Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/dp: Check if the sink crc we read is 6 bytes.

2018-04-24 Thread Dhinakaran Pandiyan
On Monday, April 23, 2018 8:25:02 PM PDT Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/i915/dp: Check if the sink crc we > read is 6 bytes. URL : https://patchwork.freedesktop.org/series/42154/ > State : failure > > == Summary == > > = CI Bug Log - changes

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-24 Thread Jani Nikula
On Mon, 23 Apr 2018, Dhinakaran Pandiyan wrote: > On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: >> On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: >> > On Fri, 20 Apr 2018, Mika Kahola wrote: >> > > >> > > On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: >> > > > >> > > > On

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-24 Thread Mika Kahola
On Fri, 2018-04-20 at 13:56 -0700, Dhinakaran Pandiyan wrote: > On Fri, 2018-04-20 at 11:15 -0700, Rodrigo Vivi wrote: > > > > On Thu, Apr 19, 2018 at 10:03:05AM +0300, Mika Kahola wrote: > > > > > > On Thu, 2018-04-19 at 09:11 +0300, Lofstedt, Marta wrote: > > > > > > > > For the PW results:  >

[Intel-gfx] [PATCH v2] drm/i915: Don't dump umpteen thousand requests

2018-04-24 Thread Chris Wilson
If we have more than a few, possibly several thousand request in the queue, don't show the central portion, just the first few and the last being executed and/or queued. The first few should be enough to help identify a problem in execution, and most often comparing the first/last in the queue is e

Re: [Intel-gfx] [PATCH v2] drm/i915/fbdev: Enable late fbdev initial configuration

2018-04-24 Thread Chris Wilson
Quoting José Roberto de Souza (2018-04-19 00:41:58) > If the initial fbdev configuration(intel_fbdev_initial_config()) runs and > there still no sink connected it will cause > drm_fb_helper_initial_config() to return 0 as no error happened(but > internally the return is -EAGAIN). > Because no frame

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't dump umpteen thousand requests (rev2)

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: Don't dump umpteen thousand requests (rev2) URL : https://patchwork.freedesktop.org/series/42151/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4083 -> Patchwork_8784 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-24 Thread Tvrtko Ursulin
On 23/04/2018 18:08, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-23 17:52:54) On 23/04/2018 14:43, Chris Wilson wrote: In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other engi

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 09:55:20) > > On 23/04/2018 18:08, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-04-23 17:52:54) > >> > >> On 23/04/2018 14:43, Chris Wilson wrote: > >>> In the existing ABI, each engine operates its own timeline > >>> (fence.context) and so should execute

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't dump umpteen thousand requests

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 09:16, Chris Wilson wrote: If we have more than a few, possibly several thousand request in the queue, don't show the central portion, just the first few and the last being executed and/or queued. The first few should be enough to help identify a problem in execution, and most ofte

Re: [Intel-gfx] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 00:16, Chris Wilson wrote: In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other engines, that should not affect execution on the local engine. v2: Move the requirements che

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't dump umpteen thousand requests

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 10:27:23) > > On 24/04/2018 09:16, Chris Wilson wrote: > > If we have more than a few, possibly several thousand request in the > > queue, don't show the central portion, just the first few and the last > > being executed and/or queued. The first few should be en

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Don't dump umpteen thousand requests (rev2)

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: Don't dump umpteen thousand requests (rev2) URL : https://patchwork.freedesktop.org/series/42151/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4083_full -> Patchwork_8784_full = == Summary - WARNING == Minor unknown changes coming

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: Only track live rings for retiring

2018-04-24 Thread Tvrtko Ursulin
On 23/04/2018 19:08, Chris Wilson wrote: We don't need to track every ring for its lifetime as they are managed by the contexts/engines. What we do want to track are the live rings so that we can sporadically clean up requests if userspace falls behind. We can simply restrict the gt->rings list

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't dump umpteen thousand requests

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 10:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-24 10:27:23) On 24/04/2018 09:16, Chris Wilson wrote: If we have more than a few, possibly several thousand request in the queue, don't show the central portion, just the first few and the last being executed and/or queu

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: Only track live rings for retiring

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 10:37:03) > > On 23/04/2018 19:08, Chris Wilson wrote: > > @@ -1403,14 +1406,17 @@ static void ring_retire_requests(struct intel_ring > > *ring) > > > > void i915_retire_requests(struct drm_i915_private *i915) > > { > > - struct intel_ring *ring, *nex

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Tvrtko Ursulin
On 23/04/2018 19:08, Chris Wilson wrote: In commit 9b6586ae9f6b ("drm/i915: Keep a global seqno per-engine"), we moved from a global inflight counter to per-engine counters in the hope that will be easy to run concurrently in future. However, with the advent of the desire to move requests betwee

Re: [Intel-gfx] [PULL] gvt-next for 4.18

2018-04-24 Thread Zhi Wang
The patch which causes conflict: --- From 2e8ea2777af45fe651dbd14b8b8e000e94467c24 Mon Sep 17 00:00:00 2001 From: Weinan Li Date: Wed, 21 Mar 2018 15:40:32 +0800 Subject: [PATCH] Revert "drm/i915/gvt: set max priority for gvt context" This reverts commit 11474e9091cf2002e948647fd9f63a7f027e488a

Re: [Intel-gfx] [CI 1/2] drm/i915: Use ktime on wait_for

2018-04-24 Thread Imre Deak
On Mon, Apr 23, 2018 at 08:35:05AM -0700, Lucas De Marchi wrote: > On Mon, Apr 23, 2018 at 4:37 AM, Mika Kuoppala > wrote: > > We use jiffies to determine when wait expires. However > > Imre did find out that jiffies can and will do a >1 > > increments on certain situations [1]. When this happens

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 11:14:21) > > On 23/04/2018 19:08, Chris Wilson wrote: > > -static int reserve_engine(struct intel_engine_cs *engine) > > +static int reserve_gt(struct drm_i915_private *i915) > > { > > - struct drm_i915_private *i915 = engine->i915; > > - u32 active =

Re: [Intel-gfx] [PATCH 06/18] drm/i915/breadcrumbs: Keep the fake irq armed across reset

2018-04-24 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-04-23 14:03:02) >> Chris Wilson writes: >> > @@ -148,6 +149,12 @@ static void intel_breadcrumbs_fake_irq(struct >> > timer_list *t) >> > if (!b->irq_armed) >> > return; >> > >> > + /* If the user has disabled the fake-

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 11:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-24 11:14:21) On 23/04/2018 19:08, Chris Wilson wrote: -static int reserve_engine(struct intel_engine_cs *engine) +static int reserve_gt(struct drm_i915_private *i915) { - struct drm_i915_private *i915 = engine->i9

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 12:17:15) > > On 24/04/2018 11:40, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-04-24 11:14:21) > >> > >> On 23/04/2018 19:08, Chris Wilson wrote: > >>> -static int reserve_engine(struct intel_engine_cs *engine) > >>> +static int reserve_gt(struct drm_i91

[Intel-gfx] [PATCH 1/2] drm/rect: Add midpoint to scale calculation functions

2018-04-24 Thread Maarten Lankhorst
When calculating limits we want to be as pessimistic as possible, so we have to explicitly say whether we want to round up or down to accurately calculate whether we are below min_scale or above max_scale. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 4 +-- drivers

[Intel-gfx] [PATCH 2/2] drm/i915: Do not adjust scale when out of bounds.

2018-04-24 Thread Maarten Lankhorst
With the previous patch drm_atomic_helper_check_plane_state correctly calculates clipping and the xf86-video-intel ddx is fixed to fall back to GPU correctly when SetPlane fails, we can remove the hack where we try to pan/zoom when out of min/max scaling range. This was already poor behavior where

[Intel-gfx] [PATCH] drm/i915: Skip printing global offsets for per-engine scratch pages

2018-04-24 Thread Chris Wilson
Knowing the offset of the per-engine scratch/HWS page during boot is not very informative, so remove the DRM_DEBUG. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_engine_cs.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu

Re: [Intel-gfx] [PATCH] drm/i915: Build request info on stack before printk

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 02:08, Chris Wilson wrote: printk unhelpfully inserts a '\n' between consecutive calls, and since our drm_printf wrapper may be emitting info a seq_file instead, KERN_CONT is not an option. To work with any drm_printf destination, we need to build up the output into a temporary buf

Re: [Intel-gfx] [PATCH] drm/i915: Build request info on stack before printk

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 12:57:41) > > On 24/04/2018 02:08, Chris Wilson wrote: > > printk unhelpfully inserts a '\n' between consecutive calls, and since > > our drm_printf wrapper may be emitting info a seq_file instead, > > KERN_CONT is not an option. To work with any drm_printf desti

Re: [Intel-gfx] [PATCH] drm/i915: Skip printing global offsets for per-engine scratch pages

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 12:52, Chris Wilson wrote: Knowing the offset of the per-engine scratch/HWS page during boot is not very informative, so remove the DRM_DEBUG. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_engine_cs.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH v2 RESEND] drm/i915: add support for specifying DMC firmware override by module param

2018-04-24 Thread Jani Nikula
Use i915.dmc_firmware_path to override default firmware for the platform and bypassing version checks. v2: add missing param struct member declaration (David) Tested-by: David Weinehall Reviewed-by: David Weinehall Cc: Anusha Srivatsa Cc: David Weinehall Signed-off-by: Jani Nikula --- drive

Re: [Intel-gfx] [PATCH v5 1/2] drm: content-type property for HDMI connector

2018-04-24 Thread Daniel Vetter
On Mon, Apr 23, 2018 at 06:44:53AM +, Lisovskiy, Stanislav wrote: > > > This table is seriously deprecated, because it's unreadable and > > unmaintainable. Quoting from the docs: > > > "Because this table is very unwieldy, do not add any new properties here. > > Instead document them in a sec

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/rect: Add midpoint to scale calculation functions

2018-04-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/rect: Add midpoint to scale calculation functions URL : https://patchwork.freedesktop.org/series/42186/ State : warning == Summary == $ dim checkpatch origin/drm-tip aca1294901eb drm/rect: Add midpoint to scale calculation functions

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Use ktime on wait_for

2018-04-24 Thread Martin Peres
On 20/04/18 19:55, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915: Use ktime on wait_for > URL : https://patchwork.freedesktop.org/series/42035/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4072_full -> Patchwork_8764_full

Re: [Intel-gfx] [PATCH] drm/i915: Build request info on stack before printk

2018-04-24 Thread Chris Wilson
Quoting Chris Wilson (2018-04-24 02:08:39) > printk unhelpfully inserts a '\n' between consecutive calls, and since > our drm_printf wrapper may be emitting info a seq_file instead, > KERN_CONT is not an option. To work with any drm_printf destination, we > need to build up the output into a tempor

Re: [Intel-gfx] [PATCH 07/18] drm/i915: Combine tasklet_kill and tasklet_disable

2018-04-24 Thread Mika Kuoppala
Chris Wilson writes: > Ideally, we want to atomically flush and disable the tasklet before > resetting the GPU. At present, we rely on being the only part to touch > our tasklet and serialisation of the reset process to ensure that we can > suspend the tasklet from the mix of reset/wedge pathways

Re: [Intel-gfx] [PATCH 07/18] drm/i915: Combine tasklet_kill and tasklet_disable

2018-04-24 Thread Chris Wilson
Quoting Mika Kuoppala (2018-04-24 13:26:11) > Chris Wilson writes: > > > Ideally, we want to atomically flush and disable the tasklet before > > resetting the GPU. At present, we rely on being the only part to touch > > our tasklet and serialisation of the reset process to ensure that we can > >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/rect: Add midpoint to scale calculation functions

2018-04-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/rect: Add midpoint to scale calculation functions URL : https://patchwork.freedesktop.org/series/42186/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4084 -> Patchwork_8785 = == Summary - SUCCESS == No regressi

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Use ktime on wait_for

2018-04-24 Thread Mika Kuoppala
Martin Peres writes: > On 20/04/18 19:55, Patchwork wrote: >> == Series Details == >> >> Series: series starting with [1/2] drm/i915: Use ktime on wait_for >> URL : https://patchwork.freedesktop.org/series/42035/ >> State : failure >> >> == Summary == >> >> = CI Bug Log - changes from CI_DRM

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip printing global offsets for per-engine scratch pages

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: Skip printing global offsets for per-engine scratch pages URL : https://patchwork.freedesktop.org/series/42187/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4084 -> Patchwork_8786 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 3/4] drm/vmwgfx: Drop DRM_CONTROL_ALLOW

2018-04-24 Thread Daniel Vetter
On Fri, Apr 20, 2018 at 07:56:34PM +0200, Thomas Hellstrom wrote: > On 04/20/2018 08:51 AM, Daniel Vetter wrote: > > Control nodes are no more! > > > > Signed-off-by: Daniel Vetter > > Cc: VMware Graphics > > Cc: Sinclair Yeh > > Cc: Thomas Hellstrom > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx

[Intel-gfx] [PATCH] drm/edid: Reset more of the display info

2018-04-24 Thread Ville Syrjala
From: Ville Syrjälä We're currently failing to reset everything in display_info.hdmi which will potentially cause us to use stale information when swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor with a HDMI 1.x monitor we will continue to think that the monitor supports scrambling.

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't dump umpteen thousand requests

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 10:40:57) > > On 24/04/2018 10:33, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-04-24 10:27:23) > >> > >> On 24/04/2018 09:16, Chris Wilson wrote: > >>> If we have more than a few, possibly several thousand request in the > >>> queue, don't show the centr

[Intel-gfx] [PATCH 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Chris Wilson
In commit 9b6586ae9f6b ("drm/i915: Keep a global seqno per-engine"), we moved from a global inflight counter to per-engine counters in the hope that will be easy to run concurrently in future. However, with the advent of the desire to move requests between engines, we do need a global counter to pr

[Intel-gfx] [PATCH 3/6] drm/i915: Only track live rings for retiring

2018-04-24 Thread Chris Wilson
We don't need to track every ring for its lifetime as they are managed by the contexts/engines. What we do want to track are the live rings so that we can sporadically clean up requests if userspace falls behind. We can simply restrict the gt->rings list to being only gt->live_rings. v2: s/live/ac

[Intel-gfx] [PATCH 4/6] drm/i915: Move timeline from GTT to ring

2018-04-24 Thread Chris Wilson
In the future, we want to move a request between engines. To achieve this, we first realise that we have two timelines in effect here. The first runs through the GTT is required for ordering vma access, which is tracked currently by engine. The second is implied by sequential execution of commands

[Intel-gfx] [PATCH 5/6] drm/i915: Split i915_gem_timeline into individual timelines

2018-04-24 Thread Chris Wilson
We need to move to a more flexible timeline that doesn't assume one fence context per engine, and so allow for a single timeline to be used across a combination of engines. This means that preallocating a fence context per engine is now a hindrance, and so we want to introduce the singular timeline

[Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Chris Wilson
In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), leading to much hilarity in miscomputing the pos

[Intel-gfx] [PATCH 6/6] drm/i915: Lazily unbind vma on close

2018-04-24 Thread Chris Wilson
When userspace is passing around swapbuffers using DRI, we frequently have to open and close the same object in the foreign address space. This shows itself as the same object being rebound at roughly 30fps (with a second object also being rebound at 30fps), which involves us having to rewrite the

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Chris Wilson
Quoting Chris Wilson (2018-04-24 14:14:11) > In the next patch, rings are the central timeline as requests may jump > between engines. Therefore in the future as we retire in order along the > engine timeline, we may retire out-of-order within a ring (as the ring now > occurs along multiple engines

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix uninitialized variable

2018-04-24 Thread Chris Wilson
Quoting Gustavo A. R. Silva (2018-04-24 14:15:45) > There is a potential execution path in which variable err is > returned without being properly initialized previously. > > Fix this by initializing variable err to 0. err is only returned along an error path, returning 0 would not be useful. Whi

Re: [Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-24 Thread Mika Kahola
On Mon, 2018-04-23 at 19:56 -0700, Dhinakaran Pandiyan wrote: > Sink crc is calculated by the sink for static frames irrespective of > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only > use > case for sink crc, we don't really need the sink_crc_{start, stop} > code. > > The seco

Re: [Intel-gfx] [PATCH 3/4] drm/vmwgfx: Drop DRM_CONTROL_ALLOW

2018-04-24 Thread Thomas Hellstrom
On 04/24/2018 03:01 PM, Daniel Vetter wrote: On Fri, Apr 20, 2018 at 07:56:34PM +0200, Thomas Hellstrom wrote: On 04/20/2018 08:51 AM, Daniel Vetter wrote: Control nodes are no more! Signed-off-by: Daniel Vetter Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom --- drivers/gpu/d

[Intel-gfx] [PATCH] drm/i915/selftests: Fix uninitialized variable

2018-04-24 Thread Gustavo A. R. Silva
There is a potential execution path in which variable err is returned without being properly initialized previously. Fix this by initializing variable err to 0. Addresses-Coverity-ID: 1468362 ("Uninitialized scalar variable") Fixes: f4ecfbfc32ed ("drm/i915: Check whitelist registers across resets

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix uninitialized variable

2018-04-24 Thread Chris Wilson
Quoting Gustavo A. R. Silva (2018-04-24 14:30:58) > > > On 04/24/2018 08:22 AM, Chris Wilson wrote: > > Quoting Gustavo A. R. Silva (2018-04-24 14:15:45) > >> There is a potential execution path in which variable err is > >> returned without being properly initialized previously. > >> > >> Fix th

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add support for specifying DMC firmware override by module param (rev3)

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: add support for specifying DMC firmware override by module param (rev3) URL : https://patchwork.freedesktop.org/series/34157/ State : warning == Summary == $ dim checkpatch origin/drm-tip c62c2ab8334b drm/i915: add support for specifying DMC firmware ove

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix uninitialized variable

2018-04-24 Thread Gustavo A. R. Silva
On 04/24/2018 08:22 AM, Chris Wilson wrote: Quoting Gustavo A. R. Silva (2018-04-24 14:15:45) There is a potential execution path in which variable err is returned without being properly initialized previously. Fix this by initializing variable err to 0. err is only returned along an error

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 12:28, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-24 12:17:15) On 24/04/2018 11:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-24 11:14:21) On 23/04/2018 19:08, Chris Wilson wrote: -static int reserve_engine(struct intel_engine_cs *engine) +static int reserv

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add support for specifying DMC firmware override by module param (rev3)

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: add support for specifying DMC firmware override by module param (rev3) URL : https://patchwork.freedesktop.org/series/34157/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4086 -> Patchwork_8787 = == Summary - SUCCESS == No regress

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 14:55:51) > > On 24/04/2018 12:28, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-04-24 12:17:15) > >> > >> On 24/04/2018 11:40, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-04-24 11:14:21) > > On 23/04/2018 19:08, Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Use ktime on wait_for

2018-04-24 Thread Mika Kuoppala
Imre Deak writes: > On Fri, Apr 20, 2018 at 11:27:55AM +0100, Chris Wilson wrote: >> Quoting Mika Kuoppala (2018-04-20 10:54:26) >> > We use jiffies to determine when wait expires. However >> > Imre did find out that jiffies can and will do a >1 >> > increments on certain situations [1]. When thi

Re: [Intel-gfx] [PATCH] drm/edid: Reset more of the display info

2018-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2018 at 04:02:50PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We're currently failing to reset everything in display_info.hdmi > which will potentially cause us to use stale information when > swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor > with a HDMI

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: Reset more of the display info

2018-04-24 Thread Patchwork
== Series Details == Series: drm/edid: Reset more of the display info URL : https://patchwork.freedesktop.org/series/42191/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4086 -> Patchwork_8788 = == Summary - SUCCESS == No regressions found. External URL: https://patc

Re: [Intel-gfx] [PATCH] drm/edid: Reset more of the display info

2018-04-24 Thread Ville Syrjälä
On Tue, Apr 24, 2018 at 04:18:37PM +0200, Daniel Vetter wrote: > On Tue, Apr 24, 2018 at 04:02:50PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We're currently failing to reset everything in display_info.hdmi > > which will potentially cause us to use stale information when > > sw

[Intel-gfx] [CI] drm/i915/breadcrumbs: Keep the fake irq armed across reset

2018-04-24 Thread Chris Wilson
Instead of synchronously cancelling the timer and re-enabling it inside the reset callbacks, keep the timer enabled and let it die on its next wakeup if no longer required. This allows intel_engine_reset_breadcrumbs() to be used from an atomic (timer/softirq) context such as required for resetting

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 14:14, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), lead

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 15:04, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-24 14:55:51) On 24/04/2018 12:28, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-24 12:17:15) On 24/04/2018 11:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-24 11:14:21) On 23/04/2018 19:08, Chris Wil

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42192/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9a8374d0cd41 drm/i915: Stop tracking timeline->inflight_seqnos -:17: ER

Re: [Intel-gfx] [PATCH v2] drm/i915/fbdev: Enable late fbdev initial configuration

2018-04-24 Thread Jani Nikula
On Tue, 24 Apr 2018, Chris Wilson wrote: > Quoting José Roberto de Souza (2018-04-19 00:41:58) >> If the initial fbdev configuration(intel_fbdev_initial_config()) runs and >> there still no sink connected it will cause >> drm_fb_helper_initial_config() to return 0 as no error happened(but >> inter

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42192/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Stop tracking timeline->inflight_seqnos -O:drivers/gpu/dr

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Tvrtko Ursulin
On 24/04/2018 15:46, Tvrtko Ursulin wrote: On 24/04/2018 14:14, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 15:46:49) > > On 24/04/2018 14:14, Chris Wilson wrote: > > In the next patch, rings are the central timeline as requests may jump > > between engines. Therefore in the future as we retire in order along the > > engine timeline, we may retire out-of-order within a

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42192/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4087 -> Patchwork_8789 = == Summary - FAILURE == Serious unknown

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/rect: Add midpoint to scale calculation functions

2018-04-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/rect: Add midpoint to scale calculation functions URL : https://patchwork.freedesktop.org/series/42186/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4084_full -> Patchwork_8785_full = == Summary - FAILURE == S

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Skip printing global offsets for per-engine scratch pages

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: Skip printing global offsets for per-engine scratch pages URL : https://patchwork.freedesktop.org/series/42187/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4084_full -> Patchwork_8786_full = == Summary - FAILURE == Serious unknown

Re: [Intel-gfx] [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type

2018-04-24 Thread Jani Nikula
On Tue, 24 Apr 2018, Luc Van Oostenryck wrote: > All implementations of the method intel_dvo_dev_ops::mode_valid(), as > well as the underlying struct drm_connector_helper_funcs::mode_valid() > use 'enum drm_mode_status' for the method's return type but the > declaration of intel_dvo_dev_ops::mode

Re: [Intel-gfx] [PATCH 1/2] drm/rect: Add midpoint to scale calculation functions

2018-04-24 Thread Ville Syrjälä
On Tue, Apr 24, 2018 at 01:36:32PM +0200, Maarten Lankhorst wrote: > When calculating limits we want to be as pessimistic as possible, > so we have to explicitly say whether we want to round up or down > to accurately calculate whether we are below min_scale or above > max_scale. > > Signed-off-by

[Intel-gfx] [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type

2018-04-24 Thread Luc Van Oostenryck
All implementations of the method intel_dvo_dev_ops::mode_valid(), as well as the underlying struct drm_connector_helper_funcs::mode_valid() use 'enum drm_mode_status' for the method's return type but the declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it. Fix this by using 'enum

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fix uninitialized variable

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix uninitialized variable URL : https://patchwork.freedesktop.org/series/42194/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4087 -> Patchwork_8790 = == Summary - SUCCESS == No regressions found. External URL: https:

Re: [Intel-gfx] [PATCH 1/2] drm/rect: Add midpoint to scale calculation functions

2018-04-24 Thread Maarten Lankhorst
Op 24-04-18 om 17:21 schreef Ville Syrjälä: > On Tue, Apr 24, 2018 at 01:36:32PM +0200, Maarten Lankhorst wrote: >> When calculating limits we want to be as pessimistic as possible, >> so we have to explicitly say whether we want to round up or down >> to accurately calculate whether we are below m

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Do not adjust scale when out of bounds.

2018-04-24 Thread Ville Syrjälä
On Tue, Apr 24, 2018 at 01:36:33PM +0200, Maarten Lankhorst wrote: > With the previous patch drm_atomic_helper_check_plane_state correctly > calculates clipping and the xf86-video-intel ddx is fixed to fall back > to GPU correctly when SetPlane fails, we can remove the hack where > we try to pan/zo

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/breadcrumbs: Keep the fake irq armed across reset (rev3)

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915/breadcrumbs: Keep the fake irq armed across reset (rev3) URL : https://patchwork.freedesktop.org/series/40825/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4087 -> Patchwork_8791 = == Summary - SUCCESS == No regressions found. Ex

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix intel_dvo_dev_ops::mode_valid's return type

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: fix intel_dvo_dev_ops::mode_valid's return type URL : https://patchwork.freedesktop.org/series/42209/ State : warning == Summary == $ dim checkpatch origin/drm-tip e19139a5a800 drm/i915: fix intel_dvo_dev_ops::mode_valid's return type -:25: CHECK:PARENTHE

Re: [Intel-gfx] [PATCH 1/2] drm/rect: Add midpoint to scale calculation functions

2018-04-24 Thread Ville Syrjälä
On Tue, Apr 24, 2018 at 05:11:37PM +0200, Maarten Lankhorst wrote: > Op 24-04-18 om 17:21 schreef Ville Syrjälä: > > On Tue, Apr 24, 2018 at 01:36:32PM +0200, Maarten Lankhorst wrote: > >> When calculating limits we want to be as pessimistic as possible, > >> so we have to explicitly say whether we

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-24 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-24 15:48:10) > > On 24/04/2018 15:04, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-04-24 14:55:51) > >> > >> On 24/04/2018 12:28, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-04-24 12:17:15) > > On 24/04/2018 11:40, Chris Wilson wrote: >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix intel_dvo_dev_ops::mode_valid's return type

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: fix intel_dvo_dev_ops::mode_valid's return type URL : https://patchwork.freedesktop.org/series/42209/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4087 -> Patchwork_8792 = == Summary - SUCCESS == No regressions found. External U

Re: [Intel-gfx] [PATCH 10/22] drm/i915/icl: Wa_1406680159 and Wa_2201832410

2018-04-24 Thread Oscar Mateo
On 04/20/2018 01:53 PM, Rodrigo Vivi wrote: On Fri, Apr 20, 2018 at 01:49:45PM -0700, Oscar Mateo wrote: On 04/20/2018 01:46 PM, Rodrigo Vivi wrote: On Fri, Apr 20, 2018 at 01:33:54PM -0700, Oscar Mateo wrote: Disable GWL clock gating to prevent two different issues that might cause hangs.

Re: [Intel-gfx] [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-24 Thread Emil Velikov
On 13 April 2018 at 11:00, Daniel Vetter wrote: > This tries to align with the X.org communities's long-standing > tradition of trying to be an inclusive community and handing out > commit rights fairly freely. > > We also tend to not revoke commit rights for people no longer > regularly active in

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add support for specifying DMC firmware override by module param (rev3)

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: add support for specifying DMC firmware override by module param (rev3) URL : https://patchwork.freedesktop.org/series/34157/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4086_full -> Patchwork_8787_full = == Summary - WARNING ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: Reset more of the display info

2018-04-24 Thread Patchwork
== Series Details == Series: drm/edid: Reset more of the display info URL : https://patchwork.freedesktop.org/series/42191/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4086_full -> Patchwork_8788_full = == Summary - WARNING == Minor unknown changes coming with Patchwor

Re: [Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-24 Thread Dhinakaran Pandiyan
On Tue, 2018-04-24 at 16:26 +0300, Mika Kahola wrote: > On Mon, 2018-04-23 at 19:56 -0700, Dhinakaran Pandiyan wrote: > > Sink crc is calculated by the sink for static frames irrespective of > > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only > > use > > case for sink crc, we do

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix uninitialized variable

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix uninitialized variable URL : https://patchwork.freedesktop.org/series/42194/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4087_full -> Patchwork_8790_full = == Summary - FAILURE == Serious unknown changes coming with

Re: [Intel-gfx] [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2018 at 7:30 PM, Emil Velikov wrote: > On 13 April 2018 at 11:00, Daniel Vetter wrote: >> This tries to align with the X.org communities's long-standing >> tradition of trying to be an inclusive community and handing out >> commit rights fairly freely. >> >> We also tend to not re

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/breadcrumbs: Keep the fake irq armed across reset (rev3)

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915/breadcrumbs: Keep the fake irq armed across reset (rev3) URL : https://patchwork.freedesktop.org/series/40825/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4087_full -> Patchwork_8791_full = == Summary - FAILURE == Serious unknown c

Re: [Intel-gfx] [PATCH] drm/edid: Reset more of the display info

2018-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2018 at 05:26:30PM +0300, Ville Syrjälä wrote: > On Tue, Apr 24, 2018 at 04:18:37PM +0200, Daniel Vetter wrote: > > On Tue, Apr 24, 2018 at 04:02:50PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > We're currently failing to reset everything in display_info.hdmi

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix uninitialized variable

2018-04-24 Thread Chris Wilson
Quoting Patchwork (2018-04-24 20:02:06) > == Series Details == > > Series: drm/i915/selftests: Fix uninitialized variable > URL : https://patchwork.freedesktop.org/series/42194/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4087_full -> Patchwork_8790_full = > > =

Re: [Intel-gfx] [PATCH v8 01/10] drm/atomic: Print debug message on atomic check failure

2018-04-24 Thread Dhinakaran Pandiyan
On Wed, 2018-04-11 at 19:42 -0400, Lyude Paul wrote: > Does what it says on the label, it's a little confusing debugging atomic > check failures otherwise. > > Cc: Manasi Navare > Cc: Ville Syrjälä > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/drm_atomic.c | 5 - > 1 file changed,

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix uninitialized variable

2018-04-24 Thread Gustavo A. R. Silva
On 04/24/2018 02:42 PM, Chris Wilson wrote: Quoting Patchwork (2018-04-24 20:02:06) == Series Details == Series: drm/i915/selftests: Fix uninitialized variable URL : https://patchwork.freedesktop.org/series/42194/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4087_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: fix intel_dvo_dev_ops::mode_valid's return type

2018-04-24 Thread Patchwork
== Series Details == Series: drm/i915: fix intel_dvo_dev_ops::mode_valid's return type URL : https://patchwork.freedesktop.org/series/42209/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4087_full -> Patchwork_8792_full = == Summary - FAILURE == Serious unknown changes c

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Check if the sink crc we read is 6 bytes.

2018-04-24 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 07:56:57PM -0700, Dhinakaran Pandiyan wrote: > We attempt to read 6 bytes, make sure we have. > > Signed-off-by: Dhinakaran Pandiyan Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [Intel-gfx] [PATCH 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-24 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 07:56:58PM -0700, Dhinakaran Pandiyan wrote: > Sink crc is calculated by the sink for static frames irrespective of > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only use > case for sink crc, we don't really need the sink_crc_{start, stop} code. > > The s

Re: [Intel-gfx] [PATCH 3/3] drm/i915/psr: Move sink-crc to intel_psr.c

2018-04-24 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 07:56:59PM -0700, Dhinakaran Pandiyan wrote: > With sink-crc now being relevant only for PSR static frames, move the > code to intel_psr.c and rename the function. > > Signed-off-by: Dhinakaran Pandiyan Acked-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_debugfs.

  1   2   >