[Intel-gfx] [PATCH v7 2/2] i915: content-type property for HDMI connector

2018-04-23 Thread StanLis
From: Stanislav Lisovskiy Added encoding of drm content_type property from drm_connector_state within AVI infoframe in order to properly handle external HDMI TV content-type setting. This requires also manipulationg ITC bit, as stated in HDMI spec. v2: * Moved helper function which attaches co

[Intel-gfx] [PATCH v7 1/2] drm: content-type property for HDMI connector

2018-04-23 Thread StanLis
From: Stanislav Lisovskiy Added content_type property to drm_connector_state in order to properly handle external HDMI TV content-type setting. v2: * Moved helper function which attaches content type property to the drm core, as was suggested. Removed redundant connector state initializat

[Intel-gfx] [PATCH v7 0/2] Enabling content-type setting for HDMI displays.

2018-04-23 Thread StanLis
From: Stanislav Lisovskiy Added content type setting property to drm_connector(part 1) and enabled transmitting it with HDMI AVI infoframes for i915(part 2). Stanislav Lisovskiy (2): drm: content-type property for HDMI connector i915: content-type property for HDMI connector Documentation/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enabling content-type setting for HDMI displays. (rev6)

2018-04-23 Thread Patchwork
== Series Details == Series: Enabling content-type setting for HDMI displays. (rev6) URL : https://patchwork.freedesktop.org/series/41876/ State : warning == Summary == $ dim checkpatch origin/drm-tip f891f01659af drm: content-type property for HDMI connector -:127: CHECK:LINE_SPACING: Please

Re: [Intel-gfx] [PATCH] drm/i915/psr : Add psr1 live status

2018-04-23 Thread vathsala nagaraju
On Saturday 21 April 2018 09:30 AM, Nagaraju, Vathsala wrote: -Original Message- From: Vivi, Rodrigo Sent: Friday, April 20, 2018 11:06 PM To: Nagaraju, Vathsala Cc: intel-gfx@lists.freedesktop.org; Pandiyan, Dhinakaran Subject: Re: [PATCH] drm/i915/psr : Add psr1 live status On Fri,

[Intel-gfx] ✓ Fi.CI.BAT: success for Enabling content-type setting for HDMI displays. (rev6)

2018-04-23 Thread Patchwork
== Series Details == Series: Enabling content-type setting for HDMI displays. (rev6) URL : https://patchwork.freedesktop.org/series/41876/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4075 -> Patchwork_8770 = == Summary - SUCCESS == No regressions found. External URL

[Intel-gfx] [PULL] gvt-next for 4.18

2018-04-23 Thread Zhi Wang
The following changes since commit fadec6eefe232696c5c471b40df33e6db616e854: drm/i915: Update DRIVER_DATE to 20180413 (2018-04-13 12:20:58 +0300) are available in the git repository at: https://github.com/intel/gvt-linux.git tags/gvt-next-2018-04-23 for you to fetch changes up to 3eda0d22e

Re: [Intel-gfx] [PULL] gvt-next for 4.18

2018-04-23 Thread Zhi Wang
Hi Jani: I picked out the patch which causes conflicts and may put it back in the next back merge from drm-intel-next to gvt-next. So there shouldn't be any conflict in this pull. Thanks for your efforts. Thanks, Zhi. On 04/23/18 16:11, Zhi Wang wrote: The following changes since commit fad

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Drop DRM_CONTROL_ALLOW

2018-04-23 Thread Joonas Lahtinen
Quoting Daniel Vetter (2018-04-20 09:51:57) > Control nodes are no more! > > Signed-off-by: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-gfx@lists.freedesktop.org Reviewed-by: Joonas Lahtinen Regards, Joonas ___

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only build INTEL_GTT on 32-bit x86

2018-04-23 Thread kbuild test robot
Hi Adam, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.17-rc2 next-20180423] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Retire requests along rings

2018-04-23 Thread Tvrtko Ursulin
On 20/04/2018 14:20, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), lead

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Retire requests along rings

2018-04-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-23 09:47:57) > > On 20/04/2018 14:20, Chris Wilson wrote: > > void i915_retire_requests(struct drm_i915_private *i915) > > { > > - struct intel_engine_cs *engine; > > - enum intel_engine_id id; > > + struct intel_ring *ring, *next; > > > > l

Re: [Intel-gfx] [PATCH] drm/hisilicon/hibmc: Using module_pci_driver.

2018-04-23 Thread xinliang
On 2018/4/21 17:51, YueHaibing wrote: Remove boilerplate code by using macro module_pci_driver. Signed-off-by: YueHaibing Thanks Haibing, Reviewed-by: Xinliang Liu Xinliang --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 + 1 file changed, 1 insertion(+), 12 dele

[Intel-gfx] [PATCH] drm/hisilicon/hibmc: Using module_pci_driver.

2018-04-23 Thread YueHaibing
Remove boilerplate code by using macro module_pci_driver. Signed-off-by: YueHaibing --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/h

[Intel-gfx] ✓ Fi.CI.IGT: success for Enabling content-type setting for HDMI displays. (rev6)

2018-04-23 Thread Patchwork
== Series Details == Series: Enabling content-type setting for HDMI displays. (rev6) URL : https://patchwork.freedesktop.org/series/41876/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4075_full -> Patchwork_8770_full = == Summary - WARNING == Minor unknown changes comin

[Intel-gfx] [PATCH i-g-t v3 0/4] trace.pl fixes

2018-04-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Remaining unreviewed (and one almost reviewed) patches to fix known outstanding issues in trace.pl and improve its request split mode. This will be useful for Virtual Engine development which is currently ongoing. Tvrtko Ursulin (4): trace.pl: Add support for colouring co

[Intel-gfx] [PATCH i-g-t 1/4] trace.pl: Add support for colouring context execution

2018-04-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add the command line switch which uses different colours for different context execution boxes. v2: * Use HSL to simplify color generation. (Lionel) * Colour other boxes in the same colour but different shade so it is easier to follow the timeline. Signed-off-by: Tvrtk

[Intel-gfx] [PATCH i-g-t 2/4] trace.pl: Fix engine busy accounting in split mode

2018-04-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In split mode all requests have to be added up since they were previously re-arranged so there is no overlap. Signed-off-by: Tvrtko Ursulin Cc: John Harrison --- scripts/trace.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/trace.pl b/scri

[Intel-gfx] [PATCH i-g-t 3/4] trace.pl: Fix incomplete request handling

2018-04-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Incomplete requests (no notify, no context complete) have to be corrected by looking at the engine timeline, and not the sorted-by-start-time view as was previously used. Per-engine timelines are generated on demand and cached for later use. v2: Find end of current context

[Intel-gfx] [PATCH i-g-t 4/4] trace.pl: Fix request split mode

2018-04-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Request split mode had several bugs, both in the original version and also after the recent refactorings. One big one was that it wasn't considering different submit ports as a reason to split execution, and also that it was too time based instead of looking at relevant time

Re: [Intel-gfx] [PATCH v11 06/11] drm: Add DRM client cap for aspect-ratio

2018-04-23 Thread Ville Syrjälä
On Mon, Apr 23, 2018 at 10:43:47AM +0530, Nautiyal, Ankit K wrote: > > > On 4/20/2018 7:37 PM, Ville Syrjälä wrote: > > On Fri, Apr 20, 2018 at 07:01:46PM +0530, Nautiyal, Ankit K wrote: > >> From: Ankit Nautiyal > >> > >> To enable aspect-ratio support in DRM, blindly exposing the aspect > >> r

Re: [Intel-gfx] [PATCH v11 07/11] drm: Add helper functions to handle aspect-ratio flag bits

2018-04-23 Thread Ville Syrjälä
On Mon, Apr 23, 2018 at 10:55:54AM +0530, Nautiyal, Ankit K wrote: > > > On 4/20/2018 7:42 PM, Ville Syrjälä wrote: > > On Fri, Apr 20, 2018 at 07:01:47PM +0530, Nautiyal, Ankit K wrote: > >> From: Ankit Nautiyal > >> > >> This patch adds helper functions for determining if aspect-ratio is > >>

[Intel-gfx] [PATCH 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Chris Wilson
In commit 9b6586ae9f6b ("drm/i915: Keep a global seqno per-engine"), we moved from a global inflight counter to per-engine counters in the hope that will be easy to run concurrently in future. However, with the advent of the desire to move requests between engines, we do need a global counter to pr

[Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-23 Thread Chris Wilson
In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), leading to much hilarity in miscomputing the pos

[Intel-gfx] [PATCH 6/6] drm/i915: Lazily unbind vma on close

2018-04-23 Thread Chris Wilson
When userspace is passing around swapbuffers using DRI, we frequently have to open and close the same object in the foreign address space. This shows itself as the same object being rebound at roughly 30fps (with a second object also being rebound at 30fps), which involves us having to rewrite the

[Intel-gfx] [PATCH 5/6] drm/i915: Split i915_gem_timeline into individual timelines

2018-04-23 Thread Chris Wilson
We need to move to a more flexible timeline that doesn't assume one fence context per engine, and so allow for a single timeline to be used across a combination of engines. This means that preallocating a fence context per engine is now a hindrance, and so we want to introduce the singular timeline

[Intel-gfx] [PATCH 3/6] drm/i915: Only track live rings for retiring

2018-04-23 Thread Chris Wilson
We don't need to track every ring for its lifetime as they are managed by the contexts/engines. What we do want to track are the live rings so that we can sporadically clean up requests if userspace falls behind. We can simply restrict the gt->rings list to being only gt->live_rings. Suggested-by:

[Intel-gfx] [PATCH 4/6] drm/i915: Move timeline from GTT to ring

2018-04-23 Thread Chris Wilson
In the future, we want to move a request between engines. To achieve this, we first realise that we have two timelines in effect here. The first runs through the GTT is required for ordering vma access, which is tracked currently by engine. The second is implied by sequential execution of commands

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Retire requests along rings

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 10:06, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-23 09:47:57) On 20/04/2018 14:20, Chris Wilson wrote: void i915_retire_requests(struct drm_i915_private *i915) { - struct intel_engine_cs *engine; - enum intel_engine_id id; + struct intel_ring *ring,

Re: [Intel-gfx] [PATCH v11 09/11] drm: Expose modes with aspect ratio, only if requested

2018-04-23 Thread Ville Syrjälä
On Mon, Apr 23, 2018 at 11:19:08AM +0530, Nautiyal, Ankit K wrote: > > > On 4/20/2018 7:52 PM, Ville Syrjälä wrote: > > On Fri, Apr 20, 2018 at 07:01:49PM +0530, Nautiyal, Ankit K wrote: > >> From: Ankit Nautiyal > >> > >> We parse the EDID and add all the modes in the connector's modelist. > >>

Re: [Intel-gfx] [PATCH v11 07/11] drm: Add helper functions to handle aspect-ratio flag bits

2018-04-23 Thread Jani Nikula
On Mon, 23 Apr 2018, "Nautiyal, Ankit K" wrote: > On 4/20/2018 7:42 PM, Ville Syrjälä wrote: >> On Fri, Apr 20, 2018 at 07:01:47PM +0530, Nautiyal, Ankit K wrote: >>> From: Ankit Nautiyal >>> +bool >>> +drm_mode_aspect_ratio_allowed(const struct drm_file *file_priv, >>> +

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Retire requests along rings

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 11:13, Chris Wilson wrote: In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), lead

Re: [Intel-gfx] [PULL] gvt-next for 4.18

2018-04-23 Thread Jani Nikula
On Mon, 23 Apr 2018, Zhi Wang wrote: > Hi Jani: > > I picked out the patch which causes conflicts and may put it back in the > next back merge from drm-intel-next to gvt-next. So there shouldn't be > any conflict in this pull. Thanks for your efforts. Thanks, pulled to drm-intel-next-queued. J

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Only track live rings for retiring

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 11:13, Chris Wilson wrote: We don't need to track every ring for its lifetime as they are managed by the contexts/engines. What we do want to track are the live rings so that we can sporadically clean up requests if userspace falls behind. We can simply restrict the gt->rings list

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Only track live rings for retiring

2018-04-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-23 11:25:54) > > On 23/04/2018 11:13, Chris Wilson wrote: > > We don't need to track every ring for its lifetime as they are managed > > by the contexts/engines. What we do want to track are the live rings so > > that we can sporadically clean up requests if userspa

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Move timeline from GTT to ring

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 11:13, Chris Wilson wrote: In the future, we want to move a request between engines. To achieve this, we first realise that we have two timelines in effect here. The first runs through the GTT is required for ordering vma access, which is tracked currently by engine. The second is

[Intel-gfx] [PATCH] drm/i915: Remove src adjustment in intel_check_sprite_plane.

2018-04-23 Thread Maarten Lankhorst
The rounding can cause a perfectly normal 16x16 src to full-screen dst to be rounded down, even without clipping involved. Because of this we should just remove the adjustment, as no other driver or plane does it. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_sprite.c | 5 -

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Only track live rings for retiring

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 11:36, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-23 11:25:54) On 23/04/2018 11:13, Chris Wilson wrote: We don't need to track every ring for its lifetime as they are managed by the contexts/engines. What we do want to track are the live rings so that we can sporadicall

[Intel-gfx] [CI 1/2] drm/i915: Use ktime on wait_for

2018-04-23 Thread Mika Kuoppala
We use jiffies to determine when wait expires. However Imre did find out that jiffies can and will do a >1 increments on certain situations [1]. When this happens in a wait_for loop, we return timeout errorneously much earlier than what the real wallclock would say. We can't afford our waits to ti

[Intel-gfx] [CI 2/2] drm/i915: Add compiler barrier to wait_for

2018-04-23 Thread Mika Kuoppala
We need to be careful to not let compiler evaluate the expiration and the operation on it's terms. Document and enforce that COND will be evaluated before checking timeout expiration. Suggested-by: Chris Wilson Cc: Chris Wilson Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson --- drive

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v6] intel-gpu-top: Rewrite the tool to be safe to use

2018-04-23 Thread Rinat Ibragimov
Ping? >Понедельник, 9 апреля 2018, 15:26 +03:00 от Tvrtko Ursulin >: > > >[Adding some people to Cc for more ack/nack type feedback.] > >Executive question is ack or nack on replacing intel_gpu_top with a new >implementation which uses only perf PMU for counter gathering. > >A short history on

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Split i915_gem_timeline into individual timelines

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 11:13, Chris Wilson wrote: We need to move to a more flexible timeline that doesn't assume one fence context per engine, and so allow for a single timeline to be used across a combination of engines. This means that preallocating a fence context per engine is now a hindrance, and s

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Move timeline from GTT to ring

2018-04-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-23 11:44:19) > > On 23/04/2018 11:13, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/i915_gem.c > > b/drivers/gpu/drm/i915/i915_gem.c > > index 0097a77fae8d..1635975dbc16 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++ b/drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Split i915_gem_timeline into individual timelines

2018-04-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-23 13:33:04) > > On 23/04/2018 11:13, Chris Wilson wrote: > > We need to move to a more flexible timeline that doesn't assume one > > fence context per engine, and so allow for a single timeline to be used > > across a combination of engines. This means that preallo

Re: [Intel-gfx] [PATCH 06/18] drm/i915/breadcrumbs: Keep the fake irq armed across reset

2018-04-23 Thread Mika Kuoppala
Chris Wilson writes: > Instead of synchronously cancelling the timer and re-enabling it inside > the reset callbacks, keep the timer enabled and let it die on its next > wakeup if no longer required. This allows > intel_engine_reset_breadcrumbs() to be used from an atomic > (timer/softirq) contex

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Lazily unbind vma on close

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 11:14, Chris Wilson wrote: When userspace is passing around swapbuffers using DRI, we frequently have to open and close the same object in the foreign address space. This shows itself as the same object being rebound at roughly 30fps (with a second object also being rebound at 30fp

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/hisilicon/hibmc: Using module_pci_driver.

2018-04-23 Thread Patchwork
== Series Details == Series: drm/hisilicon/hibmc: Using module_pci_driver. URL : https://patchwork.freedesktop.org/series/42103/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4078 -> Patchwork_8771 = == Summary - SUCCESS == No regressions found. External URL: https:/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42111/ State : warning == Summary == $ dim checkpatch origin/drm-tip cdd8eb08a9de drm/i915: Stop tracking timeline->inflight_seqnos -:14: ER

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42111/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Stop tracking timeline->inflight_seqnos -O:drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42111/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4078 -> Patchwork_8772 = == Summary - FAILURE == Serious unknown

[Intel-gfx] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Chris Wilson
In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other engines, that should not affect execution on the local engine. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/gem_exec_sche

Re: [Intel-gfx] [PATCH v7 1/2] drm: content-type property for HDMI connector

2018-04-23 Thread Lisovskiy, Stanislav
Ping From: Intel-gfx [intel-gfx-boun...@lists.freedesktop.org] on behalf of StanLis [stanislav.lisovs...@intel.com] Sent: Monday, April 23, 2018 10:34 AM To: dri-de...@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v7

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Chris Wilson
Quoting Patchwork (2018-04-23 14:40:51) > igt@core_auth@basic-auth: > fi-glk-j4005: PASS -> INCOMPLETE (k.org#198133, fdo#103359) > fi-bdw-gvtdvm: PASS -> INCOMPLETE (fdo#105600) > fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927) > fi-cnl-psr: PASS

Re: [Intel-gfx] [PATCH] drm: Don't pass the index to drm_property_add_enum()

2018-04-23 Thread Lisovskiy, Stanislav
Acked-by: Stanislav Lisovskiy Best Regards, Lisovskiy Stanislav Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo> From: Ville Syrjala [ville.syrj...@linux.intel.com] Sent: Friday, March 16, 2018 9:04 PM To: dri-de...@lists.f

Re: [Intel-gfx] [v2] drm/i915/fbdev: Enable late fbdev initial configuration

2018-04-23 Thread Jani Nikula
On Fri, 20 Apr 2018, Paul Menzel wrote: > Dear Jose, > > > On 04/19/18 01:41, Souza, Jose wrote: >> If the initial fbdev configuration(intel_fbdev_initial_config()) runs and > > Nit: Space before (. > >> there still no sink connected it will cause >> drm_fb_helper_initial_config() to return 0 as n

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove src adjustment in intel_check_sprite_plane.

2018-04-23 Thread Patchwork
== Series Details == Series: drm/i915: Remove src adjustment in intel_check_sprite_plane. URL : https://patchwork.freedesktop.org/series/42113/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4078 -> Patchwork_8773 = == Summary - SUCCESS == No regressions found. Externa

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Use ktime on wait_for

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Use ktime on wait_for URL : https://patchwork.freedesktop.org/series/42115/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4078 -> Patchwork_8774 = == Summary - SUCCESS == No regressions found. Extern

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Don't pass the index to drm_property_add_enum() (rev2)

2018-04-23 Thread Patchwork
== Series Details == Series: drm: Don't pass the index to drm_property_add_enum() (rev2) URL : https://patchwork.freedesktop.org/series/40122/ State : failure == Summary == Applying: drm: Don't pass the index to drm_property_add_enum() error: patch failed: drivers/gpu/drm/drm_connector.c:1069

Re: [Intel-gfx] [PATCH] drm/i915: Remove src adjustment in intel_check_sprite_plane.

2018-04-23 Thread Ville Syrjälä
On Mon, Apr 23, 2018 at 12:49:22PM +0200, Maarten Lankhorst wrote: > The rounding can cause a perfectly normal 16x16 src to full-screen > dst to be rounded down, even without clipping involved. Because of > this we should just remove the adjustment, as no other driver or plane > does it. > > Signe

Re: [Intel-gfx] [PATCH] drm/i915: Remove src adjustment in intel_check_sprite_plane.

2018-04-23 Thread Maarten Lankhorst
Op 23-04-18 om 16:30 schreef Ville Syrjälä: > On Mon, Apr 23, 2018 at 12:49:22PM +0200, Maarten Lankhorst wrote: >> The rounding can cause a perfectly normal 16x16 src to full-screen >> dst to be rounded down, even without clipping involved. Because of >> this we should just remove the adjustment,

Re: [Intel-gfx] [PATCH 06/18] drm/i915/breadcrumbs: Keep the fake irq armed across reset

2018-04-23 Thread Chris Wilson
Quoting Mika Kuoppala (2018-04-23 14:03:02) > Chris Wilson writes: > > @@ -148,6 +149,12 @@ static void intel_breadcrumbs_fake_irq(struct > > timer_list *t) > > if (!b->irq_armed) > > return; > > > > + /* If the user has disabled the fake-irq, restore the hangchecking */

Re: [Intel-gfx] [PATCH] drm/i915: Remove src adjustment in intel_check_sprite_plane.

2018-04-23 Thread Ville Syrjälä
On Mon, Apr 23, 2018 at 04:39:54PM +0200, Maarten Lankhorst wrote: > Op 23-04-18 om 16:30 schreef Ville Syrjälä: > > On Mon, Apr 23, 2018 at 12:49:22PM +0200, Maarten Lankhorst wrote: > >> The rounding can cause a perfectly normal 16x16 src to full-screen > >> dst to be rounded down, even without c

Re: [Intel-gfx] [CI 1/2] drm/i915: Use ktime on wait_for

2018-04-23 Thread Lucas De Marchi
On Mon, Apr 23, 2018 at 4:37 AM, Mika Kuoppala wrote: > We use jiffies to determine when wait expires. However > Imre did find out that jiffies can and will do a >1 > increments on certain situations [1]. When this happens > in a wait_for loop, we return timeout errorneously > much earlier than wh

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Antonio Argenziano
On 23/04/18 06:43, Chris Wilson wrote: In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other engines, that should not affect execution on the local engine. Signed-off-by: Chris Wilson C

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Chris Wilson
Quoting Antonio Argenziano (2018-04-23 16:37:17) > > > On 23/04/18 06:43, Chris Wilson wrote: > > In the existing ABI, each engine operates its own timeline > > (fence.context) and so should execute independently of any other. If we > > install a blocker on all other engines, that should not affe

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Antonio Argenziano
On 23/04/18 08:51, Chris Wilson wrote: Quoting Antonio Argenziano (2018-04-23 16:37:17) On 23/04/18 06:43, Chris Wilson wrote: In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other en

Re: [Intel-gfx] [PULL] gvt-next for 4.18

2018-04-23 Thread Zhi Wang
Thanks! :) On 04/23/18 18:25, Jani Nikula wrote: On Mon, 23 Apr 2018, Zhi Wang wrote: Hi Jani: I picked out the patch which causes conflicts and may put it back in the next back merge from drm-intel-next to gvt-next. So there shouldn't be any conflict in this pull. Thanks for your efforts.

[Intel-gfx] 4.17-rc2: Could not determine valid watermarks for inherited state

2018-04-23 Thread Dave Jones
This warning just started appearing during boot on a machine I upgraded to 4.17-rc2. The warning seems to have been there since 2015, but it has never triggered before today. Dave [1.158500] fb: switching to inteldrmfb from EFI VGA [1.159073] Console: switching to colour dummy de

[Intel-gfx] [PATCH v11 2/3] drm/i915: Implement WaProgramMgsrForL3BankSpecificMmioReads

2018-04-23 Thread Yunwei Zhang
L3Bank could be fused off in hardware for debug purpose, and it is possible that subslice is enabled while its corresponding L3Bank pairs are disabled. In such case, if MCR packet control register(0xFDC) is programed to point to a disabled bank pair, a MMIO read into L3Bank range will return 0 inst

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Tvrtko Ursulin
On 23/04/2018 14:43, Chris Wilson wrote: In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other engines, that should not affect execution on the local engine. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [igt-dev] [PATCH igt] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-23 17:52:54) > > On 23/04/2018 14:43, Chris Wilson wrote: > > In the existing ABI, each engine operates its own timeline > > (fence.context) and so should execute independently of any other. If we > > install a blocker on all other engines, that should not affect ex

[Intel-gfx] [PATCH v2 6/6] drm/i915: Lazily unbind vma on close

2018-04-23 Thread Chris Wilson
When userspace is passing around swapbuffers using DRI, we frequently have to open and close the same object in the foreign address space. This shows itself as the same object being rebound at roughly 30fps (with a second object also being rebound at 30fps), which involves us having to rewrite the

[Intel-gfx] [PATCH v2 3/6] drm/i915: Only track live rings for retiring

2018-04-23 Thread Chris Wilson
We don't need to track every ring for its lifetime as they are managed by the contexts/engines. What we do want to track are the live rings so that we can sporadically clean up requests if userspace falls behind. We can simply restrict the gt->rings list to being only gt->live_rings. v2: s/live/ac

[Intel-gfx] [PATCH v2 5/6] drm/i915: Split i915_gem_timeline into individual timelines

2018-04-23 Thread Chris Wilson
We need to move to a more flexible timeline that doesn't assume one fence context per engine, and so allow for a single timeline to be used across a combination of engines. This means that preallocating a fence context per engine is now a hindrance, and so we want to introduce the singular timeline

[Intel-gfx] [PATCH v2 2/6] drm/i915: Retire requests along rings

2018-04-23 Thread Chris Wilson
In the next patch, rings are the central timeline as requests may jump between engines. Therefore in the future as we retire in order along the engine timeline, we may retire out-of-order within a ring (as the ring now occurs along multiple engines), leading to much hilarity in miscomputing the pos

[Intel-gfx] [PATCH v2 1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Chris Wilson
In commit 9b6586ae9f6b ("drm/i915: Keep a global seqno per-engine"), we moved from a global inflight counter to per-engine counters in the hope that will be easy to run concurrently in future. However, with the advent of the desire to move requests between engines, we do need a global counter to pr

[Intel-gfx] [PATCH v2 4/6] drm/i915: Move timeline from GTT to ring

2018-04-23 Thread Chris Wilson
In the future, we want to move a request between engines. To achieve this, we first realise that we have two timelines in effect here. The first runs through the GTT is required for ordering vma access, which is tracked currently by engine. The second is implied by sequential execution of commands

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/hisilicon/hibmc: Using module_pci_driver.

2018-04-23 Thread Patchwork
== Series Details == Series: drm/hisilicon/hibmc: Using module_pci_driver. URL : https://patchwork.freedesktop.org/series/42103/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4078_full -> Patchwork_8771_full = == Summary - WARNING == Minor unknown changes coming with Pat

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove src adjustment in intel_check_sprite_plane.

2018-04-23 Thread Patchwork
== Series Details == Series: drm/i915: Remove src adjustment in intel_check_sprite_plane. URL : https://patchwork.freedesktop.org/series/42113/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4078_full -> Patchwork_8773_full = == Summary - WARNING == Minor unknown changes

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42139/ State : warning == Summary == $ dim checkpatch origin/drm-tip b1a184759165 drm/i915: Stop tracking timeline->inflight_seqnos -:17:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Use ktime on wait_for

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Use ktime on wait_for URL : https://patchwork.freedesktop.org/series/42115/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4078_full -> Patchwork_8774_full = == Summary - WARNING == Minor unknown changes

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42139/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Stop tracking timeline->inflight_seqnos -O:drivers/gpu

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42139/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4079 -> Patchwork_8776 = == Summary - FAILURE == Serious unkn

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-23 Thread Dhinakaran Pandiyan
On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: > On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: > > On Fri, 20 Apr 2018, Mika Kahola wrote: > > > > > > On Thu, 2018-04-19 at 17:09 +0300, Jani Nikula wrote: > > > > > > > > On Wed, 18 Apr 2018, Mika Kahola wrote: > > > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-23 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 12:21:39PM -0700, Dhinakaran Pandiyan wrote: > > > > On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: > > On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: > > > On Fri, 20 Apr 2018, Mika Kahola wrote: > > > > > > > > On Thu, 2018-04-19 at 17:09 +0300, Jani Nik

Re: [Intel-gfx] [PATCH v11 2/3] drm/i915: Implement WaProgramMgsrForL3BankSpecificMmioReads

2018-04-23 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 09:12:46AM -0700, Yunwei Zhang wrote: > L3Bank could be fused off in hardware for debug purpose, and it > is possible that subslice is enabled while its corresponding L3Bank pairs > are disabled. In such case, if MCR packet control register(0xFDC) is > programed to point to

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-23 Thread Dhinakaran Pandiyan
On Mon, 2018-04-23 at 12:34 -0700, Rodrigo Vivi wrote: > On Mon, Apr 23, 2018 at 12:21:39PM -0700, Dhinakaran Pandiyan wrote: > > > > > > > > On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: > > > On Fri, 2018-04-20 at 11:22 +0300, Jani Nikula wrote: > > > > On Fri, 20 Apr 2018, Mika Kah

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after register read

2018-04-23 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 01:24:39PM -0700, Dhinakaran Pandiyan wrote: > > > > On Mon, 2018-04-23 at 12:34 -0700, Rodrigo Vivi wrote: > > On Mon, Apr 23, 2018 at 12:21:39PM -0700, Dhinakaran Pandiyan wrote: > > > > > > > > > > > > On Fri, 2018-04-20 at 14:15 +0300, Mika Kahola wrote: > > > > On

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42139/ State : warning == Summary == $ dim checkpatch origin/drm-tip 397f93096828 drm/i915: Stop tracking timeline->inflight_seqnos -:17:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42139/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Stop tracking timeline->inflight_seqnos -O:drivers/gpu

[Intel-gfx] [PATCH igt v2] test/gem_exec_schedule: Check each engine is an independent timeline

2018-04-23 Thread Chris Wilson
In the existing ABI, each engine operates its own timeline (fence.context) and so should execute independently of any other. If we install a blocker on all other engines, that should not affect execution on the local engine. v2: Move the requirements checks from the fixture to subtest so that the

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos

2018-04-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915: Stop tracking timeline->inflight_seqnos URL : https://patchwork.freedesktop.org/series/42139/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4081 -> Patchwork_8777 = == Summary - FAILURE == Serious unkn

Re: [Intel-gfx] [PATCH v11 2/3] drm/i915: Implement WaProgramMgsrForL3BankSpecificMmioReads

2018-04-23 Thread Zhang, Yunwei
Sorry, I added a debug patch when submitting to trybot and forgot to remove that from my local branch. I will resubmit to a new series. Yunwei On 4/23/2018 12:55 PM, Rodrigo Vivi wrote: On Mon, Apr 23, 2018 at 09:12:46AM -0700, Yunwei Zhang wrote: L3Bank could be fused off in hardware for de

[Intel-gfx] UHD 620: How to debug a screen resolution that does not work reliably

2018-04-23 Thread Ricardo Ribalda Delgado
Hi I have a secondary monitor connected via USB-C adapter to HDMI. It can manage resolutions up to 2560x1440. Most of the time, when the system is booted the resolution is detected ok, but If I suspend the machine, or replug the screen, or alternate to the text console, the resolution is "downgr

[Intel-gfx] [PATCH] drm/i915/kbl: Add KBL GT2 sku

2018-04-23 Thread matthew . s . atwood
From: Matt Atwood Adding a missing GT2 sku discovered off hardware. Signed-off-by: Matt Atwood --- include/drm/i915_pciids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 70f0c25..a58a548 100644 --- a/include/drm/i915_pciids.h +

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Add KBL GT2 sku

2018-04-23 Thread Clint Taylor
On 04/23/2018 03:01 PM, matthew.s.atw...@intel.com wrote: From: Matt Atwood Adding a missing GT2 sku discovered off hardware. Signed-off-by: Matt Atwood --- include/drm/i915_pciids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h

[Intel-gfx] [PATCH] drm/i915/kbl: Add KBL GT2 sku

2018-04-23 Thread matthew . s . atwood
From: Matt Atwood Adding a missing GT2 sku discovered off hardware. Signed-off-by: Matt Atwood Reviewed-by: Clint Taylor --- include/drm/i915_pciids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 70f0c25..bab70ff 100644 --- a/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/kbl: Add KBL GT2 sku

2018-04-23 Thread Patchwork
== Series Details == Series: drm/i915/kbl: Add KBL GT2 sku URL : https://patchwork.freedesktop.org/series/42144/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4081 -> Patchwork_8778 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freed

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/kbl: Add KBL GT2 sku (rev2)

2018-04-23 Thread Patchwork
== Series Details == Series: drm/i915/kbl: Add KBL GT2 sku (rev2) URL : https://patchwork.freedesktop.org/series/42144/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4081 -> Patchwork_8779 = == Summary - SUCCESS == No regressions found. External URL: https://patchwor

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Add KBL GT2 sku

2018-04-23 Thread Rodrigo Vivi
On Mon, Apr 23, 2018 at 03:28:03PM -0700, matthew.s.atw...@intel.com wrote: > From: Matt Atwood > > Adding a missing GT2 sku discovered off hardware. > > Signed-off-by: Matt Atwood > Reviewed-by: Clint Taylor pushed to dinq, thanks for patch and review. > --- > include/drm/i915_pciids.h | 1

  1   2   >