[Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-03-29 Thread Yang
From: Yang Shi snd_hdac driver would use the component interface from i915 driver. if i915 driver do the audio component intialization too late, snd_hdac driver will meet ipanic. Signed-off-by: Bo He Signed-off-by: Yang Shi --- drivers/gpu/drm/i915/i915_drv.c | 2 -- drivers/gpu/drm/i915

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: warn only once about ddi translation table missing

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915: warn only once about ddi translation table missing URL : https://patchwork.freedesktop.org/series/40833/ State : success == Summary == Known issues: Test kms_cursor_crc: Subgroup cursor-64x64-suspend: incomplete -> PASS

Re: [Intel-gfx] [RFC v1] Data port coherency control for UMDs.

2018-03-29 Thread Joonas Lahtinen
Quoting Dunajski, Bartosz (2018-03-26 12:46:13) > Here is pull request with patch usage: > https://github.com/intel/compute-runtime/pull/29 > > This patch is required to control data port coherency depending on incoming > workload into OpenCL API (fine-grain SVM requirement). Thank you for corr

[Intel-gfx] ✓ Fi.CI.IGT: success for ICL PLLs, DP/HDMI and misc display (rev5)

2018-03-29 Thread Patchwork
== Series Details == Series: ICL PLLs, DP/HDMI and misc display (rev5) URL : https://patchwork.freedesktop.org/series/38737/ State : success == Summary == Known issues: Test kms_cursor_crc: Subgroup cursor-256x256-suspend: pass -> INCOMPLETE (shard-hsw) fdo#

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] drm/i915: move audio component intialization before audio driver use it

2018-03-29 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915: move audio component intialization before audio driver use it URL : https://patchwork.freedesktop.org/series/40858/ State : warning == Summary == $ dim checkpatch origin/drm-tip f402e6914a54 drm/i915: move audio component intia

[Intel-gfx] [PATCH v18 00/18] Add NV12 support

2018-03-29 Thread Vidya Srinivas
This patch series is adding NV12 support for Broxton display after rebasing on latest drm-tip. Initial series of the patches can be found here: https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html Previous revision history: The first version of patches were reviewed when floated b

[Intel-gfx] [PATCH v18 01/18] drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar skl_wm_values struct contains values of pipe/plane DDB only. so rename it for better readability of code. Similarly skl_copy_wm_for_pipe copies DDB values. s/skl_wm_values/skl_ddb_values s/skl_copy_wm_for_pipe/skl_copy_ddb_for_pipe Changes since V1: - also change name of skl

[Intel-gfx] [PATCH v18 05/18] drm/i915/skl+: NV12 related changes for WM

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar NV12 requires WM calculation for UV plane as well. UV plane WM should also fulfill all the WM related restrictions. v2: Addressed review comments from Shashank Sharma. v3: Addressed review comments from Shashank Sharma Changed plane_num to plane_id in skl_compute_plane_wm_par

[Intel-gfx] [PATCH v18 02/18] drm/i915/skl+: refactor WM calculation for NV12

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar Current code calculates DDB for planar formats in such a way that we store DDB of plane-0 in plane 1 & vice-versa. In order to make this clean this patch refactors WM/DDB calculation for NV12 planar formats. v2: Addressed review comments by Maarten v3: Rebased and addressed r

[Intel-gfx] [PATCH v18 09/18] drm/i915/skl: split skl_compute_ddb function

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar This patch splits skl_compute_wm/ddb functions into two parts. One adds all affected pipes after the commit to atomic_state structure and second part does compute the DDB. v2: Added reviewed by tag from Shashank Sharma v3: Added reviewed by from Juha-Pekka Heikkila v4: Rebas

[Intel-gfx] [PATCH v18 03/18] drm/i915/skl+: add NV12 in skl_format_to_fourcc

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar Add support of recognizing DRM_FORMAT_NV12 from plane_format register value. v2: Added reviewed by tag from Mika Kahola v3: Added reviewed by from Juha-Pekka Heikkila v4: Rebased the series Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Mika Kahola Signed-off-by: Mahesh Ku

[Intel-gfx] [PATCH v18 10/18] drm/i915: Set scaler mode for NV12

2018-03-29 Thread Vidya Srinivas
From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the scaler v3: Rebased (me) v

[Intel-gfx] [PATCH v18 04/18] drm/i915/skl+: support verification of DDB HW state for NV12

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar For YUV 420 Planar formats like NV12, buffer allocation is done for Y and UV surfaces separately. For NV12 plane formats, the UV buffer allocation must be programmed in the Plane Buffer Config register and the Y buffer allocation must be programmed in the Plane NV12 Buffer Conf

[Intel-gfx] [PATCH v18 06/18] drm/i915/skl+: pass skl_wm_level struct to wm compute func

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar This patch passes skl_wm_level structure itself to watermark computation function skl_compute_plane_wm function (instead of its internal parameters). It reduces number of arguments required to be passed. v2: Addressed review comments by Shashank Sharma v3: Adding reviewed by

[Intel-gfx] [PATCH v18 12/18] drm/i915: Upscale scaler max scale for NV12

2018-03-29 Thread Vidya Srinivas
From: Chandra Konduru This patch updates scaler max limit support for NV12 v2: Rebased (me) v3: Rebased (me) v4: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version. v5: Addressed review comments from Ville and rebased - calculation of max

[Intel-gfx] [PATCH v18 14/18] drm/i915: Add NV12 as supported format for sprite plane

2018-03-29 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to list of supported formats for sprite plane. v2: Rebased (me) v3: Review comments by Ville addressed - Removed skl_plane_formats_with_nv12 and added NV12 case in existing skl_plane_formats - Added the 10bpc RGB formats v4: Addressed review comments

[Intel-gfx] [PATCH v18 08/18] drm/i915/skl+: nv12 workaround disable WM level 1-7

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A) Hardware sometimes fails to wake memory from pkg C states fetching the last few lines of planar YUV 420 (NV12) planes. This causes intermittent underflow and corruption. WA: Disable package C states or do not enable late

[Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Vidya Srinivas
As per display WA 1106, to avoid corruption issues NV12 plane height needs to be multiplier of 4 Hence we modify the fb src and destination height and width to be multiples of 4. Without this, pipe fifo underruns were seen on APL and KBL. Credits-to: Maarten Lankhorst Signed-off-by: Vidya Sriniva

[Intel-gfx] [PATCH v18 17/18] drm/i915: Display WA 827

2018-03-29 Thread Vidya Srinivas
Display WA 827 applies to GEN9 (excluede GLK) and CNL. Switching the plane format from NV12 to RGB and leaving system idle results in display underrun and corruption. WA: Set the bit 15 & bit 19 to 1b in the CLKGATE_DIS_PSL register for the pipe in which NV12 plane is enabled. v2: Addressed review

[Intel-gfx] [PATCH v18 13/18] drm/i915: Add NV12 as supported format for primary plane

2018-03-29 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to list of supported formats for primary plane v2: Rebased (Chandra Konduru) v3: Rebased (me) v4: Review comments by Ville addressed Removed the skl_primary_formats_with_nv12 and added NV12 case in existing skl_primary_formats v5: Rebased (me) v6: M

[Intel-gfx] [PATCH v18 07/18] drm/i915/skl+: make sure higher latency level has higher wm value

2018-03-29 Thread Vidya Srinivas
From: Mahesh Kumar DDB allocation optimization algorithm requires/assumes ddb allocation for any memory C-state level DDB value to be as high as level below the current level. Render decompression requires level WM to be as high as wm level-0. This patch fulfils both the requirements. v2: Change

[Intel-gfx] [PATCH v18 15/18] drm/i915: Add NV12 support to intel_framebuffer_init

2018-03-29 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 as supported format to intel_framebuffer_init and performs various checks. v2: -Fix an issue in checks added (Chandra Konduru) v3: rebased (me) v4: Review comments by Ville addressed Added platform check for NV12 in intel_framebuffer_init Removed offs

[Intel-gfx] [PATCH v18 11/18] drm/i915: Update format_is_yuv() to include NV12

2018-03-29 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to format_is_yuv() function for sprite planes. v2: -Use intel_ prefix for format_is_yuv (Ville) v3: Rebased (me) v4: Rebased and addressed review comments from Clinton A Taylor. "static function in intel_sprite.c is not available to the primary plane

[Intel-gfx] [PATCH v18 16/18] drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg

2018-03-29 Thread Vidya Srinivas
If the fb format is YUV, enable the plane CSC mode bits for the conversion. v2: Addressed review comments from Shashank Sharma Alignment issue fixed in i915_reg.h v3: Adding Reviewed By from Shashank Sharma v4: Rebased the patch. As part of rebasing, re-using the color series defines which are a

Re: [Intel-gfx] [RFC i-g-t] intel-gpu-top: Rewrite the tool to be safe to use

2018-03-29 Thread Petri Latvala
Eero, can you give this a try and provide some comments? -- Petri Latvala On 03/28/2018 09:29 PM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin intel-gpu-top is a dangerous tool which can hang machines due unsafe mmio register access. This patch rewrites it to use only PMU. Only overall com

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915: move audio component intialization before audio driver use it

2018-03-29 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915: move audio component intialization before audio driver use it URL : https://patchwork.freedesktop.org/series/40858/ State : success == Summary == Series 40858v1 series starting with [1/1] drm/i915: move audio component intiali

Re: [Intel-gfx] [PATCH] drm/i915: Don't deballoon unused ggtt drm_mm_node in linux guest

2018-03-29 Thread Chris Wilson
Quoting Xiong Zhang (2018-03-29 11:58:41) > Four drm_mm_node are used to reserve guest ggtt space, but some of them > may aren't initialized and used in intel_vgt_balloon(), so these unused may be skipped and not initialised due to space constraints, > drm_mm_node couldn't be removed through drm

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Include the HW breadcrumb whenever we trace the global_seqno

2018-03-29 Thread Tvrtko Ursulin
On 27/03/2018 22:01, Chris Wilson wrote: When we include a request's global_seqno in a GEM_TRACE it often helps to know how that relates to the current breadcrumb as seen by the hardware. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_request.c | 28 +---

[Intel-gfx] ✓ Fi.CI.BAT: success for Add NV12 support (rev6)

2018-03-29 Thread Patchwork
== Series Details == Series: Add NV12 support (rev6) URL : https://patchwork.freedesktop.org/series/39670/ State : success == Summary == Series 39670v6 Add NV12 support https://patchwork.freedesktop.org/api/1.0/series/39670/revisions/6/mbox/ Known issues: Test kms_pipe_crc_basic:

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Maarten Lankhorst
Op 29-03-18 om 10:06 schreef Vidya Srinivas: > As per display WA 1106, to avoid corruption issues > NV12 plane height needs to be multiplier of 4 > Hence we modify the fb src and destination height > and width to be multiples of 4. Without this, pipe > fifo underruns were seen on APL and KBL. > > C

Re: [Intel-gfx] [PATCH] drm/i915: Don't deballoon unused ggtt drm_mm_node in linux guest

2018-03-29 Thread Zhang, Xiong Y
> Quoting Xiong Zhang (2018-03-29 11:58:41) > > Four drm_mm_node are used to reserve guest ggtt space, but some of > > them may aren't initialized and used in intel_vgt_balloon(), so these > > unused > > may be skipped and not initialised due to space constraints, [Zhang, Xiong Y] OK, I will apply

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Include the HW breadcrumb whenever we trace the global_seqno

2018-03-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-29 09:42:52) > > On 27/03/2018 22:01, Chris Wilson wrote: > > When we include a request's global_seqno in a GEM_TRACE it often helps > > to know how that relates to the current breadcrumb as seen by the > > hardware. > > > > Signed-off-by: Chris Wilson > > --- > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Avoid sleeping inside per-engine reset

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Avoid sleeping inside per-engine reset URL : https://patchwork.freedesktop.org/series/40838/ State : success == Summary == Known issues: Test kms_atomic_transition: Subgroup 1x-modeset-transitions-nonblocking: pass -> F

[Intel-gfx] [PATCH i-g-t] tests/perf_pmu: Fix usage of for_each_engine_class_instance

2018-03-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Wrong file descriptor was passed to the iterator. This had currently no effect, since it wasn't used in the macro, but needs to be fixed. At the same time make the macro consistent by checking for engine presence like the other iterators do. Added __for_each_engine_class_in

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Only warn for might_sleep() before a slow wait_for_register

2018-03-29 Thread Mika Kuoppala
Chris Wilson writes: > As intel_wait_for_register_fw() may use, and if successful only use, a > busy-wait loop, the might_sleep() warning is a little over-zealous. > Restrict it to a might_sleep_if() a slow timeout is specified (and so > the caller authorises use of a usleep). > > Signed-off-by:

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Thursday, March 29, 2018 2:19 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of > 4 for NV12 > > O

Re: [Intel-gfx] [PATCH i-g-t] tests/perf_pmu: Fix usage of for_each_engine_class_instance

2018-03-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-29 10:11:28) > From: Tvrtko Ursulin > > Wrong file descriptor was passed to the iterator. This had currently no > effect, since it wasn't used in the macro, but needs to be fixed. > > At the same time make the macro consistent by checking for engine presence > lik

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Ville Syrjälä
On Thu, Mar 29, 2018 at 01:36:02PM +0530, Vidya Srinivas wrote: > As per display WA 1106, to avoid corruption issues > NV12 plane height needs to be multiplier of 4 > Hence we modify the fb src and destination height > and width to be multiples of 4. Without this, pipe > fifo underruns were seen on

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Srinivas, Vidya
> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, March 29, 2018 2:56 PM > To: Srinivas, Vidya > Cc: intel-gfx@lists.freedesktop.org; Lankhorst, Maarten > > Subject: Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of > 4

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Ville Syrjälä
On Thu, Mar 29, 2018 at 09:29:06AM +, Srinivas, Vidya wrote: > > > > -Original Message- > > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > > Sent: Thursday, March 29, 2018 2:56 PM > > To: Srinivas, Vidya > > Cc: intel-gfx@lists.freedesktop.org; Lankhorst, Maarten > > >

[Intel-gfx] [PATCH i-g-t v2] tests/gem_eio: Never re-use contexts which were in the middle of GPU reset

2018-03-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Contexts executing when reset triggers are potentialy corrupt so trying to use them from a subsequent test (like the default context) can hang the GPU or even the driver. Workaround that by always creating a dedicated context which will be running when GPU reset happens. v2

[Intel-gfx] [PATCH] drm/i915/execlists: Set queue priority from secondary port

2018-03-29 Thread Chris Wilson
We can refine our current execlists->queue_priority if we inspect ELSP[1] rather than the head of the unsubmitted queue. Currently, we use the unsubmitted queue and say that if a subsequent request is more than important than the current queue, we will rerun the submission tasklet to evaluate the n

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Srinivas, Vidya
> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Thursday, March 29, 2018 3:04 PM > To: Srinivas, Vidya > Cc: intel-gfx@lists.freedesktop.org; Lankhorst, Maarten > > Subject: Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of > 4

Re: [Intel-gfx] [PATCH] drm/i915: Don't deballoon unused ggtt drm_mm_node in linux guest

2018-03-29 Thread Joonas Lahtinen
+ Zhi and Zhenyu Quoting Xiong Zhang (2018-03-29 13:58:41) > Four drm_mm_node are used to reserve guest ggtt space, but some of them > may aren't initialized and used in intel_vgt_balloon(), so these unused > drm_mm_node couldn't be removed through drm_mm_remove_node(). I'm not sure how this slip

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Include the HW breadcrumb whenever we trace the global_seqno

2018-03-29 Thread Tvrtko Ursulin
On 29/03/2018 09:55, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-03-29 09:42:52) On 27/03/2018 22:01, Chris Wilson wrote: When we include a request's global_seqno in a GEM_TRACE it often helps to know how that relates to the current breadcrumb as seen by the hardware. Signed-off-by: Chr

Re: [Intel-gfx] [PATCH i-g-t v2] tests/gem_eio: Never re-use contexts which were in the middle of GPU reset

2018-03-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-29 10:34:40) > From: Tvrtko Ursulin > > Contexts executing when reset triggers are potentialy corrupt so trying to > use them from a subsequent test (like the default context) can hang the > GPU or even the driver. > > Workaround that by always creating a dedicate

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid sleeping inside per-engine reset

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Avoid sleeping inside per-engine reset URL : https://patchwork.freedesktop.org/series/40838/ State : success == Summary == Series 40838v1 drm/i915: Avoid sleeping inside per-engine reset https://patchwork.freedesktop.org/api/1.0/series/40838/revisions/1/m

Re: [Intel-gfx] Subject: [PATCH 1/1] drm/i915: move audio component intialization before audio

2018-03-29 Thread Jani Nikula
On Thu, 29 Mar 2018, "Shi, Yang A" wrote: > snd_hdac driver would use the component interface from i915 driver. > if i915 driver do the audio component intialization too late, snd_hdac > driver will meet ipanic. Please include the oops. What is it about this patch that fixes the issue? Based on

[Intel-gfx] [PATCH] drm/i915/execlists: Track begin/end of execlists submission sequences

2018-03-29 Thread Chris Wilson
We would like to start doing some bookkeeping at the beginning, between contexts and at the end of execlists submission. We already mark the beginning and end using EXECLISTS_ACTIVE_USER, to provide an indication when the HW is idle. This give us a pair of sequence points we can then expand on for

[Intel-gfx] [PATCH i-g-t v2] blacklist: Don't run DRRS test on Intel CI system

2018-03-29 Thread Marta Lofstedt
Skipping takes time, specifically for the big amount of drrs related kms_frontbuffer_tracking tests. Since we currently don't have any system set up with DRRS panels, blacklisting all those test will save time, and we can avoid the need to increase the Jenkins timeout in order to solve the Bugzilla

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Maarten Lankhorst
Op 29-03-18 om 11:19 schreef Srinivas, Vidya: > >> -Original Message- >> From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] >> Sent: Thursday, March 29, 2018 2:19 PM >> To: Srinivas, Vidya ; intel- >> g...@lists.freedesktop.org >> Subject: Re: [Intel-gfx] [PATCH v18 18/18] d

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Srinivas, Vidya
> -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Thursday, March 29, 2018 3:59 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of > 4 for NV12 > > O

Re: [Intel-gfx] [CI 1/2] drm/i915/guc: enable guc interrupts unconditionally in uc_resume

2018-03-29 Thread Chris Wilson
Quoting Michel Thierry (2018-03-28 21:58:50) > Probably lost while rebasing commit eacd8391f977 ("drm/i915/guc: Keep GuC > interrupts enabled when using GuC"). > > Not really needed since i915_gem_init_hw is called before uc_resume, but > it brings symmetry to uc_suspend. > > Signed-off-by: Miche

[Intel-gfx] [PATCH i-g-t v2] intel-gpu-top: Rewrite the tool to be safe to use

2018-03-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin intel-gpu-top is a dangerous tool which can hang machines due unsafe mmio register access. This patch rewrites it to use only PMU. Only overall command streamer busyness and GPU global data such as power and frequencies are included in this new version. For access to more G

Re: [Intel-gfx] [igt-dev] [RFC i-g-t] intel-gpu-top: Rewrite the tool to be safe to use

2018-03-29 Thread Tvrtko Ursulin
On 28/03/2018 21:11, Rinat Ibragimov wrote: Среда, 28 марта 2018, 21:30 +03:00 от Tvrtko Ursulin : +static struct engines *discover_engines(void)  { -uint32_t devid = pci_dev->device_id; -uint16_t gcfgc; +const char *sysfs_root = "/sys/devices/i915/events"; Just a question. I think, I h

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Don't deballoon unused ggtt drm_mm_node in linux guest

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Don't deballoon unused ggtt drm_mm_node in linux guest URL : https://patchwork.freedesktop.org/series/40851/ State : failure == Summary == Possible new issues: Test drm_read: Subgroup empty-nonblock: pass -> FAIL

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/execlists: Set queue priority from secondary port

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Set queue priority from secondary port URL : https://patchwork.freedesktop.org/series/40869/ State : warning == Summary == $ dim checkpatch origin/drm-tip c8d32fcce635 drm/i915/execlists: Set queue priority from secondary port -:25: WARNING:COMM

Re: [Intel-gfx] [PATCH] drm: Use srcu to protect drm_device.unplugged

2018-03-29 Thread Oleksandr Andrushchenko
On 03/28/2018 06:09 PM, Daniel Vetter wrote: On Wed, Mar 28, 2018 at 10:38:35AM +0300, Oleksandr Andrushchenko wrote: From: Noralf Trønnes Use srcu to protect drm_device.unplugged in a race free manner. Drivers can use drm_dev_enter()/drm_dev_exit() to protect and mark sections preventing acce

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Include the HW breadcrumb whenever we trace the global_seqno

2018-03-29 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-29 10:43:11) > > On 29/03/2018 09:55, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-03-29 09:42:52) > >> > >> On 27/03/2018 22:01, Chris Wilson wrote: > >>> When we include a request's global_seqno in a GEM_TRACE it often helps > >>> to know how that relates

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Set queue priority from secondary port

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Set queue priority from secondary port URL : https://patchwork.freedesktop.org/series/40869/ State : success == Summary == Series 40869v1 drm/i915/execlists: Set queue priority from secondary port https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH v18 18/18] drm/i915: Keep plane size mult of 4 for NV12

2018-03-29 Thread Ville Syrjälä
On Thu, Mar 29, 2018 at 12:28:48PM +0200, Maarten Lankhorst wrote: > Op 29-03-18 om 11:19 schreef Srinivas, Vidya: > > > >> -Original Message- > >> From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > >> Sent: Thursday, March 29, 2018 2:19 PM > >> To: Srinivas, Vidya ; intel

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915: move audio component intialization before audio driver use it

2018-03-29 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915: move audio component intialization before audio driver use it URL : https://patchwork.freedesktop.org/series/40858/ State : success == Summary == Known issues: Test kms_cursor_crc: Subgroup cursor-64x64-suspend:

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Add basic sanitychecks for execlists

2018-03-29 Thread kbuild test robot
/0day-ci/linux/commits/Chris-Wilson/drm-i915-selftests-Add-basic-sanitychecks-for-execlists/20180329-183934 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-x011-201812 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the

Re: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-03-29 Thread Chris Wilson
Quoting Yang (2018-03-29 08:12:13) > From: Yang Shi > > snd_hdac driver would use the component interface from i915 driver. > if i915 driver do the audio component intialization too late, snd_hdac > driver will meet ipanic. > > Signed-off-by: Bo He > Signed-off-by: Yang Shi > --- > drivers/gp

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add NV12 support (rev6)

2018-03-29 Thread Patchwork
== Series Details == Series: Add NV12 support (rev6) URL : https://patchwork.freedesktop.org/series/39670/ State : failure == Summary == Possible new issues: Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-indfb-draw-blt: pass -> FAIL (shar

[Intel-gfx] [PATCH v6 6/8] drm/i915: Write AVI infoframes for MCA LSPCON

2018-03-29 Thread Shashank Sharma
From: "Sharma, Shashank" As LSPCON is a DP branch device, LSPCON vendors define specific methods to pass AVI infoframes to the the chip. This patch adds: - a generic wrapper function for writing AVI infoframes for all LSPCON devices. - a vendor specific function to wrire AVI infoframes into M

[Intel-gfx] [PATCH v6 1/8] drm/i915: Introduce CRTC output format

2018-03-29 Thread Shashank Sharma
This patch adds an enum "intel_output_format" to represent the output format of a particular CRTC. This enum will be used to produce a RGB/YCBCR4:4:4/YCBCR4:2:0 output format during the atomic modeset calculations. V5: - Created this separate patch to introduce and init output_format. - Initialize

[Intel-gfx] [PATCH v6 4/8] drm/i915: Check LSPCON vendor OUI

2018-03-29 Thread Shashank Sharma
From: "Sharma, Shashank" Intel LSPCON chip is provided by 2 vendors: - Megachips America (MCA) - Parade technologies (Parade tech) Its important to know the vendor of this chip, as the address to write AVI infoframes is different for those two. This patch reads the vendor OUI signature, and mar

[Intel-gfx] [PATCH v6 3/8] drm/i915: Add CRTC output format YCBCR 4:4:4

2018-03-29 Thread Shashank Sharma
This patch adds support for YCBCR 4:4:4 CRTC output format. To do this, this patch extends the existing YCBCR 4:2:0 framework by: - Adding new parameter in for YCBCR 4:4:4 enum crtc_iutput_format. - Adding case for YCBCR 4:4:4 in while setting AVI infoframes. - Adding necessary checks in modeset se

[Intel-gfx] [PATCH v6 8/8] drm/i915: Add YCBCR 4:2:0/4:4:4 support for LSPCON

2018-03-29 Thread Shashank Sharma
LSPCON chips can generate YCBCR outputs, if asked nicely :). In order to generate YCBCR 4:2:0 outputs, a source must: - send YCBCR 4:4:4 signals to LSPCON - program color space as 4:2:0 in AVI infoframes Whereas for YCBCR 4:4:4 outputs, the source must: - send YCBCR 4:4:4 signals to LSPCON - prog

[Intel-gfx] [PATCH v6 0/8] YCBCR 4:2:0/4:4:4 output support for LSPCON

2018-03-29 Thread Shashank Sharma
This patch series adds YCBCR 4:2:0 output support for LSPCON displays. In order to indicate the color format of output, to the LSPCON device, a source has to set and send proper AVI infoframes to LSPCON. So this patch series: - introduces concept of CRTC output format. - adds AVI infoframes support

[Intel-gfx] [PATCH v6 2/8] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-03-29 Thread Shashank Sharma
Currently, we are using a bool in CRTC state (state->ycbcr420), to indicate modeset, that the output format is YCBCR 4:2:0. Now in order to support other YCBCR formats, we will need more such flags. This patch adds a new enum parameter for YCBCR 4:2:0 outputs, in the CRTC output formats and then p

[Intel-gfx] [PATCH v6 5/8] drm/i915: Add AVI infoframe support for LSPCON

2018-03-29 Thread Shashank Sharma
In order to pass AVI infoframes to LSPCON devices, a source has to write them in a vendor recommended method and location. This patch series: - adds generic LSPCON infoframe setup functions. - registers these functions into existing AVI infoframe framework. - triggers these functions from modeset

[Intel-gfx] [PATCH v6 7/8] drm/i915: Write AVI infoframes for Parade LSPCON

2018-03-29 Thread Shashank Sharma
From: "Sharma, Shashank" Different LSPCON vendors specify their custom methods to pass AVI infoframes to the LSPCON chip, so does Parade tech. This patch adds functions to arrange and write AVI infoframes into Parade LSPCON chips. V2: rebase V3: Added r-b from Maarten V4: rebase V5: rebase V6:

[Intel-gfx] [PATCH i-g-t 2/2] tests/gem_eio: Add context destroyer test

2018-03-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Context destroyer is supposed to trigger wedging or resets at incovenient times and then re-use the context so either the context or driver tracking might get confused and break. Signed-off-by: Tvrtko Ursulin --- tests/gem_eio.c | 62 +++

[Intel-gfx] [PATCH i-g-t v2 1/2] tests/gem_eio: Never re-use contexts which were in the middle of GPU reset

2018-03-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Contexts executing when reset triggers are potentialy corrupt so trying to use them from a subsequent test (like the default context) can hang the GPU or even the driver. Workaround that by always creating a dedicated context which will be running when GPU reset happens. v2

Re: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-03-29 Thread Jani Nikula
On Thu, 29 Mar 2018, Chris Wilson wrote: > Quoting Yang (2018-03-29 08:12:13) >> From: Yang Shi >> >> snd_hdac driver would use the component interface from i915 driver. >> if i915 driver do the audio component intialization too late, snd_hdac >> driver will meet ipanic. >> >> Signed-off-by: Bo

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Track begin/end of execlists submission sequences

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Track begin/end of execlists submission sequences URL : https://patchwork.freedesktop.org/series/40870/ State : success == Summary == Series 40870v1 drm/i915/execlists: Track begin/end of execlists submission sequences https://patchwork.freedes

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Some plane init cleanups (rev2)

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915: Some plane init cleanups (rev2) URL : https://patchwork.freedesktop.org/series/39390/ State : success == Summary == Series 39390v2 drm/i915: Some plane init cleanups https://patchwork.freedesktop.org/api/1.0/series/39390/revisions/2/mbox/ Known issu

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for YCBCR 4:2:0/4:4:4 output support for LSPCON (rev4)

2018-03-29 Thread Patchwork
== Series Details == Series: YCBCR 4:2:0/4:4:4 output support for LSPCON (rev4) URL : https://patchwork.freedesktop.org/series/36068/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2b5dfa9c4aa1 drm/i915: Introduce CRTC output format -:86: CHECK:PARENTHESIS_ALIGNMENT: Alignment s

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for YCBCR 4:2:0/4:4:4 output support for LSPCON (rev4)

2018-03-29 Thread Patchwork
== Series Details == Series: YCBCR 4:2:0/4:4:4 output support for LSPCON (rev4) URL : https://patchwork.freedesktop.org/series/36068/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Introduce CRTC output format Okay! Commit: drm/i915: Add CRTC output format YCBCR 4

[Intel-gfx] [PATCH v2 1/4] drm/i915: Read HDCP R0 thrice in case of mismatch

2018-03-29 Thread Ramalingam C
As per DP spec when R0 mismatch is detected, HDCP source supported re-read the R0 atleast twice. And For HDMI and DP minimum wait required for the R0 availability is 100mSec. So this patch changes the wait time to 100mSec but retries twice with the time interval of 100mSec for each attempt. This

[Intel-gfx] [PATCH v2 0/4] HDCP1.4 fixes

2018-03-29 Thread Ramalingam C
First two patches needed for below DP HDCP compliance tests 1A-06 and 1B-05 Third patch fixes the HDCP1.4 Key loadability check. where as fourth one fixes the downstream device count read. Fix for HDMI HDCP1.4 CTS tests: 1A-04 and 1A-07a are functional. But the change from v2, as thinking

[Intel-gfx] [PATCH v2 4/4] drm/i915: Fix downstream dev count read

2018-03-29 Thread Ramalingam C
In both HDMI and DP, device count is represented by 6:0 bits of a register(BInfo/Bstatus) So macro for bitmasking the device_count is fixed(0x3F->0x7F). Signed-off-by: Ramalingam C cc: Sean Paul --- include/drm/drm_hdcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/incl

[Intel-gfx] [PATCH v2 3/4] drm/i915: Check hdcp key loadability

2018-03-29 Thread Ramalingam C
HDCP1.4 key can be loaded, only when Power well #1 is enabled and cdclk is enabled. Using the I915 power well infrastruture, above requirement is verified. This patch enables the hdcp initialization for HSW, BDW, and BXT. v2: Choose the PW# based on the platform. Signed-off-by: Ramalingam C R

[Intel-gfx] [PATCH v2 2/4] drm/i915: Read Vprime thrice incase of mismatch

2018-03-29 Thread Ramalingam C
In case of V prime mismatch, DP HDCP spec mandates the re-read of Vprime atleast twice. This patch needed for DP HDCP1.4 CTS Test: 1B-05. v2: Moved the V' validation into a function for retry. [Sean Paul] Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdcp.c | 113 +++

Re: [Intel-gfx] [PATCH v2 0/4] HDCP1.4 fixes

2018-03-29 Thread Ramalingam C
On Thursday 29 March 2018 07:39 PM, Ramalingam C wrote: First two patches needed for below DP HDCP compliance tests 1A-06 and 1B-05 Third patch fixes the HDCP1.4 Key loadability check. where as fourth one fixes the downstream device count read. Fix for HDMI HDCP1.4 CTS tests: 1A-04 and

Re: [Intel-gfx] [PATCH i-g-t v2] intel-gpu-top: Rewrite the tool to be safe to use

2018-03-29 Thread Eero Tamminen
Hi, I tested this on HSW GT2, BYT, BDW GT3, SKL GT2 and KBL GT3e, with Ubuntu 16.04 and 17.10, using Ubuntu default kernels (4.4 to 4.13) and latest drm-tip build (4.16.0-rc7). General comments This will be used by our customers and people who aren't necessarily familiar with

[Intel-gfx] ✗ Fi.CI.BAT: warning for YCBCR 4:2:0/4:4:4 output support for LSPCON (rev4)

2018-03-29 Thread Patchwork
== Series Details == Series: YCBCR 4:2:0/4:4:4 output support for LSPCON (rev4) URL : https://patchwork.freedesktop.org/series/36068/ State : warning == Summary == Series 36068v4 YCBCR 4:2:0/4:4:4 output support for LSPCON https://patchwork.freedesktop.org/api/1.0/series/36068/revisions/4/mbox

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Check hdcp key loadability

2018-03-29 Thread Ville Syrjälä
On Thu, Mar 29, 2018 at 07:39:07PM +0530, Ramalingam C wrote: > HDCP1.4 key can be loaded, only when Power well #1 is enabled and cdclk > is enabled. Using the I915 power well infrastruture, above requirement > is verified. > > This patch enables the hdcp initialization for HSW, BDW, and BXT. > >

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Read HDCP R0 thrice in case of mismatch

2018-03-29 Thread Sean Paul
On Thu, Mar 29, 2018 at 07:39:05PM +0530, Ramalingam C wrote: > As per DP spec when R0 mismatch is detected, HDCP source supported > re-read the R0 atleast twice. > > And For HDMI and DP minimum wait required for the R0 availability is > 100mSec. So this patch changes the wait time to 100mSec but

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Read Vprime thrice incase of mismatch

2018-03-29 Thread Sean Paul
On Thu, Mar 29, 2018 at 07:39:06PM +0530, Ramalingam C wrote: > In case of V prime mismatch, DP HDCP spec mandates the re-read of > Vprime atleast twice. > > This patch needed for DP HDCP1.4 CTS Test: 1B-05. > > v2: > Moved the V' validation into a function for retry. [Sean Paul] > > Signed-of

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Fix downstream dev count read

2018-03-29 Thread Sean Paul
On Thu, Mar 29, 2018 at 07:39:08PM +0530, Ramalingam C wrote: > In both HDMI and DP, device count is represented by 6:0 bits of a > register(BInfo/Bstatus) > > So macro for bitmasking the device_count is fixed(0x3F->0x7F). > Reviewed-by: Sean Paul > Signed-off-by: Ramalingam C > cc: Sean Pau

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP1.4 fixes (rev3)

2018-03-29 Thread Patchwork
== Series Details == Series: HDCP1.4 fixes (rev3) URL : https://patchwork.freedesktop.org/series/38978/ State : success == Summary == Series 38978v3 HDCP1.4 fixes https://patchwork.freedesktop.org/api/1.0/series/38978/revisions/3/mbox/ Known issues: Test kms_pipe_crc_basic: Subg

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Set queue priority from secondary port

2018-03-29 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Set queue priority from secondary port URL : https://patchwork.freedesktop.org/series/40869/ State : success == Summary == Known issues: Test kms_cursor_crc: Subgroup cursor-64x64-suspend: incomplete -> PASS (

[Intel-gfx] ✓ Fi.CI.BAT: success for blacklist: Don't run DRRS test on Intel CI system

2018-03-29 Thread Patchwork
== Series Details == Series: blacklist: Don't run DRRS test on Intel CI system URL : https://patchwork.freedesktop.org/series/40871/ State : success == Summary == IGT patchset tested on top of latest successful build 2cbd4ddf11b3eaf01f33d8bc2ad46411ec6c299a lib/igt_kms: Improve connector probi

[Intel-gfx] [PATCH] drm/edid: Dump valid EDIDs too

2018-03-29 Thread Ville Syrjala
From: Ville Syrjälä Having the EDID available is often very beneficial for bug analysis, even when the EDID itself is valid and not the direct cause of the bug. So let's dump the EDID to dmesg even when it's valid. This should also give us a better historical record of EDIDs for later analysis.

[Intel-gfx] [PATCH v6 1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads

2018-03-29 Thread Yunwei Zhang
WaProgramMgsrForCorrectSliceSpecificMmioReads dictate that before any MMIO read into Slice/Subslice specific registers, MCR packet control register(0xFDC) needs to be programmed to point to any enabled slice/subslice pair. Otherwise, incorrect value will be returned. However, that means each subse

Re: [Intel-gfx] [PATCH i-g-t] tests/perf_pmu: Fix usage of for_each_engine_class_instance

2018-03-29 Thread Michel Thierry
On 29/03/18 02:11, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Wrong file descriptor was passed to the iterator. This had currently no effect, since it wasn't used in the macro, but needs to be fixed. At the same time make the macro consistent by checking for engine presence like the other iter

Re: [Intel-gfx] [PATCH] drm/edid: Dump valid EDIDs too

2018-03-29 Thread Chris Wilson
Quoting Ville Syrjala (2018-03-29 16:50:23) > From: Ville Syrjälä > > Having the EDID available is often very beneficial for bug analysis, > even when the EDID itself is valid and not the direct cause of the > bug. So let's dump the EDID to dmesg even when it's valid. This > should also give us a

  1   2   >