Re: [Intel-gfx] [PATCH v2] drm/i915: Generalize definition for crtc mask

2017-12-19 Thread Mika Kahola
On Mon, 2017-12-18 at 16:05 -0800, Rodrigo Vivi wrote: > On Wed, Dec 13, 2017 at 09:25:16AM +, Mika Kahola wrote: > > > > crtc_mask is defined explicitly defined for a certain number of > > pipes per > > platform. Let's generalize this in a way that crtc_mask dependens > > only on > > the numb

[Intel-gfx] ✗ Fi.CI.BAT: failure for overlay: parse tracepoints from sysfs to figure out fields' location (rev2)

2017-12-19 Thread Patchwork
== Series Details == Series: overlay: parse tracepoints from sysfs to figure out fields' location (rev2) URL : https://patchwork.freedesktop.org/series/35545/ State : failure == Summary == IGT patchset build failed on latest successful build cfb711c046c22c3881d2334f0b43ec4eb0b9a5fc scripts/tr

[Intel-gfx] ✗ Fi.CI.BAT: failure for overlay: parse tracepoints from sysfs to figure out fields' location (rev2)

2017-12-19 Thread Patchwork
== Series Details == Series: overlay: parse tracepoints from sysfs to figure out fields' location (rev2) URL : https://patchwork.freedesktop.org/series/35545/ State : failure == Summary == IGT patchset build failed on latest successful build cfb711c046c22c3881d2334f0b43ec4eb0b9a5fc scripts/tr

[Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Fix ring ignore

2017-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Breakage from previous refactoring. Signed-off-by: Tvrtko Ursulin Reported-by: John Harrison Cc: John Harrison --- scripts/trace.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/trace.pl b/scripts/trace.pl index 588126ad46ab..98e4a9843a43 10

[Intel-gfx] [PATCH] drm/i915: Add a strong mb to resetting the has-CS-interrupt bit

2017-12-19 Thread Chris Wilson
After a reset, the state of the CSB registers are scrubbed and not valid until a powercontext is reloaded. We only know when a powercontext has been reloaded once we see a CS-interrupt, before then we must ignore the CSB registers within the execlists_submission_tasklet. However, glk is sporadicall

[Intel-gfx] ✓ Fi.CI.BAT: success for scripts/trace.pl: Fix ring ignore

2017-12-19 Thread Patchwork
== Series Details == Series: scripts/trace.pl: Fix ring ignore URL : https://patchwork.freedesktop.org/series/35565/ State : success == Summary == IGT patchset tested on top of latest successful build cfb711c046c22c3881d2334f0b43ec4eb0b9a5fc scripts/trace.pl: Auto-detect tracepoint field orde

Re: [Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Fix ring ignore

2017-12-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-19 08:46:52) > From: Tvrtko Ursulin > > Breakage from previous refactoring. > > Signed-off-by: Tvrtko Ursulin > Reported-by: John Harrison > Cc: John Harrison > --- > scripts/trace.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sc

Re: [Intel-gfx] [PATCH i-g-t v2] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-12-19 01:06:18) > With changes going to drm-tip, the tracepoints field locations are > going to change. This change introduces a tracepoint parser (using a > peg parser) which lets us figure out field positions on the fly. > > v2: Fix automake build (Lionel) > > Si

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add a strong mb to resetting the has-CS-interrupt bit

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Add a strong mb to resetting the has-CS-interrupt bit URL : https://patchwork.freedesktop.org/series/35566/ State : success == Summary == Series 35566v1 drm/i915: Add a strong mb to resetting the has-CS-interrupt bit https://patchwork.freedesktop.org/api/

[Intel-gfx] ✗ Fi.CI.IGT: warning for scripts/trace.pl: Fix ring ignore

2017-12-19 Thread Patchwork
== Series Details == Series: scripts/trace.pl: Fix ring ignore URL : https://patchwork.freedesktop.org/series/35565/ State : warning == Summary == Warning: bzip IGTPW_699/shard-kbl7/results14.json.bz2 wasn't in correct JSON format Test kms_frontbuffer_tracking: Subgroup fbc-rgb565-dra

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-19 Thread Daniel Vetter
On Mon, Dec 18, 2017 at 09:42:13AM -0800, Linus Torvalds wrote: > On Sun, Dec 17, 2017 at 11:11 PM, Daniel Vetter wrote: > > > > This didn't seem to have made it into -rc4. Anything needed to get it > > going? > > Do you actually see the problem in -rc4? > > Because we ended up removing the cros

Re: [Intel-gfx] [PATCH 4/5] drm/atomic: document how to handle driver private objects

2017-12-19 Thread Daniel Vetter
On Mon, Dec 18, 2017 at 06:09:20PM +0200, Laurent Pinchart wrote: > Hi Alex, > > On Friday, 15 December 2017 03:57:48 EET Alex Deucher wrote: > > On Thu, Dec 14, 2017 at 3:30 PM, Daniel Vetter wrote: > > > DK put some nice docs into the commit introducing driver private > > > state, but in the git

Re: [Intel-gfx] [PATCH 4/5] drm/atomic: document how to handle driver private objects

2017-12-19 Thread Daniel Vetter
On Mon, Dec 18, 2017 at 06:13:46PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Thursday, 14 December 2017 22:30:53 EET Daniel Vetter wrote: > > DK put some nice docs into the commit introducing driver private > > state, but in the git history alone it'll be los

Re: [Intel-gfx] [PATCH i-g-t v2] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Petri Latvala
On Tue, Dec 19, 2017 at 01:06:18AM +, Lionel Landwerlin wrote: > With changes going to drm-tip, the tracepoints field locations are > going to change. This change introduces a tracepoint parser (using a > peg parser) which lets us figure out field positions on the fly. > > v2: Fix automake bui

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Write AVI infoframes for Parade LSPCON

2017-12-19 Thread David Weinehall
On Mon, Dec 18, 2017 at 08:15:30PM +0100, Maarten Lankhorst wrote: > Op 14-11-17 om 16:17 schreef Shashank Sharma: > > Different LSPCON vendors specify their custom methods to pass > > AVI infoframes to the LSPCON chip, so does Parade tech. > > > > This patch adds functions to arrange and write AVI

Re: [Intel-gfx] [PATCH i-g-t v2 1/1] meson: Install .testlist files and README from tests/intel-ci

2017-12-19 Thread Daniel Vetter
On Tue, Dec 12, 2017 at 01:07:56PM +0200, Petri Latvala wrote: > v2: README too, and a better variable name (Ville) > > Signed-off-by: Petri Latvala > Cc: Daniel Vetter > Cc: Ville Syrjälä Reviewed-by: Daniel Vetter > --- > tests/intel-ci/meson.build | 8 > tests/meson.build

Re: [Intel-gfx] [PATCH igt v2] igt/gem_linear_blits: Compute GTT size using 4G limit

2017-12-19 Thread Arkadiusz Hiler
On Fri, Dec 15, 2017 at 12:22:01PM +, Chris Wilson wrote: > Quoting Chris Wilson (2017-09-13 11:39:14) > > Both gem_linear_blits and gem_tiled_blit do not request the full 48b > > GTT layout for their objects, restricting themselves to 4G. The > > underlying test that they trigger eviction is u

[Intel-gfx] [PATCH v2] mm/vmalloc: Replace opencoded 4-level page walkers

2017-12-19 Thread Chris Wilson
Rather than open-code the intricacies of walking the 4-level page tables, use the generic page table walker apply_to_page_range() instead. The important change is that it now cleans up after an unsuccessful insertion and propagates the correct error. The current failure may lead to a WARN if we en

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add a strong mb to resetting the has-CS-interrupt bit

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Add a strong mb to resetting the has-CS-interrupt bit URL : https://patchwork.freedesktop.org/series/35566/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-primscrn-cur-indfb-draw-pwrite: skip ->

[Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Optimize event parsing and processing

2017-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A couple of small optimizations which altogether bring around 30% improvement in my testing. 1. Do less string processing on tracepoints names and push more of the check into the if-ladder. 2. Pull out common db key and ctx processing and cache common values in local

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)

2017-12-19 Thread Patchwork
== Series Details == Series: igt/gem_linear_blits: Compute GTT size using 4G limit (rev2) URL : https://patchwork.freedesktop.org/series/30216/ State : success == Summary == IGT patchset tested on top of latest successful build d3d04e5f74f05850f595c729fb0c00eb7dd9c688 scripts/trace.pl: Fix rin

[Intel-gfx] ✗ Fi.CI.BAT: failure for mm/vmalloc: Replace opencoded 4-level page walkers (rev3)

2017-12-19 Thread Patchwork
== Series Details == Series: mm/vmalloc: Replace opencoded 4-level page walkers (rev3) URL : https://patchwork.freedesktop.org/series/13822/ State : failure == Summary == Applying: mm/vmalloc: Replace opencoded 4-level page walkers Using index info to reconstruct a base tree... M mm/vmal

[Intel-gfx] [PATCH] drm/i915: Fix indentation for intel_ddi_clk_select

2017-12-19 Thread Chris Wilson
drivers/gpu/drm/i915/intel_ddi.c:2098 intel_ddi_clk_select() warn: inconsistent indenting References: 8edcda1266f9 ("drm/i915: Protect DDI port to DPLL map from theoretical race.") Signed-off-by: Chris Wilson Cc: Paulo Zanoni Cc: Ville Syrjälä Cc: Maarten Lankhorst --- drivers/gpu/drm/i915/

[Intel-gfx] ✓ Fi.CI.BAT: success for scripts/trace.pl: Optimize event parsing and processing

2017-12-19 Thread Patchwork
== Series Details == Series: scripts/trace.pl: Optimize event parsing and processing URL : https://patchwork.freedesktop.org/series/35569/ State : success == Summary == IGT patchset tested on top of latest successful build d3d04e5f74f05850f595c729fb0c00eb7dd9c688 scripts/trace.pl: Fix ring ign

[Intel-gfx] [PATCH v2 3/3] drm/i915: Add pretty printer for modparams

2017-12-19 Thread Michal Wajdeczko
We dump modparams in few places (debugfs, gpu_error) using different functions. Lets add reusable function to avoid code duplication. add/remove: 1/0 grow/shrink: 0/2 up/down: 1096/-2339 (-1243) Function old new delta i915_params_dump

[Intel-gfx] [PATCH v2 2/3] drm/i915: Convert intel_device_info_dump into pretty printer

2017-12-19 Thread Michal Wajdeczko
Convert intel_device_info_dump into pretty printer to be consistent with the rest of the driver code. Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 6 +- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers

[Intel-gfx] [PATCH v2 1/3] drm/i915: Add pretty printer for device info flags

2017-12-19 Thread Michal Wajdeczko
We dump device flags in few places (init_early, debugfs, gpu_error) using different functions. Lets add reusable function to avoid code duplication. add/remove: 1/0 grow/shrink: 0/3 up/down: 1296/-3572 (-2276) Function old new delta intel_device_info_dump_

Re: [Intel-gfx] [PATCH] drm/i915: Fix indentation for intel_ddi_clk_select

2017-12-19 Thread Paulo Zanoni
Em Ter, 2017-12-19 às 11:26 +, Chris Wilson escreveu: > drivers/gpu/drm/i915/intel_ddi.c:2098 intel_ddi_clk_select() warn: > inconsistent indenting > > References: 8edcda1266f9 ("drm/i915: Protect DDI port to DPLL map > from theoretical race.") > Signed-off-by: Chris Wilson > Cc: Paulo Zanoni

[Intel-gfx] [PATCH i-g-t v3] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Lionel Landwerlin
With changes going to drm-tip, the tracepoints field locations are going to change. This change introduces a tracepoint parser (using a peg parser) which lets us figure out field positions on the fly. v2: Fix automake build (Lionel) v3: Make overlay build conditional on peg (Petri) Make wait_

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for igt/pm_rps: Always allocate spin[0]

2017-12-19 Thread Arkadiusz Hiler
On Mon, Dec 11, 2017 at 04:18:40PM +, Patchwork wrote: > == Series Details == > > Series: igt/pm_rps: Always allocate spin[0] > URL : https://patchwork.freedesktop.org/series/35176/ > State : failure > > == Summary == > > Test gem_tiled_swapping: > Subgroup non-threaded: >

[Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-19 Thread Chris Wilson
The vk cts test: dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary triggers a lot of VFS: Close: file count is 0 Dave pointed out that clearing the syncobj->file from drm_syncobj_file_release() was sufficient to silence the test, but that opens a can of worm since we assume

Re: [Intel-gfx] [RFC] drm/i915: Extend CREATE_CONTEXT to allow inheritance ala clone()

2017-12-19 Thread Michał Winiarski
On Fri, Dec 15, 2017 at 01:20:17PM +, Chris Wilson wrote: > A context encompasses the driver's view of process related state, and > encapsulates the logical GPU state where available. Each context is > currently equivalent to a process in CPU terms. Like with processes, > sometimes the user wan

[Intel-gfx] [PATCH] drm/i915: Grab power domain in skl_pipe_wm_get_hw_state()

2017-12-19 Thread Maarten Lankhorst
This should get rid of unclaimed register debug warnings, if it still happens we should put this in a intel_crtc->active check.. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104172 Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 10 +++--- 1 file changed, 7 i

Re: [Intel-gfx] [PATCH] drm/i915: Add a strong mb to resetting the has-CS-interrupt bit

2017-12-19 Thread Tvrtko Ursulin
On 19/12/2017 09:01, Chris Wilson wrote: After a reset, the state of the CSB registers are scrubbed and not valid until a powercontext is reloaded. We only know when a powercontext has been reloaded once we see a CS-interrupt, before then we must ignore the CSB registers within the execlists_sub

Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-19 Thread Daniel Vetter
On Tue, Dec 19, 2017 at 12:07:00PM +, Chris Wilson wrote: > The vk cts test: > dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary > > triggers a lot of > VFS: Close: file count is 0 > > Dave pointed out that clearing the syncobj->file from > drm_syncobj_file_release() wa

Re: [Intel-gfx] [RFC] drm/i915: Extend CREATE_CONTEXT to allow inheritance ala clone()

2017-12-19 Thread Chris Wilson
Quoting Michał Winiarski (2017-12-19 12:15:39) > On Fri, Dec 15, 2017 at 01:20:17PM +, Chris Wilson wrote: > > A context encompasses the driver's view of process related state, and > > encapsulates the logical GPU state where available. Each context is > > currently equivalent to a process in C

[Intel-gfx] [PATCH igt v2] igt/pm_rps: Always allocate spin[0]

2017-12-19 Thread Chris Wilson
Avoid having to test for spin[0] existing by starting the load-loop with it allocated. v2: Preallocate the spin[1] as well for high load. References: https://bugs.freedesktop.org/show_bug.cgi?id=104060 Signed-off-by: Chris Wilson --- tests/pm_rps.c | 27 +++ 1 file chang

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix indentation for intel_ddi_clk_select

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Fix indentation for intel_ddi_clk_select URL : https://patchwork.freedesktop.org/series/35570/ State : success == Summary == Series 35570v1 drm/i915: Fix indentation for intel_ddi_clk_select https://patchwork.freedesktop.org/api/1.0/series/35570/revisions

Re: [Intel-gfx] [PATCH i-g-t v3] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Petri Latvala
On Tue, Dec 19, 2017 at 12:00:58PM +, Lionel Landwerlin wrote: > With changes going to drm-tip, the tracepoints field locations are > going to change. This change introduces a tracepoint parser (using a > peg parser) which lets us figure out field positions on the fly. > > v2: Fix automake bui

Re: [Intel-gfx] [PATCH] drm/i915: Add a strong mb to resetting the has-CS-interrupt bit

2017-12-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-19 12:26:38) > > On 19/12/2017 09:01, Chris Wilson wrote: > > After a reset, the state of the CSB registers are scrubbed and not valid > > until a powercontext is reloaded. We only know when a powercontext has > > been reloaded once we see a CS-interrupt, before the

[Intel-gfx] [PATCH i-g-t v4] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Lionel Landwerlin
With changes going to drm-tip, the tracepoints field locations are going to change. This change introduces a tracepoint parser (using a peg parser) which lets us figure out field positions on the fly. v2: Fix automake build (Lionel) v3: Make overlay build conditional on peg (Petri) Make wait_

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)

2017-12-19 Thread Patchwork
== Series Details == Series: igt/gem_linear_blits: Compute GTT size using 4G limit (rev2) URL : https://patchwork.freedesktop.org/series/30216/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-render: fail -> PAS

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Add pretty printer for device info flags

2017-12-19 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Add pretty printer for device info flags URL : https://patchwork.freedesktop.org/series/35574/ State : success == Summary == Series 35574v1 series starting with [v2,1/3] drm/i915: Add pretty printer for device info flags ht

Re: [Intel-gfx] [PATCH igt] igt/perf_pmu: Speed up frequency measurement

2017-12-19 Thread Tvrtko Ursulin
On 15/12/2017 21:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-12-15 18:24:42) On 15/12/2017 17:05, Chris Wilson wrote: Use the normal batch_duration_ns and display the sampled frequency: Frequency: min=100, max=750, boost=750 MHz Min frequency: requested 100.0, actual 1

[Intel-gfx] [PATCH] drm/i915: Remove pointer indirection for hangcheck_state local

2017-12-19 Thread Chris Wilson
Use the local on-stack struct directly rather than hide it behind a pointer. This should be both clearer for the reader and the compiler (we rely on the compiler seeing through the functions to spot uninitialized uses of the local). Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/

Re: [Intel-gfx] [PATCH igt] igt/perf_pmu: Speed up frequency measurement

2017-12-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-19 12:57:54) > > On 15/12/2017 21:05, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-12-15 18:24:42) > >> > >> Ah I see.. only for the spin batch. Why not then gem_sync or maybe we > >> should add igt_spin_batch_free_sync? > > > > gem_quiescent_gpu goes one s

[Intel-gfx] [PATCH] drm/i915: Show if we consider the engine is idle in the GPU error state

2017-12-19 Thread Chris Wilson
Useful for verifying our bookkeeper when we encounter is knowing whether we think the engine is idle at the time of the GPU hang. References: https://bugs.freedesktop.org/show_bug.cgi?id=104305 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Mika Kuoppala Cc: Michal Wajdeczko --- drivers/g

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_kms: Drop all stale events on first commit.

2017-12-19 Thread Chris Wilson
Quoting Chris Wilson (2017-12-07 16:12:34) > Quoting Maarten Lankhorst (2017-12-07 15:57:09) > > Op 07-12-17 om 16:50 schreef Chris Wilson: > > > Quoting Maarten Lankhorst (2017-12-07 15:42:54) > > >> Op 07-12-17 om 16:03 schreef Chris Wilson: > > >>> Quoting Maarten Lankhorst (2017-12-07 13:40:25)

Re: [Intel-gfx] [PATCH igt 2/2] igt/kms_frontbuffer_tracking: Access via GGTT is not guaranteed to be tracked

2017-12-19 Thread Arkadiusz Hiler
On Thu, Dec 14, 2017 at 08:09:21PM +, Chris Wilson wrote: > Quoting Chris Wilson (2017-12-07 09:41:26) > > As the system may use a partial vma for a GGTT mmap, access via the GGTT > > mmap is not guaranteed to be tracked by FBC's fence. The rule expressed has > > been that any access to the fro

Re: [Intel-gfx] [PATCH] drm/i915: Show if we consider the engine is idle in the GPU error state

2017-12-19 Thread Chris Wilson
Quoting Chris Wilson (2017-12-19 13:14:19) > Useful for verifying our bookkeeper when we encounter is knowing whether +encounter "no progress" > we think the engine is idle at the time of the GPU hang. ___ Intel-gfx mailing list Intel-gfx@lists.freedeskt

[Intel-gfx] ✓ Fi.CI.IGT: success for scripts/trace.pl: Optimize event parsing and processing

2017-12-19 Thread Patchwork
== Series Details == Series: scripts/trace.pl: Optimize event parsing and processing URL : https://patchwork.freedesktop.org/series/35569/ State : success == Summary == Test kms_cursor_crc: Subgroup cursor-256x85-sliding: skip -> PASS (shard-hsw) Test kms_fr

Re: [Intel-gfx] [PATCH 4/5] drm/atomic: document how to handle driver private objects

2017-12-19 Thread Laurent Pinchart
Hi Daniel, On Tuesday, 19 December 2017 12:03:55 EET Daniel Vetter wrote: > On Mon, Dec 18, 2017 at 06:13:46PM +0200, Laurent Pinchart wrote: > > On Thursday, 14 December 2017 22:30:53 EET Daniel Vetter wrote: > >> DK put some nice docs into the commit introducing driver private > >> state, but in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-19 Thread Patchwork
== Series Details == Series: drm/syncobj: Stop reusing the same struct file for all syncobj -> fd URL : https://patchwork.freedesktop.org/series/35576/ State : success == Summary == Series 35576v1 drm/syncobj: Stop reusing the same struct file for all syncobj -> fd https://patchwork.freedeskt

Re: [Intel-gfx] [PATCH 4/5] drm/atomic: document how to handle driver private objects

2017-12-19 Thread Daniel Vetter
On Tue, Dec 19, 2017 at 03:33:57PM +0200, Laurent Pinchart wrote: > On Tuesday, 19 December 2017 12:03:55 EET Daniel Vetter wrote: > > On Mon, Dec 18, 2017 at 06:13:46PM +0200, Laurent Pinchart wrote: > > > On Thursday, 14 December 2017 22:30:53 EET Daniel Vetter wrote: > > >> + * Drivers are recom

Re: [Intel-gfx] [PATCH 4/5] drm/atomic: document how to handle driver private objects

2017-12-19 Thread Laurent Pinchart
Hi Daniel, On Tuesday, 19 December 2017 16:00:36 EET Daniel Vetter wrote: > On Tue, Dec 19, 2017 at 03:33:57PM +0200, Laurent Pinchart wrote: > > On Tuesday, 19 December 2017 12:03:55 EET Daniel Vetter wrote: > > > On Mon, Dec 18, 2017 at 06:13:46PM +0200, Laurent Pinchart wrote: > > > > On Thursd

[Intel-gfx] [PATCH igt v2] igt: Exercise creating context with shared GTT

2017-12-19 Thread Chris Wilson
v2: Test each shared context is its own timeline and allows request reordering between shared contexts. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Mika Kuoppala Cc: Michal Wajdeczko --- include/drm-uapi/sync_file.h | 98 +++ tests/Makefile.sources | 1

[Intel-gfx] [PATCH i-g-t v5] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Lionel Landwerlin
With changes going to drm-tip, the tracepoints field locations are going to change. This change introduces a tracepoint parser (using a peg parser) which lets us figure out field positions on the fly. v2: Fix automake build (Lionel) v3: Make overlay build conditional on peg (Petri) Make wait_

Re: [Intel-gfx] [PATCH v2 2/2] kms_content_protection: Add Content Protection test

2017-12-19 Thread Ramalingam C
Adding few more findings from the IGT usage with kernel solutions. On Wednesday 13 December 2017 04:07 PM, Ramalingam C wrote: Sean, Adding few more observations. On Thursday 07 December 2017 05:47 AM, Sean Paul wrote: Pretty simple test: - initializes the output - clears the content protec

Re: [Intel-gfx] [PATCH i-g-t] intel_vbt_decode: Typo fixes

2017-12-19 Thread Jani Nikula
On Fri, 15 Dec 2017, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > tools/intel_vbt_decode.c | 4 ++-- > tools/intel_vbt_defs.h | 6 +++--- Hi Adam, thanks for the patch. We've opted to make the kernel copy of this file the single point of truth, and copy that over verbatim every on

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Fix indentation for intel_ddi_clk_select

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Fix indentation for intel_ddi_clk_select URL : https://patchwork.freedesktop.org/series/35570/ State : warning == Summary == Test perf: Subgroup polling: pass -> FAIL (shard-hsw) fdo#102252 Test kms_flip: Subgro

[Intel-gfx] [PATCH igt] lib: Convert sw_sync to use sync_file uapi imported from the kernel

2017-12-19 Thread Chris Wilson
Similar to how we are now importing the drm uapi directly into igt, we also would like to have a copy of auxiliary uAPI such as sync_file. Signed-off-by: Chris Wilson --- include/drm-uapi/Makefile.am | 1 + include/drm-uapi/sync_file.h | 98 lib/sw_s

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/3] drm/i915: Add pretty printer for device info flags

2017-12-19 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Add pretty printer for device info flags URL : https://patchwork.freedesktop.org/series/35574/ State : success == Summary == Test gem_tiled_swapping: Subgroup non-threaded: incomplete -> PASS (s

Re: [Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Optimize event parsing and processing

2017-12-19 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-19 11:15:39) > From: Tvrtko Ursulin > > A couple of small optimizations which altogether bring around 30% > improvement in my testing. > > 1. Do less string processing on tracepoints names and push more of the >check into the if-ladder. > > 2. Pull out common

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Convert intel_device_info_dump into pretty printer

2017-12-19 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-19 11:43:45) > Convert intel_device_info_dump into pretty printer to be > consistent with the rest of the driver code. > > Suggested-by: Chris Wilson > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/3] drm/i915: Add pretty printer for device info flags

2017-12-19 Thread Chris Wilson
Quoting Patchwork (2017-12-19 15:01:40) > == Series Details == > > Series: series starting with [v2,1/3] drm/i915: Add pretty printer for device > info flags > URL : https://patchwork.freedesktop.org/series/35574/ > State : success > > == Summary == > > Test gem_tiled_swapping: > Subg

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Grab power domain in skl_pipe_wm_get_hw_state()

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Grab power domain in skl_pipe_wm_get_hw_state() URL : https://patchwork.freedesktop.org/series/35577/ State : success == Summary == Series 35577v1 drm/i915: Grab power domain in skl_pipe_wm_get_hw_state() https://patchwork.freedesktop.org/api/1.0/series/3

Re: [Intel-gfx] [PATCH i-g-t v5] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-12-19 14:26:11) > With changes going to drm-tip, the tracepoints field locations are > going to change. This change introduces a tracepoint parser (using a > peg parser) which lets us figure out field positions on the fly. > > v2: Fix automake build (Lionel) > > v3

Re: [Intel-gfx] [PATCH i-g-t v5] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Lionel Landwerlin
On 19/12/17 15:15, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-12-19 14:26:11) With changes going to drm-tip, the tracepoints field locations are going to change. This change introduces a tracepoint parser (using a peg parser) which lets us figure out field positions on the fly. v2: Fix

[Intel-gfx] [PATCH i-g-t 1/3] lib/dummyload: Support returning output fence

2017-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Support creating spin batches which return an output fence using new __igt_spin_batch_new_fence / igt_spin_batch_new_fence API. This will be used fromthe perf_pmu@interrupts test to ensure user interrupt generation from a batch with controlled duration. Signed-off-by: Tvrtk

[Intel-gfx] [PATCH i-g-t 3/3] tests/perf_pmu: Verify engine busyness accuracy

2017-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A subtest to verify that the engine busyness is reported with expected accuracy on platforms where the feature is available. We test three patterns: 2%, 50% and 98% load per engine. v2: * Use spin batch instead of nop calibration. * Various tweaks. Signed-off-by: Tvrtko

[Intel-gfx] [PATCH i-g-t 2/3] tests/perf_pmu: Simplify interrupt testing

2017-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Rather than calibrate and emit nop batches, use a manually signalled chain of spinners to generate the desired interrupts. Signed-off-by: Tvrtko Ursulin --- tests/perf_pmu.c | 94 1 file changed, 13 insertions(+), 81

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-19 Thread Patchwork
== Series Details == Series: drm/syncobj: Stop reusing the same struct file for all syncobj -> fd URL : https://patchwork.freedesktop.org/series/35576/ State : success == Summary == Test kms_cursor_legacy: Subgroup cursor-vs-flip-atomic: skip -> PASS (shard-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove pointer indirection for hangcheck_state local

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Remove pointer indirection for hangcheck_state local URL : https://patchwork.freedesktop.org/series/35580/ State : success == Summary == Series 35580v1 drm/i915: Remove pointer indirection for hangcheck_state local https://patchwork.freedesktop.org/api/1.

Re: [Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Optimize event parsing and processing

2017-12-19 Thread John Harrison
On 12/19/2017 3:15 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin A couple of small optimizations which altogether bring around 30% improvement in my testing. 1. Do less string processing on tracepoints names and push more of the check into the if-ladder. 2. Pull out common db key and ctx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show if we consider the engine is idle in the GPU error state

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Show if we consider the engine is idle in the GPU error state URL : https://patchwork.freedesktop.org/series/35581/ State : success == Summary == Series 35581v1 drm/i915: Show if we consider the engine is idle in the GPU error state https://patchwork.fre

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rps: Always allocate spin[0] (rev2)

2017-12-19 Thread Patchwork
== Series Details == Series: igt/pm_rps: Always allocate spin[0] (rev2) URL : https://patchwork.freedesktop.org/series/35176/ State : success == Summary == IGT patchset tested on top of latest successful build da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_frontbuffer_tracking: Access via G

[Intel-gfx] ✓ Fi.CI.BAT: success for igt: Exercise creating context with shared GTT (rev2)

2017-12-19 Thread Patchwork
== Series Details == Series: igt: Exercise creating context with shared GTT (rev2) URL : https://patchwork.freedesktop.org/series/35406/ State : success == Summary == IGT patchset tested on top of latest successful build da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_frontbuffer_tracking: Ac

[Intel-gfx] ✗ Fi.CI.BAT: failure for overlay: parse tracepoints from sysfs to figure out fields' location (rev5)

2017-12-19 Thread Patchwork
== Series Details == Series: overlay: parse tracepoints from sysfs to figure out fields' location (rev5) URL : https://patchwork.freedesktop.org/series/35545/ State : failure == Summary == IGT patchset build failed on latest successful build da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_fr

[Intel-gfx] ✓ Fi.CI.BAT: success for lib: Convert sw_sync to use sync_file uapi imported from the kernel

2017-12-19 Thread Patchwork
== Series Details == Series: lib: Convert sw_sync to use sync_file uapi imported from the kernel URL : https://patchwork.freedesktop.org/series/35587/ State : success == Summary == IGT patchset tested on top of latest successful build da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_frontbuffe

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] lib/dummyload: Support returning output fence

2017-12-19 Thread Patchwork
== Series Details == Series: series starting with [1/3] lib/dummyload: Support returning output fence URL : https://patchwork.freedesktop.org/series/35589/ State : success == Summary == IGT patchset tested on top of latest successful build da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_front

[Intel-gfx] [PATCH i-g-t v6] overlay: parse tracepoints from sysfs to figure out fields' location

2017-12-19 Thread Lionel Landwerlin
With changes going to drm-tip, the tracepoints field locations are going to change. This change introduces a tracepoint parser (using a peg parser) which lets us figure out field positions on the fly. v2: Fix automake build (Lionel) v3: Make overlay build conditional on peg (Petri) Make wait_

[Intel-gfx] ✗ Fi.CI.BAT: warning for overlay: parse tracepoints from sysfs to figure out fields' location (rev6)

2017-12-19 Thread Patchwork
== Series Details == Series: overlay: parse tracepoints from sysfs to figure out fields' location (rev6) URL : https://patchwork.freedesktop.org/series/35545/ State : warning == Summary == IGT patchset tested on top of latest successful build da0889bfacff106fb3ecb7049a7a21f78b4b301b igt/kms_f

[Intel-gfx] [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-19 Thread Joe Perches
Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. Done with perl script: $ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444\s*)\)?\s*,\s*\1_show\s*,\s*NULL\s*\)/DEVICE_ATTR_RO(\1)/g; print;

[Intel-gfx] [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-19 Thread Joe Perches
Joe Perches (4): sysfs.h: Use octal permissions treewide: Use DEVICE_ATTR_RW treewide: Use DEVICE_ATTR_RO treewide: Use DEVICE_ATTR_WO arch/arm/mach-pxa/sharpsl_pm.c | 4 +- arch/s390/kernel/smp.c | 2 +- arch/s390/kernel/topology.c

[Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-19 Thread Joe Perches
Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. Done with perl script: $ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*\1_show\s*,\s*

Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-19 Thread Andy Shevchenko
On Tue, Dec 19, 2017 at 8:15 PM, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR

Re: [Intel-gfx] [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-19 Thread Jani Nikula
On Tue, 19 Dec 2017, Joe Perches wrote: > drivers/gpu/drm/i915/i915_sysfs.c | 12 ++-- For i915, Acked-by: Jani Nikula -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org h

[Intel-gfx] [PATCH] drm/i915/vlv: Add cdclk workaround for DSI

2017-12-19 Thread Hans de Goede
At least on the Chuwi Vi8 (non pro/plus) the LCD panel will show an image shifted aprox. 20% to the left (with wraparound) and sometimes also wrong colors, showing that the panel controller is starting with sampling the datastream somewhere mid-line. This happens after the first blanking and re-ini

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Add cdclk workaround for DSI

2017-12-19 Thread Hans de Goede
Hi, I forgot to add a coverletter, anyways what I wanted to put in the coverletter and not in the commit message is a link to a picture of the problem this fixes: https://fedorapeople.org/~jwrdegoede/IMG_20171217_195637.jpg Note the screen is actually a portrait screen, so the picture is the ri

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Add cdclk workaround for DSI

2017-12-19 Thread Rodrigo Vivi
On Tue, Dec 19, 2017 at 07:21:13PM +, Hans de Goede wrote: > At least on the Chuwi Vi8 (non pro/plus) the LCD panel will show an image > shifted aprox. 20% to the left (with wraparound) and sometimes also wrong > colors, showing that the panel controller is starting with sampling the > datastr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vlv: Add cdclk workaround for DSI

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915/vlv: Add cdclk workaround for DSI URL : https://patchwork.freedesktop.org/series/35598/ State : success == Summary == Series 35598v1 drm/i915/vlv: Add cdclk workaround for DSI https://patchwork.freedesktop.org/api/1.0/series/35598/revisions/1/mbox/ Test g

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Add cdclk workaround for DSI

2017-12-19 Thread Ville Syrjälä
On Tue, Dec 19, 2017 at 08:31:07PM +0100, Hans de Goede wrote: > Hi, > > I forgot to add a coverletter, anyways what I wanted to put in the > coverletter and not in the commit message is a link to a picture of the > problem this fixes: > > https://fedorapeople.org/~jwrdegoede/IMG_20171217_195637.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Grab power domain in skl_pipe_wm_get_hw_state()

2017-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Grab power domain in skl_pipe_wm_get_hw_state() URL : https://patchwork.freedesktop.org/series/35577/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-blt: pass -> FAIL

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Add cdclk workaround for DSI

2017-12-19 Thread Hans de Goede
Hi, On 19-12-17 20:42, Rodrigo Vivi wrote: On Tue, Dec 19, 2017 at 07:21:13PM +, Hans de Goede wrote: At least on the Chuwi Vi8 (non pro/plus) the LCD panel will show an image shifted aprox. 20% to the left (with wraparound) and sometimes also wrong colors, showing that the panel controlle

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Add cdclk workaround for DSI

2017-12-19 Thread Hans de Goede
Hi, On 19-12-17 20:48, Ville Syrjälä wrote: On Tue, Dec 19, 2017 at 08:31:07PM +0100, Hans de Goede wrote: Hi, I forgot to add a coverletter, anyways what I wanted to put in the coverletter and not in the commit message is a link to a picture of the problem this fixes: https://fedorapeople.or

Re: [Intel-gfx] [PATCH] drm/i915: Show if we consider the engine is idle in the GPU error state

2017-12-19 Thread Rodrigo Vivi
On Tue, Dec 19, 2017 at 01:14:19PM +, Chris Wilson wrote: > Useful for verifying our bookkeeper when we encounter is knowing whether > we think the engine is idle at the time of the GPU hang. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=104305 Here you mention the hang as "fal

Re: [Intel-gfx] [PATCH] drm/i915: Remove pointer indirection for hangcheck_state local

2017-12-19 Thread Rodrigo Vivi
On Tue, Dec 19, 2017 at 01:09:48PM +, Chris Wilson wrote: > Use the local on-stack struct directly rather than hide it behind a > pointer. This should be both clearer for the reader and the compiler (we > rely on the compiler seeing through the functions to spot uninitialized > uses of the loca

Re: [Intel-gfx] [PATCH] drm/i915: Show if we consider the engine is idle in the GPU error state

2017-12-19 Thread Chris Wilson
Quoting Rodrigo Vivi (2017-12-19 20:49:54) > On Tue, Dec 19, 2017 at 01:14:19PM +, Chris Wilson wrote: > > Useful for verifying our bookkeeper when we encounter is knowing whether > > we think the engine is idle at the time of the GPU hang. > > > > References: https://bugs.freedesktop.org/show

Re: [Intel-gfx] [PATCH] drm/i915: Remove pointer indirection for hangcheck_state local

2017-12-19 Thread Chris Wilson
Quoting Rodrigo Vivi (2017-12-19 20:54:40) > On Tue, Dec 19, 2017 at 01:09:48PM +, Chris Wilson wrote: > > Use the local on-stack struct directly rather than hide it behind a > > pointer. This should be both clearer for the reader and the compiler (we > > rely on the compiler seeing through the

Re: [Intel-gfx] [PATCH] drm/i915: Grab power domain in skl_pipe_wm_get_hw_state()

2017-12-19 Thread Rodrigo Vivi
On Tue, Dec 19, 2017 at 12:16:45PM +, Maarten Lankhorst wrote: > This should get rid of unclaimed register debug warnings, if > it still happens we should put this in a intel_crtc->active check.. What if we just call skl_pipe_wm_get_hw_state() on skl_wm_get_hw_state() if intel_crtc->active ?

  1   2   >