[Intel-gfx] [PATCH 0/3] RFC: v2 set/get scratch page contents

2017-12-08 Thread kevin . rogovin
From: Kevin Rogovin This patch series for Mesa defines and uses a new ioctl interface to get and set the contents of the scratch page for a PPGTT. The purpose of checking that the scratch page is not changed is to help detect out-of-bound buffer object writes by the GPU. v2: - Correctly change

[Intel-gfx] [PATCH 3/3] i965: implement (per-context) scratch page checking

2017-12-08 Thread kevin . rogovin
From: Kevin Rogovin --- src/mesa/drivers/dri/i965/brw_context.c | 30 +++ src/mesa/drivers/dri/i965/brw_context.h | 10 + src/mesa/drivers/dri/i965/intel_batchbuffer.c | 15 +- 3 files changed, 54 insertions(+), 1 deletion(-) diff --git a/

[Intel-gfx] [PATCH 1/3] drm-uapi:i915 define set/get (per-context) scratch page ioctl interface

2017-12-08 Thread kevin . rogovin
From: Kevin Rogovin --- include/drm-uapi/i915_drm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h index 7f28eea403..e75eea058b 100644 --- a/include/drm-uapi/i915_drm.h +++ b/include/drm-uapi/i915_drm.h @@ -1412,6 +1412,15 @

[Intel-gfx] [PATCH 2/3] i965: define gen_debug for checking (per-context) scratch page

2017-12-08 Thread kevin . rogovin
From: Kevin Rogovin --- src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/intel/common/gen_debug.c b/src/intel/common/gen_debug.c index a978f2f581..b8bb8b1395 100644 --- a/src/intel/common/gen_debug.c +++ b/src/intel/common

[Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-08 Thread Chen, Augustine
Dear Sirs, Please kindly help reviewing this patch for the Bugzilla below. https://bugs.freedesktop.org/show_bug.cgi?id=103731 Thanks. Best regards, Augustine 0001-drm-i915-Remove-unused-IRQ-chip-data-of-HDMI-LPE-aud.patch Description: 0001-drm-i915-Remove-unused-IRQ-chip-data-of-HDMI-LPE-aud

Re: [Intel-gfx] [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-08 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 02:30:52PM +, Alan Cox wrote: > > If you want to actually lock down a machine to implement content > > protection, then you need secure boot without unlockable boot-loader and a > > pile more bits in userspace. > > So let me take my Intel hat off for a moment. > > The

Re: [Intel-gfx] drm-intel/for-linux-next disabled on linux-next?

2017-12-08 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 08:37:27PM +1100, Stephen Rothwell wrote: > Hi Daniel, > > On Wed, 6 Dec 2017 10:52:05 +0100 Daniel Vetter wrote: > > > > next-20171205 didn't have any of the patches in drm-intel/for-linux-next > > that weren't already in the drm-next branch. My for-linux-next was at > >

Re: [Intel-gfx] [GIT PULL] gvt-fixes for 4.15-rc3

2017-12-08 Thread Daniel Vetter
On Wed, Dec 06, 2017 at 03:51:05PM +0800, Zhenyu Wang wrote: > > Hi, > > Here's gvt-fixes for 4.15-rc3 with several fixes backported. > > thanks > -- > The following changes since commit b721b65af4eb46df6a1d9e34b14003225e403565: > > drm/i915/gvt: Correct ADDR_4K/2M/1G_MASK definition (2017-11

[Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-08 Thread Augustine.Chen
The chip data of HDMI LPE audio is set to drm_i915_private which is not consistent with the expectation by x86 APIC driver. In the case of not enabling CONFIG_CPUMASK_OFFSTACK, this would cause kernel panic while doing CPU hotplug. Since the dependency of IRQ chip data was removed from HDMI LPE aud

[Intel-gfx] [PATCH] drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers

2017-12-08 Thread Maarten Lankhorst
lock_all_ctx in setplane_internal may return -EINTR, and __setplane_internal could return -EDEADLK. Making more special cases for fb would make the code even harder to read, so the easiest solution is not taking over the fb refcount, and making callers responsible for dropping the ref. Bugzilla: h

Re: [Intel-gfx] [PATCH] drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers

2017-12-08 Thread Daniel Vetter
On Fri, Dec 08, 2017 at 10:54:36AM +0100, Maarten Lankhorst wrote: > lock_all_ctx in setplane_internal may return -EINTR, and > __setplane_internal could return -EDEADLK. Making more > special cases for fb would make the code even harder to > read, so the easiest solution is not taking over the fb

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-08 Thread Peter Zijlstra
On Thu, Dec 07, 2017 at 09:56:57PM +0100, Daniel Vetter wrote: > On Thu, Dec 07, 2017 at 08:57:09PM +0100, Peter Zijlstra wrote: > > Is what it says I suppose. Now I don't know enough about that i915 code > > to say if that breadcrumbs_signal thread can ever trigger a fault or > > not. I got prope

Re: [Intel-gfx] [PATCH] intel/atomic: Stop updating legacy fb parameters

2017-12-08 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 03:49:35PM +0100, Maarten Lankhorst wrote: > Op 07-12-17 om 15:32 schreef Daniel Vetter: > > Even fbc isn't using this stuff anymore, so time to remove it. > > > > Cleaning up one small piece of the atomic conversion cruft at the time > > ... > > > > Quick explanation on why

Re: [Intel-gfx] GemniLake laptops goes power off directly after performing suspend

2017-12-08 Thread Daniel Drake
Hi, Adding intel-gfx list in case i915 developers can help. Updated summary below. On Thu, Dec 7, 2017 at 2:14 AM, Chris Chiu wrote: > On Wed, Dec 6, 2017 at 9:34 PM, Rafael J. Wysocki wrote: > > On Wed, Dec 6, 2017 at 10:33 AM, Chris Chiu wrote: > >> On Wed, Dec 6, 2017 at 5:56 AM, Rafael J.

Re: [Intel-gfx] [PATCH] drm/i915: Use copy_from_user() in fence copying

2017-12-08 Thread David Laight
From: Kees Cook > Sent: 06 December 2017 20:29 > > There's no good reason to separate the access_ok() from the copy, > especially since the access_ok() size is hard-coded instead of using > sizeof(). Instead, just use copy_from_user() directly. Looks like an optimisation to save doing the access_o

Re: [Intel-gfx] [PATCH v6] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-12-08 Thread Imre Deak
On Tue, Dec 05, 2017 at 01:35:11PM +, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2017-12-05 13:28:54) > > From: Tvrtko Ursulin > > > > It seems that the DMC likes to transition between the DC states a lot when > > there are no connected displays (no active power domains) during command > >

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-08 Thread Peter Zijlstra
On Thu, Dec 07, 2017 at 11:08:49AM +0100, Daniel Vetter wrote: > Since -rc1 we're hitting a bunch of lockdep splats using the new > cross-release stuff around the 2 kthread completions. In all cases > they are because totally independent uses of kthread are mixed up by > lockdep into the same locki

[Intel-gfx] [PATCH i-g-t] lib: Make sure intel_aub.h gets packed in dist

2017-12-08 Thread Petri Latvala
Error revealed by distcheck. Fixes: 539a86ec6035 ("lib: copy intel_aub.h from libdrm") Signed-off-by: Petri Latvala Cc: Scott D Phillips Cc: Ben Widawsky Cc: Tomi Sarvela --- lib/Makefile.sources | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/Makefile.sources b/lib/Makefile.sources i

Re: [Intel-gfx] [PATCH] drm/i915: Drop fb reference on load_detect_pipe failure path

2017-12-08 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 10:00:25PM +, Chris Wilson wrote: > When intel_modeset_setup_plane_state() fails drop the local framebuffer > reference before jumping to the error, otherwise we leak the framebuffer. Or we could just https://patchwork.freedesktop.org/patch/165486/ This is Reviewed-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused IRQ chip data of HDMI LPE audio URL : https://patchwork.freedesktop.org/series/35076/ State : success == Summary == Series 35076v1 drm/i915: Remove unused IRQ chip data of HDMI LPE audio https://patchwork.freedesktop.org/api/1.0/series/35076

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-08 Thread Ville Syrjälä
On Fri, Dec 08, 2017 at 08:34:16AM +, Chen, Augustine wrote: > Dear Sirs, > Please kindly help reviewing this patch for the Bugzilla below. > https://bugs.freedesktop.org/show_bug.cgi?id=103731 Resend the patch using git send-email please. -- Ville Syrjälä Intel OTC _

Re: [Intel-gfx] [PATCH] drm/i915: Drop fb reference on load_detect_pipe failure path

2017-12-08 Thread Chris Wilson
Quoting Ville Syrjälä (2017-12-08 11:14:17) > On Thu, Dec 07, 2017 at 10:00:25PM +, Chris Wilson wrote: > > When intel_modeset_setup_plane_state() fails drop the local framebuffer > > reference before jumping to the error, otherwise we leak the framebuffer. > > Or we could just > https://patch

[Intel-gfx] [PATCH] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-08 Thread Chris Wilson
The intent here was that we would be listening to i915_gem_request_unsubmit in order to cancel the signaler quickly and release the reference on the request. Cancelling the signaler is done directly via intel_engine_cancel_signaling (called from unsubmit), but that does not directly wake up the sig

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers

2017-12-08 Thread Patchwork
== Series Details == Series: drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers URL : https://patchwork.freedesktop.org/series/35077/ State : success == Summary == Series 35077v1 drm/plane: Make framebuffer refcounting the responsibility of setplane_inter

[Intel-gfx] [PATCH i-g-t v2 6/7] tests/perf: enable testing on Coffelake GT3

2017-12-08 Thread Lionel Landwerlin
Add the test config uuid for GT3. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index ef37ceb3..cc0c21a1 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1075,8 +1075,11 @@ init_sys_info(void)

[Intel-gfx] [PATCH i-g-t v2 7/7] tests/perf: add test config uuid for Cannonlake

2017-12-08 Thread Lionel Landwerlin
This will enable running the tests on Cannonlake. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index cc0c21a1..99bcdc72 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1082,6 +1082,8 @@ init_sys_info(void)

[Intel-gfx] [PATCH i-g-t v2 4/7] tests/perf: factorize max oa buffer size define

2017-12-08 Thread Lionel Landwerlin
We use this value in several places. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 08ac106a..7f988d7c 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -81,6 +81,8 @@ IGT_TEST_DESCR

[Intel-gfx] [PATCH i-g-t v2 0/7] tests/perf: Enable i915 perf tests on CNL

2017-12-08 Thread Lionel Landwerlin
Adding a fix for make based builds. Cheers, Lionel Landwerlin (7): tools: make sure to include embedded drm-uapi headers include/drm-uapi: bump headers tests/perf: drop copied i915 defines/structs tests/perf: factorize max oa buffer size define tests/perf: query CS timestamp frequency i

[Intel-gfx] [PATCH i-g-t v2 3/7] tests/perf: drop copied i915 defines/structs

2017-12-08 Thread Lionel Landwerlin
Now that we have drm uapi headers in tree, we can drop this stuff. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 114 --- 1 file changed, 7 insertions(+), 107 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index a161c45d..08ac

[Intel-gfx] [PATCH i-g-t v2 1/7] tools: make sure to include embedded drm-uapi headers

2017-12-08 Thread Lionel Landwerlin
Headers from lib/ depend on drm uapi headers. Since we started embedding them, make sure to pull them first, since we still depend on libdrm, we don't want the system headers to be included first. Signed-off-by: Lionel Landwerlin --- tools/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 de

[Intel-gfx] [PATCH i-g-t v2 5/7] tests/perf: query CS timestamp frequency if available

2017-12-08 Thread Lionel Landwerlin
On Cannonlake+ the CS timestamp frequency might vary from one part to another. We have a new param to query this from the kernel (which reads the value from registers). Signed-off-by: Lionel Landwerlin --- tests/perf.c | 31 +-- 1 file changed, 25 insertions(+), 6 del

[Intel-gfx] [PATCH i-g-t v2 2/7] include/drm-uapi: bump headers

2017-12-08 Thread Lionel Landwerlin
Taken from drm-next : commit 9c606cd4117a3c45e04a6616b1a0dbeb1862 Merge: c5dd52f653fa 3997eea57caf Author: Dave Airlie Date: Thu Dec 7 06:28:22 2017 +1000 Merge branch 'drm-next-4.16' of git://people.freedesktop.org/~agd5f/linux into drm-next Signed-off-by: Lionel Landwerlin --- in

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers

2017-12-08 Thread Chris Wilson
Quoting Patchwork (2017-12-08 11:35:05) > == Series Details == > > Series: drm/plane: Make framebuffer refcounting the responsibility of > setplane_internal callers > URL : https://patchwork.freedesktop.org/series/35077/ > State : success > > == Summary == > > Series 35077v1 drm/plane: Make f

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-08 Thread Ville Syrjälä
On Fri, Dec 08, 2017 at 05:33:23PM +0800, Augustine.Chen wrote: > The chip data of HDMI LPE audio is set to drm_i915_private which is not > consistent with the expectation by x86 APIC driver. Hmm. Why is the apic code looking at data for an irq chip it hasn't created? Do we need something like -

Re: [Intel-gfx] [PATCH] drm/i915: Drop fb reference on load_detect_pipe failure path

2017-12-08 Thread Chris Wilson
Quoting Chris Wilson (2017-12-08 11:31:01) > Quoting Ville Syrjälä (2017-12-08 11:14:17) > > On Thu, Dec 07, 2017 at 10:00:25PM +, Chris Wilson wrote: > > > When intel_modeset_setup_plane_state() fails drop the local framebuffer > > > reference before jumping to the error, otherwise we leak the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Stop listening to request resubmission from the signaler kthread URL : https://patchwork.freedesktop.org/series/35084/ State : success == Summary == Series 35084v1 drm/i915: Stop listening to request resubmission from the signaler kthread https://patchw

[Intel-gfx] [PATCH v2] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-08 Thread Chris Wilson
The intent here was that we would be listening to i915_gem_request_unsubmit in order to cancel the signaler quickly and release the reference on the request. Cancelling the signaler is done directly via intel_engine_cancel_signaling (called from unsubmit), but that does not directly wake up the sig

Re: [Intel-gfx] [PATCH v3 00/11] drm/fb-helper: Add .last_close and .output_poll_changed helpers

2017-12-08 Thread Noralf Trønnes
Den 06.12.2017 10.14, skrev Daniel Vetter: On Tue, Dec 05, 2017 at 04:11:26PM -0500, Alex Deucher wrote: On Tue, Dec 5, 2017 at 1:24 PM, Noralf Trønnes wrote: The helpers are applied and have reached airlied/drm-next. amd has gained another .poll_changed user since last. Patches 1, 2, 9 app

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop listening to request resubmission from the signaler kthread (rev2)

2017-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Stop listening to request resubmission from the signaler kthread (rev2) URL : https://patchwork.freedesktop.org/series/35084/ State : success == Summary == Series 35084v2 drm/i915: Stop listening to request resubmission from the signaler kthread https:/

[Intel-gfx] ✗ Fi.CI.BAT: warning for lib: Make sure intel_aub.h gets packed in dist

2017-12-08 Thread Patchwork
== Series Details == Series: lib: Make sure intel_aub.h gets packed in dist URL : https://patchwork.freedesktop.org/series/35082/ State : warning == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, yet

[Intel-gfx] ✗ Fi.CI.BAT: failure for tests/perf: Enable i915 perf tests on CNL (rev2)

2017-12-08 Thread Patchwork
== Series Details == Series: tests/perf: Enable i915 perf tests on CNL (rev2) URL : https://patchwork.freedesktop.org/series/35067/ State : failure == Summary == IGT patchset build failed on latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, yet

Re: [Intel-gfx] [PATCH i-g-t v2 4/7] tests/perf: factorize max oa buffer size define

2017-12-08 Thread Matthew Auld
On 8 December 2017 at 11:39, Lionel Landwerlin wrote: > We use this value in several places. > > Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for tests/perf: Enable i915 perf tests on CNL (rev2)

2017-12-08 Thread Lionel Landwerlin
Apologies, I've fixed this locally and will send a v3 with the fix. On 08/12/17 13:25, Patchwork wrote: == Series Details == Series: tests/perf: Enable i915 perf tests on CNL (rev2) URL : https://patchwork.freedesktop.org/series/35067/ State : failure == Summary == IGT patchset build failed

Re: [Intel-gfx] [PATCH i-g-t v2 5/7] tests/perf: query CS timestamp frequency if available

2017-12-08 Thread Matthew Auld
On 8 December 2017 at 11:39, Lionel Landwerlin wrote: > On Cannonlake+ the CS timestamp frequency might vary from one part to > another. We have a new param to query this from the kernel (which > reads the value from registers). > > Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH i-g-t v2 6/7] tests/perf: enable testing on Coffelake GT3

2017-12-08 Thread Matthew Auld
On 8 December 2017 at 11:39, Lionel Landwerlin wrote: > Add the test config uuid for GT3. > > Signed-off-by: Lionel Landwerlin s/Coffelake/Coffeelake/ Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.

Re: [Intel-gfx] [PATCH i-g-t v2 7/7] tests/perf: add test config uuid for Cannonlake

2017-12-08 Thread Matthew Auld
On 8 December 2017 at 11:39, Lionel Landwerlin wrote: > This will enable running the tests on Cannonlake. > > Signed-off-by: Lionel Landwerlin Missing the CS timestamp frequency fallback for CNL in get_cs_timestamp_frequency(). Otherwise: Reviewed-by: Matthew Auld _

Re: [Intel-gfx] [PATCH i-g-t v2 7/7] tests/perf: add test config uuid for Cannonlake

2017-12-08 Thread Lionel Landwerlin
On 08/12/17 13:50, Matthew Auld wrote: On 8 December 2017 at 11:39, Lionel Landwerlin wrote: This will enable running the tests on Cannonlake. Signed-off-by: Lionel Landwerlin Missing the CS timestamp frequency fallback for CNL in get_cs_timestamp_frequency(). The point is that if we can't

[Intel-gfx] [PATCH igt] igt/perf: Busywait for MI_REPORT_PERF_COUNT results

2017-12-08 Thread Chris Wilson
On Haswell, at least, MI_REPORT_PERF_COUNT is not flushed by the PIPECONTROL surrounding the batch. (In theory, before the breadcrumb is updated the CPU's view of memory is coherent with the GPU, i.e. all writes have landed and are visible to userspace. This does not appear to be the case for MI_RE

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Remove unused IRQ chip data of HDMI LPE audio

2017-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused IRQ chip data of HDMI LPE audio URL : https://patchwork.freedesktop.org/series/35076/ State : warning == Summary == Test kms_cursor_legacy: Subgroup flip-vs-cursor-toggle: skip -> PASS (shard-snb)

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers

2017-12-08 Thread Patchwork
== Series Details == Series: drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers URL : https://patchwork.freedesktop.org/series/35077/ State : success == Summary == Test kms_flip: Subgroup flip-vs-panning: pass -> INCOMPLETE (s

Re: [Intel-gfx] [PATCH i-g-t v2 7/7] tests/perf: add test config uuid for Cannonlake

2017-12-08 Thread Lionel Landwerlin
On 08/12/17 13:54, Lionel Landwerlin wrote: On 08/12/17 13:50, Matthew Auld wrote: On 8 December 2017 at 11:39, Lionel Landwerlin wrote: This will enable running the tests on Cannonlake. Signed-off-by: Lionel Landwerlin Missing the CS timestamp frequency fallback for CNL in get_cs_timestamp

[Intel-gfx] [PATCH igt] igt/perf: Use igt_sysfs rather than opencoding

2017-12-08 Thread Chris Wilson
As igt_sysfs exists to provide convenience routine for parsing files found in the device's sysfs dir, use it. Signed-off-by: Chris Wilson Cc: Lionel Landwerlin Cc: Matthew Auld --- tests/perf.c | 98 +++- 1 file changed, 18 insertions(+),

[Intel-gfx] [PATCH i-g-t] igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs

2017-12-08 Thread Imre Deak
When drawing with cairo to Y/Yf tiled FBs we use a temporary linear buffer which is mapped to the CPU, but the fast blit needed for this only expects 32 bpp FBs. Add support for other bpps too. This is needed for upcoming patches testing non-32bit bpp formats with Y/Yf tiling. Thanks to Ville for

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/perf: Busywait for MI_REPORT_PERF_COUNT results

2017-12-08 Thread Patchwork
== Series Details == Series: igt/perf: Busywait for MI_REPORT_PERF_COUNT results URL : https://patchwork.freedesktop.org/series/35091/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6,

Re: [Intel-gfx] [PATCH igt] igt/perf: Busywait for MI_REPORT_PERF_COUNT results

2017-12-08 Thread Lionel Landwerlin
Hmm that sucks... I'll bring this up with hardware people. Maybe replacing this with a MI_STORE_REGISTER_MEM of the RCS timestamp register (least significant 32bits) is a better approach. On 08/12/17 14:31, Chris Wilson wrote: On Haswell, at least, MI_REPORT_PERF_COUNT is not flushed by the P

[Intel-gfx] [PATCH igt v2] igt/perf: Use igt_sysfs rather than opencoding

2017-12-08 Thread Chris Wilson
As igt_sysfs exists to provide convenience routine for parsing files found in the device's sysfs dir, use it. Signed-off-by: Chris Wilson Cc: Lionel Landwerlin Cc: Matthew Auld --- tests/perf.c | 98 +++- 1 file changed, 18 insertions(+),

[Intel-gfx] [PATCH igt v2] igt/perf: Read RCS0 timestamp directly

2017-12-08 Thread Chris Wilson
On Haswell, at least, MI_REPORT_PERF_COUNT is not flushed by the PIPECONTROL surrounding the batch. (In theory, before the breadcrumb is updated the CPU's view of memory is coherent with the GPU, i.e. all writes have landed and are visible to userspace. This does not appear to be the case for MI_RE

[Intel-gfx] [PATCH i-g-t v3 2/7] include/drm-uapi: bump headers

2017-12-08 Thread Lionel Landwerlin
Taken from drm-next : commit 9c606cd4117a3c45e04a6616b1a0dbeb1862 Merge: c5dd52f653fa 3997eea57caf Author: Dave Airlie Date: Thu Dec 7 06:28:22 2017 +1000 Merge branch 'drm-next-4.16' of git://people.freedesktop.org/~agd5f/linux into drm-next Signed-off-by: Lionel Landwerlin --- in

[Intel-gfx] [PATCH i-g-t v3 5/7] tests/perf: query CS timestamp frequency if available

2017-12-08 Thread Lionel Landwerlin
On Cannonlake+ the CS timestamp frequency might vary from one part to another. We have a new param to query this from the kernel (which reads the value from registers). v2: Skip the tests when timestamp frequency cannot be read on CNL+ (Lionel) Signed-off-by: Lionel Landwerlin Reviewed-by: Matth

[Intel-gfx] [PATCH i-g-t v3 4/7] tests/perf: factorize max oa buffer size define

2017-12-08 Thread Lionel Landwerlin
We use this value in several places. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 08ac106a..7f988d7c 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -8

[Intel-gfx] [PATCH i-g-t v3 0/7] tests/perf: Enable i915 perf tests on CNL

2017-12-08 Thread Lionel Landwerlin
Fixes for make build & skip instead of assert when unable to read cs timestamp frequency on CNL+. Cheers, Lionel Landwerlin (7): debugger/overlay/tools: make sure to include embedded drm-uapi headers include/drm-uapi: bump headers tests/perf: drop copied i915 defines/structs tests/perf: f

[Intel-gfx] [PATCH i-g-t v3 6/7] tests/perf: enable testing on Coffeelake GT3

2017-12-08 Thread Lionel Landwerlin
Add the test config uuid for GT3. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index 70166a7a..2bc0f1d6 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1075,8 +107

[Intel-gfx] [PATCH i-g-t v3 1/7] debugger/overlay/tools: make sure to include embedded drm-uapi headers

2017-12-08 Thread Lionel Landwerlin
Headers from lib/ depend on drm uapi headers. Since we started embedding them, let's make sure to pull them first. We still depend on libdrm in places, we don't want the system headers from libdrm to be included prior to the embedded ones. v2: Fix debugger/overlay (Lionel) Signed-off-by: Lionel L

[Intel-gfx] [PATCH i-g-t v3 3/7] tests/perf: drop copied i915 defines/structs

2017-12-08 Thread Lionel Landwerlin
Now that we have drm uapi headers in tree, we can drop this stuff. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 114 --- 1 file changed, 7 insertions(+), 107 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index a161c45d..08ac

[Intel-gfx] [PATCH i-g-t v3 7/7] tests/perf: add test config uuid for Cannonlake

2017-12-08 Thread Lionel Landwerlin
This will enable running the tests on Cannonlake. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index 2bc0f1d6..71774bbc 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1082,6 +1082,

[Intel-gfx] ✗ Fi.CI.BAT: warning for igt/perf: Use igt_sysfs rather than opencoding

2017-12-08 Thread Patchwork
== Series Details == Series: igt/perf: Use igt_sysfs rather than opencoding URL : https://patchwork.freedesktop.org/series/35092/ State : warning == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, yet

Re: [Intel-gfx] [PATCH igt v2] igt/perf: Read RCS0 timestamp directly

2017-12-08 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 08/12/17 15:14, Chris Wilson wrote: On Haswell, at least, MI_REPORT_PERF_COUNT is not flushed by the PIPECONTROL surrounding the batch. (In theory, before the breadcrumb is updated the CPU's view of memory is coherent with the GPU, i.e. all writes have landed a

[Intel-gfx] [PATCH i-g-t] tests/perf: skip config tests on older kernels

2017-12-08 Thread Lionel Landwerlin
We mostly run tests on the most recent kernels but those are failing on < 4.14. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index 969b8c74..71f64caf 100644 --- a/tests/perf.c +++ b/tests/pe

[Intel-gfx] ✓ Fi.CI.BAT: success for igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs

2017-12-08 Thread Patchwork
== Series Details == Series: igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs URL : https://patchwork.freedesktop.org/series/35093/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_f

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Stop listening to request resubmission from the signaler kthread (rev2)

2017-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Stop listening to request resubmission from the signaler kthread (rev2) URL : https://patchwork.freedesktop.org/series/35084/ State : warning == Summary == Test perf: Subgroup polling: fail -> PASS (shard-hsw) fdo#1022

Re: [Intel-gfx] [PATCH i-g-t] tests/perf: skip config tests on older kernels

2017-12-08 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-12-08 15:39:15) > We mostly run tests on the most recent kernels but those are failing > on < 4.14. > > Signed-off-by: Lionel Landwerlin > --- > tests/perf.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/tests/perf.c b/tests/perf.c

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/perf: Busywait for MI_REPORT_PERF_COUNT results (rev3)

2017-12-08 Thread Patchwork
== Series Details == Series: igt/perf: Busywait for MI_REPORT_PERF_COUNT results (rev3) URL : https://patchwork.freedesktop.org/series/35091/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_fo

[Intel-gfx] ✗ Fi.CI.BAT: failure for tests/perf: Enable i915 perf tests on CNL (rev3)

2017-12-08 Thread Patchwork
== Series Details == Series: tests/perf: Enable i915 perf tests on CNL (rev3) URL : https://patchwork.freedesktop.org/series/35067/ State : failure == Summary == IGT patchset build failed on latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, yet

[Intel-gfx] [PATCH i-g-t v2] tests/perf: skip config tests on older kernels

2017-12-08 Thread Lionel Landwerlin
We mostly run tests on the most recent kernels but those are failing on < 4.14. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index 969b8c74..a173680c 100644 --- a/tests/perf.c +++ b/tests/pe

Re: [Intel-gfx] [PATCH i-g-t] igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs

2017-12-08 Thread Chris Wilson
Quoting Imre Deak (2017-12-08 14:53:41) > When drawing with cairo to Y/Yf tiled FBs we use a temporary linear > buffer which is mapped to the CPU, but the fast blit needed for this > only expects 32 bpp FBs. Add support for other bpps too. > > This is needed for upcoming patches testing non-32bit

Re: [Intel-gfx] [PATCH i-g-t v2] tests/perf: skip config tests on older kernels

2017-12-08 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-12-08 16:02:36) > We mostly run tests on the most recent kernels but those are failing > on < 4.14. > > Signed-off-by: Lionel Landwerlin Reviewed-by: Chris Wilson > --- > tests/perf.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/perf: skip config tests on older kernels

2017-12-08 Thread Patchwork
== Series Details == Series: tests/perf: skip config tests on older kernels URL : https://patchwork.freedesktop.org/series/35095/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, yet

Re: [Intel-gfx] [PATCH igt v2] igt/perf: Use igt_sysfs rather than opencoding

2017-12-08 Thread Lionel Landwerlin
Thanks for the cleanup :) Reviewed-by: Lionel Landwerlin On 08/12/17 15:13, Chris Wilson wrote: As igt_sysfs exists to provide convenience routine for parsing files found in the device's sysfs dir, use it. Signed-off-by: Chris Wilson Cc: Lionel Landwerlin Cc: Matthew Auld --- tests/perf.

[Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats: Fix retrieval of hangcheck stats expectation

2017-12-08 Thread Antonio Argenziano
The test expected IOCTL 'I915_GET_RESET_STATS' would return an error when not root. That is no longer true in the driver and therefore the test was incorrectly failing. Cc: Michel Thierry Cc: Arkadiusz Hiler Signed-off-by: Antonio Argenziano --- tests/gem_reset_stats.c | 22 +++

[Intel-gfx] [PATCH i-g-t v4 0/7] tests/perf: Enable i915 perf tests on CNL

2017-12-08 Thread Lionel Landwerlin
Another set of -I to the embedded drm-uapi headers in the first patch. Cheers, Lionel Landwerlin (7): debugger/overlay/tools: make sure to include embedded drm-uapi headers include/drm-uapi: bump headers tests/perf: drop copied i915 defines/structs tests/perf: factorize max oa buffer size

[Intel-gfx] [PATCH i-g-t v4 1/7] debugger/overlay/tools: make sure to include embedded drm-uapi headers

2017-12-08 Thread Lionel Landwerlin
Headers from lib/ depend on drm uapi headers. Since we started embedding them, let's make sure to pull them first. We still depend on libdrm in places, we don't want the system headers from libdrm to be included prior to the embedded ones. v2: Fix debugger/overlay (Lionel) v3: More fixes in lib/t

[Intel-gfx] [PATCH i-g-t v4 3/7] tests/perf: drop copied i915 defines/structs

2017-12-08 Thread Lionel Landwerlin
Now that we have drm uapi headers in tree, we can drop this stuff. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 114 --- 1 file changed, 7 insertions(+), 107 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index a161c45d..08ac

[Intel-gfx] [PATCH i-g-t v4 4/7] tests/perf: factorize max oa buffer size define

2017-12-08 Thread Lionel Landwerlin
We use this value in several places. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 08ac106a..7f988d7c 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -8

[Intel-gfx] [PATCH i-g-t v4 2/7] include/drm-uapi: bump headers

2017-12-08 Thread Lionel Landwerlin
Taken from drm-next : commit 9c606cd4117a3c45e04a6616b1a0dbeb1862 Merge: c5dd52f653fa 3997eea57caf Author: Dave Airlie Date: Thu Dec 7 06:28:22 2017 +1000 Merge branch 'drm-next-4.16' of git://people.freedesktop.org/~agd5f/linux into drm-next Signed-off-by: Lionel Landwerlin --- in

[Intel-gfx] [PATCH i-g-t v4 5/7] tests/perf: query CS timestamp frequency if available

2017-12-08 Thread Lionel Landwerlin
On Cannonlake+ the CS timestamp frequency might vary from one part to another. We have a new param to query this from the kernel (which reads the value from registers). v2: Skip the tests when timestamp frequency cannot be read on CNL+ (Lionel) Signed-off-by: Lionel Landwerlin Reviewed-by: Matth

[Intel-gfx] [PATCH i-g-t v4 7/7] tests/perf: add test config uuid for Cannonlake

2017-12-08 Thread Lionel Landwerlin
This will enable running the tests on Cannonlake. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index 2bc0f1d6..71774bbc 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1082,6 +1082,

[Intel-gfx] [PATCH i-g-t v4 6/7] tests/perf: enable testing on Coffeelake GT3

2017-12-08 Thread Lionel Landwerlin
Add the test config uuid for GT3. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index 70166a7a..2bc0f1d6 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1075,8 +107

Re: [Intel-gfx] [PATCH v2] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-08 Thread Daniel Vetter
On Fri, Dec 08, 2017 at 12:10:33PM +, Chris Wilson wrote: > The intent here was that we would be listening to > i915_gem_request_unsubmit in order to cancel the signaler quickly and > release the reference on the request. Cancelling the signaler is done > directly via intel_engine_cancel_signal

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/perf: skip config tests on older kernels (rev2)

2017-12-08 Thread Patchwork
== Series Details == Series: tests/perf: skip config tests on older kernels (rev2) URL : https://patchwork.freedesktop.org/series/35095/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-08 Thread Daniel Vetter
On Fri, Dec 08, 2017 at 11:14:16AM +0100, Peter Zijlstra wrote: > On Thu, Dec 07, 2017 at 09:56:57PM +0100, Daniel Vetter wrote: > > On Thu, Dec 07, 2017 at 08:57:09PM +0100, Peter Zijlstra wrote: > > > > Is what it says I suppose. Now I don't know enough about that i915 code > > > to say if that

Re: [Intel-gfx] [PATCH v2] drm/i915: Stop listening to request resubmission from the signaler kthread

2017-12-08 Thread Daniel Vetter
On Fri, Dec 08, 2017 at 12:10:33PM +, Chris Wilson wrote: > The intent here was that we would be listening to > i915_gem_request_unsubmit in order to cancel the signaler quickly and > release the reference on the request. Cancelling the signaler is done > directly via intel_engine_cancel_signal

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats: Fix retrieval of hangcheck stats expectation

2017-12-08 Thread Chris Wilson
Quoting Antonio Argenziano (2017-12-08 16:27:17) > The test expected IOCTL 'I915_GET_RESET_STATS' would return an error > when not root. That is no longer true in the driver and therefore > the test was incorrectly failing. > > Cc: Michel Thierry > Cc: Arkadiusz Hiler > Signed-off-by: Antonio Ar

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/gem_reset_stats: Fix retrieval of hangcheck stats expectation

2017-12-08 Thread Patchwork
== Series Details == Series: tests/gem_reset_stats: Fix retrieval of hangcheck stats expectation URL : https://patchwork.freedesktop.org/series/35101/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Twea

Re: [Intel-gfx] [PATCH i-g-t] lib: Make sure intel_aub.h gets packed in dist

2017-12-08 Thread Scott D Phillips
Petri Latvala writes: > Error revealed by distcheck. > > Fixes: 539a86ec6035 ("lib: copy intel_aub.h from libdrm") > Signed-off-by: Petri Latvala > Cc: Scott D Phillips > Cc: Ben Widawsky > Cc: Tomi Sarvela Reviewed-by: Scott D Phillips > --- > lib/Makefile.sources | 1 + > 1 file changed

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_reset_stats: Fix retrieval of hangcheck stats expectation

2017-12-08 Thread Antonio Argenziano
On 08/12/17 08:46, Chris Wilson wrote: Quoting Antonio Argenziano (2017-12-08 16:27:17) The test expected IOCTL 'I915_GET_RESET_STATS' would return an error when not root. That is no longer true in the driver and therefore the test was incorrectly failing. Cc: Michel Thierry Cc: Arkadiusz Hi

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/perf: Enable i915 perf tests on CNL (rev4)

2017-12-08 Thread Patchwork
== Series Details == Series: tests/perf: Enable i915 perf tests on CNL (rev4) URL : https://patchwork.freedesktop.org/series/35067/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, yet

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for tests/perf: Enable i915 perf tests on CNL (rev4)

2017-12-08 Thread Chris Wilson
Quoting Patchwork (2017-12-08 17:10:51) > == Series Details == > > Series: tests/perf: Enable i915 perf tests on CNL (rev4) > URL : https://patchwork.freedesktop.org/series/35067/ > State : success > > == Summary == > > IGT patchset tested on top of latest successful build > 2fc64acf8a4465d5ea

[Intel-gfx] ✗ Fi.CI.IGT: warning for igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs

2017-12-08 Thread Patchwork
== Series Details == Series: igt_fb: Add support for drawing to non-32bit Y/Yf tiled FBs URL : https://patchwork.freedesktop.org/series/35093/ State : warning == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-blt: pass -> FAIL

[Intel-gfx] ✗ Fi.CI.IGT: warning for igt/perf: Busywait for MI_REPORT_PERF_COUNT results (rev3)

2017-12-08 Thread Patchwork
== Series Details == Series: igt/perf: Busywait for MI_REPORT_PERF_COUNT results (rev3) URL : https://patchwork.freedesktop.org/series/35091/ State : warning == Summary == Test drv_module_reload: Subgroup basic-reload: dmesg-warn -> PASS (shard-snb) fdo#102848

[Intel-gfx] ✗ Fi.CI.IGT: warning for tests/perf: skip config tests on older kernels (rev2)

2017-12-08 Thread Patchwork
== Series Details == Series: tests/perf: skip config tests on older kernels (rev2) URL : https://patchwork.freedesktop.org/series/35095/ State : warning == Summary == Test drv_suspend: Subgroup debugfs-reader: pass -> SKIP (shard-snb) skip

  1   2   >