Re: [Intel-gfx] [PATCH v4 6/9] drm/i915: Make use of indexed write GMBUS feature

2017-12-07 Thread Daniel Vetter
On Wed, Dec 06, 2017 at 07:00:09PM -0500, Sean Paul wrote: > This patch enables the indexed write feature of the GMBUS to concatenate > 2 consecutive messages into one. The criteria for an indexed write is > that both messages are writes, the first is length == 1, and the second > is length > 0. Th

Re: [Intel-gfx] [PATCH v6 0/5] drm/i915: Expose more GPU properties through sysfs

2017-12-07 Thread Tvrtko Ursulin
On 04/12/2017 15:02, Lionel Landwerlin wrote: Hi, After discussion with Chris, Joonas & Tvrtko, this series adds an additional commit to link the render node back to the card through a symlink. Making it obvious from an application using a render node to know where to get the information it nee

[Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Alex Tu
Rrefer to another patch [1] on mesa to extend width/height to 16384. For issue : - https://bugs.freedesktop.org/show_bug.cgi?id=102508 - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI) [1] https://patchwork.freedesktop.org/patch/124918/ Signed-off-by: Alex Tu --- drivers/gpu

Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Chris Wilson
Quoting Alex Tu (2017-12-07 09:26:00) > Rrefer to another patch [1] on mesa to extend width/height to 16384. > For issue : > - https://bugs.freedesktop.org/show_bug.cgi?id=102508 > - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI) > > [1] https://patchwork.freedesktop.org/patch

Re: [Intel-gfx] drm-intel/for-linux-next disabled on linux-next?

2017-12-07 Thread Stephen Rothwell
Hi Daniel, On Wed, 6 Dec 2017 10:52:05 +0100 Daniel Vetter wrote: > > next-20171205 didn't have any of the patches in drm-intel/for-linux-next > that weren't already in the drm-next branch. My for-linux-next was at > > commit 39ccc9852e2b46964c9c44eba52db57413ba6d27 (HEAD -> > drm-intel-next-qu

[Intel-gfx] [PATCH igt 1/2] lib/draw: Use more typical form for computing swizzle addresses

2017-12-07 Thread Chris Wilson
Actually use the XOR operation rather than open coding it with three bitwise operators (including XOR itself). Signed-off-by: Chris Wilson --- lib/igt_draw.c | 35 +++ 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/lib/igt_draw.c b/lib/igt_draw.c

[Intel-gfx] [PATCH igt 2/2] igt/kms_frontbuffer_tracking: Access via GGTT is not guaranteed to be tracked

2017-12-07 Thread Chris Wilson
As the system may use a partial vma for a GGTT mmap, access via the GGTT mmap is not guaranteed to be tracked by FBC's fence. The rule expressed has been that any access to the frontbuffer should be followed by a fb-dirty ioctl, so always apply and expect the driver to ellide no-ops. Signed-off-by

[Intel-gfx] [PATCH i-g-t for CI] tests/kms_vblank: Add test to ensure DRM_CAP_CRTC_IN_VBLANK_EVENT works correctly

2017-12-07 Thread Maarten Lankhorst
This was implemented correctly only on the atomic ioctl before, but it should really be working on all 3 ioctl's involved, so ensure we always set crtc_id correctly with a testcase. The following events are tested: - Pageflip with event. - Atomic commit with event. - wait_vblank ioctl with event.

[Intel-gfx] [PATCH igt] igt/gem_mocs_settings: Force use of master device

2017-12-07 Thread Chris Wilson
To use SECURE batches requires root + master, and we need SECURE batches to write to the privileged mocs registers, do be sure to use drm_open_driver_master() Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104157 Signed-off-by: Chris Wilson --- tests/gem_mocs_settings.c | 2 +- 1 file ch

[Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-07 Thread Daniel Vetter
Since -rc1 we're hitting a bunch of lockdep splats using the new cross-release stuff around the 2 kthread completions. In all cases they are because totally independent uses of kthread are mixed up by lockdep into the same locking class, creating artificial deadlocks. Fix this by converting kthrea

[Intel-gfx] [PATCH igt] lib: Print other clients when DRM_SET_MASTER fails

2017-12-07 Thread Chris Wilson
It looks like there are some rogue processes running in CI that prevent DRM_MASTER from being obtained. Dump the list of clients on failure to make it more obvious what is being left behind. References: https://bugs.freedesktop.org/show_bug.cgi?id=104157 Signed-off-by: Chris Wilson --- lib/Makef

Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Alex Tu
Thanks for comment. I'm not familiar with that, so just followed the patch in mes https://patchwork.freedesktop.org/patch/124918/a. How about change subtitle to "drm/i915: Increase max CRTC bounds to 16k for gen9+"? On Thu, Dec 7, 2017 at 5:32 PM, Chris Wilson wrote: > Quoting Alex Tu (2017-12-

Re: [Intel-gfx] [PATCH igt] igt/perf_pmu: Tweak wait_for_rc6, yet again

2017-12-07 Thread Tvrtko Ursulin
On 06/12/2017 23:12, Chris Wilson wrote: Still CI remains obstinate that RC6 is not smoothly incrementing during the sample period. Tweak the wait_for_rc6() to first wait for the initial Evaluation Interval before polling. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/perf_pmu.c

Re: [Intel-gfx] [PATCH igt] igt/perf_pmu: Tweak wait_for_rc6, yet again

2017-12-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-07 10:25:36) > > On 06/12/2017 23:12, Chris Wilson wrote: > > Still CI remains obstinate that RC6 is not smoothly incrementing during > > the sample period. Tweak the wait_for_rc6() to first wait for the > > initial Evaluation Interval before polling. > > > > Signe

Re: [Intel-gfx] [PATCH v4 0/9] drm/i915: Implement HDCP

2017-12-07 Thread Jose Abreu
Hi Sean, On 07-12-2017 00:00, Sean Paul wrote: > Welcome to version 4 of the patchset. I think we're nearing the finish line > (hopefully) now. This set addresses the review feedback from v3. I applied > some > R-b's from v3 review, and converted others to Cc since other changes were made > to th

Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 06:09:17PM +0800, Alex Tu wrote: > Thanks for comment. > I'm not familiar with that, so just followed the patch in mes > https://patchwork.freedesktop.org/patch/124918/a. > > How about change subtitle to "drm/i915: Increase max CRTC bounds to 16k for > gen9+"? The render s

Re: [Intel-gfx] [RFC i-g-t 3/5] lib/igt_hang_ctx: Use dummyload batch to hang ctx.

2017-12-07 Thread Chris Wilson
Quoting Antonio Argenziano (2017-12-06 23:03:44) > To hang a context we were effectively reimplementing a spinning batch > and never stopping it. This patch reuses the recursive batch from > igt_dummyload to hang a context. > > Cc: Chris Wilson > Signed-off-by: Antonio Argenziano > --- > #defin

[Intel-gfx] [PULL] drm-misc-next

2017-12-07 Thread Gustavo Padovan
Hi Dave, More 4.16 stuff, biggest thing here is the panel orientation work from Hans. The rest is just misc core and drivers improvements/doc/bugfixes. This contain a backmerge of drm-next (at v4.15-rc2) but should be transparent to you. What you should be aware is the merge conflict that will h

Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Chris Wilson
Quoting Alex Tu (2017-12-07 09:26:00) > Rrefer to another patch [1] on mesa to extend width/height to 16384. > For issue : > - https://bugs.freedesktop.org/show_bug.cgi?id=102508 > - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI) > > [1] https://patchwork.freedesktop.org/patch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Patchwork
== Series Details == Series: drm/i915: Increase max texture to 16k for gen9+ URL : https://patchwork.freedesktop.org/series/35016/ State : success == Summary == Series 35016v1 drm/i915: Increase max texture to 16k for gen9+ https://patchwork.freedesktop.org/api/1.0/series/35016/revisions/1/mbo

Re: [Intel-gfx] [GIT PULL] gvt-fixes for 4.15-rc3

2017-12-07 Thread Joonas Lahtinen
Hi, Pulled these, I will give it a final go with CI and send the pull forward. Thanks. Regards, Joonas On Wed, 2017-12-06 at 15:51 +0800, Zhenyu Wang wrote: > Hi, > > Here's gvt-fixes for 4.15-rc3 with several fixes backported. > > thanks > -- > The following changes since commit b721b65af4eb

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-07 Thread Peter Zijlstra
On Thu, Dec 07, 2017 at 11:08:49AM +0100, Daniel Vetter wrote: > Since -rc1 we're hitting a bunch of lockdep splats using the new > cross-release stuff around the 2 kthread completions. In all cases > they are because totally independent uses of kthread are mixed up by > lockdep into the same locki

[Intel-gfx] [PATCH 0/9] make stolen resource centric

2017-12-07 Thread Matthew Auld
Continuation of Paulo' stolen series[1], addressing the feedback from Joonas and Chris. [1] https://patchwork.freedesktop.org/series/30923/ Joonas Lahtinen (1): x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit Matthew Auld (8): x86/early-quirks: replace the magica

[Intel-gfx] [PATCH 7/9] drm/i915: make mappable struct resource centric

2017-12-07 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track the mappable region in a resource as well. v2: prefer iomap and gmadr naming scheme prefer DEFINE_RES_MEM Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni R

[Intel-gfx] [PATCH 9/9] drm/i915: prefer resource_size_t for everything stolen

2017-12-07 Thread Matthew Auld
Keeps things consistent now that we make use of struct resource. This should keep us covered in case we ever get huge amounts of stolen memory. v2: bunch of missing conversions (Chris) Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-by: Chris Wilson

[Intel-gfx] [PATCH 2/9] x86/early-quirks: replace the magical increment start values

2017-12-07 Thread Matthew Auld
Replace the magical +2, +9 etc. with +MB, which is far easier to read. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson Cc: Paulo Zanoni Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: x...@kernel.org Cc: linux-ker..

[Intel-gfx] [PATCH 1/9] x86/early-quirks: Extend Intel graphics stolen memory placement to 64bit

2017-12-07 Thread Matthew Auld
From: Joonas Lahtinen To give upcoming SKU BIOSes more flexibility in placing the Intel graphics stolen memory, make all variables storing the placement or size compatible with full 64 bit range. Also by exporting the stolen region as a resource, we can then nuke the duplicated stolen discovery i

[Intel-gfx] [PATCH 4/9] drm/i915: nuke the duplicated stolen discovery

2017-12-07 Thread Matthew Auld
We duplicate the stolen discovery code in early-quirks and in i915, however now that the stolen region is exported as a resource from early-quirks we can nuke the duplication. v2: check overflows_type Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-b

[Intel-gfx] [PATCH 5/9] drm/i915: make dsm struct resource centric

2017-12-07 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track dsm in a resource as well. v2: check range_overflow when writing to 32b registers (Chris) pepper in some comments (Chris) v3: refit i915_stolen_to_dma() v4: kill ggtt->stolen_size v5: some more

[Intel-gfx] [PATCH 3/9] x86/early-quirks: reverse the if ladders

2017-12-07 Thread Matthew Auld
Makes things a little easier to follow. Suggested-by: Ville Syrjälä Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Ville Syrjälä Cc: Chris Wilson Cc: Paulo Zanoni Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Reviewed-by:

[Intel-gfx] [PATCH 6/9] drm/i915: make reserved struct resource centric

2017-12-07 Thread Matthew Auld
Now that we are using struct resource to track the stolen region, it is more convenient if we track the reserved portion of that region in a resource as well. v2: s/<= end + 1/< end/ (Chris) v3: prefer DEFINE_RES_MEM Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Za

[Intel-gfx] [PATCH 8/9] drm/i915: give stolen_usable_size a more suitable home

2017-12-07 Thread Matthew Auld
Kick it out of i915_ggtt and keep it grouped with dsm and dsm_reserved, where it makes the most sense. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Paulo Zanoni Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h| 13 - drivers/gpu/drm/i9

[Intel-gfx] [PATCH i-g-t] tools: Cannonlake port clock programming

2017-12-07 Thread Mika Kahola
Cannonlake port clock programming tests and verifies DPLL legal dividers P, Q, and K. This tests adds two reference clocks 19.2MHz and 24MHz to test algorithm's capability to find P, Q, and K dividers as well as DCO frequency for different symbol clock rates. The test compares two algorithms, the

Re: [Intel-gfx] [PATCH igt] igt/perf_pmu: Tweak wait_for_rc6, yet again

2017-12-07 Thread Tvrtko Ursulin
On 07/12/2017 10:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-12-07 10:25:36) On 06/12/2017 23:12, Chris Wilson wrote: Still CI remains obstinate that RC6 is not smoothly incrementing during the sample period. Tweak the wait_for_rc6() to first wait for the initial Evaluation Interval

[Intel-gfx] ✗ Fi.CI.BAT: failure for kthread: finer-grained lockdep/cross-release completion

2017-12-07 Thread Patchwork
== Series Details == Series: kthread: finer-grained lockdep/cross-release completion URL : https://patchwork.freedesktop.org/series/35022/ State : failure == Summary == Applying: kthread: finer-grained lockdep/cross-release completion error: Failed to merge in the changes. Using index info to

[Intel-gfx] ✓ Fi.CI.BAT: success for make stolen resource centric (rev6)

2017-12-07 Thread Patchwork
== Series Details == Series: make stolen resource centric (rev6) URL : https://patchwork.freedesktop.org/series/34256/ State : success == Summary == Series 34256v6 make stolen resource centric https://patchwork.freedesktop.org/api/1.0/series/34256/revisions/6/mbox/ Test debugfs_test:

[Intel-gfx] [PULL] drm-intel-fixes

2017-12-07 Thread Joonas Lahtinen
Hi Dave, As previously, the CI is still not very happy for the drm-intel-fixes branch as we're lacking the temporary lockdep fixes which drm-tip is seeing applied. Daniel has been pinging to get them going, so let's hope next pull will then be on a solid CI base. This round it's a bunch of displa

Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Joonas Lahtinen
+ Ville as Jani is OoO On Thu, 2017-12-07 at 17:26 +0800, Alex Tu wrote: > Rrefer to another patch [1] on mesa to extend width/height to 16384. > For issue : > - https://bugs.freedesktop.org/show_bug.cgi?id=102508 > - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI) > > [1] htt

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove vma from object on destroy, not close

2017-12-07 Thread Joonas Lahtinen
On Wed, 2017-12-06 at 12:49 +, Chris Wilson wrote: > Originally we translated from the object to the vma by walking > obj->vma_list to find the matching vm (for user lookups). Now we process > user lookups using the rbtree, and we only use obj->vma_list itself for > maintaining state (e.g. ensu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] lib/draw: Use more typical form for computing swizzle addresses

2017-12-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib/draw: Use more typical form for computing swizzle addresses URL : https://patchwork.freedesktop.org/series/35017/ State : success == Summary == IGT patchset tested on top of latest successful build 261ab6bc964081ae62a6084c335033d8a48

[Intel-gfx] [PATCH i-g-t 6/6] meson: Install .testlist files

2017-12-07 Thread Petri Latvala
Signed-off-by: Petri Latvala Cc: Daniel Vetter --- tests/intel-ci/meson.build | 7 +++ tests/meson.build | 2 ++ 2 files changed, 9 insertions(+) create mode 100644 tests/intel-ci/meson.build diff --git a/tests/intel-ci/meson.build b/tests/intel-ci/meson.build new file mode 100644

[Intel-gfx] [PATCH i-g-t 3/3] tests/kms_cursor_legacy: Rework the 2x-*-vs-cursor-* tests.

2017-12-07 Thread Maarten Lankhorst
Using the fancy new DRM_CAP_CRTC_IN_VBLANK_EVENT cap I can finally make this test the work I originally intended to. For the !modeset case that means performing a pageflip on both crtc's, then requeueing as soon as the event is delivered and then check the vblank counter against the original value

[Intel-gfx] [PATCH i-g-t] tests/kms_color: Rename pipe tests to standard notation

2017-12-07 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- tests/kms_color.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tests/kms_color.c b/tests/kms_color.c index dcda12de3a39..3b0a88802c93 100644 --- a/tests/kms_color.c +++ b/tests/kms_color.c @@ -855,7 +855,7 @@

[Intel-gfx] [PATCH i-g-t 3/6] meson: Install benchmarks to $libexec/intel-gpu-tools/benchmarks

2017-12-07 Thread Petri Latvala
Signed-off-by: Petri Latvala Cc: Daniel Vetter --- benchmarks/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/benchmarks/meson.build b/benchmarks/meson.build index 4afd204f..26d65c4b 100644 --- a/benchmarks/meson.build +++ b/benchmarks/meson.build @@ -31,8 +31,12 @@ foreach p

[Intel-gfx] [PATCH i-g-t 1/3] lib/igt_kms: Drop all stale events on first commit.

2017-12-07 Thread Maarten Lankhorst
I've been trying to make kms_cursor_legacy work when subtests fail. Other subtests will start failing too because of expired events or stale pipe crc. The latter can be resolved in the test, but the former could affect other tests Signed-off-by: Maarten Lankhorst --- lib/igt_kms.c | 39 +

[Intel-gfx] [PATCH i-g-t 2/3] tests/kms_cursor_legacy: Perform lazy cleanup between tests

2017-12-07 Thread Maarten Lankhorst
Instead of assuming each subtest cleans up after itself, assume it fails and doesn't. Now that igt_kms can clean up stale events, we can just force each subtest to only clean up its framebuffers, which isn't harmful if it failed. Signed-off-by: Maarten Lankhorst --- tests/kms_cursor_legacy.c | 8

[Intel-gfx] [PATCH i-g-t 1/6] meson: Don't install headers

2017-12-07 Thread Petri Latvala
Until we can at least check for a matching ABI, the only supported way of building is having the headers from the source checkout. Signed-off-by: Petri Latvala Cc: Daniel Vetter --- lib/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index d06d

[Intel-gfx] [PATCH i-g-t 5/6] meson: Also install gem_stress.

2017-12-07 Thread Petri Latvala
Signed-off-by: Petri Latvala Cc: Daniel Vetter --- tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 45517a59..1d1cbe3a 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -293,7 +293,10 @@ foreach prog : t

[Intel-gfx] [PATCH i-g-t 4/6] meson: Install test-list.txt to libexecdir

2017-12-07 Thread Petri Latvala
Piglit needs test-list.txt to be in the same directory as the test binaries. Signed-off-by: Petri Latvala Cc: Daniel Vetter --- tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 191ac4ce..45517a59 100644 --- a/tests

[Intel-gfx] [PATCH i-g-t 2/6] meson: Don't install selfcheck binaries

2017-12-07 Thread Petri Latvala
Signed-off-by: Petri Latvala Cc: Daniel Vetter --- lib/tests/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/tests/meson.build b/lib/tests/meson.build index 29bdb2c4..55ab2b3d 100644 --- a/lib/tests/meson.build +++ b/lib/tests/meson.build @@ -22,13 +22,13

Re: [Intel-gfx] [PATCH] drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder

2017-12-07 Thread Ville Syrjälä
On Wed, Dec 06, 2017 at 09:52:51AM +0100, Maarten Lankhorst wrote: > Op 01-12-17 om 14:32 schreef Ville Syrjälä: > > On Thu, Nov 30, 2017 at 04:18:53PM +0100, Maarten Lankhorst wrote: > >> Normally this is called on a modeset, but the call is missing when > >> we inherit the mode from the BIOS, so

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Track GGTT writes on the vma

2017-12-07 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-12-07 13:42:40) > On Wed, 2017-12-06 at 12:49 +, Chris Wilson wrote: > > As writes through the GTT and GGTT PTE updates do not share the same > > path, they are not strictly ordered and so we must explicitly flush the > > indirect writes prior to modifying the PTE.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Track GGTT writes on the vma

2017-12-07 Thread Joonas Lahtinen
On Wed, 2017-12-06 at 12:49 +, Chris Wilson wrote: > As writes through the GTT and GGTT PTE updates do not share the same > path, they are not strictly ordered and so we must explicitly flush the > indirect writes prior to modifying the PTE. We do track outstanding GGTT > writes on the object i

Re: [Intel-gfx] [PATCH 05/10] drm/i915: make dsm struct resource centric

2017-12-07 Thread Ville Syrjälä
On Wed, Dec 06, 2017 at 06:30:33PM +, Chris Wilson wrote: > Quoting Matthew Auld (2017-12-06 18:17:25) > > Now that we are using struct resource to track the stolen region, it is > > more convenient if we track dsm in a resource as well. > > > > v2: check range_overflow when writing to 32b reg

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_vblank: Add test to ensure DRM_CAP_CRTC_IN_VBLANK_EVENT works correctly (rev2)

2017-12-07 Thread Patchwork
== Series Details == Series: tests/kms_vblank: Add test to ensure DRM_CAP_CRTC_IN_VBLANK_EVENT works correctly (rev2) URL : https://patchwork.freedesktop.org/series/34299/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30

[Intel-gfx] [PATCH] drm/i915: add FTRACE dependency for DRM_I915_TRACE_GEM

2017-12-07 Thread Arnd Bergmann
The new trace option gratuitously added a 'select TRACING' statement, which now causes build failures in other code that assumed tracepoints were only available with FTRACE: ERROR: "__tracepoint_ucsi_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined! ERROR: "__tracepoint_ucsi_register_por

Re: [Intel-gfx] [PATCH v3 04/11] drm/exynos: Use drm_fb_helper_lastclose() and _poll_changed()

2017-12-07 Thread Noralf Trønnes
Den 07.12.2017 01.50, skrev Inki Dae: 2017년 12월 06일 03:24에 Noralf Trønnes 이(가) 쓴 글: This driver can use drm_fb_helper_lastclose() as its .lastclose callback. It can also use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-W

[Intel-gfx] [PATCH] intel/atomic: Stop updating legacy fb parameters

2017-12-07 Thread Daniel Vetter
Even fbc isn't using this stuff anymore, so time to remove it. Cleaning up one small piece of the atomic conversion cruft at the time ... Quick explanation on why the plane->fb assignment is ok to delete: The core code takes care of the refcounting and legacy ->fb pointer updating, but drivers ar

[Intel-gfx] [PATCH] drm: More debug info for fb leaks in mode_config_cleanup

2017-12-07 Thread Daniel Vetter
We're spotting this very rarely in CI, but have no idea. Let's add more debug info about what's going on here. References: https://bugs.freedesktop.org/show_bug.cgi?id=102707 Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_mode_config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a

Re: [Intel-gfx] [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-07 Thread Alan Cox
> If you want to actually lock down a machine to implement content > protection, then you need secure boot without unlockable boot-loader and a > pile more bits in userspace. So let me take my Intel hat off for a moment. The upstream policy has always been that we don't merge things which don't

Re: [Intel-gfx] [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-07 Thread Alan Cox
> How about for sensitive video streams in government offices where you > want to avoid a spy potentially tapping the cable to see the video > stream? Last time I checked HDCP did not meet government security requirements - which is hardly surprising since you can buy $10 boxes from China to de-hd

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-07 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 01:22:56PM +0100, Peter Zijlstra wrote: > On Thu, Dec 07, 2017 at 11:08:49AM +0100, Daniel Vetter wrote: > > Since -rc1 we're hitting a bunch of lockdep splats using the new > > cross-release stuff around the 2 kthread completions. In all cases > > they are because totally i

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk"

2017-12-07 Thread Joonas Lahtinen
Hi, Thanks, this was included in the pull. One comment below, not strictly related to this patch. On Wed, 2017-12-06 at 14:25 -0800, Rodrigo Vivi wrote: > From: Radhakrishna Sripada > > This reverts commit 8f067837c4b713ce2e69be95af7b2a5eb3bd7de8. > > HSD says "WA withdrawn. It was causing co

Re: [Intel-gfx] [PATCH] intel/atomic: Stop updating legacy fb parameters

2017-12-07 Thread Maarten Lankhorst
Op 07-12-17 om 15:32 schreef Daniel Vetter: > Even fbc isn't using this stuff anymore, so time to remove it. > > Cleaning up one small piece of the atomic conversion cruft at the time > ... > > Quick explanation on why the plane->fb assignment is ok to delete: The > core code takes care of the refc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add FTRACE dependency for DRM_I915_TRACE_GEM

2017-12-07 Thread Patchwork
== Series Details == Series: drm/i915: add FTRACE dependency for DRM_I915_TRACE_GEM URL : https://patchwork.freedesktop.org/series/35035/ State : success == Summary == Series 35035v1 drm/i915: add FTRACE dependency for DRM_I915_TRACE_GEM https://patchwork.freedesktop.org/api/1.0/series/35035/r

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_kms: Drop all stale events on first commit.

2017-12-07 Thread Chris Wilson
Quoting Maarten Lankhorst (2017-12-07 13:40:25) > I've been trying to make kms_cursor_legacy work when subtests fail. > Other subtests will start failing too because of expired events or > stale pipe crc. The latter can be resolved in the test, but the former > could affect other tests > > Signed-

[Intel-gfx] [PULL] drm-misc-fixes

2017-12-07 Thread Daniel Vetter
Hi Dave, drm-misc-fixes-2017-12-07: regression fix for vc4 + rpm stable fix for analogix bridge Of course I do a pull, 2 more patches show up. Flushed them out since you'll be out next week. Cheers, Daniel The following changes since commit a703c55004e1c5076d57e43771b3e7796ea0: drm: saf

[Intel-gfx] Dual monitor stuttering bug

2017-12-07 Thread Renato Ferreira
Hello, I have an issue though i'm not really sure where it belongs to, i915, mesa, drm or xorg, so i'm really sorry if it doesn't belong here. The issue is as follows: I em experiencing a very noticeable stuttering (mainly on scroll) in any app *only* when an external monitor is enabled, and the

Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 05:26:00PM +0800, Alex Tu wrote: > Rrefer to another patch [1] on mesa to extend width/height to 16384. > For issue : > - https://bugs.freedesktop.org/show_bug.cgi?id=102508 > - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI) > > [1] https://patchwork.fr

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_kms: Drop all stale events on first commit.

2017-12-07 Thread Maarten Lankhorst
Op 07-12-17 om 16:03 schreef Chris Wilson: > Quoting Maarten Lankhorst (2017-12-07 13:40:25) >> I've been trying to make kms_cursor_legacy work when subtests fail. >> Other subtests will start failing too because of expired events or >> stale pipe crc. The latter can be resolved in the test, but th

[Intel-gfx] ✓ Fi.CI.BAT: success for intel/atomic: Stop updating legacy fb parameters (rev2)

2017-12-07 Thread Patchwork
== Series Details == Series: intel/atomic: Stop updating legacy fb parameters (rev2) URL : https://patchwork.freedesktop.org/series/34924/ State : success == Summary == Series 34924v2 intel/atomic: Stop updating legacy fb parameters https://patchwork.freedesktop.org/api/1.0/series/34924/revisi

[Intel-gfx] [RFC] drm/i915: Support creating a proxy object that links to other object's pages

2017-12-07 Thread Chris Wilson
Sometimes it is useful to work with arbitrarily large surfaces, that exceed the limits of various bits of HW. For instance, you may be creating a mega-texture, a single very large texture with essentially infinite dimensions, but need to normal textures out of it for sampling by hardware. As the te

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_kms: Drop all stale events on first commit.

2017-12-07 Thread Chris Wilson
Quoting Maarten Lankhorst (2017-12-07 15:42:54) > Op 07-12-17 om 16:03 schreef Chris Wilson: > > Quoting Maarten Lankhorst (2017-12-07 13:40:25) > >> I've been trying to make kms_cursor_legacy work when subtests fail. > >> Other subtests will start failing too because of expired events or > >> stal

Re: [Intel-gfx] [PATCH] drm: More debug info for fb leaks in mode_config_cleanup

2017-12-07 Thread Noralf Trønnes
Den 07.12.2017 15.49, skrev Daniel Vetter: We're spotting this very rarely in CI, but have no idea. Let's add more debug info about what's going on here. References: https://bugs.freedesktop.org/show_bug.cgi?id=102707 Signed-off-by: Daniel Vetter --- Acked-by: Noralf Trønnes drivers/gpu

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_kms: Drop all stale events on first commit.

2017-12-07 Thread Maarten Lankhorst
Op 07-12-17 om 16:50 schreef Chris Wilson: > Quoting Maarten Lankhorst (2017-12-07 15:42:54) >> Op 07-12-17 om 16:03 schreef Chris Wilson: >>> Quoting Maarten Lankhorst (2017-12-07 13:40:25) I've been trying to make kms_cursor_legacy work when subtests fail. Other subtests will start fail

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: More debug info for fb leaks in mode_config_cleanup

2017-12-07 Thread Patchwork
== Series Details == Series: drm: More debug info for fb leaks in mode_config_cleanup URL : https://patchwork.freedesktop.org/series/35038/ State : success == Summary == Series 35038v1 drm: More debug info for fb leaks in mode_config_cleanup https://patchwork.freedesktop.org/api/1.0/series/350

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_kms: Drop all stale events on first commit.

2017-12-07 Thread Chris Wilson
Quoting Maarten Lankhorst (2017-12-07 15:57:09) > Op 07-12-17 om 16:50 schreef Chris Wilson: > > Quoting Maarten Lankhorst (2017-12-07 15:42:54) > >> Op 07-12-17 om 16:03 schreef Chris Wilson: > >>> Quoting Maarten Lankhorst (2017-12-07 13:40:25) > I've been trying to make kms_cursor_legacy wo

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Increase max texture to 16k for gen9+

2017-12-07 Thread Patchwork
== Series Details == Series: drm/i915: Increase max texture to 16k for gen9+ URL : https://patchwork.freedesktop.org/series/35016/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-render: fail -> PASS (shar

[Intel-gfx] [PATCH] drm/i915: Refactor common list iteration over GGTT vma

2017-12-07 Thread Chris Wilson
In quite a few places, we have a list iteration over the vma on an object that only want to inspect GGTT vma. By construction, these are placed at the start of the list, so we have copied that knowledge into many callsites. Pull that knowledge back to i915_vma.h and provide a for_each_ggtt_vma() to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Support creating a proxy object that links to other object's pages

2017-12-07 Thread Patchwork
== Series Details == Series: drm/i915: Support creating a proxy object that links to other object's pages URL : https://patchwork.freedesktop.org/series/35042/ State : success == Summary == Series 35042v1 drm/i915: Support creating a proxy object that links to other object's pages https://pa

Re: [Intel-gfx] [PATCH i-g-t 3/6] meson: Install benchmarks to $libexec/intel-gpu-tools/benchmarks

2017-12-07 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 03:40:28PM +0200, Petri Latvala wrote: > Signed-off-by: Petri Latvala > Cc: Daniel Vetter > --- > benchmarks/meson.build | 4 > 1 file changed, 4 insertions(+) > > diff --git a/benchmarks/meson.build b/benchmarks/meson.build > index 4afd204f..26d65c4b 100644 > --- a

Re: [Intel-gfx] [PATCH i-g-t 2/6] meson: Don't install selfcheck binaries

2017-12-07 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 03:40:27PM +0200, Petri Latvala wrote: > Signed-off-by: Petri Latvala > Cc: Daniel Vetter Reviewed-by: Ville Syrjälä > --- > lib/tests/meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/tests/meson.build b/lib/tests/meson.buil

Re: [Intel-gfx] [PATCH i-g-t 5/6] meson: Also install gem_stress.

2017-12-07 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 03:40:30PM +0200, Petri Latvala wrote: > Signed-off-by: Petri Latvala > Cc: Daniel Vetter Reviewed-by: Ville Syrjälä > --- > tests/meson.build | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/meson.build b/tests/meson.build > index 45

Re: [Intel-gfx] [PATCH i-g-t 6/6] meson: Install .testlist files

2017-12-07 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 03:40:31PM +0200, Petri Latvala wrote: > Signed-off-by: Petri Latvala > Cc: Daniel Vetter > --- > tests/intel-ci/meson.build | 7 +++ > tests/meson.build | 2 ++ > 2 files changed, 9 insertions(+) > create mode 100644 tests/intel-ci/meson.build > > diff --g

Re: [Intel-gfx] [PATCH i-g-t 4/6] meson: Install test-list.txt to libexecdir

2017-12-07 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 03:40:29PM +0200, Petri Latvala wrote: > Piglit needs test-list.txt to be in the same directory as the test > binaries. Referencing the corresponding autotools commit would have made this easier to review... Reviewed-by: Ville Syrjälä > > Signed-off-by: Petri Latvala >

Re: [Intel-gfx] [PATCH] drm/i915: Refactor common list iteration over GGTT vma

2017-12-07 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 04:27:17PM +, Chris Wilson wrote: > In quite a few places, we have a list iteration over the vma on an > object that only want to inspect GGTT vma. By construction, these are > placed at the start of the list, so we have copied that knowledge into > many callsites. Pull

Re: [Intel-gfx] [PATCH] drm/i915: Refactor common list iteration over GGTT vma

2017-12-07 Thread Chris Wilson
Quoting Ville Syrjälä (2017-12-07 16:40:49) > On Thu, Dec 07, 2017 at 04:27:17PM +, Chris Wilson wrote: > > +#define for_each_ggtt_vma(V, OBJ) \ > > + list_for_each_entry(V, &(OBJ)->vma_list, obj_link) \ > > + if (!i915_vma_is_ggtt(vma)) break; else > > for_each_if

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Refactor common list iteration over GGTT vma

2017-12-07 Thread Patchwork
== Series Details == Series: drm/i915: Refactor common list iteration over GGTT vma URL : https://patchwork.freedesktop.org/series/35048/ State : success == Summary == Series 35048v1 drm/i915: Refactor common list iteration over GGTT vma https://patchwork.freedesktop.org/api/1.0/series/35048/r

Re: [Intel-gfx] [PATCH i-g-t 3/6] meson: Install benchmarks to $libexec/intel-gpu-tools/benchmarks

2017-12-07 Thread Chris Wilson
Quoting Petri Latvala (2017-12-07 13:40:28) > Signed-off-by: Petri Latvala > Cc: Daniel Vetter > --- > benchmarks/meson.build | 4 > 1 file changed, 4 insertions(+) > > diff --git a/benchmarks/meson.build b/benchmarks/meson.build > index 4afd204f..26d65c4b 100644 > --- a/benchmarks/meson.b

Re: [Intel-gfx] [PATCH i-g-t v2] lib/igt_sysfs: Let igt_sysfs_read|write return -errno

2017-12-07 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-07 16:52:46) > In some cases debugfs or sysfs may return errors that we > want to check. Return -errno from helper functions to make > asserts easier. > > v2: don't forget about EOF ret=0 (Chris) > small re-write (Michal) > > Signed-off-by: Michal Wajdeczko

[Intel-gfx] [PATCH i-g-t v2] lib/igt_sysfs: Let igt_sysfs_read|write return -errno

2017-12-07 Thread Michal Wajdeczko
In some cases debugfs or sysfs may return errors that we want to check. Return -errno from helper functions to make asserts easier. v2: don't forget about EOF ret=0 (Chris) small re-write (Michal) Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen --- lib/igt_sysfs.c | 4

Re: [Intel-gfx] [PATCH] drm/i915: Refactor common list iteration over GGTT vma

2017-12-07 Thread Ville Syrjälä
On Thu, Dec 07, 2017 at 04:46:37PM +, Chris Wilson wrote: > Quoting Ville Syrjälä (2017-12-07 16:40:49) > > On Thu, Dec 07, 2017 at 04:27:17PM +, Chris Wilson wrote: > > > +#define for_each_ggtt_vma(V, OBJ) \ > > > + list_for_each_entry(V, &(OBJ)->vma_list, obj_link) \ > >

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/gem_mocs_settings: Force use of master device

2017-12-07 Thread Patchwork
== Series Details == Series: igt/gem_mocs_settings: Force use of master device URL : https://patchwork.freedesktop.org/series/35019/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, ye

[Intel-gfx] ✓ Fi.CI.BAT: success for lib: Print other clients when DRM_SET_MASTER fails

2017-12-07 Thread Patchwork
== Series Details == Series: lib: Print other clients when DRM_SET_MASTER fails URL : https://patchwork.freedesktop.org/series/35023/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, y

[Intel-gfx] ✓ Fi.CI.BAT: success for tools: Cannonlake port clock programming

2017-12-07 Thread Patchwork
== Series Details == Series: tools: Cannonlake port clock programming URL : https://patchwork.freedesktop.org/series/35028/ State : success == Summary == IGT patchset tested on top of latest successful build 2fc64acf8a4465d5eab3d6cfec9b3c1b5df30d73 igt/perf_pmu: Tweak wait_for_rc6, yet again

Re: [Intel-gfx] [PATCH] drm: More debug info for fb leaks in mode_config_cleanup

2017-12-07 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 04:52:04PM +0100, Noralf Trønnes wrote: > > Den 07.12.2017 15.49, skrev Daniel Vetter: > > We're spotting this very rarely in CI, but have no idea. Let's add > > more debug info about what's going on here. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=10

Re: [Intel-gfx] [PATCH] drm/i915: Refactor common list iteration over GGTT vma

2017-12-07 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 04:27:17PM +, Chris Wilson wrote: > In quite a few places, we have a list iteration over the vma on an > object that only want to inspect GGTT vma. By construction, these are > placed at the start of the list, so we have copied that knowledge into > many callsites. Pull

Re: [Intel-gfx] [PATCH i-g-t 1/6] meson: Don't install headers

2017-12-07 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 03:40:26PM +0200, Petri Latvala wrote: > Until we can at least check for a matching ABI, the only supported way > of building is having the headers from the source checkout. > > Signed-off-by: Petri Latvala > Cc: Daniel Vetter Yeah we don't want the headers. Reviewed-by

Re: [Intel-gfx] [PATCH i-g-t 3/6] meson: Install benchmarks to $libexec/intel-gpu-tools/benchmarks

2017-12-07 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 06:32:58PM +0200, Ville Syrjälä wrote: > On Thu, Dec 07, 2017 at 03:40:28PM +0200, Petri Latvala wrote: > > Signed-off-by: Petri Latvala > > Cc: Daniel Vetter > > --- > > benchmarks/meson.build | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/benchmarks

Re: [Intel-gfx] [PATCH igt] lib: Print other clients when DRM_SET_MASTER fails

2017-12-07 Thread Daniel Vetter
On Thu, Dec 07, 2017 at 10:09:33AM +, Chris Wilson wrote: > It looks like there are some rogue processes running in CI that prevent > DRM_MASTER from being obtained. Dump the list of clients on failure to > make it more obvious what is being left behind. > > References: https://bugs.freedeskto

  1   2   >