Re: [Intel-gfx] [PATCH v3 3/9] drm: Add Content Protection property

2017-12-05 Thread Hans Verkuil
On 12/05/2017 06:15 AM, Sean Paul wrote: > This patch adds a new optional connector property to allow userspace to enable > protection over the content it is displaying. This will typically be > implemented > by the driver using HDCP. > > The property is a tri-state with the following values: > -

Re: [Intel-gfx] [PATCH] drm/i915: Fix compilation (panel orientation x enum plane rename).

2017-12-05 Thread Hans de Goede
Hi, On 05-12-17 01:58, Rodrigo Vivi wrote: On Tue, Dec 05, 2017 at 12:09:35AM +, Michel Thierry wrote: On 12/4/2017 4:04 PM, Rodrigo Vivi wrote: When commit '82daca297506 ("drm/i915: Add "panel orientation" property to the panel connector, v6.")' was done and tested by CI, commit 'ed15030d

Re: [Intel-gfx] [PATCH i-g-t 1/2] CONTRIBUTING: Fix spelling mistake and line length

2017-12-05 Thread Petri Latvala
On Tue, Dec 05, 2017 at 12:23:32AM -0500, Sean Paul wrote: > Noticed while I was reading it. Makes for a good first contribution, I > guess. > > Signed-off-by: Sean Paul Reviewed-by: Petri Latvala > --- > CONTRIBUTING | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_content_protection: Add Content Protection test

2017-12-05 Thread Petri Latvala
On Tue, Dec 05, 2017 at 12:23:33AM -0500, Sean Paul wrote: > Pretty simple test: > - initializes the output > - clears the content protection property > - verifies that it clears > - sets the content protection property to desired > - verifies that it transitions to enabled > > Does this for both

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] CONTRIBUTING: Fix spelling mistake and line length

2017-12-05 Thread Petri Latvala
On Tue, Dec 05, 2017 at 06:35:20AM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] CONTRIBUTING: Fix spelling mistake and > line length > URL : https://patchwork.freedesktop.org/series/34881/ > State : warning > > == Summary == > > Test gem_tiled_swapping

Re: [Intel-gfx] [PATCH i-g-t] intel_aubdump: Add ability to simulate execlist submission

2017-12-05 Thread Jordan Justen
On 2017-11-28 15:51:19, Scott D Phillips wrote: > Newer devices do not have the legacy ring buffer submission model, > so aub files generated using that model cannot be handled by some > internal tools. The execlist submission modeled by this change is > pretty simplistic, using GGTT only and synch

[Intel-gfx] [PATCH] drm/i915: Disable display crc feature for vgpu

2017-12-05 Thread Xiaolin Zhang
for vgpu, it doesn't support display crc feature. this patch is to skip pipe crc create and report ENODEV during set_crc_source. igt display crc relatated cases will be failed instead of dead sleep. Signed-off-by: Xiaolin Zhang --- drivers/gpu/drm/i915/intel_pipe_crc.c | 6 ++ 1 file changed

Re: [Intel-gfx] [PATCH v3 5/9] drm/i915: Add HDCP framework + base implementation

2017-12-05 Thread Ramalingam C
On Tuesday 05 December 2017 10:45 AM, Sean Paul wrote: This patch adds the framework required to add HDCP support to intel connectors. It implements Aksv loading from fuse, and parts 1/2/3 of the HDCP authentication scheme. Note that without shim implementations, this does not actually impleme

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable display crc feature for vgpu

2017-12-05 Thread Patchwork
== Series Details == Series: drm/i915: Disable display crc feature for vgpu URL : https://patchwork.freedesktop.org/series/34889/ State : success == Summary == Series 34889v1 drm/i915: Disable display crc feature for vgpu https://patchwork.freedesktop.org/api/1.0/series/34889/revisions/1/mbox/

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] CONTRIBUTING: Fix spelling mistake and line length

2017-12-05 Thread Petri Latvala
On Tue, Dec 05, 2017 at 10:26:50AM +0200, Petri Latvala wrote: > On Tue, Dec 05, 2017 at 06:35:20AM +, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [1/2] CONTRIBUTING: Fix spelling mistake and > > line length > > URL : https://patchwork.freedesktop.org/seri

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib: avoid < in gtkdoc comments

2017-12-05 Thread Joonas Lahtinen
On Mon, 2017-12-04 at 21:48 +0100, Daniel Vetter wrote: > For reasons entirely not clear to me meson gtkdoc runs in strict > xml parsing mode, whereas automake gtkdoc doesn't. And gtkdoc itself > is to dense to correctly escape this stuff. > > Paper around this. > > v2: {foo} instead of o

Re: [Intel-gfx] [PATCH i-g-t 2/3] meson: gtkdoc support

2017-12-05 Thread Petri Latvala
On Mon, Dec 04, 2017 at 09:48:36PM +0100, Daniel Vetter wrote: > Bunch of neat improvements: > > - xml generates correctly depend upon the test binaries > - no need to re-run autogen.sh when new chapters/functions get added, > all handed by meson > > Still one issue: > > - the gtkdoc target do

Re: [Intel-gfx] [PATCH] drm: savely free connectors from connector_iter

2017-12-05 Thread Daniel Vetter
On Mon, Dec 04, 2017 at 09:48:18PM +0100, Daniel Vetter wrote: > In > > commit 613051dac40da1751ab269572766d3348d45a197 > Author: Daniel Vetter > Date: Wed Dec 14 00:08:06 2016 +0100 > > drm: locking&new iterators for connector_list > > we've went to extreme lengths to make sure connector

Re: [Intel-gfx] [PATCH 3/3] i965: check scratch page in a locked fashion on each ioctl

2017-12-05 Thread Chris Wilson
Quoting kevin.rogo...@intel.com (2017-12-05 07:48:14) > From: Kevin Rogovin > > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 27 > ++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c > b/src/mesa

Re: [Intel-gfx] [PATCH] drm/i915: Fix compilation (panel orientation x enum plane rename).

2017-12-05 Thread Joonas Lahtinen
On Tue, 2017-12-05 at 09:18 +0100, Hans de Goede wrote: > Hi, > > On 05-12-17 01:58, Rodrigo Vivi wrote: > > On Tue, Dec 05, 2017 at 12:09:35AM +, Michel Thierry wrote: > > > On 12/4/2017 4:04 PM, Rodrigo Vivi wrote: > > > > When commit '82daca297506 ("drm/i915: Add "panel orientation" > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Fix compilation (panel orientation x enum plane rename).

2017-12-05 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 12:12:27PM +0200, Joonas Lahtinen wrote: > On Tue, 2017-12-05 at 09:18 +0100, Hans de Goede wrote: > > Hi, > > > > On 05-12-17 01:58, Rodrigo Vivi wrote: > > > On Tue, Dec 05, 2017 at 12:09:35AM +, Michel Thierry wrote: > > > > On 12/4/2017 4:04 PM, Rodrigo Vivi wrote:

[Intel-gfx] [PATCH i-g-t 1/1] lib/igt_gt: Add sentinel to intel_execution_engines2

2017-12-05 Thread Petri Latvala
The for_each_engine_class_instance macro stops at e__->name being NULL, so add an object that is so. Signed-off-by: Petri Latvala Cc: Tvrtko Ursulin Cc: Chris Wilson --- lib/igt_gt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/igt_gt.c b/lib/igt_gt.c index 4a8f541f..ad6e6205 100644

[Intel-gfx] [PATCH i-g-t 3/3] meson: build a full dependency for lib_igt_perf

2017-12-05 Thread Daniel Vetter
meson prefers packages dependencies over passing arount static libraries, because those also include linker flags, include dirs and everything else. While at it pull the special cases out from the common build stanzas like we do with other special cases. Just a bit of ocd to keep everything polis

[Intel-gfx] [PATCH i-g-t 2/3] meson: gtkdoc support

2017-12-05 Thread Daniel Vetter
Bunch of neat improvements: - xml generates correctly depend upon the test binaries - no need to re-run autogen.sh when new chapters/functions get added, all handed by meson Still one issue: - the gtkdoc target doesn't depend upon the custom_target yet, hacked around using build_by_default:

[Intel-gfx] [PATCH i-g-t 1/3] lib: avoid < in gtkdoc comments

2017-12-05 Thread Daniel Vetter
For reasons entirely not clear to me meson gtkdoc runs in strict xml parsing mode, whereas automake gtkdoc doesn't. And gtkdoc itself is to dense to correctly escape this stuff. Paper around this. v2: {foo} instead of of tripy (Joonas) v3: More fixups (Joonas) Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH i-g-t 1/1] lib/igt_gt: Add sentinel to intel_execution_engines2

2017-12-05 Thread Tvrtko Ursulin
On 05/12/2017 10:16, Petri Latvala wrote: The for_each_engine_class_instance macro stops at e__->name being NULL, so add an object that is so. Signed-off-by: Petri Latvala Cc: Tvrtko Ursulin Cc: Chris Wilson --- lib/igt_gt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/igt_gt.c

[Intel-gfx] [PATCH] drm/i915: Generalize definition for crtc mask

2017-12-05 Thread Mika Kahola
crtc_mask is defined explicitly defined for a certain number of pipes per platform. Let's generalize this in a way that crtc_mask dependens only on the number of pipes defined in device info. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_crt.c | 9 ++--- drivers/gpu/drm/i915/in

Re: [Intel-gfx] [PATCH 3/3] i965: check scratch page in a locked fashion on each ioctl

2017-12-05 Thread Rogovin, Kevin
Hi, > Per context, then you can remove the locking. It's fitting since the scratch > page is per-context anyway. The scratch page is per context? This I did not know, I thought it was per PPGTT. If that is the case, then my proposed interface to get/set the scratch page contents is wrong beca

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable display crc feature for vgpu

2017-12-05 Thread Patchwork
== Series Details == Series: drm/i915: Disable display crc feature for vgpu URL : https://patchwork.freedesktop.org/series/34889/ State : success == Summary == Test gem_tiled_swapping: Subgroup non-threaded: pass -> INCOMPLETE (shard-snb) fdo#104009 Test gem_eio:

Re: [Intel-gfx] [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-05 Thread Pavel Machek
On Wed 2017-11-29 22:08:56, Sean Paul wrote: > This patch adds a new optional connector property to allow userspace to enable > protection over the content it is displaying. This will typically be > implemented > by the driver using HDCP. > > The property is a tri-state with the following values:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] lib/igt_gt: Add sentinel to intel_execution_engines2

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/1] lib/igt_gt: Add sentinel to intel_execution_engines2 URL : https://patchwork.freedesktop.org/series/34892/ State : success == Summary == IGT patchset tested on top of latest successful build ece35d37e6b0afc0ba99f66179279960042c87bc tests

Re: [Intel-gfx] [PATCH 3/3] i965: check scratch page in a locked fashion on each ioctl

2017-12-05 Thread Chris Wilson
Quoting Rogovin, Kevin (2017-12-05 10:30:04) > Hi, > > > Per context, then you can remove the locking. It's fitting since the > > scratch page is per-context anyway. > > The scratch page is per context? This I did not know, I thought it was per > PPGTT. If that is the case, then my proposed in

Re: [Intel-gfx] [PATCH 3/3] i965: check scratch page in a locked fashion on each ioctl

2017-12-05 Thread Rogovin, Kevin
Thanks, I will make a v2 and post it shortly to correct for my terribly embarrassing omission caused by even more terribly embarrassing ignorance. -Kevin -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Tuesday, December 5, 2017 12:39 PM To: Rogovin, Kevin ;

Re: [Intel-gfx] [PATCH] drm/i915: Fix compilation (panel orientation x enum plane rename).

2017-12-05 Thread Hans de Goede
Hi, On 05-12-17 11:14, Daniel Vetter wrote: On Tue, Dec 05, 2017 at 12:12:27PM +0200, Joonas Lahtinen wrote: On Tue, 2017-12-05 at 09:18 +0100, Hans de Goede wrote: Hi, On 05-12-17 01:58, Rodrigo Vivi wrote: On Tue, Dec 05, 2017 at 12:09:35AM +, Michel Thierry wrote: On 12/4/2017 4:04 P

Re: [Intel-gfx] [PATCH i-g-t 3/3] meson: build a full dependency for lib_igt_perf

2017-12-05 Thread Petri Latvala
On Tue, Dec 05, 2017 at 11:16:50AM +0100, Daniel Vetter wrote: > meson prefers packages dependencies over passing arount static > libraries, because those also include linker flags, include dirs and > everything else. > > While at it pull the special cases out from the common build stanzas > like

Re: [Intel-gfx] [RFC PATCH 1/6] drm: Add Content Protection property

2017-12-05 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 11:28:40AM +0100, Pavel Machek wrote: > On Wed 2017-11-29 22:08:56, Sean Paul wrote: > > This patch adds a new optional connector property to allow userspace to > > enable > > protection over the content it is displaying. This will typically be > > implemented > > by the d

[Intel-gfx] [PATCH igt 1/2] igt/pm_rc6_residency: Replace hard-coded sleep before rc6 with a probe

2017-12-05 Thread Chris Wilson
Instead of trying to sleep for 2 evaluations intervals and then assuming that rc6 is working, poll the rc6 residency instead. References: https://bugs.freedesktop.org/show_bug.cgi?id=104099 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/pm_rc6_residency.c | 33 ++--

[Intel-gfx] [PATCH igt 2/2] igt/perf_pmu: Replace hard-coded sleep before rc6 with a probe

2017-12-05 Thread Chris Wilson
Instead of trying to sleep for 2 evaluations intervals and then assuming that rc6 is working, poll the rc6 residency instead. References: https://bugs.freedesktop.org/show_bug.cgi?id=103929 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/perf_pmu.c | 16 +++- 1 file changed

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Generalize definition for crtc mask

2017-12-05 Thread Patchwork
== Series Details == Series: drm/i915: Generalize definition for crtc mask URL : https://patchwork.freedesktop.org/series/34894/ State : warning == Summary == Series 34894v1 drm/i915: Generalize definition for crtc mask https://patchwork.freedesktop.org/api/1.0/series/34894/revisions/1/mbox/

Re: [Intel-gfx] [PATCH i-g-t 3/3] meson: build a full dependency for lib_igt_perf

2017-12-05 Thread Petri Latvala
On Tue, Dec 05, 2017 at 12:44:02PM +0200, Petri Latvala wrote: > On Tue, Dec 05, 2017 at 11:16:50AM +0100, Daniel Vetter wrote: > > meson prefers packages dependencies over passing arount static > > libraries, because those also include linker flags, include dirs and > > everything else. > > > > W

[Intel-gfx] [PATCH 2/2] drm/i915: Assert GGTT writes were flushed before unbinding a GGTT vma

2017-12-05 Thread Chris Wilson
As writes through the GTT and GGTT PTE updates do not share the same path, they are not strictly ordered and so we must explicitly flush the indirect writes prior to modifying the PTE. However, we track the PTE using multiple vma, but only a single write_domain on the object, so before unbinding an

[Intel-gfx] [PATCH 1/2] drm/i915: Flush pending GTT writes before unbinding

2017-12-05 Thread Chris Wilson
From the shrinker paths, we want to relinquish the GPU and GGTT access to the object, releasing the backing storage back to the system for swapout. As a part of that process we would unpin the pages, marking them for access by the CPU (for the swapout/swapin). However, if that process was interrupt

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] lib: avoid < in gtkdoc comments

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/3] lib: avoid < in gtkdoc comments URL : https://patchwork.freedesktop.org/series/34893/ State : success == Summary == IGT patchset tested on top of latest successful build ece35d37e6b0afc0ba99f66179279960042c87bc tests/gem_seqno_wrap: Drop

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/1] lib/igt_gt: Add sentinel to intel_execution_engines2

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/1] lib/igt_gt: Add sentinel to intel_execution_engines2 URL : https://patchwork.freedesktop.org/series/34892/ State : failure == Summary == Test drv_module_reload: Subgroup basic-no-display: pass -> DMESG-WARN

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding URL : https://patchwork.freedesktop.org/series/34899/ State : failure == Summary == Series 34899v1 series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding https:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] igt/pm_rc6_residency: Replace hard-coded sleep before rc6 with a probe

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] igt/pm_rc6_residency: Replace hard-coded sleep before rc6 with a probe URL : https://patchwork.freedesktop.org/series/34897/ State : success == Summary == IGT patchset tested on top of latest successful build ece35d37e6b0afc0ba99f6617927

Re: [Intel-gfx] [PATCH igt 2/2] igt/perf_pmu: Replace hard-coded sleep before rc6 with a probe

2017-12-05 Thread Tvrtko Ursulin
On 05/12/2017 10:56, Chris Wilson wrote: Instead of trying to sleep for 2 evaluations intervals and then assuming that rc6 is working, poll the rc6 residency instead. References: https://bugs.freedesktop.org/show_bug.cgi?id=103929 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/per

Re: [Intel-gfx] [PATCH igt 1/2] igt/pm_rc6_residency: Replace hard-coded sleep before rc6 with a probe

2017-12-05 Thread Tvrtko Ursulin
On 05/12/2017 10:56, Chris Wilson wrote: Instead of trying to sleep for 2 evaluations intervals and then assuming that rc6 is working, poll the rc6 residency instead. References: https://bugs.freedesktop.org/show_bug.cgi?id=104099 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/pm_

Re: [Intel-gfx] [PATCH igt 2/2] igt/perf_pmu: Replace hard-coded sleep before rc6 with a probe

2017-12-05 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-05 12:05:14) > > On 05/12/2017 10:56, Chris Wilson wrote: > > Instead of trying to sleep for 2 evaluations intervals and then assuming > > that rc6 is working, poll the rc6 residency instead. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=103929 >

[Intel-gfx] [PATCH 1/2] drm/i915: Flush pending GTT writes before unbinding

2017-12-05 Thread Chris Wilson
From the shrinker paths, we want to relinquish the GPU and GGTT access to the object, releasing the backing storage back to the system for swapout. As a part of that process we would unpin the pages, marking them for access by the CPU (for the swapout/swapin). However, if that process was interrupt

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] lib: avoid < in gtkdoc comments

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/3] lib: avoid < in gtkdoc comments URL : https://patchwork.freedesktop.org/series/34893/ State : failure == Summary == Test kms_flip: Subgroup plain-flip-fb-recreate-interruptible: pass -> FAIL (shard-hsw)

[Intel-gfx] [PATCH 2/2] drm/i915: Track GGTT on the vma

2017-12-05 Thread Chris Wilson
As writes through the GTT and GGTT PTE updates do not share the same path, they are not strictly ordered and so we must explicitly flush the indirect writes prior to modifying the PTE. We do track outstanding GGTT writes on the object itself, but since the object may have multiple GGTT vma, that is

[Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-12-05 Thread Chris Wilson
Checking for a tainted kernel is a convenient way to see if the test generated a critical error such as a oops, or machine check. v2: Docs? Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Radoslaw Szwichtenberg Reviewed-by: Joonas Lahtinen --- lib/Makefile.sources | 2 + lib/igt_core.c

Re: [Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-12-05 Thread Petri Latvala
On Tue, Dec 05, 2017 at 12:24:53PM +, Chris Wilson wrote: > Checking for a tainted kernel is a convenient way to see if the test > generated a critical error such as a oops, or machine check. > > v2: Docs? > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Radoslaw Szwichtenberg > R

Re: [Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-12-05 Thread Chris Wilson
Quoting Petri Latvala (2017-12-05 12:32:36) > On Tue, Dec 05, 2017 at 12:24:53PM +, Chris Wilson wrote: > > Checking for a tainted kernel is a convenient way to see if the test > > generated a critical error such as a oops, or machine check. > > > > v2: Docs? > > > > Signed-off-by: Chris Wils

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] igt/pm_rc6_residency: Replace hard-coded sleep before rc6 with a probe

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] igt/pm_rc6_residency: Replace hard-coded sleep before rc6 with a probe URL : https://patchwork.freedesktop.org/series/34897/ State : warning == Summary == Test kms_setmode: Subgroup basic: fail -> PASS

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding URL : https://patchwork.freedesktop.org/series/34900/ State : failure == Summary == Series 34900v1 series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding https:

Re: [Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-12-05 Thread Petri Latvala
On Tue, Dec 05, 2017 at 12:38:19PM +, Chris Wilson wrote: > Quoting Petri Latvala (2017-12-05 12:32:36) > > On Tue, Dec 05, 2017 at 12:24:53PM +, Chris Wilson wrote: > > > Checking for a tainted kernel is a convenient way to see if the test > > > generated a critical error such as a oops, o

Re: [Intel-gfx] [PATCH] drm/i915/skl: DMC firmware for skylake v1.27

2017-12-05 Thread Imre Deak
On Thu, Nov 09, 2017 at 05:18:32PM -0800, Anusha Srivatsa wrote: > There is a new version of dmc available for skylake. > Following additions from ver1.27 > > 1. Fix for the issue where DC_STATE was getting enabled even when > disabled by driver causing data corruption. > > Cc: Rodrigo Vivi > Si

Re: [Intel-gfx] [PATCH v5] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-12-05 Thread Imre Deak
On Sat, Dec 02, 2017 at 01:58:12AM +0200, Rogozhkin, Dmitry V wrote: > On Thu, 2017-11-30 at 13:19 +0200, Imre Deak wrote: > > On Thu, Nov 30, 2017 at 09:45:25AM +, Chris Wilson wrote: > > > Quoting Tvrtko Ursulin (2017-11-30 09:18:20) > > > > From: Tvrtko Ursulin > > > > > > > > It seems tha

Re: [Intel-gfx] [PATCH v5] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-12-05 Thread Imre Deak
On Sat, Dec 02, 2017 at 02:05:42AM +0200, Rogozhkin, Dmitry V wrote: > On Thu, 2017-11-30 at 13:19 +0200, Imre Deak wrote: > > > > +#define NEEDS_CSR_GT_PERF_WA(dev_priv) \ > > > > + (HAS_CSR(dev_priv) && IS_GEN9(dev_priv) && ! > > IS_SKYLAKE(dev_priv)) > > > > Nitpick: could be just !IS_SKY

[Intel-gfx] [PATCH v2] drm/i915: Track GGTT writes on the vma

2017-12-05 Thread Chris Wilson
As writes through the GTT and GGTT PTE updates do not share the same path, they are not strictly ordered and so we must explicitly flush the indirect writes prior to modifying the PTE. We do track outstanding GGTT writes on the object itself, but since the object may have multiple GGTT vma, that is

[Intel-gfx] [PATCH v6] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-12-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It seems that the DMC likes to transition between the DC states a lot when there are no connected displays (no active power domains) during command submission. This activity on DC states has a negative impact on the performance of the chip with huge latencies observed in the

Re: [Intel-gfx] [PATCH v6] drm/i915: Restore GT performance in headless mode with DMC loaded

2017-12-05 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-05 13:28:54) > From: Tvrtko Ursulin > > It seems that the DMC likes to transition between the DC states a lot when > there are no connected displays (no active power domains) during command > submission. > > This activity on DC states has a negative impact on the

Re: [Intel-gfx] [PATCH] drm/i915: Fix compilation (panel orientation x enum plane rename).

2017-12-05 Thread Ville Syrjälä
On Mon, Dec 04, 2017 at 04:04:15PM -0800, Rodrigo Vivi wrote: > When commit '82daca297506 ("drm/i915: Add "panel orientation" > property to the panel connector, v6.")' was done and tested > by CI, commit 'ed15030d7ab0 ("drm/i915: s/enum plane/enum > i9xx_plane_id/")' wasn't there already. > > On t

Re: [Intel-gfx] [RFC PATCH 0/6] drm/i915: Implement HDCP

2017-12-05 Thread Ville Syrjälä
On Thu, Nov 30, 2017 at 08:50:38AM +0100, Daniel Vetter wrote: > On Wed, Nov 29, 2017 at 10:08:55PM -0500, Sean Paul wrote: > > Here's the RFC for my i915 HDCP patchset. The UABI is based on what we've > > been > > using in Chrome for the past 3 years. I posted the property to the list back > > th

Re: [Intel-gfx] [RFC 1/4] drm/i915/perf: Add support to correlate GPU timestamp with system time

2017-12-05 Thread Lionel Landwerlin
On 15/11/17 12:25, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-11-15 12:13:51) #include #include @@ -2149,6 +2150,14 @@ struct i915_perf_stream { * @oa_config: The OA configuration used by the stream. */ struct i915_oa_config *oa_config; + + /** +

Re: [Intel-gfx] [PATCH 3/3] i965: check scratch page in a locked fashion on each ioctl

2017-12-05 Thread Joonas Lahtinen
On Tue, 2017-12-05 at 10:41 +, Rogovin, Kevin wrote: > Thanks, I will make a v2 and post it shortly to correct for my > terribly embarrassing omission caused by even more terribly > embarrassing ignorance. To avoid v3, do concept the code around suggested existing I915_GEM_CONTEXT_GETPARAM and

Re: [Intel-gfx] [PATCH] drm/i915: Generalize definition for crtc mask

2017-12-05 Thread Ville Syrjälä
On Tue, Dec 05, 2017 at 12:15:39PM +0200, Mika Kahola wrote: > crtc_mask is defined explicitly defined for a certain number of pipes per > platform. Let's generalize this in a way that crtc_mask dependens only on > the number of pipes defined in device info. > > Signed-off-by: Mika Kahola > --- >

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/skl: DMC firmware for skylake v1.27

2017-12-05 Thread Imre Deak
On Fri, Nov 10, 2017 at 09:20:10AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/skl: DMC firmware for skylake v1.27 > URL : https://patchwork.freedesktop.org/series/33568/ > State : warning Thanks for the patch, pushed it to drm-tip. > > == Summary == > > Test kms_setm

Re: [Intel-gfx] [PATCH] drm/i915: Fix compilation (panel orientation x enum plane rename).

2017-12-05 Thread Joonas Lahtinen
On Tue, 2017-12-05 at 15:38 +0200, Ville Syrjälä wrote: > On Mon, Dec 04, 2017 at 04:04:15PM -0800, Rodrigo Vivi wrote: > > When commit '82daca297506 ("drm/i915: Add "panel orientation" > > property to the panel connector, v6.")' was done and tested > > by CI, commit 'ed15030d7ab0 ("drm/i915: s/enu

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-05 Thread Lionel Landwerlin
Hey Sagar, Sorry for the delay looking into this series. I've done some userspace/UI work in GPUTop to try to correlate perf samples/tracepoints with i915 perf reports. I wanted to avoid having to add too much logic into the kernel and tried to sample both cpu clocks & gpu timestamps from use

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding (rev2)

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding (rev2) URL : https://patchwork.freedesktop.org/series/34900/ State : success == Summary == Series 34900v2 series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding

Re: [Intel-gfx] [RFC 4/4] drm/i915/perf: Send system clock monotonic time in perf samples

2017-12-05 Thread Lionel Landwerlin
On 15/11/17 12:13, Sagar Arun Kamble wrote: From: Sourab Gupta Currently, we have the ability to only forward the GPU timestamps in the samples (which are generated via OA reports). This limits the ability to correlate these samples with the system events. An ability is therefore needed to rep

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-05 Thread Robert Bragg
On Tue, Dec 5, 2017 at 2:16 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Hey Sagar, > > Sorry for the delay looking into this series. > I've done some userspace/UI work in GPUTop to try to correlate perf > samples/tracepoints with i915 perf reports. > > I wanted to avoid having

Re: [Intel-gfx] [PATCH v3 9/9] drm/i915: Implement HDCP for DisplayPort

2017-12-05 Thread Ramalingam C
On Tuesday 05 December 2017 10:45 AM, Sean Paul wrote: +static +bool intel_dp_hdcp_check_link(struct intel_digital_port *intel_dig_port) +{ + ssize_t ret; + u8 bstatus; + ret = drm_dp_dpcd_read(&intel_dig_port->dp.aux, DP_AUX_HDCP_BSTATUS, + &bstat

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-05 Thread Lionel Landwerlin
On 05/12/17 14:28, Robert Bragg wrote: On Tue, Dec 5, 2017 at 2:16 PM, Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: Hey Sagar, Sorry for the delay looking into this series. I've done some userspace/UI work in GPUTop to try to correlate perf samples/tracep

Re: [Intel-gfx] [RFC PATCH 0/6] drm/i915: Implement HDCP

2017-12-05 Thread Sean Paul
On Tue, Dec 5, 2017 at 8:45 AM, Ville Syrjälä wrote: > On Thu, Nov 30, 2017 at 08:50:38AM +0100, Daniel Vetter wrote: >> On Wed, Nov 29, 2017 at 10:08:55PM -0500, Sean Paul wrote: >> > Here's the RFC for my i915 HDCP patchset. The UABI is based on what we've >> > been >> > using in Chrome for the

Re: [Intel-gfx] [PATCH] drm/i915: Generalize definition for crtc mask

2017-12-05 Thread Mika Kahola
On Tue, 2017-12-05 at 15:59 +0200, Ville Syrjälä wrote: > On Tue, Dec 05, 2017 at 12:15:39PM +0200, Mika Kahola wrote: > > > > crtc_mask is defined explicitly defined for a certain number of > > pipes per > > platform. Let's generalize this in a way that crtc_mask dependens > > only on > > the num

Re: [Intel-gfx] Fixes that failed to cleanly apply to v4.15-rc1

2017-12-05 Thread Joonas Lahtinen
Dropping GVT folks that are not affected. Keeping Zhenyu and Zhi as a heads-up, there's no need for GVT pull for this rc? On Tue, 2017-11-28 at 10:54 +0200, Joonas Lahtinen wrote: > Hello, > > TL;DR Reply with backported patches for v4.15-rc1 latest TODAY > > Dear patch authors/Cc:s, the follow

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Restore GT performance in headless mode with DMC loaded (rev6)

2017-12-05 Thread Patchwork
== Series Details == Series: drm/i915: Restore GT performance in headless mode with DMC loaded (rev6) URL : https://patchwork.freedesktop.org/series/24017/ State : failure == Summary == Series 24017v6 drm/i915: Restore GT performance in headless mode with DMC loaded https://patchwork.freedeskt

Re: [Intel-gfx] [PATCH v3 3/9] drm: Add Content Protection property

2017-12-05 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 09:07:58AM +0100, Hans Verkuil wrote: > On 12/05/2017 06:15 AM, Sean Paul wrote: > > This patch adds a new optional connector property to allow userspace to > > enable > > protection over the content it is displaying. This will typically be > > implemented > > by the drive

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Implement HDCP (rev3)

2017-12-05 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 05:21:25AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Implement HDCP (rev3) > URL : https://patchwork.freedesktop.org/series/34671/ > State : failure > > == Summary == > > Applying: drm: Fix link-status kerneldoc line lengths > error: Failed to

[Intel-gfx] [PATCH] lockdep: Mark up lock disabling with TAINT_CRAP

2017-12-05 Thread Chris Wilson
When testing with lockdep disabled, if it becomes disabled due to some error or other that makes subsequenting testing incomplete, it taints the test result. Make this obvious to the test infrastructure by adding TAINT_CRAP. Signed-off-by: Chris Wilson Cc: Tomi Sarvela Cc: Daniel Vetter --- Tho

Re: [Intel-gfx] [PATCH v3 3/9] drm: Add Content Protection property

2017-12-05 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 12:15:02AM -0500, Sean Paul wrote: > This patch adds a new optional connector property to allow userspace to enable > protection over the content it is displaying. This will typically be > implemented > by the driver using HDCP. > > The property is a tri-state with the fol

Re: [Intel-gfx] [PATCH v3 3/9] drm: Add Content Protection property

2017-12-05 Thread Chris Wilson
Quoting Daniel Vetter (2017-12-05 15:34:36) > Two bits missing imo: > - Should explain that userspace should poll this property to detect a > change from ENABLED to DESIRED (and take adequate actions and e.g. stop > the stream). No uevent will be sent out because the HDCP specs require > poll

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_content_protection: Add Content Protection test

2017-12-05 Thread Sean Paul
On Tue, Dec 5, 2017 at 3:22 AM, Petri Latvala wrote: > On Tue, Dec 05, 2017 at 12:23:33AM -0500, Sean Paul wrote: >> Pretty simple test: >> - initializes the output >> - clears the content protection property >> - verifies that it clears >> - sets the content protection property to desired >> - ve

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_content_protection: Add Content Protection test

2017-12-05 Thread Ville Syrjälä
On Tue, Dec 05, 2017 at 12:23:33AM -0500, Sean Paul wrote: > Pretty simple test: > - initializes the output > - clears the content protection property > - verifies that it clears > - sets the content protection property to desired > - verifies that it transitions to enabled Can we get a chamelium

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_content_protection: Add Content Protection test

2017-12-05 Thread Sean Paul
On Tue, Dec 5, 2017 at 11:07 AM, Ville Syrjälä wrote: > On Tue, Dec 05, 2017 at 12:23:33AM -0500, Sean Paul wrote: >> Pretty simple test: >> - initializes the output >> - clears the content protection property >> - verifies that it clears >> - sets the content protection property to desired >> - v

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Put all non-blocking modesets onto an ordered wq

2017-12-05 Thread Patchwork
== Series Details == Series: drm/i915: Put all non-blocking modesets onto an ordered wq URL : https://patchwork.freedesktop.org/series/33712/ State : success == Summary == Series 33712v1 drm/i915: Put all non-blocking modesets onto an ordered wq https://patchwork.freedesktop.org/api/1.0/series

[Intel-gfx] [PATCH v3 1/8] drm/i915/huc: Move firmware selection to init_early

2017-12-05 Thread Michal Wajdeczko
Doing HuC firmware path selection from sanitize_options function is not perfect, while there is no problem with doing so during early init stage as we already have all needed data. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Reviewed-by: Chris Wil

[Intel-gfx] [PATCH v3 2/8] drm/i915/guc: Move firmware selection to init_early

2017-12-05 Thread Michal Wajdeczko
Doing GuC firmware path selection from sanitize_options function is not perfect, while there is no problem with doing so during early init stage as we already have all needed data. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Reviewed-by: Chris Wil

[Intel-gfx] [PATCH v3 4/8] drm/i915/uc: Don't fetch GuC firmware if no plan to use GuC

2017-12-05 Thread Michal Wajdeczko
If we don't plan to use GuC then we should not try to fetch GuC and HuC firmwares. We can save memory and avoid possible dmesg noise. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_uc.c | 6 ++ 1 file changed, 6 in

[Intel-gfx] [PATCH v3 6/8] drm/i915/guc: Combine enable_guc_loading|submission modparams

2017-12-05 Thread Michal Wajdeczko
We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need submission=1, we also need loading=1. We also need loading=1 when we want to want to load and verify the HuC. Lets combine above module parameters into one "enable_guc" modp

[Intel-gfx] [PATCH v3 8/8] HAX enable GuC/HuC load

2017-12-05 Thread Michal Wajdeczko
Also revert ("drm/i915/guc: Assert that we switch between known ggtt->invalidate functions") v2: don't enable GuC on GLK Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++-- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_uc.c | 2 ++

[Intel-gfx] [PATCH v3 5/8] drm/i915/uc: Don't use -EIO to report missing firmware

2017-12-05 Thread Michal Wajdeczko
-EIO has special meaning and is used when we want to allow engine initialization to fail and mark GPU as wedged. However here at this function we should return error code that corresponds to upload status only, as any decision how to handle missing firmware should be done higher level function (si

[Intel-gfx] [PATCH v3 3/8] drm/i915/guc: Introduce USES_GUC_xxx helper macros

2017-12-05 Thread Michal Wajdeczko
In the upcoming patch we will change the way how to recognize when GuC is in use. Using helper macros will minimize scope of that changes. While here, update dev_info message. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Reviewed-by: Chris Wilson

[Intel-gfx] [PATCH v3 7/8] drm/i915/huc: Load HuC only if requested

2017-12-05 Thread Michal Wajdeczko
Our new "enable_guc" modparam allows to control whenever HuC should be loaded. However existing code will try load and authenticate HuC always when we use the GuC. This patch is trying to enforce modparam selection. v2: no need to cast PTR_ERR (Chris) fetch/fini only if required (Michal) f

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding (rev2)

2017-12-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush pending GTT writes before unbinding (rev2) URL : https://patchwork.freedesktop.org/series/34900/ State : warning == Summary == Test kms_draw_crc: Subgroup draw-method-xrgb2101010-mmap-wc-untiled: p

Re: [Intel-gfx] [PATCH v2] drm/i915: Taint (TAINT_DIE) the kernel if the GPU reset fails

2017-12-05 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-12-04 13:41:11) > On Wed, 2017-11-29 at 14:05 +, Chris Wilson wrote: > > History tells us that if we cannot reset the GPU now, we never will. This > > then impacts everything that is run subsequently. On failing the reset, > > we mark the driver as wedged, trying t

[Intel-gfx] ✓ Fi.CI.BAT: success for lockdep: Mark up lock disabling with TAINT_CRAP

2017-12-05 Thread Patchwork
== Series Details == Series: lockdep: Mark up lock disabling with TAINT_CRAP URL : https://patchwork.freedesktop.org/series/34915/ State : success == Summary == Series 34915v1 lockdep: Mark up lock disabling with TAINT_CRAP https://patchwork.freedesktop.org/api/1.0/series/34915/revisions/1/mbo

[Intel-gfx] [PATCH] intel/atomic: Stop updating legacy fb parameters

2017-12-05 Thread Daniel Vetter
Even fbc isn't using this stuff anymore, so time to remove it. Cleaning up one small piece of the atomic conversion cruft at the time ... Cc: Paulo Zanoni Cc: Ville Syrjälä Cc: Maarten Lankhorst Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 29 --

Re: [Intel-gfx] [PATCH v3 5/9] drm/i915: Add HDCP framework + base implementation

2017-12-05 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 12:15:04AM -0500, Sean Paul wrote: > This patch adds the framework required to add HDCP support to intel > connectors. It implements Aksv loading from fuse, and parts 1/2/3 > of the HDCP authentication scheme. > > Note that without shim implementations, this does not actual

Re: [Intel-gfx] [PATCH v3 6/9] drm/i915: Make use of indexed write GMBUS feature

2017-12-05 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 12:15:05AM -0500, Sean Paul wrote: > This patch enables the indexed write feature of the GMBUS to concatenate > 2 consecutive messages into one. The criteria for an indexed write is > that both messages are writes, the first is length == 1, and the second > is length > 0. Th

Re: [Intel-gfx] [PATCH v3 7/9] drm/i915: Add function to output Aksv over GMBUS

2017-12-05 Thread Daniel Vetter
On Tue, Dec 05, 2017 at 12:15:06AM -0500, Sean Paul wrote: > Once the Aksv is available in the PCH, we need to get it on the wire to > the receiver via DDC. The hardware doesn't allow us to read the value > directly, so we need to tell GMBUS to source the Aksv internally and > send it to the right

  1   2   >