Re: [Intel-gfx] [PATCH 1/2] lockdep: finer-grained completion key for kthread

2017-12-04 Thread Daniel Vetter
On Wed, Nov 29, 2017 at 04:41:44PM +0100, Daniel Vetter wrote: > Ideally we'd create the key through a macro at the real callers and > pass it all the way down. This would give us better coverage for cases > where a bunch of kthreads are created for the same thing. > But this gets the job done mean

[Intel-gfx] [PATCH igt 04/10] igt/gem_ctx_switch: Do a warmup pass over all contexts

2017-12-04 Thread Chris Wilson
Ensure that we always use every context at least once before we start running the stress-test. Signed-off-by: Chris Wilson --- tests/gem_ctx_switch.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/gem_ctx_switch.c b/tests/gem_ctx_switch.c index fdd67202..159554e5 100644 --- a/t

[Intel-gfx] [PATCH igt 03/10] igt/gem_ctx_isolation: Check isolation of registers between contexts

2017-12-04 Thread Chris Wilson
A new context assumes that all of its registers are in the default state when it is created. What may happen is that a register written by one context may leak into the second, causing mass confusion. v2: Extend back to Sandybridge (etc) v3: Check context preserves registers across suspend/hiberna

[Intel-gfx] [PATCH igt 06/10] igt/gem_exec_capture: Exercise readback of userptr

2017-12-04 Thread Chris Wilson
EXEC_OBJECT_CAPTURE extends the type of buffers we may read during error capture. Previously we knew that we would only see batch buffers (which limited the objects to being from gem_create()), but now we need to check that any buffer the user can create can be read. The first alternate buffer type

[Intel-gfx] [PATCH igt 08/10] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-12-04 Thread Chris Wilson
CI doesn't run in whole-test mode, but runs each subtest individually. Tests that are designed to do a block of work to be shared between many subtests end up running that work multiple times (once per subtest) and worse, that work is wasted if the subtest will be skipped. pm_rc6_residency is one

[Intel-gfx] [PATCH igt 01/10] igt/perf_pmu: Tighten semaphore-wait measurement

2017-12-04 Thread Chris Wilson
Record the before/after semaphore-wait values around the sleep to try to reduce the inaccuracy from scheduler delays. Previously, the samples were taken before submitting the batch and then after synchronising its completion. The measurement will then be the total that the semaphore was being sampl

[Intel-gfx] [PATCH igt 07/10] igt/gem_exec_fence: Exercise merging fences

2017-12-04 Thread Chris Wilson
Execute the same batch on each engine and check that the composite fence across all engines completes only after the batch is completed on every engine. Signed-off-by: Chris Wilson --- tests/gem_exec_fence.c | 127 + 1 file changed, 127 insertions(

[Intel-gfx] [PATCH igt 05/10] igt/gem_ctx_switch: Exercise all engines at once

2017-12-04 Thread Chris Wilson
Just a small variant to apply a continuous context-switch load to all engines. --- tests/gem_ctx_switch.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/tests/gem_ctx_switch.c b/tests/gem_ctx_switch.c index 159554e5..fe919f7d 100644 --- a/te

[Intel-gfx] [PATCH igt 09/10] lib/dummyload: Wrap global list inside its own mutex

2017-12-04 Thread Chris Wilson
Give the list a mutex, for we try to iterate over it from many a random context. Signed-off-by: Chris Wilson --- lib/igt_dummyload.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/igt_dummyload.c b/lib/igt_dummyload.c index bb2be557..d19b4e5e 100644 --- a/lib/igt_dummyload.c +++

[Intel-gfx] [PATCH igt 10/10] lib/kms: Clear unused fields for getproperty ioctl

2017-12-04 Thread Chris Wilson
==24749== Syscall param ioctl(generic) points to uninitialised byte(s) ==24749==at 0x6A8ADC7: ioctl (syscall-template.S:84) ==24749==by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0) ==24749==by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022) ==24749==by 0x112937: se

[Intel-gfx] [PATCH igt 02/10] igt/gem_busy: Replace arbitrary busy batch with indefinite spinbatch

2017-12-04 Thread Chris Wilson
In CI, we were observing situations where the busy blt would complete before the very next instruction (in userspace) to assert that it was busy. This is entirely possible if the process was scheduled away and slept for longer than the arbitrary batch. Instead replace arbitrariness with a precise i

Re: [Intel-gfx] [PATCH igt 08/10] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-12-04 Thread Ewelina Musial
On Mon, Dec 04, 2017 at 09:27:29AM +, Chris Wilson wrote: > CI doesn't run in whole-test mode, but runs each subtest individually. > Tests that are designed to do a block of work to be shared between many > subtests end up running that work multiple times (once per subtest) and > worse, that wo

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] igt/perf_pmu: Tighten semaphore-wait measurement

2017-12-04 Thread Patchwork
== Series Details == Series: series starting with [01/10] igt/perf_pmu: Tighten semaphore-wait measurement URL : https://patchwork.freedesktop.org/series/34818/ State : success == Summary == IGT patchset tested on top of latest successful build 476c4b462e0453c70ee81664c0227fdddc26cbd0 igt/gem

Re: [Intel-gfx] [PATCH igt] igt/gem_ctx_isolation: Check isolation of registers between contexts

2017-12-04 Thread Joonas Lahtinen
On Fri, 2017-12-01 at 11:13 +, Chris Wilson wrote: > A new context assumes that all of its registers are in the default state > when it is created. What may happen is that a register written by one > context may leak into the second, causing mass confusion. > > v2: Extend back to Sandybridge (

Re: [Intel-gfx] [PATCH igt 08/10] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-12-04 Thread Ewelina Musial
On Mon, Dec 04, 2017 at 09:27:29AM +, Chris Wilson wrote: > CI doesn't run in whole-test mode, but runs each subtest individually. > Tests that are designed to do a block of work to be shared between many > subtests end up running that work multiple times (once per subtest) and > worse, that wo

Re: [Intel-gfx] [PATCH igt] igt/gem_ctx_isolation: Check isolation of registers between contexts

2017-12-04 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-12-04 10:23:11) > On Fri, 2017-12-01 at 11:13 +, Chris Wilson wrote: > > +++ b/tests/gem_exec_fence.c > > @@ -698,7 +698,7 @@ static bool has_submit_fence(int fd) > > int value = 0; > > > > memset(&gp, 0, sizeof(gp)); > > - gp.param = 50; /* I915_

[Intel-gfx] [PATCH igt] igt/pm_rps: Replace arbitrary HIGH_LOAD blit with a busyspin

2017-12-04 Thread Chris Wilson
Using a blit + sleep does not guarantee generating a high enough load to keep the GPU busy, a busyspin does. Replace the blit at high load with a continuous series spins and low load with a mix of spin and sleep. References: https://bugs.freedesktop.org/show_bug.cgi?id=104060 Signed-off-by: Chris

Re: [Intel-gfx] [PATCH] drm/i915: Mark expected switch fall-throughs

2017-12-04 Thread Joonas Lahtinen
On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. I have to say I'm totally not sold on regexps matching comment contents. Was something more explicit ever considered? Like:

[Intel-gfx] [PATCH igt v2] igt/pm_rps: Replace arbitrary HIGH_LOAD blit with a busyspin

2017-12-04 Thread Chris Wilson
Using a blit + sleep does not guarantee generating a high enough load to keep the GPU busy, a busyspin does. Replace the blit at high load with a continuous series spins and low load with a mix of spin and sleep. v2: Maintain a limited queue depth References: https://bugs.freedesktop.org/show_bug

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-12-04 Thread Joonas Lahtinen
On Tue, 2017-11-28 at 17:29 +, Chris Wilson wrote: > Quoting Michal Wajdeczko (2017-11-28 17:01:15) > > In commit 3f6ae7b19 ("igt/kms_frontbuffer_tracking: Keep the debugfs > > dir around") we introduced custom variant of __igt_debugfs_read function > > that fires assert when debugfs returns an

[Intel-gfx] [CI] drm/i915: deprecate pci_get_bus_and_slot()

2017-12-04 Thread Joonas Lahtinen
From: Sinan Kaya pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Extr

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rps: Replace arbitrary HIGH_LOAD blit with a busyspin

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rps: Replace arbitrary HIGH_LOAD blit with a busyspin URL : https://patchwork.freedesktop.org/series/34820/ State : success == Summary == IGT patchset tested on top of latest successful build 476c4b462e0453c70ee81664c0227fdddc26cbd0 igt/gem_eio: Increase wak

[Intel-gfx] [igt CI] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-12-04 Thread Chris Wilson
CI doesn't run in whole-test mode, but runs each subtest individually. Tests that are designed to do a block of work to be shared between many subtests end up running that work multiple times (once per subtest) and worse, that work is wasted if the subtest will be skipped. pm_rc6_residency is one

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: deprecate pci_get_bus_and_slot()

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915: deprecate pci_get_bus_and_slot() URL : https://patchwork.freedesktop.org/series/34822/ State : success == Summary == Series 34822v1 drm/i915: deprecate pci_get_bus_and_slot() https://patchwork.freedesktop.org/api/1.0/series/34822/revisions/1/mbox/ Test d

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rps: Replace arbitrary HIGH_LOAD blit with a busyspin (rev2)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rps: Replace arbitrary HIGH_LOAD blit with a busyspin (rev2) URL : https://patchwork.freedesktop.org/series/34820/ State : success == Summary == IGT patchset tested on top of latest successful build 476c4b462e0453c70ee81664c0227fdddc26cbd0 igt/gem_eio: Incre

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rc6_residency: Measure residency after checking for applicability (rev2)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rc6_residency: Measure residency after checking for applicability (rev2) URL : https://patchwork.freedesktop.org/series/32097/ State : success == Summary == IGT patchset tested on top of latest successful build 476c4b462e0453c70ee81664c0227fdddc26cbd0 igt/g

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/10] igt/perf_pmu: Tighten semaphore-wait measurement

2017-12-04 Thread Patchwork
== Series Details == Series: series starting with [01/10] igt/perf_pmu: Tighten semaphore-wait measurement URL : https://patchwork.freedesktop.org/series/34818/ State : failure == Summary == Test gem_tiled_swapping: Subgroup non-threaded: incomplete -> PASS (shar

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: deprecate pci_get_bus_and_slot()

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915: deprecate pci_get_bus_and_slot() URL : https://patchwork.freedesktop.org/series/34822/ State : success == Summary == Test drv_module_reload: Subgroup basic-no-display: pass -> DMESG-WARN (shard-snb) fdo#102707 Test drv_selfte

[Intel-gfx] [PATCH igt v2] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-12-04 Thread Chris Wilson
CI doesn't run in whole-test mode, but runs each subtest individually. Tests that are designed to do a block of work to be shared between many subtests end up running that work multiple times (once per subtest) and worse, that work is wasted if the subtest will be skipped. pm_rc6_residency is one

[Intel-gfx] [PATCH] drm/i915: Flush pending GTT writes before unbinding

2017-12-04 Thread Chris Wilson
From the shrinker paths, we want to relinquish the GPU and GGTT access to the object, releasing the backing storage back to the system for swapout. As a part of that process we would unpin the pages, marking them for access by the CPU (for the swapout/swapin). However, if that process was interrupt

Re: [Intel-gfx] [PATCH] drm/i915: Flush pending GTT writes before unbinding

2017-12-04 Thread Joonas Lahtinen
On Mon, 2017-12-04 at 12:43 +, Chris Wilson wrote: > From the shrinker paths, we want to relinquish the GPU and GGTT access to > the object, releasing the backing storage back to the system for > swapout. As a part of that process we would unpin the pages, marking > them for access by the CPU (

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rc6_residency: Measure residency after checking for applicability (rev3)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rc6_residency: Measure residency after checking for applicability (rev3) URL : https://patchwork.freedesktop.org/series/32097/ State : success == Summary == IGT patchset tested on top of latest successful build 476c4b462e0453c70ee81664c0227fdddc26cbd0 igt/g

[Intel-gfx] [PATCH v2] tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-12-04 Thread Michal Wajdeczko
In commit 3f6ae7b19 ("igt/kms_frontbuffer_tracking: Keep the debugfs dir around") we introduced custom variant of __igt_debugfs_read function that fires assert when debugfs returns an error. Replace that assert with proper error handling to allow use of errors like -ENODEV. v2: allow only -ENODEV

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/pm_rps: Replace arbitrary HIGH_LOAD blit with a busyspin (rev2)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rps: Replace arbitrary HIGH_LOAD blit with a busyspin (rev2) URL : https://patchwork.freedesktop.org/series/34820/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-blt: pass ->

[Intel-gfx] ✗ Fi.CI.IGT: failure for igt/pm_rc6_residency: Measure residency after checking for applicability (rev2)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rc6_residency: Measure residency after checking for applicability (rev2) URL : https://patchwork.freedesktop.org/series/32097/ State : failure == Summary == Test pm_rc6_residency: Subgroup rc6-accuracy: pass -> FAIL (shar

Re: [Intel-gfx] [PATCH] i915/gvt: make release_shadow_wa_ctx static.

2017-12-04 Thread Joonas Lahtinen
+ GVT-g list Zhenyu, please pick this up. Regards, Joonas On Mon, 2017-12-04 at 09:42 +1000, Dave Airlie wrote: > From: Dave Airlie > > This was removed from the header file in > d0d51282b8 drm/i915/gvt: Remove one extra declaration in scheduler.h > > Make it static then. > > Signed-off-by:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Flush pending GTT writes before unbinding

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915: Flush pending GTT writes before unbinding URL : https://patchwork.freedesktop.org/series/34830/ State : failure == Summary == Series 34830v1 drm/i915: Flush pending GTT writes before unbinding https://patchwork.freedesktop.org/api/1.0/series/34830/revisio

[Intel-gfx] [PATCH i-g-t 2/2] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9

2017-12-04 Thread Juha-Pekka Heikkila
From Gen10 onwards RGB565 90 degree rotation is supported in hw. Signed-off-by: Juha-Pekka Heikkila --- tests/kms_rotation_crc.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index f3b9d61..1769264 100644 --- a/tests/kms_rotation_

[Intel-gfx] [PATCH i-g-t 0/2] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9

2017-12-04 Thread Juha-Pekka Heikkila
Add rgb565 90 degree test for gen10 onwards and do some house cleaning on the same go. /Juha-Pekka Juha-Pekka Heikkila (2): igt/kms_rotation_crc: Change bad-pixel-format to use DRM_FORMAT_C8 igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 tests/kms_rotation_crc.c | 58

[Intel-gfx] [PATCH i-g-t 1/2] igt/kms_rotation_crc: Change bad-pixel-format to use DRM_FORMAT_C8

2017-12-04 Thread Juha-Pekka Heikkila
Gen10 onwards 90 and 270 degree rotations are supported for RGB565 format. v2 (Ville Syrjälä): As a side effect to keep bad-pixel-format test valid on all supported platforms it need to use DRM_FORMAT_C8 now. While at it clean up kms_rotation_crc test a bit, take out test_plane_rotation_ytiled_ob

[Intel-gfx] [RESEND] drm/i915: Flush pending GTT writes before unbinding

2017-12-04 Thread Chris Wilson
From the shrinker paths, we want to relinquish the GPU and GGTT access to the object, releasing the backing storage back to the system for swapout. As a part of that process we would unpin the pages, marking them for access by the CPU (for the swapout/swapin). However, if that process was interrupt

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev4)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev4) URL : https://patchwork.freedesktop.org/series/33132/ State : success == Summary == IGT patchset tested on top of latest successful build 476c4b462e0453c70ee81664c0227fdddc26cbd0 igt/gem_eio: Increase

Re: [Intel-gfx] [PATCH v2] drm/i915: Taint (TAINT_DIE) the kernel if the GPU reset fails

2017-12-04 Thread Joonas Lahtinen
On Wed, 2017-11-29 at 14:05 +, Chris Wilson wrote: > History tells us that if we cannot reset the GPU now, we never will. This > then impacts everything that is run subsequently. On failing the reset, > we mark the driver as wedged, trying to prevent further execution on the > GPU, forcing user

Re: [Intel-gfx] [PATCH v2] drm/i915: Taint (TAINT_DIE) the kernel if the GPU reset fails

2017-12-04 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-12-04 13:41:11) > On Wed, 2017-11-29 at 14:05 +, Chris Wilson wrote: > > History tells us that if we cannot reset the GPU now, we never will. This > > then impacts everything that is run subsequently. On failing the reset, > > we mark the driver as wedged, trying t

Re: [Intel-gfx] [PATCH igt] lib: Check and report if a subtest triggers a new kernel taint

2017-12-04 Thread Joonas Lahtinen
On Wed, 2017-11-29 at 12:30 +, Chris Wilson wrote: > Checking for a tainted kernel is a convenient way to see if the test > generated a critical error such as a oops, or machine check. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: Radoslaw Szwichtenberg Reviewed-by: Joonas Laht

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: avoid < in gtkdoc comments

2017-12-04 Thread Joonas Lahtinen
On Wed, 2017-11-29 at 12:17 +0100, Daniel Vetter wrote: > For reasons entirely not clear to me meson gtkdoc runs in strict > xml parsing mode, whereas automake gtkdoc doesn't. And gtkdoc itself > is to dense to correctly escape this stuff. > > Paper around this. > > Signed-off-by: Daniel

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush pending GTT writes before unbinding (rev2)

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915: Flush pending GTT writes before unbinding (rev2) URL : https://patchwork.freedesktop.org/series/34830/ State : success == Summary == Series 34830v2 drm/i915: Flush pending GTT writes before unbinding https://patchwork.freedesktop.org/api/1.0/series/34830/

[Intel-gfx] [PATCH igt] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-12-04 Thread Chris Wilson
CI doesn't run in whole-test mode, but runs each subtest individually. Tests that are designed to do a block of work to be shared between many subtests end up running that work multiple times (once per subtest) and worse, that work is wasted if the subtest will be skipped. pm_rc6_residency is one

[Intel-gfx] ✓ Fi.CI.BAT: success for test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc

2017-12-04 Thread Patchwork
== Series Details == Series: test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc URL : https://patchwork.freedesktop.org/series/34749/ State : success == Summary == IGT patchset tested on top of latest successful build 476c4b462e0453c70ee81664c0227fdddc26cbd0 igt/gem_eio: In

Re: [Intel-gfx] [PATCH igt v3] igt/gem_busy: Replace arbitrary busy batch with indefinite spinbatch

2017-12-04 Thread Joonas Lahtinen
On Sat, 2017-12-02 at 08:47 +, Chris Wilson wrote: > In CI, we were observing situations where the busy blt would complete > before the very next instruction (in userspace) to assert that it was > busy. This is entirely possible if the process was scheduled away and > slept for longer than the

[Intel-gfx] ✗ Fi.CI.IGT: failure for igt/pm_rc6_residency: Measure residency after checking for applicability (rev3)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rc6_residency: Measure residency after checking for applicability (rev3) URL : https://patchwork.freedesktop.org/series/32097/ State : failure == Summary == Test gem_busy: Subgroup close-race: pass -> FAIL (shard-snb) fdo

Re: [Intel-gfx] [PATCH igt] igt/drv_selftests: Disable initialising the display

2017-12-04 Thread Joonas Lahtinen
On Thu, 2017-11-30 at 22:04 +, Chris Wilson wrote: > Many of the selftests try to completely fill global resources; > resources > that are presumed available for bringing up the display. Avoid the > contention by simply not bringing up the display! > > This does limit the effectiveness of self

Re: [Intel-gfx] [PATCH i-g-t] igt: Make dependency on libunwind mandatory

2017-12-04 Thread Arkadiusz Hiler
On Fri, Dec 01, 2017 at 01:46:39PM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2017-12-01 13:19:54) > > With Android support gone there is not much reason for keeping libunwind > > dependency optional. This also deals (cheaply!) with ifdefs covering > > huge portions of code, removing a p

[Intel-gfx] [PATCH v6 0/5] drm/i915: Expose more GPU properties through sysfs

2017-12-04 Thread Lionel Landwerlin
Hi, After discussion with Chris, Joonas & Tvrtko, this series adds an additional commit to link the render node back to the card through a symlink. Making it obvious from an application using a render node to know where to get the information it needs. Cheers, Lionel Landwerlin (5): drm: add c

[Intel-gfx] [PATCH v6 1/5] drm: add card symlink in render sysfs directory

2017-12-04 Thread Lionel Landwerlin
In i915 we would like to expose information about the GPU topology which would be useful mostly to applications making use of the device computational capability (not so much the display part). At the moment we already store information like frequency, etc... into the card directory (/sys/class/drm

[Intel-gfx] [PATCH v6 2/5] drm/i915: store all subslice masks

2017-12-04 Thread Lionel Landwerlin
Up to now, subslice mask was assumed to be uniform across slices. But starting with Cannonlake, slices can be asymetric (for example slice0 has different number of subslices as slice1+). This change stores all subslices masks for all slices rather than having a single mask that applies to all slice

[Intel-gfx] [PATCH v6 3/5] drm/i915/debugfs: reuse max slice/subslices already stored in sseu

2017-12-04 Thread Lionel Landwerlin
Now that we have that information in topology fields, let's just reused it. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_debugfs.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu

[Intel-gfx] [PATCH v6 4/5] drm/i915: expose engine availability through sysfs

2017-12-04 Thread Lionel Landwerlin
This enables userspace to discover the engines available on the GPU. Here is the layout on a Skylake GT4: /sys/devices/pci:00/:00:02.0/drm/card0/gt/ └── engines ├── bcs │   └── 0 │   ├── capabilities │   ├── class │   ├── id │   └── instance ├──

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev4)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev4) URL : https://patchwork.freedesktop.org/series/33132/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-blt: pass -> FA

[Intel-gfx] [PATCH v6 5/5] drm/i915: expose EU topology through sysfs

2017-12-04 Thread Lionel Landwerlin
With the introduction of asymetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam. Here we introduce a more detailed way of querying the Gen's GPU topology that doesn't aggregate numbers. This is essential for monitoring parts of the GPU with the OA unit, because signals need

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Flush pending GTT writes before unbinding (rev2)

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915: Flush pending GTT writes before unbinding (rev2) URL : https://patchwork.freedesktop.org/series/34830/ State : failure == Summary == Test testdisplay: pass -> INCOMPLETE (shard-hsw) Test drv_module_reload: Subgroup basic-no-d

[Intel-gfx] ✗ Fi.CI.IGT: failure for test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc

2017-12-04 Thread Patchwork
== Series Details == Series: test/kms_plane_lowres: Fix display_commit_mode() so it returns the crc URL : https://patchwork.freedesktop.org/series/34749/ State : failure == Summary == Test kms_setmode: Subgroup basic: fail -> PASS (shard-hsw) fdo#99912 Test

Re: [Intel-gfx] [PATCH] drm/i915: Mark expected switch fall-throughs

2017-12-04 Thread Gustavo A. R. Silva
Hi Joonas, Quoting Joonas Lahtinen : On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. I have to say I'm totally not sold on regexps matching comment contents. Was somethi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Expose more GPU properties through sysfs (rev6)

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915: Expose more GPU properties through sysfs (rev6) URL : https://patchwork.freedesktop.org/series/33950/ State : success == Summary == Series 33950v6 drm/i915: Expose more GPU properties through sysfs https://patchwork.freedesktop.org/api/1.0/series/33950/re

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rc6_residency: Measure residency after checking for applicability (rev4)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rc6_residency: Measure residency after checking for applicability (rev4) URL : https://patchwork.freedesktop.org/series/32097/ State : success == Summary == IGT patchset tested on top of latest successful build 36015334f9ee86b997fc5c0deb4964184f87648f igt:

[Intel-gfx] [PATCH][next] drm/i915/gvt: Add missing breaks in switch statement

2017-12-04 Thread Colin King
From: Colin Ian King The switch statement is missing breaks for the cases of GVT_FAILSAFE_INSUFFICIENT_RESOURCE and GVT_FAILSAFE_GUEST_ERR. Add them in. Detected by CoverityScan, CID#1462416 ("Missing break in switch") Fixes: e011c6ce2b4f ("drm/i915/gvt: Add VM healthy check for workload_thread

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Add missing breaks in switch statement

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Add missing breaks in switch statement URL : https://patchwork.freedesktop.org/series/34856/ State : success == Summary == Series 34856v1 drm/i915/gvt: Add missing breaks in switch statement https://patchwork.freedesktop.org/api/1.0/series/34856/revis

[Intel-gfx] [PATCH][next] drm/i915/gvt: fix off-by-one comparison of ring_id

2017-12-04 Thread Colin King
From: Colin Ian King The ring_id maximum boundary is being compared using the > operator instead of >=, leading to an off-by-one error and an out of bounds write into array vgpu->hws_pga[]. Fix this by simply using the correct comparison operator. Also re-work another comparison that uses the co

[Intel-gfx] [PATCH i-g-t 1/3] igt_dummyload: Add preemptible parameter to spinning batch.

2017-12-04 Thread Antonio Argenziano
The recursive batch emitted in the dummyload library is always pre-emptible. This patch adds a parameter to make it conditionally pre-emptible. The batch can now be used in tests where we still want a spinning batch while not being able to preempt it. Note: The behavior preceding this patch has be

[Intel-gfx] [PATCH i-g-t 2/3] tests/gem_exec_schedule: Add reset on failed preemption test.

2017-12-04 Thread Antonio Argenziano
This patch adds a test where a low priority batch is going to be declared hung while a preemption is pending. The test wants to verify that a 'bad' low priority batch will not disrupt the execution of a high priority context and that the driver does due diligence in managing a reset while a preempt

[Intel-gfx] [PATCH i-g-t 3/3] tests/gem_exec_schedule: Add test for resetting preemptive batch

2017-12-04 Thread Antonio Argenziano
This patch adds a test that will trigger a preemption of a low priority batch by a 'bad' batch buffer which will hang. The test aims at making sure that a hanging high priority batch will not disrupt the submission flow of low priority contexts. Cc: Chris Wilson Cc: Michal Winiarski Signed-off-b

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/gem_exec_schedule: Add reset on failed preemption test.

2017-12-04 Thread Chris Wilson
Quoting Antonio Argenziano (2017-12-04 17:23:14) > This patch adds a test where a low priority batch is going to be > declared hung while a preemption is pending. The test wants to verify > that a 'bad' low priority batch will not disrupt the execution of a high > priority context and that the driv

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_exec_schedule: Add test for resetting preemptive batch

2017-12-04 Thread Chris Wilson
Quoting Antonio Argenziano (2017-12-04 17:23:15) > This patch adds a test that will trigger a preemption of a low priority > batch by a 'bad' batch buffer which will hang. The test aims at making > sure that a hanging high priority batch will not disrupt the submission > flow of low priority contex

Re: [Intel-gfx] [PATCH igt 01/10] igt/perf_pmu: Tighten semaphore-wait measurement

2017-12-04 Thread Tvrtko Ursulin
On 04/12/2017 09:27, Chris Wilson wrote: Record the before/after semaphore-wait values around the sleep to try to reduce the inaccuracy from scheduler delays. Previously, the samples were taken before submitting the batch and then after synchronising its completion. The measurement will then be

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/cnl: only divide up base frequency with crystal source

2017-12-04 Thread Paulo Zanoni
Em Seg, 2017-11-13 às 23:34 +, Lionel Landwerlin escreveu: > We apply this logic to Gen9 as well. We didn't notice this issue as > most part we've encountered so far only use the crystal as source for > their timestamp registers. > > Fixes: dab9178333 ("drm/i915: expose command stream timestam

Re: [Intel-gfx] [PATCH] drm/i915: Mark expected switch fall-throughs

2017-12-04 Thread Daniel Vetter
On Mon, Dec 4, 2017 at 4:20 PM, Gustavo A. R. Silva wrote: > Hi Joonas, > > Quoting Joonas Lahtinen : > >> On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote: >>> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >> >> >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: fix off-by-one comparison of ring_id

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix off-by-one comparison of ring_id URL : https://patchwork.freedesktop.org/series/34858/ State : success == Summary == Series 34858v1 drm/i915/gvt: fix off-by-one comparison of ring_id https://patchwork.freedesktop.org/api/1.0/series/34858/revisions

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_exec_schedule: Add test for resetting preemptive batch

2017-12-04 Thread Antonio Argenziano
On 04/12/17 09:42, Chris Wilson wrote: Quoting Antonio Argenziano (2017-12-04 17:23:15) This patch adds a test that will trigger a preemption of a low priority batch by a 'bad' batch buffer which will hang. The test aims at making sure that a hanging high priority batch will not disrupt the su

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/gem_exec_schedule: Add reset on failed preemption test.

2017-12-04 Thread Antonio Argenziano
On 04/12/17 09:37, Chris Wilson wrote: Quoting Antonio Argenziano (2017-12-04 17:23:14) This patch adds a test where a low priority batch is going to be declared hung while a preemption is pending. The test wants to verify that a 'bad' low priority batch will not disrupt the execution of a hig

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/cnl: only divide up base frequency with crystal source

2017-12-04 Thread Paulo Zanoni
Em Seg, 2017-12-04 às 15:50 -0200, Paulo Zanoni escreveu: > Em Seg, 2017-11-13 às 23:34 +, Lionel Landwerlin escreveu: > > We apply this logic to Gen9 as well. We didn't notice this issue as > > most part we've encountered so far only use the crystal as source > > for > > their timestamp regist

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Expose more GPU properties through sysfs (rev6)

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915: Expose more GPU properties through sysfs (rev6) URL : https://patchwork.freedesktop.org/series/33950/ State : failure == Summary == Test gem_eio: Subgroup in-flight-contexts: pass -> DMESG-WARN (shard-snb) fdo#104058 Test kms

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/pm_rc6_residency: Measure residency after checking for applicability (rev4)

2017-12-04 Thread Patchwork
== Series Details == Series: igt/pm_rc6_residency: Measure residency after checking for applicability (rev4) URL : https://patchwork.freedesktop.org/series/32097/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-render:

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/gvt: Add missing breaks in switch statement

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Add missing breaks in switch statement URL : https://patchwork.freedesktop.org/series/34856/ State : warning == Summary == Test gem_eio: Subgroup in-flight: pass -> DMESG-WARN (shard-snb) Test drv_module_reload: S

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] igt_dummyload: Add preemptible parameter to spinning batch.

2017-12-04 Thread Patchwork
== Series Details == Series: series starting with [1/3] igt_dummyload: Add preemptible parameter to spinning batch. URL : https://patchwork.freedesktop.org/series/34860/ State : failure == Summary == IGT patchset build failed on latest successful build c7b20c950276a41badd994324e1983760e44842b

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: fix off-by-one comparison of ring_id

2017-12-04 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix off-by-one comparison of ring_id URL : https://patchwork.freedesktop.org/series/34858/ State : success == Summary == Test kms_flip: Subgroup rcs-wf_vblank-vs-modeset: skip -> PASS (shard-hsw) Test kms_atomic_int

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Implement WaDisableVFclkgate.

2017-12-04 Thread Lucas De Marchi
Hi, On Fri, Dec 1, 2017 at 3:40 PM, Rafael Antognolli wrote: > This workaround supposedly fixes some hangs in the VF unit. > > Signed-off-by: Rafael Antognolli > --- > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > drivers/gpu/drm/i915/intel_pm.c | 5 + > 2 files changed, 8 insertions(+) > > di

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_exec_schedule: Add test for resetting preemptive batch

2017-12-04 Thread Chris Wilson
Quoting Antonio Argenziano (2017-12-04 18:25:16) > > > On 04/12/17 09:42, Chris Wilson wrote: > > Quoting Antonio Argenziano (2017-12-04 17:23:15) > >> This patch adds a test that will trigger a preemption of a low priority > >> batch by a 'bad' batch buffer which will hang. The test aims at maki

[Intel-gfx] [PATCH] drm: savely free connectors from connector_iter

2017-12-04 Thread Daniel Vetter
In commit 613051dac40da1751ab269572766d3348d45a197 Author: Daniel Vetter Date: Wed Dec 14 00:08:06 2016 +0100 drm: locking&new iterators for connector_list we've went to extreme lengths to make sure connector iterations works in any context, without introducing any additional locking cont

[Intel-gfx] [PATCH i-g-t 2/3] meson: gtkdoc support

2017-12-04 Thread Daniel Vetter
Bunch of neat improvements: - xml generates correctly depend upon the test binaries - no need to re-run autogen.sh when new chapters/functions get added, all handed by meson Still one issue: - the gtkdoc target doesn't depend upon the custom_target yet, hacked around using build_by_default:

[Intel-gfx] [PATCH i-g-t 3/3] meson: build a full dependency for lib_igt_perf

2017-12-04 Thread Daniel Vetter
meson prefers packages dependencies over passing arount static libraries, because those also include linker flags, include dirs and everything else. While at it pull the special cases out from the common build stanzas like we do with other special cases. Just a bit of ocd to keep everything polis

[Intel-gfx] [PATCH i-g-t 1/3] lib: avoid < in gtkdoc comments

2017-12-04 Thread Daniel Vetter
For reasons entirely not clear to me meson gtkdoc runs in strict xml parsing mode, whereas automake gtkdoc doesn't. And gtkdoc itself is to dense to correctly escape this stuff. Paper around this. v2: {foo} instead of of tripy (Joonas) Cc: Joonas Lahtinen Signed-off-by: Daniel Vet

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Implement WaDisableEarlyEOT.

2017-12-04 Thread Lucas De Marchi
On Fri, Dec 1, 2017 at 3:40 PM, Rafael Antognolli wrote: > There seems to be another clock gating issue which the workaround is > described as: > >"WA: Set 0xE4F0[1] = 1 to disable Early EOT of thread." > > Signed-off-by: Rafael Antognolli Reviewed-by: Lucas De Marchi Lucas De Marchi > --

Re: [Intel-gfx] [PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot()

2017-12-04 Thread Sinan Kaya
On 11/28/2017 11:29 AM, Sinan Kaya wrote: > On 11/28/2017 10:30 AM, Ville Syrjälä wrote: >>> + dev_priv->bridge_dev = >>> + pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0)); >> Maybe just pci_get_slot(pdev->bus, PCI_DEVFN(0, 0)) ? >> >> I guess if we want to be pedantic we could

Re: [Intel-gfx] linux-firmware pull request(SKL:DMC)

2017-12-04 Thread Josh Boyer
On Mon, Nov 27, 2017 at 6:13 PM, Anusha Srivatsa wrote: > Hi Ben, Kyle, > > Please consider pulling i915 updates to linux-firmware.git. > > i915-firmware-2017-11-27 > The following changes since commit 17e6288135d4500f9fe60224dce2b46d850c346b: > > brcm: update firmware for bcm4358 (2017-11-25 10

[Intel-gfx] HDCP as a Kconfig option

2017-12-04 Thread A. Wilcox
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 (Note: I am not subscribed to the list, please cc me with replies.) Hello i915 developers, I represent Adélie Linux, a Linux distribution that has the goal of empowering users through the true freedom that only libre software can provide. This new

Re: [Intel-gfx] HDCP as a Kconfig option

2017-12-04 Thread Daniel Vetter
Hi, I understand there there's concerns about the content protection stuff, but please note: - The patches under discussion enforce nothing, they only allow you to enable HDCP if you chose to do so. For real content protection you need a complete system, locked down with secure boot or similar. I

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: savely free connectors from connector_iter

2017-12-04 Thread Patchwork
== Series Details == Series: drm: savely free connectors from connector_iter URL : https://patchwork.freedesktop.org/series/34863/ State : success == Summary == Series 34863v1 drm: savely free connectors from connector_iter https://patchwork.freedesktop.org/api/1.0/series/34863/revisions/1/mbo

Re: [Intel-gfx] [PATCH v3] drm/i915: Use exponential backoff for wait_for()

2017-12-04 Thread John Harrison
On 11/29/2017 11:55 PM, Sagar Arun Kamble wrote: On 11/30/2017 12:45 PM, John Harrison wrote: On 11/29/2017 10:19 PM, Sagar Arun Kamble wrote: On 11/30/2017 8:34 AM, John Harrison wrote: On 11/24/2017 6:12 AM, Chris Wilson wrote: Quoting Michał Winiarski (2017-11-24 12:37:56) Since we see th

[Intel-gfx] [PATCH v2 1/2] drm/i915: follow single notation for workaround number

2017-12-04 Thread Lucas De Marchi
v2: Allow to have or omit space before platform Cc: Ville Syrjälä Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH v2 2/2] drm/i915: add platform tag to WA

2017-12-04 Thread Lucas De Marchi
v2: add more missing platform tags Cc: Ville Syrjälä Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drive

  1   2   >