Hi,
On 11/06/2017 11:17 AM, Daniel Vetter wrote:
On Sat, Nov 04, 2017 at 03:08:26PM +0100, Hans de Goede wrote:
Ideally we could use the VBT for this, that would be simple, in
intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set
connector->display_info.panel_orientation accordingly an
On some hardware the LCD panel is not mounted upright in the casing,
but rotated by 90 degrees. In this case we want the console to
automatically be rotated to compensate.
The drm subsys has a quirk table for this, use the
drm_get_panel_orientation_quirk function to get the panel orientation
and s
This is now all handled in the drivers and communicated through
fb_info.fbcon_rotate_hint.
Signed-off-by: Hans de Goede
---
drivers/video/fbdev/core/Makefile | 3 -
drivers/video/fbdev/core/fbcon.c| 4 +-
drivers/video/fbdev/core/fbcon.h| 6 --
drivers/vid
Hi All,
Here is v6 of my series to add a "panel orientation" property to
the drm-connector for the LCD panel to let userspace know about LCD
panels which are not mounted upright, as well as detecting upside-down
panels without needing quirks (like we do for 90 degree rotated screens).
Bartlomiej,
Ideally we could use the VBT for this, that would be simple, in
intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set
connector->display_info.panel_orientation accordingly and call
drm_connector_init_panel_orientation_property(), done.
Unfortunately vbt.dsi.config->rotation is always 0 ev
Apply the "panel orientation" drm connector prop to the primary plane so
that fbcon and fbdev using userspace programs display the right way up.
Changes in v3:
-Use a rotation member in struct drm_fb_helper_crtc and set that from
drm_setup_crtcs instead of looping over all crtc's to find the righ
On some hardware the LCD panel is not mounted upright in the casing,
but upside-down or rotated 90 degrees. In this case we want the console
to automatically be rotated to compensate.
The fbdev-driver may know about the need to rotate. Add a new
fbcon_rotate_hint field to struct fb_info, which get
On some devices the LCD panel is mounted in the casing in such a way that
the up/top side of the panel does not match with the top side of the
device (e.g. it is mounted upside-down).
This commit adds the necessary infra for lcd-panel drm_connector-s to
have a "panel orientation" property to commu
Some x86 clamshell design devices use portrait tablet screens and a display
engine which cannot rotate in hardware, so the firmware just leaves things
as is and we cannot figure out that the display is oriented non upright
from the hardware.
So at least on x86, we need a quirk table for this. This
== Series Details ==
Series: drm/fbdev: Panel orientation connector property support (rev4)
URL : https://patchwork.freedesktop.org/series/32447/
State : failure
== Summary ==
Applying: fbcon: Add fbcon_rotate_hint to struct fb_info
Patch failed at 0001 fbcon: Add fbcon_rotate_hint to struct f
Some x86 clamshell design devices use portrait tablet screens and a display
engine which cannot rotate in hardware, so the firmware just leaves things
as is and we cannot figure out that the display is oriented non upright
from the hardware.
So at least on x86, we need a quirk table for this. This
Hi All,
Here is v6 of my series to add a "panel orientation" property to
the drm-connector for the LCD panel to let userspace know about LCD
panels which are not mounted upright, as well as detecting upside-down
panels without needing quirks (like we do for 90 degree rotated screens).
Bartlomiej,
On some hardware the LCD panel is not mounted upright in the casing,
but upside-down or rotated 90 degrees. In this case we want the console
to automatically be rotated to compensate.
The fbdev-driver may know about the need to rotate. Add a new
fbcon_rotate_hint field to struct fb_info, which get
Ideally we could use the VBT for this, that would be simple, in
intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set
connector->display_info.panel_orientation accordingly and call
drm_connector_init_panel_orientation_property(), done.
Unfortunately vbt.dsi.config->rotation is always 0 ev
This is now all handled in the drivers and communicated through
fb_info.fbcon_rotate_hint.
Signed-off-by: Hans de Goede
---
drivers/video/fbdev/core/Makefile | 3 -
drivers/video/fbdev/core/fbcon.c| 4 +-
drivers/video/fbdev/core/fbcon.h| 6 --
drivers/vid
On some devices the LCD panel is mounted in the casing in such a way that
the up/top side of the panel does not match with the top side of the
device (e.g. it is mounted upside-down).
This commit adds the necessary infra for lcd-panel drm_connector-s to
have a "panel orientation" property to commu
On some hardware the LCD panel is not mounted upright in the casing,
but rotated by 90 degrees. In this case we want the console to
automatically be rotated to compensate.
The drm subsys has a quirk table for this, use the
drm_get_panel_orientation_quirk function to get the panel orientation
and s
Apply the "panel orientation" drm connector prop to the primary plane so
that fbcon and fbdev using userspace programs display the right way up.
Changes in v3:
-Use a rotation member in struct drm_fb_helper_crtc and set that from
drm_setup_crtcs instead of looping over all crtc's to find the righ
== Series Details ==
Series: drm/fbdev: Panel orientation connector property support (rev5)
URL : https://patchwork.freedesktop.org/series/32447/
State : failure
== Summary ==
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/u
This fixes the following make kerneldocs messages:
./include/drm/drm_mode_config.h:772: warning: No description found for
parameter 'modifiers_property'
./include/drm/drm_mode_config.h:772: warning: Excess struct member 'modifiers'
description in 'drm_mode_config'
Signed-off-by: Hans de Goede
== Series Details ==
Series: drm: Fix modifiers_property kernel-doc comment
URL : https://patchwork.freedesktop.org/series/34389/
State : failure
== Summary ==
Applying: drm: Fix modifiers_property kernel-doc comment
Patch failed at 0001 drm: Fix modifiers_property kernel-doc comment
Current
This is now all handled in the drivers and communicated through
fb_info.fbcon_rotate_hint.
Signed-off-by: Hans de Goede
---
drivers/video/fbdev/core/Makefile | 3 -
drivers/video/fbdev/core/fbcon.c| 4 +-
drivers/video/fbdev/core/fbcon.h| 6 --
drivers/vid
Some x86 clamshell design devices use portrait tablet screens and a display
engine which cannot rotate in hardware, so the firmware just leaves things
as is and we cannot figure out that the display is oriented non upright
from the hardware.
So at least on x86, we need a quirk table for this. This
Apply the "panel orientation" drm connector prop to the primary plane so
that fbcon and fbdev using userspace programs display the right way up.
Changes in v3:
-Use a rotation member in struct drm_fb_helper_crtc and set that from
drm_setup_crtcs instead of looping over all crtc's to find the righ
On some devices the LCD panel is mounted in the casing in such a way that
the up/top side of the panel does not match with the top side of the
device (e.g. it is mounted upside-down).
This commit adds the necessary infra for lcd-panel drm_connector-s to
have a "panel orientation" property to commu
On some hardware the LCD panel is not mounted upright in the casing,
but rotated by 90 degrees. In this case we want the console to
automatically be rotated to compensate.
The drm subsys has a quirk table for this, use the
drm_get_panel_orientation_quirk function to get the panel orientation
and s
Here is v7 of my series to add a "panel orientation" property to
the drm-connector for the LCD panel to let userspace know about LCD
panels which are not mounted upright, as well as detecting upside-down
panels without needing quirks (like we do for 90 degree rotated screens).
Bartlomiej, can we p
On some hardware the LCD panel is not mounted upright in the casing,
but upside-down or rotated 90 degrees. In this case we want the console
to automatically be rotated to compensate.
The fbdev-driver may know about the need to rotate. Add a new
fbcon_rotate_hint field to struct fb_info, which get
Ideally we could use the VBT for this, that would be simple, in
intel_dsi_init() check dev_priv->vbt.dsi.config->rotation, set
connector->display_info.panel_orientation accordingly and call
drm_connector_init_panel_orientation_property(), done.
Unfortunately vbt.dsi.config->rotation is always 0 ev
As both the hotplug event and fbdev configuration run asynchronously, it
is possible for them to run concurrently. If configuration fails, we were
freeing the fbdev causing a use-after-free in the hotplug event.
<7>[ 3069.935211] [drm:intel_fb_initial_config [i915]] Not using firmware
configurati
== Series Details ==
Series: drm/fbdev: Panel orientation connector property support (rev6)
URL : https://patchwork.freedesktop.org/series/32447/
State : success
== Summary ==
Series 32447v6 drm/fbdev: Panel orientation connector property support
https://patchwork.freedesktop.org/api/1.0/serie
== Series Details ==
Series: drm/i915/fbdev: Serialise early hotplug events with async fbdev config
URL : https://patchwork.freedesktop.org/series/34392/
State : success
== Summary ==
Series 34392v1 drm/i915/fbdev: Serialise early hotplug events with async fbdev
config
https://patchwork.freed
== Series Details ==
Series: drm/fbdev: Panel orientation connector property support (rev6)
URL : https://patchwork.freedesktop.org/series/32447/
State : warning
== Summary ==
Warning: bzip CI_DRM_3389/shard-glkb3/results31.json.bz2 wasn't in correct JSON
format
Test kms_frontbuffer_tracking:
On Sat, Nov 25, 2017 at 07:41:55PM +, Chris Wilson wrote:
> As both the hotplug event and fbdev configuration run asynchronously, it
> is possible for them to run concurrently. If configuration fails, we were
> freeing the fbdev causing a use-after-free in the hotplug event.
That'll teach me t
== Series Details ==
Series: drm/i915/fbdev: Serialise early hotplug events with async fbdev config
URL : https://patchwork.freedesktop.org/series/34392/
State : success
== Summary ==
Warning: bzip CI_DRM_3389/shard-glkb3/results31.json.bz2 wasn't in correct JSON
format
Test kms_frontbuffer_t
FYI, we noticed the following commit (built with gcc-5):
commit: 653c9f9a4dd8037ffc5afbb1040d15566aa8f533 ("lib/rbtree,drm/mm: Add
rbtree_replace_node_cached()")
git://anongit.freedesktop.org/drm-intel topic/core-for-CI
in testcase: boot
on test machine: qemu-system-i386 -enable-kvm -smp 2 -m 3
36 matches
Mail list logo
