Re: [Intel-gfx] [PATCH 1/6] drm/i915: export the stolen region as a resource

2017-11-23 Thread Ingo Molnar
* Joonas Lahtinen wrote: > + Dave as a heads-up > > On Thu, 2017-11-23 at 07:17 +0100, Ingo Molnar wrote: > > * Matthew Auld wrote: > > > > > We duplicate the stolen discovery code in early-quirks and in i915, > > > however if we just export the region as a resource from early-quirks we > > >

Re: [Intel-gfx] [PATCH] drm/i915: Avoid enum conversion warning

2017-11-23 Thread Daniel Vetter
On Wed, Nov 22, 2017 at 11:50:48PM -0800, Nick Desaulniers wrote: > Fixes the following enum conversion warning: > > drivers/gpu/drm/i915/intel_ddi.c:1481:30: error: implicit conversion > from enumeration type 'enum port' to different enumeration type 'enum > intel_dpll_id' [-Werror,-Wenum-convers

Re: [Intel-gfx] [PATCH] drm/i915: Put all non-blocking modesets onto an ordered wq

2017-11-23 Thread Daniel Vetter
On Wed, Nov 22, 2017 at 02:56:10PM +0200, Ville Syrjälä wrote: > On Wed, Nov 22, 2017 at 01:35:39PM +0100, Daniel Vetter wrote: > > On Wed, Nov 22, 2017 at 1:25 PM, Daniel Vetter > > wrote: > > > On Mon, Nov 13, 2017 at 3:36 PM, Maarten Lankhorst > > > wrote: > > >> Op 13-11-17 om 14:36 schreef

[Intel-gfx] [PATCH igt 3/3] igt/perf_pmu: Idle the GPU before starting to measure busyness

2017-11-23 Thread Chris Wilson
Make sure the HW is idle before we start sampling the GPU for busyness. If we do not rest for long enough between tests, we may carry the sampling over. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/perf_pmu.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/te

[Intel-gfx] [PATCH igt 1/3] igt/perf_pmu: Reduce arbitrary delays

2017-11-23 Thread Chris Wilson
gem_quiescent_gpu() is supposed to ensure that the HW is idle, and in the process kick the GPU into rc6, so we should not need a long delay afterwards to ensure that we are indeed in rc6. We do however need a small delay in order to be sure that rc6 cycle counter has started and stopped. v2: Apply

[Intel-gfx] igt/perf_pmu roundup

2017-11-23 Thread Chris Wilson
The stragglers for easy consumption and discussion. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH igt 2/3] igt/perf_pmu: Stop peeking at intel_mmio registers

2017-11-23 Thread Chris Wilson
Program the MI_WAIT_FOR_EVENT without reference to DERRMR by knowing its state is ~0u when not in use, and is only in use when userspace requires it. By not touching intel_regsiter_access we completely eliminate the risk that we leak the forcewake ref, which can cause later rc6 to fail. At the sam

[Intel-gfx] [PATCH v19 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-11-23 Thread Tina Zhang
v18->v19: 1) include "Handle-orphan-dmabuf_objs.patch". 2) rebase to the latest staging branch. v17->v18: 1) unmap vgpu's opregion when destroying vgpu. 2) update comments for VFIO_DEVICE_GET_GFX_DMABUF. (Alex) v16->v17: 1) modify VFIO_DEVICE_GET_GFX_DMABUF interface. (Alex) 2) add comments for x

[Intel-gfx] [PATCH v19 4/6] vfio: ABI for mdev display dma-buf operation

2017-11-23 Thread Tina Zhang
Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user query and get a plane and its information. So far, two types of buffers are supported: buffers based on dma-buf and buffers based on region. This ioctl can be invoked with: 1) Either DMABUF or REGION flag. Vendor driver returns a plane_info

[Intel-gfx] [PATCH v19 1/6] drm/i915/gvt: Add framebuffer decoder support

2017-11-23 Thread Tina Zhang
This patch is to introduce the framebuffer decoder which can decode guest OS's framebuffer information, including primary, cursor and sprite plane. v16: - rebase to 4.14.0-rc6. v14: - refine pixel format table. (Zhenyu) v9: - move drm format change to a separate patch. (Xiaoguang) v8: - fix a b

[Intel-gfx] [PATCH v19 5/6] drm/i915/gvt: Dmabuf support for GVT-g

2017-11-23 Thread Tina Zhang
This patch introduces a guest's framebuffer sharing mechanism based on dma-buf subsystem. With this sharing mechanism, guest's framebuffer can be shared between guest VM and host. v17: - modify VFIO_DEVICE_GET_GFX_DMABUF interface. (Alex) v16: - add x_hot and y_hot. (Gerd) - add flag validation f

[Intel-gfx] [PATCH v19 6/6] drm/i915/gvt: Handle orphan dmabuf_objs

2017-11-23 Thread Tina Zhang
dmabuf_obj's destruction relys on GEM release operation, which is managed in i915 driver. And there is a time window between vgpu's destruction and its dmabuf_objs' destruction. This patch is to free the orphan dmabuf_objs correctly after the vgpu passes away. Signed-off-by: Tina Zhang Cc: Zhenyu

[Intel-gfx] [PATCH v19 2/6] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-11-23 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by some Apps in windows. The float format in each component is 1:5:10 MSb-sign:exponent: fraction. This patch is to introduce the format to drm, so that the windows guest's framebuffer in this kind of format can be recognized and used by linu

[Intel-gfx] [PATCH v19 3/6] drm/i915/gvt: Add RGB 64-bit 16:16:16:16 float format

2017-11-23 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows 10 guest VM. This patch is to add this pixel format support to gvt device model. Without this patch, some Apps, e.g. "DXGIGammaVM.exe", will crash and make guest screen black. Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gv

[Intel-gfx] [CI 2/6] drm/i915: Use snprintf to avoid line-break when pretty-printing engines

2017-11-23 Thread Chris Wilson
When printing the execlist ports, we first print the ELSP header then follow it with the pretty-printed request. Since switching to drm_printer and show the output via printk, it automatically appends a newline to each call (unlike the old seq_printf output). To avoid the unwanted line break, const

[Intel-gfx] [CI 1/6] drm/printer: Add drm_vprintf()

2017-11-23 Thread Chris Wilson
Simple va_args equivalent to the existing drm_printf() for use with the drm_printer. v2: Fixup kerneldoc to match final parameter names. v3: Turn it into a kerneldoc comment Signed-off-by: Chris Wilson Cc: Rob Clark Reviewed-by: Daniel Vetter Cc: Dave Airlie Acked-by: Dave Airlie --- driver

[Intel-gfx] [CI 4/6] drm/i915: Include engine state on detecting a missed breadcrumb/seqno

2017-11-23 Thread Chris Wilson
Now that we have a common engine state pretty printer, we can use that instead of the adhoc information printed when we miss a breadcrumb. v2: Rearrange intel_engine_disarm_breadcrumbs() to avoid calling intel_engine_dump() under the rb spinlock (Mika) and to pretty-print the error state early so

[Intel-gfx] [CI 6/6] drm/i915: Add is-wedged flag to intel_engine_dump()

2017-11-23 Thread Chris Wilson
Comparing the state tested by intel_engine_is_idle() and printed by intel_engine_dump(), the only bit not shown is whether or not the device is wedged. Add that little bit of information to the pretty printer so that if the engine fails to idle we can see why. Signed-off-by: Chris Wilson Cc: Mika

[Intel-gfx] [CI 3/6] drm/i915: Make engine state pretty-printer header configurable

2017-11-23 Thread Chris Wilson
Pass in a format string (and args) to specify the header to be emitted along with the engine state when pretty-printing. This allows the header to be emitted inside the drm_printer stream, so sharing the same prefix and output characteristics (e.g. debug level and filtering). Signed-off-by: Chris

[Intel-gfx] [CI 5/6] drm/i915: Include the global reset count for intel_engine_dump()

2017-11-23 Thread Chris Wilson
Since a global reset affects the engine, include that along side the per-engine reset counter when pretty printing the engine state in intel_engine_dump(). Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_engine_cs.c | 5 +++-- 1 file chan

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Remove conditional HOTPLUG_CPU registration

2017-11-23 Thread Tvrtko Ursulin
On 23/11/2017 07:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-23 07:36:35) On 22/11/2017 18:26, Chris Wilson wrote: Even for static CPU configurations, the hotplug CPU framework is still used to determine the CPU topology, and is still being used by the perf event register to check

[Intel-gfx] [PATCH v2] drm/i915/pmu: Clear the previous sample value when parking

2017-11-23 Thread Chris Wilson
When turning off the engines, and the pmu sampling, clear the previous value as the current measurement should be 0. v2: Use a for-loop Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_pmu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915: Avoid enum conversion warning URL : https://patchwork.freedesktop.org/series/34269/ State : failure == Summary == commit ffa17d69cf53bd5af4d7e41900c3ba40f6656e31 Author: Chris Wilson Date: Thu Nov 23 07:47:39 2017 + drm-tip: 2017y-11m-23d-07h-

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Dma-buf support for GVT-g

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Dma-buf support for GVT-g URL : https://patchwork.freedesktop.org/series/34272/ State : failure == Summary == commit ffa17d69cf53bd5af4d7e41900c3ba40f6656e31 Author: Chris Wilson Date: Thu Nov 23 07:47:39 2017 + drm-tip: 2017y-11m-23d-07h-

[Intel-gfx] [PATCH] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-11-23 Thread Tina Zhang
This patch is from "[PATCH v19 0/6] drm/i915/gvt: Dma-buf support for GVT-g": https://lists.freedesktop.org/archives/intel-gvt-dev/2017-November/002508.html The RGB 64-bit 16:16:16:16 float pixel format is needed by some Apps in windows. The float format in each component is 1:5:10 MSb-sign:expone

[Intel-gfx] [PATCH] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-11-23 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by some Apps in windows. The float format in each component is 1:5:10 MSb-sign:exponent: fraction. This patch is to introduce the format to drm, so that the windows guest's framebuffer in this kind of format can be recognized and used by linu

Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.04 for Kabylake

2017-11-23 Thread Jani Nikula
On Thu, 09 Nov 2017, Rodrigo Vivi wrote: > On Thu, Nov 09, 2017 at 06:51:43PM +, Anusha Srivatsa wrote: >> There is a new version of DMC available for KBL. >> >> The release notes mentions: >> 1. Fix for the issue where DC_STATE was getting enabled even >> when disabled by driver causing data

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/printer: Add drm_vprintf()

2017-11-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/printer: Add drm_vprintf() URL : https://patchwork.freedesktop.org/series/34278/ State : success == Summary == Series 34278v1 series starting with [CI,1/6] drm/printer: Add drm_vprintf() https://patchwork.freedesktop.org/api/1.0/se

[Intel-gfx] [PATCH i-g-t] tests/perf_pmu: Bump measuring duration for semaphores as well

2017-11-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As Chris has discover 100ms is not long enough to cover the sampling error in general, fix the semaphore subtest as well to measure for 500ms. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson --- tests/perf_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Intel-gfx] [CI 1/6] drm/printer: Add drm_vprintf()

2017-11-23 Thread Chris Wilson
Quoting Chris Wilson (2017-11-23 08:40:46) > Simple va_args equivalent to the existing drm_printf() for use with the > drm_printer. > > v2: Fixup kerneldoc to match final parameter names. > v3: Turn it into a kerneldoc comment > > Signed-off-by: Chris Wilson > Cc: Rob Clark > Reviewed-by: Danie

Re: [Intel-gfx] [PATCH i-g-t] tests/perf_pmu: Bump measuring duration for semaphores as well

2017-11-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-23 09:24:01) > From: Tvrtko Ursulin > > As Chris has discover 100ms is not long enough to cover the sampling > error in general, fix the semaphore subtest as well to measure for > 500ms. > > Signed-off-by: Tvrtko Ursulin > Cc: Chris Wilson And one value for all

[Intel-gfx] [PATCH v3] drm/i915/pmu: Clear the previous sample value when parking

2017-11-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When turning off the engines, and the pmu sampling, clear the previous value as the current measurement should be 0. v2: Use a for-loop v3: * Move clearing to timer self-dis-arm to avoid race with parking. * Clear frequency samples as well. Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH] drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers

2017-11-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have agreed during the engine classes discussion that fields marked as non-ABI are better left out altogether from uapi headers. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.h | 2 +- include/uapi/drm/i915_drm.h | 3 +-- 2 files ch

[Intel-gfx] [PULL] drm-intel-next-fixes

2017-11-23 Thread Jani Nikula
Hi Dave, some early fixes for v4.15 and stable. BR, Jani. The following changes since commit e8c49fa96838101435b9e4884d49b30da7a4e0c6: drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU (2017-11-09 16:18:37 +0200) are available in the git repository at: git://ano

Re: [Intel-gfx] [PATCH] drm/i915: Put all non-blocking modesets onto an ordered wq

2017-11-23 Thread Maarten Lankhorst
Op 23-11-17 om 09:11 schreef Daniel Vetter: > On Wed, Nov 22, 2017 at 02:56:10PM +0200, Ville Syrjälä wrote: >> On Wed, Nov 22, 2017 at 01:35:39PM +0100, Daniel Vetter wrote: >>> On Wed, Nov 22, 2017 at 1:25 PM, Daniel Vetter >>> wrote: On Mon, Nov 13, 2017 at 3:36 PM, Maarten Lankhorst

Re: [Intel-gfx] [PATCH v3] drm/i915/pmu: Clear the previous sample value when parking

2017-11-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-23 09:27:40) > From: Tvrtko Ursulin > > When turning off the engines, and the pmu sampling, clear the previous > value as the current measurement should be 0. > > v2: Use a for-loop > v3: > * Move clearing to timer self-dis-arm to avoid race with parking. > * Cl

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers

2017-11-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-23 09:32:29) > From: Tvrtko Ursulin > > We have agreed during the engine classes discussion that fields marked as > non-ABI are better left out altogether from uapi headers. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/intel_ringbuffer.h | 2 +-

Re: [Intel-gfx] [PATCH 3/5] drm/vmwgfx: Try to fix plane clipping

2017-11-23 Thread Laurent Pinchart
Hi Ville, On Monday, 6 November 2017 20:04:38 EET Ville Syrjälä wrote: > On Thu, Nov 02, 2017 at 03:19:30PM +0200, Ville Syrjälä wrote: > > On Thu, Nov 02, 2017 at 11:12:09AM +0100, Daniel Vetter wrote: > >> On Wed, Nov 01, 2017 at 08:29:18PM +0200, Ville Syrjala wrote: > >>> From: Ville Syrjälä

Re: [Intel-gfx] [PATCH 4/5] drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()

2017-11-23 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Wednesday, 1 November 2017 20:29:19 EET Ville Syrjala wrote: > From: Ville Syrjälä > > drm_plane_helper_check_state() is supposed to do things the atomic way, > so it should not be inspecting crtc->enabled. Rather we should be > looking at crtc_state->enabl

Re: [Intel-gfx] [PATCH 5/5] drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c

2017-11-23 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Wednesday, 1 November 2017 20:29:20 EET Ville Syrjala wrote: > From: Ville Syrjälä > > drm_plane_helper_check_update() isn't a transitional helper, so let's > rename it to drm_atomic_helper_check_plane_state() and move it into > drm_atomic_helper.c. > > Cc

Re: [Intel-gfx] [PATCH 1/5] drm/vmwgfx: Remove bogus crtc coords vs fb size check

2017-11-23 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Wednesday, 1 November 2017 20:29:16 EET Ville Syrjala wrote: > From: Ville Syrjälä > > Throw away the bugs crtc coords vs. fb size check. Crtc coords don't > define the viewport inside the fb, that's a job for the src coords, > which have been checked by th

Re: [Intel-gfx] [PATCH 2/5] drm/vmwgfx: Use drm_plane_helper_check_state()

2017-11-23 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Wednesday, 1 November 2017 20:29:17 EET Ville Syrjala wrote: > From: Ville Syrjälä > > Atomic drivers have no reason to use drm_plane_helper_check_update() > instead of drm_plane_helper_check_state(). So let's switch over. > > Cc: VMware Graphics > Cc: Si

Re: [Intel-gfx] [PATCH 0/5] drm: drm_plane_helper_check_state() related stuff

2017-11-23 Thread Laurent Pinchart
Hi Ville, On Monday, 20 November 2017 21:36:46 EET Ville Syrjälä wrote: > On Mon, Nov 20, 2017 at 09:32:56AM -0800, Sinclair Yeh wrote: > > On Mon, Nov 20, 2017 at 08:34:50AM +0100, Daniel Vetter wrote: > >> On Fri, Nov 10, 2017 at 11:42:59PM +0200, Ville Syrjälä wrote: > >>> On Fri, Nov 10, 2017

[Intel-gfx] [PATCH i-g-t 1/3] tests/kms_color: Rename pipe tests to standard notation

2017-11-23 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- tests/kms_color.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tests/kms_color.c b/tests/kms_color.c index dcda12de3a39..3b0a88802c93 100644 --- a/tests/kms_color.c +++ b/tests/kms_color.c @@ -855,7 +855,7 @@

[Intel-gfx] [PATCH i-g-t 3/3] tests/kms_flip: Move kms_flip.vblank-vs-hang to kms_vblank

2017-11-23 Thread Maarten Lankhorst
There's no need to test this more than once. Signed-off-by: Maarten Lankhorst --- tests/kms_flip.c | 10 +- tests/kms_vblank.c | 18 ++ 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index fb37859af8d2..da55263bb307

[Intel-gfx] [PATCH i-g-t 2/3] tests/kms_flip: Remove blt/rcs flip tests.

2017-11-23 Thread Maarten Lankhorst
With the removal of mmio flips, blt and rcs flips are no longer different from doing busy testing in kms_busy. Signed-off-by: Maarten Lankhorst --- tests/kms_flip.c | 37 + 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/tests/kms_flip.c b/tests/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-11-23 Thread Patchwork
== Series Details == Series: drm: Introduce RGB 64-bit 16:16:16:16 float format URL : https://patchwork.freedesktop.org/series/34283/ State : success == Summary == Series 34283v1 drm: Introduce RGB 64-bit 16:16:16:16 float format https://patchwork.freedesktop.org/api/1.0/series/34283/revisions

[Intel-gfx] [PATCH v2] drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers

2017-11-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have agreed during the engine classes discussion that fields marked as non-ABI are better left out altogether from uapi headers. v2: Use a local define for maintanability. (Chris Wilson) Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.h | 1 + i

Re: [Intel-gfx] [PATCH v2] drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers

2017-11-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-23 10:07:01) > From: Tvrtko Ursulin > > We have agreed during the engine classes discussion that fields marked as > non-ABI are better left out altogether from uapi headers. > > v2: Use a local define for maintanability. (Chris Wilson) > > Signed-off-by: Tvrtko U

Re: [Intel-gfx] [PATCH v3] drm/i915/pmu: Clear the previous sample value when parking

2017-11-23 Thread Sagar Arun Kamble
On 11/23/2017 3:07 PM, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-23 09:27:40) From: Tvrtko Ursulin When turning off the engines, and the pmu sampling, clear the previous value as the current measurement should be 0. v2: Use a for-loop v3: * Move clearing to timer self-dis-arm to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Clear the previous sample value when parking (rev3)

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Clear the previous sample value when parking (rev3) URL : https://patchwork.freedesktop.org/series/34262/ State : success == Summary == Series 34262v3 drm/i915/pmu: Clear the previous sample value when parking https://patchwork.freedesktop.org/api/1.0

Re: [Intel-gfx] [PATCH 2/6] drm/i915: s/mappable_end/mappable_size/

2017-11-23 Thread Matthew Auld
On 22 November 2017 at 21:43, Chris Wilson wrote: > Quoting Matthew Auld (2017-11-22 21:19:16) >> The name mappable_end seems to suggest the end of the mappable region, > > This seems to be arguing for using _end :) > >> but is actually just the size, so make that obvious to the reader. > > We did

[Intel-gfx] [PATCH v4] drm/i915/pmu: Clear the previous sample value when parking

2017-11-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When turning off the engines, and the pmu sampling, clear the previous value as the current measurement should be 0. v2: Use a for-loop v3: * Move clearing to timer self-dis-arm to avoid race with parking. * Clear frequency samples as well. v4: * Init frequency to idle_fr

Re: [Intel-gfx] [CI 1/6] drm/printer: Add drm_vprintf()

2017-11-23 Thread Joonas Lahtinen
On Thu, 2017-11-23 at 09:26 +, Chris Wilson wrote: > Quoting Chris Wilson (2017-11-23 08:40:46) > > Simple va_args equivalent to the existing drm_printf() for use with the > > drm_printer. > > > > v2: Fixup kerneldoc to match final parameter names. > > v3: Turn it into a kerneldoc comment > >

[Intel-gfx] [PATCH] drm/vblank: Pass crtc_id to page_flip_ioctl.

2017-11-23 Thread Maarten Lankhorst
We added crtc_id to the atomic ioctl, but forgot to add it for vblank and page flip events. Commit bd386e518056 ("drm: Reorganize drm_pending_event to support future event types [v2]") added it to the vblank event, but page flip event was still missing. Correct this and add a test for making sure

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers (rev2)

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers (rev2) URL : https://patchwork.freedesktop.org/series/34286/ State : success == Summary == Series 34286v2 drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers https://patchwork.freedesktop.org/api/1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Clear the previous sample value when parking (rev4)

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Clear the previous sample value when parking (rev4) URL : https://patchwork.freedesktop.org/series/34262/ State : success == Summary == Series 34262v4 drm/i915/pmu: Clear the previous sample value when parking https://patchwork.freedesktop.org/api/1.0

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/vblank: Pass crtc_id to page_flip_ioctl.

2017-11-23 Thread Patchwork
== Series Details == Series: drm/vblank: Pass crtc_id to page_flip_ioctl. URL : https://patchwork.freedesktop.org/series/34292/ State : success == Summary == Series 34292v1 drm/vblank: Pass crtc_id to page_flip_ioctl. https://patchwork.freedesktop.org/api/1.0/series/34292/revisions/1/mbox/ fi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Dma-buf support for GVT-g

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Dma-buf support for GVT-g URL : https://patchwork.freedesktop.org/series/34272/ State : failure == Summary == commit 606231c4d58188daa3a9a02ac6b95f42c4fcf267 Author: Joonas Lahtinen Date: Thu Nov 23 12:37:47 2017 +0200 drm-tip: 2017y-11m-23d-1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915: Avoid enum conversion warning URL : https://patchwork.freedesktop.org/series/34269/ State : failure == Summary == commit 606231c4d58188daa3a9a02ac6b95f42c4fcf267 Author: Joonas Lahtinen Date: Thu Nov 23 12:37:47 2017 +0200 drm-tip: 2017y-11m-23d-1

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning

2017-11-23 Thread Arkadiusz Hiler
On Thu, Nov 23, 2017 at 08:58:47AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Avoid enum conversion warning > URL : https://patchwork.freedesktop.org/series/34269/ > State : failure > > == Summary == This change does not apply cleanly on top of the commit below: > co

[Intel-gfx] [PATCH 1/2] drm/i915: Rename shrinker init/cleanup to match driver initialisation phase

2017-11-23 Thread Chris Wilson
Since the shrinker is registered and unregistered during i915_driver_register and i915_driver_unregister, respectively, rename the init/cleanup functions to match. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- drivers/gpu/drm/i915/i915_dr

[Intel-gfx] [PATCH 2/2] drm/i915: Update shrinker drm_i915_private naming convention

2017-11-23 Thread Chris Wilson
Switch over from the non-descript dev_priv locals to i915. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 8 +- drivers/gpu/drm/i915/i915_gem_shrinker.c | 134 +++ 2 files changed, 71 insertions(+), 71 deletions(-) d

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/6] drm/printer: Add drm_vprintf()

2017-11-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/printer: Add drm_vprintf() URL : https://patchwork.freedesktop.org/series/34278/ State : success == Summary == Test kms_flip: Subgroup plain-flip-fb-recreate-interruptible: pass -> FAIL (shard-hs

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] tools/intel_watermark: Silence gcc7 snprintf() warnings

2017-11-23 Thread Patchwork
== Series Details == Series: series starting with [1/5] tools/intel_watermark: Silence gcc7 snprintf() warnings URL : https://patchwork.freedesktop.org/series/34187/ State : success == Summary == IGT patchset tested on top of latest successful build 8cf978bb55c312fb585364451c5aaf9f4ef9781a te

Re: [Intel-gfx] [PATCH v4] drm/i915/pmu: Clear the previous sample value when parking

2017-11-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-23 10:26:54) > From: Tvrtko Ursulin > > When turning off the engines, and the pmu sampling, clear the previous > value as the current measurement should be 0. > > v2: Use a for-loop > v3: > * Move clearing to timer self-dis-arm to avoid race with parking. > * Cl

[Intel-gfx] [PATCH] MAINTAINERS: Remove Jani as drm-misc co-maintainer

2017-11-23 Thread Jani Nikula
I'm juggling too many things, and drm-misc maintenance is one that I keep dropping on the floor. Admit reality and remove myself as maintainer. This still leaves us with a nice team of three who are actually doing the drm-misc work, while I focus on drm-intel. Cc: Daniel Vetter Cc: Gustavo Padova

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Rename shrinker init/cleanup to match driver initialisation phase

2017-11-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Rename shrinker init/cleanup to match driver initialisation phase URL : https://patchwork.freedesktop.org/series/34295/ State : success == Summary == Series 34295v1 series starting with [1/2] drm/i915: Rename shrinker init/cle

[Intel-gfx] [PATCH i-g-t] tests/kms_vblank: Add test to ensure DRM_CAP_CRTC_IN_VBLANK_EVENT works correctly

2017-11-23 Thread Maarten Lankhorst
This was implemented correctly only on the atomic ioctl before, but it should really be working on all 3 ioctl's involved, so ensure we always set crtc_id correctly with a testcase. Signed-off-by: Maarten Lankhorst --- tests/kms_vblank.c | 60 ++---

[Intel-gfx] [PATCH 1/2] drm/i915/pmu: Remove conditional HOTPLUG_CPU registration

2017-11-23 Thread Tvrtko Ursulin
From: Chris Wilson Even for static CPU configurations, the hotplug CPU framework is still used to determine the CPU topology, and is still being used by the perf event register to check for valid CPUs. Fixes: b46a33e271ed ("drm/i915/pmu: Expose a PMU interface for perf queries") Signed-off-by: C

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Only allow running on a single CPU

2017-11-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We do two things, both of which are purely to simplify and clarify the implementation: 1. Simplify the CPU online callback so it is more obvious that the purpose there is to set a single CPU mask bit for the first CPU which comes online. Using cpumask_weight for this reads

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Clear the previous sample value when parking (rev3)

2017-11-23 Thread Tvrtko Ursulin
On 23/11/2017 10:22, Patchwork wrote: == Series Details == Series: drm/i915/pmu: Clear the previous sample value when parking (rev3) URL : https://patchwork.freedesktop.org/series/34262/ State : success == Summary == Series 34262v3 drm/i915/pmu: Clear the previous sample value when parking

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers (rev2)

2017-11-23 Thread Tvrtko Ursulin
On 23/11/2017 10:41, Patchwork wrote: == Series Details == Series: drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers (rev2) URL : https://patchwork.freedesktop.org/series/34286/ State : success == Summary == Series 34286v2 drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi header

[Intel-gfx] ✓ Fi.CI.BAT: success for MAINTAINERS: Remove Jani as drm-misc co-maintainer

2017-11-23 Thread Patchwork
== Series Details == Series: MAINTAINERS: Remove Jani as drm-misc co-maintainer URL : https://patchwork.freedesktop.org/series/34296/ State : success == Summary == Series 34296v1 MAINTAINERS: Remove Jani as drm-misc co-maintainer https://patchwork.freedesktop.org/api/1.0/series/34296/revisions

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Only allow running on a single CPU

2017-11-23 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-23 12:34:32) > From: Tvrtko Ursulin > > We do two things, both of which are purely to simplify and clarify the > implementation: > > 1. > > Simplify the CPU online callback so it is more obvious that the purpose > there is to set a single CPU mask bit for the fir

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-11-23 Thread Patchwork
== Series Details == Series: drm: Introduce RGB 64-bit 16:16:16:16 float format URL : https://patchwork.freedesktop.org/series/34283/ State : success == Summary == Test drv_selftest: Subgroup mock_sanitycheck: dmesg-warn -> PASS (shard-snb) fdo#103717

Re: [Intel-gfx] [PATCH 3/6] drm/i915: make dsm struct resource centric

2017-11-23 Thread Chris Wilson
Quoting Matthew Auld (2017-11-22 21:19:17) > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc: Paulo Zanoni > --- > drivers/gpu/drm/i915/i915_drv.h| 5 ++--- > drivers/gpu/drm/i915/i915_gem_stolen.c | 19 +++ > drivers/gpu/drm/i915/intel_fbc.c

Re: [Intel-gfx] [PATCH 5/6] drm/i915: make mappable struct resource centric

2017-11-23 Thread Chris Wilson
Quoting Matthew Auld (2017-11-22 21:19:19) > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc: Paulo Zanoni > --- > drivers/gpu/drm/i915/gvt/gvt.h| 2 +- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers (rev2)

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Drop I915_ENGINE_SAMPLE_MAX from uapi headers (rev2) URL : https://patchwork.freedesktop.org/series/34286/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-render: pass

Re: [Intel-gfx] [PATCH 6/6] drm/i915: prefer resource_size_t for stolen sizes

2017-11-23 Thread Chris Wilson
Quoting Matthew Auld (2017-11-22 21:19:20) > diff --git a/include/drm/intel-gtt.h b/include/drm/intel-gtt.h > index e901de0b6dd8..71505a5e376d 100644 > --- a/include/drm/intel-gtt.h > +++ b/include/drm/intel-gtt.h > @@ -5,9 +5,9 @@ > #define_DRM_INTEL_GTT_H > > void intel_gtt_get(u64 *g

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: test descending addresses

2017-11-23 Thread Matthew Auld
For igt_write_huge make sure the higher gtt offsets don't feel left out, which is especially true when dealing with the 48b PPGTT, where we timeout long before we are able exhaust the address space. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Chris Wilson --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: rein in igt_write_huge

2017-11-23 Thread Matthew Auld
Rather than repeat the test for each engine, which takes a long time, let's try alternating between the engines in some randomized order. v2: fix gen2 blunder fix !order blunder more cunning permutation construction! Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Chris Wilso

Re: [Intel-gfx] [PATCH 4/6] drm/i915: make reserved struct resource centric

2017-11-23 Thread Chris Wilson
Quoting Matthew Auld (2017-11-22 21:19:18) > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc: Paulo Zanoni > --- > @@ -6464,9 +6463,8 @@ static bool bxt_check_bios_rc6_setup(struct > drm_i915_private *dev_priv) > * for this check. > */ > rc6_

Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: rein in igt_write_huge

2017-11-23 Thread Chris Wilson
Quoting Matthew Auld (2017-11-23 13:22:57) > Rather than repeat the test for each engine, which takes a long time, > let's try alternating between the engines in some randomized > order. > > v2: fix gen2 blunder > fix !order blunder > more cunning permutation construction! > > Suggested-b

Re: [Intel-gfx] [PATCH 2/2] drm/i915/selftests: test descending addresses

2017-11-23 Thread Chris Wilson
Quoting Matthew Auld (2017-11-23 13:22:58) > For igt_write_huge make sure the higher gtt offsets don't feel left out, > which is especially true when dealing with the 48b PPGTT, where we > timeout long before we are able exhaust the address space. > > Suggested-by: Chris Wilson > Signed-off-by: M

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Only allow running on a single CPU

2017-11-23 Thread Tvrtko Ursulin
On 23/11/2017 12:50, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-23 12:34:32) From: Tvrtko Ursulin We do two things, both of which are purely to simplify and clarify the implementation: 1. Simplify the CPU online callback so it is more obvious that the purpose there is to set a sing

Re: [Intel-gfx] [PATCH igt 1/3] igt/perf_pmu: Reduce arbitrary delays

2017-11-23 Thread Tvrtko Ursulin
On 23/11/2017 08:22, Chris Wilson wrote: gem_quiescent_gpu() is supposed to ensure that the HW is idle, and in the process kick the GPU into rc6, so we should not need a long delay afterwards to ensure that we are indeed in rc6. We do however need a small delay in order to be sure that rc6 cycle

Re: [Intel-gfx] [PATCH igt 3/3] igt/perf_pmu: Idle the GPU before starting to measure busyness

2017-11-23 Thread Tvrtko Ursulin
On 23/11/2017 08:22, Chris Wilson wrote: Make sure the HW is idle before we start sampling the GPU for busyness. If we do not rest for long enough between tests, we may carry the sampling over. I'd rather not have this since as I said yesterday each opened PMU event is supposed to record the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/pmu: Remove conditional HOTPLUG_CPU registration

2017-11-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Remove conditional HOTPLUG_CPU registration URL : https://patchwork.freedesktop.org/series/34300/ State : success == Summary == Series 34300v1 series starting with [1/2] drm/i915/pmu: Remove conditional HOTPLUG_CPU registr

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Unwind incomplete legacy context switches

2017-11-23 Thread Mika Kuoppala
Chris Wilson writes: > The legacy context switch for ringbuffer submission is multistaged, > where each of those stages may fail. However, we were updating global > state after some stages, and so we had to force the incomplete request > to be submitted because we could not unwind. Save the globa

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: rein in igt_write_huge

2017-11-23 Thread Matthew Auld
Rather than repeat the test for each engine, which takes a long time, let's try alternating between the engines in some randomized order. v2: fix gen2 blunder fix !order blunder more cunning permutation construction! Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Chris Wilso

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: test descending addresses

2017-11-23 Thread Matthew Auld
For igt_write_huge make sure the higher gtt offsets don't feel left out, which is especially true when dealing with the 48b PPGTT, where we timeout long before we are able exhaust the address space. v2: just use IGT_TIMEOUT Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Chris Wilson

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/pmu: Clear the previous sample value when parking (rev4)

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Clear the previous sample value when parking (rev4) URL : https://patchwork.freedesktop.org/series/34262/ State : warning == Summary == Test kms_plane_lowres: Subgroup pipe-b-tiling-none: pass -> SKIP (shard-hsw) fd

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: rein in igt_write_huge

2017-11-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: rein in igt_write_huge URL : https://patchwork.freedesktop.org/series/34302/ State : success == Summary == Series 34302v1 series starting with [1/2] drm/i915/selftests: rein in igt_write_huge https://patchwork.freedes

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid enum conversion warning

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915: Avoid enum conversion warning URL : https://patchwork.freedesktop.org/series/34269/ State : failure == Summary == Applying: drm/i915: Avoid enum conversion warning Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/intel_ddi.c Fal

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/vblank: Pass crtc_id to page_flip_ioctl.

2017-11-23 Thread Patchwork
== Series Details == Series: drm/vblank: Pass crtc_id to page_flip_ioctl. URL : https://patchwork.freedesktop.org/series/34292/ State : warning == Summary == Test kms_cursor_legacy: Subgroup basic-busy-flip-before-cursor-atomic: pass -> SKIP (shard-hsw) Test

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Dma-buf support for GVT-g

2017-11-23 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Dma-buf support for GVT-g URL : https://patchwork.freedesktop.org/series/34272/ State : failure == Summary == Applying: drm/i915/gvt: Add framebuffer decoder support Applying: drm: Introduce RGB 64-bit 16:16:16:16 float format Applying: drm/i915/gvt:

Re: [Intel-gfx] i915: enum intel_dpll_id cast

2017-11-23 Thread Ville Syrjälä
On Wed, Nov 22, 2017 at 12:54:49PM -0800, Kees Cook wrote: > Hi, > > While doing Clang test builds, this was reported: > > drivers/gpu/drm/i915/intel_ddi.c:1481:30: warning: implicit conversion > from enumeration type 'enum port' to different enumeration type 'enum > intel_dpll_id' [-Wenum-conver

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: rein in igt_write_huge

2017-11-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: rein in igt_write_huge URL : https://patchwork.freedesktop.org/series/34304/ State : success == Summary == Series 34304v1 series starting with [1/2] drm/i915/selftests: rein in igt_write_huge https://patchwork.freedes

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make ips_enabled a property depending on whether IPS is enabled, v3.

2017-11-23 Thread Ville Syrjälä
On Wed, Nov 22, 2017 at 07:39:01PM +0100, Maarten Lankhorst wrote: > ips_enabled was used as a variable of whether IPS can be enabled or not, > but should be used to test whether IPS is actually enabled. > > Changes since v1: > - Call needs_modeset on new crtc state. (Ville) > - IPS can be enabled

  1   2   3   >