It is easier to categorize and debug bugs if the failed condition
is in plain sight in the actual dmesg output. Make it so.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Marta Lofstedt
Signed-off-by: Mika Kuoppala
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_gem.h | 6 +-
1 file
I like this, because I would not need to check the actual code when we get
BUG() backtraces for CI.
Reviewed-by: Marta Lofstedt
> -Original Message-
> From: Mika Kuoppala [mailto:mika.kuopp...@linux.intel.com]
> Sent: Thursday, November 16, 2017 10:40 AM
> To: intel-gfx@lists.freedeskto
On 15/11/2017 16:08, Chris Wilson wrote:
We check whether the multiplies will overflow prior to calling
kmalloc_array so that we can respond with -EINVAL for the invalid user
arguments rather than treating it as an -ENOMEM that would otherwise
occur. However, as Dan Carpenter pointed out, we did
== Series Details ==
Series: drm/i915: Print the condition causing GEM_BUG_ON (rev3)
URL : https://patchwork.freedesktop.org/series/32050/
State : success
== Summary ==
Series 32050v3 drm/i915: Print the condition causing GEM_BUG_ON
https://patchwork.freedesktop.org/api/1.0/series/32050/revisi
On Wed, 15 Nov 2017, Chris Wilson wrote:
> Quoting David Weinehall (2017-11-15 18:01:41)
>> On Tue, Nov 14, 2017 at 01:51:16PM +, Chris Wilson wrote:
>> > WaEnablePooledEuFor2x6 only applies to preproduction models, unsupported
>> > since commit 0102ba1fd8af ("drm/i915: Add early BXT sdv to th
Hi,
As we missed 4.15 cycle, here's the bigger initial 4.16 gvt-next pull,
which includes many improvements as noted below.
thanks
--
The following changes since commit 34cc9efc27e2623c76a69d2ad1fa2b972e27a2c1:
drm/i915: Remove pre-production pooled-EU w/a for Broxton (2017-11-15
18:04:18 +
> > > This patch set can be tried with the following example:
> > > git://git.kraxel.org/qemu branch: work/intel-vgpu
> > >
> >
> > Tested-by: Gerd Hoffmann
>
> Hi Gerd,
>
> Can you share the xml snippets required for the VM to make this work?
> Last I tried I couldn't get the display/video
Quoting Tvrtko Ursulin (2017-11-16 09:00:08)
>
> On 15/11/2017 16:08, Chris Wilson wrote:
> > @@ -2083,14 +2083,14 @@ get_fence_array(struct drm_i915_gem_execbuffer2
> > *args,
> > if (!(args->flags & I915_EXEC_FENCE_ARRAY))
> > return NULL;
> >
> > - if (nfences > SIZE
On 16/11/2017 09:36, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-11-16 09:00:08)
On 15/11/2017 16:08, Chris Wilson wrote:
@@ -2083,14 +2083,14 @@ get_fence_array(struct drm_i915_gem_execbuffer2 *args,
if (!(args->flags & I915_EXEC_FENCE_ARRAY))
return NULL;
-
== Series Details ==
Series: drm/i915: Print the condition causing GEM_BUG_ON (rev3)
URL : https://patchwork.freedesktop.org/series/32050/
State : success
== Summary ==
Test kms_plane:
Subgroup plane-panning-bottom-right-suspend-pipe-c-planes:
fail -> PASS (
i915 GuC submission is hardware interface and GuC APIs that are not user
facing should be named intel_guc* hence we change GuC submission related
functions name prefix to intel_guc. Also changed the parameter to these
functions to intel_guc struct.
v2: Using local guc variable in intel_uc_fini_hw.
GuC submission clients are currently being used in kernel only hence
update the structure name to intel_guc_client.
Signed-off-by: Sagar Arun Kamble
Cc: Michal Wajdeczko
Cc: Michal Winiarski
Cc: Chris Wilson
Cc: Joonas Lahtinen
Acked-by: Chris Wilson
Acked-by: Joonas Lahtinen
Acked-by: Osca
intel_lrc_irq_handler and i915_guc_irq_handler are HW submission
related bh functions. Name them with submission_bh suffix and
remove intel/i915 prefix as they are static. Also rename irq_tasklet
as just tasklet for clarity.
Suggested-by: Michal Wajdeczko
Signed-off-by: Sagar Arun Kamble
Cc: Mic
i915_guc_submit, i915_guc_dequeue, i915_guc_submission_park and
i915_guc_submission_upark are functions internal to GuC submission
hence remove "i915_" prefix.
Suggested-by: Michal Wajdeczko
Signed-off-by: Sagar Arun Kamble
Cc: Michal Wajdeczko
Cc: Michal Winiarski
Cc: Chris Wilson
Cc: Joonas
With all component structures and functions named appropriately, change
the names of GuC submission source files. There were bunch of style issues
in guc_submission.c that are highlighted now by checkpatch. Fix those.
Update name in Documentation/gpu. (Joonas)
v2: Rebase.
Signed-off-by: Sagar Aru
We want to have consistent function/structure/file naming and
function parameter semantics. Suggestion from Michal Wajdeczko about
using "genx_" prefix (or better _genx" suffix for all hw related
structures types, offsets), "i915_" prefix for driver entry calls and
"intel_" in all other seems to be
Also revert ("drm/i915/guc: Assert that we switch between
known ggtt->invalidate functions")
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++--
drivers/gpu/drm/i915/i915_params.h | 4 ++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/dri
Quoting Oscar Mateo (2017-11-16 00:21:40)
>
>
> On 11/13/2017 05:09 AM, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin
> >
> > + if (instance == I915_EXEC_INSTANCE_ANY)
> > + instance = eb_select_vcs_engine(eb, file_priv, eb_flags);
>
> At this moment we don't know that this is
Quoting Sagar Arun Kamble (2017-11-16 09:53:50)
> intel_lrc_irq_handler and i915_guc_irq_handler are HW submission
> related bh functions. Name them with submission_bh suffix and
> remove intel/i915 prefix as they are static. Also rename irq_tasklet
> as just tasklet for clarity.
s/_bh/_tasklet/ b
== Series Details ==
Series: GuC submission functions/struct name/prototype update (rev2)
URL : https://patchwork.freedesktop.org/series/33679/
State : success
== Summary ==
Series 33679v2 GuC submission functions/struct name/prototype update
https://patchwork.freedesktop.org/api/1.0/series/33
On Tue, 2017-11-14 at 19:11 +, Chris Wilson wrote:
> When the GPU is idle, we can take a breather and release our hold on our
> many caches. One such cache is that we keep objects pinned in memory
> even when they are no longer accessible by the GPU, that cache is held
> until the system comes
Quoting Tvrtko Ursulin (2017-11-16 09:44:20)
>
> On 16/11/2017 09:36, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2017-11-16 09:00:08)
> >>
> >> On 15/11/2017 16:08, Chris Wilson wrote:
> >>> @@ -2083,14 +2083,14 @@ get_fence_array(struct drm_i915_gem_execbuffer2
> >>> *args,
> >>>if
We check whether the multiplies will overflow prior to calling
kmalloc_array so that we can respond with -EINVAL for the invalid user
arguments rather than treating it as an -ENOMEM that would otherwise
occur. However, as Dan Carpenter pointed out, we did an addition on the
unsigned int prior to pa
On Tue, 2017-11-14 at 19:11 +, Chris Wilson wrote:
> The object already stores (computed on the fly) the index to dma address
> so use it instead of reallocating a large temporary array every time we
> bind a rotated framebuffer.
>
> Signed-off-by: Chris Wilson
> Cc: Matthew Auld
> Cc: Joona
== Series Details ==
Series: drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects
(rev4)
URL : https://patchwork.freedesktop.org/series/33840/
State : success
== Summary ==
Series 33840v4 drm/i915: Prevent overflow of execbuf.buffer_count and
num_cliprects
https://patchwork.f
On Wed, 2017-11-15 at 10:04 -0800, Rodrigo Vivi wrote:
> On Wed, Nov 15, 2017 at 08:06:16AM +, Mika Kahola wrote:
> >
> > On Tue, 2017-11-14 at 11:47 -0800, Rodrigo Vivi wrote:
> > >
> > > Spec describe all values in MHz. We handle our
> > > clocks in KHz. This includes the best_dco_centralit
We check whether the multiplies will overflow prior to calling
kmalloc_array so that we can respond with -EINVAL for the invalid user
arguments rather than treating it as an -ENOMEM that would otherwise
occur. However, as Dan Carpenter pointed out, we did an addition on the
unsigned int prior to pa
== Series Details ==
Series: GuC submission functions/struct name/prototype update (rev2)
URL : https://patchwork.freedesktop.org/series/33679/
State : warning
== Summary ==
Test perf:
Subgroup oa-exponents:
pass -> FAIL (shard-hsw) fdo#102254
Test kms_front
On Wed, 2017-11-15 at 12:14 +, Chris Wilson wrote:
> When we call intel_engine_cancel_signaling() to stop reporting whether
> or not a request is completed via an asynchronous signal, we remove that
> request from the breadcrumb wait queue. However, we may be concurrently
> processing that requ
On Thu, 16 Nov 2017 10:53:52 +0100, Sagar Arun Kamble
wrote:
i915 GuC submission is hardware interface and GuC APIs that are not user
facing should be named intel_guc* hence we change GuC submission related
functions name prefix to intel_guc. Also changed the parameter to these
functions to i
On Wed, Nov 15, 2017 at 06:06:53PM +, Chris Wilson wrote:
> Quoting David Weinehall (2017-11-15 18:01:41)
> > On Tue, Nov 14, 2017 at 01:51:16PM +, Chris Wilson wrote:
> > > WaEnablePooledEuFor2x6 only applies to preproduction models, unsupported
> > > since commit 0102ba1fd8af ("drm/i915:
== Series Details ==
Series: drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects
(rev5)
URL : https://patchwork.freedesktop.org/series/33840/
State : success
== Summary ==
Series 33840v5 drm/i915: Prevent overflow of execbuf.buffer_count and
num_cliprects
https://patchwork.f
Quoting Michel Thierry (2017-11-15 18:30:27)
> The first test aims to check guc_init_doorbell_hw, changing the existing
> guc clients and doorbells state before calling it.
>
> The second test tries to create as many clients as it is currently possible
> (currently limited to max number of doorbel
Quoting Joonas Lahtinen (2017-11-16 10:43:42)
> On Tue, 2017-11-14 at 19:11 +, Chris Wilson wrote:
> > The object already stores (computed on the fly) the index to dma address
> > so use it instead of reallocating a large temporary array every time we
> > bind a rotated framebuffer.
> >
> > Si
== Series Details ==
Series: drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects
(rev4)
URL : https://patchwork.freedesktop.org/series/33840/
State : warning
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
pass
== Series Details ==
Series: drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects
(rev5)
URL : https://patchwork.freedesktop.org/series/33840/
State : success
== Summary ==
Test kms_vblank:
Subgroup wait-busy:
skip -> PASS (shard-hsw)
Test k
igt_output_from_connector should be used for disconnected outputs
too, this is useful for chamelium testing, where disconnected outputs
may reappear.
Signed-off-by: Maarten Lankhorst
---
lib/igt_kms.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/igt_kms.c b/lib
Instead of first calling kmstest_unset_all_crtcs, and calling
igt_display_init for each test, use igt_display_reset to reset
igt_display between tests, and use atomic commit to disable all
unused crtcs in enable_output().
Signed-off-by: Maarten Lankhorst
---
tests/chamelium.c | 45 --
Instead of strictly measuring vblanks, we try to see if a page flip
is queued on the next vblank if we run legacy cursor updates to the
pipe and another pipe in the background.
Signed-off-by: Maarten Lankhorst
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101634
---
tests/kms_cursor_leg
Signed-off-by: Maarten Lankhorst
---
tests/Makefile.am | 6 +++---
tests/intel-ci/fast-feedback.testlist | 18 +-
tests/{chamelium.c => kms_chamelium.c} | 0
tests/meson.build | 2 +-
4 files changed, 13 insertions(+), 13 deletions(-)
A lot of code duplicates this, but it should be handled in the core.
Add it and use it after igt_display_init(), the tests have to be
converted one by one.
Signed-off-by: Maarten Lankhorst
---
lib/igt_kms.c | 162 +-
lib/igt_kms.h | 1 +
On Tue, Nov 14, 2017 at 03:42:23PM -0800, Rodrigo Vivi wrote:
> Spec describe all values in MHz. We handle our
> clocks in KHz. This includes the best_dco_centrality that was
> forgot in the same unity as spec. Consequently we couldn't
> get a good divider for high frequenies. Hence HDMI 2.0 wasn't
On Tue, 2017-11-14 at 21:30 +, Chris Wilson wrote:
> I should have admitted defeat long ago as there has been a rare but
> persistent error on Sandybridge where semaphore signaling did not
> propagate to the waiter, leading to a GPU hang.
>
> With the work on fence signaling for v4.9, the impa
On 11/16/2017 3:38 PM, Chris Wilson wrote:
Quoting Sagar Arun Kamble (2017-11-16 09:53:50)
intel_lrc_irq_handler and i915_guc_irq_handler are HW submission
related bh functions. Name them with submission_bh suffix and
remove intel/i915 prefix as they are static. Also rename irq_tasklet
as just
On Tue, 2017-11-14 at 21:30 +, Chris Wilson wrote:
> As the semaphores is just part of the engine, include it with the
> general pretty printer universally used for debugging.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lah
== Series Details ==
Series: tests/kms_cursor_legacy: Rework the 2x tests.
URL : https://patchwork.freedesktop.org/series/33933/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
88d6550795fad3974d77e4db2f563c5e2e8872e1 Revert "tests/kms_flip: Make
flip-vs-pa
On Tue, 2017-11-14 at 21:30 +, Chris Wilson wrote:
> Having disabled the broken semaphores on Sandybridge, there is no need
> for a modparam any more, so remove it in favour of a simple
> HAS_LEGACY_SEMAPHORES() guard.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Reviewed-by: Maar
On Tue, 2017-11-14 at 11:41 +, Chris Wilson wrote:
> We don't actually emit any commands into the ringbuffer, so we set it
> very small. However, an upcoming change centralises the wait-for-space
> into i915_gem_request_alloc() and that imposes a minimum size upon all
> ringbuffers (mock or rea
We want to have consistent function/structure/file naming and
function parameter semantics. Suggestion from Michal Wajdeczko about
using "genx_" prefix (or better _genx" suffix for all hw related
structures types, offsets), "i915_" prefix for driver entry calls and
"intel_" in all other seems to be
i915_guc_submit, i915_guc_dequeue, i915_guc_submission_park and
i915_guc_submission_upark are functions internal to GuC submission
hence remove "i915_" prefix.
Suggested-by: Michal Wajdeczko
Signed-off-by: Sagar Arun Kamble
Cc: Michal Wajdeczko
Cc: Michal Winiarski
Cc: Chris Wilson
Cc: Joonas
i915 GuC submission is hardware interface and GuC APIs that are not user
facing should be named intel_guc* hence we change GuC submission related
functions name prefix to intel_guc. Also changed the parameter to these
functions to intel_guc struct.
v2: Using local guc variable in intel_uc_fini_hw.
GuC submission clients are currently being used in kernel only hence
update the structure name to intel_guc_client.
Signed-off-by: Sagar Arun Kamble
Cc: Michal Wajdeczko
Cc: Michal Winiarski
Cc: Chris Wilson
Cc: Joonas Lahtinen
Acked-by: Chris Wilson
Acked-by: Joonas Lahtinen
Acked-by: Osca
intel_lrc_irq_handler and i915_guc_irq_handler are HW submission related
tasklet functions. Name them with "submission_tasklet" suffix and
remove intel/i915 prefix as they are static. Also rename irq_tasklet
as just tasklet for clarity.
v2: s/_bh/_tasklet (Chris)
Suggested-by: Michal Wajdeczko
S
With all component structures and functions named appropriately, change
the names of GuC submission source files. There were bunch of style issues
in guc_submission.c that are highlighted now by checkpatch. Fix those.
Update name in Documentation/gpu. (Joonas)
v2: Rebase.
v3: Rebase.
Signed-off-
Also revert ("drm/i915/guc: Assert that we switch between
known ggtt->invalidate functions")
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++--
drivers/gpu/drm/i915/i915_params.h | 4 ++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/dri
== Series Details ==
Series: tests/kms_cursor_legacy: Rework the 2x tests.
URL : https://patchwork.freedesktop.org/series/33933/
State : warning
== Summary ==
Test kms_chv_cursor_fail:
Subgroup pipe-c-128x128-bottom-edge:
skip -> PASS (shard-hsw)
Sub
== Series Details ==
Series: series starting with [1/4] lib/igt_kms: Add igt_display_reset function.
URL : https://patchwork.freedesktop.org/series/33934/
State : failure
== Summary ==
IGT patchset tested on top of latest successful build
88d6550795fad3974d77e4db2f563c5e2e8872e1 Revert "tests/
On 15/11/17 10:30, Michel Thierry wrote:
During driver load we create the GuC clients and allocate their
doorbells just before executing guc_init_doorbell_hw; but since we just
created these doorbells, how can they be out of sync?
This code has had more than enough refactoring (2 more still in
On Mon, Nov 13, 2017 at 10:47:44AM -0800, Rodrigo Vivi wrote:
> On Sat, Nov 11, 2017 at 09:43:44AM +, Sharma, Shashank wrote:
> > Regards
> >
> > Shashank
> >
> >
> > On 11/11/2017 3:56 AM, Rodrigo Vivi wrote:
> > > Starting on GLK we support HDMI 2.0. So this patch only
> > > extend the wor
On Wed, Nov 15, 2017 at 10:50:35AM +, Chris Wilson wrote:
> clang spots
>
> drivers/gpu/drm/i915/intel_pm.c:4655:6: warning: variable 'trans_min' is used
> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
> if (INTEL_GEN(dev_priv) >= 10)
>
> but fortunately
On 11/16/2017 12:00 AM, Michel Thierry wrote:
During driver load we create the GuC clients and allocate their
doorbells just before executing guc_init_doorbell_hw; but since we just
created these doorbells, how can they be out of sync?
This code has had more than enough refactoring (2 more stil
On 15/11/2017 13:32, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-11-15 13:26:09)
On 14/11/2017 13:19, Chris Wilson wrote:
We introduce the concept of classes that each engine may belong to.
There may be more than one engine available in each class, but each
engine only belongs to one cla
Chris Wilson writes:
> Quoting Mika Kuoppala (2017-11-15 13:51:13)
>> Chris Wilson writes:
>>
>> > At the start of building a request, we would wait for roughly enough
>> > space to fit the average request (to reduce the likelihood of having to
>> > wait and abort partway through request constr
On 11/15/2017 6:01 PM, Chris Wilson wrote:
Quoting Sagar Arun Kamble (2017-11-15 12:13:54)
From: Sourab Gupta
Currently, we have the ability to only forward the GPU timestamps in the
samples (which are generated via OA reports). This limits the ability to
correlate these samples with the sys
Chris Wilson writes:
> During request construction, after pinning the context we know whether
> or not we have to emit a context switch. So move this common operation
> from every caller into i915_gem_request_alloc() itself.
>
> v2: Always submit the request if we emitted some commands during req
On 16/11/2017 10:50, Chris Wilson wrote:
We check whether the multiplies will overflow prior to calling
kmalloc_array so that we can respond with -EINVAL for the invalid user
arguments rather than treating it as an -ENOMEM that would otherwise
occur. However, as Dan Carpenter pointed out, we did
== Series Details ==
Series: GuC submission functions/struct name/prototype update (rev3)
URL : https://patchwork.freedesktop.org/series/33679/
State : success
== Summary ==
Series 33679v3 GuC submission functions/struct name/prototype update
https://patchwork.freedesktop.org/api/1.0/series/33
On Thu, 16 Nov 2017 14:32:37 +0100, Sagar Arun Kamble
wrote:
intel_lrc_irq_handler and i915_guc_irq_handler are HW submission related
tasklet functions. Name them with "submission_tasklet" suffix and
remove intel/i915 prefix as they are static. Also rename irq_tasklet
as just tasklet for clar
Quoting Tvrtko Ursulin (2017-11-16 14:00:50)
>
> On 16/11/2017 10:50, Chris Wilson wrote:
> > We check whether the multiplies will overflow prior to calling
> > kmalloc_array so that we can respond with -EINVAL for the invalid user
> > arguments rather than treating it as an -ENOMEM that would oth
Quoting Joonas Lahtinen (2017-11-16 11:08:18)
> On Wed, 2017-11-15 at 12:14 +, Chris Wilson wrote:
> > When we call intel_engine_cancel_signaling() to stop reporting whether
> > or not a request is completed via an asynchronous signal, we remove that
> > request from the breadcrumb wait queue.
On Tue, Nov 14, 2017 at 01:19:01PM +, Chris Wilson wrote:
> I noticed that dpm was storing some information about which phase of
> suspend failed inside suspend_stats. That will be useful to help debug
> such failures, so automatically dump it after suspend fails.
>
> Signed-off-by: Chris Wils
Look at the first 16 characters of the user buffer and if they are all
printable, assume that user buffer contains ASCII data (e.g. a debug log)
that we want to simply print out. Otherwise, we treat it as a binary data
and hexdump as before.
Tvrtko: you know you could just write this as a printf (
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
HDMI 2.0 Appendix F suggest that we should keep sending the infoframe
when switching from 3D to 2D mode, even if the infoframe isn't strictly
necessary (ie. not needed to transmit the VIC or stereo information)
Quoting Arkadiusz Hiler (2017-11-16 14:31:03)
> On Tue, Nov 14, 2017 at 01:19:01PM +, Chris Wilson wrote:
> > I noticed that dpm was storing some information about which phase of
> > suspend failed inside suspend_stats. That will be useful to help debug
> > such failures, so automatically dump
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
Appedix F of HDMI 2.0 says that some HDMI sink may fail to switch from
3D to 2D mode in a timely fashion if the source simply stops sending the
HDMI infoframe. The suggested workaround is to keep sending the
in
Quoting Mika Kuoppala (2017-11-16 14:00:13)
> Chris Wilson writes:
>
> > During request construction, after pinning the context we know whether
> > or not we have to emit a context switch. So move this common operation
> > from every caller into i915_gem_request_alloc() itself.
> >
> > v2: Always
Quoting Sagar Arun Kamble (2017-11-16 13:32:37)
> intel_lrc_irq_handler and i915_guc_irq_handler are HW submission related
> tasklet functions. Name them with "submission_tasklet" suffix and
> remove intel/i915 prefix as they are static. Also rename irq_tasklet
> as just tasklet for clarity.
>
> v
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer")
cause us to not send out any VICs in the AVI infoframes. That commit
was since reverted, but if and when we add aspect ratio handing back
we ne
On 16/11/2017 14:35, Chris Wilson wrote:
Look at the first 16 characters of the user buffer and if they are all
printable, assume that user buffer contains ASCII data (e.g. a debug log)
that we want to simply print out. Otherwise, we treat it as a binary data
and hexdump as before.
Tvrtko: you
== Series Details ==
Series: GuC submission functions/struct name/prototype update (rev3)
URL : https://patchwork.freedesktop.org/series/33679/
State : warning
== Summary ==
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test kms_flip:
Regards
Shashank
On 11/13/2017 10:34 PM, Ville Syrjala wrote:
From: Ville Syrjälä
If the user mode would specify an aspect ratio other than 4:3 or 16:9
we now silently ignore it. Maybe a better apporoach is to return an
error? Let's try that.
Also we must be careful that we don't try to sen
Quoting Patchwork (2017-11-16 14:56:50)
> == Series Details ==
>
> Series: GuC submission functions/struct name/prototype update (rev3)
> URL : https://patchwork.freedesktop.org/series/33679/
> State : warning
>
> == Summary ==
>
> Test kms_setmode:
> Subgroup basic:
>
Quoting Michel Thierry (2017-11-15 18:30:27)
> The first test aims to check guc_init_doorbell_hw, changing the existing
> guc clients and doorbells state before calling it.
>
> The second test tries to create as many clients as it is currently possible
> (currently limited to max number of doorbel
On Wed, Nov 15, 2017 at 09:17:01PM -, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Don't sanitize frame start delay if the pipe is off
> URL : https://patchwork.freedesktop.org/series/33901/
> State : success
>
> == Summary ==
>
> Test kms_busy:
> Subgroup extended
On Wed, Nov 15, 2017 at 09:13:28PM +, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-11-15 20:04:42)
> > From: Ville Syrjälä
> >
> > Avoid touching PIPECONF in intel_sanitize_crtc() unless the pipe is
> > actually on. Should cure some unclaimed register accesses.
> + during reset, as we ar
Quoting Chris Wilson (2017-11-15 15:25:58)
> When operating on the live_ggtt we have to find a usuable hole for our
> test. It is possible for there to be no hole we can use, so initialise
> the err to 0 for the early exit.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/selftests/i
Now that we have that information in topology fields, let's just reused it.
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_debugfs.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu
Hi all,
Based on feedback on previous series by Tvrtko & myself, here is a
series that exposes EU topology & engines availability through sysfs.
Cheers,
Lionel Landwerlin (4):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915: ex
Up to now, subslice mask was assumed to be uniform across slices. But
starting with Cannonlake, slices can be asymetric (for example slice0
has different number of subslices as slice1+). This change stores all
subslices masks for all slices rather than having a single mask that
applies to all slice
With the introduction of asymetric slices in CNL, we cannot rely on
the previous SUBSLICE_MASK getparam. Here we introduce a more detailed
way of querying the Gen's GPU topology that doesn't aggregate numbers.
This is essential for monitoring parts of the GPU with the OA unit,
because signals need
This enables userspace to discover the engines available on the GPU.
Here is the layout :
/sys/devices/pci:00/:00:02.0/drm/card0/engines
├── bcs0
│ ├── class
│ └── instance
├── rcs0
│ ├── class
│ └── instance
├── vcs0
│ ├── class
│ ├── hevc
│ └── instance
├── vcs1
│ ├── cla
From: Ville Syrjälä
Moving the init_clock_gating() call from intel_modeset_init_hw() to
intel_modeset_gem_init() had an unintended effect of not applying
some workarounds on resume. This, for example, cause some kind of
corruption to appear at the top of my IVB Thinkpad X1 Carbon LVDS
screen afte
== Series Details ==
Series: drm/i915: Expose more GPU properties through sysfs
URL : https://patchwork.freedesktop.org/series/33950/
State : failure
== Summary ==
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
A lot of code duplicates this, but it should be handled in the core.
Add it and use it after igt_display_init(), the tests have to be
converted one by one.
Changes since v1:
- Merely reset rotation to HW value.
Signed-off-by: Maarten Lankhorst
---
lib/igt_kms.c | 164 +++
Quoting Ville Syrjala (2017-11-16 16:02:15)
> From: Ville Syrjälä
>
> Moving the init_clock_gating() call from intel_modeset_init_hw() to
> intel_modeset_gem_init() had an unintended effect of not applying
> some workarounds on resume. This, for example, cause some kind of
> corruption to appear
On Thu, Nov 16, 2017 at 08:06:18PM +0530, Sharma, Shashank wrote:
> Regards
>
> Shashank
>
>
> On 11/13/2017 10:34 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > HDMI 2.0 Appendix F suggest that we should keep sending the infoframe
> > when switching from 3D to 2D mode, even if the in
== Series Details ==
Series: drm/i915: Fix init_clock_gating for resume (rev2)
URL : https://patchwork.freedesktop.org/series/33718/
State : success
== Summary ==
Series 33718v2 drm/i915: Fix init_clock_gating for resume
https://patchwork.freedesktop.org/api/1.0/series/33718/revisions/2/mbox/
== Series Details ==
Series: series starting with lib/igt_kms: Add igt_display_reset function, v2.
(rev2)
URL : https://patchwork.freedesktop.org/series/33934/
State : failure
== Summary ==
IGT patchset build failed on latest successful build
936b97165308e179880fc0f218192881953f2544 lib: Dump
On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote:
> Regards
>
> Shashank
>
>
> On 11/13/2017 10:34 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer")
> > cause us to not send out any VICs in the AVI infofra
On Thu, Nov 16, 2017 at 08:31:36PM +0530, Sharma, Shashank wrote:
> Regards
>
> Shashank
>
>
> On 11/13/2017 10:34 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > If the user mode would specify an aspect ratio other than 4:3 or 16:9
> > we now silently ignore it. Maybe a better apporoa
1 - 100 of 150 matches
Mail list logo
