Re: [Intel-gfx] [PATCH i-g-t v3] kms_atomic_transition: Split out modeset tests on internal panels

2017-11-09 Thread Maarten Lankhorst
Op 08-11-17 om 20:33 schreef Imre Deak: > Doing modeset on internal panels may have a considerable overhead due to > the panel specific power sequencing delays. To avoid long test runtimes > in CI split out the testing of internal panels from the plane modeset > subtests and test only a reduced num

Re: [Intel-gfx] [PATCH] drm/i915/intel_sdvo: mark expected switch fall-throughs

2017-11-09 Thread Jani Nikula
On Wed, 08 Nov 2017, "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 141432 > Addresses-Coverity-ID: 141433 > Addresses-Coverity-ID: 141434 > Addresses-Coverity-ID: 141435 > Add

[Intel-gfx] [PATCH] drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU

2017-11-09 Thread Chris Wilson
When we close the VMA, we unbind it from the ppgtt and tear down the page directory pointing at it. That may trigger us to return WC pages back to the system, requiring conversion back to WB which itself may sleep. That makes i915_vma_close() unsuitable for use inside the RCU read lock, which we ne

Re: [Intel-gfx] [PATCH] drm/edid: Don't send non-zero YQ in AVI infoframe for HDMI 1.x sinks

2017-11-09 Thread Daniel Vetter
On Wed, Nov 08, 2017 at 02:21:08PM -0800, Eric Anholt wrote: > Ville Syrjälä writes: > > > On Wed, Nov 08, 2017 at 12:17:28PM -0800, Eric Anholt wrote: > >> Ville Syrjala writes: > >> > >> > From: Ville Syrjälä > >> > > >> > Apparently some sinks look at the YQ bits even when receiving RGB, >

Re: [Intel-gfx] [PATCH] drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU

2017-11-09 Thread Tvrtko Ursulin
On 09/11/2017 08:20, Chris Wilson wrote: When we close the VMA, we unbind it from the ppgtt and tear down the page directory pointing at it. That may trigger us to return WC pages back to the system, requiring conversion back to WB which itself may sleep. That makes i915_vma_close() unsuitable f

Re: [Intel-gfx] [PATCH v2 06/15] drm/exynos: Use drm_fb_helper_lastclose() and _poll_changed()

2017-11-09 Thread Inki Dae
2017년 10월 31일 19:28에 Daniel Vetter 이(가) 쓴 글: > On Mon, Oct 30, 2017 at 04:39:42PM +0100, Noralf Trønnes wrote: >> This driver can use drm_fb_helper_lastclose() as its .lastclose callback. >> It can also use drm_fb_helper_output_poll_changed() as its >> .output_poll_changed callback. >> >> Cc: Ink

[Intel-gfx] [PATCH FOR CI v2] drm/i915: Generalize transcoder looping

2017-11-09 Thread Mika Kahola
To make looping through transcoders in intel_ddi.c more generic, let's switch to use 'for_each_pipe()' macro to do this. v2: Add a notion that we are dealing with transcoders instead of pipes (Jani) Reviewed-by: Ville Syrjälä Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_ddi.c | 10

Re: [Intel-gfx] [PATCH] HAX: WARN_ON(crtc->crc.opened during disable)

2017-11-09 Thread Tomi Sarvela
On 08/11/17 17:59, Jani Nikula wrote: On Wed, 08 Nov 2017, Tomi Sarvela wrote: On 08/11/17 17:27, Jani Nikula wrote: On Wed, 08 Nov 2017, Chris Wilson wrote: Quoting Jani Nikula (2017-11-08 13:06:39) Please use trybot (i.e. send patches to intel-gfx-try...@lists.freedesktop.org) for hacks

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU URL : https://patchwork.freedesktop.org/series/33491/ State : failure == Summary == Series 33491v1 drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU https://patc

Re: [Intel-gfx] [PATCH] drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU

2017-11-09 Thread Chris Wilson
Quoting Chris Wilson (2017-11-09 08:20:48) > When we close the VMA, we unbind it from the ppgtt and tear down the > page directory pointing at it. That may trigger us to return WC pages > back to the system, requiring conversion back to WB which itself may > sleep. That makes i915_vma_close() unsui

[Intel-gfx] [PATCH v2] drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU

2017-11-09 Thread Chris Wilson
When we close the VMA, we unbind it from the ppgtt and tear down the page directory pointing at it. That may trigger us to return WC pages back to the system, requiring conversion back to WB which itself may sleep. That makes i915_vma_close() unsuitable for use inside the RCU read lock, which we ne

[Intel-gfx] [PATCH] drm/atomic-helper: always track connector commits, too

2017-11-09 Thread Daniel Vetter
It's useful for syncing async connector work like link retraining. v2: Make it work (Manasi&Ville) Cc: Manasi Navare Cc: Maarten Lankhorst Cc: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic_helper.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-)

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Generalize transcoder looping (rev3)

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Generalize transcoder looping (rev3) URL : https://patchwork.freedesktop.org/series/32965/ State : warning == Summary == Series 32965v3 drm/i915: Generalize transcoder looping https://patchwork.freedesktop.org/api/1.0/series/32965/revisions/3/mbox/ Test

Re: [Intel-gfx] [RESEND PATCH v3 05/12] drm/i915: Use drm_fb_helper_output_poll_changed()

2017-11-09 Thread Noralf Trønnes
Den 06.11.2017 23.48, skrev Noralf Trønnes: This driver can use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- I'm resending to get a CI run. This

Re: [Intel-gfx] [PATCH] HAX: WARN_ON(crtc->crc.opened during disable)

2017-11-09 Thread Jani Nikula
On Wed, 08 Nov 2017, Martin Peres wrote: > On 08/11/17 17:59, Jani Nikula wrote: >> On Wed, 08 Nov 2017, Tomi Sarvela wrote: >>> On 08/11/17 17:27, Jani Nikula wrote: On Wed, 08 Nov 2017, Chris Wilson wrote: > Quoting Jani Nikula (2017-11-08 13:06:39) >> >> Please use trybot (i.

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: expose command stream timestamp frequency to userspace

2017-11-09 Thread Sagar Arun Kamble
On 11/8/2017 11:06 PM, Lionel Landwerlin wrote: Is there anyone with spare time to review this patch? I'm on it. It's kind of required for userspace to make sense of timestamps on CNL. Thanks a lot, - Lionel On 02/11/17 16:29, Lionel Landwerlin wrote: We use to have this fixed per generati

Re: [Intel-gfx] [PATCH] drm/i915/intel_sdvo: mark expected switch fall-throughs

2017-11-09 Thread Jani Nikula
On Thu, 09 Nov 2017, Jani Nikula wrote: > On Wed, 08 Nov 2017, "Gustavo A. R. Silva" wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Addresses-Coverity-ID: 141432 >> Addresses-Coverity-ID: 141433 >> Addresses-Coverity

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915: Define an engine class enum for the uABI

2017-11-09 Thread Lionel Landwerlin
On 08/11/17 19:14, Chris Wilson wrote: +/* + * Different engines serve different roles, and there may be more than one + * engine serving each role. enum drm_i915_gem_engine_class provides a + * classification of the role of the engine, which may be used when requesting + * operations to be pe

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915: Define an engine class enum for the uABI

2017-11-09 Thread Tvrtko Ursulin
On 09/11/2017 09:13, Lionel Landwerlin wrote: On 08/11/17 19:14, Chris Wilson wrote: +/* + * Different engines serve different roles, and there may be more than one + * engine serving each role. enum drm_i915_gem_engine_class provides a + * classification of the role of the engine, which may

Re: [Intel-gfx] [PATCH v2] drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU

2017-11-09 Thread Tvrtko Ursulin
On 09/11/2017 08:55, Chris Wilson wrote: When we close the VMA, we unbind it from the ppgtt and tear down the page directory pointing at it. That may trigger us to return WC pages back to the system, requiring conversion back to WB which itself may sleep. That makes i915_vma_close() unsuitable f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU (rev2)

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU (rev2) URL : https://patchwork.freedesktop.org/series/33491/ State : success == Summary == Series 33491v2 drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU https

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915: Define an engine class enum for the uABI

2017-11-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-09 09:27:33) > > On 09/11/2017 09:13, Lionel Landwerlin wrote: > > On 08/11/17 19:14, Chris Wilson wrote: > >> +/* > >> + * Different engines serve different roles, and there may be more > >> than one > >> + * engine serving each role. enum drm_i915_gem_engine_clas

[Intel-gfx] [PATCH v17 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-11-09 Thread Tina Zhang
v16->v17: 1) modify VFIO_DEVICE_GET_GFX_DMABUF interface. (Alex) 2) add comments for x_hot/y_hot. (Gerd) v15->v16: 1) add cursor hotspot fields in struct vfio_device_gfx_plane_info. (Gerd) 2) clean up some typos and add comments for VFIO_DEVICE_QUERY_GFX_PLANE. (Alex) 3) seperate the GEM Proxy par

[Intel-gfx] [PATCH v17 3/6] drm/i915/gvt: Add RGB 64-bit 16:16:16:16 float format

2017-11-09 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows 10 guest VM. This patch is to add this pixel format support to gvt device model. Without this patch, some Apps, e.g. "DXGIGammaVM.exe", will crash and make guest screen black. Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gv

[Intel-gfx] [PATCH v17 2/6] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-11-09 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by some Apps in windows. The float format in each component is 1:5:10 MSb-sign:exponent: fraction. This patch is to introduce the format to drm, so that the windows guest's framebuffer in this kind of format can be recognized and used by linu

[Intel-gfx] [PATCH v17 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-09 Thread Tina Zhang
Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user query and get a plane and its related information. So far, two types of buffers are supported: buffers based on dma-buf and buffers based on region. This ioctl can be invoked with: 1) either DMABUF or REGION flag. Vendor driver returns a pl

[Intel-gfx] [PATCH v17 1/6] drm/i915/gvt: Add framebuffer decoder support

2017-11-09 Thread Tina Zhang
This patch is to introduce the framebuffer decoder which can decode guest OS's framebuffer information, including primary, cursor and sprite plane. v16: rebase to 4.14.0-rc6. v14: - refine pixel format table. (Zhenyu) v9: - move drm format change to a separate patch. (Xiaoguang) v8: - fix a bu

[Intel-gfx] [PATCH v17 4/6] drm/i915/gvt: Add opregion support

2017-11-09 Thread Tina Zhang
Windows guest driver needs vbt in opregion, to configure the setting for display. Without opregion support, the display registers won't be set and this blocks display model to get the correct information of the guest display plane. This patch is to provide a virtual opregion for guest. Current imp

[Intel-gfx] [PATCH v17 6/6] drm/i915/gvt: Dmabuf support for GVT-g

2017-11-09 Thread Tina Zhang
This patch introduces a guest's framebuffer sharing mechanism based on dma-buf subsystem. With this sharing mechanism, guest's framebuffer can be shared between guest VM and host. v17: - modify VFIO_DEVICE_GET_GFX_DMABUF interface. (Alex) v16: - add x_hot and y_hot. (Gerd) - add flag validation f

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Generalize transcoder looping (rev3)

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Generalize transcoder looping (rev3) URL : https://patchwork.freedesktop.org/series/32965/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup basic: skip -> PASS (shard-hsw) fdo#103167 Test kms_busy:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with drm/atomic-helper: always track connector commits, too (rev3)

2017-11-09 Thread Patchwork
== Series Details == Series: series starting with drm/atomic-helper: always track connector commits, too (rev3) URL : https://patchwork.freedesktop.org/series/33410/ State : failure == Summary == Series 33410v3 series starting with drm/atomic-helper: always track connector commits, too https

Re: [Intel-gfx] [PATCH v2] drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU

2017-11-09 Thread Tvrtko Ursulin
On 09/11/2017 09:32, Tvrtko Ursulin wrote: On 09/11/2017 08:55, Chris Wilson wrote: When we close the VMA, we unbind it from the ppgtt and tear down the page directory pointing at it. That may trigger us to return WC pages back to the system, requiring conversion back to WB which itself may sl

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915: Define an engine class enum for the uABI

2017-11-09 Thread Tvrtko Ursulin
On 09/11/2017 09:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-09 09:27:33) On 09/11/2017 09:13, Lionel Landwerlin wrote: On 08/11/17 19:14, Chris Wilson wrote: +/* + * Different engines serve different roles, and there may be more than one + * engine serving each role. enum drm_i9

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v5,1/9] drm/i915: Include engine state on detecting a missed breadcrumb/seqno

2017-11-09 Thread Patchwork
== Series Details == Series: series starting with [v5,1/9] drm/i915: Include engine state on detecting a missed breadcrumb/seqno URL : https://patchwork.freedesktop.org/series/33452/ State : failure == Summary == Series 33452v1 series starting with [v5,1/9] drm/i915: Include engine state on

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Dma-buf support for GVT-g

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Dma-buf support for GVT-g URL : https://patchwork.freedesktop.org/series/33502/ State : failure == Summary == Series 33502 revision 1 was fully merged or fully failed: no git log ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH v2] drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU

2017-11-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-09 10:00:27) > > On 09/11/2017 09:32, Tvrtko Ursulin wrote: > > > > On 09/11/2017 08:55, Chris Wilson wrote: > >> When we close the VMA, we unbind it from the ppgtt and tear down the > >> page directory pointing at it. That may trigger us to return WC pages > >> ba

Re: [Intel-gfx] [PATCH i-g-t v2] intel_gvtg_test: Handle system(3) return value.

2017-11-09 Thread Tvrtko Ursulin
On 08/11/2017 12:52, Petri Latvala wrote: On Wed, Nov 08, 2017 at 12:47:43PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoid the build warning by checking the pkill either did not find any guests or managed to send a signal to all of them. v2: Inspect system(3) return value properly.

Re: [Intel-gfx] [PATCH i-g-t 4/5] gem_syslatency: Avoid arithmetic on void * warning

2017-11-09 Thread Tvrtko Ursulin
On 08/11/2017 12:28, Petri Latvala wrote: On Wed, Nov 08, 2017 at 12:06:53PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin Chris wanted to disable the warning here instead. Either way is fine with me so Reviewed-by: Petri Latvala Thanks, I did not want

[Intel-gfx] [PATCH] drm/i915: Mark vm_free_page() as a potential sleeper agent

2017-11-09 Thread Chris Wilson
vm_free_page() may call down into set_pages_array_wb() (which itself sleeps, on x86 at least) but only if on !llc and the caches overflow. Since this is unlikely, we only rarely trigger the error in practice, and so to make CI detection of this sleeping bug possible we want to mark the common vm_fr

Re: [Intel-gfx] [PATCH] drm/i915: Mark vm_free_page() as a potential sleeper agent

2017-11-09 Thread Chris Wilson
Quoting Chris Wilson (2017-11-09 10:21:41) > vm_free_page() may call down into set_pages_array_wb() (which itself > sleeps, on x86 at least) but only if on !llc and the caches overflow. > Since this is unlikely, we only rarely trigger the error in practice, > and so to make CI detection of this sle

Re: [Intel-gfx] [PATCH (resend) 1/3] drm/i915: Ignore previous watermarks on ILK if inherited

2017-11-09 Thread Daniel Vetter
On Wed, Nov 08, 2017 at 05:09:33PM +0100, Maarten Lankhorst wrote: > Op 08-11-17 om 16:41 schreef Daniel Vetter: > > On Wed, Nov 08, 2017 at 10:29:20AM +0100, Maarten Lankhorst wrote: > >> Fixes the following error when fastset is enabled, caught by CI: > >> > >> [drm:ilk_validate_wm_level.part.8 [

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Mark vm_free_page() as a potential sleeper agent

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Mark vm_free_page() as a potential sleeper agent URL : https://patchwork.freedesktop.org/series/33503/ State : warning == Summary == Series 33503v1 drm/i915: Mark vm_free_page() as a potential sleeper agent https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH i-g-t] Revert "tests/kms_flip: Make flip-vs-panning-vs-hang change DSPSURF"

2017-11-09 Thread Daniel Vetter
On Wed, Nov 08, 2017 at 02:26:31PM +0100, Maarten Lankhorst wrote: > From: Maarten Lankhorst > > This reverts commit 7296e09ee7f17e6d564e52cf64ee900670849429. > This commit was accidentally applied twice, the first time in > commit e4ba3b75e6de35483b2edea21ceda145ef0b3311. > > Signed-off-by: Maa

Re: [Intel-gfx] [PATCH] drm/i915: Mark vm_free_page() as a potential sleeper agent

2017-11-09 Thread Daniel Vetter
On Thu, Nov 09, 2017 at 10:23:44AM +, Chris Wilson wrote: > Quoting Chris Wilson (2017-11-09 10:21:41) > > vm_free_page() may call down into set_pages_array_wb() (which itself > > sleeps, on x86 at least) but only if on !llc and the caches overflow. > > Since this is unlikely, we only rarely tr

[Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

2017-11-09 Thread Mika Kahola
At least in Coffee Lake it happens that we start initiliazing audio when no display is connected. This was discovered by CI when running IGT test case drv_module_reload --r basic-no-display The issue here is that the 'intel_device_info_runtime_init()' sets num_pipes to 0 but before this happens t

Re: [Intel-gfx] [PATCH] drm/i915: Mark vm_free_page() as a potential sleeper agent

2017-11-09 Thread Chris Wilson
Quoting Daniel Vetter (2017-11-09 10:46:41) > On Thu, Nov 09, 2017 at 10:23:44AM +, Chris Wilson wrote: > > Quoting Chris Wilson (2017-11-09 10:21:41) > > > vm_free_page() may call down into set_pages_array_wb() (which itself > > > sleeps, on x86 at least) but only if on !llc and the caches ove

[Intel-gfx] [PATCH v3] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-09 Thread Lucas De Marchi
Wa Display #1183 was recently added to workaround "Failures when enabling DPLL0 with eDP link rate 2.16 or 4.32 GHz and CD clock frequency 308.57 or 617.14 MHz (CDCLK_CTL CD Frequency Select 10b or 11b) used in this enabling or in previous enabling." This Workaround was designed to minimize the i

[Intel-gfx] [PATCH] drm/i915: Mark up i915_vma_unbind() as a potential sleeper

2017-11-09 Thread Chris Wilson
Whenever we want to unbind a vma, we must wait on all GPU activity to complete first. (This is what gives us the ability to do fine grained eviction and purging by only having to wait on the VMA that we need to unbind to proceed; though if pushed we can make it a rule that we are only allowed to un

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU (rev2)

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU (rev2) URL : https://patchwork.freedesktop.org/series/33491/ State : success == Summary == Test perf: Subgroup polling: pass -> FAIL (shard-hsw) fdo#102

Re: [Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

2017-11-09 Thread Chris Wilson
Quoting Mika Kahola (2017-11-09 10:49:52) > At least in Coffee Lake it happens that we start initiliazing audio when > no display is connected. This was discovered by CI when running IGT test > case > > drv_module_reload --r basic-no-display > > The issue here is that the 'intel_device_info_runti

Re: [Intel-gfx] [PATCH v5 1/9] drm/i915: Include engine state on detecting a missed breadcrumb/seqno

2017-11-09 Thread Mika Kuoppala
Chris Wilson writes: > Now that we have a common engine state pretty printer, we can use that > instead of the adhoc information printed when we miss a breadcrumb. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/intel_breadcrumbs.c | 11 ++

Re: [Intel-gfx] [PATCH v5 1/9] drm/i915: Include engine state on detecting a missed breadcrumb/seqno

2017-11-09 Thread Chris Wilson
Quoting Mika Kuoppala (2017-11-09 11:03:39) > Chris Wilson writes: > > > Now that we have a common engine state pretty printer, we can use that > > instead of the adhoc information printed when we miss a breadcrumb. > > > > Signed-off-by: Chris Wilson > > Cc: Mika Kuoppala > > Cc: Tvrtko Ursuli

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915: Define an engine class enum for the uABI

2017-11-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-09 10:04:17) > > On 09/11/2017 09:37, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-11-09 09:27:33) > >> > >> On 09/11/2017 09:13, Lionel Landwerlin wrote: > >>> On 08/11/17 19:14, Chris Wilson wrote: > +/* > + * Different engines serve different ro

Re: [Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

2017-11-09 Thread Mika Kahola
On Thu, 2017-11-09 at 11:01 +, Chris Wilson wrote: > Quoting Mika Kahola (2017-11-09 10:49:52) > > > > At least in Coffee Lake it happens that we start initiliazing audio > > when > > no display is connected. This was discovered by CI when running IGT > > test > > case > > > > drv_module_relo

[Intel-gfx] [PATCH v2] drm/i915: Use trace_printk to provide a death rattle for GEM

2017-11-09 Thread Chris Wilson
Trying to enable printk debugging for GEM is fraught with the issue of spam; interactions with HW are very frequent and often boring. However, one instance where they are not so boring is just before a BUG; here ftrace provides a facility to dump its ringbuffer on an oops. So for CI let's enable tr

Re: [Intel-gfx] [PATCH v5 2/9] drm/i915: Define an engine class enum for the uABI

2017-11-09 Thread Lionel Landwerlin
On 09/11/17 11:13, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-09 10:04:17) On 09/11/2017 09:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-09 09:27:33) On 09/11/2017 09:13, Lionel Landwerlin wrote: On 08/11/17 19:14, Chris Wilson wrote: +/* + * Different engines serve diffe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Return early when pipes are not available

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Return early when pipes are not available URL : https://patchwork.freedesktop.org/series/33506/ State : success == Summary == Series 33506v1 drm/i915: Return early when pipes are not available https://patchwork.freedesktop.org/api/1.0/series/33506/revisio

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Mark vm_free_page() as a potential sleeper agent

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Mark vm_free_page() as a potential sleeper agent URL : https://patchwork.freedesktop.org/series/33503/ State : success == Summary == Test kms_cursor_legacy: Subgroup flip-vs-cursor-atomic-transitions: pass -> FAIL (shar

[Intel-gfx] [PATCH v2] drm/i915: Include engine state on detecting a missed breadcrumb/seqno

2017-11-09 Thread Chris Wilson
Now that we have a common engine state pretty printer, we can use that instead of the adhoc information printed when we miss a breadcrumb. v2: Rearrange intel_engine_disarm_breadcrumbs() to avoid calling intel_engine_dump() under the rb spinlock (Mika) and to pretty-print the error state early so

Re: [Intel-gfx] [RFC PATCH 1/6] drm/i915: Remove Gen9 WAs with no effect

2017-11-09 Thread Mika Kuoppala
Oscar Mateo writes: > GEN8_CONFIG0 (0xD00) is a protected by a lock (bit 31) which is set by > the BIOS, so there is no way we can enable the three chicken bits > mandated by the WA (the BIOS should be doing it instead). > > v2: Rebased > v3: Standalone patch > > Signed-off-by: Oscar Mateo > Cc:

Re: [Intel-gfx] [PATCH v2] drm/i915: Include engine state on detecting a missed breadcrumb/seqno

2017-11-09 Thread Chris Wilson
Quoting Chris Wilson (2017-11-09 11:39:58) > Now that we have a common engine state pretty printer, we can use that > instead of the adhoc information printed when we miss a breadcrumb. > > v2: Rearrange intel_engine_disarm_breadcrumbs() to avoid calling > intel_engine_dump() under the rb spinlock

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl URL : https://patchwork.freedesktop.org/series/33508/ State : success == Summary == Series 33508v1 drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl https://patchwork.freedesktop.org/api/1.0/series/33508/rev

Re: [Intel-gfx] [RFC PATCH 1/6] drm/i915: Remove Gen9 WAs with no effect

2017-11-09 Thread Chris Wilson
Quoting Mika Kuoppala (2017-11-09 11:42:45) > Oscar Mateo writes: > > > GEN8_CONFIG0 (0xD00) is a protected by a lock (bit 31) which is set by > > the BIOS, so there is no way we can enable the three chicken bits > > mandated by the WA (the BIOS should be doing it instead). > > > > v2: Rebased >

Re: [Intel-gfx] [PATCH 0/4] drm/i915: introduce query information

2017-11-09 Thread Lionel Landwerlin
With the GPUTop bits wired, here are some mugshots of a set of NUCs I have running nearby (KBL/SKL/APL) : https://imgur.com/a/uHzJc On 08/11/17 16:22, Lionel Landwerlin wrote: Hi, This series is based off work that Tvrtko started, initially for exposing the engines available to userspace. I'

Re: [Intel-gfx] [PATCH v2] drm/i915: Use trace_printk to provide a death rattle for GEM

2017-11-09 Thread Joonas Lahtinen
On Thu, 2017-11-09 at 11:15 +, Chris Wilson wrote: > Trying to enable printk debugging for GEM is fraught with the issue of > spam; interactions with HW are very frequent and often boring. However, > one instance where they are not so boring is just before a BUG; here > ftrace provides a facili

Re: [Intel-gfx] [PATCH] drm/i915: Mark up i915_vma_unbind() as a potential sleeper

2017-11-09 Thread Joonas Lahtinen
On Thu, 2017-11-09 at 10:59 +, Chris Wilson wrote: > Whenever we want to unbind a vma, we must wait on all GPU activity to > complete first. (This is what gives us the ability to do fine grained > eviction and purging by only having to wait on the VMA that we need to > unbind to proceed; though

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: expose command stream timestamp frequency to userspace

2017-11-09 Thread Sagar Arun Kamble
On 11/2/2017 9:59 PM, Lionel Landwerlin wrote: We use to have this fixed per generation, but starting with CNL userspace cannot tell just off the PCI ID. Let's make this information available. This is particularly useful for performance monitoring where much of the normalization work is done us

Re: [Intel-gfx] [PATCH v2] drm/i915: Use trace_printk to provide a death rattle for GEM

2017-11-09 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-11-09 11:53:53) > On Thu, 2017-11-09 at 11:15 +, Chris Wilson wrote: > > Trying to enable printk debugging for GEM is fraught with the issue of > > spam; interactions with HW are very frequent and often boring. However, > > one instance where they are not so boring

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Mark up i915_vma_unbind() as a potential sleeper

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Mark up i915_vma_unbind() as a potential sleeper URL : https://patchwork.freedesktop.org/series/33509/ State : warning == Summary == Series 33509v1 drm/i915: Mark up i915_vma_unbind() as a potential sleeper https://patchwork.freedesktop.org/api/1.0/series

[Intel-gfx] [PATCH 0/2] drm/i915: This set enables 90/270 degree rotation on 16bpp planes on gen10

2017-11-09 Thread Juha-Pekka Heikkila
90/270 16bpp rotation is supported in hadrware from Gen10 onwards. I modified kms_rotation_crc igt test to test this feature: https://patchwork.freedesktop.org/patch/186179/ v2: (Ville Syrjälä) move all rotation related checks from intel_plane_atomic_check_with_state into new function

[Intel-gfx] [PATCH 2/2] drm/i915: Enable 16bpp 90/270 plane rotation for gen10 onwards.

2017-11-09 Thread Juha-Pekka Heikkila
From gen10 onwards 16bpp 90/270 plane rotation is supported on hardware. Signed-off-by: Juha-Pekka Heikkila Testcase: https://patchwork.freedesktop.org/patch/186179/ --- drivers/gpu/drm/i915/intel_atomic_plane.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 1/2] drm/i915: Move rotation validity check into its own function

2017-11-09 Thread Juha-Pekka Heikkila
This makes intel_plane_atomic_check_with_state() generally shorter. v2: (Ville Syrjälä) move all rotation related checks from intel_plane_atomic_check_with_state into new function and don't pass dev_priv pointer around. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i91

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Mark up i915_vma_unbind() as a potential sleeper

2017-11-09 Thread Chris Wilson
Quoting Patchwork (2017-11-09 12:02:30) > == Series Details == > > Series: drm/i915: Mark up i915_vma_unbind() as a potential sleeper > URL : https://patchwork.freedesktop.org/series/33509/ > State : warning > > == Summary == > > Series 33509v1 drm/i915: Mark up i915_vma_unbind() as a potentia

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use trace_printk to provide a death rattle for GEM (rev2)

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Use trace_printk to provide a death rattle for GEM (rev2) URL : https://patchwork.freedesktop.org/series/33421/ State : success == Summary == Series 33421v2 drm/i915: Use trace_printk to provide a death rattle for GEM https://patchwork.freedesktop.org/api

[Intel-gfx] [PATCH igt] igt/gem_ctx_switch: Do a warmup pass over all contexts

2017-11-09 Thread Chris Wilson
Ensure that we always use every context at least once before we start running the stress-test. Signed-off-by: Chris Wilson --- tests/gem_ctx_switch.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/gem_ctx_switch.c b/tests/gem_ctx_switch.c index fdd67202..159554e5 100644 --- a/t

Re: [Intel-gfx] [PATCH] drm/i915: Mark up i915_vma_unbind() as a potential sleeper

2017-11-09 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-11-09 11:57:15) > On Thu, 2017-11-09 at 10:59 +, Chris Wilson wrote: > > Whenever we want to unbind a vma, we must wait on all GPU activity to > > complete first. (This is what gives us the ability to do fine grained > > eviction and purging by only having to wait

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Include engine state on detecting a missed breadcrumb/seqno (rev2)

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Include engine state on detecting a missed breadcrumb/seqno (rev2) URL : https://patchwork.freedesktop.org/series/33407/ State : warning == Summary == Series 33407v2 drm/i915: Include engine state on detecting a missed breadcrumb/seqno https://patchwork

Re: [Intel-gfx] [PATCH i-g-t v3] kms_atomic_transition: Split out modeset tests on internal panels

2017-11-09 Thread Imre Deak
On Thu, Nov 09, 2017 at 09:03:37AM +0100, Maarten Lankhorst wrote: > Op 08-11-17 om 20:33 schreef Imre Deak: > > Doing modeset on internal panels may have a considerable overhead due to > > the panel specific power sequencing delays. To avoid long test runtimes > > in CI split out the testing of in

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Return early when pipes are not available

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Return early when pipes are not available URL : https://patchwork.freedesktop.org/series/33506/ State : failure == Summary == Test kms_setmode: Subgroup basic: fail -> PASS (shard-hsw) fdo#99912 Test kms_flip: S

Re: [Intel-gfx] [RFC 1/7] drm: Add Plane Degamma properties

2017-11-09 Thread Shankar, Uma
>-Original Message- >From: Brian Starkey [mailto:brian.star...@arm.com] >Sent: Tuesday, November 7, 2017 11:40 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville ; >Lankhorst, Maarten ; dri- >de...@lists.freedesktop.org >Subject: Re: [Intel-gfx] [RFC 1/7] drm: Add

Re: [Intel-gfx] [PATCH v3] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-09 Thread Ville Syrjälä
On Thu, Nov 09, 2017 at 02:58:04AM -0800, Lucas De Marchi wrote: > Wa Display #1183 was recently added to workaround > "Failures when enabling DPLL0 with eDP link rate 2.16 > or 4.32 GHz and CD clock frequency 308.57 or 617.14 MHz > (CDCLK_CTL CD Frequency Select 10b or 11b) used in this > enablin

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: This set enables 90/270 degree rotation on 16bpp planes on gen10 (rev2)

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: This set enables 90/270 degree rotation on 16bpp planes on gen10 (rev2) URL : https://patchwork.freedesktop.org/series/33133/ State : warning == Summary == Series 33133v2 drm/i915: This set enables 90/270 degree rotation on 16bpp planes on gen10 https:/

Re: [Intel-gfx] [PATCH] drm/i915: Return early when pipes are not available

2017-11-09 Thread Ville Syrjälä
On Thu, Nov 09, 2017 at 01:11:05PM +0200, Mika Kahola wrote: > On Thu, 2017-11-09 at 11:01 +, Chris Wilson wrote: > > Quoting Mika Kahola (2017-11-09 10:49:52) > > > > > > At least in Coffee Lake it happens that we start initiliazing audio > > > when > > > no display is connected. This was dis

Re: [Intel-gfx] [PATCH] drm/i915: Display WA #1185 WaDisableDARBFClkGating:cnl, glk

2017-11-09 Thread Imre Deak
On Wed, Nov 08, 2017 at 03:30:16PM -0800, Rodrigo Vivi wrote: > PM Rsp is not sent when plane is turned off at around the > time that a PM fill Req is received by display > > WA: disable arbiter clock gating, set bit [27] of 0x46530 > > Cc: Radhakrishna Sripada > Cc: Imre Deak > Signed-off-by:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl URL : https://patchwork.freedesktop.org/series/33508/ State : success == Summary == Test perf: Subgroup blocking: fail -> PASS (shard-hsw) fdo#102252 Test kms_flip: Su

Re: [Intel-gfx] [RFC PATCH v6 0/6] Refactor HW workaround code

2017-11-09 Thread Ville Syrjälä
On Wed, Nov 08, 2017 at 03:59:43PM -0800, Oscar Mateo wrote: > Until we agree on a design, I have removed all new code to save the actual > list > of WAs and dump it in debugfs. For the moment, only shuffle things arounds > until > most WAs are in the same file (and classified correctly according

Re: [Intel-gfx] [PATCH] drm/i915: Display WA #1185 WaDisableDARBFClkGating:cnl, glk

2017-11-09 Thread Ville Syrjälä
On Wed, Nov 08, 2017 at 03:30:16PM -0800, Rodrigo Vivi wrote: > PM Rsp is not sent when plane is turned off at around the > time that a PM fill Req is received by display Do we know what the impact of this is? The HSD just seems to say "Detection method: Hang" which isn't partciluarly helpful. To

[Intel-gfx] ✗ Fi.CI.BAT: warning for igt/gem_ctx_switch: Do a warmup pass over all contexts

2017-11-09 Thread Patchwork
== Series Details == Series: igt/gem_ctx_switch: Do a warmup pass over all contexts URL : https://patchwork.freedesktop.org/series/33515/ State : warning == Summary == IGT patchset tested on top of latest successful build e6c4968fa0dfd2df5dd81cdec9fd785250f30899 kms_atomic_transition: Split ou

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Nuke intel_digital_port->port

2017-11-09 Thread Ville Syrjälä
On Thu, Nov 09, 2017 at 01:37:48AM +, Pandiyan, Dhinakaran wrote: > > On Tue, 2017-10-31 at 22:51 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Remove intel_digital_port->port and replace its users with > > intel_encoder->port. intel_encoder->port is a superset of > > intel_dig

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: expose command stream timestamp frequency to userspace

2017-11-09 Thread Lionel Landwerlin
On 09/11/17 11:58, Sagar Arun Kamble wrote: On 11/2/2017 9:59 PM, Lionel Landwerlin wrote: We use to have this fixed per generation, but starting with CNL userspace cannot tell just off the PCI ID. Let's make this information available. This is particularly useful for performance monitoring

[Intel-gfx] [PATCH] drm/i915: Kerneldoc typo s/rps/rps_client/

2017-11-09 Thread Chris Wilson
Update the kerneldoc parameter name to match the real parameter name. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 1fd2e8809683..a0154929

Re: [Intel-gfx] [PATCH] drm/i915: Move irqs enabled assertion deeper for mock breadcrumbs

2017-11-09 Thread Chris Wilson
Quoting Chris Wilson (2017-11-07 10:20:03) > In order to allow the mock breadcrumbs tests to run without device irqs > being enabled, move the intel_irqs_enabled() assert deeper to just > before we commit to enabling the HW irq. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > Cc: Joonas L

Re: [Intel-gfx] [PATCH v17 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-11-09 Thread Gerd Hoffmann
On Thu, Nov 09, 2017 at 05:33:56PM +0800, Tina Zhang wrote: > v16->v17: > 1) modify VFIO_DEVICE_GET_GFX_DMABUF interface. (Alex) > 2) add comments for x_hot/y_hot. (Gerd) Hmm, doesn't apply cleanly here. Tried 4.14-rc8 + gem proxy v2 + this series. Seems the patches depend on unmerged gvt changes.

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: expose command stream timestamp frequency to userspace

2017-11-09 Thread Lionel Landwerlin
On 09/11/17 14:06, Lionel Landwerlin wrote: +    } else if (INTEL_GEN(dev_priv) <= 9) { +    u32 ctc_reg = I915_READ(GEN8_CTC_MODE); +    u64 freq = 0; + +    if ((ctc_reg & GEN8_CTC_SOURCE_PARAMETER_MASK) == GEN8_CTC_SOURCE_DIVIDE_LOGIC) +    freq = read_timestamp_frequenc

Re: [Intel-gfx] [PATCH] drm/i915/: Initialise trans_min for skl_compute_transition_wm()

2017-11-09 Thread Mahesh Kumar
On Thursday 09 November 2017 09:19 AM, Mahesh Kumar wrote: Hi, On Thursday 09 November 2017 01:30 AM, Ville Syrjälä wrote: On Wed, Nov 08, 2017 at 10:39:59AM +0530, Mahesh Kumar wrote: Hi, On Tuesday 07 November 2017 11:57 PM, Chris Wilson wrote: clang spots drivers/gpu/drm/i915/intel_pm

Re: [Intel-gfx] [PATCH (resend) 1/3] drm/i915: Ignore previous watermarks on ILK if inherited

2017-11-09 Thread Maarten Lankhorst
Op 09-11-17 om 11:41 schreef Daniel Vetter: > On Wed, Nov 08, 2017 at 05:09:33PM +0100, Maarten Lankhorst wrote: >> Op 08-11-17 om 16:41 schreef Daniel Vetter: >>> On Wed, Nov 08, 2017 at 10:29:20AM +0100, Maarten Lankhorst wrote: Fixes the following error when fastset is enabled, caught by CI

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use trace_printk to provide a death rattle for GEM (rev2)

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Use trace_printk to provide a death rattle for GEM (rev2) URL : https://patchwork.freedesktop.org/series/33421/ State : failure == Summary == Test perf: Subgroup blocking: fail -> PASS (shard-hsw) fdo#102252 Test kms_fr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Kerneldoc typo s/rps/rps_client/

2017-11-09 Thread Patchwork
== Series Details == Series: drm/i915: Kerneldoc typo s/rps/rps_client/ URL : https://patchwork.freedesktop.org/series/33523/ State : success == Summary == Series 33523v1 drm/i915: Kerneldoc typo s/rps/rps_client/ https://patchwork.freedesktop.org/api/1.0/series/33523/revisions/1/mbox/ Test c

[Intel-gfx] [PATCH v3] drm/i915: Use trace_printk to provide a death rattle for GEM

2017-11-09 Thread Chris Wilson
Trying to enable printk debugging for GEM is fraught with the issue of spam; interactions with HW are very frequent and often boring. However, one instance where they are not so boring is just before a BUG; here ftrace provides a facility to dump its ringbuffer on an oops. So for CI let's enable tr

Re: [Intel-gfx] [PATCH v3] drm/i915: Use trace_printk to provide a death rattle for GEM

2017-11-09 Thread Chris Wilson
Quoting Chris Wilson (2017-11-09 14:30:19) > Trying to enable printk debugging for GEM is fraught with the issue of > spam; interactions with HW are very frequent and often boring. However, > one instance where they are not so boring is just before a BUG; here > ftrace provides a facility to dump i

  1   2   >