Re: [Intel-gfx] [PATCH v2 05/15] drm/armada: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-31 Thread Russell King - ARM Linux
On Mon, Oct 30, 2017 at 04:39:41PM +0100, Noralf Trønnes wrote: > -static void armada_output_poll_changed(struct drm_device *dev) > -{ > - struct armada_private *priv = dev->dev_private; > - struct drm_fb_helper *fbh = priv->fbdev; > - > - if (fbh) > - drm_fb_helper_hotplug_

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove i915.enable_execlists module parameter

2017-10-31 Thread Lionel Landwerlin
I can't speak for the totality of the driver, but the perf part is : Reviewed-by: Lionel Landwerlin On 26/10/17 22:17, Chris Wilson wrote: diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 59ee808f8fd9..8dfa74bd3f37 100644 --- a/drivers/gpu/drm/i915/i915_pe

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-10-31 Thread Daniel Vetter
On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: > On Tue, Oct 31, 2017 at 4:27 AM, Jani Nikula > wrote: >> >> Reminder, we have this new list dim-to...@lists.freedesktop.org for >> maintainer tools patches. Cc'd. >> > > Ahh, cool. I didn't realize dim grew up! > >> On Mon, 30 Oct 2017, Sean Pau

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-10-31 Thread Sean Paul
On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: >> On Tue, Oct 31, 2017 at 4:27 AM, Jani Nikula >> wrote: >>> >>> Reminder, we have this new list dim-to...@lists.freedesktop.org for >>> maintainer tools patches. Cc'd. >>> >> >> Ahh, cool.

Re: [Intel-gfx] [PATCH v2 00/15] drm/fb-helper: Add .last_close and .output_poll_changed helpers

2017-10-31 Thread Noralf Trønnes
Den 30.10.2017 16.39, skrev Noralf Trønnes: This patchset adds fbdev .last_close and .output_poll_changed helpers to reduce fbdev emulation footprint in drivers. I don't know which drivers have their own tree or not, so if you want me to apply your patch to drm-misc, please let me know. I will

Re: [Intel-gfx] [PATCH v8 1/6] drm/i915 : Unifying seq_puts messages for feature support

2017-10-31 Thread Sujaritha
On 10/29/2017 09:49 PM, Sagar Arun Kamble wrote: On 10/26/2017 11:24 PM, Daniele Ceraolo Spurio wrote: On 25/10/17 06:31, Michal Wajdeczko wrote: On Tue, 24 Oct 2017 19:21:20 +0200, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages in debugfs to the simplest one for

Re: [Intel-gfx] [PATCH v8 1/6] drm/i915 : Unifying seq_puts messages for feature support

2017-10-31 Thread Sujaritha
On 10/25/2017 06:31 AM, Michal Wajdeczko wrote: On Tue, 24 Oct 2017 19:21:20 +0200, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages in debugfs to the simplest one for feature support. v2: Clarifying the commit message (Anusha) v3: Re-factoring code as per review (Micha

Re: [Intel-gfx] [PATCH v8 1/6] drm/i915 : Unifying seq_puts messages for feature support

2017-10-31 Thread Sujaritha
On 10/26/2017 10:54 AM, Daniele Ceraolo Spurio wrote: On 25/10/17 06:31, Michal Wajdeczko wrote: On Tue, 24 Oct 2017 19:21:20 +0200, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages in debugfs to the simplest one for feature support. v2: Clarifying the commit message

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Runtime disable for eDP DRRS

2017-10-31 Thread Rodrigo Vivi
On Tue, Oct 31, 2017 at 09:20:42AM +, Ramalingam C wrote: > From: "C, Ramalingam" > > Module parameter enable_drrs(Boolean flag) is added to control the > eDP Idleness drrs enable flow. This goes on the opposite direction of the current trends. Well, I'm a big fan of the parameters, but the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat

2017-10-31 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat URL : https://patchwork.freedesktop.org/series/32792/ State : success == Summary == Series 32792v1 drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat https://patchwork.freedesktop.org/ap

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Pass around crtc and connector states for audio

2017-10-31 Thread Ville Syrjälä
On Tue, Oct 31, 2017 at 11:19:03AM +0200, Jani Nikula wrote: > On Mon, 30 Oct 2017, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Explicitly pass the crtc and connector states into the audio > > code enable/disable hooks, and plumb them all the way down. > > > > This gets rid of almost all

[Intel-gfx] [PATCH 00/10] drm/i915: Nuke dig_port->port and assorted cleanups

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä The main attraction of this series is removal of intel_digital_port->port. Ever since the introduction of intel_encoder->port it has been redundant, and I figured it's high time we kill it. The other stuff is mostly elimination of uses of the legacy encoder->crtc pointer and

[Intel-gfx] [PATCH 03/10] drm/i915: Eliminate some encoder->crtc usage from SDVO code

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Extract the current crtc from the crtc state rather than via the legacy encoder->crtc pointer whenever possible. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sdvo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH 01/10] drm/i915: Eliminate some encoder->crtc usage from DP code

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Extract the current crtc from the crtc state rather than via the legacy encoder->crtc pointer whenever possible. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 63 +++-- 1 file changed, 29 insertions(+), 34 deletions(-

[Intel-gfx] [PATCH 04/10] drm/i915: Eliminate some encoder->crtc usage from TV code

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Extract the current crtc from the crtc state rather than via the legacy encoder->crtc pointer whenever possible. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_tv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH 07/10] drm/i915: Replace dig_port->port with encoder port for BXT DPLL selection

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Replace dig_port->port with encoder->port in the BXT DPLL selection. We can do this because both the master encoder and the fake MST encoders have the same encoder->port value, whereas using dig_port->port only worked for the master encoder since the fake encoders were't deriv

[Intel-gfx] [PATCH 08/10] drm/i915: Nuke intel_digital_port->port

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Remove intel_digital_port->port and replace its users with intel_encoder->port. intel_encoder->port is a superset of intel_digital_port->port, and it works correctly even for MST encoders. Performed with cocci: @@ @@ struct intel_digital_port { ... - enum port po

[Intel-gfx] [PATCH 10/10] drm/i915: Clean up DP code local variables and calling conventions

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Eliminate a ton of pointless 'dev' variables in the DP code, and pass around 'dev_priv' instead of 'dev'. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 151 ++-- 1 file changed, 54 insertions(+), 97 deletions(-) diff

[Intel-gfx] [PATCH 02/10] drm/i915: Eliminate some encoder->crtc usage from DSI code

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Extract the current crtc from the crtc state rather than via the legacy encoder->crtc pointer whenever possible. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dsi.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH 06/10] drm/i915: Eliminate crtc->config usage from CRT code

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Replace crtc->config usage with the passed down crtc state. Also take the opportunity for some s/pipe_config/crtc_state/ while at it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_crt.c | 44 +--- 1 file changed, 19 inserti

[Intel-gfx] [PATCH 09/10] drm/i915: Clean up PPS code calling conventions

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä No need to pass 'dev' or 'dev_priv' when the function already takes 'intel_dp'. Also let's prefer passing 'dev_priv' instead of 'dev' when we have to pass one or the other. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 99 +--

[Intel-gfx] [PATCH 05/10] drm/i915: Pass crtc state to DPIO PHY functions

2017-10-31 Thread Ville Syrjala
From: Ville Syrjälä Rather than digging through encoder->crtc and crtc->config in the DPIO PHY functions, pass down the correct crtc state from the caller. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 19 +--- drivers/gpu/drm/i915/intel_dp.c | 16 +++

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for GuC based reset engine

2017-10-31 Thread Michel Thierry
On 10/31/2017 3:20 AM, Chris Wilson wrote: Quoting Patchwork (2017-10-30 23:20:13) For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6267/shards.html https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6267/shard-kbl1/igt@prime_b...@wait-hang-render.html is suspicious. -

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for GuC based reset engine

2017-10-31 Thread Chris Wilson
Quoting Michel Thierry (2017-10-31 20:56:03) > On 10/31/2017 3:20 AM, Chris Wilson wrote: > > Quoting Patchwork (2017-10-30 23:20:13) > >> For more details see: > >> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6267/shards.html > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6267

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Pass around crtc and connector states for audio

2017-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Pass around crtc and connector states for audio URL : https://patchwork.freedesktop.org/series/32858/ State : success == Summary == Series 32858v1 series starting with [1/2] drm/i915: Pass around crtc and connector states for

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat

2017-10-31 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat URL : https://patchwork.freedesktop.org/series/32792/ State : success == Summary == Test kms_cursor_legacy: Subgroup flip-vs-cursor-toggle: fail -> PASS (shard-hsw)

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Add subtest time limit/randomize plane, pipe combinations

2017-10-31 Thread Chris Wilson
Quoting Imre Deak (2017-10-31 13:44:47) > Doing modeset on internal panels may have a considerable overhead due to > the panel specific power sequencing delays. To avoid long test runtimes > limit the runtime of each subtest. Randomize the plane/pipe combinations > to preserve the test coverage on

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Nuke dig_port->port and assorted cleanups

2017-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Nuke dig_port->port and assorted cleanups URL : https://patchwork.freedesktop.org/series/32928/ State : warning == Summary == Series 32928v1 drm/i915: Nuke dig_port->port and assorted cleanups https://patchwork.freedesktop.org/api/1.0/series/32928/revisio

[Intel-gfx] [PATCH v6] drm/i915/guc: Add support for reset engine using GuC commands

2017-10-31 Thread Michel Thierry
This patch adds per engine reset and recovery (TDR) support when GuC is used to submit workloads to GPU. In the case of i915 directly submission to ELSP, driver manages hang detection, recovery and resubmission. With GuC submission these tasks are shared between driver and GuC. i915 is still respo

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat

2017-10-31 Thread Rodrigo Vivi
On Mon, Oct 30, 2017 at 05:41:50PM +, Daniele Ceraolo Spurio wrote: > > > On 27/10/17 15:32, Michel Thierry wrote: > > There is no need check if PPGTT is disabled because that not possible > > in CNL. Execlists and GuC submission modes rely on at least aliasing > > PPGTT and even intel_saniti

Re: [Intel-gfx] [PATCH] drm/i915: set minimum CD clock to twice the BCLK.

2017-10-31 Thread Kumar, Abhay
On 10/30/2017 5:21 PM, Pandiyan, Dhinakaran wrote: On Sun, 2017-10-29 at 03:04 +, Kumar, Abhay wrote: + Subhransu -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Kumar, Abhay Sent: Thursday, October 26, 2017 12:10 PM To: Jani Nikul

[Intel-gfx] ✓ Fi.CI.BAT: success for GuC based reset engine (rev2)

2017-10-31 Thread Patchwork
== Series Details == Series: GuC based reset engine (rev2) URL : https://patchwork.freedesktop.org/series/32859/ State : success == Summary == Series 32859v2 GuC based reset engine https://patchwork.freedesktop.org/api/1.0/series/32859/revisions/2/mbox/ Test chamelium: Subgroup dp-crc

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Add GuC Load time to dmesg log.

2017-10-31 Thread Anusha Srivatsa
Calculate the time that GuC takes to load using jiffies. This information could be very useful in determining if GuC is taking unreasonably long time to load in a certain platforms. v2: Calculate time before logs are collected. Move the guc_load_time variable as a part of intel_uc_fw struct. Store

[Intel-gfx] [PATCH 2/2] drm/i915/huc: Add HuC Load time to dmesg log.

2017-10-31 Thread Anusha Srivatsa
This patch uses jiffies to calculate the huc load time.This information can be useful for testing to know how much time huc takes to load. v2: Remove debugfs entry. Remove local variable huc_finish_load. (Daniel, Tvrtko) v3: Use ktime_get() for more accurate timings. Ensure the load is successful

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat

2017-10-31 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat URL : https://patchwork.freedesktop.org/series/32792/ State : failure == Summary == Series 32792v1 drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat https://patchwork.freedesktop.org/ap

[Intel-gfx] ✗ Fi.CI.IGT: failure for GuC based reset engine (rev2)

2017-10-31 Thread Patchwork
== Series Details == Series: GuC based reset engine (rev2) URL : https://patchwork.freedesktop.org/series/32859/ State : failure == Summary == Test drv_module_reload: Subgroup basic-reload-inject: pass -> DMESG-WARN (shard-hsw) fdo#102707 Test kms_sysfs_edid_timin

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: Add GuC Load time to dmesg log.

2017-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Add GuC Load time to dmesg log. URL : https://patchwork.freedesktop.org/series/32936/ State : success == Summary == Series 32936v1 series starting with [1/2] drm/i915/guc: Add GuC Load time to dmesg log. https://patchwork.f

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc: Add GuC Load time to dmesg log.

2017-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Add GuC Load time to dmesg log. URL : https://patchwork.freedesktop.org/series/32936/ State : success == Summary == Test drv_module_reload: Subgroup basic-reload-inject: pass -> DMESG-WARN (shar

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2017-10-31 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: include/drm/drmP.h between commit: e7646f84ad4f ("drm: Add new LEASE debug level") from the drm tree and commit: 02c9656b2f0d ("drm: Move debug macros out of drmP.h") from the drm-misc tree. I fixed it up (I used

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

2017-10-31 Thread PrasannaKumar Muralidharan
Hi Daniel, On 31 October 2017 at 21:57, Daniel Vetter wrote: > On Tue, Oct 31, 2017 at 08:37:21PM +0530, PrasannaKumar Muralidharan wrote: >> My patch is supposed to catch problem with drivers. It warns when >> vblank refcount is non-zero in drm_vblank_cleanup call. From CI log it >> can be seen

Re: [Intel-gfx] [PATCH] drm/i915: Fix DPLL warning when starting guest VM

2017-10-31 Thread Zhenyu Wang
On 2017.10.31 03:09:04 +, Zhao, Xinda wrote: > > > > On Mon, Oct 30, 2017 at 03:49:28PM +0200, Ville Syrjälä wrote: > > > On Mon, Oct 30, 2017 at 04:17:06PM +0800, Zhao, Xinda wrote: > > > > The warning is occurred in guest VM when trying to get clock in > > > > encoder initialization. > > >

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-10-31 Thread Jani Nikula
Reminder, we have this new list dim-to...@lists.freedesktop.org for maintainer tools patches. Cc'd. On Mon, 30 Oct 2017, Sean Paul wrote: > Expanding on Jani's work to sign tags, this patch adds signing for git > commit/am. I guess I'd like more rationale here. Is this something we should be do

Re: [Intel-gfx] [PATCH] drm/i915: Fix DPLL warning when starting guest VM

2017-10-31 Thread Zhao, Xinda
> -Original Message- > From: Zhenyu Wang [mailto:zhen...@linux.intel.com] > Sent: Tuesday, October 31, 2017 2:52 PM > To: Zhao, Xinda > Cc: ville.syrj...@linux.intel.com; intel-gfx@lists.freedesktop.org; > intel-gvt-...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: F

Re: [Intel-gfx] [PATCH v2 5/7] drm/i915: check LSPCON vendor OUI

2017-10-31 Thread Maarten Lankhorst
Hey, Op 09-08-17 om 08:46 schreef Shashank Sharma: > Intel LSPCON chip is provided by 2 vendors: > - Megachips America (MCA) > - Parade technologies (Parade tech) > > Its important to know the vendor of this chip, as the address to > write AVI infoframes is different for those two. > > This patch

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-10-31 Thread Daniel Vetter
On Tue, Oct 31, 2017 at 10:27:24AM +0200, Jani Nikula wrote: > > Reminder, we have this new list dim-to...@lists.freedesktop.org for > maintainer tools patches. Cc'd. > > On Mon, 30 Oct 2017, Sean Paul wrote: > > Expanding on Jani's work to sign tags, this patch adds signing for git > > commit/a

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Pass around crtc and connector states for audio

2017-10-31 Thread Jani Nikula
On Mon, 30 Oct 2017, Ville Syrjala wrote: > From: Ville Syrjälä > > Explicitly pass the crtc and connector states into the audio > code enable/disable hooks, and plumb them all the way down. > > This gets rid of almost all crtc->config and encoder->crtc > uses. The one place where we still use th

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for tests: add device information tests

2017-10-31 Thread Petri Latvala
On Mon, Oct 30, 2017 at 02:11:10PM +, Patchwork wrote: > == Series Details == > > Series: tests: add device information tests > URL : https://patchwork.freedesktop.org/series/32764/ > State : success > > == Summary == > > Test kms_flip: > Subgroup basic-flip-vs-wf_vblank: >

[Intel-gfx] [PATCH 0/2] DRRS coverage in frontbuffer tracking IGT

2017-10-31 Thread Ramalingam C
From: "C, Ramalingam" FBC, DRRS and PSR are based on front buffer tracking infra. So the features in this set, needs to be tested for all possible test cases of front buffer tracking, individually and in all combinations of the features. eDP Idleness DRRS is implemented based on front buffer tra

[Intel-gfx] [PATCH 1/2] drm/i915: Runtime disable for eDP DRRS

2017-10-31 Thread Ramalingam C
From: "C, Ramalingam" Module parameter enable_drrs(Boolean flag) is added to control the eDP Idleness drrs enable flow. Modification to this module parameter will be considered on next eDP_DRRS enable flow. So after module parameter update, a modeset will help to modify the feature state as per

[Intel-gfx] [PATCH 2/2] i915/drrs/debugfs: module param and psr status

2017-10-31 Thread Ramalingam C
From: "C, Ramalingam" When DRRS is disabled, i915_drrs_status is updated with the runtime disable state of drrs due to i915_modparams.enable_drrs - module parameters psr.enabled - psr active status Signed-off-by: C, Ramalingam --- drivers/gpu/drm/i915/i915_debugfs.c | 11

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Idleness DRRS coverage

2017-10-31 Thread Ramalingam C
From: Lohith BS By default the DRRS state will be at DRRS_HIGH_RR. When a Display content is Idle for more than 1Sec Idleness will be declared and DRRS_LOW_RR will be invoked, changing the refresh rate to the lower most refresh rate supported by the panel. As soon as there is a display content ch

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Runtime disable for eDP DRRS

2017-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Runtime disable for eDP DRRS URL : https://patchwork.freedesktop.org/series/32887/ State : failure == Summary == HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o SHIPPED scripts/kconfig/zconf.tab.c SHIPPED scr

[Intel-gfx] sound tree breaks make clean

2017-10-31 Thread Daniel Vetter
Hi all, The following commit commit 60d4981ccf3603669c8de304619048ad5da707bd Author: Takashi Iwai Date: Tue Oct 24 09:15:23 2017 +0200 sound: Retire OSS breaks $ make defconfig && make clean (just make clean in an already clean tree seems to work). We've taken the sound tree out of d

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Runtime disable for eDP DRRS

2017-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Runtime disable for eDP DRRS URL : https://patchwork.freedesktop.org/series/32887/ State : success == Summary == Series 32887v1 series starting with [1/2] drm/i915: Runtime disable for eDP DRRS https://patchwork.freedesktop.org/

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-10-31 Thread Ingo Molnar
* Hans de Goede wrote: > intel_uncore_forcewake_reset() does forcewake puts and gets as such > we need to make sure that no-one tries to access the PUNIT->PMIC bus > (on systems where this bus is shared) while it runs, otherwise bad > things happen. > > Normally this is taken care of by the i91

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-10-31 Thread Daniel Vetter
On Tue, Oct 31, 2017 at 10:50:06AM +0100, Ingo Molnar wrote: > > * Hans de Goede wrote: > > > intel_uncore_forcewake_reset() does forcewake puts and gets as such > > we need to make sure that no-one tries to access the PUNIT->PMIC bus > > (on systems where this bus is shared) while it runs, othe

Re: [Intel-gfx] sound tree breaks make clean

2017-10-31 Thread Takashi Iwai
On Tue, 31 Oct 2017 10:41:15 +0100, Daniel Vetter wrote: > > Hi all, > > The following commit > > commit 60d4981ccf3603669c8de304619048ad5da707bd > Author: Takashi Iwai > Date: Tue Oct 24 09:15:23 2017 +0200 > > sound: Retire OSS > > > breaks > > $ make defconfig && make clean > > (j

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-10-31 Thread Hans de Goede
Hi, On 31-10-17 10:50, Ingo Molnar wrote: * Hans de Goede wrote: intel_uncore_forcewake_reset() does forcewake puts and gets as such we need to make sure that no-one tries to access the PUNIT->PMIC bus (on systems where this bus is shared) while it runs, otherwise bad things happen. Normall

Re: [Intel-gfx] [PATCH v3 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-10-31 Thread Daniel Vetter
On Mon, Oct 30, 2017 at 12:09:27PM +0100, Hans de Goede wrote: > Hi, > > On 30-10-17 10:52, Daniel Vetter wrote: > > On Mon, Oct 23, 2017 at 09:14:22AM +0200, Hans de Goede wrote: > > > Apply the "panel orientation" drm connector prop to the primary plane so > > > that fbcon and fbdev using usersp

Re: [Intel-gfx] [PATCH v3 3/7] drm: Add support for a panel-orientation connector property

2017-10-31 Thread Daniel Vetter
On Mon, Oct 30, 2017 at 11:57:10AM +0100, Hans de Goede wrote: > Hi, > > On 30-10-17 10:43, Daniel Vetter wrote: > > On Mon, Oct 23, 2017 at 09:14:21AM +0200, Hans de Goede wrote: > > > On some devices the LCD panel is mounted in the casing in such a way that > > > the up/top side of the panel doe

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Add support for reset engine using GuC commands

2017-10-31 Thread Chris Wilson
Quoting Michel Thierry (2017-10-31 04:38:30) > On 30/10/17 14:09, Chris Wilson wrote: > > Quoting Michel Thierry (2017-10-30 18:56:15) > >> This patch adds per engine reset and recovery (TDR) support when GuC is > >> used to submit workloads to GPU. > >> > >> In the case of i915 directly submission

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for GuC based reset engine

2017-10-31 Thread Chris Wilson
Quoting Patchwork (2017-10-30 23:20:13) > For more details see: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6267/shards.html https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6267/shard-kbl1/igt@prime_b...@wait-hang-render.html is suspicious. -Chris _

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

2017-10-31 Thread Daniel Vetter
On Mon, Oct 30, 2017 at 06:01:12PM +0530, PrasannaKumar Muralidharan wrote: > Hi Daniel, > > On 30 October 2017 at 15:40, Daniel Vetter wrote: > > On Wed, Oct 25, 2017 at 08:44:45PM +0530, PrasannaKumar Muralidharan wrote: > >> Hi All, > >> > >> On 24 October 2017 at 22:18, PrasannaKumar Muralidh

[Intel-gfx] [PATCH 1/2] drm/i915: Reject unknown syncobj flags

2017-10-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have to reject unknown flags for uAPI considerations, and also because the curent implementation limits their i915 storage space to two bits. v2: (Chris Wilson) * Fix fail in ABI check. * Added unknown flags and BUILD_BUG_ON. v3: * Use ARCH_KMALLOC_MINALIGN instead of

[Intel-gfx] [PATCH 2/2] drm/i915: Warn in debug builds of incorrect usages of ptr_pack_bits

2017-10-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin GEM_BUG_ON if the packed bits do not fit into the specified width. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_utils.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_u

Re: [Intel-gfx] [PATCH v3 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-10-31 Thread Hans de Goede
Hi, On 31-10-17 11:14, Daniel Vetter wrote: On Mon, Oct 30, 2017 at 12:09:27PM +0100, Hans de Goede wrote: Hi, On 30-10-17 10:52, Daniel Vetter wrote: On Mon, Oct 23, 2017 at 09:14:22AM +0200, Hans de Goede wrote: Apply the "panel orientation" drm connector prop to the primary plane so that

Re: [Intel-gfx] [PATCH v2 08/15] drm/i915: Use drm_fb_helper_output_poll_changed()

2017-10-31 Thread Daniel Vetter
On Mon, Oct 30, 2017 at 04:39:44PM +0100, Noralf Trønnes wrote: > This driver can use drm_fb_helper_output_poll_changed() as its > .output_poll_changed callback. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/i915/intel_dis

Re: [Intel-gfx] [PATCH v2 07/15] drm/gma500: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-31 Thread Daniel Vetter
On Mon, Oct 30, 2017 at 04:39:43PM +0100, Noralf Trønnes wrote: > This driver can use drm_fb_helper_lastclose() as its .lastclose callback. > It can also use drm_fb_helper_output_poll_changed() as its > .output_poll_changed callback. > > Cc: Patrik Jakobsson > Signed-off-by: Noralf Trønnes Acke

Re: [Intel-gfx] [PATCH v2 06/15] drm/exynos: Use drm_fb_helper_lastclose() and _poll_changed()

2017-10-31 Thread Daniel Vetter
On Mon, Oct 30, 2017 at 04:39:42PM +0100, Noralf Trønnes wrote: > This driver can use drm_fb_helper_lastclose() as its .lastclose callback. > It can also use drm_fb_helper_output_poll_changed() as its > .output_poll_changed callback. > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > C

Re: [Intel-gfx] [PATCH v2 15/15] staging: vboxvideo: Use drm_fb_helper_lastclose()

2017-10-31 Thread Daniel Vetter
On Mon, Oct 30, 2017 at 04:39:51PM +0100, Noralf Trønnes wrote: > This driver can use drm_fb_helper_lastclose() as its .lastclose callback. > > Cc: Hans de Goede > Signed-off-by: Noralf Trønnes > Reviewed-by: Hans de Goede > --- > drivers/staging/vboxvideo/vbox_drv.c | 2 +- > drivers/stagin

[Intel-gfx] ✗ Fi.CI.BAT: warning for tests/kms_frontbuffer_tracking: Idleness DRRS coverage

2017-10-31 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: Idleness DRRS coverage URL : https://patchwork.freedesktop.org/series/32888/ State : warning == Summary == IGT patchset tested on top of latest successful build 7aac0e88606ce453b111ce80419dc58519db05ad assembler: Fix bashism in run-t

[Intel-gfx] [resend] drm/i915: Check incoming alignment for unfenced buffers (on i915gm)

2017-10-31 Thread Chris Wilson
In case the object has changed tiling between calls to execbuf, we need to check if the existing offset inside the GTT matches the new tiling constraint. We even need to do this for "unfenced" tiled objects, where the 3D commands use an implied fence and so the object still needs to match the physi

Re: [Intel-gfx] [PATCH v3 4/7] drm/fb-helper: Apply panel orientation connector prop to the primary plane

2017-10-31 Thread Daniel Vetter
On Tue, Oct 31, 2017 at 11:24:14AM +0100, Hans de Goede wrote: > Hi, > > On 31-10-17 11:14, Daniel Vetter wrote: > > On Mon, Oct 30, 2017 at 12:09:27PM +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 30-10-17 10:52, Daniel Vetter wrote: > > > > On Mon, Oct 23, 2017 at 09:14:22AM +0200, Hans

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Reject unknown syncobj flags

2017-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Reject unknown syncobj flags URL : https://patchwork.freedesktop.org/series/32893/ State : success == Summary == Series 32893v1 series starting with [1/2] drm/i915: Reject unknown syncobj flags https://patchwork.freedesktop.org/

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for tests: add device information tests

2017-10-31 Thread Lionel Landwerlin
On 31/10/17 09:21, Petri Latvala wrote: On Mon, Oct 30, 2017 at 02:11:10PM +, Patchwork wrote: == Series Details == Series: tests: add device information tests URL : https://patchwork.freedesktop.org/series/32764/ State : success == Summary == Test kms_flip: Subgroup basic-flip

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Check incoming alignment for unfenced buffers (on i915gm) (rev2)

2017-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Check incoming alignment for unfenced buffers (on i915gm) (rev2) URL : https://patchwork.freedesktop.org/series/32828/ State : success == Summary == Series 32828v2 drm/i915: Check incoming alignment for unfenced buffers (on i915gm) https://patchwork.fre

[Intel-gfx] [CI 2/2] drm/i915: Print the condition causing GEM_BUG_ON

2017-10-31 Thread Mika Kuoppala
It is easier to categorize and debug bugs if the failed condition is in plain sight in the actual dmesg output. Make it so. Cc: Chris Wilson Cc: Joonas Lahtinen Signed-off-by: Mika Kuoppala Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_gem.h | 6 +- 1 file changed, 5 insertio

[Intel-gfx] [CI 1/2] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-31 Thread Mika Kuoppala
There is a possibility on gen9 hardware to miss the forcewake ack message. The recommended workaround is to use another free bit and toggle it until original bit is successfully acknowledged. Some future gen9 revs might or might not fix the underlying issue but the fallback to reserve bit dance ca

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-31 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Fallback to reserve forcewake if primary ack missing URL : https://patchwork.freedesktop.org/series/32896/ State : failure == Summary == Series 32896v1 series starting with [CI,1/2] drm/i915: Fallback to reserve forcewake i

[Intel-gfx] [PATCH] drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all

2017-10-31 Thread Chris Wilson
To acquire all modeset locks requires a ww_ctx to be allocated. As this is the legacy path and the allocation small, to reduce the changes required (and complex untested error handling) to the legacy drivers, we simply assume that the allocation succeeds. At present, it relies on the too-small-to-f

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-10-31 Thread Ingo Molnar
* Daniel Vetter wrote: > On Tue, Oct 31, 2017 at 10:50:06AM +0100, Ingo Molnar wrote: > > > > * Hans de Goede wrote: > > > > > intel_uncore_forcewake_reset() does forcewake puts and gets as such > > > we need to make sure that no-one tries to access the PUNIT->PMIC bus > > > (on systems where

[Intel-gfx] [PATCH] drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all

2017-10-31 Thread Chris Wilson
To acquire all modeset locks requires a ww_ctx to be allocated. As this is the legacy path and the allocation small, to reduce the changes required (and complex untested error handling) to the legacy drivers, we simply assume that the allocation succeeds. At present, it relies on the too-small-to-f

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Reject unknown syncobj flags

2017-10-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Reject unknown syncobj flags URL : https://patchwork.freedesktop.org/series/32893/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test drv_m

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all

2017-10-31 Thread Patchwork
== Series Details == Series: drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all URL : https://patchwork.freedesktop.org/series/32899/ State : success == Summary == Series 32899v1 drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all https://patchwork.freedesktop.org/api/1.0/

[Intel-gfx] [PATCH] drm/i915: Check that the breadcrumb wasn't disarmed automatically before parking

2017-10-31 Thread Chris Wilson
We will disarm the breadcrumb interrupt if we see a user interrupt whilst no one is waiting. This may race with the call to intel_engine_disarm_breadcrumbs() triggering an assert that we aren't trying to do the same job twice. Prevent this by checking that the irq is still armed after flushing the

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Check incoming alignment for unfenced buffers (on i915gm) (rev2)

2017-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Check incoming alignment for unfenced buffers (on i915gm) (rev2) URL : https://patchwork.freedesktop.org/series/32828/ State : warning == Summary == Test kms_flip: Subgroup vblank-vs-dpms-suspend: pass -> SKIP (shard-h

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all (rev2)

2017-10-31 Thread Patchwork
== Series Details == Series: drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all (rev2) URL : https://patchwork.freedesktop.org/series/32899/ State : failure == Summary == Series 32899v2 drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all https://patchwork.freedesktop.org/a

Re: [Intel-gfx] [CI 2/2] drm/i915: Print the condition causing GEM_BUG_ON

2017-10-31 Thread Chris Wilson
Quoting Mika Kuoppala (2017-10-31 11:22:54) > It is easier to categorize and debug bugs if the failed condition > is in plain sight in the actual dmesg output. Make it so. > > Cc: Chris Wilson > Cc: Joonas Lahtinen > Signed-off-by: Mika Kuoppala > Reviewed-by: Joonas Lahtinen > --- > drivers/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Check that the breadcrumb wasn't disarmed automatically before parking

2017-10-31 Thread Patchwork
== Series Details == Series: drm/i915: Check that the breadcrumb wasn't disarmed automatically before parking URL : https://patchwork.freedesktop.org/series/32903/ State : failure == Summary == Series 32903v1 drm/i915: Check that the breadcrumb wasn't disarmed automatically before parking ht

Re: [Intel-gfx] [PATCH] drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all

2017-10-31 Thread Chris Wilson
Quoting Chris Wilson (2017-10-31 11:55:35) > To acquire all modeset locks requires a ww_ctx to be allocated. As this > is the legacy path and the allocation small, to reduce the changes > required (and complex untested error handling) to the legacy drivers, we > simply assume that the allocation su

Re: [Intel-gfx] [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"

2017-10-31 Thread Joonas Lahtinen
On Mon, 2017-10-30 at 17:29 +, Chris Wilson wrote: > To quote kbuild/makefiles.txt: > > cc-disable-warning checks if gcc supports a given warning and returns > the commandline switch to disable it. This special function is needed, > because gcc 4.4 and later accept any unknown -Wno

Re: [Intel-gfx] [PATCH] drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all

2017-10-31 Thread Ville Syrjälä
On Tue, Oct 31, 2017 at 11:55:35AM +, Chris Wilson wrote: > To acquire all modeset locks requires a ww_ctx to be allocated. As this > is the legacy path and the allocation small, to reduce the changes > required (and complex untested error handling) to the legacy drivers, we > simply assume tha

[Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Add subtest time limit/randomize plane, pipe combinations

2017-10-31 Thread Imre Deak
Doing modeset on internal panels may have a considerable overhead due to the panel specific power sequencing delays. To avoid long test runtimes limit the runtime of each subtest. Randomize the plane/pipe combinations to preserve the test coverage on such panels at least over multiple test runs. B

[Intel-gfx] ✓ Fi.CI.BAT: success for kms_atomic_transition: Add subtest time limit/randomize plane, pipe combinations

2017-10-31 Thread Patchwork
== Series Details == Series: kms_atomic_transition: Add subtest time limit/randomize plane, pipe combinations URL : https://patchwork.freedesktop.org/series/32905/ State : success == Summary == IGT patchset tested on top of latest successful build 7aac0e88606ce453b111ce80419dc58519db05ad asse

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Save all GT WAs and apply them at a later time

2017-10-31 Thread Joonas Lahtinen
On Mon, 2017-10-30 at 13:17 -0700, Oscar Mateo wrote: > By doing this, we can dump these workarounds in debugfs for validation (which, > at the moment, we are only able to do for the contexts WAs). > > v2: > - Wrong macro used for MMIO set bit masked > - Improved naming > - Rebased > > v3:

Re: [Intel-gfx] [PATCH v2 08/15] drm/i915: Use drm_fb_helper_output_poll_changed()

2017-10-31 Thread Noralf Trønnes
Den 31.10.2017 11.27, skrev Daniel Vetter: On Mon, Oct 30, 2017 at 04:39:44PM +0100, Noralf Trønnes wrote: This driver can use drm_fb_helper_output_poll_changed() as its .output_poll_changed callback. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Noralf Trønnes ---

Re: [Intel-gfx] [PATCH v2 15/15] staging: vboxvideo: Use drm_fb_helper_lastclose()

2017-10-31 Thread Noralf Trønnes
Den 31.10.2017 11.32, skrev Daniel Vetter: On Mon, Oct 30, 2017 at 04:39:51PM +0100, Noralf Trønnes wrote: This driver can use drm_fb_helper_lastclose() as its .lastclose callback. Cc: Hans de Goede Signed-off-by: Noralf Trønnes Reviewed-by: Hans de Goede --- drivers/staging/vboxvideo/vbo

[Intel-gfx] ✓ Fi.CI.IGT: success for kms_atomic_transition: Add subtest time limit/randomize plane, pipe combinations

2017-10-31 Thread Patchwork
== Series Details == Series: kms_atomic_transition: Add subtest time limit/randomize plane, pipe combinations URL : https://patchwork.freedesktop.org/series/32905/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-A: dm

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

2017-10-31 Thread PrasannaKumar Muralidharan
Hi Daniel, On 31 October 2017 at 15:51, Daniel Vetter wrote: > > On Mon, Oct 30, 2017 at 06:01:12PM +0530, PrasannaKumar Muralidharan wrote: > > Hi Daniel, > > > > On 30 October 2017 at 15:40, Daniel Vetter wrote: > > > On Wed, Oct 25, 2017 at 08:44:45PM +0530, PrasannaKumar Muralidharan > > >

[Intel-gfx] [PATCH 1/2] drm/i915: Introduce execlist_port_* accessors

2017-10-31 Thread Mika Kuoppala
From: Mika Kuoppala Instead of trusting that first available port is at index 0, use accessor to hide this. This is a preparation for a following patches where head can be at arbitrary location in the port array. v2: improved commit message, elsp_ready readability (Chris) v3: s/execlist_port_ind

  1   2   >