[Intel-gfx] [PATCH v5] drm/i915/guc: Preemption! With GuC

2017-10-26 Thread Michał Winiarski
Pretty similar to what we have on execlists. We're reusing most of the GEM code, however, due to GuC quirks we need a couple of extra bits. Preemption is implemented as GuC action, and actions can be pretty slow. Because of that, we're using a mutex to serialize them. Since we're requesting preempt

[Intel-gfx] [PATCH] MAINTAINERS: Update gvt-linux.git new repo place

2017-10-26 Thread Zhenyu Wang
gvt-linux.git repo is moved for its new place under https://github.com/intel/gvt-linux.git Old https://github.com/01org/gvt-linux.git is set only for redirect now. Signed-off-by: Zhenyu Wang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTA

Re: [Intel-gfx] [PATCH] drm/i915: Cancel the modeset retry work during modeset cleanup

2017-10-26 Thread Maarten Lankhorst
Op 26-10-17 om 03:20 schreef Manasi Navare: > During modeset cleanup on driver unload we may have a pending > hotplug work. This needs to be cancel early during the teardown > so that it does not fire after we have freed the connector. > We do this after drm_kms_helper_poll_fini(dev) since this mig

[Intel-gfx] [PATCH igt] igt/gem_exec_latency: Wire up an interloper for preemption

2017-10-26 Thread Chris Wilson
For measuring the cost of preemption, inject a low priority spinner between the two measurements; the difference between the preemption and the normal dispatch includes both the cost of the spinner dispatch and of preempting it. Close enough for us to estimate the cost of preemption, though we don'

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Tvrtko Ursulin
On 25/10/2017 18:38, Chris Wilson wrote: > Quoting Chris Wilson (2017-10-25 16:47:13) >> Quoting Tvrtko Ursulin (2017-10-25 16:36:15) >>> From: Tvrtko Ursulin >> I've prototyped a quick demo of intel-client-top which produces output like: >> >> neverball[ 6011]: rcs0: 41.01% bcs0: 0.0

[Intel-gfx] ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev2)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev2) URL : https://patchwork.freedesktop.org/series/32654/ State : warning == Summary == Series 32654v2 Preemption with GuC, fourth try https://patchwork.freedesktop.org/api/1.0/series/32654/revisions/2/mbox/ Test drv_module_reloa

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-10-26 08:34:24) > > On 25/10/2017 18:38, Chris Wilson wrote: > > Quoting Chris Wilson (2017-10-25 16:47:13) > >> Quoting Tvrtko Ursulin (2017-10-25 16:36:15) > >>> From: Tvrtko Ursulin > > >> I've prototyped a quick demo of intel-client-top which produces output > >

Re: [Intel-gfx] [PATCH 1/2] drm/dp: Bit definition for D3 power state that keeps AUX fully powered

2017-10-26 Thread Jani Nikula
On Thu, 10 Aug 2017, Dhinakaran Pandiyan wrote: > DPCD 600h - SET_POWER & SET_DP_PWR_VOLTAGE defines power state > > 101 = Set Main-Link for local Sink device and all downstream Sink > devices to D3 (power-down mode), keep AUX block fully powered, ready to > reply within a Response Timeout period

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Hide dangerous tests

2017-10-26 Thread Jani Nikula
On Wed, 25 Oct 2017, Chris Wilson wrote: > Some tests are designed to exercise the limits of the HW and may trigger > unintended side-effects making the machine unusable. This should not be > executed by default, but are still useful for early platform validation. > > References: https://bugs.free

[Intel-gfx] ✗ Fi.CI.BAT: warning for MAINTAINERS: Update gvt-linux.git new repo place

2017-10-26 Thread Patchwork
== Series Details == Series: MAINTAINERS: Update gvt-linux.git new repo place URL : https://patchwork.freedesktop.org/series/32678/ State : warning == Summary == Series 32678v1 MAINTAINERS: Update gvt-linux.git new repo place https://patchwork.freedesktop.org/api/1.0/series/32678/revisions/1/m

[Intel-gfx] ✗ Fi.CI.BAT: warning for igt/gem_exec_latency: Wire up an interloper for preemption

2017-10-26 Thread Patchwork
== Series Details == Series: igt/gem_exec_latency: Wire up an interloper for preemption URL : https://patchwork.freedesktop.org/series/32679/ State : warning == Summary == IGT patchset tested on top of latest successful build 12ee485a1e23bd49b754751fa82859012f751a1a igt/drv_hangman: Skip alias

Re: [Intel-gfx] [PATCH] drm/i915: set minimum CD clock to twice the BCLK.

2017-10-26 Thread Jani Nikula
On Wed, 25 Oct 2017, Dhinakaran Pandiyan wrote: > On Wednesday, October 25, 2017 3:02:12 PM PDT abhay.ku...@intel.com wrote: >> From: Abhay Kumar >> >> In glk when device boots with only 1366x768 panel, HDA codec doesn't comeup. >> This result in no audio forever as cdclk is < 96Mhz. Forever...

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/gem_exec_latency: Wire up an interloper for preemption

2017-10-26 Thread Patchwork
== Series Details == Series: igt/gem_exec_latency: Wire up an interloper for preemption URL : https://patchwork.freedesktop.org/series/32679/ State : success == Summary == Test drv_suspend: Subgroup fence-restore-untiled-hibernate: dmesg-fail -> FAIL (shard-hsw) k

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Lionel Landwerlin
On 26/10/17 08:34, Tvrtko Ursulin wrote: On 25/10/2017 18:38, Chris Wilson wrote: Quoting Chris Wilson (2017-10-25 16:47:13) Quoting Tvrtko Ursulin (2017-10-25 16:36:15) From: Tvrtko Ursulin I've prototyped a quick demo of intel-client-top which produces output like: neverball[ 6011]

Re: [Intel-gfx] [PATCH i-g-t v3] lib: Move __gem_context_create to common ioctl wrapper library.

2017-10-26 Thread Michał Winiarski
On Wed, Oct 25, 2017 at 05:28:39PM -0700, Antonio Argenziano wrote: > This patch adds a context creation ioctl wrapper that returns the error > for the caller to consume. Multiple tests that implemented this already, > have been changed to use the new library function. > > v2: > - Add gem_re

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Save PM interrupt register offsets in device info

2017-10-26 Thread Tvrtko Ursulin
On 25/10/2017 08:45, Jani Nikula wrote: On Tue, 24 Oct 2017, Tvrtko Ursulin wrote: On 24/10/17 18:48, Jani Nikula wrote: On Tue, 24 Oct 2017, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-10-24 11:41:13) diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/in

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-10-26 10:50:57) > On 26/10/17 08:34, Tvrtko Ursulin wrote: > > On 25/10/2017 18:38, Chris Wilson wrote: > >> Quoting Chris Wilson (2017-10-25 16:47:13) > >>> Quoting Tvrtko Ursulin (2017-10-25 16:36:15) > From: Tvrtko Ursulin > >>> I've prototyped a quick demo

Re: [Intel-gfx] [PATCH i-g-t v3] lib: Move __gem_context_create to common ioctl wrapper library.

2017-10-26 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-26 11:05:14) > On Wed, Oct 25, 2017 at 05:28:39PM -0700, Antonio Argenziano wrote: > > This patch adds a context creation ioctl wrapper that returns the error > > for the caller to consume. Multiple tests that implemented this already, > > have been changed to use

[Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-10-26 Thread Chris Wilson
It has been many years since the last confirmed sighting (and fix) of an RC6 related bug (usually a system hang). Remove the parameter to stop users from setting dangerous values, as they often set it during triage and end up disabling the entire runtime pm instead (the option is not a fine scalpel

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_latency: Wire up an interloper for preemption

2017-10-26 Thread Michał Winiarski
On Thu, Oct 26, 2017 at 08:31:27AM +0100, Chris Wilson wrote: > For measuring the cost of preemption, inject a low priority spinner > between the two measurements; the difference between the preemption and > the normal dispatch includes both the cost of the spinner dispatch and > of preempting it.

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_eio: Skip in-flight-suspend on snb

2017-10-26 Thread Lofstedt, Marta
Since the discussion on this died and I believe that everyone are scared that the dodge suggestion would require someone to do some work. I could Ack the patch if: + igt_skip_on_f(IS_SANDYBRIDGE(intel_get_drm_devid(fd)), + "random incompletes in CI with this test\n"); +

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove unsafe i915.enable_rc6 (rev3)

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Remove unsafe i915.enable_rc6 (rev3) URL : https://patchwork.freedesktop.org/series/21884/ State : failure == Summary == Series 21884v3 drm/i915: Remove unsafe i915.enable_rc6 https://patchwork.freedesktop.org/api/1.0/series/21884/revisions/3/mbox/ Test

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_latency: Wire up an interloper for preemption

2017-10-26 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-26 11:52:31) > On Thu, Oct 26, 2017 at 08:31:27AM +0100, Chris Wilson wrote: > > For measuring the cost of preemption, inject a low priority spinner > > between the two measurements; the difference between the preemption and > > the normal dispatch includes both th

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_latency: Wire up an interloper for preemption

2017-10-26 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-26 11:52:31) > On Thu, Oct 26, 2017 at 08:31:27AM +0100, Chris Wilson wrote: > > For measuring the cost of preemption, inject a low priority spinner > > between the two measurements; the difference between the preemption and > > the normal dispatch includes both th

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_eio: Skip in-flight-suspend on snb

2017-10-26 Thread Lofstedt, Marta
> -Original Message- > From: Lofstedt, Marta > Sent: Thursday, October 26, 2017 1:57 PM > To: 'Martin Peres' ; Joonas Lahtinen > ; Daniel Vetter ; > Intel Graphics Development ; Latvala, Petri > > Cc: Chris Wilson > Subject: RE: [PATCH i-g-t] tests/gem_eio: Skip in-flight-suspend on snb

[Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Remove support for legacy CRC api.

2017-10-26 Thread Maarten Lankhorst
In kernel v4.10 the legacy crc api has been replaced by a generic drm crc API. While at it, fix igt_require_pipe_crc, the file cannot be opened any more when the crtc is not active after kernel commit 8038e09be5a3 ("drm/crc: Only open CRC on atomic drivers when the CRTC is active."). Statting the f

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_latency: Wire up an interloper for preemption

2017-10-26 Thread Michał Winiarski
On Thu, Oct 26, 2017 at 12:04:11PM +0100, Chris Wilson wrote: > Quoting Michał Winiarski (2017-10-26 11:52:31) > > On Thu, Oct 26, 2017 at 08:31:27AM +0100, Chris Wilson wrote: > > > For measuring the cost of preemption, inject a low priority spinner > > > between the two measurements; the differen

[Intel-gfx] [PATCH] drm/i915: Include RING_MODE when dumping the engine state

2017-10-26 Thread Chris Wilson
Knowing the RING_MODE flags is useful for checking the state of the engine, such as whether the CS is idle after trying to stop the engines before reset. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/intel_engine_cs.c | 5 + 1 file changed, 5 insertions(+) diff --g

[Intel-gfx] [PATCH] drm/i915: Abandon the reset if we fail to stop the engines

2017-10-26 Thread Chris Wilson
Some machines, *cough* snb *cough*, fail catastrophically if asked to reset the GPU under certain conditions. The initial guess is that this is when the rings are still busy at the time of the reset request (because that's a pattern we've seen elsewhere, hence why we do try gen3_stop_engines() befo

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Include RING_MODE when dumping the engine state

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Include RING_MODE when dumping the engine state URL : https://patchwork.freedesktop.org/series/32691/ State : success == Summary == Series 32691v1 drm/i915: Include RING_MODE when dumping the engine state https://patchwork.freedesktop.org/api/1.0/series/3

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Abandon the reset if we fail to stop the engines

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Abandon the reset if we fail to stop the engines URL : https://patchwork.freedesktop.org/series/32692/ State : failure == Summary == Series 32692v1 drm/i915: Abandon the reset if we fail to stop the engines https://patchwork.freedesktop.org/api/1.0/series

[Intel-gfx] ✗ Fi.CI.BAT: failure for igt/gem_exec_latency: Wire up an interloper for preemption

2017-10-26 Thread Patchwork
== Series Details == Series: igt/gem_exec_latency: Wire up an interloper for preemption URL : https://patchwork.freedesktop.org/series/32679/ State : failure == Summary == Series 32679 revision 1 was fully merged or fully failed: no git log == Logs == For more details see: https://intel-gfx-

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Abandon the reset if we fail to stop the engines

2017-10-26 Thread Chris Wilson
Quoting Patchwork (2017-10-26 13:33:06) > == Series Details == > > Series: drm/i915: Abandon the reset if we fail to stop the engines > URL : https://patchwork.freedesktop.org/series/32692/ > State : failure > > == Summary == > > Series 32692v1 drm/i915: Abandon the reset if we fail to stop th

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Save PM interrupt register offsets in device info

2017-10-26 Thread Jani Nikula
On Thu, 26 Oct 2017, Tvrtko Ursulin wrote: > On 25/10/2017 08:45, Jani Nikula wrote: >> On Tue, 24 Oct 2017, Tvrtko Ursulin wrote: >>> On 24/10/17 18:48, Jani Nikula wrote: On Tue, 24 Oct 2017, Chris Wilson wrote: > Quoting Sagar Arun Kamble (2017-10-24 11:41:13) >> diff --git a/dri

Re: [Intel-gfx] [PATCH v3 05/12] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michal Wajdeczko
On Wed, 25 Oct 2017 22:00:13 +0200, Michał Winiarski wrote: From: Dave Gordon This second client is created with priority KMD_HIGH, and marked as preemptive. This will allow us to request preemption using GuC actions. v2: Extract clients creation into a helper, debugfs fixups. (Michał)

[Intel-gfx] ✗ Fi.CI.BAT: failure for lib/igt_debugfs: Remove support for legacy CRC api.

2017-10-26 Thread Patchwork
== Series Details == Series: lib/igt_debugfs: Remove support for legacy CRC api. URL : https://patchwork.freedesktop.org/series/32689/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_latency: Wire up an

Re: [Intel-gfx] [PATCH] drm/i915: Abandon the reset if we fail to stop the engines

2017-10-26 Thread Ville Syrjälä
On Thu, Oct 26, 2017 at 01:12:12PM +0100, Chris Wilson wrote: > Some machines, *cough* snb *cough*, fail catastrophically if asked to > reset the GPU under certain conditions. Did we try skipping the gen6_rps_disable() already? > The initial guess is that this > is when the rings are still busy a

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Tvrtko Ursulin
On 26/10/2017 10:50, Lionel Landwerlin wrote: On 26/10/17 08:34, Tvrtko Ursulin wrote: On 25/10/2017 18:38, Chris Wilson wrote: Quoting Chris Wilson (2017-10-25 16:47:13) Quoting Tvrtko Ursulin (2017-10-25 16:36:15) From: Tvrtko Ursulin I've prototyped a quick demo of intel-client-top which

[Intel-gfx] [PATCH 1/2] drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects)

2017-10-26 Thread Chris Wilson
Kasan spotted [IGT] gem_tiled_pread_pwrite: exiting, ret=0 == BUG: KASAN: use-after-free in __i915_gem_object_reset_page_iter+0x15c/0x170 [i915] Read of size 8 at addr 8801359da310 by task kworker/3:2/182 CPU

[Intel-gfx] [PATCH 2/2] drm/i915: Hold rcu_read_lock when iterating over the radixtree (vma idr)

2017-10-26 Thread Chris Wilson
Kasan spotted [IGT] gem_tiled_pread_pwrite: exiting, ret=0 == BUG: KASAN: use-after-free in __i915_gem_object_reset_page_iter+0x15c/0x170 [i915] Read of size 8 at addr 8801359da310 by task kworker/3:2/182 CPU

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-10-26 14:00:28) > > On 26/10/2017 10:50, Lionel Landwerlin wrote: > > On 26/10/17 08:34, Tvrtko Ursulin wrote: > >> On 25/10/2017 18:38, Chris Wilson wrote: > >>> Quoting Chris Wilson (2017-10-25 16:47:13) > Quoting Tvrtko Ursulin (2017-10-25 16:36:15) > > Fro

Re: [Intel-gfx] [PATCH] drm/i915: Abandon the reset if we fail to stop the engines

2017-10-26 Thread Chris Wilson
Quoting Ville Syrjälä (2017-10-26 13:59:05) > On Thu, Oct 26, 2017 at 01:12:12PM +0100, Chris Wilson wrote: > > Some machines, *cough* snb *cough*, fail catastrophically if asked to > > reset the GPU under certain conditions. > > Did we try skipping the gen6_rps_disable() already? I had thought w

[Intel-gfx] [PATCH v4] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michał Winiarski
From: Dave Gordon This second client is created with priority KMD_HIGH, and marked as preemptive. This will allow us to request preemption using GuC actions. v2: Extract clients creation into a helper, debugfs fixups. (Michał) Recreate doorbell on init. (Daniele) Move clients into an array. v3:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects)

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects) URL : https://patchwork.freedesktop.org/series/32693/ State : success == Summary == Series 32693v1 series starting with [1/2] drm/i915: Hold rcu_read_lock when ite

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Save PM interrupt register offsets in device info

2017-10-26 Thread Jani Nikula
On Thu, 26 Oct 2017, Jani Nikula wrote: > On Thu, 26 Oct 2017, Tvrtko Ursulin wrote: >> On 25/10/2017 08:45, Jani Nikula wrote: >>> On Tue, 24 Oct 2017, Tvrtko Ursulin wrote: On 24/10/17 18:48, Jani Nikula wrote: > On Tue, 24 Oct 2017, Chris Wilson wrote: >> Quoting Sagar Arun Kamb

Re: [Intel-gfx] [PATCH] drm/i915: Abandon the reset if we fail to stop the engines

2017-10-26 Thread Ville Syrjälä
On Thu, Oct 26, 2017 at 02:11:22PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2017-10-26 13:59:05) > > On Thu, Oct 26, 2017 at 01:12:12PM +0100, Chris Wilson wrote: > > > Some machines, *cough* snb *cough*, fail catastrophically if asked to > > > reset the GPU under certain conditions. > >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled

2017-10-26 Thread Paulo Zanoni
Em Qua, 2017-10-25 às 17:37 -0700, Dhinakaran Pandiyan escreveu: > The frontbuffer_tracking PSR tests fail if PSR cannot be activated > when > there is sink support. But, there are several other requirements > related to > mode timings that have to be satisfied before PSR can be enabled. No > reaso

[Intel-gfx] [PATCH v5] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michał Winiarski
From: Dave Gordon This second client is created with priority KMD_HIGH, and marked as preemptive. This will allow us to request preemption using GuC actions. v2: Extract clients creation into a helper, debugfs fixups. (Michał) Recreate doorbell on init. (Daniele) Move clients into an array. v3:

[Intel-gfx] [PATCH v6] drm/i915/guc: Preemption! With GuC

2017-10-26 Thread Michał Winiarski
Pretty similar to what we have on execlists. We're reusing most of the GEM code, however, due to GuC quirks we need a couple of extra bits. Preemption is implemented as GuC action, and actions can be pretty slow. Because of that, we're using a mutex to serialize them. Since we're requesting preempt

[Intel-gfx] ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev3)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev3) URL : https://patchwork.freedesktop.org/series/32654/ State : warning == Summary == Series 32654v3 Preemption with GuC, fourth try https://patchwork.freedesktop.org/api/1.0/series/32654/revisions/3/mbox/ Test chamelium:

Re: [Intel-gfx] [PATCH v5] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michal Wajdeczko
On Thu, 26 Oct 2017 15:32:31 +0200, Michał Winiarski wrote: From: Dave Gordon This second client is created with priority KMD_HIGH, and marked as preemptive. This will allow us to request preemption using GuC actions. v2: Extract clients creation into a helper, debugfs fixups. (Michał)

Re: [Intel-gfx] [PATCH] drm/i915: Include RING_MODE when dumping the engine state

2017-10-26 Thread Mika Kuoppala
Chris Wilson writes: > Knowing the RING_MODE flags is useful for checking the state of the > engine, such as whether the CS is idle after trying to stop the engines > before reset. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_engine_cs.c | 5 + > 1

[Intel-gfx] ✓ Fi.CI.BAT: success for Preemption with GuC, fourth try (rev5)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev5) URL : https://patchwork.freedesktop.org/series/32654/ State : success == Summary == Series 32654v5 Preemption with GuC, fourth try https://patchwork.freedesktop.org/api/1.0/series/32654/revisions/5/mbox/ Test kms_cursor_legac

[Intel-gfx] [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-26 Thread Mika Kuoppala
There is a possibility on gen9 hardware to miss the forcewake ack message. The recommended workaround is to use another free bit and toggle it until original bit is successfully acknowledged. The workaround is a bit misleadingly named as WaRsForcewakeAddDelayForAck. The reason for naming is most l

[Intel-gfx] [PATCH v6] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michał Winiarski
From: Dave Gordon This second client is created with priority KMD_HIGH, and marked as preemptive. This will allow us to request preemption using GuC actions. v2: Extract clients creation into a helper, debugfs fixups. (Michał) Recreate doorbell on init. (Daniele) Move clients into an array. v3:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Fallback to reserve forcewake if primary ack missing URL : https://patchwork.freedesktop.org/series/32694/ State : failure == Summary == Series 32694v1 drm/i915: Fallback to reserve forcewake if primary ack missing https://patchwork.freedesktop.org/api/1.

[Intel-gfx] [PATCH 1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-26 Thread Jani Nikula
Per my reading of the eDP spec, DP_DPCD_DISPLAY_CONTROL_CAPABLE bit in DP_EDP_CONFIGURATION_CAP should be set if the eDP display control registers starting at offset DP_EDP_DPCD_REV are "enabled". Currently we check the bit before reading the registers, and DP_EDP_DPCD_REV is the only way to detect

[Intel-gfx] [PATCH 2/2] drm/i915/edp: clean up code and comments around eDP DPCD read

2017-10-26 Thread Jani Nikula
Some minor drive-by cleanups. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 158438bb0389..73b1ed8cff6b 100644 --- a/drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix SSEU Device Status.

2017-10-26 Thread Lionel Landwerlin
Since I've been looking at EU_DISABLE* in intel_device_info.c, your patch caught my eye :) Reading the documentation I couldn't find anything wrong. Reviewed-by: Lionel Landwerlin On 26/10/17 01:15, Rodrigo Vivi wrote: CNL adds an extra register for slice/subslice information. Although no SKU

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-10-26 Thread Joonas Lahtinen
On Thu, 2017-10-26 at 11:32 +0100, Chris Wilson wrote: > It has been many years since the last confirmed sighting (and fix) of an > RC6 related bug (usually a system hang). Remove the parameter to stop > users from setting dangerous values, as they often set it during triage > and end up disabling

Re: [Intel-gfx] [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-26 Thread Chris Wilson
Quoting Mika Kuoppala (2017-10-26 15:01:44) > There is a possibility on gen9 hardware to miss the forcewake ack > message. The recommended workaround is to use another free > bit and toggle it until original bit is successfully acknowledged. > > The workaround is a bit misleadingly named as WaRsFo

Re: [Intel-gfx] [PATCH] drm/i915: Add -Wall -Wextra to our build, set warnings to full

2017-10-26 Thread Jani Nikula
On Tue, 24 Oct 2017, Chris Wilson wrote: > Recently W=1 on gcc-7.2 (-Wunused-const-variable) caught a regression > that had been lurking for 6 months, so lets try enabling the full set of > warnings for CI builds. This means more patches will be rejected early > that contain trivial and sometimes

[Intel-gfx] ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev6)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev6) URL : https://patchwork.freedesktop.org/series/32654/ State : warning == Summary == Series 32654v6 Preemption with GuC, fourth try https://patchwork.freedesktop.org/api/1.0/series/32654/revisions/6/mbox/ Test kms_pipe_crc_bas

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Include RING_MODE when dumping the engine state

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Include RING_MODE when dumping the engine state URL : https://patchwork.freedesktop.org/series/32691/ State : success == Summary == Test kms_plane: Subgroup plane-panning-bottom-right-suspend-pipe-A-planes: skip -> PASS

Re: [Intel-gfx] [PATCH 1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-26 Thread Ville Syrjälä
On Thu, Oct 26, 2017 at 05:29:31PM +0300, Jani Nikula wrote: > Per my reading of the eDP spec, DP_DPCD_DISPLAY_CONTROL_CAPABLE bit in > DP_EDP_CONFIGURATION_CAP should be set if the eDP display control > registers starting at offset DP_EDP_DPCD_REV are "enabled". Currently we > check the bit before

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/igt_debugfs: Remove support for legacy CRC api.

2017-10-26 Thread Patchwork
== Series Details == Series: lib/igt_debugfs: Remove support for legacy CRC api. URL : https://patchwork.freedesktop.org/series/32689/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-oldfb-with-reset-render-B: dmesg-warn -> PASS (shard-

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects)

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects) URL : https://patchwork.freedesktop.org/series/32693/ State : warning == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-C:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/edp: read edp display control registers unconditionally URL : https://patchwork.freedesktop.org/series/32695/ State : success == Summary == Series 32695v1 series starting with [1/2] drm/i915/edp: read edp display control regist

[Intel-gfx] [PATCH 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-26 Thread Ville Syrjala
From: Ville Syrjälä Starting from version 204 VBT can specify the max TMDS clock we are allowed to use with HDMI ports. Parse that information and take it into account when filtering modes and computing a crtc state. Also take the opportunity to sort the platform check if ladder from new to old.

[Intel-gfx] [PATCH 1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible()

2017-10-26 Thread Ville Syrjala
From: Ville Syrjälä Move the crtc state related 12bpc checks into hdmi_12bpc_possible() since that one already examines other parts of the crtc state. Note that we can drop the !force_dvi check since crtc_state->has_hdmi_sink already accounts for that. Signed-off-by: Ville Syrjälä --- drivers

[Intel-gfx] ✓ Fi.CI.IGT: success for Preemption with GuC, fourth try (rev5)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev5) URL : https://patchwork.freedesktop.org/series/32654/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-oldfb-with-reset-render-A: pass -> DMESG-WARN (shard-hsw) fdo#1022

[Intel-gfx] [PATCH] drm/i915: Remove obsolete ringbuffer emission for gen8+

2017-10-26 Thread Chris Wilson
submission. We have made a few improvements to lowlevel execlists throughput, and ringbuffer currently panics on boot! (bdw i7-5557u, 20171026): ring execlists exec continuous nops on all rings: n/a1.921us exec sequential nops on each

Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete ringbuffer emission for gen8+

2017-10-26 Thread Chris Wilson
Quoting Chris Wilson (2017-10-26 16:31:33) > Since removing the module parameter to force selection of ringbuffer > emission for gen8, the code is defunct. Remove it. Ah, there's meant to a patch to remove the modparam first. It's not required to test this patch, just equally pointless to keep i91

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible()

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible() URL : https://patchwork.freedesktop.org/series/32698/ State : success == Summary == Series 32698v1 series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possibl

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-26 Thread Chris Wilson
Quoting Ville Syrjala (2017-10-26 16:14:05) > From: Ville Syrjälä > > Starting from version 204 VBT can specify the max TMDS clock we are > allowed to use with HDMI ports. Parse that information and take it > into account when filtering modes and computing a crtc state. > > + if (bdb_vers

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible()

2017-10-26 Thread Chris Wilson
Quoting Ville Syrjala (2017-10-26 16:14:04) > From: Ville Syrjälä > > Move the crtc state related 12bpc checks into hdmi_12bpc_possible() > since that one already examines other parts of the crtc state. > > Note that we can drop the !force_dvi check since > crtc_state->has_hdmi_sink already acco

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-26 Thread Ville Syrjälä
On Thu, Oct 26, 2017 at 04:44:39PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2017-10-26 16:14:05) > > From: Ville Syrjälä > > > > Starting from version 204 VBT can specify the max TMDS clock we are > > allowed to use with HDMI ports. Parse that information and take it > > into account w

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove obsolete ringbuffer emission for gen8+

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Remove obsolete ringbuffer emission for gen8+ URL : https://patchwork.freedesktop.org/series/32701/ State : failure == Summary == Series 32701v1 drm/i915: Remove obsolete ringbuffer emission for gen8+ https://patchwork.freedesktop.org/api/1.0/series/32701

[Intel-gfx] ✓ Fi.CI.IGT: success for Preemption with GuC, fourth try (rev6)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev6) URL : https://patchwork.freedesktop.org/series/32654/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-A: pass -> DMESG-WARN (shard-hsw) fdo#1022

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-26 Thread Chris Wilson
Quoting Ville Syrjälä (2017-10-26 16:51:23) > On Thu, Oct 26, 2017 at 04:44:39PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2017-10-26 16:14:05) > > > From: Ville Syrjälä > > > > > > Starting from version 204 VBT can specify the max TMDS clock we are > > > allowed to use with HDMI port

Re: [Intel-gfx] [PATCH] drm/i915: Cancel the modeset retry work during modeset cleanup

2017-10-26 Thread Manasi Navare
On Thu, Oct 26, 2017 at 07:33:44AM +0100, Chris Wilson wrote: > Quoting Manasi Navare (2017-10-26 02:20:04) > > During modeset cleanup on driver unload we may have a pending > > hotplug work. This needs to be cancel early during the teardown > > so that it does not fire after we have freed the conn

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible()

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible() URL : https://patchwork.freedesktop.org/series/32698/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-C:

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Make GuC log part of the uC error state

2017-10-26 Thread Michal Wajdeczko
On Wed, 25 Oct 2017 13:11:25 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2017-10-25 11:41:12) We keep details of GuC and HuC in separate error state struct. Make GuC log part of it to group all related data together. The only significant change would appear to placement in error-s

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Lionel Landwerlin
On 26/10/17 14:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-10-26 14:00:28) On 26/10/2017 10:50, Lionel Landwerlin wrote: On 26/10/17 08:34, Tvrtko Ursulin wrote: On 25/10/2017 18:38, Chris Wilson wrote: Quoting Chris Wilson (2017-10-25 16:47:13) Quoting Tvrtko Ursulin (2017-10-25 16

[Intel-gfx] [PATCH i-g-t v4] lib: Move __gem_context_create to common ioctl wrapper library.

2017-10-26 Thread Antonio Argenziano
This patch adds a context creation ioctl wrapper that returns the error for the caller to consume. Multiple tests that implemented this already, have been changed to use the new library function. v2: - Add gem_require_contexts() to check for contexts support (Chris) v3: - Add gem_

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Remove support for legacy CRC api.

2017-10-26 Thread James Ausmus
On Thu, Oct 26, 2017 at 01:38:51PM +0200, Maarten Lankhorst wrote: > In kernel v4.10 the legacy crc api has been replaced by a generic > drm crc API. While at it, fix igt_require_pipe_crc, the file cannot be > opened any more when the crtc is not active after kernel commit 8038e09be5a3 > ("drm/crc:

[Intel-gfx] [PATCH v6 1/3] drm/i915: Add Guc/HuC firmware details to error state

2017-10-26 Thread Michal Wajdeczko
Include GuC and HuC firmware details in captured error state to provide additional debug information. To reuse existing uc firmware pretty printer, introduce new drm-printer variant that works with our i915_error_state_buf output. Also update uc firmware pretty printer to accept const input. v2: d

[Intel-gfx] [PATCH v6 3/3] drm/i915: Handle error-state modparams in dedicated functions

2017-10-26 Thread Michal Wajdeczko
Capturing and cleanup and modparams in error state requires some macro tricks. Move that code into separated functions for easier maintenance. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gpu_error.c | 26 +- 1 file changed, 17 insertion

[Intel-gfx] [PATCH v6 2/3] drm/i915: Make GuC log part of the uC error state

2017-10-26 Thread Michal Wajdeczko
We keep details of GuC and HuC in separate error state struct. Make GuC log part of it to group all related data together. Since we are printing uC details at the end, with this change GuC log will be moved there too. v2: comment on new placement of the log (Chris) Signed-off-by: Michal Wajdeczko

[Intel-gfx] ✗ Fi.CI.BAT: failure for Lib: Move __gem_context_create to common ioctl wrapper library. (rev3)

2017-10-26 Thread Patchwork
== Series Details == Series: Lib: Move __gem_context_create to common ioctl wrapper library. (rev3) URL : https://patchwork.freedesktop.org/series/31775/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_la

Re: [Intel-gfx] [PATCH 1/2] drm/dp: Bit definition for D3 power state that keeps AUX fully powered

2017-10-26 Thread Pandiyan, Dhinakaran
On Thu, 2017-10-26 at 10:59 +0300, Jani Nikula wrote: > On Thu, 10 Aug 2017, Dhinakaran Pandiyan wrote: > > DPCD 600h - SET_POWER & SET_DP_PWR_VOLTAGE defines power state > > > > 101 = Set Main-Link for local Sink device and all downstream Sink > > devices to D3 (power-down mode), keep AUX block

Re: [Intel-gfx] [PATCH v8 1/6] drm/i915 : Unifying seq_puts messages for feature support

2017-10-26 Thread Daniele Ceraolo Spurio
On 25/10/17 06:31, Michal Wajdeczko wrote: On Tue, 24 Oct 2017 19:21:20 +0200, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages in debugfs to the simplest one for feature support. v2: Clarifying the commit message (Anusha) v3: Re-factoring code as per review (Michal) v4

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/3] drm/i915: Add Guc/HuC firmware details to error state

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/i915: Add Guc/HuC firmware details to error state URL : https://patchwork.freedesktop.org/series/32710/ State : success == Summary == Series 32710v1 series starting with [v6,1/3] drm/i915: Add Guc/HuC firmware details to error st

[Intel-gfx] [GIT PULL] gvt fix for 4.14-rc6

2017-10-26 Thread Zhi Wang
Hi: Here are some fixes for 4.14-rc6. Zhenyu's patch fixes the per_ctx_bb check in GVT-g since the usage of per_ctx_bb in i915 has been changed recently. Another two patches from Xiong fix the GPU hang of linxu guest when it's running large workload. Thanks, Zhi. The following changes si

[Intel-gfx] ✗ Fi.CI.IGT: failure for Lib: Move __gem_context_create to common ioctl wrapper library. (rev3)

2017-10-26 Thread Patchwork
== Series Details == Series: Lib: Move __gem_context_create to common ioctl wrapper library. (rev3) URL : https://patchwork.freedesktop.org/series/31775/ State : failure == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-A: pass ->

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix SSEU Device Status.

2017-10-26 Thread Rodrigo Vivi
On Thu, Oct 26, 2017 at 02:31:16PM +, Lionel Landwerlin wrote: > Since I've been looking at EU_DISABLE* in intel_device_info.c, your patch > caught my eye :) > Reading the documentation I couldn't find anything wrong. > > Reviewed-by: Lionel Landwerlin Thanks. Merged to dinq. > > On 26/10/

Re: [Intel-gfx] [PATCH v6] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michel Thierry
On 26/10/17 07:17, Michał Winiarski wrote: @@ -763,14 +770,14 @@ static int guc_init_doorbell_hw(struct intel_guc *guc) /* Now for every client (and not only execbuf_client) make sure their * doorbells are known by the GuC */ - //for (client = client_list; client != NULL

[Intel-gfx] [PATCH v2] drm/i915/selftests: Add a GuC doorbells selftest

2017-10-26 Thread Michel Thierry
Try to create as many clients as it is currently possible (currently limited to max number of doorbells) and exercise the doorbell alloc/dealloc code. Since our usage mode require very few clients/doorbells, this code has been exercised very lightly and it's good to have a simple test for it. As

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Add a GuC doorbells selftest

2017-10-26 Thread Michel Thierry
On 26/10/17 11:51, Michel Thierry wrote: Try to create as many clients as it is currently possible (currently limited to max number of doorbells) and exercise the doorbell alloc/dealloc code. Since our usage mode require very few clients/doorbells, this code has been exercised very lightly and i

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add a GuC doorbells selftest (rev2)

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add a GuC doorbells selftest (rev2) URL : https://patchwork.freedesktop.org/series/32655/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelea

  1   2   >