== Series Details ==
Series: drm/i915: Skip waking the device to service pwrite (rev2)
URL : https://patchwork.freedesktop.org/series/29560/
State : success
== Summary ==
Series 29560v2 drm/i915: Skip waking the device to service pwrite
https://patchwork.freedesktop.org/api/1.0/series/29560/re
On Tue, 17 Oct 2017, Joonas Lahtinen wrote:
> From: Kees Cook
>
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: Daniel Vetter
> Cc: Jani Nik
On Wed, Oct 18, 2017 at 03:29:48PM -0700, Sripada, Radhakrishna wrote:
> Currently the user space does not have a way to force the bpc. The
> default bpc to be programmed is decided by the driver and is run
> against connector limitations. Creating a new property for the userspace
> to recommend a
On 18/10/2017 17:04, Sagar Arun Kamble wrote:
On 10/18/2017 6:42 PM, Tvrtko Ursulin wrote:
On 18/10/2017 07:46, Sagar Arun Kamble wrote:
GuC log runtime/relay channel data is released during i915 unregister,
So only GuC log vma needs to be released during submission_fini.
Signed-off-by: Saga
On Wed, 2017-10-18 at 23:48 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Redo some switch statements in the cdclk code to use a common
> fall through for the default case. Makes everything look a bit
> more uniform
>
> Cc: Mika Kahola
> Cc: Manasi Navare
> Cc: Rodrigo Vivi
Reviewed-b
On 18/10/2017 16:50, Sagar Arun Kamble wrote:
On 10/18/2017 6:29 PM, Tvrtko Ursulin wrote:
On 18/10/2017 07:46, Sagar Arun Kamble wrote:
Parameter guc_log_level needs to be sanitized based on GuC support and
enable_guc_loading parameter since it depends on them like
enable_guc_submission. Thi
On Wed, Oct 18, 2017 at 11:39:15PM -0200, Gabriel Krisman Bertazi wrote:
> knowing the assertion triggered on wait_until_enabled() is not that
> useful without knowing what exactly caused the failure. It might be an
> user error, like too little stolen memory by the bios, or an actual
> issue in t
On Thu, Oct 19, 2017 at 07:23:07AM +0100, Chris Wilson wrote:
> Emphasize that we want to test synchronisation using the dmabuf API
> (prime_sync_start, prime_sync_end) and so drop the manual
> synchronisation using the GEM API (gem_sync).
>
> Signed-off-by: Chris Wilson
Assuming CI approves too
== Series Details ==
Series: igt/prime_mmap_coherency: Remove manual gem_sync() calls
URL : https://patchwork.freedesktop.org/series/32272/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
d4a4fbec0c079c7bec7fa6a2c756eea02314799e igt/prime_mmap_coherency: Cal
On Thu, Oct 19, 2017 at 07:37:33AM +0100, Chris Wilson wrote:
> If the device is in runtime suspend, resuming takes time and reduces our
> powersaving. If this was for a small write into an object, that resume
> will take longer than any savings in using the indirect GGTT access to
> avoid the cpu
== Series Details ==
Series: series starting with [CI,1/4] lib: Add DROP_IDLE
URL : https://patchwork.freedesktop.org/series/32268/
State : success
== Summary ==
Test kms_flip:
Subgroup wf_vblank-vs-modeset:
dmesg-warn -> PASS (shard-hsw) fdo#102614
Subgro
== Series Details ==
Series: tests/kms_plane_lowres: Rework tests to work without fbcon. (rev3)
URL : https://patchwork.freedesktop.org/series/32016/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
d4a4fbec0c079c7bec7fa6a2c756eea02314799e igt/prime_mmap_cohe
Quoting Daniele Ceraolo Spurio (2017-10-12 23:30:41)
> The same code to create and import a vgem object is used in a couple of
> places and a couple more are coming up in the next patches so extract
> the code into a common function
>
> Signed-off-by: Daniele Ceraolo Spurio
> ---
> lib/igt_dummy
Quoting Daniele Ceraolo Spurio (2017-10-12 23:30:42)
> Using an imported vgem bo we can test reads from an object not backed
> by struct page. These reads use different paths in the kernel.
>
> While at it, extract some common code in an helper function and fix the
> src vs dst naming (they are th
== Series Details ==
Series: drm/i915: Skip waking the device to service pwrite (rev2)
URL : https://patchwork.freedesktop.org/series/29560/
State : success
== Summary ==
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252
Subgroup oa-ex
assert_rpm_wakelock_held is triggered from i915_pmic_bus_access_notifier
even though it gets unregistered on (runtime) suspend, this is caused
by a race happening under the following circumstances:
intel_runtime_pm_put does:
atomic_dec(&dev_priv->pm.wakeref_count);
pm_runtime_mark_last_bus
intel_uncore_suspend() unregisters the uncore code's PMIC bus access
notifier and gets called on both normal and runtime suspend.
intel_uncore_resume_early() re-registers the notifier, but only on
normal resume. Add a new intel_uncore_runtime_resume() function which
only re-registers the notifier
Quoting Ville: "the forcewake timer might still be active until the uncore
suspend, and having active forcewakes while we've already told the GT wake
stuff to stop acting normally doesn't seem quite right to me."
Reported-by: Ville Syrjälä
Suggested-by: Imre Deak
Signed-off-by: Hans de Goede
Re
Hi All,
Here is a resend of the first 3 of the 4 patches in my Misc. PMIC bus
access notifier fixes series. I'm leaving out the 4th patch this time,
because that includes some changes to the iosf_mbi code under arch/x86
and that has been blocking this series from getting upstream sofar.
I will se
== Series Details ==
Series: drm/i915: Misc. PMIC bus access notifier fixes
URL : https://patchwork.freedesktop.org/series/32274/
State : success
== Summary ==
Series 32274v1 drm/i915: Misc. PMIC bus access notifier fixes
https://patchwork.freedesktop.org/api/1.0/series/32274/revisions/1/mbox/
Quoting Joonas Lahtinen (2017-10-13 12:22:26)
> On Thu, 2017-10-12 at 15:29 -0700, Daniele Ceraolo Spurio wrote:
> > Respin with review fixes for meson build and gem_concurrent_all.
> > I'll send the new tests for pread/pwrite suggested by Chris as a
> > separated series as they depend on the other
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> In the future I want to allow tests to commit more properties,
> but for this to work I have to fix all properties to work better
> with atomic commit. Instead of special casing each
> property make a bitmask for all property changed fla
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_drv.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index a05ab3a1ab27..bfd743892458 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i91
Op 19-10-17 om 11:08 schreef Mika Kahola:
> On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
>> In the future I want to allow tests to commit more properties,
>> but for this to work I have to fix all properties to work better
>> with atomic commit. Instead of special casing each
>> prop
== Series Details ==
Series: hax: moar padding
URL : https://patchwork.freedesktop.org/series/32278/
State : success
== Summary ==
Series 32278v1 hax: moar padding
https://patchwork.freedesktop.org/api/1.0/series/32278/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
CI gets upset about it resulting in an incomplete, let's skip it until
that's fixed to avoid havoc in the CI farm. Of course this should/will
be reverted as soon as we have a fix (similar to how we dealt with the
snb-dies-in-blt-hangs issue).
Cc: Joonas Lahtinen
Cc: Chris Wilson
Cc: "Lofstedt, M
== Series Details ==
Series: tests/kms_plane_lowres: Rework tests to work without fbcon. (rev3)
URL : https://patchwork.freedesktop.org/series/32016/
State : success
== Summary ==
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test kms_
On Thu, Oct 19, 2017 at 11:51:51AM +0200, Daniel Vetter wrote:
> CI gets upset about it resulting in an incomplete, let's skip it until
> that's fixed to avoid havoc in the CI farm. Of course this should/will
> be reverted as soon as we have a fix (similar to how we dealt with the
> snb-dies-in-blt
On 19/10/2017 07:37, Chris Wilson wrote:
If the device is in runtime suspend, resuming takes time and reduces our
powersaving. If this was for a small write into an object, that resume
will take longer than any savings in using the indirect GGTT access to
avoid the cpu cache.
Commit talks abou
On 18/10/2017 07:46, Sagar Arun Kamble wrote:
Disabling GuC interrupts involves access to GuC IRQ control registers
hence ensure device is RPM awake.
v2: Add comment about need to synchronize flush work and log runtime
destroy
Signed-off-by: Sagar Arun Kamble
Cc: Michal Wajdeczko
Cc: Da
== Series Details ==
Series: tests/gem_eio: Skip in-flight-suspend on snb
URL : https://patchwork.freedesktop.org/series/32280/
State : failure
== Summary ==
IGT patchset tested on top of latest successful build
abc08cba366a64a07f7f4deb167ae7d6ae059958 lib: Free all internal buffers before
me
On 18/10/2017 07:46, Sagar Arun Kamble wrote:
This patch adds support to enable/disable GuC interrupts for different
features without impacting others needs. Currently GuC log capture and
CT buffer receive mechanisms use the GuC interrupts. GuC interrupts are
currently enabled and disabled in di
Quoting Tvrtko Ursulin (2017-10-19 11:02:05)
>
> On 19/10/2017 07:37, Chris Wilson wrote:
> > If the device is in runtime suspend, resuming takes time and reduces our
> > powersaving. If this was for a small write into an object, that resume
> > will take longer than any savings in using the indir
On 18/10/2017 07:47, Sagar Arun Kamble wrote:
With guc_log_unregister disabling runtime logging and interrupts there
is no need to disable interrupts during uc_fini_hw hence it is removed.
With GuC CT buffer mechanism, interrupt disabling can be added at a point
where CT mechanism ceases.
Signe
Hello,
I get these Oopses from time to time, but unfortunately(?) not often
enough to be anywhere near reproducible. But they seem to be related to
whatever activites my laptop/X-server/driver/gpu/screen is doing while
I'm not present. The oops happens when I'm away for a while. So I guess
it mi
Ah, domains.
It is a real bug, but the quickest way to paper over it is to
s/TEST_DEVICES/TEST_NONE/ (that way we still have the test in arguably a
more realistic mode), we have other reset tests that also trigger
the death. The bug tells us reset on snb is unreliable (writing to GDRST
causes a ma
On 18/10/2017 07:47, Sagar Arun Kamble wrote:
To balance the GuC interrupt references we don't allow enabling interrupts
If logging was enabled earlier with different verbosity.
I've noticed in a couple of your previous commits words in the middle of
sentences starting with upper case which i
Here's another one I had lying around in pstore. Note that this one has
slighty older kernel and BIOS version, possibly eliminating a couple of
variables.
<6>[18285.732012] [drm] GPU HANG: ecode 9:0:0xfffe, in Xorg [842], reason:
Hang on render ring, action: reset
<6>[18285.732024] [drm] GP
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> In the future I want to allow tests to commit more properties,
> but for this to work I have to fix all properties to work better
> with atomic commit. Instead of special casing each
> property make a bitmask f
Quoting Bjørn Mork (2017-10-19 11:24:57)
> Hello,
>
> I get these Oopses from time to time, but unfortunately(?) not often
> enough to be anywhere near reproducible. But they seem to be related to
> whatever activites my laptop/X-server/driver/gpu/screen is doing while
> I'm not present. The oops
== Series Details ==
Series: drm/i915: Misc. PMIC bus access notifier fixes
URL : https://patchwork.freedesktop.org/series/32274/
State : warning
== Summary ==
Test perf:
Subgroup oa-exponents:
fail -> PASS (shard-hsw) fdo#102254
Test kms_flip:
Subgr
On Wed, Oct 18, 2017 at 02:11:46PM -0700, Manasi Navare wrote:
> On Mon, Oct 16, 2017 at 05:57:01PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > encoder->type is unreliable for DP/HDMI, so pass it in explicity into
> > cnl_ddi_vswing_sequence(). This matches what we do for BXT.
> >
Chris Wilson writes:
> Quoting Bjørn Mork (2017-10-19 11:24:57)
>> Hello,
>>
>> I get these Oopses from time to time, but unfortunately(?) not often
>> enough to be anywhere near reproducible. But they seem to be related to
>> whatever activites my laptop/X-server/driver/gpu/screen is doing whi
On Wed, Oct 18, 2017 at 02:50:59PM -0700, Rodrigo Vivi wrote:
> On Wed, Oct 18, 2017 at 08:48:24PM +, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Track the system agent voltage we request from pcode in the cdclk state
> > on CNL. Annoyingly we can't actually read out the current valu
_drm_lease_revoke() requires it callers to hold the idr_mutex, but its
only caller did not. Every device release would then trigger:
WARNING: CPU: 7 PID: 4169 at drivers/gpu/drm/drm_lease.c:313
_drm_lease_revoke+0x12c/0x140
Modules linked in: vgem snd_hda_codec_hdmi snd_hda_codec_generic i915
Bjørn Mork writes:
> Chris Wilson writes:
>
>> and at a guess
>> intel_iommu=igfx_off to avoid the hangs in the first place.
>
> Thanks for the tip. I'll try that
My memory is more than a bit flakey, but this did eventually ring a
bell.,. And googling I see that I have tried that tip before wit
Quoting Bjørn Mork (2017-10-19 11:43:17)
> Chris Wilson writes:
>
> > Quoting Bjørn Mork (2017-10-19 11:24:57)
> >> Hello,
> >>
> >> I get these Oopses from time to time, but unfortunately(?) not often
> >> enough to be anywhere near reproducible. But they seem to be related to
> >> whatever ac
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> Blacklist some explicit atomic properties. We could theoretically set
> them but that's not what the legacy path is for. :)
>
> When adding new properties, this means we could test those through
> the legacy c
On Thu, 2017-10-19 at 13:48 +0300, Ville Syrjälä wrote:
> On Wed, Oct 18, 2017 at 02:50:59PM -0700, Rodrigo Vivi wrote:
> >
> > On Wed, Oct 18, 2017 at 08:48:24PM +, Ville Syrjala wrote:
> > >
> > > From: Ville Syrjälä
> > >
> > > Track the system agent voltage we request from pcode in the
On 18/10/2017 07:47, Sagar Arun Kamble wrote:
In order to override the disable/enable control of GuC interrupts during
suspend/reset cycle we are creating two new functions suspend/restore
guc_interrupts which check if interrupts were enabled and disable them
on suspend and enable them on resume
Quoting Bjørn Mork (2017-10-19 11:55:18)
> Bjørn Mork writes:
> > Chris Wilson writes:
> >
> >> and at a guess
> >> intel_iommu=igfx_off to avoid the hangs in the first place.
> >
> > Thanks for the tip. I'll try that
>
> My memory is more than a bit flakey, but this did eventually ring a
> bell
On 19/10/2017 11:19, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-10-19 11:02:05)
On 19/10/2017 07:37, Chris Wilson wrote:
If the device is in runtime suspend, resuming takes time and reduces our
powersaving. If this was for a small write into an object, that resume
will take longer than
== Series Details ==
Series: hax: moar padding
URL : https://patchwork.freedesktop.org/series/32278/
State : warning
== Summary ==
Test perf:
Subgroup oa-exponents:
fail -> PASS (shard-hsw) fdo#102254
Test kms_busy:
Subgroup extended-modeset-hang-new
igt_pipe_refresh was added for the forked helper, we could just call it
from the fork to prevent races against MODE_ID.
The static 1024x768 mode is allocated on the stack and returned, which will
result in a garbage mode. Make the fallback mode global to prevent this.
igt_output_set_pipe is unnee
Hi All,
Here is a split-up version of my "drm/i915: Acquire PUNIT->PMIC bus for
intel_uncore_forcewake_reset()" patch, this time with the
arch/x86/platform/intel/iosf_mbi.c split out into a separate patch.
Since the iosf_mbi changes are fairly isolated, ideally this entire
series would go upstrea
For race free unregistration drivers may need to acquire PMIC bus access
through iosf_mbi_punit_acquire() and then (un)register the notifier without
dropping the lock.
This commit adds an unlocked variant of
iosf_mbi_unregister_pmic_bus_access_notifier for this use case.
Signed-off-by: Hans de Go
intel_uncore_forcewake_reset() does forcewake puts and gets as such
we need to make sure that no-one tries to access the PUNIT->PMIC bus
(on systems where this bus is shared) while it runs, otherwise bad
things happen.
Normally this is taken care of by the i915_pmic_bus_access_notifier()
which doe
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> With the replace_prop_blob functions we can safely replace the blob
> for
> any property, without having to care about error handling ourselves.
>
> This will for example allow overriding color management blob
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> Setting broadcast rgb was only used by chamelium, but is now handled
> in igt_display by default. This means that chamelium doesn't need to
> set it, and this can be hidden. The broadcast RGB property is intel
> -Original Message-
> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Thursday, October 19, 2017 12:57 PM
> To: Intel Graphics Development
> Cc: Daniel Vetter ; Joonas Lahtinen
> ; Chris Wilson ;
> Lofstedt, Marta ; Martin Peres
>
> Subject: Re:
== Series Details ==
Series: series starting with [v5,1/2] x86/platform/intel/iosf_mbi: Add unlocked
PMIC bus access notifier unregister
URL : https://patchwork.freedesktop.org/series/32288/
State : failure
== Summary ==
Series 32288v1 series starting with [v5,1/2] x86/platform/intel/iosf_mbi
== Series Details ==
Series: tests/gem_eio: Skip in-flight-suspend on snb
URL : https://patchwork.freedesktop.org/series/32280/
State : warning
== Summary ==
IGT patchset tested on top of latest successful build
abc08cba366a64a07f7f4deb167ae7d6ae059958 lib: Free all internal buffers before
me
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 17:33 +0200, Maarten Lankhorst wrote:
> This allows test to test whether a property is supported, in
> a nice and clean way. It removes the need for special case
> functions like igt_plane_supports_rotation.
>
> Convert the users of igt_plane_suppor
== Series Details ==
Series: tests/kms_concurrent: Fix testcase fails.
URL : https://patchwork.freedesktop.org/series/32287/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
abc08cba366a64a07f7f4deb167ae7d6ae059958 lib: Free all internal buffers before
measu
On Thu, Oct 19, 2017 at 01:56:38PM +0300, Mika Kahola wrote:
> On Thu, 2017-10-19 at 13:48 +0300, Ville Syrjälä wrote:
> > On Wed, Oct 18, 2017 at 02:50:59PM -0700, Rodrigo Vivi wrote:
> > >
> > > On Wed, Oct 18, 2017 at 08:48:24PM +, Ville Syrjala wrote:
> > > >
> > > > From: Ville Syrjälä
Quoting Chris Wilson (2017-10-19 11:53:44)
> _drm_lease_revoke() requires it callers to hold the idr_mutex, but its
> only caller did not. Every device release would then trigger:
>
> WARNING: CPU: 7 PID: 4169 at drivers/gpu/drm/drm_lease.c:313
> _drm_lease_revoke+0x12c/0x140
> Modules linked i
On Wed, Oct 18, 2017 at 12:59:05PM -0700, James Ausmus wrote:
> On Wed, Oct 18, 2017 at 09:19:58PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > A bunch of functions are now exclusively used for HDMI, so naming the
> > variables with hdmi prefix/suffix is redundant. Also use int rat
On Thu, 19 Oct 2017, Daniel Vetter wrote:
> On Wed, Oct 18, 2017 at 03:29:48PM -0700, Sripada, Radhakrishna wrote:
>> Currently the user space does not have a way to force the bpc. The
>> default bpc to be programmed is decided by the driver and is run
>> against connector limitations. Creating a
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> Some tests need to get the current kernel value for properties
> as part of the test. Add get_prop functions that will retrieve
> the current kernel value.
>
> Signed-off-by: Maarten Lankhorst
> ---
> lib/ig
Include GuC and HuC firmware details in captured error state
to provide additional debug information. To reuse existing
uc firmware pretty printer, introduce new drm-printer variant
that works with our i915_error_state_buf output.
Suggested-by: Chris Wilson
Signed-off-by: Michal Wajdeczko
Cc: Ch
== Series Details ==
Series: tests/kms_concurrent: Fix testcase fails.
URL : https://patchwork.freedesktop.org/series/32287/
State : success
== Summary ==
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test drv_module_reload:
Su
On Thu, Oct 19, 2017 at 1:37 PM, Lofstedt, Marta
wrote:
>
>
>> -Original Message-
>> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel
>> Vetter
>> Sent: Thursday, October 19, 2017 12:57 PM
>> To: Intel Graphics Development
>> Cc: Daniel Vetter ; Joonas Lahtinen
>> ;
Hi,
On 19-10-17 13:50, Patchwork wrote:
== Series Details ==
Series: series starting with [v5,1/2] x86/platform/intel/iosf_mbi: Add unlocked
PMIC bus access notifier unregister
URL : https://patchwork.freedesktop.org/series/32288/
State : failure
This seems to be a random failure getting a
...to see if it's problematic elsewhere than just SNB (as seen on
shards).
Signed-off-by: Petri Latvala
---
tests/intel-ci/fast-feedback.testlist | 298 +-
1 file changed, 2 insertions(+), 296 deletions(-)
diff --git a/tests/intel-ci/fast-feedback.testlist
b/t
Reviewed-by: Mika Kahola
On Thu, 2017-10-12 at 13:54 +0200, Maarten Lankhorst wrote:
> igt_pipe_get_property has been replaced by igt_pipe_obj_get_prop.
>
> Signed-off-by: Maarten Lankhorst
> ---
> lib/igt_kms.c | 10 --
> lib/igt_kms.h | 3 ---
> 2 files changed, 13 deletions(-)
>
>
Hi,
On 19-10-17 15:04, Hans de Goede wrote:
Hi,
On 19-10-17 13:50, Patchwork wrote:
== Series Details ==
Series: series starting with [v5,1/2] x86/platform/intel/iosf_mbi: Add unlocked
PMIC bus access notifier unregister
URL : https://patchwork.freedesktop.org/series/32288/
State : failure
== Series Details ==
Series: drm/i915: Add Guc/HuC firmware details to error state
URL : https://patchwork.freedesktop.org/series/32293/
State : failure
== Summary ==
Series 32293v1 drm/i915: Add Guc/HuC firmware details to error state
https://patchwork.freedesktop.org/api/1.0/series/32293/rev
On 19/10/17 12:51, Daniel Vetter wrote:
CI gets upset about it resulting in an incomplete, let's skip it until
that's fixed to avoid havoc in the CI farm. Of course this should/will
be reverted as soon as we have a fix (similar to how we dealt with the
snb-dies-in-blt-hangs issue).
Cc: Joonas La
Quoting Michal Wajdeczko (2017-10-19 13:57:06)
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c
> b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 653fb69..0105b87 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -30,6 +30,8 @@
> #include
Quoting Michal Wajdeczko (2017-10-19 13:57:06)
> @@ -774,6 +793,11 @@ int i915_error_state_to_str(struct
> drm_i915_error_state_buf *m,
> err_print_capabilities(m, &error->device_info);
> err_print_params(m, &error->params);
>
> + if (HAS_GUC(dev_priv)) {
Could we not peek
From: Ville Syrjälä
encoder->type isn't reliable for DP/HDMI so instead extract the correct
type from the crtc state in intel_ddi_set_pipe_settings().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 47
1 file changed, 24 insertions(
From: Ville Syrjälä
Here's the last chunk of my DDI encoder->type frobbery elimnination. Afterwards
DP/HDMI DDI encoders will have "DDI" as their type permanently, and instead one
needs to consult the crtc state output_types to determine in which mode we're
driving the port. For eDP DDI encoder w
From: Ville Syrjälä
Pass an old crtc state to intel_ddi_post_disable() from the MST code.
Note that this crtc state won't necessaitly match the one that was
passed to intel_ddi_pre_enable() if the first stream to be enabled isn't
the last stream to be disabled. But this is fine since the states
From: Ville Syrjälä
Currently the DDI encoder->type will change at runtime depending on
what kind of hotplugs we've processed. That's quite bad since we can't
really trust that that current value of encoder->type actually matches
the type of signal we're trying to drive through it.
Let's elimina
From: Ville Syrjälä
encoder->port works for FDI, and it also works for MST (regardless of
whether we're dealing with the "fake" MST encoder, or mst->primary).
So let's eliminate intel_ddi_get_encoder_port().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 50 ++
From: Ville Syrjälä
Eliminate intel_prepare_dp_ddi_buffers()'s reliance on the encoder->type
by passing in the crtc state.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/gp
From: Ville Syrjälä
intel_ddi_enable_transcoder_func() already has the crtc state so we can
use that instead of the untrustworthy encoder->type.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git
From: Ville Syrjälä
We should be using the DPLL hw state we got from the current crtc state
to determine the corresponding port clock frequency rather than getting
it via the current state programmed into the DPLL.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 17 +---
From: Ville Syrjälä
Reduce our general reliance on encoder->type and instead use
output_types from the crtc state when enabling LPE audio.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i91
From: Ville Syrjälä
encoder->type is not realiable for DP/HDMI so let's switch the DPLL
selection over to using output_types.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 36 +--
1 file changed, 13 insertions(+), 23 deletions(-)
diff
From: Ville Syrjälä
Eliminate the partially duplicated DDI readout code from MST, and
instead just call intel_ddi_get_config(). As a nice bonus we get
more cross checking as intel_ddi_get_config() will populate
output_types based on the actual mode of the DDI port.
Additonally intel_ddi_get_conf
== Series Details ==
Series: Run gem_eio@in-flight-suspend on farm1
URL : https://patchwork.freedesktop.org/series/32296/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
abc08cba366a64a07f7f4deb167ae7d6ae059958 lib: Free all internal buffers before
measurin
== Series Details ==
Series: drm/i915: Last part of DDI encoder->type cleanup
URL : https://patchwork.freedesktop.org/series/32298/
State : success
== Summary ==
Series 32298v1 drm/i915: Last part of DDI encoder->type cleanup
https://patchwork.freedesktop.org/api/1.0/series/32298/revisions/1/m
On Tue, 17 Oct 2017, Jani Nikula wrote:
> They're unused and unsupported. Leave the reduced_clock pointers in
> place still, should they prove useful later on.
>
> v2: go from nuking DDI lowfreq_avail to nuking it entirely (Ville)
>
> Cc: Daniel Vetter
> Cc: Ville Syrjälä
> Suggested-by: Ville S
On Tue, 17 Oct 2017, Jani Nikula wrote:
> Only the DDI hook has some actual content.
>
> Cc: Daniel Vetter
> Cc: Ville Syrjälä
> Reviewed-by: Ville Syrjälä
> Signed-off-by: Jani Nikula
Pushed to dinq, thanks for the review.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_crt.c | 26 ++
On Thu, Oct 19, 2017 at 03:56:37PM +0300, Jani Nikula wrote:
> On Thu, 19 Oct 2017, Daniel Vetter wrote:
> > On Wed, Oct 18, 2017 at 03:29:48PM -0700, Sripada, Radhakrishna wrote:
> >> Currently the user space does not have a way to force the bpc. The
> >> default bpc to be programmed is decided b
Hi Dave, I hoped this was going to be the last pull, but there's some
pressure for another. I'll tag more this week, and we can see next week
if you'd be willing to still take it.
BR,
Jani.
drm-intel-next-2017-10-12:
Last batch of drm/i915 features for v4.15:
- transparent huge pages support (M
== Series Details ==
Series: Run gem_eio@in-flight-suspend on farm1
URL : https://patchwork.freedesktop.org/series/32296/
State : warning
== Summary ==
Test drv_module_reload:
Subgroup basic-no-display:
pass -> DMESG-WARN (shard-hsw) fdo#102707
Test kms_busy:
From: Mika Kuoppala
As all our access to execlist ports are through head and tail
helpers, we can now move the head instead of memmoving the array.
Cc: Michał Winiarski
Cc: Joonas Lahtinen
Cc: Chris Wilson
Signed-off-by: Mika Kuoppala
---
drivers/gpu/drm/i915/intel_ringbuffer.h | 9 +---
From: Mika Kuoppala
Instead of trusting that first available port is at index 0,
use accessor to hide this. This is a preparation for a
following patches where head can be at arbitrary location
in the port array.
v2: improved commit message, elsp_ready readability (Chris)
v3: s/execlist_port_ind
1 - 100 of 202 matches
Mail list logo
