[Intel-gfx] ✓ Fi.CI.BAT: success for GuC Interrupts/Log updates

2017-10-18 Thread Patchwork
== Series Details == Series: GuC Interrupts/Log updates URL : https://patchwork.freedesktop.org/series/32179/ State : success == Summary == Series 32179v1 GuC Interrupts/Log updates https://patchwork.freedesktop.org/api/1.0/series/32179/revisions/1/mbox/ Test chamelium: Subgroup dp-ed

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use a mask when applying WaProgramL3SqcReg1Default

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Use a mask when applying WaProgramL3SqcReg1Default URL : https://patchwork.freedesktop.org/series/32158/ State : success == Summary == Test kms_setmode: Subgroup basic: fail -> PASS (shard-hsw) fdo#99912 fdo#99912 http

[Intel-gfx] [PATCH i-g-t] lib/i915: Move submission related helpers to lib/i915/gem_submission

2017-10-18 Thread Michał Winiarski
Since I accidentally broke the build for some, by putting the pretty printer for submission inside ifdef HAVE_PROCPS, it's time to move the whole thing into lib/i915 while fixing this mistake. Let's also rename the pretty printer and add a doc to it as well as the section. Fixes: f6dfe556659f ("li

Re: [Intel-gfx] [PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off

2017-10-18 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 06:32:52PM +0300, Ville Syrjälä wrote: > On Tue, Oct 17, 2017 at 05:27:14PM +0200, Daniel Vetter wrote: > > At least when they have vblank support they need to call this, or the > > vblank core will happily call into their crtc->enable_vblank callback > > even when the crtc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove g4x lowfreq_avail and has_pipe_cxsr

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: remove g4x lowfreq_avail and has_pipe_cxsr URL : https://patchwork.freedesktop.org/series/32134/ State : success == Summary == Series 32134v1 drm/i915: remove g4x lowfreq_avail and has_pipe_cxsr https://patchwork.freedesktop.org/api/1.0/series/32134/revis

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fixup userptr mmu notifier registration error handling (rev2)

2017-10-18 Thread Tvrtko Ursulin
On 17/10/2017 17:07, Patchwork wrote: == Series Details == Series: drm/i915: Fixup userptr mmu notifier registration error handling (rev2) URL : https://patchwork.freedesktop.org/series/32136/ State : success == Summary == Series 32136v2 drm/i915: Fixup userptr mmu notifier registration err

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: No need for RING_MAX_NONPRIV_SLOTS space

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: No need for RING_MAX_NONPRIV_SLOTS space URL : https://patchwork.freedesktop.org/series/32159/ State : failure == Summary == Test drv_suspend: Subgroup sysfs-reader-hibernate: fail -> DMESG-FAIL (shard-hsw) k.org#196691 Test

Re: [Intel-gfx] [PATCH i-g-t] tests: remove kms_fbc_crc

2017-10-18 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 05:10:21PM -0200, Paulo Zanoni wrote: > Em Ter, 2017-10-17 às 18:59 +0300, Ville Syrjälä escreveu: > > On Tue, Oct 17, 2017 at 05:16:40PM +0200, Daniel Vetter wrote: > > > This was the predecessor test to kms_frontbuffer_tracking, which > > > not > > > just tests fbc, and al

Re: [Intel-gfx] [PATCH i-g-t] lib/i915: Move submission related helpers to lib/i915/gem_submission

2017-10-18 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-18 09:02:12) > Since I accidentally broke the build for some, by putting the pretty > printer for submission inside ifdef HAVE_PROCPS, it's time to move the > whole thing into lib/i915 while fixing this mistake. > Let's also rename the pretty printer and add a doc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/crt: split compute_config hook by platforms

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915/crt: split compute_config hook by platforms URL : https://patchwork.freedesktop.org/series/32135/ State : success == Summary == Series 32135v1 drm/i915/crt: split compute_config hook by platforms https://patchwork.freedesktop.org/api/1.0/series/32135/revis

Re: [Intel-gfx] [PATCH] drm/i915: No need for RING_MAX_NONPRIV_SLOTS space

2017-10-18 Thread Chris Wilson
Quoting Oscar Mateo (2017-10-17 21:27:51) > Now that we write RING_FORCE_TO_NONPRIV registers directly to hardware, > [commit 32ced39 ("drm/i915: Transform whitelisting WAs into a simple reg > write")] there is no need to save space for them in the list of context > workarounds. > > v2: Refer to p

Re: [Intel-gfx] [PATCH] drm/i915: Debugfs to disable context banning

2017-10-18 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 09:23:43AM -0700, Jeff McGee wrote: > On Tue, Oct 17, 2017 at 05:36:54PM +0200, Daniel Vetter wrote: > > On Tue, Oct 17, 2017 at 08:25:33AM -0700, jeff.mc...@intel.com wrote: > > > From: Jeff McGee > > > > > > Useful for stress testing various reset scenarios. The ioctl th

Re: [Intel-gfx] [PATCH v2] drm/i915: Fixup userptr mmu notifier registration error handling

2017-10-18 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 04:09:08PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Avoid dereferencing the error pointer and also avoid returning NULL > from i915_mmu_notifier_find since the callers do not expect that. How did my patch return a NULL value? At least I assume that's the re

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2017-10-18 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_gem_evict.c between commit: 99b169d3c2052 ("drm/i915: Fix eviction when the GGTT is idle but full") from the drm-intel-fixes tree and commit: 9c1477e83e629 ("drm/i915/selftests: Exercise

[Intel-gfx] [PATCH] drm/i915: Do not rely on wm preservation for ILK watermarks

2017-10-18 Thread Maarten Lankhorst
The original intent was to preserve watermarks as much as possible in intel_pipe_wm.raw_wm, and put the validated ones in intel_pipe_wm.wm. It seems this approach is insufficient and we don't always preserve the raw watermarks, so just use the atomic iterator we're already using to get a const poi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Don't recheck link status for eDP display.

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Don't recheck link status for eDP display. URL : https://patchwork.freedesktop.org/series/32164/ State : success == Summary == Test kms_flip: Subgroup flip-vs-rmfb: pass -> DMESG-WARN (shard-hsw) fdo#102614 +1 Test kms_setmod

Re: [Intel-gfx] [PATCH v2] drm/i915: Fixup userptr mmu notifier registration error handling

2017-10-18 Thread Tvrtko Ursulin
On 18/10/2017 10:07, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 04:09:08PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoid dereferencing the error pointer and also avoid returning NULL from i915_mmu_notifier_find since the callers do not expect that. How did my patch return a NULL

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/i915: Move submission related helpers to lib/i915/gem_submission

2017-10-18 Thread Patchwork
== Series Details == Series: lib/i915: Move submission related helpers to lib/i915/gem_submission URL : https://patchwork.freedesktop.org/series/32184/ State : success == Summary == IGT patchset tested on top of latest successful build e66027ceef6266ef72fc7485567f518d2ce48817 tests: remove kms

Re: [Intel-gfx] [PATCH igt] igt/pm_rc6_residency: Measure residency after checking for applicability

2017-10-18 Thread Arkadiusz Hiler
On Tue, Oct 17, 2017 at 09:49:54AM +0100, Chris Wilson wrote: > CI doesn't run in whole-test mode, but runs each subtest individually. > Tests that are designed to do a block of work to be shared between many > subtests end up running that work multiple times (once per subtest) and > worse, that wo

[Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Mark Brown
Hi all, Today's linux-next merge of the sound-asoc tree got a conflict in: drivers/gpu/drm/amd/include/amd_shared.h between commit: cfa289fd4986c ("drm/amdgpu: rename amdgpu_dpm_funcs to amd_pm_funcs") from the drm-misc tree and commit: 1e4448648333a ("drm/amdgpu Moving amdgpu asic type

Re: [Intel-gfx] [PATCH v5] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-18 Thread Daniel Vetter
On Sun, Oct 15, 2017 at 12:06:44AM +0530, Harsha Sharma wrote: > Replace instances of drm_framebuffer_reference/unreference() with > *_get/put() suffixes and drm_dev_unref with *_put() suffix > because get/put is shorter and consistent with the > kernel use of *_get/put suffixes. > Done with follow

Re: [Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Mark Brown
On Wed, Oct 18, 2017 at 10:57:33AM +0100, Mark Brown wrote: > I fixed it up (see below) and can carry the fix as necessary. This > is now fixed as far as linux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your tree > is submitted for mergi

[Intel-gfx] ✓ Fi.CI.IGT: success for HAX: kernel/swsusp: Show invalid swap signature (rev2)

2017-10-18 Thread Patchwork
== Series Details == Series: HAX: kernel/swsusp: Show invalid swap signature (rev2) URL : https://patchwork.freedesktop.org/series/32130/ State : success == Summary == shard-hswtotal:2551 pass:1441 dwarn:0 dfail:0 fail:9 skip:1101 time:9283s == Logs == For more details see: h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not rely on wm preservation for ILK watermarks

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Do not rely on wm preservation for ILK watermarks URL : https://patchwork.freedesktop.org/series/32197/ State : success == Summary == Series 32197v1 drm/i915: Do not rely on wm preservation for ILK watermarks https://patchwork.freedesktop.org/api/1.0/seri

[Intel-gfx] ✗ Fi.CI.BAT: failure for igt/pm_rc6_residency: Allow some leeway on the upper %% bound

2017-10-18 Thread Patchwork
== Series Details == Series: igt/pm_rc6_residency: Allow some leeway on the upper %% bound URL : https://patchwork.freedesktop.org/series/32112/ State : failure == Summary == Series 32112 revision 1 was fully merged or fully failed: no git log == Logs == For more details see: https://intel-g

[Intel-gfx] [PATCH] drm/i915: Disable lazy PPGTT page table optimization for vGPU

2017-10-18 Thread Joonas Lahtinen
When running under virtualization (vGPU active), we must disable the azy PPGTT page table initialization optimization introduced by: 14826673247e ("drm/i915: Only initialize partially filled pagetables") We must do this because GVT-g makes unduly assumptions about guest behaviour, which this opti

Re: [Intel-gfx] [PATCH v7 3/4] drm/i915/guc : Updating GuC and HuC FW select function

2017-10-18 Thread Sagar Arun Kamble
On 10/18/2017 4:20 AM, Sujaritha Sundaresan wrote: Updating GuC and HuC firmware select function to support removing i915_modparams.enable_guc_loading module parameter. v2: Clarifying the commit message (Anusha) v3: Unify seq_puts messages, Re-factoring code as per review (Michal) v4: Rebase

Re: [Intel-gfx] [PATCH] drm/i915: Disable lazy PPGTT page table optimization for vGPU

2017-10-18 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-10-18 11:25:43) > When running under virtualization (vGPU active), we must disable > the azy PPGTT page table initialization optimization introduced by: > > 14826673247e ("drm/i915: Only initialize partially filled pagetables") > > We must do this because GVT-g makes

[Intel-gfx] [PATCH i-g-t] tests/kms_cursor_legacy: Remove strict vblank checking on 2x-*-vs-cursor tests.

2017-10-18 Thread Maarten Lankhorst
There is no guarantee that on 2 screens the vblanks are in any way synchronized, so it's best to stop checking them, since doing an update involving multiple pipes may incur an arbitrary amount of delay. Signed-off-by: Maarten Lankhorst Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10163

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_cursor_legacy: Remove strict vblank checking on 2x-*-vs-cursor tests.

2017-10-18 Thread Chris Wilson
Quoting Maarten Lankhorst (2017-10-18 11:43:25) > There is no guarantee that on 2 screens the vblanks are in any way > synchronized, so it's best to stop checking them, since doing an update > involving multiple pipes may incur an arbitrary amount of delay. Ah, that's a shame. Not much point in as

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-18 Thread Joonas Lahtinen
On Tue, 2017-10-17 at 15:50 -0700, Sujaritha Sundaresan wrote: > We currently have two module parameters that control GuC: > "enable_guc_loading" and "enable_guc_submission". Whenever > we need i915_modparams.enable_guc_submission=1, we also need > enable_guc_loading=1. We also need enable_guc_load

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rps: Move some test logic out of boost function

2017-10-18 Thread Szwichtenberg, Radoslaw
On Wed, 2017-10-18 at 11:10 +0530, Sagar Arun Kamble wrote: > > On 10/17/2017 6:13 PM, Radoslaw Szwichtenberg wrote: > > Moving code out of the boost function will allow its usage > > in other/new test scenarios. > > > > Signed-off-by: Radoslaw Szwichtenberg > > Cc: Sagar Arun Kamble > > --- >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable lazy PPGTT page table optimization for vGPU

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Disable lazy PPGTT page table optimization for vGPU URL : https://patchwork.freedesktop.org/series/32201/ State : success == Summary == Series 32201v1 drm/i915: Disable lazy PPGTT page table optimization for vGPU https://patchwork.freedesktop.org/api/1.0/

[Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout

2017-10-18 Thread Imre Deak
The CI software watchdog (owatch) will timeout if the test doesn't output anything for a long time on standard out or error. At least the plane-all-modeset-transition and plane-all-modeset-transition-fences subtests run without any output longer than the watchdog timeout, so output some more progre

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_cursor_legacy: Remove strict vblank checking on 2x-*-vs-cursor tests.

2017-10-18 Thread Maarten Lankhorst
Op 18-10-17 om 12:47 schreef Chris Wilson: > Quoting Maarten Lankhorst (2017-10-18 11:43:25) >> There is no guarantee that on 2 screens the vblanks are in any way >> synchronized, so it's best to stop checking them, since doing an update >> involving multiple pipes may incur an arbitrary amount of

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Remove strict vblank checking on 2x-*-vs-cursor tests.

2017-10-18 Thread Patchwork
== Series Details == Series: tests/kms_cursor_legacy: Remove strict vblank checking on 2x-*-vs-cursor tests. URL : https://patchwork.freedesktop.org/series/32202/ State : success == Summary == IGT patchset tested on top of latest successful build 9a3f6f59d4c208219f7d3178106bdef628ff68d0 tests

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout

2017-10-18 Thread Chris Wilson
Quoting Imre Deak (2017-10-18 12:29:33) > The CI software watchdog (owatch) will timeout if the test doesn't > output anything for a long time on standard out or error. At least the > plane-all-modeset-transition and plane-all-modeset-transition-fences > subtests run without any output longer than

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout

2017-10-18 Thread Petri Latvala
On Wed, Oct 18, 2017 at 02:29:33PM +0300, Imre Deak wrote: > The CI software watchdog (owatch) will timeout if the test doesn't > output anything for a long time on standard out or error. At least the > plane-all-modeset-transition and plane-all-modeset-transition-fences > subtests run without any

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout

2017-10-18 Thread Imre Deak
On Wed, Oct 18, 2017 at 02:43:38PM +0300, Petri Latvala wrote: > On Wed, Oct 18, 2017 at 02:29:33PM +0300, Imre Deak wrote: > > The CI software watchdog (owatch) will timeout if the test doesn't > > output anything for a long time on standard out or error. At least the > > plane-all-modeset-transit

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout

2017-10-18 Thread Imre Deak
On Wed, Oct 18, 2017 at 02:47:17PM +0300, Imre Deak wrote: > On Wed, Oct 18, 2017 at 02:43:38PM +0300, Petri Latvala wrote: > > On Wed, Oct 18, 2017 at 02:29:33PM +0300, Imre Deak wrote: > > > The CI software watchdog (owatch) will timeout if the test doesn't > > > output anything for a long time o

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-18 Thread Michal Wajdeczko
On Wed, 18 Oct 2017 00:50:47 +0200, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need i915_modparams.enable_guc_submission=1, we also need enable_guc_loading=1. We also need enable_guc_loadi

[Intel-gfx] ✓ Fi.CI.BAT: success for kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout

2017-10-18 Thread Patchwork
== Series Details == Series: kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout URL : https://patchwork.freedesktop.org/series/32206/ State : success == Summary == IGT patchset tested on top of latest successful build 9a3f6f59d4c208219f7d3178106bdef628ff

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout

2017-10-18 Thread Petri Latvala
On 10/18/2017 02:50 PM, Imre Deak wrote: On Wed, Oct 18, 2017 at 02:47:17PM +0300, Imre Deak wrote: On Wed, Oct 18, 2017 at 02:43:38PM +0300, Petri Latvala wrote: On Wed, Oct 18, 2017 at 02:29:33PM +0300, Imre Deak wrote: The CI software watchdog (owatch) will timeout if the test doesn't out

[Intel-gfx] [PATCH v2] drm/i915: Flush the idle-worker for debugfs/i915_drop_caches

2017-10-18 Thread Chris Wilson
After being requested to idle the GPU, flush the idle worker to drop the residual active state, and any internal object caches. v2: By popular demand, introduce DROP_IDLE for fine-grained control from userspace, though it should be used as part of a DROP_ACTIVE | DROP_RETIRE | DROP_IDLE |

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_plane_lowres: Rework tests to work without fbcon. (rev2)

2017-10-18 Thread Patchwork
== Series Details == Series: tests/kms_plane_lowres: Rework tests to work without fbcon. (rev2) URL : https://patchwork.freedesktop.org/series/32016/ State : success == Summary == IGT patchset tested on top of latest successful build 9a3f6f59d4c208219f7d3178106bdef628ff68d0 tests/intel-ci: Rem

[Intel-gfx] [PATCH igt 2/4] lib: Idle the GT when quiescing the GPU

2017-10-18 Thread Chris Wilson
As part of the general procedure for ensuring the GPU is idle, we also want to ask the driver to flush its idle_worker. The idle_worker is responsible for releasing both the driver's internal cache of buffers and cache of state (such as the prolonged GT wakeref). By flushing the idle_worker we ensu

[Intel-gfx] [PATCH igt 4/4] lib: Free all internal buffers before measuring available memory

2017-10-18 Thread Chris Wilson
Release the internal caches (by flushing the idle_worker) to maximise the available memory for use by tests (and to reduce sporadic skipping when on the cusp). Signed-off-by: Chris Wilson --- lib/intel_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/intel_os.c b/lib/

[Intel-gfx] [PATCH igt 3/4] lib: Flush the driver's internal cache of objects before counting

2017-10-18 Thread Chris Wilson
As the driver itself keeps a cache of objects, these too need to be flushed prior to producing a stable count of objects. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102655 Signed-off-by: Chris Wilson --- lib/igt_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Intel-gfx] [PATCH igt 1/4] lib: Add DROP_IDLE

2017-10-18 Thread Chris Wilson
A new flag for an old API; now we can request that the driver flush its idle_worker to release internal caches. Signed-off-by: Chris Wilson --- lib/igt_debugfs.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h index 4fa49d21..d90d

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Export low level PM IRQ functions to control from GuC functions

2017-10-18 Thread Tvrtko Ursulin
On 18/10/2017 07:46, Sagar Arun Kamble wrote: In order to separate GuC IRQ handling functions from i915_irq.c we need to export the low level pm irq handlers. Export pm_iir, reset_pm_iir and enable/disable_pm_irq functions. Suggested-by: Michal Wajdeczko Signed-off-by: Sagar Arun Kamble Cc: M

Re: [Intel-gfx] [PATCH v3 11/22] drm/i915/cnl: Move GT and Display workarounds from init_clock_gating

2017-10-18 Thread Ville Syrjälä
On Fri, Oct 13, 2017 at 01:54:05PM -0700, Oscar Mateo wrote: > To their rightful place inside intel_workarounds.c > > Signed-off-by: Oscar Mateo > Cc: Rodrigo Vivi > Cc: Chris Wilson > Cc: Mika Kuoppala > Cc: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_pm.c | 32 > +---

Re: [Intel-gfx] [PATCH 02/11] drm/i915/guc: Move GuC interrupts related functions from i915_irq.c to intel_guc.c

2017-10-18 Thread Tvrtko Ursulin
On 18/10/2017 07:46, Sagar Arun Kamble wrote: GuC interrupts handling is core GuC functionality. Better to keep it with other core functions in intel_guc.c. Since they are used from uC functions, GuC logging, i915 irq handling keeping them grouped in intel_guc.c instead of intel_uc.c. Suggested

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush the idle-worker for debugfs/i915_drop_caches (rev2)

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Flush the idle-worker for debugfs/i915_drop_caches (rev2) URL : https://patchwork.freedesktop.org/series/32102/ State : success == Summary == Series 32102v2 drm/i915: Flush the idle-worker for debugfs/i915_drop_caches https://patchwork.freedesktop.org/api

Re: [Intel-gfx] [PATCH 03/11] drm/i915/guc: Pass intel_guc struct parameter to GuC interrupts functions

2017-10-18 Thread Tvrtko Ursulin
On 18/10/2017 07:46, Sagar Arun Kamble wrote: GuC interrupts handling functions are GuC specific functions hence update the parameter from dev_priv to intel_guc struct. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Chris Wilson Cc:

Re: [Intel-gfx] [PATCH v2] drm/i915: Flush the idle-worker for debugfs/i915_drop_caches

2017-10-18 Thread Joonas Lahtinen
On Wed, 2017-10-18 at 13:16 +0100, Chris Wilson wrote: > After being requested to idle the GPU, flush the idle worker to drop the > residual active state, and any internal object caches. > > v2: By popular demand, introduce DROP_IDLE for fine-grained control from > userspace, though it should be u

Re: [Intel-gfx] [PATCH 04/11] drm/i915/guc: Sanitize module parameter guc_log_level

2017-10-18 Thread Tvrtko Ursulin
On 18/10/2017 07:46, Sagar Arun Kamble wrote: Parameter guc_log_level needs to be sanitized based on GuC support and enable_guc_loading parameter since it depends on them like enable_guc_submission. This will make GuC logging paths independent of enable_guc_submission parameter in further patche

Re: [Intel-gfx] [PATCH igt 1/4] lib: Add DROP_IDLE

2017-10-18 Thread Joonas Lahtinen
On Wed, 2017-10-18 at 13:34 +0100, Chris Wilson wrote: > A new flag for an old API; now we can request that the driver flush its > idle_worker to release internal caches. > > Signed-off-by: Chris Wilson Whole series is; Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Sou

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] lib: Add DROP_IDLE

2017-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/4] lib: Add DROP_IDLE URL : https://patchwork.freedesktop.org/series/32211/ State : success == Summary == IGT patchset tested on top of latest successful build 9a3f6f59d4c208219f7d3178106bdef628ff68d0 tests/intel-ci: Remove fast-feedback-si

Re: [Intel-gfx] [PATCH 05/11] drm/i915/guc: Make GuC log related functions depend only on log level

2017-10-18 Thread Tvrtko Ursulin
On 18/10/2017 07:46, Sagar Arun Kamble wrote: With guc_log_level parameter sanitized we can remove the GuC submission checks from flush_guc_logs and i915_guc_log_register/unregister and intel_uc_fini_hw. It is important to note that GuC log runtime/relay channel data has to be freed during drive

Re: [Intel-gfx] [PATCH 06/11] drm/i915/guc: Only release GuC log object during submission_fini

2017-10-18 Thread Tvrtko Ursulin
On 18/10/2017 07:46, Sagar Arun Kamble wrote: GuC log runtime/relay channel data is released during i915 unregister, So only GuC log vma needs to be released during submission_fini. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Chris

Re: [Intel-gfx] [PATCH 07/13] drm/i915/cnl: DVFS for PLL enabling

2017-10-18 Thread Ville Syrjälä
On Tue, Oct 17, 2017 at 04:23:07PM -0700, Rodrigo Vivi wrote: > On Tue, Oct 17, 2017 at 08:36:14PM +, Ville Syrjälä wrote: > > On Tue, Oct 17, 2017 at 09:02:05PM +0300, Ville Syrjälä wrote: > > > On Tue, Oct 17, 2017 at 10:45:22AM -0700, Rodrigo Vivi wrote: > > > > On Tue, Oct 17, 2017 at 05:23

[Intel-gfx] ✓ Fi.CI.IGT: success for GuC Interrupts/Log updates

2017-10-18 Thread Patchwork
== Series Details == Series: GuC Interrupts/Log updates URL : https://patchwork.freedesktop.org/series/32179/ State : success == Summary == Test drv_suspend: Subgroup sysfs-reader-hibernate: dmesg-fail -> FAIL (shard-hsw) k.org#196691 k.org#196691 https://bugzill

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rps: Move some test logic out of boost function

2017-10-18 Thread Sagar Arun Kamble
On 10/18/2017 4:33 PM, Szwichtenberg, Radoslaw wrote: On Wed, 2017-10-18 at 11:10 +0530, Sagar Arun Kamble wrote: On 10/17/2017 6:13 PM, Radoslaw Szwichtenberg wrote: Moving code out of the boost function will allow its usage in other/new test scenarios. Signed-off-by: Radoslaw Szwichtenberg

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Export low level PM IRQ functions to control from GuC functions

2017-10-18 Thread Sagar Arun Kamble
On 10/18/2017 6:12 PM, Tvrtko Ursulin wrote: On 18/10/2017 07:46, Sagar Arun Kamble wrote: In order to separate GuC IRQ handling functions from i915_irq.c we need to export the low level pm irq handlers. Export pm_iir, reset_pm_iir and enable/disable_pm_irq functions. Suggested-by: Michal Wa

Re: [Intel-gfx] [PATCH 02/11] drm/i915/guc: Move GuC interrupts related functions from i915_irq.c to intel_guc.c

2017-10-18 Thread Sagar Arun Kamble
On 10/18/2017 6:16 PM, Tvrtko Ursulin wrote: On 18/10/2017 07:46, Sagar Arun Kamble wrote: GuC interrupts handling is core GuC functionality. Better to keep it with other core functions in intel_guc.c. Since they are used from uC functions, GuC logging, i915 irq handling keeping them grouped

[Intel-gfx] [PATCH igt] igt/prime_mmap_coherency: Call prime_sync_start before read after write

2017-10-18 Thread Chris Wilson
We never declared that we were about to read from the mmap after copying into using the BLT (a missed call to prime_sync_start); leaving its coherency ill-defined. For completeness, add the missing prime_sync_end() as well. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103168 Signed-off-b

Re: [Intel-gfx] [PATCH] drm/i915: Debugfs to disable context banning

2017-10-18 Thread Jeff McGee
On Wed, Oct 18, 2017 at 11:01:13AM +0200, Daniel Vetter wrote: > On Tue, Oct 17, 2017 at 09:23:43AM -0700, Jeff McGee wrote: > > On Tue, Oct 17, 2017 at 05:36:54PM +0200, Daniel Vetter wrote: > > > On Tue, Oct 17, 2017 at 08:25:33AM -0700, jeff.mc...@intel.com wrote: > > > > From: Jeff McGee > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: remove g4x lowfreq_avail and has_pipe_cxsr

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: remove g4x lowfreq_avail and has_pipe_cxsr URL : https://patchwork.freedesktop.org/series/32134/ State : success == Summary == Test drv_suspend: Subgroup sysfs-reader-hibernate: dmesg-fail -> FAIL (shard-hsw) k.org#196691 Tes

Re: [Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Deucher, Alexander
> -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Wednesday, October 18, 2017 6:08 AM > To: Deucher, Alexander; Mukunda, Vijendar; Zhu, Rex; Daniel Vetter; Intel > Graphics; DRI; Liam Girdwood > Cc: Linux-Next Mailing List; Linux Kernel Mailing List; alsa-devel@als

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Output more finegrained progress info to avoid CI watchdog timeout

2017-10-18 Thread Daniel Vetter
On Wed, Oct 18, 2017 at 02:43:38PM +0300, Petri Latvala wrote: > On Wed, Oct 18, 2017 at 02:29:33PM +0300, Imre Deak wrote: > > The CI software watchdog (owatch) will timeout if the test doesn't > > output anything for a long time on standard out or error. At least the > > plane-all-modeset-transit

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/prime_mmap_coherency: Call prime_sync_start before read after write

2017-10-18 Thread Patchwork
== Series Details == Series: igt/prime_mmap_coherency: Call prime_sync_start before read after write URL : https://patchwork.freedesktop.org/series/32219/ State : success == Summary == IGT patchset tested on top of latest successful build 9a3f6f59d4c208219f7d3178106bdef628ff68d0 tests/intel-ci

Re: [Intel-gfx] [PATCH 1/5] drm/i915: move adjusted_x/y from crtc to cache.

2017-10-18 Thread Ville Syrjälä
On Tue, Oct 17, 2017 at 11:08:07PM +0300, Juha-Pekka Heikkila wrote: This one lacked a commit message. I just slapped in something rudimentary this time. In the future make sure the commit messages are there, and that they're useful ;) Entire series pushed to dinq. Thanks for the patches. > Sign

Re: [Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Deucher, Alexander
> -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Wednesday, October 18, 2017 5:58 AM > To: Deucher, Alexander; Mukunda, Vijendar; Zhu, Rex; Daniel Vetter; Intel > Graphics; DRI; Liam Girdwood > Cc: Linux-Next Mailing List; Linux Kernel Mailing List > Subject: linu

Re: [Intel-gfx] [PATCH igt] igt/prime_mmap_coherency: Call prime_sync_start before read after write

2017-10-18 Thread Daniel Vetter
On Wed, Oct 18, 2017 at 03:19:44PM +0100, Chris Wilson wrote: > We never declared that we were about to read from the mmap after copying > into using the BLT (a missed call to prime_sync_start); leaving its > coherency ill-defined. For completeness, add the missing > prime_sync_end() as well. > >

Re: [Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Mark Brown
On Wed, Oct 18, 2017 at 02:30:50PM +, Deucher, Alexander wrote: > The patch below effectively reverts 1e4448648333a. If you drop the patch > below, you should be fine. As I said in my followup mail I've dropped all these patches due to build failures, please resend both the pull request and

Re: [Intel-gfx] [PATCH igt] igt/prime_mmap_coherency: Call prime_sync_start before read after write

2017-10-18 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-18 15:47:27) > On Wed, Oct 18, 2017 at 03:19:44PM +0100, Chris Wilson wrote: > > We never declared that we were about to read from the mmap after copying > > into using the BLT (a missed call to prime_sync_start); leaving its > > coherency ill-defined. For completenes

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/crt: split compute_config hook by platforms

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915/crt: split compute_config hook by platforms URL : https://patchwork.freedesktop.org/series/32135/ State : success == Summary == Test drv_suspend: Subgroup sysfs-reader-hibernate: dmesg-fail -> FAIL (shard-hsw) k.org#196691 Tes

[Intel-gfx] [PATCH i-g-t v2] tests/pm_rps: Move some test logic out of boost function

2017-10-18 Thread Radoslaw Szwichtenberg
Moving code out of the boost function will allow its usage in other/new test scenarios. Signed-off-by: Radoslaw Szwichtenberg --- tests/pm_rps.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index 89f3e31c..fa548260 100644

Re: [Intel-gfx] [PATCH 04/11] drm/i915/guc: Sanitize module parameter guc_log_level

2017-10-18 Thread Sagar Arun Kamble
On 10/18/2017 6:29 PM, Tvrtko Ursulin wrote: On 18/10/2017 07:46, Sagar Arun Kamble wrote: Parameter guc_log_level needs to be sanitized based on GuC support and enable_guc_loading parameter since it depends on them like enable_guc_submission. This will make GuC logging paths independent of e

Re: [Intel-gfx] [PATCH i-g-t 1/8] lib/igt_dummyload: add igt_cork

2017-10-18 Thread Daniele Ceraolo Spurio
On 13/10/17 09:37, Daniele Ceraolo Spurio wrote: On 13/10/17 01:31, Chris Wilson wrote: Quoting Chris Wilson (2017-10-12 23:57:38) Quoting Daniele Ceraolo Spurio (2017-10-12 23:27:27) +igt_cork_t *igt_cork_new(int fd); _new does not imply plugged. +void igt_cork_signal(igt_cork_t *cork

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/pm_rps: Move some test logic out of boost function (rev2)

2017-10-18 Thread Patchwork
== Series Details == Series: tests/pm_rps: Move some test logic out of boost function (rev2) URL : https://patchwork.freedesktop.org/series/32131/ State : success == Summary == IGT patchset tested on top of latest successful build 9a3f6f59d4c208219f7d3178106bdef628ff68d0 tests/intel-ci: Remove

Re: [Intel-gfx] [PATCH 05/11] drm/i915/guc: Make GuC log related functions depend only on log level

2017-10-18 Thread Sagar Arun Kamble
On 10/18/2017 6:37 PM, Tvrtko Ursulin wrote: On 18/10/2017 07:46, Sagar Arun Kamble wrote: With guc_log_level parameter sanitized we can remove the GuC submission checks from flush_guc_logs and i915_guc_log_register/unregister and intel_uc_fini_hw. It is important to note that GuC log runtime

Re: [Intel-gfx] [PATCH i-g-t 1/8] lib/igt_dummyload: add igt_cork

2017-10-18 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2017-10-18 16:49:24) > > > On 13/10/17 09:37, Daniele Ceraolo Spurio wrote: > > > > > > On 13/10/17 01:31, Chris Wilson wrote: > >> Quoting Chris Wilson (2017-10-12 23:57:38) > >>> Quoting Daniele Ceraolo Spurio (2017-10-12 23:27:27) > +igt_cork_t *igt_cork_

Re: [Intel-gfx] [PATCH 06/11] drm/i915/guc: Only release GuC log object during submission_fini

2017-10-18 Thread Sagar Arun Kamble
On 10/18/2017 6:42 PM, Tvrtko Ursulin wrote: On 18/10/2017 07:46, Sagar Arun Kamble wrote: GuC log runtime/relay channel data is released during i915 unregister, So only GuC log vma needs to be released during submission_fini. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Danie

Re: [Intel-gfx] linux-next: manual merge of the sound-asoc tree with the drm-misc tree

2017-10-18 Thread Mark Brown
On Wed, Oct 18, 2017 at 02:33:37PM +, Deucher, Alexander wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > Your conflict change affectively reverted 1e444864833

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-18 Thread Sujaritha
On 10/18/2017 03:58 AM, Joonas Lahtinen wrote: On Tue, 2017-10-17 at 15:50 -0700, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need i915_modparams.enable_guc_submission=1, we also need enable

Re: [Intel-gfx] [PATCH v2 05/10] drm/i915: Integrate BXT into intel_ddi_dp_voltage_max()

2017-10-18 Thread James Ausmus
On Mon, Oct 16, 2017 at 05:57:00PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Make BXT less special by following the CNL approach and handling > it in intel_ddi_dp_voltage_max() alognside every other DDI platform. > > v2: Clean up the argument types to bxt_ddi_vswing_sequence() while

Re: [Intel-gfx] [PATCH i-g-t 1/8] lib/igt_dummyload: add igt_cork

2017-10-18 Thread Daniele Ceraolo Spurio
On 18/10/17 09:04, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2017-10-18 16:49:24) On 13/10/17 09:37, Daniele Ceraolo Spurio wrote: On 13/10/17 01:31, Chris Wilson wrote: Quoting Chris Wilson (2017-10-12 23:57:38) Quoting Daniele Ceraolo Spurio (2017-10-12 23:27:27) +igt_cork_

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-18 Thread Joonas Lahtinen
On Wed, 2017-10-18 at 09:25 -0700, Sujaritha wrote: > > On 10/18/2017 03:58 AM, Joonas Lahtinen wrote: > > On Tue, 2017-10-17 at 15:50 -0700, Sujaritha Sundaresan wrote: > > > We currently have two module parameters that control GuC: > > > "enable_guc_loading" and "enable_guc_submission". Whenever

Re: [Intel-gfx] [PATCH v7 2/4] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-18 Thread Sujaritha
On 10/18/2017 09:50 AM, Joonas Lahtinen wrote: On Wed, 2017-10-18 at 09:25 -0700, Sujaritha wrote: On 10/18/2017 03:58 AM, Joonas Lahtinen wrote: On Tue, 2017-10-17 at 15:50 -0700, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and

Re: [Intel-gfx] [PATCH v2 06/10] drm/i915: Pass encoder type to cnl_ddi_vswing_sequence() explicitly

2017-10-18 Thread James Ausmus
On Mon, Oct 16, 2017 at 05:57:01PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > encoder->type is unreliable for DP/HDMI, so pass it in explicity into > cnl_ddi_vswing_sequence(). This matches what we do for BXT. > > v2: Pass intel_encoder down to cnl_ddi_vswing_program(), and > clea

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Kill off the BXT buf_trans default_index

2017-10-18 Thread James Ausmus
On Mon, Oct 16, 2017 at 05:57:02PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > default_index contained in the BXT buf_trans tables is actually useless. > For DP we should always have a valid level selected (otherwise the link > training logic would be buggy), and for HDMI we can just do

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/i915: Move submission related helpers to lib/i915/gem_submission

2017-10-18 Thread Patchwork
== Series Details == Series: lib/i915: Move submission related helpers to lib/i915/gem_submission URL : https://patchwork.freedesktop.org/series/32184/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test pe

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Extract intel_ddi_get_buf_trans_hdmi()

2017-10-18 Thread Ville Syrjälä
On Mon, Oct 16, 2017 at 04:41:49PM -0700, Ausmus, James wrote: > On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala > wrote: > > From: Ville Syrjälä > > > > Introduce intel_ddi_get_buf_trans_hdmi() and start using it where we > > can. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Centralize the SKL DDI A/E vs. B/C/D buf trans handling

2017-10-18 Thread James Ausmus
On Mon, Oct 16, 2017 at 05:57:03PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > SKL DDI B/C/D only have 9 usable buf trans registers for DP/eDP. That > matches the normal DP buf trans tables, but the low vswing eDP tables > have 10 entries. Thus the eDP tables can only be used safely wit

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Do not rely on wm preservation for ILK watermarks

2017-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Do not rely on wm preservation for ILK watermarks URL : https://patchwork.freedesktop.org/series/32197/ State : failure == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test perf:

Re: [Intel-gfx] [PATCH 09/10] drm/i915: Unify error handling for missing DDI buf trans tables

2017-10-18 Thread James Ausmus
On Mon, Oct 16, 2017 at 05:57:04PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Handle missing buf trans tables, or out of bounds buf trans levels > the same way everywhere. These should never be hit under normal > conditions, but let's play it safe for now. > > Signed-off-by: Ville Syr

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Drop the redundant hdmi prefix/suffix from a lot of variables

2017-10-18 Thread James Ausmus
On Mon, Oct 16, 2017 at 05:57:05PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > A bunch of functions are now exclusively used for HDMI, so naming the > variables with hdmi prefix/suffix is redundant. Also use int rather > than u32 for the translation level consistently. Is there a case

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Extract intel_ddi_get_buf_trans_hdmi()

2017-10-18 Thread James Ausmus
On Wed, Oct 18, 2017 at 08:09:24PM +0300, Ville Syrjälä wrote: > On Mon, Oct 16, 2017 at 04:41:49PM -0700, Ausmus, James wrote: > > On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala > > wrote: > > > From: Ville Syrjälä > > > > > > Introduce intel_ddi_get_buf_trans_hdmi() and start using it where we

Re: [Intel-gfx] [PATCH 09/10] drm/i915: Unify error handling for missing DDI buf trans tables

2017-10-18 Thread Ville Syrjälä
On Wed, Oct 18, 2017 at 10:41:44AM -0700, James Ausmus wrote: > On Mon, Oct 16, 2017 at 05:57:04PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Handle missing buf trans tables, or out of bounds buf trans levels > > the same way everywhere. These should never be hit under normal > >

  1   2   >