[Intel-gfx] [PATCH] drm/i915: check pin validity of VBT configuration

2017-10-13 Thread Li, Fei
In this patch, add validity checking of pin configuration from VBT; If invalid, print log, ignore the configuration. Without this patch, in case of invalid pin configured by VBT, panic is hit: [ 45.778820] WARN_ON(!intel_gmbus_is_valid_pin(dev_priv, pin)) [ 45.778820] [ cut here ]

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: enable to read CSB and CSB write pointer from HWSP in GVT-g VM (rev2)

2017-10-13 Thread Patchwork
== Series Details == Series: drm/i915: enable to read CSB and CSB write pointer from HWSP in GVT-g VM (rev2) URL : https://patchwork.freedesktop.org/series/31789/ State : success == Summary == shard-hswtotal:2501 pass:1413 dwarn:0 dfail:0 fail:9 skip:1079 time:9529s == Logs ==

Re: [Intel-gfx] [PULL] drm-intel-next

2017-10-13 Thread Jani Nikula
On Fri, 13 Oct 2017, Dave Airlie wrote: > On 13 October 2017 at 01:23, Jani Nikula wrote: >> On Wed, 11 Oct 2017, Jani Nikula wrote: >>> Hi Dave, more v4.15 features. >> >> Okay, so I suck and there's still one more batch to come after this. I'm >> a bit out of rhythm here. When do you want the

[Intel-gfx] [PATCH] HAX: Do not restore mode through fbcon

2017-10-13 Thread Maarten Lankhorst
Lets try it and see what breaks! Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_fb_helper.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 6a31d13f2f81..0414da9

Re: [Intel-gfx] [PATCH v13 03/21] drm/i915/guc: Add status checks to enable/disable_guc_interrupts

2017-10-13 Thread Sagar Arun Kamble
On 10/12/2017 11:47 AM, Sagar Arun Kamble wrote: On 10/12/2017 11:20 AM, Sagar Arun Kamble wrote: On 10/11/2017 8:50 PM, Michal Wajdeczko wrote: On Wed, 11 Oct 2017 10:53:58 +0200, Sagar Arun Kamble wrote: GuC interrupts are currently enabled by Logging and disabled in different scena

[Intel-gfx] ✗ Fi.CI.BAT: warning for HAX: Do not restore mode through fbcon

2017-10-13 Thread Patchwork
== Series Details == Series: HAX: Do not restore mode through fbcon URL : https://patchwork.freedesktop.org/series/31893/ State : warning == Summary == Series 31893v1 HAX: Do not restore mode through fbcon https://patchwork.freedesktop.org/api/1.0/series/31893/revisions/1/mbox/ Test chamelium

Re: [Intel-gfx] [PATCH i-g-t 1/8] lib/igt_dummyload: add igt_cork

2017-10-13 Thread Chris Wilson
Quoting Chris Wilson (2017-10-12 23:57:38) > Quoting Daniele Ceraolo Spurio (2017-10-12 23:27:27) > > +igt_cork_t *igt_cork_new(int fd); > > _new does not imply plugged. > > > +void igt_cork_signal(igt_cork_t *cork); > > When have you signaled a cork? > > > +void igt_cork_free(int fd, igt_cork_

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Fix DP_AUX_CH_CTL_TIME_OUT naming

2017-10-13 Thread Jani Nikula
On Thu, 12 Oct 2017, Rodrigo Vivi wrote: > On Thu, Oct 12, 2017 at 09:30:36PM +, James Ausmus wrote: >> Rename DP_AUX_CH_CTL_TIME_OUT_1600us to DP_AUX_CH_CTL_TIME_OUT_MAX, as >> the meaning of the (3 << 26) value varies per platform, but it's always the >> maximum timeout for that platform. Pr

Re: [Intel-gfx] [PATCH v4] drm/i915: enable to read CSB and CSB write pointer from HWSP in GVT-g VM

2017-10-13 Thread Joonas Lahtinen
On Fri, 2017-10-13 at 09:17 +0800, Li, Weinan Z wrote: > On 10/12/2017 4:16 PM, Chris Wilson wrote: > > Quoting Weinan Li (2017-10-12 07:50:08) > > > @@ -398,6 +395,9 @@ static bool csb_force_mmio(struct drm_i915_private > > > *i915) > > > if (intel_vtd_active()) > > >

Re: [Intel-gfx] [PATCH v5] drm/i915: enable to read CSB and CSB write pointer from HWSP in GVT-g VM

2017-10-13 Thread Chris Wilson
Quoting Weinan Li (2017-10-13 02:46:16) > Let GVT-g VM read the CSB and CSB write pointer from virtual HWSP, not all > the host support this feature, need to check the BIT(3) of caps in PVINFO. > > v3 : Remove unnecessary comments. > v4 : Separate VM enable patch with GVT-g implementation patch du

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915/guc : Unifying seq_puts messages for feature support

2017-10-13 Thread Sagar Arun Kamble
Keep subject as "drm/i915" as this is generic change. Also I saw i915_runtime_pm_status debugfs output not updated. Could you please check. On 10/11/2017 12:02 AM, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages in debugfs to the simplest one for feature support. v2: Clar

Re: [Intel-gfx] [PATCH v4 1/3] drm: Add retries for lspcon mode detection

2017-10-13 Thread Jani Nikula
On Thu, 12 Oct 2017, Shashank Sharma wrote: > From the CI builds, its been observed that during a driver > reload/insert, dp dual mode read function sometimes fails to > read from LSPCON device over i2c-over-aux channel. > > This patch: > - adds some delay and few retries, allowing a scope for the

Re: [Intel-gfx] [PATCH v3 0/3] Various retries for LSPCON

2017-10-13 Thread Jani Nikula
On Tue, 10 Oct 2017, "Sharma, Shashank" wrote: > Regards > > Shashank > > > On 10/10/2017 3:42 PM, Saarinen, Jani wrote: >> Hi, >> >>> -Original Message- >>> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf >>> Of Shashank Sharma >>> Sent: tiistai 10. lokakuuta 20

Re: [Intel-gfx] [PATCH v2 00/13] Firmware code reorg

2017-10-13 Thread Joonas Lahtinen
On Thu, 2017-10-12 at 19:16 +, Michal Wajdeczko wrote: > Suggested-by: Joonas Lahtinen Suggested-by, Reported-by and other merit tags should be in the patches where they get recorded when the series is merged. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporatio

Re: [Intel-gfx] [PATCH v6 2/3] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-10-13 Thread Sagar Arun Kamble
On 10/11/2017 12:02 AM, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need i915_modparams.enable_guc_submission=1, we also need enable_guc_loading=1. We also need enable_guc_loading=1 when we

Re: [Intel-gfx] [PATCH v3 07/14] drm/i915/guc: Move firmware size check out of generic code

2017-10-13 Thread Michal Wajdeczko
On Fri, 13 Oct 2017 08:49:22 +0200, Sagar Arun Kamble wrote: On 10/13/2017 4:24 AM, Michal Wajdeczko wrote: Checking GuC firmware size can be done in GuC specific code right before DMA copy as it is unlikely to fail anyway. v2: rebased Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamb

Re: [Intel-gfx] [PATCH v3 08/14] drm/i915/guc: Pick better place for Guc final status message

2017-10-13 Thread Michal Wajdeczko
On Fri, 13 Oct 2017 08:54:14 +0200, Sagar Arun Kamble wrote: On 10/13/2017 4:24 AM, Michal Wajdeczko wrote: Guc status message printed right after firmware upload may be too optimistic, as we may fail on subsequent steps. Move that message to the end of intel_uc_init_hw where we know the s

Re: [Intel-gfx] [PATCH v3 08/14] drm/i915/guc: Pick better place for Guc final status message

2017-10-13 Thread Michal Wajdeczko
On Fri, 13 Oct 2017 08:54:14 +0200, Sagar Arun Kamble wrote: On 10/13/2017 4:24 AM, Michal Wajdeczko wrote: Guc status message printed right after firmware upload may be too optimistic, as we may fail on subsequent steps. Move that message to the end of intel_uc_init_hw where we know the s

Re: [Intel-gfx] [PATCH v3 08/14] drm/i915/guc: Pick better place for Guc final status message

2017-10-13 Thread Sagar Arun Kamble
On 10/13/2017 3:44 PM, Michal Wajdeczko wrote: On Fri, 13 Oct 2017 08:54:14 +0200, Sagar Arun Kamble wrote: On 10/13/2017 4:24 AM, Michal Wajdeczko wrote: Guc status message printed right after firmware upload may be too optimistic, as we may fail on subsequent steps. Move that message t

[Intel-gfx] [PATCH] drm/i915: Get rid of hardcoded pipes

2017-10-13 Thread Mika Kahola
Favor for_each_pipe() macro when looping through pipes. This patch is related to miscellenous fixes to reduce dependency on I915_MAX_PIPES. https://patchwork.freedesktop.org/series/30336/ Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp_mst.c | 14 -- 1 file changed, 8

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Add .get_hw_state() method for planes

2017-10-13 Thread Ville Syrjälä
On Thu, Oct 12, 2017 at 08:59:20PM +0200, Daniel Vetter wrote: > On Wed, Oct 11, 2017 at 07:04:47PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add a .get_hw_state() method for planes, returning true or false > > depending on whether the plane is enabled. Use it to rewrite the > >

Re: [Intel-gfx] [PATCH 3/9] drm/i915: s/enum plane/enum old_plane_id/

2017-10-13 Thread Ville Syrjälä
On Thu, Oct 12, 2017 at 09:06:24PM +0200, Daniel Vetter wrote: > On Wed, Oct 11, 2017 at 07:04:49PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Rename enum plane to enum old_plane_id to make it clear that it only > > applies to pre-SKL platforms. > > > > v2: Reorder patches > >

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Nuke ironlake_get_initial_plane_config()

2017-10-13 Thread Ville Syrjälä
On Thu, Oct 12, 2017 at 09:17:40PM +0200, Daniel Vetter wrote: > On Wed, Oct 11, 2017 at 07:04:52PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The only relevant difference between i9xx_get_initial_plane_config() and > > ironlake_get_initial_plane_config() is the HSW/BDW TILEOFF h

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Switch fbc over to for_each_new_intel_plane_in_state()

2017-10-13 Thread Ville Syrjälä
On Thu, Oct 12, 2017 at 09:21:07PM +0200, Daniel Vetter wrote: > On Wed, Oct 11, 2017 at 07:04:53PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Stop using the old for_each_intel_plane_in_state() type iteration > > macro and replace it with for_each_new_intel_plane_in_state(). > >

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Nuke crtc->plane

2017-10-13 Thread Ville Syrjälä
On Thu, Oct 12, 2017 at 09:38:20PM +0200, Daniel Vetter wrote: > On Wed, Oct 11, 2017 at 07:04:54PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Eliminate crtc->plane since it's pretty much a layering violation. > > We can always get the plane via crtc->primary if we actually need

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Get rid of hardcoded pipes

2017-10-13 Thread Patchwork
== Series Details == Series: drm/i915: Get rid of hardcoded pipes URL : https://patchwork.freedesktop.org/series/31900/ State : success == Summary == Series 31900v1 drm/i915: Get rid of hardcoded pipes https://patchwork.freedesktop.org/api/1.0/series/31900/revisions/1/mbox/ fi-bdw-5557u t

[Intel-gfx] [PATCH i-g-t 1/4] lib: Extract helpers for determining submission method

2017-10-13 Thread Michał Winiarski
Couple of tests are using either determining submission method, or pretty printing. Let's move those to helpers in lib. Signed-off-by: Michał Winiarski Cc: Arkadiusz Hiler Cc: Chris Wilson Cc: Katarzyna Dec Cc: Petri Latvala --- lib/igt_aux.c | 18 + lib/igt_aux.h

[Intel-gfx] [PATCH i-g-t v2 2/4] lib/i915: Extract helpers for determining scheduler capabilities

2017-10-13 Thread Michał Winiarski
Couple of tests are using either determining scheduler capabilities or pretty printing. Let's move those to helpers in lib. We can also keep the value obtained from getparam static. v2: Break the trend of expanding ioctl_wrappers Signed-off-by: Michał Winiarski Cc: Arkadiusz Hiler Cc: Chris Wil

[Intel-gfx] [PATCH i-g-t v2 4/4] lib/i915: Extract context priority setparam to a helper

2017-10-13 Thread Michał Winiarski
Another example of something that is used across different tests, and should be moved to lib. v2: Break the trend of expanding ioctl_wrappers Signed-off-by: Michał Winiarski Cc: Arkadiusz Hiler Cc: Chris Wilson Cc: Katarzyna Dec Cc: Petri Latvala --- lib/i915/gem_context.c| 40 +

[Intel-gfx] [PATCH i-g-t 3/4] lib/i915: Move context related helpers to lib/i915/gem_context

2017-10-13 Thread Michał Winiarski
We'd like to make ioctl_wrappers a bit thinner, and we plan to add new helpers in the following patch. Let's move context related helpers before adding more content. Signed-off-by: Michał Winiarski Cc: Arkadiusz Hiler Cc: Chris Wilson Cc: Katarzyna Dec Cc: Petri Latvala --- .../intel-gpu-too

[Intel-gfx] [PATCH v4 04/14] drm/i915/guc: Move doc near related definitions

2017-10-13 Thread Michal Wajdeczko
After GuC code reorg some documentation was left in wrong place. Move it closer to corresponding definitions. v2: use consistent name for the GuC (Sagar) Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Reviewed-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_gu

[Intel-gfx] [PATCH v4 08/14] drm/i915/guc: Pick better place for Guc final status message

2017-10-13 Thread Michal Wajdeczko
GuC status message printed right after firmware upload may be too optimistic, as we may fail on subsequent steps. Move that message to the end of intel_uc_init_hw where we know the status for sure. v2: use dev_info (Chris) Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Sagar Arun Kambl

[Intel-gfx] [PATCH v4 06/14] drm/i915/guc: Reorder functions in intel_guc_fw.c

2017-10-13 Thread Michal Wajdeczko
Functions should be defined in their use order. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_guc_fw.c | 81 +++-- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v4 02/14] drm/i915/guc: Move GuC boot param initialization out of xfer

2017-10-13 Thread Michal Wajdeczko
We want to keep ucode xfer functions separate from other initialization. Once separated, add explicit forcewake. v2: use BLITTER domain only and add comment (Daniele) Suggested-by: Joonas Lahtinen Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Cc: Daniele Ceraolo Sp

[Intel-gfx] [PATCH v4 05/14] drm/i915/guc: Rename intel_guc_loader.c to intel_guc_fw.c

2017-10-13 Thread Michal Wajdeczko
Remaining functions in intel_guc_loader.c were focused around GuC firmware. Rename them to match object-verb pattern and rename file itself. Suggested-by: Joonas Lahtinen Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Reviewed-by: Chris Wilson --- drivers/gpu/drm/i

[Intel-gfx] [PATCH v4 11/14] drm/i915: Update DMC firmware load error messages

2017-10-13 Thread Michal Wajdeczko
Some of the error messages from DMC load were too generic and may be confusing for the user. Lets explicitly add DMC words there. Also as homepage of DMC firmware is same as for the GuC and Huc, lets reuse URL definition. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Imre Deak Cc: Mika K

[Intel-gfx] [PATCH v4 00/14] Firmware code reorg

2017-10-13 Thread Michal Wajdeczko
CC: Joonas Lahtinen Cc: Chris Wilson v1: was sent with wrong prefix "P v4" v2: apply review comments from Chris/Daniele v3: restore DRM_WARN, add firmware url v4: update DMC messages, drop CI HAX Michal Wajdeczko (14): drm/i915: Move intel_guc_wopcm_size to intel_guc.c drm/i915/guc: Move Gu

[Intel-gfx] [PATCH v4 03/14] drm/i915/guc: Small fixups post code move

2017-10-13 Thread Michal Wajdeczko
Existing code needs some style fixes. To avoid polluting pure move patch, do it now as separate step. Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_guc.c | 11 ++- drivers/gpu/drm/i915/intel_gu

[Intel-gfx] [PATCH v4 14/14] drm/i915/huc: Move fw select function

2017-10-13 Thread Michal Wajdeczko
No functional change. Just place the function closer to related definitions. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_huc.c | 72 1 file changed, 36 insertions(+)

[Intel-gfx] [PATCH v4 07/14] drm/i915/guc: Move firmware size check out of generic code

2017-10-13 Thread Michal Wajdeczko
Checking GuC firmware size can be done in GuC specific code right before DMA copy as it is unlikely to fail anyway. v2: rebased Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamble Cc: Joonas Lahtinen Reviewed-by: Sagar Arun Kamble #1 --- drivers/gpu/drm/i915/intel_guc_fw.c | 7 ++- dri

[Intel-gfx] [PATCH v4 10/14] drm/i915/uc: Add message with firmware url

2017-10-13 Thread Michal Wajdeczko
In case of firmware fetch failure we should help user find latest firmware. Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_uc_fw.c | 2 ++ drivers/gpu/drm/i915/intel_uc_fw.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drive

[Intel-gfx] [PATCH v4 13/14] drm/i915/guc: Update Guc messages on load failure

2017-10-13 Thread Michal Wajdeczko
In case of GuC firmware loading failure we were reporting DRM_ERROR also for case when GuC loading was not strictly required. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_uc.c | 9 +

[Intel-gfx] [PATCH v4 12/14] drm/i915/uc: Unify firmware loading

2017-10-13 Thread Michal Wajdeczko
Firmware loading for GuC and HuC are similar. Move common code into generic function for maximum reuse. v2: change message levels (Chris) Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Cc: Anusha Srivatsa Cc: Sujaritha Sundaresan Cc: Chris Wilson Reviewed-by: Chri

[Intel-gfx] [PATCH v4 09/14] drm/i915/uc: Improve debug messages in firmware fetch

2017-10-13 Thread Michal Wajdeczko
Time to remove less important info and make messages clear and consistent. v2: change some message levels (Chris) v3: restore DRM_WARN (Chris) Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamble Cc: Joonas Lahtinen Cc: Chris Wilson Reviewed-by: Chris Wilson #2 --- drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH v4 01/14] drm/i915: Move intel_guc_wopcm_size to intel_guc.c

2017-10-13 Thread Michal Wajdeczko
Function intel_guc_wopcm_size didn't fit well in the old place. With this move upcoming cleanup will be simpler. Suggested-by: Joonas Lahtinen Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_guc.c| 11

[Intel-gfx] ✗ Fi.CI.IGT: failure for HAX: Do not restore mode through fbcon

2017-10-13 Thread Patchwork
== Series Details == Series: HAX: Do not restore mode through fbcon URL : https://patchwork.freedesktop.org/series/31893/ State : failure == Summary == Test kms_chv_cursor_fail: Subgroup pipe-C-256x256-bottom-edge: pass -> INCOMPLETE (shard-hsw) Subgroup p

Re: [Intel-gfx] [IGT PATCH 1/2] aux: Suspend signal helper for shell commands

2017-10-13 Thread Imre Deak
On Thu, Oct 12, 2017 at 02:52:40PM +0100, Chris Wilson wrote: > Quoting Imre Deak (2017-10-12 14:22:06) > > The clone() system call with a larger executable (like /bin/sh) may have > > One thing to note it's not the target executable size that's > problematic, it's ours. It is our mm that is being

Re: [Intel-gfx] [PATCH i-g-t v2 0/6] Drop tests for object creation from stolen

2017-10-13 Thread Joonas Lahtinen
On Thu, 2017-10-12 at 15:29 -0700, Daniele Ceraolo Spurio wrote: > Respin with review fixes for meson build and gem_concurrent_all. > I'll send the new tests for pread/pwrite suggested by Chris as a > separated series as they depend on the other cleanup I've sent > and this series can potentially b

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib: Extract helpers for determining submission method

2017-10-13 Thread Katarzyna Dec
On Fri, Oct 13, 2017 at 01:00:17PM +0200, Michał Winiarski wrote: > Couple of tests are using either determining submission method, or > pretty printing. Let's move those to helpers in lib. > > Signed-off-by: Michał Winiarski > Cc: Arkadiusz Hiler > Cc: Chris Wilson >> Cc: Katarzyna Dec Rev

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] lib: Extract helpers for determining submission method

2017-10-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] lib: Extract helpers for determining submission method URL : https://patchwork.freedesktop.org/series/31904/ State : success == Summary == IGT patchset tested on top of latest successful build 58616272b23efce1e62a3ee0d37e13de6ffc012f igt

Re: [Intel-gfx] [PATCH i-g-t v2 4/4] lib/i915: Extract context priority setparam to a helper

2017-10-13 Thread Katarzyna Dec
On Fri, Oct 13, 2017 at 01:00:20PM +0200, Michał Winiarski wrote: > Another example of something that is used across different tests, and > should be moved to lib. > > v2: Break the trend of expanding ioctl_wrappers > > Signed-off-by: Michał Winiarski > Cc: Arkadiusz Hiler > Cc: Chris Wilson >

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib: Extract helpers for determining submission method

2017-10-13 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-13 12:00:17) > Couple of tests are using either determining submission method, or > pretty printing. Let's move those to helpers in lib. > > Signed-off-by: Michał Winiarski > Cc: Arkadiusz Hiler > Cc: Chris Wilson > Cc: Katarzyna Dec > Cc: Petri Latvala > ---

Re: [Intel-gfx] [PATCH i-g-t 3/4] lib/i915: Move context related helpers to lib/i915/gem_context

2017-10-13 Thread Katarzyna Dec
Reviewed-by:Katarzyna Dec , Cheers, Kasia ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t v2 2/4] lib/i915: Extract helpers for determining scheduler capabilities

2017-10-13 Thread Katarzyna Dec
Reviewed-by: Katarzyna Dec Cheers, Kasia ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t v2 2/2] aux: Use IGT version of system() call to run rtcwake

2017-10-13 Thread Imre Deak
The clone() system call has difficulty to make progress if interrupted frequently by the signal helper process. At least on an APL, like in the Bugzilla ticket below, this can introduce minutes of overhead to a single system() call (leading to a global CI timeout). To get rid of the overhead suspen

[Intel-gfx] [PATCH i-g-t v2 1/2] aux: Suspend signal helper for shell commands

2017-10-13 Thread Imre Deak
The clone() system call with a larger executable (like /bin/sh) may have difficulty to make progress on some platforms if interrupted frequently. So suspend the signal helper process for the duration of the syscall. This is needed to solve an actual problem by the next patch. v2: - Clarify/fix cod

Re: [Intel-gfx] [PATCH i-g-t 3/4] lib/i915: Move context related helpers to lib/i915/gem_context

2017-10-13 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-13 12:00:19) > We'd like to make ioctl_wrappers a bit thinner, and we plan to add new > helpers in the following patch. Let's move context related helpers before > adding more content. > > Signed-off-by: Michał Winiarski > Cc: Arkadiusz Hiler > Cc: Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t v2 4/4] lib/i915: Extract context priority setparam to a helper

2017-10-13 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-13 12:00:20) > Another example of something that is used across different tests, and > should be moved to lib. > > v2: Break the trend of expanding ioctl_wrappers > > Signed-off-by: Michał Winiarski > Cc: Arkadiusz Hiler > Cc: Chris Wilson > Cc: Katarzyna Dec

[Intel-gfx] ✓ Fi.CI.BAT: success for Firmware code reorg (rev3)

2017-10-13 Thread Patchwork
== Series Details == Series: Firmware code reorg (rev3) URL : https://patchwork.freedesktop.org/series/31846/ State : success == Summary == Series 31846v3 Firmware code reorg https://patchwork.freedesktop.org/api/1.0/series/31846/revisions/3/mbox/ fi-bdw-5557u total:289 pass:268 dwarn:0

Re: [Intel-gfx] [PATCH v4 10/14] drm/i915/uc: Add message with firmware url

2017-10-13 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-13 12:11:33) > diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h > b/drivers/gpu/drm/i915/intel_uc_fw.h > index 5c01849..1d580fa 100644 > --- a/drivers/gpu/drm/i915/intel_uc_fw.h > +++ b/drivers/gpu/drm/i915/intel_uc_fw.h > @@ -27,6 +27,8 @@ > > struct drm_i915_p

Re: [Intel-gfx] [PATCH v4 11/14] drm/i915: Update DMC firmware load error messages

2017-10-13 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-13 12:11:34) > Some of the error messages from DMC load were too generic and > may be confusing for the user. Lets explicitly add DMC words there. > Also as homepage of DMC firmware is same as for the GuC and Huc, > lets reuse URL definition. > > Signed-off-by: Mi

Re: [Intel-gfx] [PATCH v4 10/14] drm/i915/uc: Add message with firmware url

2017-10-13 Thread Chris Wilson
Quoting Chris Wilson (2017-10-13 12:50:53) > Quoting Michal Wajdeczko (2017-10-13 12:11:33) > > diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h > > b/drivers/gpu/drm/i915/intel_uc_fw.h > > index 5c01849..1d580fa 100644 > > --- a/drivers/gpu/drm/i915/intel_uc_fw.h > > +++ b/drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH igt 1/2] lib: Ask the kernel to quiesce the GPU

2017-10-13 Thread Chris Wilson
Since the introduction of debugfs/i915_drop_caches, we have offered the ability to wait upon all outstanding batches. This is more efficient and less error prone (one example is the use of context priorities, we have to idle at the lowest in order not to jump over any low priority tasks we want to

[Intel-gfx] [PATCH igt 2/2] synchax

2017-10-13 Thread Chris Wilson
--- tests/gem_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/gem_sync.c b/tests/gem_sync.c index c9e2f014..e178db25 100644 --- a/tests/gem_sync.c +++ b/tests/gem_sync.c @@ -876,6 +876,8 @@ igt_main } for (e = intel_execution_engines; e->name; e++) { +

[Intel-gfx] [PATCH i-g-t 1/2] tests: Clean up igt_skip_on_simulation() uses

2017-10-13 Thread Arkadiusz Hiler
General update to reflect current state of things. Signed-off-by: Arkadiusz Hiler --- tests/core_prop_blob.c | 2 -- tests/gem_busy.c | 4 ++-- tests/gem_close_race.c | 2 -- tests/gem_cpu_reloc.c | 1 - tests/gem_ctx_exec.c | 4 ++-- tests/gem_ctx_switch.c | 3 +

[Intel-gfx] [PATCH i-g-t 2/2] tests/intel-ci: Remove fast-feedback-simulation.testlist

2017-10-13 Thread Arkadiusz Hiler
Signed-off-by: Arkadiusz Hiler --- tests/intel-ci/Makefile.am | 1 - tests/intel-ci/README| 7 -- tests/intel-ci/fast-feedback-simulation.testlist | 91 3 files changed, 99 deletions(-) delete mode 100644 tests/intel-ci

[Intel-gfx] [igt RFC 3/3] lib: Enable automatic ftrace dumping for suspend failures

2017-10-13 Thread Chris Wilson
Supplement dmesg with the function call graph to try and help identify why the suspend failed. On the other hand, it may be very noisy and perturb the system due to its overhead... Signed-off-by: Chris Wilson --- lib/igt_aux.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-

[Intel-gfx] [igt RFC 2/3] lib: Add hooks for enabling ftrace

2017-10-13 Thread Chris Wilson
If the kernel has tracing support builtin, we can enable around troublesome tests to obtain greater detail from the kernel that may prove invaluable in debugging the problem. Signed-off-by: Chris Wilson --- lib/Makefile.sources | 2 + lib/igt_core.c | 5 ++ lib/igt_ftrace.c | 181 +

[Intel-gfx] [igt RFC 1/3] lib/debugfs: Make is_mountpoint() non-fatal

2017-10-13 Thread Chris Wilson
is_mountpoint() asserts rather than report the error. Normally this isn't a problem, except for atypical selftests. Signed-off-by: Chris Wilson --- lib/igt_debugfs.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/ig

Re: [Intel-gfx] [PATCH i-g-t v2 0/6] Drop tests for object creation from stolen

2017-10-13 Thread Petri Latvala
On Fri, Oct 13, 2017 at 02:22:26PM +0300, Joonas Lahtinen wrote: > On Thu, 2017-10-12 at 15:29 -0700, Daniele Ceraolo Spurio wrote: > > Respin with review fixes for meson build and gem_concurrent_all. > > I'll send the new tests for pread/pwrite suggested by Chris as a > > separated series as they

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] aux: Suspend signal helper for shell commands

2017-10-13 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] aux: Suspend signal helper for shell commands URL : https://patchwork.freedesktop.org/series/31908/ State : failure == Summary == IGT patchset tested on top of latest successful build 58616272b23efce1e62a3ee0d37e13de6ffc012f igt/gem_e

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] lib: Ask the kernel to quiesce the GPU

2017-10-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib: Ask the kernel to quiesce the GPU URL : https://patchwork.freedesktop.org/series/31909/ State : failure == Summary == IGT patchset build failed on latest successful build 58616272b23efce1e62a3ee0d37e13de6ffc012f igt/gem_eio: Check ha

Re: [Intel-gfx] [igt RFC 2/3] lib: Add hooks for enabling ftrace

2017-10-13 Thread Chris Wilson
Quoting Chris Wilson (2017-10-13 13:02:58) > If the kernel has tracing support builtin, we can enable around > troublesome tests to obtain greater detail from the kernel that may > prove invaluable in debugging the problem. Michał pointed out that there is a ftrace-dump-on-oops flag, which could v

[Intel-gfx] [PATCH igt 1/2] lib: Ask the kernel to quiesce the GPU

2017-10-13 Thread Chris Wilson
Since the introduction of debugfs/i915_drop_caches, we have offered the ability to wait upon all outstanding batches. This is more efficient and less error prone (one example is the use of context priorities, we have to idle at the lowest in order not to jump over any low priority tasks we want to

[Intel-gfx] [PATCH igt 2/2] synchax

2017-10-13 Thread Chris Wilson
--- tests/gem_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/gem_sync.c b/tests/gem_sync.c index c9e2f014..41cfe6c1 100644 --- a/tests/gem_sync.c +++ b/tests/gem_sync.c @@ -876,6 +876,8 @@ igt_main } for (e = intel_execution_engines; e->name; e++) { +

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] tests: Clean up igt_skip_on_simulation() uses

2017-10-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] tests: Clean up igt_skip_on_simulation() uses URL : https://patchwork.freedesktop.org/series/31910/ State : failure == Summary == IGT patchset tested on top of latest successful build 58616272b23efce1e62a3ee0d37e13de6ffc012f igt/gem_eio:

Re: [Intel-gfx] [igt RFC 1/3] lib/debugfs: Make is_mountpoint() non-fatal

2017-10-13 Thread Ville Syrjälä
On Fri, Oct 13, 2017 at 01:02:57PM +0100, Chris Wilson wrote: > is_mountpoint() asserts rather than report the error. Normally this > isn't a problem, except for atypical selftests. > > Signed-off-by: Chris Wilson Reviewed-by: Ville Syrjälä > --- > lib/igt_debugfs.c | 33 -

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFC,1/3] lib/debugfs: Make is_mountpoint() non-fatal

2017-10-13 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/3] lib/debugfs: Make is_mountpoint() non-fatal URL : https://patchwork.freedesktop.org/series/31911/ State : success == Summary == IGT patchset tested on top of latest successful build 58616272b23efce1e62a3ee0d37e13de6ffc012f igt/gem_ei

[Intel-gfx] [PATCH 1/2] drm/i915: Parse DSI backlight/cabc ports.

2017-10-13 Thread Madhav Chauhan
This patch parse DSI backlight/cabc ports info from VBT and save them inside local structure. This saved info can be directly used while initializing DSI for different platforms instead of parsing for each platform. V2: Changes: - Typo fix in commit message. - Move up newly added port vari

[Intel-gfx] [PATCH 2/2] drm/i915: Use existing DSI backlight ports info

2017-10-13 Thread Madhav Chauhan
This patch re-use already parsed DSI backlight/cabc ports info for saving it inside struct intel_dsi rather than parsing it at the time of DSI initialization. V2: Remove backlight and cabc variable initialization (Jani N). Reviewed-by: Jani Nikula Signed-off-by: Madhav Chauhan --- drivers/gpu/

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Get rid of hardcoded pipes

2017-10-13 Thread Patchwork
== Series Details == Series: drm/i915: Get rid of hardcoded pipes URL : https://patchwork.freedesktop.org/series/31900/ State : success == Summary == Test kms_setmode: Subgroup basic: fail -> PASS (shard-hsw) fdo#99912 Test kms_atomic_transition: Sub

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] lib: Ask the kernel to quiesce the GPU

2017-10-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib: Ask the kernel to quiesce the GPU URL : https://patchwork.freedesktop.org/series/31913/ State : failure == Summary == IGT patchset tested on top of latest successful build 58616272b23efce1e62a3ee0d37e13de6ffc012f igt/gem_eio: Check h

[Intel-gfx] [PATCH 1/2] drm/i915: Keep the rings stopped until they have been re-initialized

2017-10-13 Thread Chris Wilson
Before modifying the ring register (RING_START, HEAD, TAIL, CTL) we first make sure it is stopped (or else the hw may not resample the registers). However, we do not need to let the hw restart until after we have reprogrammed all the rings. This should help prevent situations where pending operatio

[Intel-gfx] [PATCH 2/2] drm/i915: Always stop the rings before a missing GPU reset

2017-10-13 Thread Chris Wilson
Always try to stop the rings, even if the GPU reset itself has been disabled (via modparam i915.reset). This should at least stop the hw from spinning in the background consuming resources (e.g. power and memory bandwidth) letting the system rest-in-peace. References: https://bugs.freedesktop.org/

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Keep the rings stopped until they have been re-initialized

2017-10-13 Thread Mika Kuoppala
Chris Wilson writes: > Before modifying the ring register (RING_START, HEAD, TAIL, CTL) we > first make sure it is stopped (or else the hw may not resample the > registers). However, we do not need to let the hw restart until after we > have reprogrammed all the rings. This should help prevent si

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] lib: Extract helpers for determining submission method

2017-10-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] lib: Extract helpers for determining submission method URL : https://patchwork.freedesktop.org/series/31904/ State : success == Summary == Test kms_setmode: Subgroup basic: fail -> PASS (shard-hsw) fdo

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Always stop the rings before a missing GPU reset

2017-10-13 Thread Mika Kuoppala
Chris Wilson writes: > Always try to stop the rings, even if the GPU reset itself has been > disabled (via modparam i915.reset). This should at least stop the hw > from spinning in the background consuming resources (e.g. power and > memory bandwidth) letting the system rest-in-peace. > > Referen

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Parse DSI backlight/cabc ports.

2017-10-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Parse DSI backlight/cabc ports. URL : https://patchwork.freedesktop.org/series/31914/ State : success == Summary == Series 31914v1 series starting with [1/2] drm/i915: Parse DSI backlight/cabc ports. https://patchwork.freedeskt

[Intel-gfx] [PATCH v2 00/10] drm/i915: Plane assert/readout cleanups etc.

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Respin of the plane readout/sanitation series. I tried to address all of Daniel's review comments, and tossed in the requested plane state verification patch on top. Also dropped the primary plane windowing patch for now. Entire series available here: git://github.com/vsyrjal

[Intel-gfx] [PATCH v2 01/10] drm/i915: Add .get_hw_state() method for planes

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Add a .get_hw_state() method for planes, returning true or false depending on whether the plane is enabled. Use it to rewrite the plane enabled/disabled asserts in platform agnostic fashion. We do lose the pre-gen4 plane<->pipe mapping checks, but since we're supposed sanitiz

[Intel-gfx] [PATCH v2 04/10] drm/i915: Use enum i9xx_plane_id for the .get_fifo_size() hooks

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Replace the 0 and 1 with PLANE_A and PLANE_B in the pre-g4x wm code. v2: s/old_plane_id/i9xx_plane_id/ (Daniel) Cc: Daniel Vetter Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/intel_pm.c | 36 ++

[Intel-gfx] [PATCH v3 02/10] drm/i915: Redo plane sanitation during readout

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Unify the plane disabling during state readout by pulling the code into a new helper intel_plane_disable_noatomic(). We'll also read out the state of all planes, so that we know which planes really need to be diabled. Additonally we change the plane<->pipe mapping sanitation

[Intel-gfx] [PATCH v3 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Rename enum plane to enum i9xx_plane_id to make it clear that it only applies to pre-SKL platforms. enum i9xx_plane_id is a global identifier, whereas enum plane_id is per-pipe. We need the old global identifier to index the primary plane (and the pre-g4x sprite C if we ever

[Intel-gfx] [PATCH 06/10] drm/i915: Nuke ironlake_get_initial_plane_config()

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä The only relevant difference between i9xx_get_initial_plane_config() and ironlake_get_initial_plane_config() is the HSW/BDW TILEOFF handling. Add that to i9xx_get_initial_plane_config() and nuke ironlake_get_initial_plane_config(). Signed-off-by: Ville Syrjälä Reviewed-by: D

[Intel-gfx] [PATCH 10/10] drm/i915: Add rudimentary plane state verification

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Check that the planes on each crtc undergoing a modeset are in the state we expect them to be. For now we can only check whether each plane is correctly enabled or disabled. In the future we may want to expand the plane state readout to support a more through verification. Cc

[Intel-gfx] [PATCH v3 05/10] drm/i915: Cleanup enum pipe/enum plane_id/enum i9xx_plane_id in initial fb readout

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Use enum pipe, enum plane_id, and enum i9xx_plane_id consistently in the initial framebuffe readout. v2: Use old_plane_id in the ilk code v3: s/old_plane_id/i9xx_plane_id/ (Daniel) Cc: Daniel Vetter Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter --- drivers/gpu/

[Intel-gfx] [PATCH v2 08/10] drm/i915: Nuke crtc->plane

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Eliminate crtc->plane since it's pretty much a layering violation. We can always get the plane via crtc->primary if we actually need it. The only ugly thing left is plane_to_crtc_mapping[], but that's still needed by the pre-g4x watermark code. v2: Removed a misplaced commen

[Intel-gfx] [PATCH 07/10] drm/i915: Switch fbc over to for_each_new_intel_plane_in_state()

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Stop using the old for_each_intel_plane_in_state() type iteration macro and replace it with for_each_new_intel_plane_in_state(). And similarly replace drm_atomic_get_existing_crtc_state() with intel_atomic_get_new_crtc_state(). Switch over to intel_ types as well to make the c

[Intel-gfx] [PATCH 09/10] drm/i915: Use plane->get_hw_state() for initial plane fb readout

2017-10-13 Thread Ville Syrjala
From: Ville Syrjälä Since we now have a ->get_hw_state() method for planes, let's use that during the initial plane fb readout. Cc: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 30 -- 1 file chan

Re: [Intel-gfx] [PULL] drm-misc-next

2017-10-13 Thread Maarten Lankhorst
Op 12-10-17 om 14:05 schreef Daniel Vetter: > Hi Dave, > > drm-misc-next-2017-10-12: > More 4.15 drm-misc stuff: > > Cross-subsystem Changes: > - bridge cleanup refactor (Benjamin Gaignard) > > Core Changes: > - less surprising atomic iterators (Maarten), fixes an oops introduced > in drm-next >

  1   2   3   >