With the code motion mostly done, convert all the GuC code away
from uint??_t at once (only a couple dozen variables), so that
reading the checkpatch.pl output should actually pinpoint if
a new uint??_t was accidentally introduced.
Signed-off-by: Joonas Lahtinen
Cc: Michal Wajdeczko
Cc: Chris Wi
On Thu, 2017-10-05 at 11:54 -0700, Michel Thierry wrote:
> On 10/5/2017 11:28 AM, Chris Wilson wrote:
> > Quoting Michel Thierry (2017-10-05 19:19:27)
> > > WaDisableCtxRestoreArbitration was only applied for bdw and chv, but
> > > this changed after the code got moved to gen8_emit_bb_start (and, a
== Series Details ==
Series: drm/i915/selftests: fix check for intel IOMMU
URL : https://patchwork.freedesktop.org/series/31426/
State : failure
== Summary ==
Series 31426 revision 1 was fully merged or fully failed: no git log
___
Intel-gfx mailing
On Thu, Oct 05, 2017 at 02:50:13PM +0300, Jani Nikula wrote:
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_crt.c | 3 +++
> drivers/gpu/drm/i915/intel_ddi.c | 18 ++
> drivers/gpu/drm/i915/intel_display.c | 3 ---
> 3 files changed, 21 insertions(+), 3
On 10/6/2017 12:07 PM, Sagar Arun Kamble wrote:
GTT mappings are to be suspended post i915_gem_suspend and display
I think I should say this "post idling GPU and display suspend". Will
update in next rev.
suspend. GPU is reset in i915_gem_suspend. This separated the HW suspend
across reset. T
On Fri, Oct 06, 2017 at 10:07:45AM +0200, Daniel Vetter wrote:
> On Thu, Oct 05, 2017 at 02:50:13PM +0300, Jani Nikula wrote:
> > Signed-off-by: Jani Nikula
> > ---
> > drivers/gpu/drm/i915/intel_crt.c | 3 +++
> > drivers/gpu/drm/i915/intel_ddi.c | 18 ++
> > drivers/gpu
== Series Details ==
Series: i915 PMU and engine busy stats (rev16)
URL : https://patchwork.freedesktop.org/series/27488/
State : failure
== Summary ==
Series 27488v16 i915 PMU and engine busy stats
https://patchwork.freedesktop.org/api/1.0/series/27488/revisions/16/mbox/
Test gem_exec_suspen
== Series Details ==
Series: drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock
URL : https://patchwork.freedesktop.org/series/31430/
State : failure
== Summary ==
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generat
On 05/10/2017 17:24, Daniel Vetter wrote:
On Thu, Oct 05, 2017 at 03:55:19PM +0100, Tvrtko Ursulin wrote:
On 05/10/2017 15:09, Daniel Vetter wrote:
stop_machine is not really a locking primitive we should use, except
when the hw folks tell us the hw is broken and that's the only way to
work a
On Thu, 05 Oct 2017, Kees Cook wrote:
> On Thu, Oct 5, 2017 at 6:45 AM, Joonas Lahtinen
> wrote:
>> On Wed, 2017-10-04 at 17:54 -0700, Kees Cook wrote:
>>> In preparation for unconditionally passing the struct timer_list pointer to
>>> all timer callbacks, switch to using the new timer_setup() an
On Thu, 05 Oct 2017, Daniel Vetter wrote:
> On Thu, Oct 05, 2017 at 01:52:14PM +0300, Jani Nikula wrote:
>> Only assign the hooks once instead of overwriting for DDI.
>>
>> Signed-off-by: Jani Nikula
>
> Reviewed-by: Daniel Vetter
Thanks for the review, pushed patches 1-5 to dinq.
BR,
Jani.
Quoting Daniel Vetter (2017-10-05 17:12:35)
> On Thu, Oct 05, 2017 at 03:30:12PM +0100, Chris Wilson wrote:
> > Quoting Daniel Vetter (2017-10-05 15:09:48)
> > > stop_machine is not really a locking primitive we should use, except
> > > when the hw folks tell us the hw is broken and that's the only
On 10/6/2017 12:41 PM, Joonas Lahtinen wrote:
With the code motion mostly done, convert all the GuC code away
from uint??_t at once (only a couple dozen variables), so that
reading the checkpatch.pl output should actually pinpoint if
a new uint??_t was accidentally introduced.
Signed-off-by: J
== Series Details ==
Series: drm/i915: Use rcu instead of stop_machine
URL : https://patchwork.freedesktop.org/series/31433/
State : success
== Summary ==
Series 31433v1 drm/i915: Use rcu instead of stop_machine
https://patchwork.freedesktop.org/api/1.0/series/31433/revisions/1/mbox/
Test kms
Quoting Chris Wilson (2017-10-05 17:12:25)
> Quoting Matthew Auld (2017-10-05 16:19:00)
> > static inline unsigned int i915_sg_segment_size(void)
> > {
> > unsigned int size = swiotlb_max_segment();
> > @@ -3101,6 +3116,8 @@ intel_info(const struct drm_i915_private *dev_priv)
> > #define
On Fri, Oct 6, 2017 at 10:30 AM, Tvrtko Ursulin
wrote:
>
> On 05/10/2017 17:24, Daniel Vetter wrote:
>>
>> On Thu, Oct 05, 2017 at 03:55:19PM +0100, Tvrtko Ursulin wrote:
>>>
>>>
>>> On 05/10/2017 15:09, Daniel Vetter wrote:
stop_machine is not really a locking primitive we should use, e
With the code motion mostly done, convert all the uC code away
from uint??_t at once (only a couple dozen variables), so that
reading the checkpatch.pl output should actually pinpoint if
a new uint??_t was accidentally introduced.
v2: - Include intel_uc_fw.h too (Sagar)
Signed-off-by: Joonas Laht
Op 05-10-17 om 18:30 schreef Daniel Vetter:
> On Thu, Oct 05, 2017 at 04:15:20PM +0200, Maarten Lankhorst wrote:
>> crtc_state_is_legacy also checks for CTM, which was missing from
>> intel_color_check. By using the same condition for commit and check
>> we reduce the chance of mismatches.
>>
>> Th
On Fri, 06 Oct 2017 10:49:40 +0200, Joonas Lahtinen
wrote:
With the code motion mostly done, convert all the uC code away
from uint??_t at once (only a couple dozen variables), so that
reading the checkpatch.pl output should actually pinpoint if
a new uint??_t was accidentally introduced.
v2
On Thu, 05 Oct 2017, Daniel Vetter wrote:
> On Tue, Oct 03, 2017 at 04:38:04PM +0300, Jani Nikula wrote:
>> Since commit cad37e1910f9 ("dim: auto-add remotes") url_to_remote can't
>> really fail. Same for repo_to_remote when the repo exists. Redirecting
>> their output when the remote isn't there
On Fri, Oct 6, 2017 at 10:42 AM, Chris Wilson wrote:
> Quoting Daniel Vetter (2017-10-05 17:12:35)
>> On Thu, Oct 05, 2017 at 03:30:12PM +0100, Chris Wilson wrote:
>> > Quoting Daniel Vetter (2017-10-05 15:09:48)
>> > > stop_machine is not really a locking primitive we should use, except
>> > > wh
Checking GuC firmware size can be done in GuC specific code
right before DMA copy as it is unlikely to fail anyway.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/intel_guc_loader.c | 14 +++---
drivers/gpu/drm/i915/intel_uc_fw.c
Fix includes order and make sure we only include required headers.
While here, make intel_huc.h header self-contained.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Chris Wilson
---
drivers/gpu/drm/i915/intel_huc.c | 6 --
drivers/gpu/drm/i915/intel_huc.h | 2 ++
2 files changed,
4.14-rc1 gained the fancy new cross-release support in lockdep, which
seems to have uncovered a few more rules about what is allowed and
isn't.
This one here seems to indicate that allocating a work-queue while
holding mmap_sem is a no-go, so let's try to preallocate it.
Of course another way to
stop_machine is not really a locking primitive we should use, except
when the hw folks tell us the hw is broken and that's the only way to
work around it.
This patch tries to address the locking abuse of stop_machine() from
commit 20e4933c478a1ca694b38fa4ac44d99e659941f5
Author: Chris Wilson
Dat
Quoting Daniel Vetter (2017-10-06 10:06:37)
> stop_machine is not really a locking primitive we should use, except
> when the hw folks tell us the hw is broken and that's the only way to
> work around it.
>
> This patch tries to address the locking abuse of stop_machine() from
>
> commit 20e4933c
Quoting Daniel Vetter (2017-10-06 10:06:36)
> 4.14-rc1 gained the fancy new cross-release support in lockdep, which
> seems to have uncovered a few more rules about what is allowed and
> isn't.
>
> This one here seems to indicate that allocating a work-queue while
> holding mmap_sem is a no-go, so
== Series Details ==
Series: drm/i915: Use the crtc_state_is_legacy in intel_color_check
URL : https://patchwork.freedesktop.org/series/31434/
State : failure
== Summary ==
Series 31434 revision 1 was fully merged or fully failed: no git log
___
Int
== Series Details ==
Series: series starting with [CI,1/2] drm-tip: 2017y-10m-05d-06h-44m-09s UTC
integration manifest
URL : https://patchwork.freedesktop.org/series/31437/
State : failure
== Summary ==
Series 31437 revision 1 was fully merged or fully failed: no git log
dim has supported picking up the first match from a list of urls since
61df7dc31c63 ("dim: allow a space separated list of URLs for each repo
in drm_tip_repos"). This way we don't have to have a complicated set of
rules for converting between ssh, git and https protocol URLs, and we
can configure t
This way we can remove more special casing and hard-coding in dim. Until
we have updated dim, this does mean extra fetches of the repos, but that
should be a brief transitional period.
Also add git:// and https:// URLs for drm-tip, although this is likely
not going to be very useful for very many
Quoting Daniel Vetter (2017-10-06 10:06:36)
> 4.14-rc1 gained the fancy new cross-release support in lockdep, which
> seems to have uncovered a few more rules about what is allowed and
> isn't.
>
> This one here seems to indicate that allocating a work-queue while
> holding mmap_sem is a no-go, so
== Series Details ==
Series: drm/i915: Use rcu instead of stop_machine
URL : https://patchwork.freedesktop.org/series/31433/
State : failure
== Summary ==
Test kms_cursor_crc:
Subgroup cursor-size-change:
dmesg-fail -> PASS (shard-hsw) fdo#102886 +5
Test perf:
=== Convert ioctls to interruptible ===
Various ioctl's were using noninterruptible locking. I've converted some of the
most common ones
to use interruptible locking. This will allow programs to be interrupted when
waiting for locking,
instead of being blocked indefinitely.
=== Reworking IGT's k
== Series Details ==
Series: huge gtt pages (rev12)
URL : https://patchwork.freedesktop.org/series/25118/
State : failure
== Summary ==
Series 25118v12 huge gtt pages
https://patchwork.freedesktop.org/api/1.0/series/25118/revisions/12/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-re
== Series Details ==
Series: Guc code reorg cont'd
URL : https://patchwork.freedesktop.org/series/31447/
State : failure
== Summary ==
Series 31447 revision 1 was fully merged or fully failed: no git log
___
Intel-gfx mailing list
Intel-gfx@lists.fr
On Fri, 6 Oct 2017, Daniel Vetter wrote:
> On Fri, Oct 6, 2017 at 10:42 AM, Chris Wilson
> wrote:
> >> > > This patch tries to address the locking snafu from
> >> >
> >> > There's a locking snafu in the code?
The lock problem exists definitely. We did not introduce new dependencies
through the h
On Fri, 6 Oct 2017, Chris Wilson wrote:
> Quoting Daniel Vetter (2017-10-06 10:06:37)
> > stop_machine is not really a locking primitive we should use, except
> > when the hw folks tell us the hw is broken and that's the only way to
> > work around it.
> >
> > This patch tries to address the locki
EXEC_OBJECT_CAPTURE extends the type of buffers we may read during error
capture. Previously we knew that we would only see batch buffers (which
limited the objects to being from gem_create()), but now we need to
check that any buffer the user can create can be read. The first
alternate buffer type
== Series Details ==
Series: drm/i915/execlists: WaDisableCtxRestoreArbitration is only needed in
gen8 (rev2)
URL : https://patchwork.freedesktop.org/series/31452/
State : warning
== Summary ==
Series 31452v2 drm/i915/execlists: WaDisableCtxRestoreArbitration is only
needed in gen8
https://p
If a worker requeues itself, it may switch to a different kworker pool,
which flush_work() considers as complete. To be strict, we then need to
keep flushing the work until it is no longer pending.
References: https://bugs.freedesktop.org/show_bug.cgi?id=102456
Signed-off-by: Chris Wilson
Cc: Mik
On 10/6/2017 2:31 PM, Michal Wajdeczko wrote:
Checking GuC firmware size can be done in GuC specific code
right before DMA copy as it is unlikely to fail anyway.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/intel_guc_loader.c | 14
== Series Details ==
Series: series starting with [1/2] drm/i915: avoid unnecessary call to
intel_hpd_pin_to_port
URL : https://patchwork.freedesktop.org/series/31459/
State : warning
== Summary ==
Series 31459v1 series starting with [1/2] drm/i915: avoid unnecessary call to
intel_hpd_pin_to
Lets not introduce BIT() macro requirement for UAPI for now.
Fixes: 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl")
Signed-off-by: Joonas Lahtinen
Cc: Chris Wilson
---
include/uapi/drm/i915_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/i915_d
Quoting Joonas Lahtinen (2017-10-06 11:45:59)
> Lets not introduce BIT() macro requirement for UAPI for now.
>
> Fixes: 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl")
> Signed-off-by: Joonas Lahtinen
> Cc: Chris Wilson
Yes, this is the simplest solution for now. I mistakenly thought we
Quoting Daniel Vetter (2017-10-06 10:06:37)
> stop_machine is not really a locking primitive we should use, except
> when the hw folks tell us the hw is broken and that's the only way to
> work around it.
>
> This patch tries to address the locking abuse of stop_machine() from
>
> commit 20e4933c
== Series Details ==
Series: drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2)
URL : https://patchwork.freedesktop.org/series/31457/
State : warning
== Summary ==
Series 31457v2 drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice
https://patchwork.freedesktop.org/api/1.0/series/31457/
On Fri, Oct 06, 2017 at 11:06:37AM +0200, Daniel Vetter wrote:
> I pondered whether we should annotate engine->submit_request as __rcu
> and use rcu_assign_pointer and rcu_dereference on it. But the reason
> behind those is to make sure the compiler/cpu barriers are there for
> when you have an ac
On Fri, 2017-10-06 at 10:53 +0200, Michal Wajdeczko wrote:
> On Fri, 06 Oct 2017 10:49:40 +0200, Joonas Lahtinen
> wrote:
>
> > With the code motion mostly done, convert all the uC code away
> > from uint??_t at once (only a couple dozen variables), so that
> > reading the checkpatch.pl output
On Fri, 2017-10-06 at 12:00 +0100, Chris Wilson wrote:
> Quoting Joonas Lahtinen (2017-10-06 11:45:59)
> > Lets not introduce BIT() macro requirement for UAPI for now.
> >
> > Fixes: 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl")
> > Signed-off-by: Joonas Lahtinen
> > Cc: Chris Wilson
>
On Fri, Oct 06, 2017 at 12:12:41PM +0200, Thomas Gleixner wrote:
> So if you don't have a compelling technical reason to
> use it, then it _is_ the wrong tool.
This. stop_machine() effectively takes down _all_ CPUs for the duration
of your callback. That is something you really should avoid at pre
When we suspend, we do not want to be interrupted by a pending reset, or
failure of that reset. After the resume, the errors should be noted as
usual.
Signed-off-by: Chris Wilson
---
tests/gem_eio.c | 48
1 file changed, 48 insertions(+)
diff --g
If two nop's (requests in-flight following a wedged device) complete at
the same time, the global_seqno value written to the HWSP is undefined
as the two threads are not serialized.
Fixes: ce1135c7de64 ("drm/i915: Complete requests in nop_submit_request")
Signed-off-by: Chris Wilson
Cc: Tvrtko Ur
== Series Details ==
Series: series starting with [v2,1/1] drm/i915: Split i915_gem_suspend into
user quiescing and HW cleanup/suspend (rev2)
URL : https://patchwork.freedesktop.org/series/31450/
State : failure
== Summary ==
Series 31450v2 series starting with [v2,1/1] drm/i915: Split i915_g
Thanks for the reviews. Will be sending the updated revision.
Thanks
Sagar
On 10/5/2017 11:24 PM, Chris Wilson wrote:
Quoting Sagar Arun Kamble (2017-10-04 15:07:24)
Prepared generic functions intel_enable_rc6, intel_disable_rc6,
intel_enable_rps and intel_disable_rps functions to setup RC6/RP
On 06/10/2017 10:06, Daniel Vetter wrote:
4.14-rc1 gained the fancy new cross-release support in lockdep, which
seems to have uncovered a few more rules about what is allowed and
isn't.
This one here seems to indicate that allocating a work-queue while
holding mmap_sem is a no-go, so let's try
On 06/10/2017 12:22, Chris Wilson wrote:
If two nop's (requests in-flight following a wedged device) complete at
the same time, the global_seqno value written to the HWSP is undefined
as the two threads are not serialized.
Fixes: ce1135c7de64 ("drm/i915: Complete requests in nop_submit_request"
tree: git://anongit.freedesktop.org/drm-intel for-linux-next
head: faf654864b25f4ca4efd416145d37b794c0b805f
commit: faf654864b25f4ca4efd416145d37b794c0b805f [2/2] drm/i915: Unify uC
variable types to avoid flooding checkpatch.pl
config: i386-randconfig-x003-201740 (attached as .config)
compile
tree: git://anongit.freedesktop.org/drm-intel for-linux-next
head: faf654864b25f4ca4efd416145d37b794c0b805f
commit: faf654864b25f4ca4efd416145d37b794c0b805f [2/2] drm/i915: Unify uC
variable types to avoid flooding checkpatch.pl
config: i386-randconfig-x005-201740 (attached as .config)
compile
On Fri, 06 Oct 2017 12:43:10 +0200, Sagar Arun Kamble
wrote:
On 10/6/2017 2:31 PM, Michal Wajdeczko wrote:
Checking GuC firmware size can be done in GuC specific code
right before DMA copy as it is unlikely to fail anyway.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Joonas
== Series Details ==
Series: drm/i915: Unify GuC variable types to avoid floding checkpatch.pl
URL : https://patchwork.freedesktop.org/series/31469/
State : failure
== Summary ==
Series 31469 revision 1 was fully merged or fully failed: no git log
_
== Series Details ==
Series: drm/i915: Unify uC variable types to avoid floding checkpatch.pl
URL : https://patchwork.freedesktop.org/series/31473/
State : failure
== Summary ==
Series 31473 revision 1 was fully merged or fully failed: no git log
__
Quoting Tvrtko Ursulin (2017-10-06 12:42:34)
>
> On 06/10/2017 12:22, Chris Wilson wrote:
> > If two nop's (requests in-flight following a wedged device) complete at
> > the same time, the global_seqno value written to the HWSP is undefined
> > as the two threads are not serialized.
> >
> > Fixes
If two nop's (requests in-flight following a wedged device) complete at
the same time, the global_seqno value written to the HWSP is undefined
as the two threads are not serialized.
v2: Use irqsafe spinlock. We expect the callback may be called from
inside another irq spinlock, so we can't uncondi
On 10/6/2017 5:17 PM, Michal Wajdeczko wrote:
On Fri, 06 Oct 2017 12:43:10 +0200, Sagar Arun Kamble
wrote:
On 10/6/2017 2:31 PM, Michal Wajdeczko wrote:
Checking GuC firmware size can be done in GuC specific code
right before DMA copy as it is unlikely to fail anyway.
Signed-off-by: Mic
With GuC based SLPC, frequency control will be moved to GuC and Host will
continue to control RC6 and LLC ring frequency setup. This needs separate
handling of RPS, RC6 and LLC ring frequencies in i915 flows. We still
continue use the *gt_powersave routines with separate status variables
for RPS, R
== Series Details ==
Series: drm/i915/guc: Move firmware size check out of generic code
URL : https://patchwork.freedesktop.org/series/31474/
State : success
== Summary ==
Series 31474v1 drm/i915/guc: Move firmware size check out of generic code
https://patchwork.freedesktop.org/api/1.0/series
Defined new struct intel_rc6 to hold RC6 specific state and
intel_ring_pstate to hold ring specific state.
v2: s/intel_ring_pstate/intel_llc_pstate and rebase. (Chris)
Signed-off-by: Sagar Arun Kamble
Cc: Imre Deak
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Radoslaw Szwichtenberg
---
drivers/
We were using dev_priv->pm for runtime power management related state.
This patch renames it to "rpm" which looks more apt. Will be using pm
for state containing RPS/RC6 state in the next patch.
Signed-off-by: Sagar Arun Kamble
Cc: Imre Deak
Cc: Chris Wilson
Cc: Joonas Lahtinen
Reviewed-by: Ra
This patch separates enable/disable of RC6 and RPS for gen6+
platforms prior to VLV.
Signed-off-by: Sagar Arun Kamble
Cc: Imre Deak
Cc: Chris Wilson
Cc: Joonas Lahtinen
Reviewed-by: Radoslaw Szwichtenberg
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c | 17 +++---
This patch separates RC6 and RPS enabling for BDW.
RC6/RPS Disabling are handled through gen6 functions.
PM Programming guide recommends a sequence within forcewakes to
configure RC6, RPS and ring frequencies in sequence. With this
patch the order is still maintained.
v2: Update sequence numbers i
This function gives the status of RC6, whether disabled or if
enabled then which state. intel_enable_rc6 will be used for
enabling RC6 in the next patch.
v2: Rebase.
Signed-off-by: Sagar Arun Kamble
Cc: Chris Wilson
Cc: Imre Deak
Cc: Joonas Lahtinen
Reviewed-by: Radoslaw Szwichtenberg
Review
This patch separates enable/disable of RC6 and RPS for CHV.
v2: Fixed comment.
Signed-off-by: Sagar Arun Kamble
Cc: Imre Deak
Cc: Chris Wilson
Cc: Joonas Lahtinen
Reviewed-by: Radoslaw Szwichtenberg
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_pm.c | 30
Prepared substructure rps for RPS related state. autoenable_work and
pcu_lock are used for RC6 hence they are defined outside rps structure.
Renamed the RPS lock as pcu_lock.
v2: Rebase.
Signed-off-by: Sagar Arun Kamble
Cc: Chris Wilson
Cc: Imre Deak
Cc: Joonas Lahtinen
Reviewed-by: Radoslaw
This patch removes all IS_BROADWELL checks and non-BDW changes from
gen8_enable_rps as it is called only for BROADWELL.
Suggested-by: Chris Wilson
Signed-off-by: Sagar Arun Kamble
Cc: Imre Deak
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Radoslaw Szwichtenberg
---
drivers/gpu/drm/i915/intel_pm
This patch separates enable/disable of RC6 and RPS for VLV.
v2: Removed unnecessary comments about forcewakes while enabling
RC6/RPS. Added changes to output turbo control status for VLV in
i915_frequency_info.
Signed-off-by: Sagar Arun Kamble
Cc: Imre Deak
Cc: Chris Wilson
Cc: Joonas Lahtinen
Prepared generic functions intel_enable_rc6, intel_disable_rc6,
intel_enable_rps and intel_disable_rps functions to setup RC6/RPS
based on platforms.
v2: Make intel_enable/disable_rc6/rps static. (Chris)
Signed-off-by: Sagar Arun Kamble
Cc: Imre Deak
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: R
Prepared intel_update_ring_freq function to setup ring frequency
for applicable platforms determined by macro HAS_LLC.
v2: Replaced NEEDS_RING_FREQ_UPDATE with HAS_LLC macro. (Chris)
Added check while calling from intel_enable_gt_powersave.
Signed-off-by: Sagar Arun Kamble
Cc: Imre Deak
Cc:
Hi,
> Yeah, that could solve the problem. But I'm not sure if it could be
> acceptable.
> Zhenyu, can you share your comments?
Ping? Any progress here? We are at 4.14-rc3 already. v15 is needed
really soon now otherwise the 4.15 merge window will be missed.
cheers,
Gerd
_
On 06/10/2017 12:56, Chris Wilson wrote:
If two nop's (requests in-flight following a wedged device) complete at
the same time, the global_seqno value written to the HWSP is undefined
as the two threads are not serialized.
v2: Use irqsafe spinlock. We expect the callback may be called from
insi
Quoting Sagar Arun Kamble (2017-10-06 13:13:31)
> This patch removes all IS_BROADWELL checks and non-BDW changes from
> gen8_enable_rps as it is called only for BROADWELL.
>
> Suggested-by: Chris Wilson
> Signed-off-by: Sagar Arun Kamble
> Cc: Imre Deak
> Cc: Chris Wilson
> Cc: Joonas Lahtinen
== Series Details ==
Series: drm/i915/huc: Fix includes in intel_huc.c
URL : https://patchwork.freedesktop.org/series/31475/
State : success
== Summary ==
Series 31475v1 drm/i915/huc: Fix includes in intel_huc.c
https://patchwork.freedesktop.org/api/1.0/series/31475/revisions/1/mbox/
Test kms
On Thu, Oct 05, 2017 at 05:02:39PM +, Daniele Ceraolo Spurio wrote:
>
>
> On 05/10/17 02:33, Chris Wilson wrote:
> > Quoting Michał Winiarski (2017-10-05 10:13:40)
> > > We're using first page of kernel context state to share data with GuC,
> > > let's precompute the ggtt offset at GuC initia
Commit faf654864b25 ("drm/i915: Unify uC variable types to avoid
flooding checkpatch.pl") breaks 32-bit kernel builds. Lets use
chained cast to make compiler happy.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_guc_submission.c | 4 ++--
1 f
Quoting Sagar Arun Kamble (2017-10-06 13:13:35)
> We were using dev_priv->pm for runtime power management related state.
> This patch renames it to "rpm" which looks more apt. Will be using pm
> for state containing RPS/RC6 state in the next patch.
>
> Signed-off-by: Sagar Arun Kamble
> Cc: Imre
Quoting Sagar Arun Kamble (2017-10-06 13:13:38)
> Prepared intel_update_ring_freq function to setup ring frequency
> for applicable platforms determined by macro HAS_LLC.
>
> v2: Replaced NEEDS_RING_FREQ_UPDATE with HAS_LLC macro. (Chris)
> Added check while calling from intel_enable_gt_powers
Quoting Sagar Arun Kamble (2017-10-06 13:13:39)
> Prepared generic functions intel_enable_rc6, intel_disable_rc6,
> intel_enable_rps and intel_disable_rps functions to setup RC6/RPS
> based on platforms.
>
> v2: Make intel_enable/disable_rc6/rps static. (Chris)
>
> Signed-off-by: Sagar Arun Kambl
== Series Details ==
Series: series starting with [1/2] drm/i915: Preallocate our mmu notifier
workequeu to unbreak cpu hotplug deadlock
URL : https://patchwork.freedesktop.org/series/31476/
State : warning
== Summary ==
Series 31476v1 series starting with [1/2] drm/i915: Preallocate our mmu
We can use drm_printer to hide the differences between printk and
seq_printf, and so make the i915_engine_info pretty printer able to be
called from different contexts and not just debugfs. For instance, I
want to use the pretty printer to debug kselftests.
Signed-off-by: Chris Wilson
Cc: Mika Ku
During hangcheck testing, we try to execute requests following the GPU
reset, and in particular want to try and debug when those fail.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
Em Qui, 2017-10-05 às 14:49 -0700, Rodrigo Vivi escreveu:
> On Thu, Oct 05, 2017 at 09:38:41PM +, Paulo Zanoni wrote:
> > Don't call it when we can do like the other functions and just look
> > at
> > port->port. Also rename the intel_digital_port variable to make it
> > look like the other fun
Quoting Sagar Arun Kamble (2017-10-06 13:13:40)
> Defined new struct intel_rc6 to hold RC6 specific state and
> intel_ring_pstate to hold ring specific state.
>
> v2: s/intel_ring_pstate/intel_llc_pstate and rebase. (Chris)
>
> Signed-off-by: Sagar Arun Kamble
> Cc: Imre Deak
> Cc: Chris Wilson
Quoting Michal Wajdeczko (2017-10-06 13:36:56)
> Commit faf654864b25 ("drm/i915: Unify uC variable types to avoid
> flooding checkpatch.pl") breaks 32-bit kernel builds. Lets use
> chained cast to make compiler happy.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Joonas Lahtinen
> Cc: Chris Wilson
Commit faf654864b25 ("drm/i915: Unify uC variable types to avoid
flooding checkpatch.pl") breaks 32-bit kernel builds. Lets use
cast helper to make compiler happy.
v2: introduce ptr_to_u64 (Chris)
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i9
On Fri, Oct 06, 2017 at 11:06:34AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2)
> URL : https://patchwork.freedesktop.org/series/31457/
> State : warning
>
> == Summary ==
>
> Series 31457v2 drm/i915/cnl: WaDisableGatherA
Quoting Michal Wajdeczko (2017-10-06 14:08:44)
> Commit faf654864b25 ("drm/i915: Unify uC variable types to avoid
> flooding checkpatch.pl") breaks 32-bit kernel builds. Lets use
> cast helper to make compiler happy.
>
> v2: introduce ptr_to_u64 (Chris)
>
> Signed-off-by: Michal Wajdeczko
> Cc:
Quoting Rodrigo Vivi (2017-10-06 14:10:06)
> On Fri, Oct 06, 2017 at 11:06:34AM +, Patchwork wrote:
> > == Series Details ==
> >
> > Series: drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2)
> > URL : https://patchwork.freedesktop.org/series/31457/
> > State : warning
> >
> > == Su
== Series Details ==
Series: drm/i915: Try harder to finish the idle-worker (rev2)
URL : https://patchwork.freedesktop.org/series/29690/
State : success
== Summary ==
Series 29690v2 drm/i915: Try harder to finish the idle-worker
https://patchwork.freedesktop.org/api/1.0/series/29690/revisions/
== Series Details ==
Series: drm/i915: Don't use BIT() in UAPI section
URL : https://patchwork.freedesktop.org/series/31482/
State : failure
== Summary ==
Series 31482 revision 1 was fully merged or fully failed: no git log
___
Intel-gfx mailing lis
== Series Details ==
Series: drm/i915/guc: Move firmware size check out of generic code
URL : https://patchwork.freedesktop.org/series/31474/
State : warning
== Summary ==
Test kms_cursor_legacy:
Subgroup cursorA-vs-flipA-atomic-transitions:
fail -> PASS (sh
1 - 100 of 204 matches
Mail list logo