[Intel-gfx] [PATCH] drm/i915: Unify GuC variable types to avoid floding checkpatch.pl

2017-10-06 Thread Joonas Lahtinen
With the code motion mostly done, convert all the GuC code away from uint??_t at once (only a couple dozen variables), so that reading the checkpatch.pl output should actually pinpoint if a new uint??_t was accidentally introduced. Signed-off-by: Joonas Lahtinen Cc: Michal Wajdeczko Cc: Chris Wi

Re: [Intel-gfx] [PATCH] drm/i915/execlists: WaDisableCtxRestoreArbitration is only needed in gen8

2017-10-06 Thread Joonas Lahtinen
On Thu, 2017-10-05 at 11:54 -0700, Michel Thierry wrote: > On 10/5/2017 11:28 AM, Chris Wilson wrote: > > Quoting Michel Thierry (2017-10-05 19:19:27) > > > WaDisableCtxRestoreArbitration was only applied for bdw and chv, but > > > this changed after the code got moved to gen8_emit_bb_start (and, a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: fix check for intel IOMMU

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix check for intel IOMMU URL : https://patchwork.freedesktop.org/series/31426/ State : failure == Summary == Series 31426 revision 1 was fully merged or fully failed: no git log ___ Intel-gfx mailing

Re: [Intel-gfx] [RFC PATCH] drm/i915: push shared dpll enable to encoders on DDI platforms

2017-10-06 Thread Daniel Vetter
On Thu, Oct 05, 2017 at 02:50:13PM +0300, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_crt.c | 3 +++ > drivers/gpu/drm/i915/intel_ddi.c | 18 ++ > drivers/gpu/drm/i915/intel_display.c | 3 --- > 3 files changed, 21 insertions(+), 3

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Split i915_gem_suspend into user quiescing and HW cleanup/suspend

2017-10-06 Thread Sagar Arun Kamble
On 10/6/2017 12:07 PM, Sagar Arun Kamble wrote: GTT mappings are to be suspended post i915_gem_suspend and display I think I should say this "post idling GPU and display suspend". Will update in next rev. suspend. GPU is reset in i915_gem_suspend. This separated the HW suspend across reset. T

Re: [Intel-gfx] [RFC PATCH] drm/i915: push shared dpll enable to encoders on DDI platforms

2017-10-06 Thread Daniel Vetter
On Fri, Oct 06, 2017 at 10:07:45AM +0200, Daniel Vetter wrote: > On Thu, Oct 05, 2017 at 02:50:13PM +0300, Jani Nikula wrote: > > Signed-off-by: Jani Nikula > > --- > > drivers/gpu/drm/i915/intel_crt.c | 3 +++ > > drivers/gpu/drm/i915/intel_ddi.c | 18 ++ > > drivers/gpu

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915 PMU and engine busy stats (rev16)

2017-10-06 Thread Patchwork
== Series Details == Series: i915 PMU and engine busy stats (rev16) URL : https://patchwork.freedesktop.org/series/27488/ State : failure == Summary == Series 27488v16 i915 PMU and engine busy stats https://patchwork.freedesktop.org/api/1.0/series/27488/revisions/16/mbox/ Test gem_exec_suspen

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915: Preallocate mmu notifier to unbreak cpu hotplug deadlock URL : https://patchwork.freedesktop.org/series/31430/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generat

Re: [Intel-gfx] [PATCH] drm/i915: Use rcu instead of stop_machine

2017-10-06 Thread Tvrtko Ursulin
On 05/10/2017 17:24, Daniel Vetter wrote: On Thu, Oct 05, 2017 at 03:55:19PM +0100, Tvrtko Ursulin wrote: On 05/10/2017 15:09, Daniel Vetter wrote: stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work a

Re: [Intel-gfx] [PATCH] drm/i915: Convert timers to use timer_setup()

2017-10-06 Thread Jani Nikula
On Thu, 05 Oct 2017, Kees Cook wrote: > On Thu, Oct 5, 2017 at 6:45 AM, Joonas Lahtinen > wrote: >> On Wed, 2017-10-04 at 17:54 -0700, Kees Cook wrote: >>> In preparation for unconditionally passing the struct timer_list pointer to >>> all timer callbacks, switch to using the new timer_setup() an

Re: [Intel-gfx] [PATCH 5/5] drm/i915/crt: clean up encoder hook assignment

2017-10-06 Thread Jani Nikula
On Thu, 05 Oct 2017, Daniel Vetter wrote: > On Thu, Oct 05, 2017 at 01:52:14PM +0300, Jani Nikula wrote: >> Only assign the hooks once instead of overwriting for DDI. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Daniel Vetter Thanks for the review, pushed patches 1-5 to dinq. BR, Jani.

Re: [Intel-gfx] [PATCH] drm/i915: Use rcu instead of stop_machine

2017-10-06 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-05 17:12:35) > On Thu, Oct 05, 2017 at 03:30:12PM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-10-05 15:09:48) > > > stop_machine is not really a locking primitive we should use, except > > > when the hw folks tell us the hw is broken and that's the only

Re: [Intel-gfx] [PATCH] drm/i915: Unify GuC variable types to avoid floding checkpatch.pl

2017-10-06 Thread Sagar Arun Kamble
On 10/6/2017 12:41 PM, Joonas Lahtinen wrote: With the code motion mostly done, convert all the GuC code away from uint??_t at once (only a couple dozen variables), so that reading the checkpatch.pl output should actually pinpoint if a new uint??_t was accidentally introduced. Signed-off-by: J

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use rcu instead of stop_machine

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915: Use rcu instead of stop_machine URL : https://patchwork.freedesktop.org/series/31433/ State : success == Summary == Series 31433v1 drm/i915: Use rcu instead of stop_machine https://patchwork.freedesktop.org/api/1.0/series/31433/revisions/1/mbox/ Test kms

Re: [Intel-gfx] [PATCH 06/21] drm/i915: introduce page_size members

2017-10-06 Thread Chris Wilson
Quoting Chris Wilson (2017-10-05 17:12:25) > Quoting Matthew Auld (2017-10-05 16:19:00) > > static inline unsigned int i915_sg_segment_size(void) > > { > > unsigned int size = swiotlb_max_segment(); > > @@ -3101,6 +3116,8 @@ intel_info(const struct drm_i915_private *dev_priv) > > #define

Re: [Intel-gfx] [PATCH] drm/i915: Use rcu instead of stop_machine

2017-10-06 Thread Daniel Vetter
On Fri, Oct 6, 2017 at 10:30 AM, Tvrtko Ursulin wrote: > > On 05/10/2017 17:24, Daniel Vetter wrote: >> >> On Thu, Oct 05, 2017 at 03:55:19PM +0100, Tvrtko Ursulin wrote: >>> >>> >>> On 05/10/2017 15:09, Daniel Vetter wrote: stop_machine is not really a locking primitive we should use, e

[Intel-gfx] [PATCH v2] drm/i915: Unify uC variable types to avoid floding checkpatch.pl

2017-10-06 Thread Joonas Lahtinen
With the code motion mostly done, convert all the uC code away from uint??_t at once (only a couple dozen variables), so that reading the checkpatch.pl output should actually pinpoint if a new uint??_t was accidentally introduced. v2: - Include intel_uc_fw.h too (Sagar) Signed-off-by: Joonas Laht

Re: [Intel-gfx] [PATCH] drm/i915: Use the crtc_state_is_legacy in intel_color_check

2017-10-06 Thread Maarten Lankhorst
Op 05-10-17 om 18:30 schreef Daniel Vetter: > On Thu, Oct 05, 2017 at 04:15:20PM +0200, Maarten Lankhorst wrote: >> crtc_state_is_legacy also checks for CTM, which was missing from >> intel_color_check. By using the same condition for commit and check >> we reduce the chance of mismatches. >> >> Th

Re: [Intel-gfx] [PATCH v2] drm/i915: Unify uC variable types to avoid floding checkpatch.pl

2017-10-06 Thread Michal Wajdeczko
On Fri, 06 Oct 2017 10:49:40 +0200, Joonas Lahtinen wrote: With the code motion mostly done, convert all the uC code away from uint??_t at once (only a couple dozen variables), so that reading the checkpatch.pl output should actually pinpoint if a new uint??_t was accidentally introduced. v2

Re: [Intel-gfx] [dim PATCH 2/6] dim: url_to_remote can't normally fail

2017-10-06 Thread Jani Nikula
On Thu, 05 Oct 2017, Daniel Vetter wrote: > On Tue, Oct 03, 2017 at 04:38:04PM +0300, Jani Nikula wrote: >> Since commit cad37e1910f9 ("dim: auto-add remotes") url_to_remote can't >> really fail. Same for repo_to_remote when the repo exists. Redirecting >> their output when the remote isn't there

Re: [Intel-gfx] [PATCH] drm/i915: Use rcu instead of stop_machine

2017-10-06 Thread Daniel Vetter
On Fri, Oct 6, 2017 at 10:42 AM, Chris Wilson wrote: > Quoting Daniel Vetter (2017-10-05 17:12:35) >> On Thu, Oct 05, 2017 at 03:30:12PM +0100, Chris Wilson wrote: >> > Quoting Daniel Vetter (2017-10-05 15:09:48) >> > > stop_machine is not really a locking primitive we should use, except >> > > wh

[Intel-gfx] [PATCH] drm/i915/guc: Move firmware size check out of generic code

2017-10-06 Thread Michal Wajdeczko
Checking GuC firmware size can be done in GuC specific code right before DMA copy as it is unlikely to fail anyway. Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamble Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_guc_loader.c | 14 +++--- drivers/gpu/drm/i915/intel_uc_fw.c

[Intel-gfx] [PATCH] drm/i915/huc: Fix includes in intel_huc.c

2017-10-06 Thread Michal Wajdeczko
Fix includes order and make sure we only include required headers. While here, make intel_huc.h header self-contained. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_huc.c | 6 -- drivers/gpu/drm/i915/intel_huc.h | 2 ++ 2 files changed,

[Intel-gfx] [PATCH 1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock

2017-10-06 Thread Daniel Vetter
4.14-rc1 gained the fancy new cross-release support in lockdep, which seems to have uncovered a few more rules about what is allowed and isn't. This one here seems to indicate that allocating a work-queue while holding mmap_sem is a no-go, so let's try to preallocate it. Of course another way to

[Intel-gfx] [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged

2017-10-06 Thread Daniel Vetter
stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it. This patch tries to address the locking abuse of stop_machine() from commit 20e4933c478a1ca694b38fa4ac44d99e659941f5 Author: Chris Wilson Dat

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged

2017-10-06 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-06 10:06:37) > stop_machine is not really a locking primitive we should use, except > when the hw folks tell us the hw is broken and that's the only way to > work around it. > > This patch tries to address the locking abuse of stop_machine() from > > commit 20e4933c

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock

2017-10-06 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-06 10:06:36) > 4.14-rc1 gained the fancy new cross-release support in lockdep, which > seems to have uncovered a few more rules about what is allowed and > isn't. > > This one here seems to indicate that allocating a work-queue while > holding mmap_sem is a no-go, so

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use the crtc_state_is_legacy in intel_color_check

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915: Use the crtc_state_is_legacy in intel_color_check URL : https://patchwork.freedesktop.org/series/31434/ State : failure == Summary == Series 31434 revision 1 was fully merged or fully failed: no git log ___ Int

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] drm-tip: 2017y-10m-05d-06h-44m-09s UTC integration manifest

2017-10-06 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm-tip: 2017y-10m-05d-06h-44m-09s UTC integration manifest URL : https://patchwork.freedesktop.org/series/31437/ State : failure == Summary == Series 31437 revision 1 was fully merged or fully failed: no git log

[Intel-gfx] [drm-rerere PATCH 1/2] nightly.conf: add url lists to all repos

2017-10-06 Thread Jani Nikula
dim has supported picking up the first match from a list of urls since 61df7dc31c63 ("dim: allow a space separated list of URLs for each repo in drm_tip_repos"). This way we don't have to have a complicated set of rules for converting between ssh, git and https protocol URLs, and we can configure t

[Intel-gfx] [drm-rerere PATCH 2/2] nightly.conf: add drm-tip and linux-upstream to drm_tip_repos

2017-10-06 Thread Jani Nikula
This way we can remove more special casing and hard-coding in dim. Until we have updated dim, this does mean extra fetches of the repos, but that should be a brief transitional period. Also add git:// and https:// URLs for drm-tip, although this is likely not going to be very useful for very many

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock

2017-10-06 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-06 10:06:36) > 4.14-rc1 gained the fancy new cross-release support in lockdep, which > seems to have uncovered a few more rules about what is allowed and > isn't. > > This one here seems to indicate that allocating a work-queue while > holding mmap_sem is a no-go, so

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use rcu instead of stop_machine

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915: Use rcu instead of stop_machine URL : https://patchwork.freedesktop.org/series/31433/ State : failure == Summary == Test kms_cursor_crc: Subgroup cursor-size-change: dmesg-fail -> PASS (shard-hsw) fdo#102886 +5 Test perf:

[Intel-gfx] MSR - Maarten Lankhorst - October 2017

2017-10-06 Thread Maarten Lankhorst
=== Convert ioctls to interruptible === Various ioctl's were using noninterruptible locking. I've converted some of the most common ones to use interruptible locking. This will allow programs to be interrupted when waiting for locking, instead of being blocked indefinitely. === Reworking IGT's k

[Intel-gfx] ✗ Fi.CI.BAT: failure for huge gtt pages (rev12)

2017-10-06 Thread Patchwork
== Series Details == Series: huge gtt pages (rev12) URL : https://patchwork.freedesktop.org/series/25118/ State : failure == Summary == Series 25118v12 huge gtt pages https://patchwork.freedesktop.org/api/1.0/series/25118/revisions/12/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-re

[Intel-gfx] ✗ Fi.CI.BAT: failure for Guc code reorg cont'd

2017-10-06 Thread Patchwork
== Series Details == Series: Guc code reorg cont'd URL : https://patchwork.freedesktop.org/series/31447/ State : failure == Summary == Series 31447 revision 1 was fully merged or fully failed: no git log ___ Intel-gfx mailing list Intel-gfx@lists.fr

Re: [Intel-gfx] [PATCH] drm/i915: Use rcu instead of stop_machine

2017-10-06 Thread Thomas Gleixner
On Fri, 6 Oct 2017, Daniel Vetter wrote: > On Fri, Oct 6, 2017 at 10:42 AM, Chris Wilson > wrote: > >> > > This patch tries to address the locking snafu from > >> > > >> > There's a locking snafu in the code? The lock problem exists definitely. We did not introduce new dependencies through the h

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged

2017-10-06 Thread Thomas Gleixner
On Fri, 6 Oct 2017, Chris Wilson wrote: > Quoting Daniel Vetter (2017-10-06 10:06:37) > > stop_machine is not really a locking primitive we should use, except > > when the hw folks tell us the hw is broken and that's the only way to > > work around it. > > > > This patch tries to address the locki

[Intel-gfx] [PATCH igt] igt/gem_exec_capture: Exercise readback of userptr

2017-10-06 Thread Chris Wilson
EXEC_OBJECT_CAPTURE extends the type of buffers we may read during error capture. Previously we knew that we would only see batch buffers (which limited the objects to being from gem_create()), but now we need to check that any buffer the user can create can be read. The first alternate buffer type

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/execlists: WaDisableCtxRestoreArbitration is only needed in gen8 (rev2)

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915/execlists: WaDisableCtxRestoreArbitration is only needed in gen8 (rev2) URL : https://patchwork.freedesktop.org/series/31452/ State : warning == Summary == Series 31452v2 drm/i915/execlists: WaDisableCtxRestoreArbitration is only needed in gen8 https://p

[Intel-gfx] [CI] drm/i915: Try harder to finish the idle-worker

2017-10-06 Thread Chris Wilson
If a worker requeues itself, it may switch to a different kworker pool, which flush_work() considers as complete. To be strict, we then need to keep flushing the work until it is no longer pending. References: https://bugs.freedesktop.org/show_bug.cgi?id=102456 Signed-off-by: Chris Wilson Cc: Mik

Re: [Intel-gfx] [PATCH] drm/i915/guc: Move firmware size check out of generic code

2017-10-06 Thread Sagar Arun Kamble
On 10/6/2017 2:31 PM, Michal Wajdeczko wrote: Checking GuC firmware size can be done in GuC specific code right before DMA copy as it is unlikely to fail anyway. Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamble Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_guc_loader.c | 14

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: avoid unnecessary call to intel_hpd_pin_to_port

2017-10-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: avoid unnecessary call to intel_hpd_pin_to_port URL : https://patchwork.freedesktop.org/series/31459/ State : warning == Summary == Series 31459v1 series starting with [1/2] drm/i915: avoid unnecessary call to intel_hpd_pin_to

[Intel-gfx] [PATCH] drm/i915: Don't use BIT() in UAPI section

2017-10-06 Thread Joonas Lahtinen
Lets not introduce BIT() macro requirement for UAPI for now. Fixes: 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl") Signed-off-by: Joonas Lahtinen Cc: Chris Wilson --- include/uapi/drm/i915_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/i915_d

Re: [Intel-gfx] [PATCH] drm/i915: Don't use BIT() in UAPI section

2017-10-06 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-10-06 11:45:59) > Lets not introduce BIT() macro requirement for UAPI for now. > > Fixes: 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl") > Signed-off-by: Joonas Lahtinen > Cc: Chris Wilson Yes, this is the simplest solution for now. I mistakenly thought we

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged

2017-10-06 Thread Chris Wilson
Quoting Daniel Vetter (2017-10-06 10:06:37) > stop_machine is not really a locking primitive we should use, except > when the hw folks tell us the hw is broken and that's the only way to > work around it. > > This patch tries to address the locking abuse of stop_machine() from > > commit 20e4933c

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2)

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2) URL : https://patchwork.freedesktop.org/series/31457/ State : warning == Summary == Series 31457v2 drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice https://patchwork.freedesktop.org/api/1.0/series/31457/

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged

2017-10-06 Thread Peter Zijlstra
On Fri, Oct 06, 2017 at 11:06:37AM +0200, Daniel Vetter wrote: > I pondered whether we should annotate engine->submit_request as __rcu > and use rcu_assign_pointer and rcu_dereference on it. But the reason > behind those is to make sure the compiler/cpu barriers are there for > when you have an ac

Re: [Intel-gfx] [PATCH v2] drm/i915: Unify uC variable types to avoid floding checkpatch.pl

2017-10-06 Thread Joonas Lahtinen
On Fri, 2017-10-06 at 10:53 +0200, Michal Wajdeczko wrote: > On Fri, 06 Oct 2017 10:49:40 +0200, Joonas Lahtinen > wrote: > > > With the code motion mostly done, convert all the uC code away > > from uint??_t at once (only a couple dozen variables), so that > > reading the checkpatch.pl output

Re: [Intel-gfx] [PATCH] drm/i915: Don't use BIT() in UAPI section

2017-10-06 Thread Joonas Lahtinen
On Fri, 2017-10-06 at 12:00 +0100, Chris Wilson wrote: > Quoting Joonas Lahtinen (2017-10-06 11:45:59) > > Lets not introduce BIT() macro requirement for UAPI for now. > > > > Fixes: 3fd3a6ffe279 ("drm/i915: Simplify i915_reg_read_ioctl") > > Signed-off-by: Joonas Lahtinen > > Cc: Chris Wilson >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged

2017-10-06 Thread Peter Zijlstra
On Fri, Oct 06, 2017 at 12:12:41PM +0200, Thomas Gleixner wrote: > So if you don't have a compelling technical reason to > use it, then it _is_ the wrong tool. This. stop_machine() effectively takes down _all_ CPUs for the duration of your callback. That is something you really should avoid at pre

[Intel-gfx] [PATCH igt] igt/gem_eio: Check hang/eio recovery during suspend

2017-10-06 Thread Chris Wilson
When we suspend, we do not want to be interrupted by a pending reset, or failure of that reset. After the resume, the errors should be noted as usual. Signed-off-by: Chris Wilson --- tests/gem_eio.c | 48 1 file changed, 48 insertions(+) diff --g

[Intel-gfx] [PATCH] drm/i915: Order two completing nop_submit_request

2017-10-06 Thread Chris Wilson
If two nop's (requests in-flight following a wedged device) complete at the same time, the global_seqno value written to the HWSP is undefined as the two threads are not serialized. Fixes: ce1135c7de64 ("drm/i915: Complete requests in nop_submit_request") Signed-off-by: Chris Wilson Cc: Tvrtko Ur

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/1] drm/i915: Split i915_gem_suspend into user quiescing and HW cleanup/suspend (rev2)

2017-10-06 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] drm/i915: Split i915_gem_suspend into user quiescing and HW cleanup/suspend (rev2) URL : https://patchwork.freedesktop.org/series/31450/ State : failure == Summary == Series 31450v2 series starting with [v2,1/1] drm/i915: Split i915_g

Re: [Intel-gfx] [PATCH 09/10] drm/i915: Create generic functions to control RC6, RPS

2017-10-06 Thread Sagar Arun Kamble
Thanks for the reviews. Will be sending the updated revision. Thanks Sagar On 10/5/2017 11:24 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-10-04 15:07:24) Prepared generic functions intel_enable_rc6, intel_disable_rc6, intel_enable_rps and intel_disable_rps functions to setup RC6/RP

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock

2017-10-06 Thread Tvrtko Ursulin
On 06/10/2017 10:06, Daniel Vetter wrote: 4.14-rc1 gained the fancy new cross-release support in lockdep, which seems to have uncovered a few more rules about what is allowed and isn't. This one here seems to indicate that allocating a work-queue while holding mmap_sem is a no-go, so let's try

Re: [Intel-gfx] [PATCH] drm/i915: Order two completing nop_submit_request

2017-10-06 Thread Tvrtko Ursulin
On 06/10/2017 12:22, Chris Wilson wrote: If two nop's (requests in-flight following a wedged device) complete at the same time, the global_seqno value written to the HWSP is undefined as the two threads are not serialized. Fixes: ce1135c7de64 ("drm/i915: Complete requests in nop_submit_request"

[Intel-gfx] [drm-intel:for-linux-next 2/2] drivers/gpu//drm/i915/i915_guc_submission.c:391:25: error: cast from pointer to integer of different size

2017-10-06 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: faf654864b25f4ca4efd416145d37b794c0b805f commit: faf654864b25f4ca4efd416145d37b794c0b805f [2/2] drm/i915: Unify uC variable types to avoid flooding checkpatch.pl config: i386-randconfig-x003-201740 (attached as .config) compile

[Intel-gfx] [drm-intel:for-linux-next 2/2] drivers/gpu//drm/i915/i915_guc_submission.c:391:25: warning: cast from pointer to integer of different size

2017-10-06 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: faf654864b25f4ca4efd416145d37b794c0b805f commit: faf654864b25f4ca4efd416145d37b794c0b805f [2/2] drm/i915: Unify uC variable types to avoid flooding checkpatch.pl config: i386-randconfig-x005-201740 (attached as .config) compile

Re: [Intel-gfx] [PATCH] drm/i915/guc: Move firmware size check out of generic code

2017-10-06 Thread Michal Wajdeczko
On Fri, 06 Oct 2017 12:43:10 +0200, Sagar Arun Kamble wrote: On 10/6/2017 2:31 PM, Michal Wajdeczko wrote: Checking GuC firmware size can be done in GuC specific code right before DMA copy as it is unlikely to fail anyway. Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamble Cc: Joonas

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unify GuC variable types to avoid floding checkpatch.pl

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915: Unify GuC variable types to avoid floding checkpatch.pl URL : https://patchwork.freedesktop.org/series/31469/ State : failure == Summary == Series 31469 revision 1 was fully merged or fully failed: no git log _

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unify uC variable types to avoid floding checkpatch.pl

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915: Unify uC variable types to avoid floding checkpatch.pl URL : https://patchwork.freedesktop.org/series/31473/ State : failure == Summary == Series 31473 revision 1 was fully merged or fully failed: no git log __

Re: [Intel-gfx] [PATCH] drm/i915: Order two completing nop_submit_request

2017-10-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-10-06 12:42:34) > > On 06/10/2017 12:22, Chris Wilson wrote: > > If two nop's (requests in-flight following a wedged device) complete at > > the same time, the global_seqno value written to the HWSP is undefined > > as the two threads are not serialized. > > > > Fixes

[Intel-gfx] [PATCH v2] drm/i915: Order two completing nop_submit_request

2017-10-06 Thread Chris Wilson
If two nop's (requests in-flight following a wedged device) complete at the same time, the global_seqno value written to the HWSP is undefined as the two threads are not serialized. v2: Use irqsafe spinlock. We expect the callback may be called from inside another irq spinlock, so we can't uncondi

Re: [Intel-gfx] [PATCH] drm/i915/guc: Move firmware size check out of generic code

2017-10-06 Thread Sagar Arun Kamble
On 10/6/2017 5:17 PM, Michal Wajdeczko wrote: On Fri, 06 Oct 2017 12:43:10 +0200, Sagar Arun Kamble wrote: On 10/6/2017 2:31 PM, Michal Wajdeczko wrote: Checking GuC firmware size can be done in GuC specific code right before DMA copy as it is unlikely to fail anyway. Signed-off-by: Mic

[Intel-gfx] [PATCH v2 00/11] drm/i915: Separate RC6, RPS, LLC ring Frequency management

2017-10-06 Thread Sagar Arun Kamble
With GuC based SLPC, frequency control will be moved to GuC and Host will continue to control RC6 and LLC ring frequency setup. This needs separate handling of RPS, RC6 and LLC ring frequencies in i915 flows. We still continue use the *gt_powersave routines with separate status variables for RPS, R

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Move firmware size check out of generic code

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915/guc: Move firmware size check out of generic code URL : https://patchwork.freedesktop.org/series/31474/ State : success == Summary == Series 31474v1 drm/i915/guc: Move firmware size check out of generic code https://patchwork.freedesktop.org/api/1.0/series

[Intel-gfx] [PATCH v2 11/11] drm/i915: Introduce separate status variable for RC6 and LLC ring frequency setup

2017-10-06 Thread Sagar Arun Kamble
Defined new struct intel_rc6 to hold RC6 specific state and intel_ring_pstate to hold ring specific state. v2: s/intel_ring_pstate/intel_llc_pstate and rebase. (Chris) Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Radoslaw Szwichtenberg --- drivers/

[Intel-gfx] [PATCH v2 06/11] drm/i915: Name i915_runtime_pm structure in dev_priv as "rpm"

2017-10-06 Thread Sagar Arun Kamble
We were using dev_priv->pm for runtime power management related state. This patch renames it to "rpm" which looks more apt. Will be using pm for state containing RPS/RC6 state in the next patch. Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc: Chris Wilson Cc: Joonas Lahtinen Reviewed-by: Ra

[Intel-gfx] [PATCH v2 01/11] drm/i915: Separate RPS and RC6 handling for gen6+

2017-10-06 Thread Sagar Arun Kamble
This patch separates enable/disable of RC6 and RPS for gen6+ platforms prior to VLV. Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc: Chris Wilson Cc: Joonas Lahtinen Reviewed-by: Radoslaw Szwichtenberg Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 17 +++---

[Intel-gfx] [PATCH v2 03/11] drm/i915: Separate RPS and RC6 handling for BDW

2017-10-06 Thread Sagar Arun Kamble
This patch separates RC6 and RPS enabling for BDW. RC6/RPS Disabling are handled through gen6 functions. PM Programming guide recommends a sequence within forcewakes to configure RC6, RPS and ring frequencies in sequence. With this patch the order is still maintained. v2: Update sequence numbers i

[Intel-gfx] [PATCH v2 08/11] drm/i915: Rename intel_enable_rc6 to intel_rc6_enabled

2017-10-06 Thread Sagar Arun Kamble
This function gives the status of RC6, whether disabled or if enabled then which state. intel_enable_rc6 will be used for enabling RC6 in the next patch. v2: Rebase. Signed-off-by: Sagar Arun Kamble Cc: Chris Wilson Cc: Imre Deak Cc: Joonas Lahtinen Reviewed-by: Radoslaw Szwichtenberg Review

[Intel-gfx] [PATCH v2 05/11] drm/i915: Separate RPS and RC6 handling for CHV

2017-10-06 Thread Sagar Arun Kamble
This patch separates enable/disable of RC6 and RPS for CHV. v2: Fixed comment. Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc: Chris Wilson Cc: Joonas Lahtinen Reviewed-by: Radoslaw Szwichtenberg Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_pm.c | 30

[Intel-gfx] [PATCH v2 07/11] drm/i915: Name structure in dev_priv that contains RPS/RC6 state as "pm"

2017-10-06 Thread Sagar Arun Kamble
Prepared substructure rps for RPS related state. autoenable_work and pcu_lock are used for RC6 hence they are defined outside rps structure. Renamed the RPS lock as pcu_lock. v2: Rebase. Signed-off-by: Sagar Arun Kamble Cc: Chris Wilson Cc: Imre Deak Cc: Joonas Lahtinen Reviewed-by: Radoslaw

[Intel-gfx] [PATCH v2 02/11] drm/i915: Remove superfluous IS_BDW checks and non-BDW changes from gen8_enable_rps

2017-10-06 Thread Sagar Arun Kamble
This patch removes all IS_BROADWELL checks and non-BDW changes from gen8_enable_rps as it is called only for BROADWELL. Suggested-by: Chris Wilson Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Radoslaw Szwichtenberg --- drivers/gpu/drm/i915/intel_pm

[Intel-gfx] [PATCH v2 04/11] drm/i915: Separate RPS and RC6 handling for VLV

2017-10-06 Thread Sagar Arun Kamble
This patch separates enable/disable of RC6 and RPS for VLV. v2: Removed unnecessary comments about forcewakes while enabling RC6/RPS. Added changes to output turbo control status for VLV in i915_frequency_info. Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc: Chris Wilson Cc: Joonas Lahtinen

[Intel-gfx] [PATCH v2 10/11] drm/i915: Create generic functions to control RC6, RPS

2017-10-06 Thread Sagar Arun Kamble
Prepared generic functions intel_enable_rc6, intel_disable_rc6, intel_enable_rps and intel_disable_rps functions to setup RC6/RPS based on platforms. v2: Make intel_enable/disable_rc6/rps static. (Chris) Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc: Chris Wilson Cc: Joonas Lahtinen Cc: R

[Intel-gfx] [PATCH v2 09/11] drm/i915: Create generic function to setup LLC ring frequency table

2017-10-06 Thread Sagar Arun Kamble
Prepared intel_update_ring_freq function to setup ring frequency for applicable platforms determined by macro HAS_LLC. v2: Replaced NEEDS_RING_FREQ_UPDATE with HAS_LLC macro. (Chris) Added check while calling from intel_enable_gt_powersave. Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc:

Re: [Intel-gfx] [PATCH v14 5/7] vfio: ABI for mdev display dma-buf operation

2017-10-06 Thread Gerd Hoffmann
Hi, > Yeah, that could solve the problem. But I'm not sure if it could be > acceptable. > Zhenyu, can you share your comments? Ping? Any progress here? We are at 4.14-rc3 already. v15 is needed really soon now otherwise the 4.15 merge window will be missed. cheers, Gerd _

Re: [Intel-gfx] [PATCH v2] drm/i915: Order two completing nop_submit_request

2017-10-06 Thread Tvrtko Ursulin
On 06/10/2017 12:56, Chris Wilson wrote: If two nop's (requests in-flight following a wedged device) complete at the same time, the global_seqno value written to the HWSP is undefined as the two threads are not serialized. v2: Use irqsafe spinlock. We expect the callback may be called from insi

Re: [Intel-gfx] [PATCH v2 02/11] drm/i915: Remove superfluous IS_BDW checks and non-BDW changes from gen8_enable_rps

2017-10-06 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-10-06 13:13:31) > This patch removes all IS_BROADWELL checks and non-BDW changes from > gen8_enable_rps as it is called only for BROADWELL. > > Suggested-by: Chris Wilson > Signed-off-by: Sagar Arun Kamble > Cc: Imre Deak > Cc: Chris Wilson > Cc: Joonas Lahtinen

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/huc: Fix includes in intel_huc.c

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915/huc: Fix includes in intel_huc.c URL : https://patchwork.freedesktop.org/series/31475/ State : success == Summary == Series 31475v1 drm/i915/huc: Fix includes in intel_huc.c https://patchwork.freedesktop.org/api/1.0/series/31475/revisions/1/mbox/ Test kms

Re: [Intel-gfx] [PATCH 01/10] drm/i915/guc: Precompute GuC shared data offset

2017-10-06 Thread Michał Winiarski
On Thu, Oct 05, 2017 at 05:02:39PM +, Daniele Ceraolo Spurio wrote: > > > On 05/10/17 02:33, Chris Wilson wrote: > > Quoting Michał Winiarski (2017-10-05 10:13:40) > > > We're using first page of kernel context state to share data with GuC, > > > let's precompute the ggtt offset at GuC initia

[Intel-gfx] [PATCH] drm/i915: Fix pointer-to-int conversion

2017-10-06 Thread Michal Wajdeczko
Commit faf654864b25 ("drm/i915: Unify uC variable types to avoid flooding checkpatch.pl") breaks 32-bit kernel builds. Lets use chained cast to make compiler happy. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_guc_submission.c | 4 ++-- 1 f

Re: [Intel-gfx] [PATCH v2 06/11] drm/i915: Name i915_runtime_pm structure in dev_priv as "rpm"

2017-10-06 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-10-06 13:13:35) > We were using dev_priv->pm for runtime power management related state. > This patch renames it to "rpm" which looks more apt. Will be using pm > for state containing RPS/RC6 state in the next patch. > > Signed-off-by: Sagar Arun Kamble > Cc: Imre

Re: [Intel-gfx] [PATCH v2 09/11] drm/i915: Create generic function to setup LLC ring frequency table

2017-10-06 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-10-06 13:13:38) > Prepared intel_update_ring_freq function to setup ring frequency > for applicable platforms determined by macro HAS_LLC. > > v2: Replaced NEEDS_RING_FREQ_UPDATE with HAS_LLC macro. (Chris) > Added check while calling from intel_enable_gt_powers

Re: [Intel-gfx] [PATCH v2 10/11] drm/i915: Create generic functions to control RC6, RPS

2017-10-06 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-10-06 13:13:39) > Prepared generic functions intel_enable_rc6, intel_disable_rc6, > intel_enable_rps and intel_disable_rps functions to setup RC6/RPS > based on platforms. > > v2: Make intel_enable/disable_rc6/rps static. (Chris) > > Signed-off-by: Sagar Arun Kambl

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock

2017-10-06 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock URL : https://patchwork.freedesktop.org/series/31476/ State : warning == Summary == Series 31476v1 series starting with [1/2] drm/i915: Preallocate our mmu

[Intel-gfx] [PATCH 1/2] drm/i915: Make i915_engine_info pretty printer to standalone

2017-10-06 Thread Chris Wilson
We can use drm_printer to hide the differences between printk and seq_printf, and so make the i915_engine_info pretty printer able to be called from different contexts and not just debugfs. For instance, I want to use the pretty printer to debug kselftests. Signed-off-by: Chris Wilson Cc: Mika Ku

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Pretty print engine state when requests fail to start

2017-10-06 Thread Chris Wilson
During hangcheck testing, we try to execute requests following the GPU reset, and in particular want to try and debug when those fail. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [Intel-gfx] [PATCH 1/2] drm/i915: avoid unnecessary call to intel_hpd_pin_to_port

2017-10-06 Thread Paulo Zanoni
Em Qui, 2017-10-05 às 14:49 -0700, Rodrigo Vivi escreveu: > On Thu, Oct 05, 2017 at 09:38:41PM +, Paulo Zanoni wrote: > > Don't call it when we can do like the other functions and just look > > at > > port->port. Also rename the intel_digital_port variable to make it > > look like the other fun

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Introduce separate status variable for RC6 and LLC ring frequency setup

2017-10-06 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-10-06 13:13:40) > Defined new struct intel_rc6 to hold RC6 specific state and > intel_ring_pstate to hold ring specific state. > > v2: s/intel_ring_pstate/intel_llc_pstate and rebase. (Chris) > > Signed-off-by: Sagar Arun Kamble > Cc: Imre Deak > Cc: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Fix pointer-to-int conversion

2017-10-06 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-06 13:36:56) > Commit faf654864b25 ("drm/i915: Unify uC variable types to avoid > flooding checkpatch.pl") breaks 32-bit kernel builds. Lets use > chained cast to make compiler happy. > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: Chris Wilson

[Intel-gfx] [PATCH v2] drm/i915: Fix pointer-to-int conversion

2017-10-06 Thread Michal Wajdeczko
Commit faf654864b25 ("drm/i915: Unify uC variable types to avoid flooding checkpatch.pl") breaks 32-bit kernel builds. Lets use cast helper to make compiler happy. v2: introduce ptr_to_u64 (Chris) Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/i9

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2)

2017-10-06 Thread Rodrigo Vivi
On Fri, Oct 06, 2017 at 11:06:34AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2) > URL : https://patchwork.freedesktop.org/series/31457/ > State : warning > > == Summary == > > Series 31457v2 drm/i915/cnl: WaDisableGatherA

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix pointer-to-int conversion

2017-10-06 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-06 14:08:44) > Commit faf654864b25 ("drm/i915: Unify uC variable types to avoid > flooding checkpatch.pl") breaks 32-bit kernel builds. Lets use > cast helper to make compiler happy. > > v2: introduce ptr_to_u64 (Chris) > > Signed-off-by: Michal Wajdeczko > Cc:

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2)

2017-10-06 Thread Chris Wilson
Quoting Rodrigo Vivi (2017-10-06 14:10:06) > On Fri, Oct 06, 2017 at 11:06:34AM +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2) > > URL : https://patchwork.freedesktop.org/series/31457/ > > State : warning > > > > == Su

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Try harder to finish the idle-worker (rev2)

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915: Try harder to finish the idle-worker (rev2) URL : https://patchwork.freedesktop.org/series/29690/ State : success == Summary == Series 29690v2 drm/i915: Try harder to finish the idle-worker https://patchwork.freedesktop.org/api/1.0/series/29690/revisions/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Don't use BIT() in UAPI section

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915: Don't use BIT() in UAPI section URL : https://patchwork.freedesktop.org/series/31482/ State : failure == Summary == Series 31482 revision 1 was fully merged or fully failed: no git log ___ Intel-gfx mailing lis

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/guc: Move firmware size check out of generic code

2017-10-06 Thread Patchwork
== Series Details == Series: drm/i915/guc: Move firmware size check out of generic code URL : https://patchwork.freedesktop.org/series/31474/ State : warning == Summary == Test kms_cursor_legacy: Subgroup cursorA-vs-flipA-atomic-transitions: fail -> PASS (sh

  1   2   3   >