[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnp: set min brightness from VBT

2017-09-13 Thread Patchwork
== Series Details == Series: drm/i915/cnp: set min brightness from VBT URL : https://patchwork.freedesktop.org/series/30256/ State : success == Summary == Test perf: Subgroup polling: fail -> PASS (shard-hsw) fdo#102252 fdo#102252 https://bugs.freedesktop.o

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms

2017-09-13 Thread Maarten Lankhorst
Op 12-09-17 om 22:11 schreef Pandiyan, Dhinakaran: > > > On Tue, 2017-09-12 at 19:08 +, Pandiyan, Dhinakaran wrote: >> On Tue, 2017-09-12 at 19:17 +0300, Ville Syrjälä wrote: >>> On Tue, Sep 12, 2017 at 07:11:32PM +0300, Ville Syrjälä wrote: On Tue, Sep 05, 2017 at 06:26:34PM -0700, Dhinak

Re: [Intel-gfx] [PATCH v2 1/6] drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting, v2.

2017-09-13 Thread Maarten Lankhorst
Op 12-09-17 om 15:56 schreef Emil Velikov: > On 12 September 2017 at 14:37, Maarten Lankhorst > wrote: >> When we want to make drm_atomic_commit interruptible, there are a lot of >> places that call the lock function, which we don't have control over. >> >> Rather than trying to convert every sing

Re: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"

2017-09-13 Thread Jani Nikula
On Tue, 05 Sep 2017, Mika Kahola wrote: > The revert patch solved the issue > > *ERROR* Video mode command 0x0041 send failed. > > on my setup with APL+MIPI/DSI single link combo. > > Tested-by: Mika Kahola Pushed to dinq, thanks for the patch and testing. Alas, I failed to add your Tested-b

Re: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"

2017-09-13 Thread Jani Nikula
On Tue, 12 Sep 2017, "Chauhan, Madhav" wrote: >> -Original Message- >> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >> Vidya Srinivas >> Sent: Tuesday, September 5, 2017 3:15 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Srinivas, Vidya >> Subject: [Int

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsi: Replace MIPI command error message with debug message

2017-09-13 Thread Jani Nikula
On Fri, 01 Sep 2017, Mika Kahola wrote: > Error message indicating that the same MIPI command is sent consecutively > is perhaps too strongly said. Let's replace that as a debug message instead. > > Signed-off-by: Mika Kahola Pushed to dinq, thanks for the patch. BR, Jani. > --- > drivers/gpu

Re: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"

2017-09-13 Thread Chauhan, Madhav
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, September 13, 2017 1:39 PM > To: Chauhan, Madhav ; Srinivas, Vidya > ; intel-gfx@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready > before shutdown command" > > On Tue, 12 Sep 20

Re: [Intel-gfx] [PATCH] drm/i915: Enable scanline read for gen9 dsi

2017-09-13 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Tuesday, September 12, 2017 8:36 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; Srinivas, Vidya >Subject: Re: [PATCH] drm/i915: Enable scanline read for gen9 dsi > >On Tue, Sep 12, 2017 at

[Intel-gfx] [PATCH v2 5/6] drm/i915: Kill off intel_crtc_active.

2017-09-13 Thread Maarten Lankhorst
Use crtc->active directly instead. This is still not completely optimal and needs fixing, but it's about as good as using intel_crtc_active. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 19 --- drivers/gpu/drm/i915/intel_drv.h | 1 - drivers/gp

[Intel-gfx] [PATCH v2 0/6] drm/i915: Convert gen4- watermarks to atomic.

2017-09-13 Thread Maarten Lankhorst
Calculate watermarks for gen4 and lower atomically. Changes since first version: - Address review feedback in first patch. - Rename sr/hpll.yyy to sr/hpll.yyy_wm. - Clarify comment in calculate gen4 watermarks semiatomically. Maarten Lankhorst (6): drm/i915: Calculate gen3- watermarks semi-atom

[Intel-gfx] [PATCH v2 2/6] drm/i915: Program gen3- watermarks atomically

2017-09-13 Thread Maarten Lankhorst
With the atomic watermark calculations calculate intermediary watermark values and update the watermarks atomically. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h | 5 + drivers/gpu/drm/i915/intel_drv.h | 5 +- drivers/gpu/drm/i915/intel_pm.c | 241 ++

[Intel-gfx] [PATCH v2 1/6] drm/i915: Calculate gen3- watermarks semi-atomically, v3.

2017-09-13 Thread Maarten Lankhorst
The gen3 watermark calculations are converted to atomic, but the wm update calls are still done through the legacy functions. This will make it easier to bisect things if they go wrong. CI was having issues on the kms_cursor_legacy tests with too much debug info printed out, in order to reduce th

[Intel-gfx] [PATCH v2 6/6] drm/i915: Rip out legacy watermark infrastructure

2017-09-13 Thread Maarten Lankhorst
The legacy watermark infrastructure is now unused, so remove it. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i915/intel_atomic.c | 2 - drivers/gpu/drm/i915/intel_display.c | 71 ++-- drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH v2 4/6] drm/i915: Program gen4 watermarks atomically

2017-09-13 Thread Maarten Lankhorst
We're already calculating the watermarks correctly, now we have to program them too. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/

[Intel-gfx] [PATCH v2 3/6] drm/i915: Calculate gen4 watermarks semiatomically.

2017-09-13 Thread Maarten Lankhorst
Gen4 watermark is handled same as gen3-. Calculate the optimal watermarks atomically first, and program it in the legacy helper. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 141 1 file changed, 100 insertions(+), 41 deletions(-)

[Intel-gfx] [PATCH v16 1/4] drm/i915: Introduce private PAT management

2017-09-13 Thread Zhi Wang
The private PAT management is to support PPAT entry manipulation. Two APIs are introduced for dynamically managing PPAT entries: intel_ppat_get and intel_ppat_put. intel_ppat_get will search for an existing PPAT entry which perfectly matches the required PPAT value. If not, it will try to allocate

[Intel-gfx] [PATCH v16 3/4] drm/i915: Do not allocate unused PPAT entries

2017-09-13 Thread Zhi Wang
Only PPAT entries 0/2/3/4 are using. Remove extra PPAT entry allocation during initialization. v8: - Move ppat_index() into i915_gem_gtt.c. (Chris) - Change the name of ppat_bits_to_index to ppat_index. Suggested-by: Joonas Lahtinen Signed-off-by: Zhi Wang Cc: Ben Widawsky Cc: Rodrigo Vivi C

[Intel-gfx] [PATCH v16 2/4] drm/i915: Remove the "INDEX" suffix from PPAT marcos

2017-09-13 Thread Zhi Wang
Remove the "INDEX" suffix from PPAT marcos as they are bits actually, not indexes. Suggested-by: Chris Wilson Signed-off-by: Zhi Wang Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Joonas Lahtinen Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- drivers/gpu/drm/i915/i915_ge

[Intel-gfx] [PATCH v16 4/4] drm/i915/selftests: Introduce live tests of private PAT management

2017-09-13 Thread Zhi Wang
Introduce two live tests of private PAT management: igt_ppat_init - This test is to check if all the PPAT configurations are written into HW. igt_ppat_get - This test performs several sub-tests on intel_ppat_get() and intel_ppat_put(). The "perfect match" test case will try to get a PPAT entry w

[Intel-gfx] [RFC v6 04/11] drm/i915/pmu: Expose a PMU interface for perf queries

2017-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin From: Chris Wilson From: Tvrtko Ursulin From: Dmitry Rogozhkin The first goal is to be able to measure GPU (and invidual ring) busyness without having to poll registers from userspace. (Which not only incurs holding the forcewake lock indefinitely, perturbing the system,

[Intel-gfx] [PATCH 1/6] drm/i915/lrc: Clarify the format of the context image

2017-09-13 Thread Chris Wilson
From: Michel Thierry Not only the context image consist of two parts (the PPHWSP, and the logical context state), but we also allocate a header at the start of for sharing data with GuC. Thus every lrc looks like this: | [guc] | [hwsp] [logical state] | |<- our header ->|<- context

[Intel-gfx] [PATCH 5/6] drm/i915/execlists: Read the context-status buffer from the HWSP

2017-09-13 Thread Chris Wilson
The engine provides a mirror of the CSB in the HWSP. If we use the cacheable reads from the HWSP, we can shave off a few mmio reads per context-switch interrupt (which are quite frequent!). Just removing a couple of mmio is not enough to actually reduce any latency, but a small reduction in overall

[Intel-gfx] [PATCH 4/6] drm/i915: Allow HW status page to be bound high

2017-09-13 Thread Chris Wilson
At the time of commit 1f767e02d69f ("drm/i915: HWS must be in the mappable region for g33"), drm_mm insertion would often default to placing a new object high in the zone forcing us to specify that certain HWSP must be bound within the low mappable region. Since then, drm_mm has gained more finesse

[Intel-gfx] [RFC v6 04/11] drm/i915/pmu: Expose a PMU interface for perf queries

2017-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin From: Chris Wilson From: Tvrtko Ursulin From: Dmitry Rogozhkin The first goal is to be able to measure GPU (and invidual ring) busyness without having to poll registers from userspace. (Which not only incurs holding the forcewake lock indefinitely, perturbing the system,

[Intel-gfx] [PATCH 2/6] drm/i915/guc: Don't make assumptions while getting the lrca offset

2017-09-13 Thread Chris Wilson
From: Michel Thierry Using the HWSP ggtt_offset to get the lrca offset is only correct if the HWSP happens to be before it (when we reuse the PPHWSP of the kernel context as the engine HWSP). Instead of making this assumption, get the lrca offset from the kernel_context engine state. And while l

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Convert gen4- watermarks to atomic. (rev4)

2017-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Convert gen4- watermarks to atomic. (rev4) URL : https://patchwork.freedesktop.org/series/23954/ State : success == Summary == Series 23954v4 drm/i915: Convert gen4- watermarks to atomic. https://patchwork.freedesktop.org/api/1.0/series/23954/revisions/4/

[Intel-gfx] [PATCH 6/6] drm/i915/execlists: Read the context-status HEAD from the HWSP

2017-09-13 Thread Chris Wilson
The engine also provides a mirror of the CSB write pointer in the HWSP, but not of our read pointer. To take advantage of this we need to remember where we read up to on the last interrupt and continue off from there. This poses a problem following a reset, as we don't know where the hw will start

[Intel-gfx] [PATCH 3/6] drm/i915/lrc: allocate separate page for HWSP

2017-09-13 Thread Chris Wilson
From: Daniele Ceraolo Spurio On gen8+ we're currently using the PPHWSP of the kernel ctx as the global HWSP. However, when the kernel ctx gets submitted (e.g. from __intel_autoenable_gt_powersave) the HW will use that page as both HWSP and PPHWSP. This causes a conflict in the register arena of t

Re: [Intel-gfx] [RFC] drm/i915: Rename global i915 to i915_params

2017-09-13 Thread Jani Nikula
On Tue, 12 Sep 2017, Ville Syrjälä wrote: > On Tue, Sep 12, 2017 at 03:28:09PM +, Michal Wajdeczko wrote: >> Our global struct with params is named exactly the same way >> as new preferred name for the drm_i915_private function parameter. > > Preferred by some, perhaps not by others. > > I sus

Re: [Intel-gfx] [RFC v3 00/11] i915 PMU and engine busy stats

2017-09-13 Thread Tvrtko Ursulin
On 12/09/2017 23:01, Rogozhkin, Dmitry V wrote: On Tue, 2017-09-12 at 15:54 +0100, Tvrtko Ursulin wrote: On 12/09/2017 03:03, Rogozhkin, Dmitry V wrote: Hi, Just tried v3 series. perf-stat works fine. From the IGT tests which I wrote for i915 PMU (https://patchwork.freedesktop.org/series/293

Re: [Intel-gfx] [RFC] drm/i915: Rename global i915 to i915_params

2017-09-13 Thread Jani Nikula
On Tue, 12 Sep 2017, Chris Wilson wrote: > Quoting Ville Syrjälä (2017-09-12 16:36:57) >> > -module_param_named(modeset, i915.modeset, int, 0400); >> > +module_param_named(modeset, i915_params.modeset, int, 0400); > > We could clear the bulk of this patch > > #define i915_param_named(name, T, perm

Re: [Intel-gfx] [PATCH] drm/i915: Disable DMC powersaving during GT operations

2017-09-13 Thread Imre Deak
On Tue, Sep 12, 2017 at 01:57:07PM +0100, Tvrtko Ursulin wrote: > > On 12/09/2017 13:45, Tvrtko Ursulin wrote: > > > > On 12/09/2017 13:37, Chris Wilson wrote: > > > The DMC typifies the worst example of firmware: it overrides system > > > behaviour and is fubar. When no displays are active, the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v16,1/4] drm/i915: Introduce private PAT management

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [v16,1/4] drm/i915: Introduce private PAT management URL : https://patchwork.freedesktop.org/series/30264/ State : success == Summary == Series 30264v1 series starting with [v16,1/4] drm/i915: Introduce private PAT management https://patchwor

[Intel-gfx] [PATCH i-g-t] tests/tools_test: Make sure l3_parity is supported

2017-09-13 Thread Abdiel Janulgue
v3: Don't pipe the output of intel_l3_parity, parse it's output directly. (Petri) v2: Check support before executing test. Skip test only if intel_l3_parity tool tells us to skip. (Petri) bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101650 Cc: Petri Latvala Signed-off-by: Abdie

[Intel-gfx] [PATCH] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit

2017-09-13 Thread Maarten Lankhorst
Commit b44d5c0c105a ("drm/i915: Always wait for flip_done, v2.") removed the call to wait_for_vblanks and replaced it with flip_done. Unfortunately legacy_cursor_update was unset too late, and the replacement call drm_atomic_helper_wait_for_flip_done() was a noop. Make sure that its unset before s

Re: [Intel-gfx] [PATCH 5/9] drm/i915/dp: Remove intel_dp->is_mst check in intel_dp_check_mst_status

2017-09-13 Thread Jani Nikula
On Tue, 12 Sep 2017, Dhinakaran Pandiyan wrote: > There is just only one caller now, which already checks for > intel_dp->is_mst. So, remove this and fix some braces while at it. > > Signed-off-by: Dhinakaran Pandiyan > --- > drivers/gpu/drm/i915/intel_dp.c | 85 > --

[Intel-gfx] ✗ Fi.CI.BAT: warning for i915 PMU and engine busy stats (rev4)

2017-09-13 Thread Patchwork
== Series Details == Series: i915 PMU and engine busy stats (rev4) URL : https://patchwork.freedesktop.org/series/27488/ State : warning == Summary == Series 27488v4 i915 PMU and engine busy stats https://patchwork.freedesktop.org/api/1.0/series/27488/revisions/4/mbox/ Test kms_flip:

Re: [Intel-gfx] [PATCH] drm/i915/cnp: set min brightness from VBT

2017-09-13 Thread Jani Nikula
On Wed, 13 Sep 2017, "Lee, Shawn C" wrote: > Min brightness value from vbt was missing for CNP platform. > This setting have to refer backlight ic spec to restrict > min backlight output. Without this restriction, driver would > allow to configure lower brightness value and violate > backlight ic

Re: [Intel-gfx] [PATCH] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit

2017-09-13 Thread Lofstedt, Marta
Tested-by: Marta Löfstedt > -Original Message- > From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] > Sent: Wednesday, September 13, 2017 12:26 PM > To: intel-gfx@lists.freedesktop.org > Cc: Maarten Lankhorst ; Daniel Vetter > ; Jani Nikula ; Lofstedt, > Marta > Subject:

Re: [Intel-gfx] [PATCH 3/3] drm/i915/guc: Small improvements to guc_wq_item_append

2017-09-13 Thread Chris Wilson
Quoting Oscar Mateo (2017-09-12 22:36:37) > Spare some comments and other small style changes. > > Suggested-by: Joonas Lahtinen > Signed-off-by: Oscar Mateo Series Reviewed-by: Chris Wilson and pushed, thanks. -Chris ___ Intel-gfx mailing list Intel

Re: [Intel-gfx] [PATCH] drm/i915: Move the context descriptor to an inline helper

2017-09-13 Thread Chris Wilson
Quoting Oscar Mateo (2017-09-12 23:50:08) > > > On 09/12/2017 02:49 PM, Chris Wilson wrote: > > The context descriptor is stored inside the per-engine context state, as > > we only need to compute it once and access it frequently. However, > > currently only intel_lrc.c has easy access, but i915_

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915/lrc: Clarify the format of the context image

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/lrc: Clarify the format of the context image URL : https://patchwork.freedesktop.org/series/30269/ State : success == Summary == Series 30269v1 series starting with [1/6] drm/i915/lrc: Clarify the format of the context image ht

Re: [Intel-gfx] [PATCH i-g-t] tests/tools_test: Make sure l3_parity is supported

2017-09-13 Thread Petri Latvala
On Wed, Sep 13, 2017 at 12:24:18PM +0300, Abdiel Janulgue wrote: > v3: Don't pipe the output of intel_l3_parity, parse it's output > directly. (Petri) > > v2: Check support before executing test. > Skip test only if intel_l3_parity tool tells us to skip. (Petri) > > bugzilla: https://bugs

Re: [Intel-gfx] [PATCH i-g-t] tests/tools_test: Make sure l3_parity is supported

2017-09-13 Thread Abdiel Janulgue
On 09/13/2017 01:10 PM, Petri Latvala wrote: > On Wed, Sep 13, 2017 at 12:24:18PM +0300, Abdiel Janulgue wrote: >> v3: Don't pipe the output of intel_l3_parity, parse it's output >> directly. (Petri) >> >> v2: Check support before executing test. >> Skip test only if intel_l3_parity tool

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Unset legacy_cursor_update early in intel_atomic_commit

2017-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Unset legacy_cursor_update early in intel_atomic_commit URL : https://patchwork.freedesktop.org/series/30273/ State : success == Summary == Series 30273v1 drm/i915: Unset legacy_cursor_update early in intel_atomic_commit https://patchwork.freedesktop.org/

[Intel-gfx] [RFC v7 04/11] drm/i915/pmu: Expose a PMU interface for perf queries

2017-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin From: Chris Wilson From: Tvrtko Ursulin From: Dmitry Rogozhkin The first goal is to be able to measure GPU (and invidual ring) busyness without having to poll registers from userspace. (Which not only incurs holding the forcewake lock indefinitely, perturbing the system,

[Intel-gfx] [RFC v5 05/11] drm/i915/pmu: Suspend sampling when GPU is idle

2017-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If only a subset of events is enabled we can afford to suspend the sampling timer when the GPU is idle and so save some cycles and power. v2: Rebase and limit timer even more. v3: Rebase. v4: Rebase. v5: Skip action if perf PMU failed to register. Signed-off-by: Tvrtko Ursu

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms

2017-09-13 Thread Ville Syrjälä
On Wed, Sep 13, 2017 at 09:32:40AM +0200, Maarten Lankhorst wrote: > Op 12-09-17 om 22:11 schreef Pandiyan, Dhinakaran: > > > > > > On Tue, 2017-09-12 at 19:08 +, Pandiyan, Dhinakaran wrote: > >> On Tue, 2017-09-12 at 19:17 +0300, Ville Syrjälä wrote: > >>> On Tue, Sep 12, 2017 at 07:11:32PM +0

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kmod: Allow specifying libkmod config via environment variables

2017-09-13 Thread Chris Wilson
Quoting Chris Wilson (2017-09-12 16:51:40) > Quoting Joonas Lahtinen (2017-09-12 16:44:10) > > Allow specifying the kernel module configuration via environment > > variables. This allows enumerating the subtests of the kselftest > > wrappers from sysroot directory. > > > > IGT_KMOD_CONFIG_PATHS=""

[Intel-gfx] [PATCH igt v2] igt/gem_linear_blits: Compute GTT size using 4G limit

2017-09-13 Thread Chris Wilson
Both gem_linear_blits and gem_tiled_blit do not request the full 48b GTT layout for their objects, restricting themselves to 4G. The underlying test that they trigger eviction is unaffected by this restriction, so we can simply reduce their memory requirements to fill the low 4G GTT space and so al

[Intel-gfx] [PATCH igt v2 2/3] igt/gem_eio: Exercise wedged with native in-flight requests

2017-09-13 Thread Chris Wilson
If we wedged one engine with unready requests to a second engine (blocked by waiting on requests from the first, using a dma-fence), check that we propagate the -EIO to those in-flight requests. Signed-off-by: Chris Wilson --- tests/gem_eio.c | 89

[Intel-gfx] [PATCH igt v2 3/3] igt/gem_eio: Check wedged with inflight on the same engine

2017-09-13 Thread Chris Wilson
Some overlap with gem_exec_fence, but confirm that light for waiting on a fence (both native and external), that a request queued is also flagged as EIO upon wedging. Signed-off-by: Chris Wilson --- tests/gem_eio.c | 41 + 1 file changed, 41 insertions(+)

[Intel-gfx] [PATCH igt v2 1/3] igt/gem_eio: inflight wedged requires long plugging

2017-09-13 Thread Chris Wilson
As our hangcheck may exceed 10s to declare the device wedged, we need to hold the plugging fence indefinitely. This makes using vgem as our input fence unusable, so resort to using sw_sync. At the same time, we can then check that the async result is also -EIO. Bugzilla: https://bugs.freedesktop.o

[Intel-gfx] [PATCH i-g-t 1/2] igt: Remove Android support

2017-09-13 Thread Arkadiusz Hiler
This patch gets rid of Android support, deleting all the hacks and moving code around to the places it belong. Android build is not really maintained properly and rots rather fast. With recent push for Meson here and Android going for Soong it will only accelerate. It's a good time to drop the il

[Intel-gfx] [PATCH i-g-t 2/2] Revert "lib/igt_aux: Make procps optional"

2017-09-13 Thread Arkadiusz Hiler
This reverts commit d7d3f4e87b827152f00bdf89a67871736672b492 and gets rid of the config option from the meson.build. It was needed only for the Android support. Signed-off-by: Arkadiusz Hiler --- configure.ac | 6 +- lib/igt_aux.c | 35 +++ meson.build |

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915 PMU and engine busy stats (rev6)

2017-09-13 Thread Patchwork
== Series Details == Series: i915 PMU and engine busy stats (rev6) URL : https://patchwork.freedesktop.org/series/27488/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CHK inc

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms

2017-09-13 Thread Maarten Lankhorst
Op 13-09-17 om 12:37 schreef Ville Syrjälä: > On Wed, Sep 13, 2017 at 09:32:40AM +0200, Maarten Lankhorst wrote: >> Op 12-09-17 om 22:11 schreef Pandiyan, Dhinakaran: >>> >>> On Tue, 2017-09-12 at 19:08 +, Pandiyan, Dhinakaran wrote: On Tue, 2017-09-12 at 19:17 +0300, Ville Syrjälä wrote:

[Intel-gfx] [PATCH i-g-t 6/9] tests/perf: Add testcase to verify timestamps

2017-09-13 Thread Sagar Arun Kamble
v2: Updated property enum names. Signed-off-by: Sagar Arun Kamble --- tests/intel_perf_dapc.c | 75 + 1 file changed, 75 insertions(+) diff --git a/tests/intel_perf_dapc.c b/tests/intel_perf_dapc.c index 2d76e6f..7a6effa 100644 --- a/tests/intel_p

[Intel-gfx] [PATCH i-g-t 4/9] tests/perf: Add testcase to verify pid

2017-09-13 Thread Sagar Arun Kamble
v2: Updated property enum names. Signed-off-by: Sagar Arun Kamble --- tests/intel_perf_dapc.c | 76 + 1 file changed, 76 insertions(+) diff --git a/tests/intel_perf_dapc.c b/tests/intel_perf_dapc.c index 23d6ffe..ccc37b6 100644 --- a/tests/intel_p

[Intel-gfx] [PATCH i-g-t 5/9] tests/perf: Add testcase to verify tag

2017-09-13 Thread Sagar Arun Kamble
v2: Updated property enum names. Defined TAG_MASK, set_tag and get_tag for local use. Signed-off-by: Sagar Arun Kamble --- tests/intel_perf_dapc.c | 142 1 file changed, 142 insertions(+) diff --git a/tests/intel_perf_dapc.c b/tests/intel_perf_da

[Intel-gfx] [PATCH i-g-t 2/9] tests/perf: Test i915 assisted command stream based perf metrics capture

2017-09-13 Thread Sagar Arun Kamble
This tests different performance metrics being streamed by i915 driver. This feature in i915 also referred as Driver Assisted Performance Capture (DAPC) provides userspace an ability to sample the OA reports at execbuf boundaries and associate other metadata like CTX ID, PID, TAG with each sample.

[Intel-gfx] [PATCH i-g-t 3/9] tests/perf: Add testcase to verify ctx id

2017-09-13 Thread Sagar Arun Kamble
This subtest verifies that the CS perf samples contains proper HW context ID as captured through CONTEXT_PARAM_HW_ID. v2: Updated property enum names. Signed-off-by: Sagar Arun Kamble --- lib/ioctl_wrappers.h| 1 + tests/intel_perf_dapc.c | 102

[Intel-gfx] [PATCH i-g-t 7/9] tests/perf: Add testcase to verify mmio

2017-09-13 Thread Sagar Arun Kamble
v2: Updated the check for RC6 register value. Updated property enum names. Defined local_I915_PERF_MMIO_NUM_MAX and local_drm_i915_perf_mmio_list for local use. Signed-off-by: Sagar Arun Kamble --- tests/intel_perf_dapc.c | 266 1 file changed, 26

[Intel-gfx] [PATCH i-g-t 0/9] IGT Testcases for i915 DAPC feature

2017-09-13 Thread Sagar Arun Kamble
This series implements set of testcases for verifying data sampled through i915 perf/DAPC feature. It tests validity of association of OA with correct engine/stream, ctx id, pid, tag, timestamps, mmio samples w.r.t execbuf begin and end. It also adds a testcase to verify concurrent operation of two

[Intel-gfx] [PATCH i-g-t 8/9] tests/perf: Add testcase to verify concurrent streams

2017-09-13 Thread Sagar Arun Kamble
v2: Updated property enum names. Signed-off-by: Sagar Arun Kamble --- tests/intel_perf_dapc.c | 211 1 file changed, 211 insertions(+) diff --git a/tests/intel_perf_dapc.c b/tests/intel_perf_dapc.c index 8644505..acc027b 100644 --- a/tests/intel_

[Intel-gfx] [PATCH i-g-t 9/9] tests/perf: Add testcase to verify association of OABUFFER reports with CS properties

2017-09-13 Thread Sagar Arun Kamble
Signed-off-by: Sagar Arun Kamble --- tests/intel_perf_dapc.c | 152 +--- 1 file changed, 143 insertions(+), 9 deletions(-) diff --git a/tests/intel_perf_dapc.c b/tests/intel_perf_dapc.c index acc027b..5d935bf 100644 --- a/tests/intel_perf_dapc.c +++ b/

[Intel-gfx] [PATCH 1/2] drm/i915: Use mul_u32_u32() for 32b x 32b -> 64b result

2017-09-13 Thread Chris Wilson
As realised by commit 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends"), GCC does not always generate ideal code for performing a 32b x 32b multiply returning a 64b result (i.e. where we idiomatically use u64 result = (u64)x * (u32)x). This catches a couple of instances in th

[Intel-gfx] [PATCH 2/2] drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result

2017-09-13 Thread Chris Wilson
As realised by commit 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends"), GCC does not always generate ideal code for performing a 32b x 32b multiply returning a 64b result (i.e. where we idiomatically use u64 result = (u64)x * (u32)x). Signed-off-by: Chris Wilson --- drive

[Intel-gfx] [CI] drm/i915: Squelch smatch warning for statement with no effect

2017-09-13 Thread Chris Wilson
The sgt iterators cause an drivers/gpu/drm/i915/i915_gpu_error.c:846 i915_error_object_create() warn: statement has no effect 7 everywhere they are used. If we change the code slightly, we can achieve the same increment without altering the output or raising a warning. textdata bss

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/gem_linear_blits: Compute GTT size using 4G limit (rev2)

2017-09-13 Thread Patchwork
== Series Details == Series: igt/gem_linear_blits: Compute GTT size using 4G limit (rev2) URL : https://patchwork.freedesktop.org/series/30216/ State : success == Summary == IGT patchset tested on top of latest successful build b6ea8b204c8a18af7098326522e8acaffb19dd7a tests/tools_test: Make su

[Intel-gfx] [PATCH 1/4] drm/i915/guc: Remove obsolete comments and remove unused variable

2017-09-13 Thread Chris Wilson
From: Michał Winiarski Originally removed in: c1adab970348 ("drm/i915/guc: Remove failed doorbell stat from debugfs") f1448a62a103 ("drm/i915/guc: Remove last submission result from debugfs") Were accidentaly restored in: 925344ccc91d ("BackMerge tag 'v4.12-rc5' into drm-next") We can also remo

[Intel-gfx] [PATCH 3/4] polish-doorbell

2017-09-13 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_debugfs.c| 4 +- drivers/gpu/drm/i915/i915_guc_submission.c | 61 ++ drivers/gpu/drm/i915/intel_uc.h| 1 - 3 files changed, 13 insertions(+), 53 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers

[Intel-gfx] [PATCH 2/4] drm/i915/guc: Submit GuC workitems containing coalesced requests

2017-09-13 Thread Chris Wilson
From: Michał Winiarski To create an upper bound on number of GuC workitems, we need to change the way that requests are being submitted. Rather than submitting each request as an individual workitem, we can do coalescing in a similar way we're handlig execlist submission ports. We also need to st

[Intel-gfx] [PATCH 4/4] HAX Enable GuC Submission for CI

2017-09-13 Thread Chris Wilson
From: Michał Winiarski Also: Revert "drm/i915/guc: Assert that we switch between known ggtt->invalidate functions" This reverts commit 04f7b24eccdfae680a36e9825fe0d61dcd5ed528. Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20170912132226.25629-1-michal.winia

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Use mul_u32_u32() for 32b x 32b -> 64b result

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use mul_u32_u32() for 32b x 32b -> 64b result URL : https://patchwork.freedesktop.org/series/30279/ State : failure == Summary == Series 30279v1 series starting with [1/2] drm/i915: Use mul_u32_u32() for 32b x 32b -> 64b resul

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Convert gen4- watermarks to atomic. (rev4)

2017-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Convert gen4- watermarks to atomic. (rev4) URL : https://patchwork.freedesktop.org/series/23954/ State : failure == Summary == Test kms_setmode: Subgroup basic: fail -> PASS (shard-hsw) fdo#99912 Test kms_flip:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Squelch smatch warning for statement with no effect

2017-09-13 Thread Patchwork
== Series Details == Series: drm/i915: Squelch smatch warning for statement with no effect URL : https://patchwork.freedesktop.org/series/30280/ State : success == Summary == Series 30280v1 drm/i915: Squelch smatch warning for statement with no effect https://patchwork.freedesktop.org/api/1.0/

[Intel-gfx] [PATCH igt] igt/prime_busy: Declare the hang tests expect to cause GPU hangs

2017-09-13 Thread Chris Wilson
Pull the two subtests together into the same subtest group as the fixtures were repeated for both and so we can consolidate down to one. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- tests/prime_busy.c | 81 ++ 1 file changed, 33 insertion

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms

2017-09-13 Thread Ville Syrjälä
On Wed, Sep 13, 2017 at 12:46:47PM +0200, Maarten Lankhorst wrote: > Op 13-09-17 om 12:37 schreef Ville Syrjälä: > > On Wed, Sep 13, 2017 at 09:32:40AM +0200, Maarten Lankhorst wrote: > >> Op 12-09-17 om 22:11 schreef Pandiyan, Dhinakaran: > >>> > >>> On Tue, 2017-09-12 at 19:08 +, Pandiyan, Dh

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use mul_u32_u32() for 32b x 32b -> 64b result

2017-09-13 Thread Ville Syrjälä
On Wed, Sep 13, 2017 at 11:51:53AM +0100, Chris Wilson wrote: > As realised by commit 9e3d6223d209 ("math64, timers: Fix 32bit > mul_u64_u32_shr() and friends"), GCC does not always generate ideal code > for performing a 32b x 32b multiply returning a 64b result (i.e. where > we idiomatically use u

Re: [Intel-gfx] [PATCH 2/2] drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result

2017-09-13 Thread Ville Syrjälä
On Wed, Sep 13, 2017 at 11:51:54AM +0100, Chris Wilson wrote: > As realised by commit 9e3d6223d209 ("math64, timers: Fix 32bit > mul_u64_u32_shr() and friends"), GCC does not always generate ideal code > for performing a 32b x 32b multiply returning a 64b result (i.e. where > we idiomatically use u

[Intel-gfx] [PATCH v7 1/2] drm/i915: Introduce INTEL_GEN_MASK

2017-09-13 Thread Joonas Lahtinen
Split INTEL_GEN_MASK out of IS_GEN macro, and make it usable within static declarations (unlike compound statements). v2: - s/combound/compound/ (Tvrtko) - Fix whitespace (yes, we need automatic checkpatch.pl) Signed-off-by: Joonas Lahtinen Cc: Jani Nikula Cc: Chris Wilson Reviewed-by: Jani Ni

[Intel-gfx] [PATCH v7 2/2] drm/i915: Simplify i915_reg_read_ioctl

2017-09-13 Thread Joonas Lahtinen
Convert to use the freshly available made INTEL_GEN_MASK for easier grepping and improve function readability and clarify the UABI documentation. No functional changes. v2: - Lift GEM_BUG_ONs and use is_power_of_2 (Chris) - Retain -EINVAL on bad flags behavior (Chris) v3: - Extract flags with 'e

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mst: Use MST sideband message transaction for dpms

2017-09-13 Thread Maarten Lankhorst
Op 13-09-17 om 13:48 schreef Ville Syrjälä: > On Wed, Sep 13, 2017 at 12:46:47PM +0200, Maarten Lankhorst wrote: >> Op 13-09-17 om 12:37 schreef Ville Syrjälä: >>> On Wed, Sep 13, 2017 at 09:32:40AM +0200, Maarten Lankhorst wrote: Op 12-09-17 om 22:11 schreef Pandiyan, Dhinakaran: > On Tue

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/guc: Remove obsolete comments and remove unused variable

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/guc: Remove obsolete comments and remove unused variable URL : https://patchwork.freedesktop.org/series/30282/ State : failure == Summary == Series 30282v1 series starting with [1/4] drm/i915/guc: Remove obsolete comments and r

Re: [Intel-gfx] [PATCH v16 1/4] drm/i915: Introduce private PAT management

2017-09-13 Thread Joonas Lahtinen
On Wed, 2017-09-13 at 16:44 +0800, Zhi Wang wrote: > The private PAT management is to support PPAT entry manipulation. Two > APIs are introduced for dynamically managing PPAT entries: intel_ppat_get > and intel_ppat_put. > > intel_ppat_get will search for an existing PPAT entry which perfectly > m

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v7,1/2] drm/i915: Introduce INTEL_GEN_MASK

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [v7,1/2] drm/i915: Introduce INTEL_GEN_MASK URL : https://patchwork.freedesktop.org/series/30291/ State : success == Summary == Series 30291v1 series starting with [v7,1/2] drm/i915: Introduce INTEL_GEN_MASK https://patchwork.freedesktop.org/ap

[Intel-gfx] [RFC v3 11/11] drm/i915: Gate engine stats collection with a static key

2017-09-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This reduces the cost of the software engine busyness tracking to a single no-op instruction when there are no listeners. v2: Rebase and some comments. v3: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_pmu.c | 54 +++-- dr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] igt/gem_eio: inflight wedged requires long plugging

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] igt/gem_eio: inflight wedged requires long plugging URL : https://patchwork.freedesktop.org/series/30275/ State : success == Summary == IGT patchset tested on top of latest successful build b6ea8b204c8a18af7098326522e8acaffb19dd7a tes

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v16,1/4] drm/i915: Introduce private PAT management

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [v16,1/4] drm/i915: Introduce private PAT management URL : https://patchwork.freedesktop.org/series/30264/ State : success == Summary == Test prime_self_import: Subgroup reimport-vs-gem_close-race: fail -> PASS

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kmod: Allow specifying libkmod config via environment variables

2017-09-13 Thread Joonas Lahtinen
On Wed, 2017-09-13 at 11:37 +0100, Chris Wilson wrote: > Quoting Chris Wilson (2017-09-12 16:51:40) > > Quoting Joonas Lahtinen (2017-09-12 16:44:10) > > > Allow specifying the kernel module configuration via environment > > > variables. This allows enumerating the subtests of the kselftest > > > w

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Squelch smatch warning for statement with no effect

2017-09-13 Thread Chris Wilson
Quoting Patchwork (2017-09-13 12:39:46) > == Series Details == > > Series: drm/i915: Squelch smatch warning for statement with no effect > URL : https://patchwork.freedesktop.org/series/30280/ > State : success > > == Summary == > > Series 30280v1 drm/i915: Squelch smatch warning for statement

Re: [Intel-gfx] [PATCH 4/9] drm/i915/dp: Avoid more dpcd transactions after resume failure

2017-09-13 Thread Ville Syrjälä
On Tue, Sep 12, 2017 at 04:57:25PM -0700, Dhinakaran Pandiyan wrote: > drm_dp_mst_topology_mgr_resume() fails if there are dpcd failures, so > there's no need to try that again in _check_mst_status() That commit message somehow doesn't seem to match this patch. You're not removing anything from _c

[Intel-gfx] ✓ Fi.CI.BAT: success for i915 PMU and engine busy stats (rev7)

2017-09-13 Thread Patchwork
== Series Details == Series: i915 PMU and engine busy stats (rev7) URL : https://patchwork.freedesktop.org/series/27488/ State : success == Summary == Series 27488v7 i915 PMU and engine busy stats https://patchwork.freedesktop.org/api/1.0/series/27488/revisions/7/mbox/ Test chamelium:

Re: [Intel-gfx] [PATCH 5/9] drm/i915/dp: Remove intel_dp->is_mst check in intel_dp_check_mst_status

2017-09-13 Thread Ville Syrjälä
On Tue, Sep 12, 2017 at 04:57:26PM -0700, Dhinakaran Pandiyan wrote: > There is just only one caller now, which already checks for > intel_dp->is_mst. So, remove this and fix some braces while at it. Hmm. So this depends on the subtle detail that drm_dp_mst_topology_mgr_resume() will "fail" if did

[Intel-gfx] [PATCH v7] drm/i915/execlists: Read the context-status buffer from the HWSP

2017-09-13 Thread Chris Wilson
The engine provides a mirror of the CSB in the HWSP. If we use the cacheable reads from the HWSP, we can shave off a few mmio reads per context-switch interrupt (which are quite frequent!). Just removing a couple of mmio is not enough to actually reduce any latency, but a small reduction in overall

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915/lrc: Clarify the format of the context image

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/lrc: Clarify the format of the context image URL : https://patchwork.freedesktop.org/series/30269/ State : success == Summary == Test kms_flip: Subgroup wf_vblank-vs-modeset: dmesg-warn -> PASS (sha

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] igt: Remove Android support

2017-09-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] igt: Remove Android support URL : https://patchwork.freedesktop.org/series/30276/ State : success == Summary == IGT patchset tested on top of latest successful build c718ba805208e55d675defe9b2a66852e2ae038c lib/igt_kmod: Allow specifying

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Use mul_u32_u32() for 32b x 32b -> 64b result

2017-09-13 Thread Chris Wilson
Quoting Patchwork (2017-09-13 12:22:43) > == Series Details == > > Series: series starting with [1/2] drm/i915: Use mul_u32_u32() for 32b x 32b > -> 64b result > URL : https://patchwork.freedesktop.org/series/30279/ > State : failure > > == Summary == > > Series 30279v1 series starting with [

Re: [Intel-gfx] [PATCH 5/6] drm/i915/execlists: Read the context-status buffer from the HWSP

2017-09-13 Thread Mika Kuoppala
Chris Wilson writes: > The engine provides a mirror of the CSB in the HWSP. If we use the > cacheable reads from the HWSP, we can shave off a few mmio reads per > context-switch interrupt (which are quite frequent!). Just removing a > couple of mmio is not enough to actually reduce any latency, b

  1   2   >