[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Stop using long platform names on clock gating functions.

2017-08-29 Thread Patchwork
== Series Details == Series: drm/i915: Stop using long platform names on clock gating functions. URL : https://patchwork.freedesktop.org/series/29453/ State : warning == Summary == Test kms_chv_cursor_fail: Subgroup pipe-C-128x128-bottom-edge: pass -> SKIP (

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-08-29 Thread Lofstedt, Marta
I can no longer reproduce the flip/flopping "FBC disabled" on the kms_frontbuffer_tracking tests. Instead I hit: WARNING: CPU: 2 PID: 25732 at drivers/gpu/drm/i915/intel_fbc.c:1173 WARNING: CPU: 2 PID: 25732 at drivers/gpu/drm/i915/intel_fbc.c:1141 /Marta > -Original Message- > From: Lo

Re: [Intel-gfx] [PATCH i-g-t v4] pm_rps: Changes in waitboost scenario

2017-08-29 Thread Szwichtenberg, Radoslaw
On Mon, 2017-08-28 at 10:50 +0200, Katarzyna Dec wrote: > CI is observing sporadical failures in pm_rps subtests. > There are a couple of reasons. One of them is the fact that > on gen6, gen7 and gen7.5, max frequency (as in the HW limit) > is not set to RP0, but the value obtaind from PCODE (which

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Unify skylake plane update

2017-08-29 Thread Jani Nikula
On Mon, 28 Aug 2017, Juha-Pekka Heikkila wrote: > Don't handle skylake primary plane separately as it is similar > plane as the others. This misses another reference to skylake_update_primary_plane, as reported by CI. BR, Jani. > > Signed-off-by: Juha-Pekka Heikkila > --- > drivers/gpu/drm/i9

[Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Zhi Wang
The private PAT management is to support PPAT entry manipulation. Two APIs are introduced for dynamically managing PPAT entries: intel_ppat_get and intel_ppat_put. intel_ppat_get will search for an existing PPAT entry which perfectly matches the required PPAT value. If not, it will try to allocate

[Intel-gfx] [RFCv5 1/2] drm/i915: Factor out setup_private_pat()

2017-08-29 Thread Zhi Wang
Factor out setup_private_pat() for introducing the following patches. Cc: Ben Widawsky Cc: Rodrigo Vivi Cc: Chris Wilson Cc: Joonas Lahtinen Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/i915_gem_gtt.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

Re: [Intel-gfx] [PATCH i-g-t v2 2/3] docs: Add user and developer documentation about Chamelium support

2017-08-29 Thread Szwichtenberg, Radoslaw
On Mon, 2017-08-28 at 11:12 +0300, Paul Kocialkowski wrote: > This introduces plain-text documentation about the Chamelium aimed at > users who wish to deploy the platform, as well as developers who wish > to work on improving IGT support for it. > > Given the contents of this documentation, it fe

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFCv5,1/2] drm/i915: Factor out setup_private_pat()

2017-08-29 Thread Patchwork
== Series Details == Series: series starting with [RFCv5,1/2] drm/i915: Factor out setup_private_pat() URL : https://patchwork.freedesktop.org/series/29456/ State : success == Summary == Series 29456v1 series starting with [RFCv5,1/2] drm/i915: Factor out setup_private_pat() https://patchwor

Re: [Intel-gfx] [PATCH i-g-t v4] pm_rps: Changes in waitboost scenario

2017-08-29 Thread Daniel Vetter
On Tue, Aug 29, 2017 at 07:43:20AM +, Szwichtenberg, Radoslaw wrote: > On Mon, 2017-08-28 at 10:50 +0200, Katarzyna Dec wrote: > > CI is observing sporadical failures in pm_rps subtests. > > There are a couple of reasons. One of them is the fact that > > on gen6, gen7 and gen7.5, max frequency

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_exec_reuse: Adds cleanup at the end of test.

2017-08-29 Thread Chris Wilson
Quoting Antonio Argenziano (2017-08-29 00:18:34) > This patch introduces a fixture at the end of the test to destroy > objects that have been created and stop the hang detector. We shouldn't have to. Resources are cleaned up by the kernel, and hang detector is using the fork helper which is meant

Re: [Intel-gfx] [PATCH i-g-t 1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-29 Thread Lionel Landwerlin
Hi Sagar, Thanks for writing this test. It looks promising but there are a few issues that needs to be addressed for this to run in CI. Please have a look at the comments below. Thanks! On 28/08/17 10:53, Sagar Arun Kamble wrote: This test verifies different i915 perf sampling options for fi

Re: [Intel-gfx] [PATCH v2 00/10] Improve robustness of the i915 perf tests

2017-08-29 Thread Lionel Landwerlin
On 28/08/17 15:23, Arkadiusz Hiler wrote: On Mon, Aug 28, 2017 at 02:33:13PM +0100, Lionel Landwerlin wrote: On 28/08/17 08:21, Arkadiusz Hiler wrote: On Wed, Aug 23, 2017 at 10:43:08AM +0100, Lionel Landwerlin wrote: Hi all, Here is an updated patch series containing mostly cleanups. Cheers

[Intel-gfx] [PATCH i-g-t v5] pm_rps: Changes in waitboost scenario

2017-08-29 Thread Katarzyna Dec
CI is observing sporadical failures in pm_rps subtests. There are a couple of reasons. One of them is the fact that on gen6, gen7 and gen7.5, max frequency (as in the HW limit) is not set to RP0, but the value obtaind from PCODE (which may be different from RP0). Thus the test is operating under wr

Re: [Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-29 Thread Chris Wilson
Quoting Jeff McGee (2017-08-28 21:18:44) > On Mon, Aug 28, 2017 at 08:44:48PM +0100, Chris Wilson wrote: > > Quoting jeff.mc...@intel.com (2017-08-28 20:25:30) > > > From: Jeff McGee > > > > > > If someone else is resetting the engine we should clear our own bit as > > > part of skipping that eng

[Intel-gfx] ✓ Fi.CI.BAT: success for pm_rps: Changes in waitboost scenario (rev7)

2017-08-29 Thread Patchwork
== Series Details == Series: pm_rps: Changes in waitboost scenario (rev7) URL : https://patchwork.freedesktop.org/series/28966/ State : success == Summary == IGT patchset tested on top of latest successful build bf45d253648250fc402eee02237366c8882b2053 igt: Add gem_close with latest DRM-Tip k

Re: [Intel-gfx] [RFC v2 2/3] drm/i915/pmu: serve global events and support perf stat

2017-08-29 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 11:38:43PM +, Rogozhkin, Dmitry V wrote: > On Wed, 2017-08-23 at 08:26 -0700, Dmitry Rogozhkin wrote: > > +static cpumask_t i915_pmu_cpumask = CPU_MASK_CPU0; > > Peter, this hardcoding of cpumask to use CPU0 works, but should I > implement something smarter or this will

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-29 Thread Peter Zijlstra
On Mon, Aug 28, 2017 at 10:43:17PM +, Rogozhkin, Dmitry V wrote: > Hi Peter, > > I have updated my fixes to Tvrtko's PMU, they are here: > https://patchwork.freedesktop.org/series/28842/, and I started to check > whether we will be able to cover all the use cases for this PMU which we > had in

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Joonas Lahtinen
On Tue, 2017-08-29 at 16:00 +0800, Zhi Wang wrote: > The private PAT management is to support PPAT entry manipulation. Two > APIs are introduced for dynamically managing PPAT entries: intel_ppat_get > and intel_ppat_put. > > intel_ppat_get will search for an existing PPAT entry which perfectly > m

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [RFCv5,1/2] drm/i915: Factor out setup_private_pat()

2017-08-29 Thread Patchwork
== Series Details == Series: series starting with [RFCv5,1/2] drm/i915: Factor out setup_private_pat() URL : https://patchwork.freedesktop.org/series/29456/ State : failure == Summary == Test kms_flip: Subgroup plain-flip-fb-recreate: pass -> FAIL (shard-hs

[Intel-gfx] [PATCH 1/3] drm/i915: dspaddr_offset doesn't need to be more than local variable

2017-08-29 Thread Juha-Pekka Heikkila
Move u32 dspaddr_offset from struct intel_crtc member into local variable in i9xx_update_primary_plane() Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_display.c | 11 ++- drivers/gpu/drm/i915/intel_drv.h | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) di

[Intel-gfx] [PATCH 3/3] drm/i915: Unify skylake plane disable

2017-08-29 Thread Juha-Pekka Heikkila
Don't handle skylake primary plane separately as it is similar plane as the others. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_display.c | 21 ++--- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_sprite.c | 2 +- 3 files changed,

[Intel-gfx] [PATCH 2/3] drm/i915: Unify skylake plane update

2017-08-29 Thread Juha-Pekka Heikkila
Don't handle skylake primary plane separately as it is similar plane as the others. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_display.c | 81 +--- drivers/gpu/drm/i915/intel_drv.h | 3 ++ drivers/gpu/drm/i915/intel_sprite.c | 2 +- 3

[Intel-gfx] [PATCH 0/3] drm/i915: Skylake plane update/disable unifications [v2]

2017-08-29 Thread Juha-Pekka Heikkila
Fixed missed references which were brough on rebase. /Juha-Pekka Juha-Pekka Heikkila (3): drm/i915: dspaddr_offset doesn't need to be more than local variable drm/i915: Unify skylake plane update drm/i915: Unify skylake plane disable drivers/gpu/drm/i915/intel_display.c | 113

Re: [Intel-gfx] [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse

2017-08-29 Thread Chris Wilson
Quoting Daniel Vetter (2017-08-28 23:12:57) > On Mon, Aug 28, 2017 at 11:46:04AM +0100, Chris Wilson wrote: > > CHECK drivers/gpu/drm/i915/intel_display.c > > drivers/gpu/drm/i915/intel_display.c:3753 intel_finish_reset() warn: > > inconsistent indenting > > > > Signed-off-by: Chris Wilson >

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Always wake the device to flush the GTT

2017-08-29 Thread Chris Wilson
Quoting Patchwork (2017-08-28 21:15:28) > == Series Details == > > Series: drm/i915: Always wake the device to flush the GTT > URL : https://patchwork.freedesktop.org/series/29436/ > State : success > > == Summary == > > Test kms_flip: > Subgroup plain-flip-ts-check: >

Re: [Intel-gfx] [PATCH v2] drm/i915: Recreate vmapping even when the object is pinned

2017-08-29 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-08-28 14:44:36) > On Mon, 2017-08-28 at 11:46 +0100, Chris Wilson wrote: > > Sometimes we know we are the only user of the bo, but since we take a > > protective pin_pages early on, an attempt to change the vmap on the > > object is denied because it is busy. i915_gem_

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Chris Wilson
Quoting Zhi Wang (2017-08-29 09:00:51) > +static void cnl_setup_private_ppat(struct intel_ppat *ppat) > +{ > + ppat->max_entries = 8; > + ppat->update = cnl_private_pat_update; > + ppat->match = bdw_private_pat_match; > + ppat->dummy_value = GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Always wake the device to flush the GTT

2017-08-29 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Chris Wilson > Sent: Tuesday, August 29, 2017 12:59 PM > To: intel-gfx@lists.freedesktop.org; Patchwork > > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] ✓ Fi.CI.IGT

[Intel-gfx] [PATCH i-g-t] tests/kms_atomic: subtest atomic_invalid_params requires CRTC

2017-08-29 Thread Marta Lofstedt
Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_params. This leads to segfault on machines where the subtest should be skipped. Signed-off-by: Marta Lofstedt --- tests/kms_atomic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c index

[Intel-gfx] ✗ Fi.CI.IGT: warning for pm_rps: Changes in waitboost scenario (rev7)

2017-08-29 Thread Patchwork
== Series Details == Series: pm_rps: Changes in waitboost scenario (rev7) URL : https://patchwork.freedesktop.org/series/28966/ State : warning == Summary == Test pm_rps: Subgroup reset: fail -> PASS (shard-hsw) fdo#102250 +1 Test perf: Subgroup bloc

[Intel-gfx] [PATCH] drm/i915: Always wake the device to flush the GTT

2017-08-29 Thread Chris Wilson
Since we hold the device wakeref when writing through the GTT (otherwise the writes would fail), we presumed that before the device sleeps those writes would naturally be flushed and that we wouldn't need our mmio read trick. However, that presumption seems false and a sleepy bxt seems to require u

Re: [Intel-gfx] [PATCH] drm/i915: Don't use GPU relocations prior to cmdparser stalls

2017-08-29 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-08-28 10:26:40) > On Sat, 2017-08-26 at 14:56 +0100, Chris Wilson wrote: > > If we are using the cmdparser, we will have to copy the batch and so > > stall for the relocations. Rather than prolong that stall by adding more > > relocation requests, just use CPU relocati

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Skylake plane update/disable unifications [v2]

2017-08-29 Thread Patchwork
== Series Details == Series: drm/i915: Skylake plane update/disable unifications [v2] URL : https://patchwork.freedesktop.org/series/29462/ State : warning == Summary == Series 29462v1 drm/i915: Skylake plane update/disable unifications [v2] https://patchwork.freedesktop.org/api/1.0/series/294

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Chris Wilson
Quoting Chris Wilson (2017-08-29 11:05:21) > Quoting Zhi Wang (2017-08-29 09:00:51) > > +static void cnl_setup_private_ppat(struct intel_ppat *ppat) > > +{ > > + ppat->max_entries = 8; > > + ppat->update = cnl_private_pat_update; > > + ppat->match = bdw_private_pat_match; > > +

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_atomic: subtest atomic_invalid_params requires CRTC

2017-08-29 Thread Mika Kahola
In my view, this is a valid check. Reviewed-by: Mika Kahola On Tue, 2017-08-29 at 13:32 +0300, Marta Lofstedt wrote: > Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_para > ms. > This leads to segfault on machines where the subtest should be > skipped. > > Signed-off-by: Marta

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Always wake the device to flush the GTT (rev2)

2017-08-29 Thread Patchwork
== Series Details == Series: drm/i915: Always wake the device to flush the GTT (rev2) URL : https://patchwork.freedesktop.org/series/29436/ State : warning == Summary == Series 29436v2 drm/i915: Always wake the device to flush the GTT https://patchwork.freedesktop.org/api/1.0/series/29436/revi

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_atomic: subtest atomic_invalid_params requires CRTC

2017-08-29 Thread Patchwork
== Series Details == Series: tests/kms_atomic: subtest atomic_invalid_params requires CRTC URL : https://patchwork.freedesktop.org/series/29464/ State : success == Summary == IGT patchset tested on top of latest successful build bf45d253648250fc402eee02237366c8882b2053 igt: Add gem_close with

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Wang, Zhi A
Hi Chris: There is mapping between i915 cache level -> PPAT index. Currently it's: static gen8_pte_t gen8_pte_encode(dma_addr_t addr, enum i915_cache_level level) { ... switch (level) { case I915_CACHE_NONE: pte |= PPAT_UNCACHED

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Wang, Zhi A
Thanks Joonas! :) -Original Message- From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] Sent: Tuesday, August 29, 2017 12:37 PM To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org Cc: ch...@chris-wilson.co.uk; zhen...@linux.intel.com; Widaws

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Chris Wilson
Quoting Wang, Zhi A (2017-08-29 12:13:26) > Hi Chris: > There is mapping between i915 cache level -> PPAT index. Currently it's: > > static gen8_pte_t gen8_pte_encode(dma_addr_t addr, > enum i915_cache_level level) > { > ... > switch (level) { >

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Wang, Zhi A
Thanks for the reply! For the hole, per my understanding, the author wanted the mapping to be consistent: i915 cache level <-> PPAT index <-> cache attribute in IA page table in case the GPU and IA may share page tables in future, since actually PPAT index is represented as PAT/PCD/PWT bits in

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Joonas Lahtinen
On Tue, 2017-08-29 at 12:23 +0100, Chris Wilson wrote: > Quoting Wang, Zhi A (2017-08-29 12:13:26) > > Hi Chris: > > There is mapping between i915 cache level -> PPAT index. Currently it's: > > > > static gen8_pte_t gen8_pte_encode(dma_addr_t addr, > > enum i9

Re: [Intel-gfx] [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input

2017-08-29 Thread Paul Kocialkowski
On Mon, 2017-08-28 at 17:55 +0300, Paul Kocialkowski wrote: > Before capturing video, the Chamelium will always wait for the video > input to be stable (and perform the FSM if it was not). This means > that > there is no need to explicitly do it beforehand. > > When the receiver needs to be reset,

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Chris Wilson
Quoting Zhi Wang (2017-08-29 09:00:51) > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > b/drivers/gpu/drm/i915/i915_gem_gtt.c > index b74fa9d..b99b6ca 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -2816,41 +2816,215 @@ static int ggtt_probe

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Chris Wilson
Quoting Zhi Wang (2017-08-29 09:00:51) > The private PAT management is to support PPAT entry manipulation. Two > APIs are introduced for dynamically managing PPAT entries: intel_ppat_get > and intel_ppat_put. > > intel_ppat_get will search for an existing PPAT entry which perfectly > matches the r

[Intel-gfx] ✓ Fi.CI.IGT: success for tests/kms_atomic: subtest atomic_invalid_params requires CRTC

2017-08-29 Thread Patchwork
== Series Details == Series: tests/kms_atomic: subtest atomic_invalid_params requires CRTC URL : https://patchwork.freedesktop.org/series/29464/ State : success == Summary == Test kms_plane: Subgroup plane-panning-bottom-right-suspend-pipe-C-planes: skip -> PASS

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Always sanity check engine state upon idling

2017-08-29 Thread Chris Wilson
Quoting Chris Wilson (2017-08-26 12:09:33) > When we do a locked idle we know that afterwards all requests have been > completed and the engines have been cleared of tasks. For whatever > reason, this doesn't always happen and we may go into a suspend with > ELSP still full, and this causes an issu

Re: [Intel-gfx] [RFCv5 2/2] drm/i915: Introduce private PAT management

2017-08-29 Thread Wang, Zhi A
Sure. I'm digging selftest now. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Tuesday, August 29, 2017 3:18 PM To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org Cc: joonas.lahti...@linux.intel.com; zhen...@linux.intel.c

[Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Open DRM driver without master for hpd storm exit

2017-08-29 Thread Paul Kocialkowski
When running the full chamelium test binary, it occurs that the hpd storm exit handler (that restores its initial value) will fail when trying to acquire DRM master. This happens even though the previously-held DRM file descriptor was closed already. Since there is no need to get DRM master for d

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Always sanity check engine state upon idling

2017-08-29 Thread Joonas Lahtinen
On Sat, 2017-08-26 at 12:09 +0100, Chris Wilson wrote: > When we do a locked idle we know that afterwards all requests have been > completed and the engines have been cleared of tasks. For whatever > reason, this doesn't always happen and we may go into a suspend with > ELSP still full, and this ca

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/igt_debugfs: Open DRM driver without master for hpd storm exit

2017-08-29 Thread Patchwork
== Series Details == Series: lib/igt_debugfs: Open DRM driver without master for hpd storm exit URL : https://patchwork.freedesktop.org/series/29470/ State : success == Summary == IGT patchset tested on top of latest successful build bf45d253648250fc402eee02237366c8882b2053 igt: Add gem_close

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Always sanity check engine state upon idling

2017-08-29 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-08-29 14:07:40) > On Sat, 2017-08-26 at 12:09 +0100, Chris Wilson wrote: > > When we do a locked idle we know that afterwards all requests have been > > completed and the engines have been cleared of tasks. For whatever > > reason, this doesn't always happen and we may

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Always sanity check engine state upon idling

2017-08-29 Thread Mika Kuoppala
Chris Wilson writes: > When we do a locked idle we know that afterwards all requests have been > completed and the engines have been cleared of tasks. For whatever > reason, this doesn't always happen and we may go into a suspend with > ELSP still full, and this causes an issue upon resume as we

Re: [Intel-gfx] [PATCH v3 06/12] tests/perf: rework oa-exponent test

2017-08-29 Thread Lionel Landwerlin
On 23/08/17 23:17, Matthew Auld wrote: On 08/23, Lionel Landwerlin wrote: New issues that were discovered while making the tests work on Gen8+ : - we need to measure timings between periodic reports and discard all other kind of reports - it seems periodicity of the reports can be affe

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Clear wedged status upon resume

2017-08-29 Thread Mika Kuoppala
Chris Wilson writes: > When we wait up from suspend, the device has been powered down and > should come back afresh. We should be able to safely remove the wedged > status from the previous session and start afresh. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Joonas Lahtinen Rev

[Intel-gfx] [PATCH i-g-t v4 03/12] tests/perf: update max buffer size for reading reports

2017-08-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 5058315c..bc5ea133 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1280,9 +1280,7 @@ read_2_oa_reports(int format_id, /* Note: w

[Intel-gfx] [PATCH i-g-t v4 04/12] tests/perf: rc6: try to guess when rc6 is disabled

2017-08-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index bc5ea133..1b441601 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -3445,6 +3445,17 @@ gen8_test_single_ctx_render_target_writes_a_counter(void)

[Intel-gfx] [PATCH i-g-t v4 00/12] Improve robustness of the i915 perf tests

2017-08-29 Thread Lionel Landwerlin
Hi, Some nits by Matthew in patch 6. Cheers, Lionel Landwerlin (11): tests/perf: make stream_fd a global variable tests/perf: update max buffer size for reading reports tests/perf: rc6: try to guess when rc6 is disabled tests/perf: remove frequency related changes tests/perf: rework oa

[Intel-gfx] [PATCH i-g-t v4 02/12] tests/perf: add per context filtering test for gen8+

2017-08-29 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- tests/perf.c | 777 --- 1 file changed, 745 insertions(+), 32 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index ca5bfdc5..5058315c 100644 --- a

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Always sanity check engine state upon idling

2017-08-29 Thread Chris Wilson
Quoting Mika Kuoppala (2017-08-29 14:36:57) > Chris Wilson writes: > > > When we do a locked idle we know that afterwards all requests have been > > completed and the engines have been cleared of tasks. For whatever > > reason, this doesn't always happen and we may go into a suspend with > > ELSP

[Intel-gfx] [PATCH i-g-t v4 01/12] tests/perf: make stream_fd a global variable

2017-08-29 Thread Lionel Landwerlin
When debugging unstable tests on new platforms we currently we don't cleanup everything well in between different tests. Since only a single OA stream fd can be opened at a time, having the stream_fd as a global variable helps us cleanup the state between tests. Signed-off-by: Lionel Landwerlin -

[Intel-gfx] [PATCH i-g-t v4 07/12] tests/perf: make enable-disable more reliable

2017-08-29 Thread Lionel Landwerlin
Estimation of the amount of reports can only refer to periodic ones, as context switch reports completely depend on what happens on the system. Also generate some load to prevent clock frequency changes to impact our measurement. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 96 +++

[Intel-gfx] [PATCH i-g-t v4 11/12] tests/perf: estimate number of blocking/polling based on time spent

2017-08-29 Thread Lionel Landwerlin
Blocking & polling tests define an amount of time to spend in the test and then estimate the number of syscalls that should successfully return. The problem is that while running the test we might spend slightly more time than initiallly planned. This change estimates the number of syscalls based o

[Intel-gfx] [PATCH i-g-t v4 10/12] tests/perf: add Geminilake support

2017-08-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index 32f34ec4..24df7c2a 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1124,6 +1124,9 @@ init_sys_info(void)

[Intel-gfx] [PATCH i-g-t v4 09/12] tests/perf: add Kabylake support

2017-08-29 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index 32d53ea1..32f34ec4 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -,8 +,23 @@ init_sys_info

[Intel-gfx] [PATCH i-g-t v4 05/12] tests/perf: remove frequency related changes

2017-08-29 Thread Lionel Landwerlin
Experience shows that most of the issues we face with periodicity of the reports produced by the OA unit are related to power management, not frequency. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 141 --- 1 file changed, 9 insertio

[Intel-gfx] [PATCH i-g-t v4 08/12] tests/perf: make buffer-fill more reliable

2017-08-29 Thread Lionel Landwerlin
Filling rate of the buffer must discard context switch reports as they do not depend upon the periodicity, instead they're a factor on the amount of different applications concurrently running on the system. Signed-off-by: Lionel Landwerlin Tested-by: Matthew Auld Reviewed-by: Matthew Auld ---

[Intel-gfx] [PATCH i-g-t v4 12/12] tests/perf: prevent power management to kick in when necessary

2017-08-29 Thread Lionel Landwerlin
Some of our tests measure that the OA unit produces reports at expected time intervals (as configured through the PERF_OPEN ioctl). It turns out the power management plays a role in the decision of the OA unit to write reports to memory. Under normal circumstances we don't really mind if the unit m

[Intel-gfx] [PATCH i-g-t v4 06/12] tests/perf: rework oa-exponent test

2017-08-29 Thread Lionel Landwerlin
New issues that were discovered while making the tests work on Gen8+ : - we need to measure timings between periodic reports and discard all other kind of reports - it seems periodicity of the reports can be affected outside of RC6 (frequency change), we can detect this by looking at the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Discard the request queue if we fail to sleep before suspend

2017-08-29 Thread Mika Kuoppala
Chris Wilson writes: > If we fail to clear the outstanding request queue before suspending, > mark those requests as lost. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=102037 > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Joonas Lahtinen > --- > drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH 1/2] drm/atomic: Move drm_crtc_commit to drm_crtc_state.

2017-08-29 Thread Maarten Lankhorst
Most code only cares about the current commit or previous commit. Fortunately we already have a place to track those. Move it to drm_crtc_state where it belongs. :) The per-crtc commit_list is kept for places where we have to look deeper than the current or previous commit for checking whether to

[Intel-gfx] [PATCH 2/2] drm/atomic: Fix freeing connector/plane state too early by tracking commits

2017-08-29 Thread Maarten Lankhorst
Currently we neatly track the crtc state, but forget to look at plane/connector state. When doing a nonblocking modeset, immediately followed by a setprop before the modeset completes, the setprop will see the modesets new state as the old state and free it. This has to be solved by waiting for h

[Intel-gfx] [PATCH 2/2] drm/i915/perf: Remove open-coding of i915_gem_switch_to_kernel_context()

2017-08-29 Thread Chris Wilson
The kernel context does not need to be updated for the oa config, since it is *never* used for anything but idling the device; it should never be required to emit OA samples. As such we can forgo tweaking the context image, and just do a plain switch to enforce the GPU barrier so that we can then u

[Intel-gfx] [PATCH 1/2] drm/i915: Pull wait-for-idle into i915_gem_switch_to_kernel_context()

2017-08-29 Thread Chris Wilson
All callers do want a synchronous switch to the kernel context, that is by the time the call returns, the GPU has evicted all user contexts and now has the kernel context pinned. As all callers want this behaviour, refactor the common wait-for-idle into the switch. Signed-off-by: Chris Wilson Cc:

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/igt_debugfs: Open DRM driver without master for hpd storm exit

2017-08-29 Thread Patchwork
== Series Details == Series: lib/igt_debugfs: Open DRM driver without master for hpd storm exit URL : https://patchwork.freedesktop.org/series/29470/ State : success == Summary == Test kms_atomic_transition: Subgroup plane-all-transition-fencing: skip -> PASS

Re: [Intel-gfx] [PATCH 01/23] mm/shmem: introduce shmem_file_setup_with_mnt

2017-08-29 Thread Joonas Lahtinen
On Fri, 2017-08-25 at 13:49 -0700, Andrew Morton wrote: > On Thu, 24 Aug 2017 13:04:09 +0100 Matthew Auld > wrote: > > > On 23 August 2017 at 23:34, Andrew Morton wrote: > > > On Wed, 23 Aug 2017 12:31:28 +0300 Joonas Lahtinen > > > wrote: > > > > > > > This patch has been floating around fo

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve robustness of the i915 perf tests (rev2)

2017-08-29 Thread Patchwork
== Series Details == Series: Improve robustness of the i915 perf tests (rev2) URL : https://patchwork.freedesktop.org/series/28373/ State : success == Summary == IGT patchset tested on top of latest successful build bf45d253648250fc402eee02237366c8882b2053 igt: Add gem_close with latest DRM-T

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/atomic: Move drm_crtc_commit to drm_crtc_state.

2017-08-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: Move drm_crtc_commit to drm_crtc_state. URL : https://patchwork.freedesktop.org/series/29476/ State : success == Summary == Series 29476v1 series starting with [1/2] drm/atomic: Move drm_crtc_commit to drm_crtc_state. https:

Re: [Intel-gfx] [i-g-t PATCH 00/10] tools/intel_vbt_decode: switch to using kernel intel_vbt_defs.h

2017-08-29 Thread Jani Nikula
On Tue, 29 Aug 2017, Daniel Vetter wrote: > On Mon, Aug 28, 2017 at 03:19:52PM +0300, Jani Nikula wrote: >> There's little point in duplicating the efforts of describing the same >> data in two places. This series lets us use the verbatim copy of the >> intel_vbt_defs.h from kernel. Going forward,

Re: [Intel-gfx] [PATCH 02/23] drm/i915: introduce simple gemfs

2017-08-29 Thread Joonas Lahtinen
On Mon, 2017-08-21 at 19:34 +0100, Matthew Auld wrote: > Not a fully blown gemfs, just our very own tmpfs kernel mount. Doing so > moves us away from the shmemfs shm_mnt, and gives us the much needed > flexibility to do things like set our own mount options, namely huge= > which should allow us to

Re: [Intel-gfx] [PATCH 05/23] drm/i915: push set_pages down to the callers

2017-08-29 Thread Joonas Lahtinen
On Mon, 2017-08-21 at 19:34 +0100, Matthew Auld wrote: > Each backend is now responsible for calling __i915_gem_object_set_pages > upon successfully gathering its backing storage. This eliminates the > inconsistency between the async and sync paths, which stands out even > more when we start throwi

Re: [Intel-gfx] [PATCH 03/23] drm/i915/gemfs: enable THP

2017-08-29 Thread Joonas Lahtinen
On Mon, 2017-08-21 at 19:34 +0100, Matthew Auld wrote: > Enable transparent-huge-pages through gemfs by mounting with > huge=within_size. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Chris Wilson > +++ b/drivers/gpu/drm/i915/i915_gemfs.c > @@ -24,6 +24,7 @@ > > #include >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Pull wait-for-idle into i915_gem_switch_to_kernel_context()

2017-08-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Pull wait-for-idle into i915_gem_switch_to_kernel_context() URL : https://patchwork.freedesktop.org/series/29478/ State : success == Summary == Series 29478v1 series starting with [1/2] drm/i915: Pull wait-for-idle into i915_g

Re: [Intel-gfx] [PATCH] drm/i915: Always wake the device to flush the GTT

2017-08-29 Thread Joonas Lahtinen
On Tue, 2017-08-29 at 11:33 +0100, Chris Wilson wrote: > Since we hold the device wakeref when writing through the GTT (otherwise > the writes would fail), we presumed that before the device sleeps those > writes would naturally be flushed and that we wouldn't need our mmio > read trick. However, t

Re: [Intel-gfx] [PATCH] drm/i915: Always wake the device to flush the GTT

2017-08-29 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-08-29 15:54:06) > On Tue, 2017-08-29 at 11:33 +0100, Chris Wilson wrote: > > Since we hold the device wakeref when writing through the GTT (otherwise > > the writes would fail), we presumed that before the device sleeps those > > writes would naturally be flushed and t

Re: [Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-29 Thread Jeff McGee
On Tue, Aug 29, 2017 at 10:07:18AM +0100, Chris Wilson wrote: > Quoting Jeff McGee (2017-08-28 21:18:44) > > On Mon, Aug 28, 2017 at 08:44:48PM +0100, Chris Wilson wrote: > > > Quoting jeff.mc...@intel.com (2017-08-28 20:25:30) > > > > From: Jeff McGee > > > > > > > > If someone else is resetting

[Intel-gfx] [PATCH i-g-t] docs/chamelium: Explain that the Chamelium should only target one DUT

2017-08-29 Thread Paul Kocialkowski
This adds an explanation about why the Chamelium should only be connected to one target device at once to the in-tree documentation. Signed-off-by: Paul Kocialkowski --- docs/chamelium.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/chamelium.txt b/docs/chamelium.txt index 775

[Intel-gfx] ✓ Fi.CI.IGT: success for Improve robustness of the i915 perf tests (rev2)

2017-08-29 Thread Patchwork
== Series Details == Series: Improve robustness of the i915 perf tests (rev2) URL : https://patchwork.freedesktop.org/series/28373/ State : success == Summary == Test perf: Subgroup oa-exponents: fail -> PASS (shard-hsw) fdo#102254 Subgroup polling:

Re: [Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-29 Thread Chris Wilson
Quoting Jeff McGee (2017-08-29 16:04:17) > On Tue, Aug 29, 2017 at 10:07:18AM +0100, Chris Wilson wrote: > > Quoting Jeff McGee (2017-08-28 21:18:44) > > > On Mon, Aug 28, 2017 at 08:44:48PM +0100, Chris Wilson wrote: > > > > Quoting jeff.mc...@intel.com (2017-08-28 20:25:30) > > > > > From: Jeff M

Re: [Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-29 Thread Chris Wilson
Quoting Jeff McGee (2017-08-28 20:46:00) > On Mon, Aug 28, 2017 at 12:41:58PM -0700, Michel Thierry wrote: > > On 28/08/17 12:25, jeff.mc...@intel.com wrote: > > >From: Jeff McGee > > > > > >If someone else is resetting the engine we should clear our own bit as > > >part of skipping that engine. O

[Intel-gfx] ✓ Fi.CI.BAT: success for docs/chamelium: Explain that the Chamelium should only target one DUT

2017-08-29 Thread Patchwork
== Series Details == Series: docs/chamelium: Explain that the Chamelium should only target one DUT URL : https://patchwork.freedesktop.org/series/29482/ State : success == Summary == IGT patchset tested on top of latest successful build bf45d253648250fc402eee02237366c8882b2053 igt: Add gem_clo

[Intel-gfx] [PATCH] HAX drm/i915: Disable runtime-pm for shard-apl

2017-08-29 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index a1e6b696bcfa..9a8a2ec9fbcd 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -397,6 +397,7 @@ static c

[Intel-gfx] [PATCH i-g-t] tests/audio: Add suspend and hibernate tests for HDMI signal integrity

2017-08-29 Thread Paul Kocialkowski
This introduces tests for HDMI signal integrity after suspend and hibernate. They simply test that signal integrity is ensured before and after suspend or hibernate. Signed-off-by: Paul Kocialkowski --- tests/audio.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/

[Intel-gfx] [PATCH] drm/i915: Flush indirect GTT writes upon runtime-suspend

2017-08-29 Thread Chris Wilson
Our assumption is that indirect writes via the GTT are naturally flushed when we enter runtime suspend. However, from the look of bxt in our CI, this is not true and so we must apply our trick of doing a mmio to serialise the writes. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- drivers/g

[Intel-gfx] ✗ Fi.CI.BAT: warning for HAX drm/i915: Disable runtime-pm for shard-apl

2017-08-29 Thread Patchwork
== Series Details == Series: HAX drm/i915: Disable runtime-pm for shard-apl URL : https://patchwork.freedesktop.org/series/29484/ State : warning == Summary == Series 29484v1 HAX drm/i915: Disable runtime-pm for shard-apl https://patchwork.freedesktop.org/api/1.0/series/29484/revisions/1/mbox/

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/atomic: Move drm_crtc_commit to drm_crtc_state.

2017-08-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: Move drm_crtc_commit to drm_crtc_state. URL : https://patchwork.freedesktop.org/series/29476/ State : failure == Summary == Test perf: Subgroup blocking: fail -> PASS (shard-hsw) fdo#102252

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Always wake the device to flush the GTT (rev3)

2017-08-29 Thread Patchwork
== Series Details == Series: drm/i915: Always wake the device to flush the GTT (rev3) URL : https://patchwork.freedesktop.org/series/29436/ State : success == Summary == Series 29436v3 drm/i915: Always wake the device to flush the GTT https://patchwork.freedesktop.org/api/1.0/series/29436/revi

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Skylake plane update/disable unifications [v2]

2017-08-29 Thread Patchwork
== Series Details == Series: drm/i915: Skylake plane update/disable unifications [v2] URL : https://patchwork.freedesktop.org/series/29462/ State : warning == Summary == Series 29462v1 drm/i915: Skylake plane update/disable unifications [v2] https://patchwork.freedesktop.org/api/1.0/series/294

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/audio: Add suspend and hibernate tests for HDMI signal integrity

2017-08-29 Thread Patchwork
== Series Details == Series: tests/audio: Add suspend and hibernate tests for HDMI signal integrity URL : https://patchwork.freedesktop.org/series/29485/ State : success == Summary == IGT patchset tested on top of latest successful build bf45d253648250fc402eee02237366c8882b2053 igt: Add gem_cl

[Intel-gfx] [PATCH 0/3] drm/i915: add perf support for Coffeelake

2017-08-29 Thread Lionel Landwerlin
Hi all, This series adds support for perf on Coffeelake GT2. This requires some changes in order to identify GT2s chipsets. It seems the scheme that was used before in device IDs isn't there anymore. Cheers, Lionel Landwerlin (3): drm/i915: add GT number to intel_device_info drm/i915: rework

  1   2   >