Re: [Intel-gfx] [PATCH] drm/i915/cnl: WaForceEnableNonCoherent

2017-08-25 Thread Michał Winiarski
On Thu, Aug 24, 2017 at 03:42:05PM -0700, Oscar Mateo wrote: > > > On 08/23/2017 03:02 PM, Rodrigo Vivi wrote: > > Must Force Non-Coherent whenever executing a 3D context. > > This is a workaround for a possible hang in the unlikely event > > a TLB invalidation occurs during a PSD flush. > > Se

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add retries for dp dual mode reads (rev3)

2017-08-25 Thread Patchwork
== Series Details == Series: Add retries for dp dual mode reads (rev3) URL : https://patchwork.freedesktop.org/series/29155/ State : failure == Summary == Series 29155v3 Add retries for dp dual mode reads https://patchwork.freedesktop.org/api/1.0/series/29155/revisions/3/mbox/ Test gem_ringfi

[Intel-gfx] [CI] drm/i915: Skip render state setup (TEST for CI)

2017-08-25 Thread Mika Kuoppala
Curiosity killed the CI farm? Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_render_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_render_state.c b/drivers/gpu/drm/i915/i915_gem_render_state.c index 4dd4c2159a92..022b58475a66 100644

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WaForceEnableNonCoherent

2017-08-25 Thread Mika Kuoppala
Michał Winiarski writes: > On Thu, Aug 24, 2017 at 03:42:05PM -0700, Oscar Mateo wrote: >> >> >> On 08/23/2017 03:02 PM, Rodrigo Vivi wrote: >> > Must Force Non-Coherent whenever executing a 3D context. >> > This is a workaround for a possible hang in the unlikely event >> > a TLB invalidatio

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites

2017-08-25 Thread Daniel Stone
On 24 August 2017 at 20:10, wrote: > Y/Yf somehow dropped out from the SKL+ sprite modifier list. Add them > in. There's no 'somehow': https://lists.freedesktop.org/archives/intel-gfx/2017-August/134932.html I would prefer to not see this pushed whilst it doesn't actually work. Cheers, Daniel

Re: [Intel-gfx] [CI] drm/i915: Skip render state setup (TEST for CI)

2017-08-25 Thread Mika Kuoppala
Mika Kuoppala writes: This was trybot material. Sorry for noise. -Mika > Curiosity killed the CI farm? > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_gem_render_state.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem_render_state.c

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Skip render state setup (TEST for CI)

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915: Skip render state setup (TEST for CI) URL : https://patchwork.freedesktop.org/series/29332/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h C

[Intel-gfx] [PATCH i-g-t 1/2] tests/Makefile.am: Install test-list*.txt to libexecdir

2017-08-25 Thread Petri Latvala
Piglit expects test-list*.txt files to be in the same directory as the test binaries. Installing non-executable files to libexecdir requires going around some of autotools' sanity checks. This change should make 'make install':ed IGT runnable with piglit. Signed-off-by: Petri Latvala Cc: Tomi Sa

[Intel-gfx] [PATCH i-g-t 0/2] Fixing make install

2017-08-25 Thread Petri Latvala
This series makes a 'make install'ed IGT runnable with piglit. One issue is that piglit expects test-list.txt and test-list-full.txt to be in the same directory as the test binaries. Another is that the testlist files were not installed. Petri Latvala (2): tests/Makefile.am: Install test-list*.t

[Intel-gfx] [PATCH i-g-t 2/2] intel-ci: Install testlist files to pkgdata dir

2017-08-25 Thread Petri Latvala
Signed-off-by: Petri Latvala Cc: Tomi Sarvela Cc: Arkadiusz Hiler --- tests/intel-ci/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/intel-ci/Makefile.am b/tests/intel-ci/Makefile.am index 2e9cca7..b3aff97 100644 --- a/tests/intel-ci/Makefile.am +++ b/tests

[Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-08-25 Thread Marta Lofstedt
From: "Lofstedt, Marta" The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* has non-consistent results, pending between fail and pass. The fails are always due to "FBC disabled". With this increase in timeout the flip-flop behavior is no longer reproducible. This is a partial revert of: 64590c

[Intel-gfx] ✓ Fi.CI.BAT: success for Add retries for dp dual mode reads (rev3)

2017-08-25 Thread Patchwork
== Series Details == Series: Add retries for dp dual mode reads (rev3) URL : https://patchwork.freedesktop.org/series/29155/ State : success == Summary == Series 29155v3 Add retries for dp dual mode reads https://patchwork.freedesktop.org/api/1.0/series/29155/revisions/3/mbox/ Test gem_ringfi

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/20] drm/i915: "Race-to-idle" on switching to the kernel context

2017-08-25 Thread Patchwork
== Series Details == Series: series starting with [01/20] drm/i915: "Race-to-idle" on switching to the kernel context URL : https://patchwork.freedesktop.org/series/29201/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-08-25 Thread Petri Latvala
On 08/25/2017 01:40 PM, Marta Lofstedt wrote: After investigating the timeout needed, the conclusion is that the longer timeout is only needed when the test swaps between some specific draw domains, typically blt vs. mmap_cpu. The objective of the FBC part of the tests is not to benchmark draw

Re: [Intel-gfx] [PATCH] drm/i915: "Race-to-idle" on switching to the kernel context

2017-08-25 Thread David Weinehall
On Wed, Aug 23, 2017 at 04:03:44PM +0100, Chris Wilson wrote: > Quoting David Weinehall (2017-08-23 15:54:13) > > On Fri, Aug 18, 2017 at 03:08:15PM +0100, Chris Wilson wrote: > > > During suspend we want to flush out all active contexts and their > > > rendering. To do so we queue a request from t

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-08-25 Thread Chris Wilson
Quoting Marta Lofstedt (2017-08-25 11:40:29) > From: "Lofstedt, Marta" > > The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* > has non-consistent results, pending between fail and pass. > The fails are always due to "FBC disabled". > With this increase in timeout the flip-flop behavior is no

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/kms_hdmi_inject: Require /proc/asound before asserting

2017-08-25 Thread Patchwork
== Series Details == Series: igt/kms_hdmi_inject: Require /proc/asound before asserting URL : https://patchwork.freedesktop.org/series/29217/ State : success == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some informati

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/gem_fence_thresh: Use streaming reads for verify

2017-08-25 Thread Patchwork
== Series Details == Series: igt/gem_fence_thresh: Use streaming reads for verify URL : https://patchwork.freedesktop.org/series/29208/ State : success == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some information abo

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixing make install

2017-08-25 Thread Patchwork
== Series Details == Series: Fixing make install URL : https://patchwork.freedesktop.org/series/29338/ State : success == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some information about the execbuf calls with lates

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites

2017-08-25 Thread Ville Syrjälä
On Fri, Aug 25, 2017 at 10:40:28AM +0100, Daniel Stone wrote: > On 24 August 2017 at 20:10, wrote: > > Y/Yf somehow dropped out from the SKL+ sprite modifier list. Add them > > in. > > There's no 'somehow': > https://lists.freedesktop.org/archives/intel-gfx/2017-August/134932.html > > I would p

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add retries for dp dual mode reads (rev3)

2017-08-25 Thread Patchwork
== Series Details == Series: Add retries for dp dual mode reads (rev3) URL : https://patchwork.freedesktop.org/series/29155/ State : failure == Summary == Test kms_flip: Subgroup flip-vs-expired-vblank-interruptible: pass -> FAIL (shard-hsw) Test kms_sysfs_e

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Switch over to the LLC/eLLC hotspot avoidance hash mode for CCS

2017-08-25 Thread Ville Syrjälä
On Thu, Aug 24, 2017 at 09:55:54PM -0700, Ben Widawsky wrote: > On 17-08-24 22:10:51, Ville Syrjälä wrote: > >From: Ville Syrjälä > > > >Use the LLC/eLLC hotspot avoidance mode for CCS on LLC machines. This is > >reported to give better performance. > > > > Not seeing in the diff how this only hi

Re: [Intel-gfx] [PATCH v14 0/7] drm/i915/gvt: Dma-buf support for GVT-g

2017-08-25 Thread Gerd Hoffmann
On Fri, 2017-08-18 at 18:21 +0800, Tina Zhang wrote: > v13->v14: > 1) add PROBE, DMABUF and REGION flags. (Alex) > 2) return -ENXIO when gem proxy object is banned by ioctl. >    (Chris) (Daniel) > 3) add some details about the float pixel format. (Daniel) > 4) add F suffix to the defined name. (Da

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-08-25 Thread Lofstedt, Marta
> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Friday, August 25, 2017 1:47 PM > To: Lofstedt, Marta ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: > increase FBC wait timeout to 5s >

Re: [Intel-gfx] [PATCH v3] drm/i915: Beef up the IPS vs. CRC workaround

2017-08-25 Thread Ville Syrjälä
On Thu, Aug 17, 2017 at 05:55:09PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Oneshot disabling of IPS when CRC capturing is started is insufficient. > IPS may get re-enabled by any plane update, and hence tests that keep > CRC capturing on across plane updates will sta

[Intel-gfx] [PATCH i-g-t] tests: chamelium: Eliminate reset when preparing output

2017-08-25 Thread Paul Kocialkowski
Resetting the Chamelium when preparing the video output is unnecessary and significant increases the tests run-time. Since all video-related tests work just as well without it, eliminate it. This also adds a call to reset_test in the analog frame dump test, that was missing before, although the ch

Re: [Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list

2017-08-25 Thread Paul Kocialkowski
On Wed, 2017-08-23 at 18:21 +0300, Paul Kocialkowski wrote: > This adds the fastest chamelium tests to the Intel CI fast-feedback > list, with the objective of running in under a minute. For the record, here are average run times for the added tests: dp-hpd-fast: 2.397s dp-edid-read: 1.776s dp-crc

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s (rev2)

2017-08-25 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s (rev2) URL : https://patchwork.freedesktop.org/series/26479/ State : success == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log so

[Intel-gfx] ✗ Fi.CI.IGT: warning for igt/kms_hdmi_inject: Require /proc/asound before asserting

2017-08-25 Thread Patchwork
== Series Details == Series: igt/kms_hdmi_inject: Require /proc/asound before asserting URL : https://patchwork.freedesktop.org/series/29217/ State : warning == Summary == Test vgem_basic: Subgroup unload: pass -> SKIP (shard-hsw) shard-hswtotal:223

Re: [Intel-gfx] [PATCH] drm/i915/guc: Add GuC Load time to debugfs

2017-08-25 Thread Michal Wajdeczko
On Thu, Aug 24, 2017 at 09:38:06PM -0700, Anusha Srivatsa wrote: > Calculate the time that GuC takes to load. > This information could be very useful in > determining if GuC is taking unreasonably long time > to load in a certain platforms. > > Cc: Oscar Mateo > Cc: Michal Wajdeczko > Signed-off

Re: [Intel-gfx] [PATCH 01/10] drm/i915/bios: amend child device config parameters

2017-08-25 Thread Ville Syrjälä
On Thu, Aug 24, 2017 at 09:53:59PM +0300, Jani Nikula wrote: > Add both some new and some old fields to child device config > parameters. Prepare for switching to just one child device config. Use > naming from struct old_child_dev_config for common fields. > > No functional changes. > > Cc: Anim

[Intel-gfx] ✓ Fi.CI.BAT: success for tests: chamelium: Eliminate reset when preparing output

2017-08-25 Thread Patchwork
== Series Details == Series: tests: chamelium: Eliminate reset when preparing output URL : https://patchwork.freedesktop.org/series/29346/ State : success == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some information

Re: [Intel-gfx] [PATCH 2/4] drm/i915: decouple gen9 and gen10 dp signal levels.

2017-08-25 Thread Ville Syrjälä
On Wed, Aug 16, 2017 at 01:19:49PM -0700, Rodrigo Vivi wrote: > Let's decouple bxt, glk and cnl dp signal levels > from other DDIs to avoid confusion. > > No functional change. Only a reorg to avoid messing > with currently working DP signal levels when > moving voltage swing sequences around to m

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-08-25 Thread Lofstedt, Marta
> -Original Message- > From: Lofstedt, Marta > Sent: Friday, August 25, 2017 2:54 PM > To: 'Chris Wilson' ; intel-gfx@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: > increase FBC wait timeout to 5s > > > > > -Original Message-

Re: [Intel-gfx] [PATCH v14 0/7] drm/i915/gvt: Dma-buf support for GVT-g

2017-08-25 Thread Wang, Zhi A
Hi Gerd: Thanks for the testing. We will find out the problem and refresh the whole patch series. Thanks, Zhi. -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Friday, August 25, 2017 2:47 PM To: Zhang, Tina ; zhen...@linux.intel.com; Lv, Zhiyuan ; Wang, Zhi

Re: [Intel-gfx] [RFC PATCH 4/4] drm/i915: Enable voltage swing before enabling DDI_BUF_CTL.

2017-08-25 Thread Ville Syrjälä
On Wed, Aug 16, 2017 at 01:19:51PM -0700, Rodrigo Vivi wrote: > Sequences for DisplayPort asks us to > " Configure voltage swing and related IO settings. > Refer to DDI Buffer section." > > before "Configure and enable DDI_BUF_CTL" > > On BXT and CNL this means to execute the ddi vswing sequences

Re: [Intel-gfx] [PATCH 2/4] drm/i915: decouple gen9 and gen10 dp signal levels.

2017-08-25 Thread Ville Syrjälä
On Fri, Aug 25, 2017 at 03:46:33PM +0300, Ville Syrjälä wrote: > On Wed, Aug 16, 2017 at 01:19:49PM -0700, Rodrigo Vivi wrote: > > Let's decouple bxt, glk and cnl dp signal levels > > from other DDIs to avoid confusion. > > > > No functional change. Only a reorg to avoid messing > > with currently

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-08-25 Thread Chris Wilson
Quoting Lofstedt, Marta (2017-08-25 13:50:16) > > > > -Original Message- > > From: Lofstedt, Marta > > Sent: Friday, August 25, 2017 2:54 PM > > To: 'Chris Wilson' ; > > intel-gfx@lists.freedesktop.org > > Subject: RE: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: > > incr

[Intel-gfx] ✗ Fi.CI.IGT: warning for igt/gem_fence_thresh: Use streaming reads for verify

2017-08-25 Thread Patchwork
== Series Details == Series: igt/gem_fence_thresh: Use streaming reads for verify URL : https://patchwork.freedesktop.org/series/29208/ State : warning == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test perf: Subg

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-08-25 Thread Lofstedt, Marta
+paulo > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Friday, August 25, 2017 4:12 PM > To: Lofstedt, Marta ; intel- > g...@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: > increase FBC wait timeout to

Re: [Intel-gfx] [PATCH 10/12] drm: Fix modifiers_property kernel doc

2017-08-25 Thread Daniel Vetter
On Thu, Aug 24, 2017 at 10:10:58PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The member is called 'modifiers_property' instead of 'modifiers'. Adjust > the kernel docs to match. > > Cc: dri-de...@lists.freedesktop.org > Cc: Ben Widawsky > Cc: Jason Ekstrand > Cc: Da

Re: [Intel-gfx] [PATCH 11/12] drm: Check that the plane supports the request format+modifier combo

2017-08-25 Thread Daniel Vetter
On Thu, Aug 24, 2017 at 10:10:59PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Currently we only check that the plane supports the pixel format of the > fb we're about to feed to it. Extend it to check also the modifier, and > more specifically that the combination of th

Re: [Intel-gfx] [PATCH 01/10] drm/i915/bios: amend child device config parameters

2017-08-25 Thread Jani Nikula
On Fri, 25 Aug 2017, Ville Syrjälä wrote: > On Thu, Aug 24, 2017 at 09:53:59PM +0300, Jani Nikula wrote: >> Add both some new and some old fields to child device config >> parameters. Prepare for switching to just one child device config. Use >> naming from struct old_child_dev_config for common f

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites

2017-08-25 Thread Daniel Stone
Hi, On 25 August 2017 at 12:34, Ville Syrjälä wrote: > On Fri, Aug 25, 2017 at 10:40:28AM +0100, Daniel Stone wrote: >> On 24 August 2017 at 20:10, wrote: >> > Y/Yf somehow dropped out from the SKL+ sprite modifier list. Add them >> > in. >> >> There's no 'somehow': >> https://lists.freedesktop

[Intel-gfx] ✗ Fi.CI.IGT: warning for Fixing make install

2017-08-25 Thread Patchwork
== Series Details == Series: Fixing make install URL : https://patchwork.freedesktop.org/series/29338/ State : warning == Summary == Test vgem_basic: Subgroup unload: pass -> SKIP (shard-hsw) shard-hswtotal:2230 pass:1230 dwarn:0 dfail:0 fail:18

[Intel-gfx] [PATCH 0/4] drm/i915/bios: additional vbt definition cleanups

2017-08-25 Thread Jani Nikula
Follow-up to [1]. BR, Jani. [1] cover.1503600621.git.jani.nikula@intel.com">http://mid.mail-archive.com/cover.1503600621.git.jani.nikula@intel.com Jani Nikula (4): drm/i915/bios: split up iboost to hdmi and dp bitfields drm/i915/bios: amend bdb_general_features drm/i915/bios: amend child

[Intel-gfx] [PATCH 3/4] drm/i915/bios: amend child device flags based on intel_vbt_decode

2017-08-25 Thread Jani Nikula
Copy over some fields defined in the intel_vbt_decode tool. No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_vbt_defs.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers

[Intel-gfx] [PATCH 2/4] drm/i915/bios: amend bdb_general_features

2017-08-25 Thread Jani Nikula
Copy over some fields defined in the intel_vbt_tool. No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_vbt_defs.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drive

[Intel-gfx] [PATCH 1/4] drm/i915/bios: split up iboost to hdmi and dp bitfields

2017-08-25 Thread Jani Nikula
This is according to the style all over the place. No functional changes. Cc: Ville Syrjälä Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 4 ++-- drivers/gpu/drm/i915/intel_vbt_defs.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-

[Intel-gfx] [PATCH 4/4] drm/i915/bios: amend edp block based on intel_vbt_decode

2017-08-25 Thread Jani Nikula
Copy over some fields defined in the intel_vbt_decode tool. No functional changes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 4 ++-- drivers/gpu/drm/i915/intel_vbt_defs.h | 25 - 2 files changed, 22 insertions(+), 7 deletio

Re: [Intel-gfx] [PATCH 0/4] drm/i915/bios: additional vbt definition cleanups

2017-08-25 Thread Jani Nikula
On Fri, 25 Aug 2017, Jani Nikula wrote: > Follow-up to [1]. Oh, and part of the rationale is that I'm migrating intel_vbt_decode to use intel_vbt_defs.h copied over verbatim from the kernel. Going forward, we should not duplicate this stuff. BR, Jani. > > BR, > Jani. > > > [1] cover.1503600621.

Re: [Intel-gfx] [PATCH 3/4] drm/i915/bios: amend child device flags based on intel_vbt_decode

2017-08-25 Thread Ville Syrjälä
On Fri, Aug 25, 2017 at 05:11:22PM +0300, Jani Nikula wrote: > Copy over some fields defined in the intel_vbt_decode tool. No > functional changes. > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_vbt_defs.h | 9 +++-- > 1 file changed, 7 insertions(+),

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: additional vbt definition cleanups

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915/bios: additional vbt definition cleanups URL : https://patchwork.freedesktop.org/series/29357/ State : success == Summary == Series 29357v1 drm/i915/bios: additional vbt definition cleanups https://patchwork.freedesktop.org/api/1.0/series/29357/revisions/1

[Intel-gfx] [PATCH v4 0/1] drm/i915: Deal with upside-down mounted LCD panels

2017-08-25 Thread Hans de Goede
Hi All, When I last send this patch not everyone was enthusiastic about this patch. As already mentioned in the v2 discussion, solving this in userspace is not really feasible since there is no single place to fix it there, it will need fixing in at least 6 different places from the top of my head

[Intel-gfx] [PATCH v4] drm/i915: Deal with upside-down mounted LCD panels

2017-08-25 Thread Hans de Goede
On some (Bay Trail) devices the LCD panel is mounted upside-down. This commit uses the code to read back the initial rotation of the primary plane in get_initial_plane_config from Ville Syrjala's "drm/fb-helper: Inherit rotation wip" patch and when re-using the initial fb it stores that in intel_c

[Intel-gfx] [PATCH] drm/i915: Quietly cancel FBC activation if CRTC is turned off before worker

2017-08-25 Thread Chris Wilson
Since we use a worker to enable FBC on the CRTC, it is possible for the CRTC to be switched off before we run. In this case, the CRTC will not allow us to wait upon a vblank, so remove the DRM_ERROR as this is very much expected. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102410 Fixes:

Re: [Intel-gfx] [PATCH] i915, drm/fourcc: Improve the CCS modifier documentation

2017-08-25 Thread Ville Syrjälä
On Fri, Aug 18, 2017 at 11:34:40AM -0700, Jason Ekstrand wrote: > This updates the documentation on the intel CCS modifiers for a couple > of reasons: > > 1) The old documentation required that the CCS modifier only be used > with formats. While i915 currently only supports CCS scanout

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Deal with upside-down mounted LCD panels (rev2)

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915: Deal with upside-down mounted LCD panels (rev2) URL : https://patchwork.freedesktop.org/series/29161/ State : success == Summary == Series 29161v2 drm/i915: Deal with upside-down mounted LCD panels https://patchwork.freedesktop.org/api/1.0/series/29161/re

Re: [Intel-gfx] [PATCH] drm/i915/guc: Add GuC Load time to debugfs

2017-08-25 Thread Oscar Mateo
Cc: Sujaritha On 08/24/2017 09:38 PM, Anusha Srivatsa wrote: Calculate the time that GuC takes to load. This information could be very useful in determining if GuC is taking unreasonably long time to load in a certain platforms. Cc: Oscar Mateo Cc: Michal Wajdeczko Signed-off-by: Anusha Sriv

[Intel-gfx] [PATCH i-g-t 2/3] docs: Add user and developer documentation about Chamelium support

2017-08-25 Thread Paul Kocialkowski
This introduces plain-text documentation about the Chamelium aimed at users who wish to deploy the platform, as well as developers who wish to work on improving IGT support for it. Given the contents of this documentation, it felt more relevant to make it part of the tree instead of the API refere

[Intel-gfx] [PATCH i-g-t 1/3] lib/igt_core: Use HTML character for documentation comment in example

2017-08-25 Thread Paul Kocialkowski
The gtkdoc output for the example configuration given in the file confuses gtkdoc because of the use of # for comments, that is interpreted as a headline (although it is an example block). This uses the HTML character instead to ensure the rendering is correct. Signed-off-by: Paul Kocialkowski -

[Intel-gfx] [PATCH i-g-t 3/3] docs: Add user documentation about audio support

2017-08-25 Thread Paul Kocialkowski
This introduces plain-text documentation about the audio test, aimed at users who wish to setup and run the audio tests. Given the contents of this documentation, it felt more relevant to make it part of the tree instead of the API reference. Signed-off-by: Paul Kocialkowski --- docs/audio.txt

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Quietly cancel FBC activation if CRTC is turned off before worker

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915: Quietly cancel FBC activation if CRTC is turned off before worker URL : https://patchwork.freedesktop.org/series/29362/ State : success == Summary == Series 29362v1 drm/i915: Quietly cancel FBC activation if CRTC is turned off before worker https://patc

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Nuke a pointless unreachable()

2017-08-25 Thread Emil Velikov
On 25 August 2017 at 05:40, Ben Widawsky wrote: > This was specifically requested by Emil. > Not quite, a gist is below. Regardless, I do not want inspire lengthy discussions over a trivial suggestion. Please proceed as you gents prefer. Thanks Emil a)Original code if X return A; else if Y

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] lib/igt_core: Use HTML character for documentation comment in example

2017-08-25 Thread Patchwork
== Series Details == Series: series starting with [1/3] lib/igt_core: Use HTML character for documentation comment in example URL : https://patchwork.freedesktop.org/series/29363/ State : success == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae6132

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WaForceEnableNonCoherent

2017-08-25 Thread Oscar Mateo
On 08/25/2017 12:41 AM, Michał Winiarski wrote: On Thu, Aug 24, 2017 at 03:42:05PM -0700, Oscar Mateo wrote: On 08/23/2017 03:02 PM, Rodrigo Vivi wrote: Must Force Non-Coherent whenever executing a 3D context. This is a workaround for a possible hang in the unlikely event a TLB invalidati

Re: [Intel-gfx] [PATCH] drm/i915/guc: Add GuC Load time to debugfs

2017-08-25 Thread Srivatsa, Anusha
>-Original Message- >From: Mateo Lozano, Oscar >Sent: Friday, August 25, 2017 8:18 AM >To: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org >Cc: Wajdeczko, Michal ; Sundaresan, Sujaritha > >Subject: Re: [PATCH] drm/i915/guc: Add GuC Load time to debugfs > >Cc: Sujaritha > Thanks Osca

[Intel-gfx] [PATCH] drm/i915: Mark wait_for_engine() as maybe_unused

2017-08-25 Thread Matthias Kaehlcke
The only call of wait_for_engine() is wrapped in a GEM_WARN_ON macro, which confusingly suppresses the call unless CONFIG_DRM_I915_DEBUG_GEM is set. According to http://www.spinics.net/lists/intel-gfx/msg128768.html the current behavior is correct, even though it's not obvious. Different solutions

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for lib: Avoid actually throttling from igt_require_gem() (rev2)

2017-08-25 Thread Daniel Vetter
On Thu, Aug 24, 2017 at 01:22:40PM -, Patchwork wrote: > == Series Details == > > Series: lib: Avoid actually throttling from igt_require_gem() (rev2) > URL : https://patchwork.freedesktop.org/series/28983/ > State : failure 2 r-b tags and no comment on why it failed CI? Smells like review

Re: [Intel-gfx] [PATCH 00/12] drm/i915: Fix up the CCS code

2017-08-25 Thread Daniel Vetter
On Thu, Aug 24, 2017 at 10:10:48PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Looks like we ended up with a stale version of my CCS code in dinq. > This series contains the remainder in smaller chunks. I also ended > up adding a bunch of extra cleanup etc. on top. > >

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for Fixing make install

2017-08-25 Thread Daniel Vetter
On Fri, Aug 25, 2017 at 02:08:33PM -, Patchwork wrote: > == Series Details == > > Series: Fixing make install > URL : https://patchwork.freedesktop.org/series/29338/ > State : warning > > == Summary == > > Test vgem_basic: > Subgroup unload: > pass -> SKIP

Re: [Intel-gfx] [PATCH] drm/i915: Quietly cancel FBC activation if CRTC is turned off before worker

2017-08-25 Thread Daniel Vetter
On Fri, Aug 25, 2017 at 04:02:15PM +0100, Chris Wilson wrote: > Since we use a worker to enable FBC on the CRTC, it is possible for the > CRTC to be switched off before we run. In this case, the CRTC will not > allow us to wait upon a vblank, so remove the DRM_ERROR as this is very > much expected.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Mark wait_for_engine() as maybe_unused

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915: Mark wait_for_engine() as maybe_unused URL : https://patchwork.freedesktop.org/series/29365/ State : success == Summary == Series 29365v1 drm/i915: Mark wait_for_engine() as maybe_unused https://patchwork.freedesktop.org/api/1.0/series/29365/revisions/1/m

[Intel-gfx] [PATCH igt] lib/kmod: Fix error reporting for kmod load/unload

2017-08-25 Thread Chris Wilson
A "return -err ? err < 0 : err" managed to slip through. So if err was set, we returned 0 or 1 based on sign, or 0 if err was zero. If err is negative, we want treat it as an error, so report it back to the caller, all other values were a success, so convert those to 0. This should actually be no

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for lib: Avoid actually throttling from igt_require_gem() (rev2)

2017-08-25 Thread Chris Wilson
Quoting Daniel Vetter (2017-08-25 18:11:56) > On Thu, Aug 24, 2017 at 01:22:40PM -, Patchwork wrote: > > == Series Details == > > > > Series: lib: Avoid actually throttling from igt_require_gem() (rev2) > > URL : https://patchwork.freedesktop.org/series/28983/ > > State : failure > > 2 r-b

[Intel-gfx] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s (rev2)

2017-08-25 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s (rev2) URL : https://patchwork.freedesktop.org/series/26479/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test

[Intel-gfx] ✓ Fi.CI.IGT: success for tests: chamelium: Eliminate reset when preparing output

2017-08-25 Thread Patchwork
== Series Details == Series: tests: chamelium: Eliminate reset when preparing output URL : https://patchwork.freedesktop.org/series/29346/ State : success == Summary == Test perf: Subgroup blocking: fail -> PASS (shard-hsw) fdo#102252 Test vgem_basic:

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/kmod: Fix error reporting for kmod load/unload

2017-08-25 Thread Patchwork
== Series Details == Series: lib/kmod: Fix error reporting for kmod load/unload URL : https://patchwork.freedesktop.org/series/29368/ State : success == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some information about

[Intel-gfx] [PATCH i-g-t 1/4] lib: Add some syncobj helpers (v2)

2017-08-25 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- lib/Makefile.sources | 2 + lib/igt_syncobj.c| 207 +++ lib/igt_syncobj.h| 71 ++ 3 files changed, 280 insertions(+) create mode 100644 lib/igt_syncobj.c create mode 100644 lib/igt_synco

[Intel-gfx] [PATCH i-g-t 4/4] syncobj: Add a test for SYNCOBJ_CREATE_SIGNALED

2017-08-25 Thread Jason Ekstrand
--- tests/syncobj_basic.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/syncobj_basic.c b/tests/syncobj_basic.c index 0a304f1..acc4a64 100644 --- a/tests/syncobj_basic.c +++ b/tests/syncobj_basic.c @@ -146,6 +146,16 @@ test_bad_create_flags(int fd) igt_assert(ret

[Intel-gfx] [PATCH i-g-t 2/4] tests/syncobj: Convert the basic test over to the helpers

2017-08-25 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- tests/syncobj_basic.c | 77 +-- 1 file changed, 19 insertions(+), 58 deletions(-) diff --git a/tests/syncobj_basic.c b/tests/syncobj_basic.c index a7a6742..0a304f1 100644 --- a/tests/syncobj_basic.c +++ b/tests/syn

[Intel-gfx] [PATCH i-g-t 3/4] tests/syncobj: Add some wait and reset tests (v6)

2017-08-25 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] lib: Add some syncobj helpers (v2)

2017-08-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] lib: Add some syncobj helpers (v2) URL : https://patchwork.freedesktop.org/series/29370/ State : success == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some inform

[Intel-gfx] [PATCH igt] igt/vgem_basic: Load and unload the module first

2017-08-25 Thread Chris Wilson
To ensure the module exists, first load it. Then when we try to unload the module (to check that our modprobe interface works), we will not get spurious failures due to -ENOENT (in this case meaning the module did not exist): (vgem_basic:18361) igt-core-DEBUG: Starting subtest: unload (vgem_basic:

Re: [Intel-gfx] [PATCH i-g-t] tests: chamelium: Eliminate reset when preparing output

2017-08-25 Thread Lyude Paul
R-B'd and pushed, thanks! On Fri, 2017-08-25 at 15:03 +0300, Paul Kocialkowski wrote: > Resetting the Chamelium when preparing the video output is > unnecessary > and significant increases the tests run-time. Since all video-related > tests work just as well without it, eliminate it. > > This als

[Intel-gfx] [PATCH igt v2] igt/vgem_basic: Load and unload the module first

2017-08-25 Thread Chris Wilson
To ensure the module exists, first load it. Then when we try to unload the module (to check that our modprobe interface works), we will not get spurious failures due to -ENOENT (in this case meaning the module did not exist): (vgem_basic:18361) igt-core-DEBUG: Starting subtest: unload (vgem_basic:

[Intel-gfx] ✗ Fi.CI.BAT: warning for igt/vgem_basic: Load and unload the module first

2017-08-25 Thread Patchwork
== Series Details == Series: igt/vgem_basic: Load and unload the module first URL : https://patchwork.freedesktop.org/series/29371/ State : warning == Summary == IGT patchset tested on top of latest successful build 29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some information about

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for lib: Avoid actually throttling from igt_require_gem() (rev2)

2017-08-25 Thread Daniel Vetter
On Fri, Aug 25, 2017 at 06:39:01PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-08-25 18:11:56) > > On Thu, Aug 24, 2017 at 01:22:40PM -, Patchwork wrote: > > > == Series Details == > > > > > > Series: lib: Avoid actually throttling from igt_require_gem() (rev2) > > > URL : https

Re: [Intel-gfx] [RFC v2 3/3] drm/i915/pmu: deny perf driver level sampling of i915 PMU

2017-08-25 Thread Rogozhkin, Dmitry V
Returning mailing list back. Just tried ./intel-gpu-overlay. From what I see it wonderfully works even when I wiped out event->sampling_period from i915 RFC PMU and prohibited it. Mind that I did not remove sampling inside i915 RFC PMU: I removed only timer staff which is exposed to the perf co

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/vgem_basic: Load and unload the module first (rev2)

2017-08-25 Thread Patchwork
== Series Details == Series: igt/vgem_basic: Load and unload the module first (rev2) URL : https://patchwork.freedesktop.org/series/29371/ State : success == Summary == IGT patchset tested on top of latest successful build 60f6a12195395934f179d5ecc080353190d19a6c tests: chamelium: Eliminate re

[Intel-gfx] [PATCH] drm/i915/cnl: don't hardcode DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT

2017-08-25 Thread Paulo Zanoni
We have the macro, use it. Makes the code a little easier to understand. Cc: Rodrigo Vivi Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_d

Re: [Intel-gfx] [PATCH] drm/i915/cnl: don't hardcode DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT

2017-08-25 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Fri, Aug 25, 2017 at 12:40 PM, Paulo Zanoni wrote: > We have the macro, use it. Makes the code a little easier to > understand. > > Cc: Rodrigo Vivi > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+)

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: additional vbt definition cleanups

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915/bios: additional vbt definition cleanups URL : https://patchwork.freedesktop.org/series/29357/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test perf: Subgrou

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: don't hardcode DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915/cnl: don't hardcode DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT URL : https://patchwork.freedesktop.org/series/29373/ State : success == Summary == Series 29373v1 drm/i915/cnl: don't hardcode DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT https://patchwork.freedesktop.org/api/1.0/se

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Deal with upside-down mounted LCD panels (rev2)

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915: Deal with upside-down mounted LCD panels (rev2) URL : https://patchwork.freedesktop.org/series/29161/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test perf:

Re: [Intel-gfx] [PATCH 01/23] mm/shmem: introduce shmem_file_setup_with_mnt

2017-08-25 Thread Andrew Morton
On Thu, 24 Aug 2017 13:04:09 +0100 Matthew Auld wrote: > On 23 August 2017 at 23:34, Andrew Morton wrote: > > On Wed, 23 Aug 2017 12:31:28 +0300 Joonas Lahtinen > > wrote: > > > >> This patch has been floating around for a while now Acked and without > >> further comments. It is blocking us f

[Intel-gfx] [PATCH 02/10] drm/i915: decouple gen9 and gen10 dp signal levels.

2017-08-25 Thread Rodrigo Vivi
Let's decouple bxt, glk and cnl dp signal levels from other DDIs to avoid confusion. No functional change. Only a reorg to avoid messing with currently working DP signal levels when moving voltage swing sequences around to match spec. v2: ddi_signal_levels is also called from other ddi platfo

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc : Removing enable_guc_loading module

2017-08-25 Thread Daniele Ceraolo Spurio
On 23/08/17 15:11, Sujaritha Sundaresan wrote: Whenever we need i915.enable_guc_submission=1, we also need enable_guc_loading=1. We also need enable_guc_loading=1 when we want to verify the HuC, which is every time we have a HuC (but all platforms with HuC have a GuC and viceversa). We don't

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Quietly cancel FBC activation if CRTC is turned off before worker

2017-08-25 Thread Patchwork
== Series Details == Series: drm/i915: Quietly cancel FBC activation if CRTC is turned off before worker URL : https://patchwork.freedesktop.org/series/29362/ State : failure == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912

Re: [Intel-gfx] [PATCH 1/2] mm: Track actual nr_scanned during shrink_slab()

2017-08-25 Thread Andrew Morton
On Thu, 24 Aug 2017 10:00:49 +0200 Vlastimil Babka wrote: > > Even if a > > shrinker has a mistake, VM will have big trouble like infinite loop. > > We could fake 0 as 1 or something, at least. If the shrinker returns sc->nr_scanned==0 then that's a buggy shrinker - it should return SHRINK_STOP

  1   2   >