[Intel-gfx] ✗ Fi.CI.BAT: warning for YCBCR 4:2:0 support for LSPCON

2017-08-09 Thread Patchwork
== Series Details == Series: YCBCR 4:2:0 support for LSPCON URL : https://patchwork.freedesktop.org/series/28536/ State : warning == Summary == Series 28536v1 YCBCR 4:2:0 support for LSPCON https://patchwork.freedesktop.org/api/1.0/series/28536/revisions/1/mbox/ Test gem_exec_suspend:

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for YCBCR 4:2:0 support for LSPCON

2017-08-09 Thread Sharma, Shashank
These failure are from Parade based LSPCON's, where the delay is not yet fine tuned: [ 197.761072] [drm:lspcon_write_infoframe [i915]] *ERROR* LSPCON FW not ready for infoframes [ 197.761100] [drm:lspcon_write_infoframe [i915]] *ERROR* Failed to write AVI infoframes Regards Shashank -Orig

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-09 Thread Zhang, Tina
> -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Alex Williamson > Sent: Tuesday, August 8, 2017 1:43 AM > To: Zhang, Tina > Cc: Tian, Kevin ; intel-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; kwankh...@nvid

Re: [Intel-gfx] [PATCH 3/8] drm/i915/gen10: Calculate and enable transition WM

2017-08-09 Thread Maarten Lankhorst
Op 18-07-17 om 14:49 schreef Mahesh Kumar: > From: "Kumar, Mahesh" > > GEN > 9 require transition WM to be programmed if IPC is enabled. > This patch calculates & enable transition WM for supported platforms. > If transition WM is enabled, Plane read requests are sent at high > priority until fill

Re: [Intel-gfx] [PATCH] drm/i915: Clear lost context-switch interrupts across reset

2017-08-09 Thread Chris Wilson
Quoting Dong, Chuanxiao (2017-08-09 01:26:00) > > -Original Message- > > From: Thierry, Michel > > Sent: Tuesday, August 8, 2017 1:40 AM > > To: Chris Wilson ; intel-gfx@lists.freedesktop.org > > Cc: Dong, Chuanxiao ; Ursulin, Tvrtko > > ; Winiarski, Michal > > Subject: Re: [PATCH] drm/i91

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] lib: Add hooks for enabling ftrace

2017-08-09 Thread Petri Latvala
On Tue, Aug 08, 2017 at 02:46:51PM +, Patchwork wrote: > PASS: igt_list_only > XFAIL: igt_no_exit_list_only > XFAIL: igt_no_subtest > FAIL: igt_simulation > XFAIL: igt_no_exit > FAIL: igt_segfault > PASS: igt_fork_helper > FAIL: igt_exit_handler > XFAIL: igt_simple_test_subtests > FAIL: igt_hdm

[Intel-gfx] [PATCH i-g-t] tests/kms_flip: Remove $engine-flip-vs-dpms/modeset

2017-08-09 Thread Maarten Lankhorst
This is already tested in kms_busy, and without cs flips there's no point in doing those tests any more. Signed-off-by: Maarten Lankhorst --- tests/kms_flip.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index ede5fd2ba9c5..e

Re: [Intel-gfx] [PATCH igt] tools/null_state_gen: Don't upload color calc and depth stencil on gen6

2017-08-09 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2017-08-08 14:36:59) >> Mika Kuoppala writes: >> >> > We were pointing the color calc and depth stencil states blindly >> > to an offset of 1k from bb start. This was foolhardy as it collides >> > with other state in the batch and results in a wreck

[Intel-gfx] [PATCH igt] tools/null_state_gen: Add proper color calc and depth stencil states

2017-08-09 Thread Mika Kuoppala
We were just pointing these states blindly into the 1k offset in the bb. Make a suitable sized and aligned null block and point both indirect state pointers to that block. v2: move blend state generation into the same function Reported-by: Chris Wilson Signed-off-by: Mika Kuoppala --- tools/nu

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl+: debugfs entry to control IPC

2017-08-09 Thread Maarten Lankhorst
Op 18-07-17 om 14:49 schreef Mahesh Kumar: > From: "Kumar, Mahesh" > > This patch creates an entry in debugfs to check the status of IPC. > This can also be used to enable/disable IPC in supported platforms. > > Signed-off-by: Mahesh Kumar > --- > drivers/gpu/drm/i915/i915_debugfs.c | 73 >

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl+: debugfs entry to control IPC

2017-08-09 Thread Maarten Lankhorst
Op 18-07-17 om 14:49 schreef Mahesh Kumar: > From: "Kumar, Mahesh" > > This patch creates an entry in debugfs to check the status of IPC. > This can also be used to enable/disable IPC in supported platforms. > > Signed-off-by: Mahesh Kumar > --- > drivers/gpu/drm/i915/i915_debugfs.c | 73 >

Re: [Intel-gfx] [PATCH 7/8] drm/i915/bxt+: Enable IPC support

2017-08-09 Thread Maarten Lankhorst
Op 18-07-17 om 14:49 schreef Mahesh Kumar: > From: "Kumar, Mahesh" > > This patch adds IPC support. This patch also enables IPC in all supported > platforms based on has_ipc flag. > IPC (Isochronous Priority Control) is the hardware feature, which > dynamically controls the memory read priority of

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl+: debugfs entry to control IPC

2017-08-09 Thread Mahesh Kumar
Hi, Thanks for review. On Wednesday 09 August 2017 03:03 PM, Maarten Lankhorst wrote: Op 18-07-17 om 14:49 schreef Mahesh Kumar: From: "Kumar, Mahesh" This patch creates an entry in debugfs to check the status of IPC. This can also be used to enable/disable IPC in supported platforms. Sign

[Intel-gfx] [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl

2017-08-09 Thread Chris Wilson
==24749== Syscall param ioctl(generic) points to uninitialised byte(s) ==24749==at 0x6A8ADC7: ioctl (syscall-template.S:84) ==24749==by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0) ==24749==by 0x138531: kmstest_set_connector_dpms (igt_kms.c:1022) ==24749==by 0x112937: se

[Intel-gfx] [PATCH 3/8] drm/i915/guc: Handle GuC HW/SW state cleanup in unload path

2017-08-09 Thread Sagar Arun Kamble
Teardown of GuC HW/SW state was not properly done in unload path. During unload, we can rely on intel_guc_reset_prepare being done as part of i915_gem_suspend for disabling GuC interfaces. We will have to disable GuC submission prior to suspend as that involves communication with GuC to destroy doo

[Intel-gfx] [PATCH 6/8] drm/i915/guc: Change default GuC FW for BXT to v9.29

2017-08-09 Thread Sagar Arun Kamble
This patch makes v9.29 firmware as default firmware for BXT. This update includes (since v8.7): - Added support to log media reset count for host to read it - BXT WA for fixing MTP hangs. WaDisableDOPRenderClkGatingAtSubmit - Sub-feature level control for power management features. - Minor clean-u

[Intel-gfx] [PATCH 2/8] drm/i915/guc: Handle GuC interaction in reset/suspend scenarios

2017-08-09 Thread Sagar Arun Kamble
Tearing down of guc_ggtt_invalidate/guc_interrupts/guc_communication setup should happen towards end of reset/suspend as these are setup back again during recovery/resume. Prepared helpers intel_guc_pause and intel_guc_unpause that will do teardown/bringup of this setup along with suspension/resum

[Intel-gfx] [PATCH 7/8] drm/i915/guc: Change default GuC FW for KBL to v9.39

2017-08-09 Thread Sagar Arun Kamble
This patch makes v9.39 firmware as default firmware for KBL. This update includes (since v9.14): - DCC spec changes for BXT + DCT enabling - Bug Fix for power conservation feature SLPC_DCC - Scheduler 1-element submission during DCC cycles. - SB based Pre-ETM/ETM flow enabling for debug signed GuC

[Intel-gfx] [PATCH 1/8] drm/i915: Separate GuC/HuC specific functionality from intel_uc

2017-08-09 Thread Sagar Arun Kamble
Removed unnecessary intel_uc.h includes as it is present in i915_drv.h. Created intel_guc.c and intel_guc.h for placing GuC specific code. Created intel_huc.h to refer to HuC specific functions. Cc: Chris Wilson Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Signed-off-by: Sagar Arun Kamble -

[Intel-gfx] [PATCH 4/8] drm/i915/guc: Disable critical logging in GuC by default from GuC v9

2017-08-09 Thread Sagar Arun Kamble
From GuC v9 firmware (for KBL v9.39+), separate control is added to enable critical logging in GuC to enable capturing minimal important logs in production systems. i915.guc_log_level controls the verbosity and logging in GuC for logs other than critical logs. By default, logging in GuC is disabled

[Intel-gfx] [PATCH 5/8] drm/i915/guc: Change default GuC FW for SKL to v9.33

2017-08-09 Thread Sagar Arun Kamble
This patch makes v9.33 firmware as default firmware for SKL. This update includes (since v6.1): - HuC RSA Keys updated. - Adding per engine preemption support in GuC scheduler - Minor bug fixes. - Added support to log media reset count for host to read it - Sub-feature level control for power mana

[Intel-gfx] ✓ Fi.CI.BAT: success for tools/null_state_gen: Add proper color calc and depth stencil states

2017-08-09 Thread Patchwork
== Series Details == Series: tools/null_state_gen: Add proper color calc and depth stencil states URL : https://patchwork.freedesktop.org/series/28542/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_

Re: [Intel-gfx] [PATCH 4/8] drm/i915/guc: Disable critical logging in GuC by default from GuC v9

2017-08-09 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-08-09 11:23:48) > From GuC v9 firmware (for KBL v9.39+), separate control is added to enable > critical logging in GuC to enable capturing minimal important logs in > production systems. > i915.guc_log_level controls the verbosity and logging in GuC for logs other >

Re: [Intel-gfx] [PATCH igt] lib/kms: Clear unused fields for getproperty ioctl

2017-08-09 Thread Mika Kuoppala
Chris Wilson writes: > ==24749== Syscall param ioctl(generic) points to uninitialised byte(s) > ==24749==at 0x6A8ADC7: ioctl (syscall-template.S:84) > ==24749==by 0x5067687: drmIoctl (in /opt/xorg/lib64/libdrm.so.2.4.0) > ==24749==by 0x138531: kmstest_set_connector_dpms (igt_kms.c:102

Re: [Intel-gfx] [RFC i-g-t] tests/gem_exec_basic: Documentation for subtests

2017-08-09 Thread Fiedorowicz, Lukasz
Hi, I'm a bit confused by this patch. How is this idea different from what previous patch from Petri offered? I mean what additional value does this solution brings? Is this something we want on top of previous solution or instead of previous solution? This doesn't take in to account auto generated

[Intel-gfx] [maintainer-tools PATCH 2/7] dim: fix end-of-line in regex

2017-08-09 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- dim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dim b/dim index af1baa11c7b2..eaabcec43c8f 100755 --- a/dim +++ b/dim @@ -1970,7 +1970,7 @@ function dim_add_missing_cc name='' if echo "$cc" | grep -q '

[Intel-gfx] [maintainer-tools PATCH 1/7] dim: don't run add-missing-cc on merge commits

2017-08-09 Thread Eric Engestrom
get_maintainer.pl needs a diff, so this script can't run on a merge commit. Signed-off-by: Eric Engestrom --- dim | 5 + 1 file changed, 5 insertions(+) diff --git a/dim b/dim index 619d855b321b..af1baa11c7b2 100755 --- a/dim +++ b/dim @@ -1960,6 +1960,11 @@ function dim_fixes function d

[Intel-gfx] [maintainer-tools PATCH 5/7] dim: move empty name logic to function

2017-08-09 Thread Eric Engestrom
Fair warning: this slightly changes the behaviour, as $testname would previously contain the email if $testcc didn't contain a name. Shouldn't affect anything though. Signed-off-by: Eric Engestrom --- dim | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/dim b/dim in

[Intel-gfx] [maintainer-tools PATCH 3/7] dim: split out email parsing functions

2017-08-09 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- dim | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/dim b/dim index eaabcec43c8f..a656afa0d255 100755 --- a/dim +++ b/dim @@ -1958,6 +1958,16 @@ function dim_fixes fi } +function email_get_address +{ + sed

[Intel-gfx] [maintainer-tools PATCH 4/7] dim: merge string substitutions

2017-08-09 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index a656afa0d255..4ffac497c621 100755 --- a/dim +++ b/dim @@ -1965,7 +1965,7 @@ function email_get_address function email_get_name { - echo ${cc/<*/} | sed -e 's/[[:spac

[Intel-gfx] [maintainer-tools PATCH 7/7] dim: protect against escaped chars when reading cc'ed emails

2017-08-09 Thread Eric Engestrom
Suggested by shellcheck (`make check`). Signed-off-by: Eric Engestrom --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index 2e22fefa8867..75ce55188af4 100755 --- a/dim +++ b/dim @@ -2002,7 +2002,7 @@ function dim_add_missing_cc return

[Intel-gfx] [maintainer-tools PATCH 6/7] dim: split out 'is email cc'ed in latest commit' to a function

2017-08-09 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- dim | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/dim b/dim index 481a53e23035..2e22fefa8867 100755 --- a/dim +++ b/dim @@ -1970,6 +1970,31 @@ function email_get_name fi } +function

[Intel-gfx] [PATCH i-g-t 2/2] docs: Include subtest documentation

2017-08-09 Thread Petri Latvala
A simple and naive format: Double newline denotes paragraph change, otherwise insert subtest documentation into the generated docs as-is. Signed-off-by: Petri Latvala --- This works for me, but I don't know if the generated docs are actually valid docbook xml. docs/reference/intel-gpu-tools/

[Intel-gfx] [PATCH i-g-t 1/2] Add support for subtest-specific documentation

2017-08-09 Thread Petri Latvala
The current documentation for tests is limited to a single string per test binary. This patch adds support for documenting individual subtests. The syntax for subtest documentation is: igt_document_subtest("Frob knobs to see if one of the " "crossbeams will go out of sk

Re: [Intel-gfx] [PATCH i-g-t 1/2] Add support for subtest-specific documentation

2017-08-09 Thread Arkadiusz Hiler
On Wed, Aug 09, 2017 at 02:40:49PM +0300, Petri Latvala wrote: > The current documentation for tests is limited to a single string per > test binary. This patch adds support for documenting individual > subtests. > > The syntax for subtest documentation is: > >igt_document_subtest("Frob knobs

[Intel-gfx] [PULL] drm-intel-fixes

2017-08-09 Thread Jani Nikula
Hi Dave, drm/i915 fixes for v4.13-rc5. BR, Jani. The following changes since commit aae4e7a8bc44722fe70d58920a36916b1043195e: Linux 4.13-rc4 (2017-08-06 18:44:49 -0700) are available in the git repository at: git://anongit.freedesktop.org/git/drm-intel tags/drm-intel-fixes-2017-08-09-1 f

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] lib: Add hooks for enabling ftrace

2017-08-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib: Add hooks for enabling ftrace URL : https://patchwork.freedesktop.org/series/28491/ State : failure == Summary == IGT patchset build failed on latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic.

[Intel-gfx] [PATCH igt 2/2] lib/core: Don't leak dummyloads between subtests

2017-08-09 Thread Chris Wilson
If a test fails or skips early, it may not clean up after itself. In lieu of having a framework for test deconstructors, hook igt_terminate_spin_batches() into exit_subtest() itself so that we don't allow a recursive batch from an earlier test to leak into the next and cause an unexpected GPU hang.

[Intel-gfx] [PATCH igt 1/2] lib/dummyload: Wrap global list inside its own mutex

2017-08-09 Thread Chris Wilson
Give the list a mutex, for we try to iterate over it from many a random context. Signed-off-by: Chris Wilson --- lib/igt_dummyload.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/igt_dummyload.c b/lib/igt_dummyload.c index 5ad386a5..5d654825 100644 --- a/lib/igt_dummyload.c +++

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Introduce intel_ddi_dp_level.

2017-08-09 Thread Jani Nikula
On Tue, 08 Aug 2017, Rodrigo Vivi wrote: > +static uint32_t intel_ddi_dp_level(struct intel_dp *intel_dp) Sorry to pick on specifically this patch when there continue to be offenders all over the place... but shouldn't we prefer the kernel types over standard C types? Not that checkpatch is an au

[Intel-gfx] ✗ Fi.CI.BAT: failure for lib/kms: Clear unused fields for getproperty ioctl

2017-08-09 Thread Patchwork
== Series Details == Series: lib/kms: Clear unused fields for getproperty ioctl URL : https://patchwork.freedesktop.org/series/28546/ State : failure == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. with lates

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] lib: Add hooks for enabling ftrace

2017-08-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib: Add hooks for enabling ftrace URL : https://patchwork.freedesktop.org/series/28491/ State : failure == Summary == IGT patchset build failed on latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] Add support for subtest-specific documentation

2017-08-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] Add support for subtest-specific documentation URL : https://patchwork.freedesktop.org/series/28554/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add sy

Re: [Intel-gfx] [maintainer-tools PATCH 1/7] dim: don't run add-missing-cc on merge commits

2017-08-09 Thread Jani Nikula
On Wed, 09 Aug 2017, Eric Engestrom wrote: > get_maintainer.pl needs a diff, so this script can't run on a merge > commit. > > Signed-off-by: Eric Engestrom > --- > dim | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/dim b/dim > index 619d855b321b..af1baa11c7b2 100755 > --- a/dim >

Re: [Intel-gfx] [maintainer-tools PATCH 2/7] dim: fix end-of-line in regex

2017-08-09 Thread Jani Nikula
On Wed, 09 Aug 2017, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > dim | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dim b/dim > index af1baa11c7b2..eaabcec43c8f 100755 > --- a/dim > +++ b/dim > @@ -1970,7 +1970,7 @@ function dim_add_missing_cc >

Re: [Intel-gfx] [maintainer-tools PATCH 3/7] dim: split out email parsing functions

2017-08-09 Thread Jani Nikula
On Wed, 09 Aug 2017, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > dim | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/dim b/dim > index eaabcec43c8f..a656afa0d255 100755 > --- a/dim > +++ b/dim > @@ -1958,6 +1958,16 @@ function dim_fi

[Intel-gfx] [dim PATCH] dim: drop rebuild-nightly alias

2017-08-09 Thread Jani Nikula
Let tab completion handle rebuild-tip better. If someone needs the old alias, it can be placed in ~/.dimrc. Signed-off-by: Jani Nikula --- dim | 1 - 1 file changed, 1 deletion(-) diff --git a/dim b/dim index 619d855b321b..f576fca0488a 100755 --- a/dim +++ b/dim @@ -546,7 +546,6 @@ function com

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] lib: Add hooks for enabling ftrace

2017-08-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] lib: Add hooks for enabling ftrace URL : https://patchwork.freedesktop.org/series/28491/ State : failure == Summary == IGT patchset build failed on latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic.

[Intel-gfx] [PATCH igt] lib/kms: Pass fd to igt_enable_connectors()

2017-08-09 Thread Chris Wilson
Pass the fd along to igt_enable_connectors() so that it actually dtrt when there are multiple drm devices in the system. Signed-off-by: Chris Wilson --- lib/igt_kms.c| 13 - lib/igt_kms.h| 2 +- tests/kms_flip.c | 2 +- tests/kms_invalid_

Re: [Intel-gfx] [RFC i-g-t] tests/gem_exec_basic: Documentation for subtests

2017-08-09 Thread Szwichtenberg, Radoslaw
On Tue, 2017-08-08 at 15:09 -0700, Vinay Belgaumkar wrote: > This is an RFC for adding documentation to IGT subtests. Each subtest can have > something similar to a WHAT - explaining what the subtest actually does, > and a WHY - which explains a use case, if applicable. Additionally, > include comm

[Intel-gfx] [PULL] drm-misc-fixes

2017-08-09 Thread Sean Paul
Hi Dave, Here's the -fixes pull for last week. Considering this is 2 weeks worth, it's pretty light. You might recognize some of these patches. The rockchip set and Chris' dma-buf patch were also applied to -misc-next. Misplaced patches continues to be the primary growing pain for the misc trees.

Re: [Intel-gfx] [PATCH] drm/i915: Allow HW status page to be bound high

2017-08-09 Thread Joonas Lahtinen
On ti, 2017-08-08 at 13:54 +0100, Chris Wilson wrote: > At the time of commit 1f767e02d69f ("drm/i915: HWS must be in the > mappable region for g33"), drm_mm insertion would often default to > placing a new object high in the zone forcing us to specify that certain > HWSP must be bound within the l

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Separate GuC/HuC specific functionality from intel_uc

2017-08-09 Thread Michal Wajdeczko
On Wed, Aug 09, 2017 at 03:53:45PM +0530, Sagar Arun Kamble wrote: > Removed unnecessary intel_uc.h includes as it is present in i915_drv.h. > Created intel_guc.c and intel_guc.h for placing GuC specific code. > Created intel_huc.h to refer to HuC specific functions. > > Cc: Chris Wilson > Cc: Mi

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-09 Thread Kirti Wankhede
On 8/8/2017 11:37 PM, Alex Williamson wrote: > On Tue, 8 Aug 2017 14:18:07 +0530 > Kirti Wankhede wrote: > >> On 8/7/2017 11:13 PM, Alex Williamson wrote: >>> On Mon, 7 Aug 2017 08:11:43 + >>> "Zhang, Tina" wrote: >>> After going through the previous discussions, here are some summ

Re: [Intel-gfx] [RFC i-g-t] tests/gem_exec_basic: Documentation for subtests

2017-08-09 Thread Arkadiusz Hiler
On Tue, Aug 08, 2017 at 03:09:00PM -0700, Vinay Belgaumkar wrote: > This is an RFC for adding documentation to IGT subtests. Each subtest can have > something similar to a WHAT - explaining what the subtest actually does, > and a WHY - which explains a use case, if applicable. Additionally, > inclu

Re: [Intel-gfx] [PATCH 3/8] drm/i915/guc: Handle GuC HW/SW state cleanup in unload path

2017-08-09 Thread Michal Wajdeczko
On Wed, Aug 09, 2017 at 03:53:47PM +0530, Sagar Arun Kamble wrote: > Teardown of GuC HW/SW state was not properly done in unload path. > During unload, we can rely on intel_guc_reset_prepare being done > as part of i915_gem_suspend for disabling GuC interfaces. > We will have to disable GuC submiss

[Intel-gfx] [PATCH] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Chris Wilson
Another case where we need to call sysfs_attr_init() to setup the internal lockdep class prior to use: [9.325229] BUG: key 880168bc7bb0 not in .data! [9.325240] DEBUG_LOCKS_WARN_ON(1) [9.325250] [ cut here ] [9.325280] WARNING: CPU: 1 PID: 275 at kernel/

Re: [Intel-gfx] [PATCH] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Lionel Landwerlin
Right, that's exactly what I was asking in our previous exchange. You need to leave the memset() I think, because we check further down that function that id == 0 to detect failure to recognize that the (Gen, GT) is supported. Unless there is a guarantee that dev_priv is fully memset()? Thank

Re: [Intel-gfx] [PATCH] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-08-09 15:57:59) > Right, that's exactly what I was asking in our previous exchange. I just follow the traces, and am internally screaming at how much we are stuffing inside drm_i915_private nowadays. > You need to leave the memset() I think, because we check furth

Re: [Intel-gfx] [PATCH] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Lionel Landwerlin
On 09/08/17 16:02, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-09 15:57:59) Right, that's exactly what I was asking in our previous exchange. I just follow the traces, and am internally screaming at how much we are stuffing inside drm_i915_private nowadays. You need to leave the

Re: [Intel-gfx] [PATCH] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Lionel Landwerlin
On 09/08/17 16:14, Lionel Landwerlin wrote: On 09/08/17 16:02, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-09 15:57:59) Right, that's exactly what I was asking in our previous exchange. I just follow the traces, and am internally screaming at how much we are stuffing inside drm_i915

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/perf: Initialise dynamic sysfs group before creation URL : https://patchwork.freedesktop.org/series/28560/ State : warning == Summary == Series 28560v1 drm/i915/perf: Initialise dynamic sysfs group before creation https://patchwork.freedesktop.org/api/1.0/

[Intel-gfx] [PATCH 1/2] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Chris Wilson
Another case where we need to call sysfs_attr_init() to setup the internal lockdep class prior to use: [9.325229] BUG: key 880168bc7bb0 not in .data! [9.325240] DEBUG_LOCKS_WARN_ON(1) [9.325250] [ cut here ] [9.325280] WARNING: CPU: 1 PID: 275 at kernel/

[Intel-gfx] [PATCH 2/2] drm/i915/perf: Drop lockdep assert for i915_oa_init_reg_state()

2017-08-09 Thread Chris Wilson
This is called from execlist context init which we need to be unlocked. Commit f89823c21224 ("drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface") added a lockdep assert to this path for unclear reasons, remove it again! Fixes: 701f8231a2fe ("drm/i915/perf: prune OA configs") Signed-of

[Intel-gfx] [PATCH] drm/i915/perf: Drop redundant check for perf.initialised on reset

2017-08-09 Thread Chris Wilson
As we cannot have an exclusive stream set if the perf has not been initialized, we only need to check for that exclusive stream. Signed-off-by: Chris Wilson Cc: Lionel Landwerlin Cc: Matthew Auld --- drivers/gpu/drm/i915/i915_perf.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-)

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/perf: Drop redundant check for perf.initialised on reset

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/perf: Drop redundant check for perf.initialised on reset URL : https://patchwork.freedesktop.org/series/28564/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generate

Re: [Intel-gfx] [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2)

2017-08-09 Thread Matt Roper
On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote: > Hi Matt, Mauro, > > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > > On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote: > > > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for > > > decoding DMI mem

[Intel-gfx] [PATCH v3 14/16] drm/i915/guc: Enable GuC interrupts when using CT

2017-08-09 Thread Michal Wajdeczko
We will need them in G2H communication to properly handle responses and requests from the Guc. v2: keep irq enabled while disabling GuC logging (Oscar) Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Daniele Ceraolo Spurio Cc: Michel Thierry --- drivers/gpu/drm/i915/i915_guc_submission.c

[Intel-gfx] [PATCH] drm/i915: Supply the engine-id for our mock_engine()

2017-08-09 Thread Chris Wilson
In the initial selftest, we didn't care what the engine->id was, just that it could uniquely identify it. Later though, we started tracking in the fixed size arrays around the drm_i915_private and so we now require it to be appropriate. This becomes an issue when using the standalone harness of run

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-09 Thread Alex Williamson
On Wed, 9 Aug 2017 08:31:00 + "Zhang, Tina" wrote: > > -Original Message- > > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > > Behalf Of Alex Williamson > > Sent: Tuesday, August 8, 2017 1:43 AM > > To: Zhang, Tina > > Cc: Tian, Kevin ; intel-gfx@lists.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Supply the engine-id for our mock_engine()

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915: Supply the engine-id for our mock_engine() URL : https://patchwork.freedesktop.org/series/28565/ State : success == Summary == Series 28565v1 drm/i915: Supply the engine-id for our mock_engine() https://patchwork.freedesktop.org/api/1.0/series/28565/revis

Re: [Intel-gfx] [RFC i-g-t] tests/gem_exec_basic: Documentation for subtests

2017-08-09 Thread Belgaumkar, Vinay
On 8/9/2017 7:32 AM, Arkadiusz Hiler wrote: On Tue, Aug 08, 2017 at 03:09:00PM -0700, Vinay Belgaumkar wrote: This is an RFC for adding documentation to IGT subtests. Each subtest can have something similar to a WHAT - explaining what the subtest actually does, and a WHY - which explains a use

[Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

Re: [Intel-gfx] [PATCH v3 14/16] drm/i915/guc: Enable GuC interrupts when using CT

2017-08-09 Thread Oscar Mateo
On 08/09/2017 09:24 AM, Michal Wajdeczko wrote: We will need them in G2H communication to properly handle responses and requests from the Guc. v2: keep irq enabled while disabling GuC logging (Oscar) Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Daniele Ceraolo Spurio Cc: Michel Thie

[Intel-gfx] ✗ Fi.CI.BAT: failure for syncobj: Add some wait and reset tests

2017-08-09 Thread Patchwork
== Series Details == Series: syncobj: Add some wait and reset tests URL : https://patchwork.freedesktop.org/series/28567/ State : failure == Summary == IGT patchset build failed on latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. make all-recursive Mak

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Introduce intel_ddi_dp_level.

2017-08-09 Thread Vivi, Rodrigo
On Wed, 2017-08-09 at 15:20 +0300, Jani Nikula wrote: > On Tue, 08 Aug 2017, Rodrigo Vivi wrote: > > +static uint32_t intel_ddi_dp_level(struct intel_dp *intel_dp) > > Sorry to pick on specifically this patch when there continue to be > offenders all over the place... don't be sorry. I'm glad t

[Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests (v2)

2017-08-09 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-09 18:04:42) > This adds both trivial error-checking tests as well as more complex > tests which actually test whether or not waits do what they're supposed > to do. They only currently work on i915 but it should be simple to hook > them up for other drivers by simp

[Intel-gfx] [PATCH] drm/i915/guc: Rename GuC irq trigger function

2017-08-09 Thread Michal Wajdeczko
We should emphasize that irq trigger function depends on Gen. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_uc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c index 2

[Intel-gfx] [PATCH] drm/i915: Update from drm-next

2017-08-09 Thread Jason Ekstrand
--- include/drm/i915_drm.h | 61 ++ 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 5ebe046..c26bf7c 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -412,6 +412,

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Daniel Stone
Hi Jason, On 9 August 2017 at 18:04, Jason Ekstrand wrote: > +/* One one tenth of a second */ > +#define SHORT_TIME_NSEC 1ull Er, a hundredth? Or only one, one tenth? > +static void > +test_wait_illegal_handle(int fd) > +{ > + struct drm_syncobj_wait wait = { 0 }; > + uint32

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Preserve SRD_CTL bit 29 on PSR init

2017-08-09 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Tue, Aug 8, 2017 at 2:51 PM, Jim Bride wrote: > Bit 29 of SRD_CTL needs to have its value preserved according to the > B-Spec, so right before we write out the register we go ahead and read > the register and preserve the value of that bit before we write out > the c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Rename GuC irq trigger function

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/guc: Rename GuC irq trigger function URL : https://patchwork.freedesktop.org/series/28570/ State : success == Summary == Series 28570v1 drm/i915/guc: Rename GuC irq trigger function https://patchwork.freedesktop.org/api/1.0/series/28570/revisions/1/mbox/

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 10:28 AM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-08-09 18:04:42) > > This adds both trivial error-checking tests as well as more complex > > tests which actually test whether or not waits do what they're supposed > > to do. They only currently work on i915 but

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Preserve SRD_CTL bit 29 on PSR init

2017-08-09 Thread Rodrigo Vivi
merged to dinq. Thanks for the patch and reviews On Wed, Aug 9, 2017 at 10:37 AM, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi > > On Tue, Aug 8, 2017 at 2:51 PM, Jim Bride wrote: >> Bit 29 of SRD_CTL needs to have its value preserved according to the >> B-Spec, so right before we write out

[Intel-gfx] ✗ Fi.CI.BAT: failure for syncobj: Add some wait and reset tests (rev2)

2017-08-09 Thread Patchwork
== Series Details == Series: syncobj: Add some wait and reset tests (rev2) URL : https://patchwork.freedesktop.org/series/28567/ State : failure == Summary == IGT patchset build failed on latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. make all-recurs

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 10:28 AM, Chris Wilson wrote: > > [snip] > > Key tests missing here are signal (SIGINT) handling, especially how the > timeout parameters is handled on repeats, see igt_interruptible(), though > you must use igt_ioctl(). I'll see what I can do > Polling multiple handles

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-09 18:46:49) > On Wed, Aug 9, 2017 at 10:28 AM, Chris Wilson > wrote: > > Quoting Jason Ekstrand (2017-08-09 18:04:42) > > This adds both trivial error-checking tests as well as more complex > > tests which actually test whether or not waits do what th

[Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests (v3)

2017-08-09 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

[Intel-gfx] [PATCH] drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Chris Wilson
To further facilitate GEM testing, allow testing of drm_syncobj by attaching them to vgem fences. These fences are already employed by igt for testing inter-driver fence handling (across dmabuf and sync_file). An igt example use would be like: int vgem = drm_driver_open(DRIVER_VGEM); uint32

[Intel-gfx] ✓ Fi.CI.BAT: success for syncobj: Add some wait and reset tests (rev3)

2017-08-09 Thread Patchwork
== Series Details == Series: syncobj: Add some wait and reset tests (rev3) URL : https://patchwork.freedesktop.org/series/28567/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. with latest DRM

Re: [Intel-gfx] [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

2017-08-09 Thread Noralf Trønnes
Den 09.08.2017 01.42, skrev Joe Kniss: Because all drivers currently use gem objects for framebuffer planes, the virtual create_handle() is not required. This change adds a struct drm_gem_object *gems[4] field to drm_framebuffer and removes create_handle() function pointer from drm_framebuffer_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Patchwork
== Series Details == Series: drm/vgem: Couple in drm_syncobj support URL : https://patchwork.freedesktop.org/series/28576/ State : success == Summary == Series 28576v1 drm/vgem: Couple in drm_syncobj support https://patchwork.freedesktop.org/api/1.0/series/28576/revisions/1/mbox/ Test gem_exe

[Intel-gfx] [PATCH v6] drm/i915/edp: Allow alternate fixed mode for eDP if available.

2017-08-09 Thread Jim Bride
Some fixed resolution panels actually support more than one mode, with the only thing different being the refresh rate. Having this alternate mode available to us is desirable, because it allows us to test PSR on panels whose setup time at the preferred mode is too long. With this patch we allow t

Re: [Intel-gfx] [PATCH 1/3] drm/i915/cnl: Add allowed DP rates for Cannonlake.

2017-08-09 Thread Rodrigo Vivi
Clint or Mika, could you please review this patch and next 2 here? I remember Clint telling me at some point that rates had possibly change on spec but I checked here and I still see: "eDP/DP link bit rates: 1.62, 2.16, 2.7, 3.24, 4.32, 5.4, 6.48*, 8.1* GHz" Thanks in advance, Rodrigo. On Thu, J

[Intel-gfx] [PATCH] drm/i915/cnl: Add slice and subslice information to debugfs.

2017-08-09 Thread Rodrigo Vivi
A missing part to EU slice power gating is the debugfs interface. This patch actually should have been squashed to the initial EU slice power gating one. v2: Initial patch was merged without this part. Fixes: c7ae7e9ab207 ("drm/i915/cnl: Configure EU slice power gating.") Cc: Joonas Lahtinen Sig

[Intel-gfx] [PATCH igt] igt: Add vgem_syncobj

2017-08-09 Thread Chris Wilson
Exercise the drm_syncobj / vGEM coupling. Signed-off-by: Chris Wilson --- lib/igt_vgem.c | 68 +++- lib/igt_vgem.h | 15 +++- tests/Makefile.sources | 1 + tests/vgem_syncobj.c | 212 + 4 files changed, 276 inserti

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Allow alternate fixed mode for eDP if available.

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/edp: Allow alternate fixed mode for eDP if available. URL : https://patchwork.freedesktop.org/series/28578/ State : success == Summary == Series 28578v1 drm/i915/edp: Allow alternate fixed mode for eDP if available. https://patchwork.freedesktop.org/api/1.

Re: [Intel-gfx] [PATCH i-g-t 1/2] Add support for subtest-specific documentation

2017-08-09 Thread Belgaumkar, Vinay
On 8/9/2017 4:40 AM, Petri Latvala wrote: The current documentation for tests is limited to a single string per test binary. This patch adds support for documenting individual subtests. The syntax for subtest documentation is: igt_document_subtest("Frob knobs to see if one of the "

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Add slice and subslice information to debugfs.

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Add slice and subslice information to debugfs. URL : https://patchwork.freedesktop.org/series/28579/ State : success == Summary == Series 28579v1 drm/i915/cnl: Add slice and subslice information to debugfs. https://patchwork.freedesktop.org/api/1.0/se

  1   2   >