Re: [Intel-gfx] linux-next: unsigned commits in the drm-misc tree

2017-07-26 Thread Daniel Vetter
Oops, that shouldn't have happened. Actually, our maintainer tooling ensures this doesn't happen, by auto-adding the committer sob line. But these patches (and a bunch of others pushed by Benjamin) haven't been pushed by our tooling it seems (the Link: tag is missing at least). Benjamin, what happ

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-26 Thread Datczuk, Andrzej
Adding Marek and Sebastian for Perf config register whitelist expertise :) Please comment the previous Lionel's message (Tuesday, July 25, 2017 6:04 PM). As for 0x2b00, it isn't included, note the different bracket (exclusive range). Regards, Andrzej -Original Message- From: Landwerlin,

Re: [Intel-gfx] [PATCH i-g-t 1/2] igt: Move read_rc6_residency function to lib

2017-07-26 Thread Szwichtenberg, Radoslaw
On Tue, 2017-07-25 at 17:26 +0200, Ewelina Musial wrote: > Gem_mocs_settings and pm_rc6_residency tests are defining > the same functionality to read residency from sysfs. > Moving that function to lib/igt_aux and updating tests. > > Signed-off-by: Ewelina Musial Reviewed-by: Radoslaw Szwichtenbe

[Intel-gfx] [GIT PULL] GVT-g fixes for 4.13-rc3

2017-07-26 Thread Zhenyu Wang
Hi, here's current gvt fixes for 4.13. One vblank timer close bug fixed by Fred and enable more KBL SKUs besides E3 server. Thanks. -- The following changes since commit 0cf5ec41839d82ee7f8fbb47f137b7afc562b9f1: drm/i915/gvt: Use fence error from GVT request for workload status (2017-07-11 13

Re: [Intel-gfx] [PATCH i-g-t 2/3] configure.ac: Disable chamelium by default and add enable argument

2017-07-26 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 13:07 -0400, Lyude Paul wrote: > I like this patch, however there's a mistake in it: > > On Tue, 2017-07-25 at 15:48 +0300, Paul Kocialkowski wrote: > > Since the chamelium is not a very usual piece of hardware and > > requires > > pulling-in lots of specific dependencies, it

[Intel-gfx] [PATCH i-g-t v2] configure.ac: Disable chamelium by default and add enable argument

2017-07-26 Thread Paul Kocialkowski
Since the chamelium is not a very usual piece of hardware and requires pulling-in lots of specific dependencies, it makes sense to keep it disabled by default. An explicit --enable-chamelium argument is provided to enable it when necessary. This also leads to more predictable results than automati

Re: [Intel-gfx] [PATCH] drm/i915: Handle msr read failure gracefully

2017-07-26 Thread Chris Wilson
Quoting Gabriel Krisman Bertazi (2017-07-26 06:30:16) > Chris Wilson writes: > > > Quoting Gabriel Krisman Bertazi (2017-07-25 19:19:22) > >> power = (power & 0x1f00) >> 8; > >> units = 100 / (1 << power); /* convert to uJ */ > >> power = I915_READ(MCH_SECP_NRG_STTS);

[Intel-gfx] [PATCH i-g-t 0/2] Test case for NV12 functionality

2017-07-26 Thread Vidya Srinivas
This series implements a test case for checking NV12 functionality for linear/tile-X/tile-Y tiling formats. The series adds NV12 functionality to the IGT library. The series is based on previous version posted by Chandra Konduru during 2015 based on the IGT framework available then. Previous versi

[Intel-gfx] [PATCH i-g-t 1/2] Prep work for adding NV12 testcase

2017-07-26 Thread Vidya Srinivas
From: chandra konduru This patch adds necessary prep work for nv12 testcase: - updated fb allocation functions to handle NV12 format - igt helper function to return png image size - igt helper function to calculate start of uv in a given NV12 buffer - igt helper function to map buffer for host ac

[Intel-gfx] [PATCH i-g-t 2/2] tests/test_nv12.c: This patch adds test_nv12 test case. It is a simple test that covers testing NV12 in linear/tile-X/tile-Y tiling formats.

2017-07-26 Thread Vidya Srinivas
From: chandra konduru Previous version reference https://patchwork.freedesktop.org/patch/59067/ was posted by Chandra Konduru on Sept 9 2015 based on the IGT framework available at that time Current version: Rebased as per current IGT (me). This version tests basic NV12 in linear/tile-X/tile-Y t

Re: [Intel-gfx] [RFC 04/14] drm/i915/pmu: Decouple uAPI engine ids

2017-07-26 Thread Tvrtko Ursulin
On 25/07/2017 02:18, Ben Widawsky wrote: On 17-07-18 15:36:08, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As elsewhere in the code we have to decouple the binary engine identifiers for easier maintenance. Also the sampler mask was incorrect in the timer callback. I don't quite understand

Re: [Intel-gfx] [RFC 07/14] drm/i915/pmu: Add fake regs

2017-07-26 Thread Tvrtko Ursulin
On 25/07/2017 02:20, Ben Widawsky wrote: On 17-07-18 15:36:11, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Without this I can get a null ptr deref when trying to access our events with perf. Signed-off-by: Tvrtko Ursulin This definitely seems unsafe, but should be squashed in somewhere ea

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Only skip updating execobject.offset after error

2017-07-26 Thread Joonas Lahtinen
On pe, 2017-07-21 at 15:50 +0100, Chris Wilson wrote: > I was being overly paranoid in not updating the execobject.offset after > performing the fallback copy where we set reloc.presumed_offset to -1. > The thinking was to ensure that a subsequent NORELOC execbuf would be > forced to process the in

Re: [Intel-gfx] [PATCH] drm/i915: Rework sdvo proxy i2c locking

2017-07-26 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-26 07:02:44) > lockdep complaints about a locking recursion for the i2c bus lock > because both the sdvo ddc proxy bus and the gmbus nested within use > the same locking class. It's not really a deadlock since we never nest > the other way round, but it's annoying. >

Re: [Intel-gfx] [RFC v3] drm/hdcp: drm enum property for CP State

2017-07-26 Thread Ramalingam C
On Tuesday 25 July 2017 06:04 PM, Sean Paul wrote: On Mon, Jul 24, 2017 at 2:12 PM, Ramalingam C wrote: DRM connector property is created to represent the content protection state of the connector and to configure the same. Content protection states defined: DRM_MODE_CONTENT_PROTECT

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Force CPU synchronisation even if userspace requests ASYNC

2017-07-26 Thread Joonas Lahtinen
On pe, 2017-07-21 at 15:50 +0100, Chris Wilson wrote: > The goal here was to minimise doing any thing or any check inside the > kernel that was not strictly required. For a userspace that assumes > complete control over the cache domains, the kernel is usually using > outdated information and may t

Re: [Intel-gfx] [RFC 00/14] i915 PMU and engine busy stats

2017-07-26 Thread Tvrtko Ursulin
On 20/07/2017 10:03, Tvrtko Ursulin wrote: On 19/07/2017 13:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-07-18 15:36:04) From: Tvrtko Ursulin Rough sketch of the idea I mentioned a few times to various people - merging the engine busyness tracking with Chris i915 PMU RFC. First pa

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Force CPU synchronisation even if userspace requests ASYNC

2017-07-26 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-07-26 11:19:26) > On pe, 2017-07-21 at 15:50 +0100, Chris Wilson wrote: > > The goal here was to minimise doing any thing or any check inside the > > kernel that was not strictly required. For a userspace that assumes > > complete control over the cache domains, the ke

[Intel-gfx] [intel-gfx][i-g-t][help]can't read the backlight

2017-07-26 Thread Gu, HailinX
Hi~ all, I try to run the test pm_backlight. But there is an skip with the log as following. IGT-Version: 1.19-g4258cc8e (x86_64) (Linux: 4.10.0 x86_64) Test requirement not met in function __real_main154, file pm_backlight.c:163: Test requirement: !(backlight_read(&old, "brightness"))

Re: [Intel-gfx] [RFC 00/14] i915 PMU and engine busy stats

2017-07-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-07-26 11:34:49) > > On 20/07/2017 10:03, Tvrtko Ursulin wrote: > > On 19/07/2017 13:05, Chris Wilson wrote: > >> Quoting Tvrtko Ursulin (2017-07-18 15:36:04) > >>> From: Tvrtko Ursulin > >>> > >>> Rough sketch of the idea I mentioned a few times to various people - >

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-26 Thread Szulc, Sebastian
0x2b04 - what is the setting for this register in the kernel? It is a debug register and we would like to control it too <0x91B8,0x91C8> - these are not simple counters only - a couple of bits are used to choose the right event to measure, so we need read/write access Regards, S. -Origina

Re: [Intel-gfx] [PATCH] drm/i915: Handle msr read failure gracefully

2017-07-26 Thread Chris Wilson
Quoting Chris Wilson (2017-07-26 09:39:31) > Quoting Gabriel Krisman Bertazi (2017-07-26 06:30:16) > > When reading the i915_energy_uJ debugfs file, it tries to fetch > > MSR_RAPL_POWER_UNIT, which might not be available, like in a vm > > environment, causing the exception shown below. > > > > We

Re: [Intel-gfx] [PATCH v2 3/7] drm/rcar-du: Use new iterator macros, v2.

2017-07-26 Thread Laurent Pinchart
Hi Maarten, Thank you for the patch. On Wednesday 19 Jul 2017 16:39:16 Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the correct new > iterator macros. > > Also look at new_plane_state instead of plane->state when looking up > the hw planes in use. They should b

Re: [Intel-gfx] linux-next: unsigned commits in the drm-misc tree

2017-07-26 Thread Daniel Vetter
On Wed, Jul 26, 2017 at 9:09 AM, Daniel Vetter wrote: > Oops, that shouldn't have happened. Actually, our maintainer tooling > ensures this doesn't happen, by auto-adding the committer sob line. > But these patches (and a bunch of others pushed by Benjamin) haven't > been pushed by our tooling it

[Intel-gfx] [PULL] drm-misc-next remix edition

2017-07-26 Thread Sean Paul
Hi Dave, Here's the revised pull from -misc-next with fixed history. It's mostly comprised of last week's PR, but has a few changes on top that I've summarized as well. Once you pull this, I'll backmerge/ff to pick up the stm changes which will hopefully stop the spread of the rebase/bad history.

Re: [Intel-gfx] [PULL] drm-misc-next remix edition

2017-07-26 Thread Daniel Vetter
Hi Dave, On Wed, Jul 26, 2017 at 2:27 PM, Sean Paul wrote: > Hi Dave, > Here's the revised pull from -misc-next with fixed history. It's mostly > comprised of last week's PR, but has a few changes on top that I've summarized > as well. > > Once you pull this, I'll backmerge/ff to pick up the stm

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-26 Thread Rudniewski, Marek
Hi Lionel, You wrote: 0xe180 is named HALF_SLICE_CHICKEN2 and touched by the kernel. Would it be possible to provide some explanation as to why it's modified? I'm concerned we're going to break something if we touch it from userspace, potentially dropping what the kernel put in. Some parts of NO

[Intel-gfx] [PATCH 03/16] drm/i915: Consolidate get_fence with pin_fence

2017-07-26 Thread Chris Wilson
Following the pattern now used for obj->mm.pages, use just pin_fence and unpin_fence to control access to the fence registers. I.e. instead of calling get_fence(); pin_fence(), we now just need to call pin_fence(). This will make it easier to reduce the locking requirements around fence registers.

[Intel-gfx] [PATCH 05/16] drm/i915: Refactor testing obj->mm.pages

2017-07-26 Thread Chris Wilson
Since we occasionally stuff an error pointer into obj->mm.pages for a semi-permanent or even permanent failure, we have to be more careful and not just test against NULL when deciding if the object has a complete set of its concurrent pages. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i

[Intel-gfx] More tweaks

2017-07-26 Thread Chris Wilson
All other the shop, sent individually before pulled together for fun. Some improvements for the shrinker, some improvements for fencing, and execbuf tweaks. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/m

[Intel-gfx] [PATCH 04/16] drm/i915: Emit pipelined fence changes

2017-07-26 Thread Chris Wilson
Many years ago, long before requests, we tried doing this. We never quite got it right, but now with requests we have the tracking to do the job properly! One of the stall points for gen2/gen3 is the use of fence registers for GPU operations. There are only a few available, and currently if we exh

[Intel-gfx] [PATCH] drm/i915: Rework sdvo proxy i2c locking

2017-07-26 Thread Daniel Vetter
lockdep complaints about a locking recursion for the i2c bus lock because both the sdvo ddc proxy bus and the gmbus nested within use the same locking class. It's not really a deadlock since we never nest the other way round, but it's annoying. Fix it by pulling the gmbus locking into the i2c lock

[Intel-gfx] [PATCH 12/16] drm/i915: Convert execbuf to use struct-of-array packing for critical fields

2017-07-26 Thread Chris Wilson
When userspace is doing most of the work, avoiding relocs (using NO_RELOC) and opting out of implicit synchronisation (using ASYNC), we still spend a lot of time processing the arrays in execbuf, even though we now should have nothing to do most of the time. One issue that becomes readily apparent

[Intel-gfx] [PATCH 11/16] drm/i915: Check context status before looking up our obj/vma

2017-07-26 Thread Chris Wilson
Since we keep the context around across the slow lookup where we may drop the struct_mutex, we should double check that the context is still valid upon reacquisition. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Joonas Lahtinen Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_execbuf

[Intel-gfx] [PATCH 14/16] drm/i915: Replace execbuf vma ht with an idr

2017-07-26 Thread Chris Wilson
This was the competing idea long ago, but it was only with the rewrite of the idr as an radixtree and using the radixtree directly ourselves, along with the realisation that we can store the vma directly in the radixtree and only need a list for the reverse mapping, that made the patch performant e

[Intel-gfx] [PATCH 15/16] drm/i915: Trivial grammar fix s/opt of/opt out of/ in comment

2017-07-26 Thread Chris Wilson
The word out was dropped from the sentence across the line break, put it back. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_ge

[Intel-gfx] [PATCH 06/16] drm/i915: Move dev_priv->mm.[un]bound_list to its own lock

2017-07-26 Thread Chris Wilson
Remove the struct_mutex requirement around dev_priv->mm.bound_list and dev_priv->mm.unbound_list by giving it its own spinlock. This reduces one more requirement for struct_mutex and in the process gives us slightly more accurate unbound_list tracking, which should improve the shrinker. Signed-off

[Intel-gfx] [PATCH 08/16] drm/i915: Only free the oldest stale object before a fresh allocation

2017-07-26 Thread Chris Wilson
Inspired by Tvrtko's critique of the reaping of the stale contexts before allocating a new one, also limit the freed object reaping to the oldest stale object before allocating a fresh object. Unlike contexts, objects may have radically different sizes of backing storage, but similar to contexts, w

[Intel-gfx] [PATCH 13/16] drm/i915: Simplify eb_lookup_vmas()

2017-07-26 Thread Chris Wilson
Since the introduction of being able to perform a lockless lookup of an object (i915_gem_object_get_rcu() in fbbd37b36fa5 ("drm/i915: Move object release to a freelist + worker") we no longer need to split the object/vma lookup into 3 phases and so combine them into a much simpler single loop. Sig

[Intel-gfx] [PATCH 01/16] drm/i915: Keep a small stash of preallocated WC pages

2017-07-26 Thread Chris Wilson
We use WC pages for coherent writes into the ppGTT on !llc architectuures. However, to create a WC page requires a stop_machine(), i.e. is very slow. To compensate we currently keep a per-vm cache of recently freed pages, but we still see the slow startup of new contexts. We can amoritize that cost

[Intel-gfx] [PATCH 07/16] drm/i915: Trim struct_mutex hold duration for i915_gem_free_objects

2017-07-26 Thread Chris Wilson
We free objects in bulk after they wait for their RCU grace period. Currently, we take struct_mutex and unbind all the objects. This can lead to a long lock duration during which time those objects have their pages unfreeable (i.e. the shrinker is prevented from reaping those pages). If we only pro

[Intel-gfx] [PATCH 09/16] drm/i915: Track user GTT faulting per-vma

2017-07-26 Thread Chris Wilson
We don't wish to refault the entire object (other vma) when unbinding one partial vma. To do this track which vma have been faulted into the user's address space. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_gem.c | 50 +++

[Intel-gfx] [PATCH 02/16] drm/i915: Pin fence for iomap

2017-07-26 Thread Chris Wilson
Acquire the fence register for the iomap in i915_vma_pin_iomap() on behalf of the caller. We probably want for the caller to specify whether the fence should be pinned for their usage, but at the moment all callers do want the associated fence, or none, so take it on their behalf. Signed-off-by:

[Intel-gfx] [PATCH 16/16] drm/i915: Mark the GT as busy before idling the previous request

2017-07-26 Thread Chris Wilson
In a synchronous setup, we may retire the last request before we complete allocating the next request. As the last request is retired, we queue a timer to mark the device as idle, and promptly have to execute ad cancel that timer once we complete allocating the request and need to keep the device a

[Intel-gfx] [PATCH 10/16] drm/i915: Try a minimal attempt to insert the whole object for relocations

2017-07-26 Thread Chris Wilson
As we have a lightweight fallback to insert a single page into the aperture, try to avoid any heavier evictions when attempting to insert the entire object. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[Intel-gfx] [PATCH 1/3] backlight: always select BACKLIGHT_LCD_SUPPORT for BACKLIGHT_CLASS_DEVICE

2017-07-26 Thread Arnd Bergmann
randconfig builds occasionally produce this Kconfig warning: warning: (DRM_RADEON && DRM_AMDGPU && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 && DRM_SHMOBILE && DRM_TILCDC && DRM_FSL_DCU && DRM_TINYDRM && DRM_PARADE_PS8622 && FB_BACKLIGHT && FB_ARMCLCD && FB_MX3 && USB_APPLEDISPLAY && FB_OLPC_DCON &&

[Intel-gfx] [PATCH 2/3] ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies

2017-07-26 Thread Arnd Bergmann
ACPI_VIDEO keeps causing problems with circular Kconfig dependencies, as it depends on a couple of other symbols, and it gets selected by drivers that may end up being depending on others. This is an attempt to simplify this by changing all drivers that currently 'select ACPI_VIDEO' to use 'depend

[Intel-gfx] [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal

2017-07-26 Thread Arnd Bergmann
Hi everyone, It took me a while to figure this out properly, as I kept getting circular or missing dependencies with video drivers. This set of three patches should simplify the situation a bit, mostly by cleaning up the dependencies around CONFIG_ACPI_VIDEO. With all three patches applied, I no

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rework sdvo proxy i2c locking (rev2)

2017-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Rework sdvo proxy i2c locking (rev2) URL : https://patchwork.freedesktop.org/series/27907/ State : success == Summary == Series 27907v2 drm/i915: Rework sdvo proxy i2c locking https://patchwork.freedesktop.org/api/1.0/series/27907/revisions/2/mbox/ Test

[Intel-gfx] [PATCH 3/3] drm/etnaviv: add thermal dependency

2017-07-26 Thread Arnd Bergmann
When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is built-in, we get a link error: drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_bind': etnaviv_gpu.c:(.text.etnaviv_gpu_bind+0x34): undefined reference to `thermal_of_cooling_device_register' etnaviv_gpu.c:(.text.e

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/16] drm/i915: Keep a small stash of preallocated WC pages

2017-07-26 Thread Patchwork
== Series Details == Series: series starting with [01/16] drm/i915: Keep a small stash of preallocated WC pages URL : https://patchwork.freedesktop.org/series/27934/ State : success == Summary == Series 27934v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/27934

Re: [Intel-gfx] [PATCH] drm/i915/sdvo: Shut up state checker with hdmi cards on gen3

2017-07-26 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-25 14:48:41) > The hdmi bits simply don't exist, so nerf them. I think audio doesn't > work on gen3 at all, and for the limited color range we should > probably use the colorimetry sdvo paramater instead of the bit in the > port. > > But fixing sdvo isn't my goal, I

[Intel-gfx] ✓ Fi.CI.BAT: success for Kconfig dependencies: acpi-video, backlight and thermal

2017-07-26 Thread Patchwork
== Series Details == Series: Kconfig dependencies: acpi-video, backlight and thermal URL : https://patchwork.freedesktop.org/series/27936/ State : success == Summary == Series 27936v1 Kconfig dependencies: acpi-video, backlight and thermal https://patchwork.freedesktop.org/api/1.0/series/27936

Re: [Intel-gfx] [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal

2017-07-26 Thread Daniel Vetter
On Wed, Jul 26, 2017 at 03:53:09PM +0200, Arnd Bergmann wrote: > Hi everyone, > > It took me a while to figure this out properly, as I kept getting > circular or missing dependencies with video drivers. > > This set of three patches should simplify the situation a bit, > mostly by cleaning up the

Re: [Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-26 Thread Chris Wilson
Quoting Imre Deak (2017-07-25 22:12:36) > From: Damien Lespiau > > We exit early if has_aliasing_ppgtt is 0, so towards the end of the > function has_aliasing_ppgtt can only be 1. > > Also: > > if (foo) > return 1; > else > return 0; > > when foo

Re: [Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-26 Thread Imre Deak
Yep, looks better in the end. If you could send a proper patch I'd review it. On Wed, Jul 26, 2017 at 03:44:00PM +0100, Chris Wilson wrote: > Quoting Imre Deak (2017-07-25 22:12:36) > > From: Damien Lespiau > > > > We exit early if has_aliasing_ppgtt is 0, so towards the end of the > > function

Re: [Intel-gfx] [RFC v3] drm/hdcp: drm enum property for CP State

2017-07-26 Thread Sean Paul
On Wed, Jul 26, 2017 at 03:24:10PM +0530, Ramalingam C wrote: > > > On Tuesday 25 July 2017 06:04 PM, Sean Paul wrote: > > On Mon, Jul 24, 2017 at 2:12 PM, Ramalingam C > > wrote: > > > DRM connector property is created to represent the content protection > > > state of the connector and to con

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-26 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 17:50 +0200, Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 03:18:04PM +0300, Paul Kocialkowski wrote: > > On Tue, 2017-07-25 at 10:16 +0200, Daniel Vetter wrote: > > > On Tue, Jul 25, 2017 at 10:58:55AM +0300, Paul Kocialkowski wrote: > > > > On Tue, 2017-07-25 at 09:34 +0200

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-26 Thread Lionel Landwerlin
On 26/07/17 12:28, Szulc, Sebastian wrote: 0x2b04 - what is the setting for this register in the kernel? It is a debug register and we would like to control it too We've disabled the clock ratio changes in the kernel because on gen9 they produce a lot of reports unhelpful reports : https://

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-26 Thread Lionel Landwerlin
On 26/07/17 13:40, Rudniewski, Marek wrote: Hi Lionel, You wrote: 0xe180 is named HALF_SLICE_CHICKEN2 and touched by the kernel. Would it be possible to provide some explanation as to why it's modified? I'm concerned we're going to break something if we touch it from userspace, potentially drop

Re: [Intel-gfx] [PATCH 11/21] drm/i915: support 1G pages for the 48b PPGTT

2017-07-26 Thread Matthew Auld
On 25 July 2017 at 20:53, Chris Wilson wrote: > Quoting Matthew Auld (2017-07-25 20:21:23) >> Support inserting 1G gtt pages into the 48b PPGTT. >> >> v2: sanity check sg->length against page_size >> >> Signed-off-by: Matthew Auld >> Cc: Joonas Lahtinen >> Cc: Chris Wilson >> --- >> drivers/gp

Re: [Intel-gfx] [PATCH 1/3] backlight: always select BACKLIGHT_LCD_SUPPORT for BACKLIGHT_CLASS_DEVICE

2017-07-26 Thread Andy Shevchenko
On Wed, Jul 26, 2017 at 4:53 PM, Arnd Bergmann wrote: > randconfig builds occasionally produce this Kconfig warning: > > warning: (DRM_RADEON && DRM_AMDGPU && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 > && DRM_SHMOBILE && DRM_TILCDC && DRM_FSL_DCU && DRM_TINYDRM && > DRM_PARADE_PS8622 && FB_BACKLIGH

[Intel-gfx] [PATCH 1/3] drm/i915: Trim struct_mutex usage for kms

2017-07-26 Thread Chris Wilson
Reduce acquisition of struct_mutex to the critical regions that must hold it; for KMS, we need struct_mutex currently only for the purpose of pinning/unpinning the framebuffer's VMA into the global GTT. This allows us to avoid taking the struct_mutex when disabling the CRTC (i.e. NULL framebuffer o

[Intel-gfx] [PATCH 2/3] drm/i915: Make i915_gem_object_phys_attach() use obj->mm.lock more appropriately

2017-07-26 Thread Chris Wilson
Actually transferring from shmemfs to the physically contiguous set of pages should be wholly guarded by its obj->mm.lock! v2: Remember to free the old pages. Signed-off-by: Chris Wilson Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_gem.c | 50

Re: [Intel-gfx] [PATCH i-g-t v2] configure.ac: Disable chamelium by default and add enable argument

2017-07-26 Thread Lyude Paul
r-b'd and pushed, thanks! On Wed, 2017-07-26 at 11:11 +0300, Paul Kocialkowski wrote: > Since the chamelium is not a very usual piece of hardware and > requires > pulling-in lots of specific dependencies, it makes sense to keep it > disabled by default. > > An explicit --enable-chamelium argument

[Intel-gfx] [PATCH 3/3] drm/i915: Pin the pages before acquiring struct_mutex for display

2017-07-26 Thread Chris Wilson
Since we don't need the struct_mutex to acquire the object's pages, call i915_gem_object_pin_pages() before we bind the object into the GGTT. Signed-off-by: Chris Wilson Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 9 - 1 file changed, 8 insertions(+), 1 del

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Trim struct_mutex usage for kms

2017-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Trim struct_mutex usage for kms URL : https://patchwork.freedesktop.org/series/27947/ State : success == Summary == Series 27947v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/27947/revisions/1/mb

Re: [Intel-gfx] [RFC v3] drm/hdcp: drm enum property for CP State

2017-07-26 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Wednesday, July 26, 2017 8:23 PM > To: C, Ramalingam > Cc: Sean Paul ; Vetter, Daniel > ; Intel Graphics Development g...@lists.freedesktop.org>; dri-devel ; > Daniel > Vetter > Subject: Re: [RFC v3] drm/hdcp

Re: [Intel-gfx] [PATCH v4 RESEND 0/4] Kernel PSR Fix-ups

2017-07-26 Thread Jim Bride
On Tue, Jul 25, 2017 at 08:13:03PM +0300, David Weinehall wrote: > On Tue, Jul 25, 2017 at 09:48:07AM -0700, Jim Bride wrote: > > These patches, along with an upcoming series for IGT, enable our > > PSR IGT tests to run reliably once again on HSW, BDW, and SKL. > > The first change enables us to ru

Re: [Intel-gfx] [PATCH] drm/i915/sdvo: Shut up state checker with hdmi cards on gen3

2017-07-26 Thread Daniel Vetter
On Wed, Jul 26, 2017 at 4:33 PM, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-25 14:48:41) >> The hdmi bits simply don't exist, so nerf them. I think audio doesn't >> work on gen3 at all, and for the limited color range we should >> probably use the colorimetry sdvo paramater instead of th

Re: [Intel-gfx] [RFC v3] drm/hdcp: drm enum property for CP State

2017-07-26 Thread Sean Paul
On Wed, Jul 26, 2017 at 12:51 PM, C, Ramalingam wrote: > >> -Original Message- >> From: Sean Paul [mailto:seanp...@chromium.org] >> Sent: Wednesday, July 26, 2017 8:23 PM >> To: C, Ramalingam >> Cc: Sean Paul ; Vetter, Daniel >> ; Intel Graphics Development > g...@lists.freedesktop.org>;

Re: [Intel-gfx] [PATCH] drm/i915/sdvo: Shut up state checker with hdmi cards on gen3

2017-07-26 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-26 18:52:06) > On Wed, Jul 26, 2017 at 4:33 PM, Chris Wilson > wrote: > > Quoting Daniel Vetter (2017-07-25 14:48:41) > >> The hdmi bits simply don't exist, so nerf them. I think audio doesn't > >> work on gen3 at all, and for the limited color range we should > >>

[Intel-gfx] [PATCH 1/6] drm/i915: Implement .get_format_info() hook for CCS

2017-07-26 Thread Ben Widawsky
From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are compressed and which are not. The lo

[Intel-gfx] [PATCH 3/6] drm: Plumb modifiers through plane init

2017-07-26 Thread Ben Widawsky
This is the plumbing for supporting fb modifiers on planes. Modifiers have already been introduced to some extent, but this series will extend this to allow querying modifiers per plane. Based on this, the client to enable optimal modifications for framebuffers. This patch simply allows the DRM dr

[Intel-gfx] [PATCH 2/6] drm/i915: Add render decompression support

2017-07-26 Thread Ben Widawsky
From: Ville Syrjälä SKL+ display engine can scan out certain kinds of compressed surfaces produced by the render engine. This involved telling the display engine the location of the color control surfae (CCS) which describes which parts of the main surface are compressed and which are not. The lo

[Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-07-26 Thread Ben Widawsky
v2: Support sprite plane. Support pipe C/D limitation on GEN9. v3: Rename structure (Ville) Handle GLK (Ville) This requires rebase on the correct Ville patches Cc: Daniel Stone Cc: Kristian Høgsberg Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_display.c | 30 ++

[Intel-gfx] [PATCH 4/6] drm: Create a format/modifier blob

2017-07-26 Thread Ben Widawsky
Updated blob layout (Rob, Daniel, Kristian, xerpi) v2: * Removed __packed, and alignment (.+) * Fix indent in drm_format_modifier fields (Liviu) * Remove duplicated modifier > 64 check (Liviu) * Change comment about modifier (Liviu) * Remove arguments to blob creation, use plane instead (Liviu) *

[Intel-gfx] [PATCH 5/6] drm/i915: Add format modifiers for Intel

2017-07-26 Thread Ben Widawsky
This was based on a patch originally by Kristian. It has been modified pretty heavily to use the new callbacks from the previous patch. v2: - Add LINEAR and Yf modifiers to list (Ville) - Combine i8xx and i965 into one list of formats (Ville) - Allow 1010102 formats for Y/Yf tiled (Ville) v

[Intel-gfx] [PATCH 2/2] drm/i915: Call the unlocked version of i915_gem_object_get_pages()

2017-07-26 Thread Chris Wilson
When we hold for the lock for swapping out the shmem pages for the physically contiguous pages, we have to call the unlocked version of get_pages! Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101934 Fixes: 35d23516946e ("drm/i915: Make i915_gem_object_phys_attach() use obj->mm.lock more

[Intel-gfx] [PATCH 1/2] drm/i915: Move i915_gem_object_phys_attach()

2017-07-26 Thread Chris Wilson
Prevent a forward declaration in the next patch. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 118 1 file changed, 58 insertions(+), 60 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Implement .get_format_info() hook for CCS

2017-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Implement .get_format_info() hook for CCS URL : https://patchwork.freedesktop.org/series/27949/ State : failure == Summary == Series 27949v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/27949/rev

Re: [Intel-gfx] [PATCH 2/3] ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies

2017-07-26 Thread Rafael J. Wysocki
On Wednesday, July 26, 2017 03:53:11 PM Arnd Bergmann wrote: > ACPI_VIDEO keeps causing problems with circular Kconfig dependencies, > as it depends on a couple of other symbols, and it gets selected by > drivers that may end up being depending on others. > > This is an attempt to simplify this by

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move i915_gem_object_phys_attach()

2017-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move i915_gem_object_phys_attach() URL : https://patchwork.freedesktop.org/series/27950/ State : success == Summary == Series 27950v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/27950/revisions/1

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Call the unlocked version of i915_gem_object_get_pages()

2017-07-26 Thread Matthew Auld
On 26 July 2017 at 19:16, Chris Wilson wrote: > When we hold for the lock for swapping out the shmem pages for the > physically contiguous pages, we have to call the unlocked version of > get_pages! > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101934 > Fixes: 35d23516946e ("drm/i915:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Call the unlocked version of i915_gem_object_get_pages()

2017-07-26 Thread Chris Wilson
Quoting Matthew Auld (2017-07-26 19:55:01) > On 26 July 2017 at 19:16, Chris Wilson wrote: > > When we hold for the lock for swapping out the shmem pages for the > > physically contiguous pages, we have to call the unlocked version of > > get_pages! > > > > Bugzilla: https://bugs.freedesktop.org/s

Re: [Intel-gfx] [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-26 Thread Noralf Trønnes
Den 25.07.2017 10.01, skrev Daniel Vetter: It's dead code, the core handles all this directly now. The only special case is nouveau and tda988x which used one function for both legacy modeset code and -nv50 atomic world instead of 2 vtables. But amounts to exactly the same. v2: Rebase over the

[Intel-gfx] [PATCH] drm/i915/sdvo: Shut up state checker with hdmi cards on gen3

2017-07-26 Thread Daniel Vetter
The hdmi bits simply don't exist, so nerf them. I think audio doesn't work on gen3 at all, and for the limited color range we should probably use the colorimetry sdvo paramater instead of the bit in the port. But fixing sdvo isn't my goal, I just want to get the backtrace out of the way, and this

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/sdvo: Shut up state checker with hdmi cards on gen3 (rev3)

2017-07-26 Thread Patchwork
== Series Details == Series: drm/i915/sdvo: Shut up state checker with hdmi cards on gen3 (rev3) URL : https://patchwork.freedesktop.org/series/27860/ State : success == Summary == Series 27860v3 drm/i915/sdvo: Shut up state checker with hdmi cards on gen3 https://patchwork.freedesktop.org/api

Re: [Intel-gfx] [PATCH] drm/i915/guc: Prevent ggtt->invalidate assert during GuC reload

2017-07-26 Thread Michel Thierry
On 6/30/2017 10:41 AM, Michel Thierry wrote: The driver reloads the GuC firmware after full gpu reset or suspend/resume, but it never disables the GuC beforehand. This leads us to hit the assert inside i915_ggtt_enable_guc added by commit 04f7b24eccdf ("drm/i915/guc: Assert that we switch between

[Intel-gfx] [PATCH] drm/i915: Split pin mapping into per platform functions

2017-07-26 Thread Anusha Srivatsa
Cleanup the code. Map the pins in accordance to individual platforms rather than according to ports. Create separate functions for platforms. Suugested-by Ville Syrjala Cc: Ville Syrjala Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_drv.h | 4 ++- drivers/gpu/drm/i915/intel_h

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Split pin mapping into per platform functions

2017-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Split pin mapping into per platform functions URL : https://patchwork.freedesktop.org/series/27965/ State : failure == Summary == Series 27965v1 drm/i915: Split pin mapping into per platform functions https://patchwork.freedesktop.org/api/1.0/series/27965

[Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Prevent compiler warning on unchecked printf format

2017-07-26 Thread Gabriel Krisman Bertazi
Commit 34a54192e1fb ("lib/igt_debugfs: Add extended helper to format crc to string") introduced the following compiler warning: igt_debugfs.c: In function ‘igt_crc_to_string_extended’: igt_debugfs.c:373:4: warning: format not a string literal, argument types not checked [-Wformat-nonliteral]

Re: [Intel-gfx] [PATCH] drm/i915/guc: Prevent ggtt->invalidate assert during GuC reload

2017-07-26 Thread Chris Wilson
Quoting Michel Thierry (2017-07-26 21:59:07) > On 6/30/2017 10:41 AM, Michel Thierry wrote: > > The driver reloads the GuC firmware after full gpu reset or > > suspend/resume, but it never disables the GuC beforehand. > > This leads us to hit the assert inside i915_ggtt_enable_guc added > > by comm