Re: [Intel-gfx] [PATCH 5/9] drm/i915: More surgically unbreak the modeset vs reset deadlock

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 4:05 PM, Daniel Vetter wrote: > On Wed, Jul 19, 2017 at 3:42 PM, Chris Wilson > wrote: >> Quoting Daniel Vetter (2017-07-19 13:54:58) >>> diff --git a/drivers/gpu/drm/i915/intel_display.c >>> b/drivers/gpu/drm/i915/intel_display.c >>> index 5aa7ca1ab592..4762f158032d 100

[Intel-gfx] ✓ Fi.CI.BAT: success for gpu reset vs modeset fix, plus page_flip removal

2017-07-19 Thread Patchwork
== Series Details == Series: gpu reset vs modeset fix, plus page_flip removal URL : https://patchwork.freedesktop.org/series/27576/ State : success == Summary == Series 27576v1 gpu reset vs modeset fix, plus page_flip removal https://patchwork.freedesktop.org/api/1.0/series/27576/revisions/1/m

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Remove intel_flip_work infrastructure

2017-07-19 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-19 14:24:20) > On Wed, Jul 19, 2017 at 02:07:36PM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-07-19 13:55:01) > > > This gets rid of all the interactions between the legacy flip code and > > > the modeset code. Yay! > > > > Including our missed vblank

Re: [Intel-gfx] [RFC 3/4] drm/i915/execlists: Split insert_request()

2017-07-19 Thread Michał Winiarski
On Mon, Jul 17, 2017 at 09:42:34AM +0100, Chris Wilson wrote: > In the next patch we will want to reinsert a request not at the end of > the priority queue, but at the front. Here we split insert_request() > into two, the first function retrieves the priority list (for reuse for > unsubmit later) a

Re: [Intel-gfx] [RFC 2/4] drm/i915/execlists: Keep request->priority for its lifetime

2017-07-19 Thread Michał Winiarski
On Mon, Jul 17, 2017 at 09:42:33AM +0100, Chris Wilson wrote: > With preemption, we will want to "unsubmit" a request, taking it back > from the hw and returning it to the priority sorted execution list. In > order to know where to insert it into that list, we need to remember > its adjust priority

Re: [Intel-gfx] [RFC 1/4] drm/i915/execlists: Move insert_request()

2017-07-19 Thread Michał Winiarski
On Mon, Jul 17, 2017 at 09:42:32AM +0100, Chris Wilson wrote: > Move insert_request() earlier to avoid a forward declaration in a later > patch. > > Signed-off-by: Chris Wilson Reviewed-by: Michał Winiarski -Michał > --- > drivers/gpu/drm/i915/intel_lrc.c | 128 > +++

Re: [Intel-gfx] [RFC 2/4] drm/i915/execlists: Keep request->priority for its lifetime

2017-07-19 Thread Chris Wilson
Quoting Michał Winiarski (2017-07-19 15:25:51) > On Mon, Jul 17, 2017 at 09:42:33AM +0100, Chris Wilson wrote: > > With preemption, we will want to "unsubmit" a request, taking it back > > from the hw and returning it to the priority sorted execution list. In > > order to know where to insert it in

Re: [Intel-gfx] [RFC 3/4] drm/i915/execlists: Split insert_request()

2017-07-19 Thread Chris Wilson
Quoting Michał Winiarski (2017-07-19 15:23:47) > On Mon, Jul 17, 2017 at 09:42:34AM +0100, Chris Wilson wrote: > Matches what I have in my tree, except for "first" hidden in pointer. > Can we #define the bit where we're keeping the "first" status? This way we can > immediatelly see what's going on

[Intel-gfx] [PATCH v2 0/7] drm/atomic: Remove deprecated atomic iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
It's time to kill off for_each_obj_in_state, and convert the remainder to for_each_(old/new/both)_obj_in_state. Some patches have been upstreamed, these are the remaining few with compile fixes. Maarten Lankhorst (7): drm/atomic: Use new iterator macros in drm_atomic_helper_wait_for_flip_done

[Intel-gfx] [PATCH v2 7/7] drm/atomic: Remove deprecated accessor macros

2017-07-19 Thread Maarten Lankhorst
Now that the last users have been converted, we can finally get rid of for_each_obj_in_state, we have better macros to replace them with. Signed-off-by: Maarten Lankhorst Cc: Daniel Vetter Cc: Jani Nikula Cc: Sean Paul Cc: David Airlie --- include/drm/drm_atomic.h| 75 ---

[Intel-gfx] [PATCH v2 3/7] drm/rcar-du: Use new iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
for_each_obj_in_state is about to be removed, so use the correct new iterator macros. Also look at new_plane_state instead of plane->state when looking up the hw planes in use. They should be the same except when reallocating, (in which case this code is skipped) and we should really stop looking

[Intel-gfx] [PATCH v2 1/7] drm/atomic: Use new iterator macros in drm_atomic_helper_wait_for_flip_done, again.

2017-07-19 Thread Maarten Lankhorst
for_each_obj_in_state is about to be removed, so use the correct new iterator macro. I renamed the variable to 'unused', but forgot to convert drm_atomic_helper_wait_for_flip_done to the new iterator macro, so make it work this time. Signed-off-by: Maarten Lankhorst Cc: Daniel Vetter Cc: Jani N

[Intel-gfx] [PATCH v2 4/7] drm/omapdrm: Fix omap_atomic_wait_for_completion

2017-07-19 Thread Maarten Lankhorst
Use the new iterator macro and look for crtc_state->active instead of enable, only crtc_state->enable implies that vblanks will happen. Signed-off-by: Maarten Lankhorst Cc: Tomi Valkeinen Reviewed-by: Daniel Vetter --- drivers/gpu/drm/omapdrm/omap_drv.c | 6 +++--- 1 file changed, 3 insertions

[Intel-gfx] [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-19 Thread Maarten Lankhorst
Instead of assigning plane to __plane, iterate over plane which is the same thing. Simplify the check for n_planes != 1, at that point we know plane != NULL as well. Rename obj_state to new_obj_state, and get rid of the bogus stuff. crtc->state->state is NEVER non-null, if it is, there is a bug. W

[Intel-gfx] [PATCH v2 5/7] drm/msm: Convert to use new iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
for_each_obj_in_state is about to be removed, so convert to the new iterator macros. Just like in omap, use crtc_state->active instead of crtc_state->enable when waiting for completion. Changes since v1: - Fix compilation. Signed-off-by: Maarten Lankhorst Cc: Rob Clark Cc: Archit Taneja Cc: V

[Intel-gfx] [PATCH v2 6/7] drm/nouveau: Convert nouveau to use new iterator macros, v2.

2017-07-19 Thread Maarten Lankhorst
Use the new atomic iterator macros, the old ones are about to be removed. With the new macros, it's more easy to get old and new state so get them from the macros instead of from obj->state. Changes since v1: - Don't mix up old and new state. (danvet) - Rebase on top of interruptible swap_state ch

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for gpu reset vs modeset fix, plus page_flip removal

2017-07-19 Thread Chris Wilson
Quoting Patchwork (2017-07-19 15:15:25) > fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 > time:443s > fi-bdw-gvtdvmtotal:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 > time:427s > fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Mark contexts as lost during freeing of mock device

2017-07-19 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Mark contexts as lost during freeing of mock device URL : https://patchwork.freedesktop.org/series/27580/ State : success == Summary == Series 27580v1 drm/i915/selftests: Mark contexts as lost during freeing of mock device https://patchwork.fre

[Intel-gfx] [PATCH i-g-t 1/3] configure.ac: Enable back chamelium build by default

2017-07-19 Thread Paul Kocialkowski
Introducing an option for chamelium build inadvertently disabled it by default, according to the definition of the AC_ARG_ENABLE macro. This enables it back chamelium by default. Fixes: fd096fcc ("configure.ac: Make building chamelium an option") Signed-off-by: Paul Kocialkowski --- configure.

[Intel-gfx] [PATCH i-g-t 2/3] configure.ac: Make glib dependency optional to preserve Android build

2017-07-19 Thread Paul Kocialkowski
This adds ifdef wrappers, with matching autoconf macros, to make the dependency on glib (used for parsing configuration) optional. This allows preserving the ability to build IGT on Android, where glib support is lacking. Signed-off-by: Paul Kocialkowski --- configure.ac | 8 +++- lib/igt

[Intel-gfx] [PATCH i-g-t 0/3] Various autoconf fixups

2017-07-19 Thread Paul Kocialkowski
These patches apply on top of: tests/chamelium: Detect analogue bridges and handle EDID accordingly ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 3/3] configure.ac: Make gsl dependency and dependent code optional

2017-07-19 Thread Paul Kocialkowski
This adds automake instructions, with matching autoconf macros, to make the dependency on gsl and the code that depends on it optional. This should allow preserving the ability to build IGT on Android, where gsl support may be lacking. Signed-off-by: Paul Kocialkowski --- configure.ac |

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic: Remove deprecated atomic iterator macros, v2.

2017-07-19 Thread Patchwork
== Series Details == Series: drm/atomic: Remove deprecated atomic iterator macros, v2. URL : https://patchwork.freedesktop.org/series/27582/ State : success == Summary == Series 27582v1 drm/atomic: Remove deprecated atomic iterator macros, v2. https://patchwork.freedesktop.org/api/1.0/series/2

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/chamelium: Skip suspend/resume test with unreliable hotplug event

2017-07-19 Thread Lyude Paul
On Wed, 2017-07-19 at 11:31 +0300, Paul Kocialkowski wrote: > On Tue, 2017-07-18 at 22:21 +0100, Chris Wilson wrote: > > Quoting Paul Kocialkowski (2017-07-18 16:16:26) > > > It may occur that a hotplug uevent is detected at resume, even > > > though it > > > does not indicate that an actual hotplu

Re: [Intel-gfx] [PATCH i-g-t v5 0/7] CRC testing with Chamelium improvements

2017-07-19 Thread Lyude Paul
Thank you for all of the great work you're doing! This looks perfect, so for the whole series Reviewed-by: Lyude I've pushed everything upstream, congrats! On Wed, 2017-07-19 at 16:46 +0300, Paul Kocialkowski wrote: > Changes since v4: > * Moved igt_get_cairo_surface out of the thread function

Re: [Intel-gfx] [PATCH v2] drm/i915: Consistently use enum pipe for PCH transcoders

2017-07-19 Thread Matthias Kaehlcke
El Wed, Jul 19, 2017 at 08:30:36AM +0200 Daniel Vetter ha dit: > On Tue, Jul 18, 2017 at 01:48:53PM -0700, Matthias Kaehlcke wrote: > > Hi Daniel, > > > > El Tue, Jul 18, 2017 at 08:39:50AM +0200 Daniel Vetter ha dit: > > > > > On Mon, Jul 17, 2017 at 11:14:03AM -0700, Matthias Kaehlcke wrote: >

[Intel-gfx] [PATCH] drm/i915: Pass enum pipe to intel_set_pch_fifo_underrun_reporting()

2017-07-19 Thread Matthias Kaehlcke
Commit a21960339c8c ("drm/i915: Consistently use enum pipe for PCH transcoders") misses some pieces, due to a problem with the patch format, this patch adds the remaining bits. Fixes: a21960339c8c ("drm/i915: Consistently use enum pipe for PCH transcoders") Signed-off-by: Matthias Kaehlcke ---

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Mark contexts as lost during freeing of mock device

2017-07-19 Thread Matthew Auld
On 19 July 2017 at 14:59, Chris Wilson wrote: > We need to unpin the last retired context early in the shutdown sequence > so that its RCU free is done before we try to free the context ida. I > included this in a later patch ("drm/i915: Keep a recent cache of freed > contexts objects for reuse")

Re: [Intel-gfx] [PATCH i-g-t 3/3] configure.ac: Make gsl dependency and dependent code optional

2017-07-19 Thread Lyude Paul
R-B for the first two, I've already pushed them. For this one I'd prefer it if you just squashed it into the series where you add analog frame comparison support. Otherwise, looks good. On Wed, 2017-07-19 at 17:59 +0300, Paul Kocialkowski wrote: > This adds automake instructions, with matching aut

Re: [Intel-gfx] [PATCH i-g-t v3 0/2] Analogue/VGA frame comparison support

2017-07-19 Thread Lyude Paul
For both patches once you squash the configure.ac changes into the first one: Reviewed-by: Lyude Once you post the new versions I'll just go ahead and push them On Wed, 2017-07-19 at 16:48 +0300, Paul Kocialkowski wrote: > Changes since v2: > * Changed analogue in favor of analog > * Integrated

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Pass enum pipe to intel_set_pch_fifo_underrun_reporting()

2017-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Pass enum pipe to intel_set_pch_fifo_underrun_reporting() URL : https://patchwork.freedesktop.org/series/27591/ State : success == Summary == Series 27591v1 drm/i915: Pass enum pipe to intel_set_pch_fifo_underrun_reporting() https://patchwork.freedesktop

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Mark contexts as lost during freeing of mock device

2017-07-19 Thread Chris Wilson
Quoting Matthew Auld (2017-07-19 18:40:05) > On 19 July 2017 at 14:59, Chris Wilson wrote: > > We need to unpin the last retired context early in the shutdown sequence > > so that its RCU free is done before we try to free the context ida. I > > included this in a later patch ("drm/i915: Keep a re

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-07-19 Thread Pandiyan, Dhinakaran
On Wed, 2017-07-19 at 15:59 +0530, Jenny TC wrote: > With older panels, AUX pin for backlight doesn't work. On some > panels, this causes backlight issues on S3 resume. What is it that we are missing in the resume path? > Enable the > feature only for eDP1.4 or later. I can't find the eDP 1.4

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Avoid the gpu reset vs. modeset deadlock

2017-07-19 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 3:44 PM, Daniel Vetter wrote: > On Wed, Jul 19, 2017 at 3:32 PM, Chris Wilson > wrote: >> Quoting Daniel Vetter (2017-07-19 13:54:56) >>> ... using the biggest hammer we have. This is essentially a weaponized >>> version of the timeout-based wedging Chris added in >>> >>>

[Intel-gfx] [PATCH] drm/i915/selftests: Fix an error handling path in 'mock_gem_device()'

2017-07-19 Thread Christophe JAILLET
Goto the right label in case of error, otherwise there is a leak. This has been introduced by c5cf9a9147ff. In this patch a goto has not been updated. Fixes: c5cf9a9147ff ("drm/i915: Create a kmem_cache to allocate struct i915_priolist from") Signed-off-by: Christophe JAILLET --- drivers/gpu/dr

[Intel-gfx] [PATCH 2/2] drm/i915: Simplify scaler init during CRTC HW readout

2017-07-19 Thread Imre Deak
The crtc state starts out being bzero'd, so no need to clear scaler_users. Also intel_crtc_init_scalers() knows already which platforms have scalers, so no need for the platform check here. Similarly intel_crtc_init_scalers() will init scaler_id as required, so no need to do it here separately. Cc

[Intel-gfx] [PATCH 1/2] drm/i915: Fix scaler init during CRTC HW state readout

2017-07-19 Thread Imre Deak
The scaler allocation code depends on a non-zero default value for the crtc scaler_id, so make sure we initialize the scaler state accordingly even if the crtc is off. This fixes at least an initial YUV420 modeset (added in a follow-up patchset by Shashank) when booting with the screen off: after t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fix an error handling path in 'mock_gem_device()'

2017-07-19 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix an error handling path in 'mock_gem_device()' URL : https://patchwork.freedesktop.org/series/27604/ State : success == Summary == Series 27604v1 drm/i915/selftests: Fix an error handling path in 'mock_gem_device()' https://patchwork.freedes

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix scaler init during CRTC HW state readout

2017-07-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix scaler init during CRTC HW state readout URL : https://patchwork.freedesktop.org/series/27607/ State : success == Summary == Series 27607v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/27607/

Re: [Intel-gfx] [PATCH] drm/i915: Synchronize connectors states when switching from poll to irq

2017-07-19 Thread Pandiyan, Dhinakaran
On Mon, 2017-06-26 at 15:32 +0300, Paul Kocialkowski wrote: > After detecting an IRQ storm, hotplug detection will switch from > irq-based detection to poll-based detection. After a short delay or > when resetting storm detection from debugfs, detection will switch > back to being irq-based. > >

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm-intel tree

2017-07-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/i915/i915_drv.c between commit: 99c539bef538 ("drm/i915: unregister interfaces first in unload") from the drm-intel tree and commit: baf54385af78 ("drm/i915: Drop drm_vblank_cleanup") from the drm-

Re: [Intel-gfx] [PATCH] drm/i915: Synchronize connectors states when switching from poll to irq

2017-07-19 Thread Manasi Navare
On Tue, Jul 18, 2017 at 03:11:42PM +0300, Paul Kocialkowski wrote: > On Mon, 2017-06-26 at 15:32 +0300, Paul Kocialkowski wrote: > > After detecting an IRQ storm, hotplug detection will switch from > > irq-based detection to poll-based detection. After a short delay or > > when resetting storm dete

Re: [Intel-gfx] [PATCH] edp-DRRS test

2017-07-19 Thread Ramalingam C
On Friday 14 July 2017 02:21 AM, Paulo Zanoni wrote: Em Qua, 2017-06-21 às 13:40 +0530, Lohith BS escreveu: Idleness DRRS: By default the DRRS state will be at DRRS_HIGH_RR. When a Display content is Idle for more than 1Sec Idleness will be declared and DRRS_LOW_RR will

<    1   2