Re: [Intel-gfx] [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations

2017-05-29 Thread Gerd Hoffmann
> +struct vfio_vgpu_dmabuf_info { > + __u32 argsz; > + __u32 flags; > + struct vfio_vgpu_plane_info plane_info; > + __s32 fd; > + __u32 pad; > +}; Hmm, now you have argsz and flags twice in vfio_vgpu_dmabuf_info ... I think we should have something like this: struct vfio_vgpu

Re: [Intel-gfx] [PATCH 32/37] drm/sun4i: Drop drm_vblank_cleanup

2017-05-29 Thread Maxime Ripard
On Wed, May 24, 2017 at 04:52:07PM +0200, Daniel Vetter wrote: > Again seems just cargo-culted ... It's not ordered against any > irq/vblank/modeset shutdown. > > Cc: Maxime Ripard > Signed-off-by: Daniel Vetter Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Free Electrons Embedded Linux

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-29 Thread Jani Nikula
On Fri, 26 May 2017, Rodrigo Vivi wrote: > I believe we need to cc:stable on this right?! > > Jani, is this ok to go ahead and merge after stable is cc'ed? Please add this, and it'll all happen automagically. Fixes: acf45d11050a ("drm/i915/psr: disable psr2 for resolution greater than 32X20") C

Re: [Intel-gfx] [PATCH 55/67] drm/i915/gen10: implement gen 10 watermarks calculations

2017-05-29 Thread Ander Conselvan De Oliveira
On Thu, 2017-04-06 at 12:15 -0700, Rodrigo Vivi wrote: > From: Paulo Zanoni > > They're slightly different than the gen 9 calculations. I missed this at first, but GLK should follow the gen10 watermark programming as it has a gen10 display. > > TODO: before upstraming this, check if the spec i

Re: [Intel-gfx] [PATCH 2/3] drm/i915/glk: WA#0893: Also apply memory bw wa to Geminilake.

2017-05-29 Thread Ander Conselvan De Oliveira
On Fri, 2017-05-26 at 16:23 -0700, Rodrigo Vivi wrote: > According to spec this WA is needed for every gen9. Actually GLK has a gen10 display, so the gen9 workarounds don't apply. Ander > > Cc:Arthur Runyan > Cc: Ander Conselvan de Oliveira > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/

Re: [Intel-gfx] [PATCH] Defined NM doesn't work on KBL and uses automatic N/M.

2017-05-29 Thread Jani Nikula
On Fri, 26 May 2017, "Wang, Quanxian" wrote: > "The patch is probably fine. But I can't invent an explanation if I > don't know what the problem is." > > @Jani @libin, is it possible for you to help contact Intel graphics > hardware design engineer to get the reason why M/N doesn't work as you >

Re: [Intel-gfx] [PATCH 31/37] drm/stm: Drop drm_vblank_cleanup

2017-05-29 Thread Philippe CORNU
On 05/24/2017 04:52 PM, Daniel Vetter wrote: > Again seems just cargo-culted. > > Cc: Yannick Fertre > Cc: Philippe Cornu > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/stm/ltdc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/dr

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for i2c: refactor core and break out blocks

2017-05-29 Thread Jani Nikula
On Sat, 27 May 2017, Wolfram Sang wrote: > As far as I can read the above page, all non-green blocks are caused by > non-I2C issues. So, I'd assume my patch set doesn't break things. Good! Thanks for submitting the series for testing. This is just a basic test set, but gives confidence there's no

Re: [Intel-gfx] [PATCH 3/4] drm/dp: start a DPCD based DP sink/branch device quirk database

2017-05-29 Thread Jani Nikula
On Thu, 18 May 2017, "Pandiyan, Dhinakaran" wrote: > On Thu, 2017-05-18 at 14:10 +0300, Jani Nikula wrote: >> Face the fact, there are Display Port sink and branch devices out there >> in the wild that don't follow the Display Port specifications, or they >> have bugs, or just otherwise require s

Re: [Intel-gfx] [PATCH 3/4] drm/dp: start a DPCD based DP sink/branch device quirk database

2017-05-29 Thread Jani Nikula
On Thu, 18 May 2017, Clint Taylor wrote: > On 05/18/2017 04:10 AM, Jani Nikula wrote: >> Face the fact, there are Display Port sink and branch devices out there >> in the wild that don't follow the Display Port specifications, or they >> have bugs, or just otherwise require special treatment. Star

Re: [Intel-gfx] [PATCH 23/37] drm/imx: Drop drm_vblank_cleanup

2017-05-29 Thread Philipp Zabel
Hi Daniel, On Wed, 2017-05-24 at 16:51 +0200, Daniel Vetter wrote: > It's only done in the driver load error path, where vblanks don't need > to be quiescent anyway. And that's all drm_vblank_cleanup does, since > the core will release the vblank allocations on its own already. So > drop it. Than

Re: [Intel-gfx] [PATCH] drm/i915: Wait for struct_mutex inside shrinker

2017-05-29 Thread Joonas Lahtinen
On ke, 2017-05-24 at 11:11 +0100, Chris Wilson wrote: > Having resolved whether or not we would deadlock upon a call to > mutex_lock(&dev->struct_mutex), we can then wait for the contended > struct_mutex if we are not the owner. This should significantly improve > the chance of running the shrinker

[Intel-gfx] [i-g-t PATCH v2 2/4] igt/igt_core: Provide an option to check for the log buffer contents

2017-05-29 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue --- lib/igt_core.c | 24 lib/igt_core.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/lib/igt_core.c b/lib/igt_core.c index c2c8872..81d2039 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -329,6 +329,30 @@ static void _igt_l

[Intel-gfx] [i-g-t PATCH v2 3/4] Convert shell script tests to C version

2017-05-29 Thread Abdiel Janulgue
v2: Use internal igt_debugfs functions instead of cat and document debugfs tests. Convert sysfs_l3_parity properly. Rename redundant names in tests. Converted: - check_drm_clients (ensures no other clients are running. functionality provided by drm_open_driver_master). - debugfs_e

[Intel-gfx] [i-g-t PATCH v2 1/4] lib/igt_core: Add igt_exec helpers

2017-05-29 Thread Abdiel Janulgue
Support executing external processes with the goal of capturing its standard streams to the igt logging infrastructure in addition to its exit status. v2: Fix leaks on fd teardown. Make sure redirected process printout when > 64kb still works, like full dmesg. (Petri) Cc: Petri Latvala Signe

[Intel-gfx] [i-g-t PATCH v2 4/4] Convert ddx_intel_after_fbdev to C.

2017-05-29 Thread Abdiel Janulgue
v2: Use igt_exec_cmd macro. Signed-off-by: Abdiel Janulgue --- tests/Makefile.sources| 1 + tests/ddx_intel_after_fbdev | 73 --- tests/ddx_intel_after_fbdev.c | 113 ++ 3 files changed, 114 insertions(+), 73 deletions(

Re: [Intel-gfx] [i-g-t PATCH v2 3/4] Convert shell script tests to C version

2017-05-29 Thread Chris Wilson
On Mon, May 29, 2017 at 03:08:09PM +0300, Abdiel Janulgue wrote: > diff --git a/tests/debugfs.c b/tests/debugfs.c > new file mode 100644 > index 000..fb33f9f > --- /dev/null > +++ b/tests/debugfs.c > @@ -0,0 +1,97 @@ > +/* > + * Copyright © 2017 Intel Corporation > + * > + * Permission is hereb

Re: [Intel-gfx] [i-g-t PATCH v2 1/4] lib/igt_core: Add igt_exec helpers

2017-05-29 Thread Chris Wilson
On Mon, May 29, 2017 at 03:08:07PM +0300, Abdiel Janulgue wrote: > Support executing external processes with the goal of capturing its > standard streams to the igt logging infrastructure in addition to its > exit status. This is not an exec wrapper. This is a system() replacement. That it invokes

Re: [Intel-gfx] [i-g-t PATCH v2 4/4] Convert ddx_intel_after_fbdev to C.

2017-05-29 Thread Chris Wilson
On Mon, May 29, 2017 at 03:08:10PM +0300, Abdiel Janulgue wrote: > v2: Use igt_exec_cmd macro. What benefit does this give us? You are not writing it in C using the system libraries, you are just badly rewriting the shell script as snippets pass to shell from C. -Chris -- Chris Wilson, Intel Ope

[Intel-gfx] Updated drm-intel-testing

2017-05-29 Thread Daniel Vetter
Hi all, More stuff for 4.13: - skl+ wm fixes from Mahesh Kumar - some refactor and tests for i915_sw_fence (Chris) - tune execlist/scheduler code (Chris) - g4x,g33 gpu reset improvements (Chris, Mika) - guc code cleanup (Michal Wajdeczko, Michał Winiarski) - dp aux backlight improvements (Puthiko

[Intel-gfx] [PULL] drm-intel-fixes

2017-05-29 Thread Jani Nikula
Hi Dave, fixes all around, including GVT. I guess Joonas' RCU sync fix is the most important one. I've got the DP quirk stuff I asked about sitting on a branch, feeding to drm-tip too, hoping to get a bit more testing on it. I'll send a separate pull request for it later this week. BR, Jani. T

Re: [Intel-gfx] [RFC PATCH v3 5/5] ACPI: button: Always notify kernel space using _LID returning value

2017-05-29 Thread Benjamin Tissoires
Hi Lv, On May 27 2017 or thereabouts, Lv Zheng wrote: > Both nouveau and i915, the only 2 kernel space lid notification listeners, > invoke acpi_lid_open() API to obtain _LID returning value instead of using > the notified value. > > So this patch moves this logic from listeners to lid driver, al

Re: [Intel-gfx] [PATCH 08/37] drm/doc: Polish irq helper documentation

2017-05-29 Thread Daniel Vetter
On Thu, May 25, 2017 at 12:46:29AM -0700, Stefan Agner wrote: > On 2017-05-24 07:51, Daniel Vetter wrote: > > Pull a (much shorter) overview into drm_irq.c, and instead put the > > callback documentation into in-line comments in drm_drv.h. > > Looks good and just found all I needed to know to fix

Re: [Intel-gfx] [RFC PATCH 7/7] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-05-29 Thread Daniel Vetter
On Fri, May 26, 2017 at 12:20:48PM +0200, Hans Verkuil wrote: > On 05/26/2017 09:15 AM, Daniel Vetter wrote: > > On Thu, May 25, 2017 at 05:06:26PM +0200, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Implement support for this DisplayPort feature. > >> > >> The cec device is created whene

[Intel-gfx] [PATCH] drm: Fix locking in drm_atomic_helper_resume

2017-05-29 Thread Daniel Vetter
In the conversion to drop drm_modeset_lock_all and the magic implicit context I failed to realize that _resume starts out with a pile of state copies, but not with the locks. And hence drm_atomic_commit won't grab these for us. Cc: Jyri Sarha Fixes: a5b8444e289c ("drm/atomic-helper: remove modese

Re: [Intel-gfx] [PATCH 07/37] drm: Extract drm_vblank.[hc]

2017-05-29 Thread Stefan Agner
On 2017-05-24 07:51, Daniel Vetter wrote: > drm_irq.c contains both the irq helper library (optional) and the > vblank support (optional, but part of the modeset uapi, and doesn't > require the use of the irq helpers at all. > > Split this up for more clarity of the scope of the individual bits. >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Fix locking in drm_atomic_helper_resume

2017-05-29 Thread Patchwork
== Series Details == Series: drm: Fix locking in drm_atomic_helper_resume URL : https://patchwork.freedesktop.org/series/25018/ State : success == Summary == Series 25018v1 drm: Fix locking in drm_atomic_helper_resume https://patchwork.freedesktop.org/api/1.0/series/25018/revisions/1/mbox/ Te

Re: [Intel-gfx] [PATCH] drm/i915/gvt: remove redundant -Wall

2017-05-29 Thread Nick Desaulniers
ping for review ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PULL] drm-intel-next

2017-05-29 Thread Daniel Vetter
017-05-02 04:46:01 +1000) are available in the git repository at: git://anongit.freedesktop.org/git/drm-intel tags/drm-intel-next-2017-05-29 for you to fetch changes up to cd9f4688a3297c0df0eecc2adaae5812d3e5b997: drm/i915: Update DRIVER_DATE to 20170529 (2017-05

Re: [Intel-gfx] [PATCH 18/37] drm/exynos: Drop drm_vblank_cleanup

2017-05-29 Thread Inki Dae
Hi Daniel, 2017년 05월 24일 23:51에 Daniel Vetter 이(가) 쓴 글: > Only in the load failure path, where the hardware is quiet anyway. > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +---