[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: capture GuC logs if FW fails to load

2017-05-04 Thread Patchwork
== Series Details == Series: drm/i915/guc: capture GuC logs if FW fails to load URL : https://patchwork.freedesktop.org/series/23982/ State : success == Summary == Series 23982v1 drm/i915/guc: capture GuC logs if FW fails to load https://patchwork.freedesktop.org/api/1.0/series/23982/revisions

Re: [Intel-gfx] [PATCH 04/15] drm/i915: Clean up cursor junk from intel_crtc

2017-05-04 Thread Imre Deak
On Mon, Mar 27, 2017 at 09:55:35PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Move cursor_base, cursor_cntl, and cursor_size from intel_crtc > into intel_plane so that we don't need the crtc for cursor stuff > so much. > > Also entirely nuke cursor_addr which IMO doesn

Re: [Intel-gfx] [PATCH] drm/i915: Set all undefined MOCS entries to follow PTE

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 10:56:54AM -0700, Francisco Jerez wrote: > David Weinehall writes: > > > On Thu, May 04, 2017 at 10:51:29AM +0100, Chris Wilson wrote: > >> A good default for garbage entries from the user is to follow the > >> default setting of the object (i.e. the PTE). Currently they u

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts()

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 4 May 2017 13:20:47 +0200 > > Some strings which did not contain data format specifications should be put > into a sequence. Thus use the corresponding function "seq_puts". debugfs / seq_file i

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info()

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 06:59:23PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 4 May 2017 14:15:00 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: quoted string split across lines > > Thus fix the affected source code place.

Re: [Intel-gfx] [PATCHv4 2/3] drm/prime: Introduce drm_gem_prime_import_dev

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 11:45:47AM -0700, Laura Abbott wrote: > > The existing drm_gem_prime_import function uses the underlying > struct device of a drm_device for attaching to a dma_buf. Some drivers > (notably vgem) may not have an underlying device structure. Offer > an alternate function to a

[Intel-gfx] i915 4.9 regression: DP AUX CH sanitization no longer working on Asus desktops

2017-05-04 Thread Daniel Drake
Hi, Numerous Asus desktops and All-in-one computers (e.g. D520MT) have a regression on Linux 4.9 where the VGA output is shown all-white. This is a regression caused by: commit 0ce140d45a8398b501934ac289aef0eb7f47c596 Author: Ville Syrjälä Date: Tue Oct 11 20:52:47 2016 +0300 drm/i915: C

Re: [Intel-gfx] [PATCHv4 1/3] drm/vgem: Add a dummy platform device

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 11:45:46AM -0700, Laura Abbott wrote: > > The vgem driver is currently registered independent of any actual > device. Some usage of the dmabuf APIs require an actual device structure > to do anything. Register a dummy platform device for use with dmabuf. > > Reviewed-by: C

Re: [Intel-gfx] [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 11:45:48AM -0700, Laura Abbott wrote: > > Enable the GEM dma-buf import interfaces in addition to the export > interfaces. This lets vgem be used as a test source for other allocators > (e.g. Ion). > > Reviewed-by: Chris Wilson > Signed-off-by: Laura Abbott > --- > v4: U

Re: [Intel-gfx] [PATCH v2] tests/pm_sseu: Re-enable the test

2017-05-04 Thread Oscar Mateo
On 05/04/2017 08:37 AM, Petri Latvala wrote: On Wed, Apr 26, 2017 at 03:28:09AM -0700, Oscar Mateo wrote: This test got inadvertently disabled by commit 83884e97 (Restore "lib: Open debugfs files for the given DRM device") when the initialization order got changed (dbg_init before gem_init). v2

Re: [Intel-gfx] [PATCH] drm/i915: Update MOCS settings for gen 9

2017-05-04 Thread Ewins, Jon
On 5/4/2017 9:51 AM, Kenneth Graunke wrote: On Thursday, May 4, 2017 7:47:21 AM PDT David Weinehall wrote: On Thu, May 04, 2017 at 10:35:33AM +0200, Arkadiusz Hiler wrote: Thanks for rephrasing - that's exactly what I am concerned with. Did you just use the MediaSDK as it is - meaning that M

[Intel-gfx] [PATCH RESEND] drm: i915: Don't try detecting sinks on ports already in use

2017-05-04 Thread Gabriel Krisman Bertazi
On systems where more than one connector is attached to the same port, the HPD pin is also shared, and attaching one connector will trigger a hotplug on every other connector on that port. But, according to the documentation, connectors sharing the port cannot be enabled simultaneously, such that

Re: [Intel-gfx] i915 4.9 regression: DP AUX CH sanitization no longer working on Asus desktops

2017-05-04 Thread Ville Syrjälä
On Thu, May 04, 2017 at 02:21:26PM -0600, Daniel Drake wrote: > Hi, > > Numerous Asus desktops and All-in-one computers (e.g. D520MT) have a > regression on Linux 4.9 where the VGA output is shown all-white. > > This is a regression caused by: > > commit 0ce140d45a8398b501934ac289aef0eb7f47c596

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info()

2017-05-04 Thread SF Markus Elfring
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c >> @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m) >> >> forcewake_count = >> READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count); >> if (forcewake_count) { >> -seq_puts(m, "RC information in

Re: [Intel-gfx] i915 4.9 regression: DP AUX CH sanitization no longer working on Asus desktops

2017-05-04 Thread Daniel Drake
On Thu, May 4, 2017 at 2:37 PM, Ville Syrjälä wrote: > Please check if commit bb1d132935c2 ("drm/i915/vbt: split out defaults > that are set when there is no VBT") fixes things for you. I think this is not going to help. This would only make a difference when there is no VBT at all at which point

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/guc: Make scratch register base and count flexible

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 06:26:04PM +0200, Michal Wajdeczko wrote: > On Thu, May 04, 2017 at 04:22:15PM +0300, Jani Nikula wrote: > > On Thu, 04 May 2017, Michal Wajdeczko wrote: > > > We are using some scratch registers in MMIO based send function. > > > Make their base and count flexible in prepa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: i915: Don't try detecting sinks on ports already in use (rev2)

2017-05-04 Thread Patchwork
== Series Details == Series: drm: i915: Don't try detecting sinks on ports already in use (rev2) URL : https://patchwork.freedesktop.org/series/23299/ State : success == Summary == Series 23299v2 drm: i915: Don't try detecting sinks on ports already in use https://patchwork.freedesktop.org/api

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info()

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 10:48:10PM +0200, SF Markus Elfring wrote: > >> +++ b/drivers/gpu/drm/i915/i915_debugfs.c > >> @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m) > >> > >>forcewake_count = > >> READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count); >

Re: [Intel-gfx] [PATCH RESEND] drm: i915: Don't try detecting sinks on ports already in use

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 05:36:49PM -0300, Gabriel Krisman Bertazi wrote: > On systems where more than one connector is attached to the same port, > the HPD pin is also shared, and attaching one connector will trigger a > hotplug on every other connector on that port. But, according to the > docume

Re: [Intel-gfx] [PATCH] drm/i915: Set all undefined MOCS entries to follow PTE

2017-05-04 Thread Francisco Jerez
Chris Wilson writes: > On Thu, May 04, 2017 at 10:56:54AM -0700, Francisco Jerez wrote: >> David Weinehall writes: >> >> > On Thu, May 04, 2017 at 10:51:29AM +0100, Chris Wilson wrote: >> >> A good default for garbage entries from the user is to follow the >> >> default setting of the object (i

Re: [Intel-gfx] i915 4.9 regression: DP AUX CH sanitization no longer working on Asus desktops

2017-05-04 Thread Manasi Navare
On Thu, May 04, 2017 at 02:52:09PM -0600, Daniel Drake wrote: > On Thu, May 4, 2017 at 2:37 PM, Ville Syrjälä > wrote: > > Please check if commit bb1d132935c2 ("drm/i915/vbt: split out defaults > > that are set when there is no VBT") fixes things for you. > > I think this is not going to help. Th

Re: [Intel-gfx] [RFC] drm/i915/guc: capture GuC logs if FW fails to load

2017-05-04 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Daniele Ceraolo Spurio >Sent: Thursday, May 4, 2017 11:52 AM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [RFC] drm/i915/guc: capture GuC logs if FW fails to load > >We're cur

Re: [Intel-gfx] [RFC] drm/i915/guc: capture GuC logs if FW fails to load

2017-05-04 Thread Chris Wilson
On Thu, May 04, 2017 at 09:26:35PM +, Srivatsa, Anusha wrote: > >+void i915_guc_load_error_log_capture(struct drm_i915_private *i915) { > >+void *log, *buf; > >+struct i915_vma *vma = i915->guc.log.vma; > >+ > >+if (i915->gpu_error.guc_load_fail_log || !vma) > >+return;

Re: [Intel-gfx] [PATCH RESEND] drm: i915: Don't try detecting sinks on ports already in use

2017-05-04 Thread Manasi Navare
On Thu, May 04, 2017 at 05:36:49PM -0300, Gabriel Krisman Bertazi wrote: > On systems where more than one connector is attached to the same port, > the HPD pin is also shared, and attaching one connector will trigger a > hotplug on every other connector on that port. But, according to the > docume

Re: [Intel-gfx] [PATCH] drm/i915: Update MOCS settings for gen 9

2017-05-04 Thread Dmitry Rogozhkin
On 5/4/2017 9:51 AM, Kenneth Graunke wrote: MediaSDK is not a benchmark. If I'm not mistaken, it's a userspace driver produced by Intel engineers, one which Intel has the full capability to change. What you're saying is that Intel's MediaSDK engineers are unwilling to change their software to

Re: [Intel-gfx] [PATCHv4 3/3] drm/vgem: Enable dmabuf import interfaces

2017-05-04 Thread Joe Perches
On Thu, 2017-05-04 at 21:25 +0100, Chris Wilson wrote: > On Thu, May 04, 2017 at 11:45:48AM -0700, Laura Abbott wrote: > > > > Enable the GEM dma-buf import interfaces in addition to the export > > interfaces. This lets vgem be used as a test source for other allocators > > (e.g. Ion). > > > > Re

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info()

2017-05-04 Thread Dan Carpenter
On Thu, May 04, 2017 at 09:12:32PM +0100, Chris Wilson wrote: > On Thu, May 04, 2017 at 06:59:23PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 4 May 2017 14:15:00 +0200 > > > > The script "checkpatch.pl" pointed information out like the following. > > > > WARNING: quo

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Adjust seven checks for null pointers

2017-05-04 Thread Jani Nikula
On Thu, 04 May 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 4 May 2017 13:52:19 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script “checkpatch.pl” pointed information out like the following. > > Comparison to

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add spaces for better code readability

2017-05-04 Thread Jani Nikula
On Thu, 04 May 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 4 May 2017 14:04:38 +0200 > > Use space characters at some source code places according to > the Linux coding style convention. LGTM. Frankly the only concern I have with accepting this patch is that it encourages

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts()

2017-05-04 Thread Jani Nikula
On Thu, 04 May 2017, Chris Wilson wrote: > On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Thu, 4 May 2017 13:20:47 +0200 >> >> Some strings which did not contain data format specifications should be put >> into a sequence. Thus use the corresp

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Delete unnecessary braces in three functions

2017-05-04 Thread Jani Nikula
On Thu, 04 May 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 4 May 2017 13:40:53 +0200 > > Do not use curly brackets at some source code places > where a single statement should be sufficient. We only tend to do this kind of changes when we're changing the surrounding code a

Re: [Intel-gfx] [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-04 Thread kbuild test robot
Hi Andy, [auto build test ERROR on next-20170503] [cannot apply to pm/linux-next linus/master linux/master v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/guc: Make scratch register base and count flexible

2017-05-04 Thread Jani Nikula
On Thu, 04 May 2017, Chris Wilson wrote: > On Thu, May 04, 2017 at 06:26:04PM +0200, Michal Wajdeczko wrote: >> On Thu, May 04, 2017 at 04:22:15PM +0300, Jani Nikula wrote: >> > On Thu, 04 May 2017, Michal Wajdeczko wrote: >> > > We are using some scratch registers in MMIO based send function. >>

Re: [Intel-gfx] [PATCH] ALSA: hda: Use loop counter for hdac_wait_for_cmd_dmas() timeout

2017-05-04 Thread Lofstedt, Marta
Chris, Jeeja already has a patch that fix this issue in bug 100419, this also "happens" to be identical to a patch a sent on an internal mail to Intel audio developers on the 5 of April. But, then they replied they wanted another solution. I guess it is up to audio dev to decide what solution th

Re: [Intel-gfx] [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-04 Thread Dan Williams
On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use uuid_le type. At the same time we > convert current users. > > acpi_str_to_uuid() becomes useless after the conversion and it's safe

[Intel-gfx] [PATCH v3] drm/i915/edp: Read link status after exit link training

2017-05-04 Thread Lee, Shawn C
From: "Lee, Shawn C" Display driver read DPCD register 0x202, 0x203 and 0x204 to identify eDP sink status. If PSR exit and link trainign are ongoing at eDP sink. And eDP source read these registers at the same time. eDP sink will report EQ & symbol lock not done. Then caused eDP display flicking.

Re: [Intel-gfx] i915 4.9 regression: DP AUX CH sanitization no longer working on Asus desktops

2017-05-04 Thread Jani Nikula
On Thu, 04 May 2017, Daniel Drake wrote: > Hi, > > Numerous Asus desktops and All-in-one computers (e.g. D520MT) have a > regression on Linux 4.9 where the VGA output is shown all-white. Would you mind filing a bug over at [1], essentially with this message copy-pasted and the dmesg attached to t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Read link status after exit PSR (rev3)

2017-05-04 Thread Patchwork
== Series Details == Series: drm/i915/edp: Read link status after exit PSR (rev3) URL : https://patchwork.freedesktop.org/series/23631/ State : success == Summary == Series 23631v3 drm/i915/edp: Read link status after exit PSR https://patchwork.freedesktop.org/api/1.0/series/23631/revisions/3/

Re: [Intel-gfx] [PATCH] drm/i915: Fix rawclk readout for g4x

2017-05-04 Thread Jani Nikula
On Thu, 04 May 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Turns out our skills in decoding the CLKCFG register weren't good > enough. On this particular elk the answer we got was 400 MHz when > in reality the clock was running at 266 MHz, which then caused us > to program

Re: [Intel-gfx] [RFC PATCH 6/6] drm/i915/gvt: support QEMU getting the dmabuf

2017-05-04 Thread Gerd Hoffmann
Hi, > > >>Hmm, that looks like a rather strange way to return a file descriptor. > > >> > > >>What is the reason to not use ioctls on the vfio file handle, like > > >>older version of these patches did? > > >If I understood correctly that Alex prefer not to change the ioctls on the > > >vfio

<    1   2