Re: [Intel-gfx] [PATCH 58/67] drm/i915/cnl: Cannonlake color init.

2017-04-25 Thread Ander Conselvan De Oliveira
On Tue, 2017-04-25 at 05:29 +, Vivi, Rodrigo wrote: > > On Apr 24, 2017, at 10:57 AM, Ville Syrjälä > > wrote: > > > > > On Thu, Apr 06, 2017 at 12:15:54PM -0700, Rodrigo Vivi wrote: > > > Cannonlake has same color setup as Geminilake. > > > Legacy color load luts doesn't work anymore on Can

Re: [Intel-gfx] [PATCH] drm/i915/glk: Don't allow 12 bpc when htotal is too big

2017-04-25 Thread Ander Conselvan De Oliveira
On Mon, 2017-04-24 at 16:49 +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 4/24/2017 4:17 PM, Ander Conselvan de Oliveira wrote: > > Display workaround #1139 for Geminilake instructs us to restrict HDMI > > to 8 bpc when htotal is greater than 5460. Otherwise, the pipe is unable

Re: [Intel-gfx] [PATCH v7 1/4] drm: Add driver-private objects to atomic state

2017-04-25 Thread Maarten Lankhorst
On 21-04-17 07:51, Dhinakaran Pandiyan wrote: > From: "Pandiyan, Dhinakaran" > > It is necessary to track states for objects other than connector, crtc > and plane for atomic modesets. But adding objects like DP MST link > bandwidth to drm_atomic_state would mean that a non-core object will be > m

Re: [Intel-gfx] [PATCH v7 4/4] drm/dp: Track MST link bandwidth

2017-04-25 Thread Maarten Lankhorst
On 21-04-17 07:51, Dhinakaran Pandiyan wrote: > From: "Pandiyan, Dhinakaran" > > Use the added helpers to track MST link bandwidth for atomic modesets. > Link bw is acquired in the ->atomic_check() phase when CRTCs are being > enabled with drm_atomic_find_vcpi_slots() instead of drm_find_vcpi_slot

Re: [Intel-gfx] [PATCH v2 1/2] PCI / PM: Add needs_resume flag to avoid suspend complete optimization

2017-04-25 Thread Imre Deak
On Tue, Apr 25, 2017 at 08:21:49AM +0200, Lukas Wunner wrote: > On Mon, Apr 24, 2017 at 10:56:40PM +0200, Rafael J. Wysocki wrote: > > On Monday, April 24, 2017 10:42:42 PM Lukas Wunner wrote: > > > On Mon, Apr 24, 2017 at 10:02:30PM +0200, Lukas Wunner wrote: > > > > On Mon, Apr 24, 2017 at 05:27:

[Intel-gfx] [PATCH] drm/i915/gvt: fix typo: "supporte" -> "support"

2017-04-25 Thread Colin King
From: Colin Ian King trivial fix to typo in WARN_ONCE message Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gvt/handlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c index 0ad1a508e2af.

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rc6_residency: Add subtest to check RC6 suspend handling

2017-04-25 Thread Szwichtenberg, Radoslaw
On Mon, 2017-04-24 at 14:55 +0200, Ewelina Musial wrote: > In some cases we observed that forcewake isn't kept after > resume and then RC6 residency is not constant. > > References: HSD#1804921797 > Cc: Arkadiusz Hiler > Cc: Michal Winiarski > Cc: Lukasz Fiedorowicz > Signed-off-by: Ewelina Mus

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: fix typo: "supporte" -> "support"

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix typo: "supporte" -> "support" URL : https://patchwork.freedesktop.org/series/23495/ State : success == Summary == Series 23495v1 drm/i915/gvt: fix typo: "supporte" -> "support" https://patchwork.freedesktop.org/api/1.0/series/23495/revisions/1/mbo

[Intel-gfx] [PATCH v4] drm/i915/edp: Read link status more times when EQ not done

2017-04-25 Thread Lee, Shawn C
From: "Lee, Shawn C" Display driver read DPCD register 0x202, 0x203 and 0x204 to identify eDP sink status.If PSR exit is ongoing at eDP sink, and eDP source read these registers at the same time. Panel will report EQ & symbol lock not done. It will cause panel display flicking. Try to read link s

Re: [Intel-gfx] [PATCH v6 05/20] drm/i915/tdr: Add support for per engine reset recovery

2017-04-25 Thread Chris Wilson
On Mon, Apr 24, 2017 at 02:22:21PM -0700, Michel Thierry wrote: > > > On 20/04/17 17:17, Michel Thierry wrote: > >>Hmm. Interesting. This relies on i915_gem_retire_requests() (i.e. > >>struct_mutex) to skip replaying innocent requests, but here we should be > >>asserting that we do have the hung

Re: [Intel-gfx] [PATCH v2 1/2] PCI / PM: Add needs_resume flag to avoid suspend complete optimization

2017-04-25 Thread Lukas Wunner
On Tue, Apr 25, 2017 at 11:55:07AM +0300, Imre Deak wrote: > On Tue, Apr 25, 2017 at 08:21:49AM +0200, Lukas Wunner wrote: > > On Mon, Apr 24, 2017 at 10:56:40PM +0200, Rafael J. Wysocki wrote: > > > On Monday, April 24, 2017 10:42:42 PM Lukas Wunner wrote: > > > > On Mon, Apr 24, 2017 at 10:02:30P

[Intel-gfx] [i-g-t PATCH] Convert ddx_intel_after_fbdev to C.

2017-04-25 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue --- tests/Makefile.sources| 1 + tests/ddx_intel_after_fbdev | 73 - tests/ddx_intel_after_fbdev.c | 121 ++ 3 files changed, 122 insertions(+), 73 deletions(-) delete mode 100755 tests/dd

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Read link status more times when EQ not done (rev5)

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915/dp: Read link status more times when EQ not done (rev5) URL : https://patchwork.freedesktop.org/series/18982/ State : success == Summary == Series 18982v5 drm/i915/dp: Read link status more times when EQ not done https://patchwork.freedesktop.org/api/1.0/s

Re: [Intel-gfx] [PATCH v2 1/2] PCI / PM: Add needs_resume flag to avoid suspend complete optimization

2017-04-25 Thread Imre Deak
On Tue, Apr 25, 2017 at 11:46:42AM +0200, Lukas Wunner wrote: > On Tue, Apr 25, 2017 at 11:55:07AM +0300, Imre Deak wrote: > > On Tue, Apr 25, 2017 at 08:21:49AM +0200, Lukas Wunner wrote: > > > On Mon, Apr 24, 2017 at 10:56:40PM +0200, Rafael J. Wysocki wrote: > > > > On Monday, April 24, 2017 10:

[Intel-gfx] [PATCH V6] drm/i915: Disable stolen memory when i915 runs in guest vm

2017-04-25 Thread Xiong Zhang
Stolen memory isn't a standard pci resource and exists in RMRR which has identity mapping in iommu table when host boot up, so IGD could access stolen memory in host OS. While according to 'commit c875d2c1b808 ("iommu/vt-d: Exclude devices using RMRRs from IOMMU API domains")',RMRR isn't supported

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Prevent the system suspend complete optimization

2017-04-25 Thread Imre Deak
On Mon, Apr 24, 2017 at 10:16:38PM +0200, Lukas Wunner wrote: > On Mon, Apr 24, 2017 at 05:27:43PM +0300, Imre Deak wrote: > > Since > > > > commit bac2a909a096c9110525c18cbb8ce73c660d5f71 > > Author: Rafael J. Wysocki > > Date: Wed Jan 21 02:17:42 2015 +0100 > > > > PCI / PM: Avoid resumi

[Intel-gfx] [PATCH] drm/i915: Report request restarts for both execlists/guc

2017-04-25 Thread Chris Wilson
As we now share the execlist_port[] tracking for both execlists/guc, we can reset the inflight count on both and report which requests are being restarted. Suggested-by: Michel Thierry Signed-off-by: Chris Wilson Cc: Michel Thierry Cc: Mika Kuoppala Cc: Tvrtko Ursulin --- drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rc6_residency: Add subtest to check RC6 suspend handling

2017-04-25 Thread Michał Winiarski
On Mon, Apr 24, 2017 at 02:55:23PM +0200, Ewelina Musial wrote: > In some cases we observed that forcewake isn't kept after > resume and then RC6 residency is not constant. > > References: HSD#1804921797 > Cc: Arkadiusz Hiler > Cc: Michal Winiarski > Cc: Lukasz Fiedorowicz > Signed-off-by: Ewel

Re: [Intel-gfx] [PATCH i-g-t] tests/pm_rc6_residency: Add subtest to check RC6 suspend handling

2017-04-25 Thread Chris Wilson
On Mon, Apr 24, 2017 at 02:55:23PM +0200, Ewelina Musial wrote: > In some cases we observed that forcewake isn't kept after > resume and then RC6 residency is not constant. This test only asks whether the debugfs/forcewake-user is kept across resume. What benefit does this have over the existing t

[Intel-gfx] [PATCH i-g-t v6] benchmarks/gem_wsim: Command submission workload simulator

2017-04-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tool which emits batch buffers to engines with configurable sequences, durations, contexts, dependencies and userspace waits. Unfinished but shows promise so sending out for early feedback. v2: * Load workload descriptors from files. (also -w) * Help text. * Calibration

Re: [Intel-gfx] [PATCH i-g-t v6] benchmarks/gem_wsim: Command submission workload simulator

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 12:13:04PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Tool which emits batch buffers to engines with configurable > sequences, durations, contexts, dependencies and userspace waits. > > Unfinished but shows promise so sending out for early feedback. > > v2:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable stolen memory when i915 runs in guest vm

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915: Disable stolen memory when i915 runs in guest vm URL : https://patchwork.freedesktop.org/series/23501/ State : success == Summary == Series 23501v1 drm/i915: Disable stolen memory when i915 runs in guest vm https://patchwork.freedesktop.org/api/1.0/series

[Intel-gfx] [PATCH v5 00/11] drm/i915: Convert connector properties to atomic.

2017-04-25 Thread Maarten Lankhorst
The preparation patches have been changed slightly. I've made a v3 for aspect ratio and scaling mode to prevent a place where getproperty won't return the same as setproperty for i915. The scaling mode handling is also done separately, it makes it easier to review everything. With less breakage be

[Intel-gfx] [PATCH v5 08/11] drm/i915: Convert intel_dp properties to atomic, v2.

2017-04-25 Thread Maarten Lankhorst
intel_dp supports 3 properties, scaling mode, broadcast rgb and force_audio. intel_digital_connector handles the plumbing, so we only have to hook this up in compute_config and init. Changes since v1: - Remove limited_color_range too, unused. (danvet) Signed-off-by: Maarten Lankhorst Reviewed-by

[Intel-gfx] [PATCH v5 10/11] drm/i915: Handle force_audio correctly in intel_sdvo

2017-04-25 Thread Maarten Lankhorst
Do the same as other connectors, attempt to detect hdmi audio in the detect() callback, and only use the force_audio property as override. Compute has_audio in pipe_config, and use that value instead of the probed value directly. Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter --- d

[Intel-gfx] [PATCH v5 04/11] drm/i915: Add plumbing for digital connector state, v3.

2017-04-25 Thread Maarten Lankhorst
Some atomic properties are common between the various kinds of connectors, for example a lot of them use panel fitting mode. It makes sense to put a lot of it in a common place, so each connector can use it while they're being converted. Implement the properties required for the connectors: - scal

[Intel-gfx] [PATCH v5 11/11] drm/i915: Convert intel_sdvo connector properties to atomic.

2017-04-25 Thread Maarten Lankhorst
SDVO was the last connector that's still using the legacy paths for properties, and this is with a reason! This connector implements a lot of properties dynamically, and some of them shared with the digital connector state, so sdvo_connector_state subclasses intel_digital_connector_state. set_pro

[Intel-gfx] [PATCH v5 06/11] drm/i915: Convert LVDS connector properties to atomic.

2017-04-25 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_lvds.c | 43 --- 1 file changed, 8 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index f4f270b81c8c

[Intel-gfx] [PATCH v5 02/11] drm/core: Allow attaching custom scaling mode properties

2017-04-25 Thread Maarten Lankhorst
Some connectors may not allow all scaling mode properties, this function will allow creating the scaling mode property with only the supported subset. This will make it possible to convert i915 connectors to atomic. Signed-off-by: Maarten Lankhorst Cc: dri-de...@lists.freedesktop.org --- drive

[Intel-gfx] [PATCH v5 07/11] drm/i915: Make intel_dp->has_audio reflect hw state only

2017-04-25 Thread Maarten Lankhorst
Always detect if audio is available during edid detection. With less magic switching it's easier to convert the dp connector properties to atomic. Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_dp.c | 38 -- 1 file

[Intel-gfx] [PATCH v5 01/11] drm/atomic: Handle aspect ratio and scaling mode in core, v3.

2017-04-25 Thread Maarten Lankhorst
This is required to for i915 to convert connector properties to atomic. Changes since v1: - Add docbook info. (danvet) - Change picture_aspect_ratio to enum hdmi_picture_aspect. Changes since v2: - For i915 put the properties in connector_state, to prevent regressions where the property doesn't

[Intel-gfx] [PATCH v5 09/11] drm/i915: Convert intel_hdmi connector properties to atomic

2017-04-25 Thread Maarten Lankhorst
intel_hdmi supports 3 properties, force_audio, broadcast rgb and scaling mode. The last one is only created for eDP, so the is_eDP in set_property is not required. panel fitting and broadcast rgb are straightforward and only requires changing compute_config. force_audio is also used to force DVI

[Intel-gfx] [PATCH v5 05/11] drm/i915: Convert DSI connector properties to atomic.

2017-04-25 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_dsi.c | 47 +++- 1 file changed, 8 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 21c293078cd8..7

[Intel-gfx] [PATCH v5 03/11] drm/i915: Use per-connector scaling mode property

2017-04-25 Thread Maarten Lankhorst
None of the intel connectors can use all types of scaling modes, so only try the ones that are possible. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_dp.c| 35 ++-- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_dsi.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Report request restarts for both execlists/guc

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915: Report request restarts for both execlists/guc URL : https://patchwork.freedesktop.org/series/23502/ State : success == Summary == Series 23502v1 drm/i915: Report request restarts for both execlists/guc https://patchwork.freedesktop.org/api/1.0/series/235

Re: [Intel-gfx] [PATCH V6] drm/i915: Disable stolen memory when i915 runs in guest vm

2017-04-25 Thread Joonas Lahtinen
+ David and Jon On ti, 2017-04-25 at 18:34 +0800, Xiong Zhang wrote: The blocking issue I see is that bisecting is still not pointing at relevant commits. Both bisected commits from Bugzilla are not related to changes in stolen memory usage behavior. I'd assume a successful bisect to land at the

Re: [Intel-gfx] [PATCH i-g-t v6] benchmarks/gem_wsim: Command submission workload simulator

2017-04-25 Thread Tvrtko Ursulin
On 25/04/2017 12:35, Chris Wilson wrote: On Tue, Apr 25, 2017 at 12:13:04PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Tool which emits batch buffers to engines with configurable sequences, durations, contexts, dependencies and userspace waits. Unfinished but shows promise so sending

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Convert connector properties to atomic. (rev6)

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915: Convert connector properties to atomic. (rev6) URL : https://patchwork.freedesktop.org/series/22634/ State : warning == Summary == Series 22634v6 drm/i915: Convert connector properties to atomic. https://patchwork.freedesktop.org/api/1.0/series/22634/revi

Re: [Intel-gfx] [PATCH] drm/i915: Report request restarts for both execlists/guc

2017-04-25 Thread Tvrtko Ursulin
On 25/04/2017 11:38, Chris Wilson wrote: As we now share the execlist_port[] tracking for both execlists/guc, we can reset the inflight count on both and report which requests are being restarted. Suggested-by: Michel Thierry Signed-off-by: Chris Wilson Cc: Michel Thierry Cc: Mika Kuoppala

Re: [Intel-gfx] [PATCH i-g-t v6] benchmarks/gem_wsim: Command submission workload simulator

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 01:10:34PM +0100, Tvrtko Ursulin wrote: > > On 25/04/2017 12:35, Chris Wilson wrote: > >On Tue, Apr 25, 2017 at 12:13:04PM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin [snip] > >>+static enum intel_engine_id > >>+rt_balance(const struct workload_balancer *balancer

Re: [Intel-gfx] [PATCH] drm/i915: Report request restarts for both execlists/guc

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 01:21:47PM +0100, Tvrtko Ursulin wrote: > > On 25/04/2017 11:38, Chris Wilson wrote: > >As we now share the execlist_port[] tracking for both execlists/guc, we > >can reset the inflight count on both and report which requests are being > >restarted. > > > >Suggested-by: Mic

Re: [Intel-gfx] [PATCH i-g-t v6] benchmarks/gem_wsim: Command submission workload simulator

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 01:25:48PM +0100, Chris Wilson wrote: > On Tue, Apr 25, 2017 at 01:10:34PM +0100, Tvrtko Ursulin wrote: > > > > On 25/04/2017 12:35, Chris Wilson wrote: > > >On Tue, Apr 25, 2017 at 12:13:04PM +0100, Tvrtko Ursulin wrote: > > >>From: Tvrtko Ursulin > [snip] > > >>+static e

[Intel-gfx] [PATCH v2] drm/i915: Differentiate between sw write location into ring and last hw read

2017-04-25 Thread Chris Wilson
We need to keep track of the last location we ask the hw to read up to (RING_TAIL) separately from our last write location into the ring, so that in the event of a GPU reset we do not tell the HW to proceed into a partially written request (which can happen if that request is waiting for an externa

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Report request restarts for both execlists/guc

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 11:58:46AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Report request restarts for both execlists/guc > URL : https://patchwork.freedesktop.org/series/23502/ > State : success > > == Summary == > > Series 23502v1 drm/i915: Report request restart

[Intel-gfx] [PATCH i-g-t] igt/meta_test: Fix dmesg-warn test

2017-04-25 Thread Marta Lofstedt
Add bracket to match with piglit dmesg filter. Signed-off-by: Marta Lofstedt --- tests/meta_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/meta_test.c b/tests/meta_test.c index e09efba0..c02cf8bc 100644 --- a/tests/meta_test.c +++ b/tests/meta_test.c @@ -97,

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Differentiate between sw write location into ring and last hw read (rev2)

2017-04-25 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Differentiate between sw write location into ring and last hw read (rev2) URL : https://patchwork.freedesktop.org/series/23411/ State : success == Summary == Series 23411v2 Series without cover letter https://patchwork.freedeskt

Re: [Intel-gfx] [PATCH v2] drm/i915: Differentiate between sw write location into ring and last hw read

2017-04-25 Thread Mika Kuoppala
Chris Wilson writes: > We need to keep track of the last location we ask the hw to read up to > (RING_TAIL) separately from our last write location into the ring, so > that in the event of a GPU reset we do not tell the HW to proceed into > a partially written request (which can happen if that re

Re: [Intel-gfx] [PATCH v2] drm/i915: Differentiate between sw write location into ring and last hw read

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 04:50:15PM +0300, Mika Kuoppala wrote: > Chris Wilson writes: > > > We need to keep track of the last location we ask the hw to read up to > > (RING_TAIL) separately from our last write location into the ring, so > > that in the event of a GPU reset we do not tell the HW t

Re: [Intel-gfx] [PATCH v5 02/11] drm/core: Allow attaching custom scaling mode properties

2017-04-25 Thread Sean Paul
On Tue, Apr 25, 2017 at 01:55:26PM +0200, Maarten Lankhorst wrote: > Some connectors may not allow all scaling mode properties, this function will > allow > creating the scaling mode property with only the supported subset. > > This will make it possible to convert i915 connectors to atomic. > >

Re: [Intel-gfx] [PATCH v5 02/11] drm/core: Allow attaching custom scaling mode properties

2017-04-25 Thread Ville Syrjälä
On Tue, Apr 25, 2017 at 01:55:26PM +0200, Maarten Lankhorst wrote: > Some connectors may not allow all scaling mode properties, this function will > allow > creating the scaling mode property with only the supported subset. > > This will make it possible to convert i915 connectors to atomic. > >

[Intel-gfx] [PATCH] drm/i915: Avoid the branch in computing intel_ring_space()

2017-04-25 Thread Chris Wilson
Exploit the power-of-two ring size to compute the space across the wraparound using a mask rather than a if. Convert to unsigned integers so the operation is well defined. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/intel_ringbuffer.c | 20 ++-- driver

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Lionel Landwerlin
Hey Matt, This commit had your reviewed-by on v4, are you still okay with it? Thanks! - Lionel On 24/04/17 11:49, Lionel Landwerlin wrote: From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular no

[Intel-gfx] GPU hangs and X shot down with 4.11-rc6

2017-04-25 Thread Michal Hocko
Hi, I have just experienced X being shut down once with 4.11-rc2 and 2 times with 4.11-rc6 kernel. I do not remember seeing something like this before but it is quite possible I was just lucky to not trigger this issue before. It always happened while I was working on a presentation in LibreOffice

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Matthew Auld
On 24 April 2017 at 19:49, Lionel Landwerlin wrote: > From: Robert Bragg > > Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all > share (more-or-less) the same OA unit design. > > Of particular note in comparison to Haswell: some OA unit HW config > state has become per-context

[Intel-gfx] [PATCH i-g-t 0/7] Misc fixes and cleanup

2017-04-25 Thread Brian Starkey
Hi, This is not really a series but a set of miscellaneous fixes and cleanup. It should be mostly noncontroversial, with the exception of perhaps the last two patches. Patch 6 splits all of the igt_crc code out of igt_debugfs into a separate file. The goal here was to make it easier to add new C

[Intel-gfx] [PATCH i-g-t 2/7] lib/igt_kms: Fix override_mode handling

2017-04-25 Thread Brian Starkey
igt_display_commit isn't refreshing all outputs anymore, which means that an override mode may never get picked up. Instead of forcing a reprobe to handle copying the override_mode into default_mode, just change igt_output_get_mode() to return the override_mode if it's been set, and remove the old

[Intel-gfx] [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified

2017-04-25 Thread Brian Starkey
If "video=" is specified on the kernel command-line, use it to override the default mode in kmstest_get_connector_default_mode. If a mode override was provided on the command-line, it was probably for good reason so we should honor it. Signed-off-by: Brian Starkey --- lib/igt_kms.c | 135 +

[Intel-gfx] [PATCH i-g-t 5/7] lib/igt_debugfs: Only use valid values in igt_crc_to_str()

2017-04-25 Thread Brian Starkey
Not all elements in the crc array may be valid, so only use the valid ones to generate the string. Signed-off-by: Brian Starkey --- lib/igt_debugfs.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index f5ed3dafee8a..80f25c6159

[Intel-gfx] [PATCH i-g-t 4/7] lib/igt_debugfs: Remove igt_debugfs_t

2017-04-25 Thread Brian Starkey
It's not used anymore, so remove it. Signed-off-by: Brian Starkey --- lib/igt_debugfs.c |5 - 1 file changed, 5 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 7584be5f9cc1..f5ed3dafee8a 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_debugfs.c @@ -84,11 +84,6 @@ *

[Intel-gfx] [PATCH i-g-t RESEND 1/7] lib/igt_kms: Fix erroneous assert

2017-04-25 Thread Brian Starkey
In trying to fix igt_display_init() for devices without cursors, I actually made matters worse. Fix the assert. Fixes: 545aa3398223 lib/igt_kms: Remove redundant cursor code Signed-off-by: Brian Starkey --- lib/igt_kms.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --

[Intel-gfx] [PATCH i-g-t 6/7] igt: lib/igt_crc: Split out CRC functionality

2017-04-25 Thread Brian Starkey
Separate out the CRC code for better compartmentalisation. Should ease the addition of more/different CRC sources in the future. Signed-off-by: Brian Starkey --- lib/Makefile.sources |2 + lib/igt_chamelium.h |1 + lib/igt_crc.c | 563 +

[Intel-gfx] [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak

2017-04-25 Thread Brian Starkey
igt_get_all_cairo_formats() allocates the format list on the heap, but returns it in a const pointer. Change this so that callers can free the array without a warning, and free the array in all callers. Signed-off-by: Brian Starkey --- lib/igt_fb.c |4 +++- lib/igt_fb.h |2 +-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid the branch in computing intel_ring_space()

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915: Avoid the branch in computing intel_ring_space() URL : https://patchwork.freedesktop.org/series/23515/ State : success == Summary == Series 23515v1 drm/i915: Avoid the branch in computing intel_ring_space() https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified

2017-04-25 Thread Ville Syrjälä
On Tue, Apr 25, 2017 at 05:45:13PM +0100, Brian Starkey wrote: > If "video=" is specified on the kernel command-line, use it to override > the default mode in kmstest_get_connector_default_mode. > > If a mode override was provided on the command-line, it was probably for > good reason so we should

Re: [Intel-gfx] [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified

2017-04-25 Thread Brian Starkey
On Tue, Apr 25, 2017 at 07:58:18PM +0300, Ville Syrjälä wrote: On Tue, Apr 25, 2017 at 05:45:13PM +0100, Brian Starkey wrote: If "video=" is specified on the kernel command-line, use it to override the default mode in kmstest_get_connector_default_mode. If a mode override was provided on the co

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Lionel Landwerlin
On 25/04/17 09:42, Matthew Auld wrote: On 24 April 2017 at 19:49, Lionel Landwerlin wrote: From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular note in comparison to Haswell: some OA unit HW confi

Re: [Intel-gfx] [PATCH] drm/i915: Report request restarts for both execlists/guc

2017-04-25 Thread Michel Thierry
On 25/04/17 05:30, Chris Wilson wrote: On Tue, Apr 25, 2017 at 01:21:47PM +0100, Tvrtko Ursulin wrote: On 25/04/2017 11:38, Chris Wilson wrote: As we now share the execlist_port[] tracking for both execlists/guc, we can reset the inflight count on both and report which requests are being resta

[Intel-gfx] [PATCH v7 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular note in comparison to Haswell: some OA unit HW config state has become per-context state and as a consequence it is somewhat more complicated to ma

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable OA unit for Gen 8 and 9 in i915 perf (rev8)

2017-04-25 Thread Patchwork
== Series Details == Series: Enable OA unit for Gen 8 and 9 in i915 perf (rev8) URL : https://patchwork.freedesktop.org/series/20084/ State : failure == Summary == cc1: all warnings being treated as errors cc1: all warnings being treated as errors scripts/Makefile.build:294: recipe for target

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak

2017-04-25 Thread Gabriel Krisman Bertazi
Brian Starkey writes: > igt_get_all_cairo_formats() allocates the format list on the heap, but > returns it in a const pointer. Change this so that callers can free the > array without a warning, and free the array in all callers. > > Signed-off-by: Brian Starkey > --- > lib/igt_fb.c |

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Matthew Auld
On 25 April 2017 at 18:10, Lionel Landwerlin wrote: > On 25/04/17 09:42, Matthew Auld wrote: >> >> On 24 April 2017 at 19:49, Lionel Landwerlin >> wrote: >>> >>> From: Robert Bragg >>> >>> Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all >>> share (more-or-less) the same OA

[Intel-gfx] [PATCH v2 14/21] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers

2017-04-25 Thread Logan Gunthorpe
These two drivers appear to duplicate the functionality of sg_copy_buffer. So we clean them up to use the common code. This helps us remove a couple of instances that would otherwise be slightly tricky sg_map usages. Signed-off-by: Logan Gunthorpe Cc: Johannes Thumshirn --- drivers/scsi/csiost

[Intel-gfx] [PATCH v2 18/21] mmc: tmio: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to sg_map helper. Seeing there is no cleare error path, SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Wolfram Sang Cc: Ulf Hansson --- drivers/mmc/host/tmio_mmc.h | 7 +-- drivers/mmc/host/tmio_mmc_p

[Intel-gfx] [PATCH v2 03/21] libiscsi: Make use of new the sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Convert the kmap and kmap_atomic uses to the sg_map function. We now store the flags for the kmap instead of a boolean to indicate atomicitiy. We use ISCSI_TCP_INTERNAL_ERR error type that was prepared earlier for this. Signed-off-by: Logan Gunthorpe Cc: Lee Duncan Cc: Chris Leech --- drivers/

[Intel-gfx] [PATCH v2 04/21] target: Make use of the new sg_map function at 16 call sites

2017-04-25 Thread Logan Gunthorpe
Fairly straightforward conversions in all spots. In a couple of cases any error gets propogated up should sg_map fail. In other cases a warning is issued if the kmap fails seeing there's no clear error path. This should not be an issue until someone tries to use unmappable memory in the sgl with th

[Intel-gfx] [PATCH v2 08/21] dm-crypt: Make use of the new sg_map helper in 4 call sites

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion to the new function in all four spots. Signed-off-by: Logan Gunthorpe Cc: Alasdair Kergon Cc: Mike Snitzer --- drivers/md/dm-crypt.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/md/dm-crypt

[Intel-gfx] [PATCH v2 09/21] staging: unisys: visorbus: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Acked-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers

[Intel-gfx] [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to the new helper, except due to the lack of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Konrad Rzeszutek Wilk Cc: "Roger Pau Monné" --- dr

[Intel-gfx] [PATCH v2 05/21] drm/i915: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This is a single straightforward conversion from kmap to sg_map. We also create the i915_gem_object_unmap function to common up the unmap code. Signed-off-by: Logan Gunthorpe Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 27 --- 1 file changed, 16 insert

[Intel-gfx] [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion to the new function in the caam driver and shash library. Signed-off-by: Logan Gunthorpe Cc: Herbert Xu Cc: "David S. Miller" --- crypto/shash.c| 9 ++--- drivers/crypto/caam/caamalg.c | 8 +++- 2 files changed, 9 insertions(+), 8 deletio

[Intel-gfx] [PATCH v2 02/21] libiscsi: Add an internal error code

2017-04-25 Thread Logan Gunthorpe
This is a prep patch to add a new error code to libiscsi. We want to rework some kmap calls to be able to fail. When we do, we'd like to use this error code. This patch simply introduces ISCSI_TCP_INTERNAL_ERR and prints "Internal Error." when it gets hit. Signed-off-by: Logan Gunthorpe --- dri

[Intel-gfx] [PATCH v2 06/21] crypto: hifn_795x: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Conversion of a couple kmap_atomic instances to the sg_map helper function. However, it looks like there was a bug in the original code: the source scatter lists offset (t->offset) was passed to ablkcipher_get which added it to the destination address. This doesn't make a lot of sense, but t->offs

[Intel-gfx] [PATCH v2 00/21] Introduce common scatterlist map function

2017-04-25 Thread Logan Gunthorpe
Changes since v1: * Rebased onto next-20170424 * Removed the _offset version of these functions per Christoph's suggestion * Added an SG_MAP_MUST_NOT_FAIL flag which will BUG_ON in future cases that can't gracefully fail. This removes a bunch of the noise added in v1 to a couple of the drive

[Intel-gfx] [PATCH v2 20/21] mmc: tifm_sd: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This conversion is a bit complicated. We modiy the read_fifo, write_fifo and copy_page functions to take a scatterlist instead of a page. Thus we can use sg_map instead of kmap_atomic. There's a bit of accounting that needed to be done for the offset for this to work. (Seeing sg_map takes care of t

[Intel-gfx] [PATCH v2 12/21] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Achim Leubner Cc: John Garry --- drivers/scsi/gdth.c| 9 +++-- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 14 +- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 13 +---

[Intel-gfx] [PATCH v2 21/21] memstick: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion, but we have to make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Alex Dubov --- drivers/memstick/host/jmb38x_ms.c | 11 ++- drivers/memstick/host/tifm_ms.c | 11 ++- 2 files changed,

[Intel-gfx] [PATCH v2 11/21] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Brian King Cc: Artur Paszkiewicz --- drivers/scsi/ipr.c | 27 ++- drivers/scsi/isci/request.c | 42 +- drivers/scsi/pmcraid.c

[Intel-gfx] [PATCH v2 17/21] mmc: spi: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
We use the sg_map helper but it's slightly more complicated as we only check for the error when the mapping actually gets used. Such that if the mapping failed but wasn't needed then no error occurs. Signed-off-by: Logan Gunthorpe Cc: Ulf Hansson --- drivers/mmc/host/mmc_spi.c | 26

[Intel-gfx] [PATCH v2 13/21] scsi: arcmsr, ips, megaraid: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers Signed-off-by: Logan Gunthorpe Cc: Adaptec OEM Raid Solutions Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S --- drivers/scsi/arcmsr/arcmsr_hba.c | 16 drivers/scsi/ips.c | 8 drivers/scsi/me

[Intel-gfx] [PATCH v2 19/21] mmc: sdricoh_cs: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This is a straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Cc: Sascha Sommer Cc: Ulf Hansson --- drivers/mmc/host/sdricoh_cs.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdric

[Intel-gfx] [PATCH v2 10/21] RDS: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion except there's no error path, so we make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Santosh Shilimkar Cc: "David S. Miller" --- net/rds/ib_recv.c | 8 1 file changed, 4 insertions(+), 4 del

[Intel-gfx] [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-25 Thread Logan Gunthorpe
This patch introduces functions which kmap the pages inside an sgl. These functions replace a common pattern of kmap(sg_page(sg)) that is used in more than 50 places within the kernel. The motivation for this work is to eventually safely support sgls that contain io memory. In order for that to wo

[Intel-gfx] [PATCH v2 16/21] mmc: sdhci: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion, except due to the lack of an error path we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Adrian Hunter Cc: Ulf Hansson --- drivers/mmc/host/sdhci.c | 14 +- 1 file changed, 9 insertio

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce common scatterlist map function (rev2)

2017-04-25 Thread Patchwork
== Series Details == Series: Introduce common scatterlist map function (rev2) URL : https://patchwork.freedesktop.org/series/23149/ State : success == Summary == Series 23149v2 Introduce common scatterlist map function https://patchwork.freedesktop.org/api/1.0/series/23149/revisions/2/mbox/ T

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak

2017-04-25 Thread Brian Starkey
On Tue, Apr 25, 2017 at 02:43:13PM -0300, Gabriel Krisman Bertazi wrote: Brian Starkey writes: igt_get_all_cairo_formats() allocates the format list on the heap, but returns it in a const pointer. Change this so that callers can free the array without a warning, and free the array in all calle

Re: [Intel-gfx] GPU hangs and X shot down with 4.11-rc6

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 06:41:20PM +0200, Michal Hocko wrote: > Hi, > I have just experienced X being shut down once with 4.11-rc2 and 2 times > with 4.11-rc6 kernel. I do not remember seeing something like this > before but it is quite possible I was just lucky to not trigger this > issue before.

[Intel-gfx] [PATCH 00/11] drm/i915: LPE audio runtime PM and multipipe

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä I was wondering why my VLV no longer runtime suspended, and after some thinking I decided it had to be the LPE audio preventing it. Turns out I was right, so here's my attempt at fixing it. And while looking at the code I couldn't help but notice that it couldn't actually han

[Intel-gfx] [PATCH 01/11] drm/i915: Fix runtime PM for LPE audio

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä Not calling pm_runtime_enable() means that runtime PM can't be enabled at all via sysfs. So we definitely need to call it from somewhere. Calling it from the driver seems like a bad idea because it would have to be paired with a pm_runtime_disable() at driver unload time, oth

[Intel-gfx] [PATCH 02/11] ALSA: x86: Clear the pdata.notify_lpe_audio pointer before teardown

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä Clear the notify function pointer in the platform data before we tear down the driver. Otherwise i915 would end up calling a stale function pointer and possibly explode. Cc: Takashi Iwai Cc: Pierre-Louis Bossart Signed-off-by: Ville Syrjälä --- sound/x86/intel_hdmi_audio.

[Intel-gfx] [PATCH 04/11] drm/i915: Remove the unsued pending_notify from LPE platform data

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä The pending_notify flag in the LPE audio platform data is pointless, actually unused. So let's kill it off. Cc: Takashi Iwai Cc: Pierre-Louis Bossart Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_lpe_audio.c | 2 -- include/drm/intel_lpe_audio.h | 1

  1   2   >