[Intel-gfx] [PATCH] drm/i915: Keep all engine locks across scheduling

2017-03-26 Thread Chris Wilson
Unlocking is dangerous. In this case we combine an early update to the out-of-queue request, because we know that it will be inserted into the correct FIFO priority-ordered slot when it becomes ready in the future. However, given sufficient enthusiasm, it may become ready as we are continuing to re

[Intel-gfx] [PATCH] drm/i915: Keep all engine locks across scheduling

2017-03-26 Thread Chris Wilson
Unlocking is dangerous. In this case we combine an early update to the out-of-queue request, because we know that it will be inserted into the correct FIFO priority-ordered slot when it becomes ready in the future. However, given sufficient enthusiasm, it may become ready as we are continuing to re

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Keep all engine locks across scheduling (rev2)

2017-03-26 Thread Patchwork
== Series Details == Series: drm/i915: Keep all engine locks across scheduling (rev2) URL : https://patchwork.freedesktop.org/series/21890/ State : success == Summary == Series 21890v2 drm/i915: Keep all engine locks across scheduling https://patchwork.freedesktop.org/api/1.0/series/21890/revi

[Intel-gfx] linux-next: manual merge of the kspp tree with the drm-misc tree

2017-03-26 Thread Stephen Rothwell
Hi Kees, Today's linux-next merge of the kspp tree got a conflict in: include/drm/drm_drv.h between commit: 91faa0478b59 ("drm: drop extern from function decls") from the drm-misc tree and commit: 6bbaac116552 ("initify: Mark functions with the __nocapture attribute") from the kspp tre

Re: [Intel-gfx] [PATCHi v2] drm/i915: Enhanced disable access to stolen memory as a guest

2017-03-26 Thread Zhenyu Wang
On 2017.03.24 18:23:44 +0800, Xiong Zhang wrote: > commit "04a68a3 drm/i915/gvt: Disable access to stolen memory as a guest" > isn't enough in GVT-d which will pass through IGD to guest and don't run > vgt code. While intel_vgpu_active() is true only when vgt code run on > host and guest in GVT-g.

Re: [Intel-gfx] [PATCH v4] drm/i915/scheduler: add gvt notification for guc submission

2017-03-26 Thread Dong, Chuanxiao
Hello, ping for review v4. It fixed the comments from Joonas and Chris. Would like to know if this patch can be applied in i915 to unblock the GVT in GuC mode. :) Thanks Chuanxiao > -Original Message- > From: Dong, Chuanxiao > Sent: Friday, March 24, 2017 9:49 AM > To: intel-gfx@lists.f

[Intel-gfx] [PATCH 2/2] drm/i915: Assert that the request->tail fits within the ring

2017-03-26 Thread Chris Wilson
In addition to being qword-aligned, the RING_TAIL offset must be within the ring! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_lrc.c| 4 drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/d

[Intel-gfx] [PATCH 1/2] drm/i915/execlists: Wrap tail pointer after reset tweaking

2017-03-26 Thread Chris Wilson
If the request->wa_tail is 0 (because it landed exactly on the end of the ringbuffer), when we reconstruct request->tail following a reset we fill in an illegal value (-8 or 0x0018). As a result, RING_HEAD is never able to catch up with RING_TAIL and the GPU spins endlessly. If the ring contain

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/execlists: Wrap tail pointer after reset tweaking

2017-03-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Wrap tail pointer after reset tweaking URL : https://patchwork.freedesktop.org/series/21907/ State : success == Summary == Series 21907v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/21

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-26 Thread Michel Dänzer
On 23/03/17 07:32 PM, Thomas Hellstrom wrote: > On 03/23/2017 11:10 AM, Daniel Vetter wrote: >> On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: >>> On 03/23/2017 08:31 AM, Daniel Vetter wrote: On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: > On Thu, Mar 23

Re: [Intel-gfx] [PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-26 Thread Maarten Lankhorst
Hey, There are still 2 unnecessary NULL checks, afaict. Op 22-03-17 om 23:30 schreef Dhinakaran Pandiyan: > From: "Pandiyan, Dhinakaran" > > It is necessary to track states for objects other than connector, crtc > and plane for atomic modesets. But adding objects like DP MST link > bandwidth to

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-26 Thread Daniel Vetter
We discussed this quickly on irc, transcribing. On Mon, Mar 27, 2017 at 5:01 AM, Michel Dänzer wrote: > Strictly speaking, the (virtual) hardware is too limited to support the > legacy KMS cursor API. AFAIR e.g. weston at least used to make use of HW > cursors for other surfaces, not sure that's

Re: [Intel-gfx] [PATCH v5 4/8] drm: Add driver-private objects to atomic state

2017-03-26 Thread Daniel Vetter
On Wed, Mar 22, 2017 at 03:30:49PM -0700, Dhinakaran Pandiyan wrote: > From: "Pandiyan, Dhinakaran" > > It is necessary to track states for objects other than connector, crtc > and plane for atomic modesets. But adding objects like DP MST link > bandwidth to drm_atomic_state would mean that a non

Re: [Intel-gfx] [dim PATCH 1/7] completion: shellcheck bash completion and fix issues

2017-03-26 Thread Daniel Vetter
On Fri, Mar 24, 2017 at 06:11:53PM +0200, Jani Nikula wrote: > Add bash_completion to 'make shellcheck' target, and fix the failures. > > Signed-off-by: Jani Nikula > --- > Makefile| 2 +- > bash_completion | 13 +++-- > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff

Re: [Intel-gfx] [dim PATCH 3/7] dim: add 'make mancheck' target to check all subcommands have been documented

2017-03-26 Thread Daniel Vetter
On Fri, Mar 24, 2017 at 06:11:55PM +0200, Jani Nikula wrote: > Just a simple grep. > > Signed-off-by: Jani Nikula > --- > Makefile | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Makefile b/Makefile > index c1fe02c1b565..ce283114c4aa 100644 > --- a/Makefile > +++ b/Makefile > @@

Re: [Intel-gfx] [dim PATCH 7/7] dim: group command documentation in the man page by target audiences

2017-03-26 Thread Daniel Vetter
On Fri, Mar 24, 2017 at 06:11:59PM +0200, Jani Nikula wrote: > Group the man page by: > > - commands for developers > - commands for committers and maintainers > - advanced commands for committers and maintainers > - commands for maintainers > - dim help commands. > > We have so many commands by

Re: [Intel-gfx] [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

2017-03-26 Thread Frans Klaver
On Thu, Mar 23, 2017 at 1:22 PM, Colin King wrote: > From: Colin Ian King > > info is being checked to see if it is a null pointer, however, vpgu is > dereferencing info before this check, leading to a potential null > pointer dereference. If info is null, then the error message being > printed

Re: [Intel-gfx] [PATCH 08/19] drm/tilcdc: Drop calls to modeset_lock_crtc

2017-03-26 Thread Jyri Sarha
On 03/22/17 23:50, Daniel Vetter wrote: > Again this is an internal helper, not the official way to lock a crtc. > > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Signed-off-by: Daniel Vetter Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 12 ++-- > 1 file changed, 6 in

Re: [Intel-gfx] [PATCH] drm/i915: Remove unsafe i915.enable_rc6

2017-03-26 Thread Daniel Vetter
On Sat, Mar 25, 2017 at 02:23:44PM +, Chris Wilson wrote: > It has been many years since the last confirmed sighting (and fix) of an > RC6 related bug (usually a system hang). Remove the parameter to stop > users from setting dangerous values. > > Signed-off-by: Chris Wilson > Cc: Jani Nikula