Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: > On 03/22/2017 10:50 PM, Daniel Vetter wrote: > > It's been around forever, no one bothered to address the FIXME, so I > > presume it's all fine. > > > > Cc: Sinclair Yeh > > Cc: Thomas Hellstrom > > Signed-off-by: Daniel Vetter

Re: [Intel-gfx] [PATCH] drm/i915: Actually pass the reclaim gfp_t along to shmemfs!

2017-03-23 Thread Joonas Lahtinen
On ke, 2017-03-22 at 22:34 +, Chris Wilson wrote: > Words cannot describe the embarrassment at creating a new gfp_t relaim to > only prevent the oomkiller but allow direct|kswapd reclaim, and then not > use it in the shmem_read_mapping_page_gfp(). > > Fixes: 24f8e00a8a2e ("drm/i915: Prefer to

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: > On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: > > On 03/22/2017 10:50 PM, Daniel Vetter wrote: > > > It's been around forever, no one bothered to address the FIXME, so I > > > presume it's all fine. > > > > > > Cc:

[Intel-gfx] [PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-23 Thread Chris Wilson
We want to provide the vblank irq shadow for pageflip events as well as vblank queries. Such events are completed within the vblank interrupt handler, and so the current check for disabling the irq will disable it from with the same interrupt as the last pageflip event. If we move the decision on w

Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt notification for guc submission

2017-03-23 Thread Tian, Kevin
> From: Dong, Chuanxiao > Sent: Thursday, March 23, 2017 1:29 PM > > Ping for review. GVT relies on the notification before a request submitted > and after a request completed, just like when using execlist mode submission. > > > -Original Message- > > From: Dong, Chuanxiao > > Sent: Wedn

Re: [Intel-gfx] [PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-23 Thread Chris Wilson
Better subject might be drm: Use vblank irq shadow for entire flip sequence -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for more drmP.h cleanup (rev7)

2017-03-23 Thread Patchwork
== Series Details == Series: more drmP.h cleanup (rev7) URL : https://patchwork.freedesktop.org/series/21670/ State : success == Summary == Series 21670v7 more drmP.h cleanup https://patchwork.freedesktop.org/api/1.0/series/21670/revisions/7/mbox/ Test kms_pipe_crc_basic: Subgroup sus

[Intel-gfx] [dim PATCH] completion: shellcheck bash completion and fix issues

2017-03-23 Thread Jani Nikula
Add bash_completion to 'make shellcheck' target, and fix the failures. Signed-off-by: Jani Nikula --- Makefile| 2 +- bash_completion | 13 +++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 30fc3dd3bff8..c1fe02c1b565 100644 --- a/Make

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Thomas Hellstrom
Hi, Daniel, On 03/23/2017 08:31 AM, Daniel Vetter wrote: > On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: >> On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: >>> On 03/22/2017 10:50 PM, Daniel Vetter wrote: It's been around forever, no one bothered to address

Re: [Intel-gfx] [PATCH v4 4/8] drm: Add driver-private objects to atomic state

2017-03-23 Thread Maarten Lankhorst
Op 22-03-17 om 22:05 schreef Pandiyan, Dhinakaran: > On Wed, 2017-03-22 at 11:00 +0100, Maarten Lankhorst wrote: >> Op 16-03-17 om 08:10 schreef Dhinakaran Pandiyan: >>> From: "Pandiyan, Dhinakaran" >>> >>> It is necessary to track states for objects other than connector, crtc >>> and plane for at

[Intel-gfx] [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence

2017-03-23 Thread Chris Wilson
Ensure that before we overwrite the reservation_object with our exclusive fence for the pending clflush operation, that we do wait upon all the fences in the current reservation_object. Fixes: 57822dc6b9cf ("drm/i915: Perform object clflushing asynchronously") Signed-off-by: Chris Wilson Cc: Joon

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Restore marking context objects as dirty on pinning

2017-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Restore marking context objects as dirty on pinning URL : https://patchwork.freedesktop.org/series/21708/ State : failure == Summary == Series 21708v1 drm/i915: Restore marking context objects as dirty on pinning https://patchwork.freedesktop.org/api/1.0/

[Intel-gfx] [GIT PULL] more GVT-g fixes for 4.11

2017-03-23 Thread Zhenyu Wang
Hi, Here's updated gvt fixes for 4.11. Major ones are for KVM reference fix, guest gtt partial update fix for very big guest mem, and Changbin's following fix for gvt context notification. Thanks. -- The following changes since commit 2958b9013fcbabeeba221161d0712f5259f1e15d: drm/i915/gvt: F

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove superfluous hw_flags from mi_set_context()

2017-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Remove superfluous hw_flags from mi_set_context() URL : https://patchwork.freedesktop.org/series/21709/ State : success == Summary == Series 21709v1 drm/i915: Remove superfluous hw_flags from mi_set_context() https://patchwork.freedesktop.org/api/1.0/seri

[Intel-gfx] ✗ Fi.CI.BAT: warning for wire acquire ctx through legacy modeset paths

2017-03-23 Thread Patchwork
== Series Details == Series: wire acquire ctx through legacy modeset paths URL : https://patchwork.freedesktop.org/series/21710/ State : warning == Summary == Series 21710v1 wire acquire ctx through legacy modeset paths https://patchwork.freedesktop.org/api/1.0/series/21710/revisions/1/mbox/

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Skip unused fw_domains

2017-03-23 Thread Mika Kuoppala
Chris Wilson writes: > Use find-first-set bitop to quickly scan through the fw_domains mask and > skip iterating over unused domains. > > v2: Move the WARN into the caller, to prevent compiler warnings in > normal builds. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_debugfs

Re: [Intel-gfx] [PATCH] drm/i915: Remove superfluous hw_flags from mi_set_context()

2017-03-23 Thread Tvrtko Ursulin
On 22/03/2017 21:03, Chris Wilson wrote: Why have both hw_flags and flags, when just one will do? Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_context.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_context.c

Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt notification for guc submission

2017-03-23 Thread Joonas Lahtinen
On ke, 2017-03-22 at 14:34 +0800, Chuanxiao Dong wrote: > GVT request needs a manual mmio load/restore. Before GuC submit > a request, send notification to gvt for mmio loading. And after > the GuC finished this GVT request, notify gvt again for mmio > restore. This follows the usage when using exe

Re: [Intel-gfx] [PATCH] drm/i915: Restore marking context objects as dirty on pinning

2017-03-23 Thread Tvrtko Ursulin
On 22/03/2017 20:59, Chris Wilson wrote: Commit e8a9c58fcd9a ("drm/i915: Unify active context tracking between legacy/execlists/guc") converted the legacy intel_ringbuffer submission to the same context pinning mechanism as execlists - that is to pin the context until the subsequent request is r

Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt notification for guc submission

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 11:37:32AM +0200, Joonas Lahtinen wrote: > On ke, 2017-03-22 at 14:34 +0800, Chuanxiao Dong wrote: > > @@ -87,5 +87,18 @@ uint64_t intel_lr_context_descriptor(struct > > i915_gem_context *ctx, > >  /* Execlists */ > >  int intel_sanitize_enable_execlists(struct drm_i915_pri

Re: [Intel-gfx] [PATCH] drm/i915: Restore marking context objects as dirty on pinning

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 09:41:30AM +, Tvrtko Ursulin wrote: > > On 22/03/2017 20:59, Chris Wilson wrote: > >Commit e8a9c58fcd9a ("drm/i915: Unify active context tracking between > >legacy/execlists/guc") converted the legacy intel_ringbuffer submission > >to the same context pinning mechanism

Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt notification for guc submission

2017-03-23 Thread Tvrtko Ursulin
On 22/03/2017 06:34, Chuanxiao Dong wrote: GVT request needs a manual mmio load/restore. Before GuC submit a request, send notification to gvt for mmio loading. And after the GuC finished this GVT request, notify gvt again for mmio restore. This follows the usage when using execlists submission.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Actually pass the reclaim gfp_t along to shmemfs!

2017-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Actually pass the reclaim gfp_t along to shmemfs! URL : https://patchwork.freedesktop.org/series/21721/ State : success == Summary == Series 21721v1 drm/i915: Actually pass the reclaim gfp_t along to shmemfs! https://patchwork.freedesktop.org/api/1.0/seri

Re: [Intel-gfx] [PATCH] drm/i915: Actually pass the reclaim gfp_t along to shmemfs!

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 09:29:47AM +0200, Joonas Lahtinen wrote: > On ke, 2017-03-22 at 22:34 +, Chris Wilson wrote: > > Words cannot describe the embarrassment at creating a new gfp_t relaim to > > only prevent the oomkiller but allow direct|kswapd reclaim, and then not > > use it in the shmem

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Restore marking context objects as dirty on pinning

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 09:03:30AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Restore marking context objects as dirty on pinning > URL : https://patchwork.freedesktop.org/series/21708/ > State : failure > > == Summary == > > Series 21708v1 drm/i915: Restore marking c

Re: [Intel-gfx] [PATCH] drm/i915: Remove superfluous hw_flags from mi_set_context()

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 09:37:35AM +, Tvrtko Ursulin wrote: > > On 22/03/2017 21:03, Chris Wilson wrote: > >Why have both hw_flags and flags, when just one will do? > > > >Signed-off-by: Chris Wilson > >--- > > drivers/gpu/drm/i915/i915_gem_context.c | 14 +++--- > > 1 file changed, 7

[Intel-gfx] [dim PATCH 2/7] dim: abstract and fix maintainer scope check for dinq

2017-03-23 Thread Jani Nikula
Separate maintainer scope check from checkpatch, and only do the check on applying patches. Also, fix the failures on grep not matching. Fixes: 56e53a49e28f ("dim: declare and assign separately") Signed-off-by: Jani Nikula --- dim | 33 - 1 file changed, 20 insert

[Intel-gfx] [dim PATCH 7/7] dim: propagate errors from check_maintainer

2017-03-23 Thread Jani Nikula
Signed-off-by: Jani Nikula --- dim | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/dim b/dim index 7b6275e7796f..989674ab7a91 100755 --- a/dim +++ b/dim @@ -701,7 +701,9 @@ function dim_apply_branch if ! checkpatch_commit HEAD; then rv=1

[Intel-gfx] [dim PATCH 4/7] dim: return exit code from checkpatch_commit

2017-03-23 Thread Jani Nikula
Return the exit code to let callers make better decisions on what to do. Signed-off-by: Jani Nikula --- dim | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/dim b/dim index e6943d34c43f..c282782b429d 100755 --- a/dim +++ b/dim @@ -697,7 +697,7 @@ function dim_app

[Intel-gfx] [dim PATCH 1/7] dim: don't fail on grep not matching

2017-03-23 Thread Jani Nikula
Oops, the comment told us to watch out for this. Fixes: 56e53a49e28f ("dim: declare and assign separately") Signed-off-by: Jani Nikula --- dim | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/dim b/dim index c1ac9e546ea9..ddcc18f17f0d 100755 --- a/dim +++ b/dim @@ -1091,10

[Intel-gfx] [dim PATCH 5/7] dim: make dim checkpatch subcommand return exit codes

2017-03-23 Thread Jani Nikula
Signed-off-by: Jani Nikula --- dim | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dim b/dim index c282782b429d..e23617c8907c 100755 --- a/dim +++ b/dim @@ -1179,13 +1179,17 @@ dim_alias_check_patch=checkpatch dim_alias_cp=checkpatch function dim_checkpatch { -

[Intel-gfx] [dim PATCH 6/7] dim: make dim apply-branch subcommand return exit codes

2017-03-23 Thread Jani Nikula
For example, piping from emacs only pops up the stdout/stderr buffer when the exit code is non-zero. Signed-off-by: Jani Nikula --- dim | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/dim b/dim index e23617c8907c..7b6275e7796f 100755 --- a/dim +++ b/dim @@ -667,7

[Intel-gfx] [dim PATCH 3/7] dim: only issue warnings on new BUG macros

2017-03-23 Thread Jani Nikula
We apply the patch regardless of the warn_or_fail result, so just switch to using an error message. Signed-off-by: Jani Nikula --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index 268bc6ca280d..e6943d34c43f 100755 --- a/dim +++ b/dim @@ -1112,7 +1112,7 @@ f

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: Skip unused fw_domains

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 11:36:53AM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > @@ -1253,9 +1269,9 @@ static void intel_uncore_fw_domains_init(struct > > drm_i915_private *dev_priv) > >FORCEWAKE_MT, FORCEWAKE_MT_ACK); > > > > spin_lock_irq(&dev_

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: > Hi, Daniel, > > On 03/23/2017 08:31 AM, Daniel Vetter wrote: > > On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: > >> On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas Hellstrom wrote: > >>> On 03/22/2017 10:50 PM, D

[Intel-gfx] ✓ Fi.CI.BAT: success for Enhancement to intel_dp_aux_backlight driver (rev2)

2017-03-23 Thread Patchwork
== Series Details == Series: Enhancement to intel_dp_aux_backlight driver (rev2) URL : https://patchwork.freedesktop.org/series/21086/ State : success == Summary == Series 21086v2 Enhancement to intel_dp_aux_backlight driver https://patchwork.freedesktop.org/api/1.0/series/21086/revisions/2/mb

[Intel-gfx] [CI 1/7] drm/i915: Eliminate per-fw_domain i915 backpointer

2017-03-23 Thread Chris Wilson
Pass along the drm_i915_private pointer from the caller, rather than looking it up from each fw_domain during fw_domains_get/_put. This allows us to then eliminate the backpointer, in exchange for a more complicated unwrapping procedure in the rare intel_uncore_fw_release_timer(). Signed-off-by: C

[Intel-gfx] [CI 4/7] drm/i915: Skip unused fw_domains

2017-03-23 Thread Chris Wilson
Use find-first-set bitop to quickly scan through the fw_domains mask and skip iterating over unused domains. v2: Move the WARN into the caller, to prevent compiler warnings in normal builds. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-

[Intel-gfx] [CI 3/7] drm/i915: Use correct fw_domains during reset

2017-03-23 Thread Chris Wilson
In the next patch we will begin to sanity check that we do not attempt to obtain the forcewake on an unsupport domain. However, that is exactly what we do during reset of the fw_domains - rectify it before it explodes. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Mika Kuoppala ---

[Intel-gfx] [CI 5/7] drm/i915: Remove posting-read for forcewake put

2017-03-23 Thread Chris Wilson
We can relax the requirement upon ourselves that the forcewake is released immediately and just allow it to occur naturally following our mmio request. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i915/intel_uncore.c |

[Intel-gfx] [CI 2/7] drm/i915: Use correct fw_domains during initialisation

2017-03-23 Thread Chris Wilson
In the next patch we will begin to sanity check that we do not attempt to obtain the forcewake on an unsupport domain. However, that is exactly what we do during our actual initialisation of fw_domains - rectify it before it explodes. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Mi

[Intel-gfx] [CI 7/7] drm/i915: Drop uncore spinlock for reading debugfs forcewake counters

2017-03-23 Thread Chris Wilson
The set of available structs is not protected by the spinlock, and for the single read we can use READ_ONCE instead. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_debugfs.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/driv

[Intel-gfx] [CI 6/7] drm/i915: All fw_domains share the same set/clear/reset values

2017-03-23 Thread Chris Wilson
Since we reuse the same values for each fw_domain, move them onto uncore. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 11 +- drivers/gpu/drm/i915/intel_uncore.c | 40 +++-- 2 files changed, 27 inserti

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Thomas Hellstrom
On 03/23/2017 11:10 AM, Daniel Vetter wrote: > On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: >> Hi, Daniel, >> >> On 03/23/2017 08:31 AM, Daniel Vetter wrote: >>> On Thu, Mar 23, 2017 at 08:28:32AM +0100, Daniel Vetter wrote: On Thu, Mar 23, 2017 at 07:22:31AM +0100, Thomas

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reduce Data Link N value for 1 lane DP->hdmi converters

2017-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Reduce Data Link N value for 1 lane DP->hdmi converters URL : https://patchwork.freedesktop.org/series/21724/ State : success == Summary == Series 21724v1 drm/i915: Reduce Data Link N value for 1 lane DP->hdmi converters https://patchwork.freedesktop.org/

[Intel-gfx] ✓ Fi.CI.BAT: success for Various improvements around the GuC topic

2017-03-23 Thread Patchwork
== Series Details == Series: Various improvements around the GuC topic URL : https://patchwork.freedesktop.org/series/21726/ State : success == Summary == Series 21726v1 Various improvements around the GuC topic https://patchwork.freedesktop.org/api/1.0/series/21726/revisions/1/mbox/ fi-bdw-5

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with drm: Make the decision to keep vblank irq enabled earlier (rev2)

2017-03-23 Thread Patchwork
== Series Details == Series: series starting with drm: Make the decision to keep vblank irq enabled earlier (rev2) URL : https://patchwork.freedesktop.org/series/21318/ State : success == Summary == Series 21318v2 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/21

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Wait for all fences before installing an exclusive clflush fence

2017-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Wait for all fences before installing an exclusive clflush fence URL : https://patchwork.freedesktop.org/series/21746/ State : success == Summary == Series 21746v1 drm/i915: Wait for all fences before installing an exclusive clflush fence https://patchw

Re: [Intel-gfx] [PATCH] drm/i915: Reduce Data Link N value for 1 lane DP->hdmi converters

2017-03-23 Thread Ville Syrjälä
On Wed, Mar 22, 2017 at 04:27:36PM -0700, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > Several major vendor USB-C->HDMI converters fail to recover a 5.4 GHz 1 lane > signal if the Data Link N is greater than 0x8. > Patch detects when 1 lane 5.4 GHz signal is being used and makes

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [CI,1/7] drm/i915: Eliminate per-fw_domain i915 backpointer

2017-03-23 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915: Eliminate per-fw_domain i915 backpointer URL : https://patchwork.freedesktop.org/series/21752/ State : warning == Summary == Series 21752v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/21752/r

Re: [Intel-gfx] [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence

2017-03-23 Thread Mika Kuoppala
Chris Wilson writes: > Ensure that before we overwrite the reservation_object with our > exclusive fence for the pending clflush operation, that we do wait upon > all the fences in the current reservation_object. > > Fixes: 57822dc6b9cf ("drm/i915: Perform object clflushing asynchronously") > Sig

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [CI,1/7] drm/i915: Eliminate per-fw_domain i915 backpointer

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 11:56:11AM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/7] drm/i915: Eliminate per-fw_domain i915 > backpointer > URL : https://patchwork.freedesktop.org/series/21752/ > State : warning > > == Summary == > > Series 21752v1 Serie

Re: [Intel-gfx] [PATCH] drm/i915: Wait for all fences before installing an exclusive clflush fence

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 01:55:33PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > Ensure that before we overwrite the reservation_object with our > > exclusive fence for the pending clflush operation, that we do wait upon > > all the fences in the current reservation_object. > > > > Fix

[Intel-gfx] [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

2017-03-23 Thread Colin King
From: Colin Ian King info is being checked to see if it is a null pointer, however, vpgu is dereferencing info before this check, leading to a potential null pointer dereference. If info is null, then the error message being printed by macro gvt_vgpu_err and this requires vpgu to exist. We can u

Re: [Intel-gfx] [PATCH i-g-t v3 1/7] lib/igt_kms: Add forcing TEST_ONLY for atomic commits

2017-03-23 Thread Mika Kahola
On Wed, 2017-03-08 at 15:59 +0100, Maarten Lankhorst wrote: > Op 01-02-17 om 14:18 schreef Mika Kahola: > > > > Add an option to force atomic commits to do commits with TEST_ONLY > > flag > > first before doing the actual commit. > > > > Signed-off-by: Mika Kahola > > --- > >  lib/igt_kms.c | 18

Re: [Intel-gfx] [PATCH] drm/i915: Reduce Data Link N value for 1 lane DP->hdmi converters

2017-03-23 Thread Jani Nikula
On Thu, 23 Mar 2017, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > Several major vendor USB-C->HDMI converters fail to recover a 5.4 GHz 1 lane > signal if the Data Link N is greater than 0x8. > Patch detects when 1 lane 5.4 GHz signal is being used and makes the maximum > value 2

Re: [Intel-gfx] [PATCH] drm/i915: Actually pass the reclaim gfp_t along to shmemfs!

2017-03-23 Thread Jani Nikula
On Thu, 23 Mar 2017, Chris Wilson wrote: > On Thu, Mar 23, 2017 at 09:29:47AM +0200, Joonas Lahtinen wrote: >> On ke, 2017-03-22 at 22:34 +, Chris Wilson wrote: >> > Words cannot describe the embarrassment at creating a new gfp_t relaim to >> > only prevent the oomkiller but allow direct|kswap

Re: [Intel-gfx] [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 12:22:30PM +, Colin King wrote: > From: Colin Ian King > > info is being checked to see if it is a null pointer, however, vpgu is > dereferencing info before this check, leading to a potential null > pointer dereference. If info is null, then the error message being >

[Intel-gfx] [PATCH i-g-t v4 0/7] Validate TEST_ONLY correctness against full atomic commit

2017-03-23 Thread Mika Kahola
This test case adds TEST_ONLY flag to the following test cases to test atomic commit correctness. - kms_plane_multiple - kms_atomic_transitions - kms_plane_scaling - kms_rotation_crc - kms_plane_lowres The test randomly selects one of the above test cases and tests atomic commit. If the tes

[Intel-gfx] [PATCH i-g-t v4 6/7] tests/kms_plane_lowres: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_plane_lowres.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_

[Intel-gfx] [PATCH i-g-t v4 5/7] tests/kms_rotation_crc: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_rotation_crc.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.

[Intel-gfx] [PATCH i-g-t v4 2/7] tests/kms_plane_multiple: Add TEST_ONLY flag Cc: maarten.lankho...@linux.intel.com

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit v3: Moved force_test_atomic flag set to 'test_plane_position()' Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 48

[Intel-gfx] [PATCH i-g-t v4 2/3] tests/kms_plane_multiple: Add TEST_ONLY flag Cc: maarten.lankho...@linux.intel.com

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit v3: Moved force_test_atomic flag set to 'test_plane_position()' Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 48

[Intel-gfx] [PATCH i-g-t v4 4/7] tests/kms_plane_scaling: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic scaling without actually committing the changes. v2: Create subtests with TEST_ONLY flag and one without v3: Rename subtest 'force-atomic-test' as 'with-atomic-test' Signed-off-by: Mika Kahola --- tests/kms_plane_scaling.c | 28 1 f

[Intel-gfx] [PATCH i-g-t v4 1/7] lib/igt_kms: Add forcing TEST_ONLY for atomic commits

2017-03-23 Thread Mika Kahola
Add an option to force atomic commits to do commits with TEST_ONLY flag first before doing the actual commit. v2: Clear force_test_atomic flag if atomic commit with TEST_ONLY flag fails (Maarten) Signed-off-by: Mika Kahola --- lib/igt_kms.c | 22 +- lib/igt_kms.h | 1 +

[Intel-gfx] [PATCH i-g-t v4 3/7] tests/kms_atomic_transition: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic transition display commits without actual real-life commit. v2: use flag to force atomic commit with TEST_ONLY flag v3: Rebase Signed-off-by: Mika Kahola --- tests/kms_atomic_transition.c | 72 +++ 1 file changed, 59 inse

[Intel-gfx] [PATCH i-g-t v4 7/7] tests/kms_cursor_legacy: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_cursor_legacy.c | 230 -- 1 file changed, 204 insertions(+), 26 deletions(-) diff --git a/tests/kms_cursor_legacy.c b/tests

Re: [Intel-gfx] [PATCH 06/19] drm/vmwgfx: Drop the cursor locking hack

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 11:32:49AM +0100, Thomas Hellstrom wrote: > On 03/23/2017 11:10 AM, Daniel Vetter wrote: > > On Thu, Mar 23, 2017 at 09:35:25AM +0100, Thomas Hellstrom wrote: > >> Hi, Daniel, > >> > >> On 03/23/2017 08:31 AM, Daniel Vetter wrote: > >>> On Thu, Mar 23, 2017 at 08:28:32AM +01

Re: [Intel-gfx] [PATCH] drm/scdc: declare drm_scdc_get_scrambling_status

2017-03-23 Thread Jani Nikula
On Wed, 22 Mar 2017, "Sharma, Shashank" wrote: > Thanks for this patch, Jani. > > Reviewed-by: Shashank Sharma And pushed to drm-misc-next, thanks for the review. BR, Jani. > > > Regards > Shashank > On 3/22/2017 4:33 PM, Jani Nikula wrote: >> Fix sparse warning: >> >> drivers/gpu/drm/drm_scd

[Intel-gfx] [PATCH i-g-t v4 2/7] tests/kms_plane_multiple: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit v3: Moved force_test_atomic flag set to 'test_plane_position()' v4: Fix typo in subject field Signed-off-by: Mika Kahola --- tests/

[Intel-gfx] [PATCH] drm/i915: Pass vma to relocate entry

2017-03-23 Thread Chris Wilson
We can simplify our tracking of pending writes in an execbuf to the single bit in the vma->exec_entry->flags, but that requires the relocation function knowing the object's vma. Pass it along. Note we have only been using a single bit to track flushing since commit cc889e0f6ce6a63c62db17d702ecfed

Re: [Intel-gfx] [PATCH 02/19] drm: Add acquire ctx parameter to ->update_plane

2017-03-23 Thread Russell King - ARM Linux
On Wed, Mar 22, 2017 at 10:50:41PM +0100, Daniel Vetter wrote: > diff --git a/drivers/gpu/drm/armada/armada_overlay.c > b/drivers/gpu/drm/armada/armada_overlay.c > index 34cb73d0db77..b54fd8cbd3a6 100644 > --- a/drivers/gpu/drm/armada/armada_overlay.c > +++ b/drivers/gpu/drm/armada/armada_overlay.

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

2017-03-23 Thread Patchwork
== Series Details == Series: drm/i915/kvmgt: avoid dereferencing a potentially null info pointer URL : https://patchwork.freedesktop.org/series/21762/ State : warning == Summary == Series 21762v1 drm/i915/kvmgt: avoid dereferencing a potentially null info pointer https://patchwork.freedesktop

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Various improvements around the GuC topic

2017-03-23 Thread Joonas Lahtinen
Merged this series except the HAX patch (also, reordered the S-o-b, R-b and Cc lines to canonical form), so do rebase your work. Regards, Joonas On to, 2017-03-23 at 11:06 +, Patchwork wrote: > == Series Details == > > Series: Various improvements around the GuC topic > URL   : https://patc

Re: [Intel-gfx] [PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-23 Thread Ville Syrjälä
On Thu, Mar 23, 2017 at 07:51:06AM +, Chris Wilson wrote: > We want to provide the vblank irq shadow for pageflip events as well as > vblank queries. Such events are completed within the vblank interrupt > handler, and so the current check for disabling the irq will disable it > from with the s

Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt notification for guc submission

2017-03-23 Thread Dong, Chuanxiao
> -Original Message- > From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] > Sent: Thursday, March 23, 2017 5:38 PM > To: Dong, Chuanxiao; intel-gfx@lists.freedesktop.org > Cc: intel-gvt-...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt

[Intel-gfx] [PATCH] drm/i915/execlists: Relax the locked clear_bit(IRQ_EXECLIST)

2017-03-23 Thread Chris Wilson
We only need to care about the ordering of the clearing of the bit with the uncached CSB read in order to correctly detect a new interrupt before the read completes. The uncached read itself acts as a full memory barrier, so we do not to enforce another in the form of a locked clear_bit. Signed-of

Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt notification for guc submission

2017-03-23 Thread Dong, Chuanxiao
> -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Chris Wilson > Sent: Thursday, March 23, 2017 5:43 PM > To: Joonas Lahtinen > Cc: intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org; > Dong, Chuanxiao > Subjec

Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt notification for guc submission

2017-03-23 Thread Dong, Chuanxiao
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Thursday, March 23, 2017 5:52 PM > To: Dong, Chuanxiao; intel-gfx@lists.freedesktop.org > Cc: intel-gvt-...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/scheduler: add gvt n

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/15] drm/i915: Copy user requested buffers into the error state (rev4)

2017-03-23 Thread Patchwork
== Series Details == Series: series starting with [01/15] drm/i915: Copy user requested buffers into the error state (rev4) URL : https://patchwork.freedesktop.org/series/21377/ State : failure == Summary == drivers/gpu/drm/i915/i915_gem_execbuffer.c:1891:1: error: expected expression before

Re: [Intel-gfx] [PATCH 00/14] drm/i915: Moar plane update optimizations

2017-03-23 Thread Ville Syrjälä
On Fri, Mar 17, 2017 at 11:17:54PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The plane updates are still taking far too long, at least with > heavy kernel debug knobs turned on. Using kms_atomic_transitions > I'm currently seeing numbers as high as 170 usec on my VLV.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/execlists: Relax the locked clear_bit(IRQ_EXECLIST)

2017-03-23 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Relax the locked clear_bit(IRQ_EXECLIST) URL : https://patchwork.freedesktop.org/series/21767/ State : failure == Summary == Series 21767v1 drm/i915/execlists: Relax the locked clear_bit(IRQ_EXECLIST) https://patchwork.freedesktop.org/api/1.0/se

Re: [Intel-gfx] [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

2017-03-23 Thread Joonas Lahtinen
Dropping the irrelevant Cc's. On to, 2017-03-23 at 12:39 +, Chris Wilson wrote: > On Thu, Mar 23, 2017 at 12:22:30PM +, Colin King wrote: > > > > From: Colin Ian King > > > > info is being checked to see if it is a null pointer, however, vpgu is > > dereferencing info before this check,

Re: [Intel-gfx] [PATCH v2] drm/i915: Store a direct lookup from object handle to vma

2017-03-23 Thread Daniel Vetter
On Wed, Mar 22, 2017 at 04:22:38PM +0200, Joonas Lahtinen wrote: > + Daniel for the rsvd2 I'd go with a shadow struct definition which matches the uapi one exactly, except for having a proper name and type for this ... Or we do the anynomous union thing again. -Daniel > > On ke, 2017-03-22 at 09

Re: [Intel-gfx] [PATCH v3 0/5] drm/i915: SKL+ render decompression support

2017-03-23 Thread Daniel Stone
Hi Ville, On 21 March 2017 at 18:12, wrote: > Another iteration of the i915 CCS support. Main change is lifting the > fb dimensions hsub/vsub alignment restrictions from the core. Without that > userspace would have to align the fb size be a multiple of 8x16 pixels > which isn't something they a

Re: [Intel-gfx] [dim PATCH 1/7] dim: don't fail on grep not matching

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 12:06:16PM +0200, Jani Nikula wrote: > Oops, the comment told us to watch out for this. > > Fixes: 56e53a49e28f ("dim: declare and assign separately") I just hacked around this with a || true :-) Ack. -Daniel > Signed-off-by: Jani Nikula > --- > dim | 5 + > 1 file

Re: [Intel-gfx] [dim PATCH 7/7] dim: propagate errors from check_maintainer

2017-03-23 Thread Daniel Vetter
On Thu, Mar 23, 2017 at 12:06:22PM +0200, Jani Nikula wrote: > Signed-off-by: Jani Nikula Ack on the entire pile. -Daniel > --- > dim | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dim b/dim > index 7b6275e7796f..989674ab7a91 100755 > --- a/dim > +++ b/dim >

Re: [Intel-gfx] [PATCH v2] drm/i915: Store a direct lookup from object handle to vma

2017-03-23 Thread Chris Wilson
On Thu, Mar 23, 2017 at 03:23:28PM +0100, Daniel Vetter wrote: > On Wed, Mar 22, 2017 at 04:22:38PM +0200, Joonas Lahtinen wrote: > > + Daniel for the rsvd2 > > I'd go with a shadow struct definition which matches the uapi one exactly, > except for having a proper name and type for this ... Or we

[Intel-gfx] [PATCH] drm/i915: Check we have an wake device before flushing GTT writes

2017-03-23 Thread Chris Wilson
We can assume that if the device is asleep then all pending GTT writes will have been posted, and so we can defer the flush from i915_gem_object_flush_gtt_write_domain() [ 1957.462568] WARNING: CPU: 0 PID: 6132 at drivers/gpu/drm/i915/intel_drv.h:1742 fwtable_read32+0x123/0x150 [i915] [ 1957.4625

[Intel-gfx] [PATCH v4 1/2] drm/edid: Complete CEA modedb(VIC 1-107)

2017-03-23 Thread Shashank Sharma
CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64 modes (VIC=1 to VIC=64). Now to be able to parse new CEA modes using the existing methods, we have to complete the modedb (VIC=65 onw

[Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Shashank Sharma
HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI infoframes should be 0. HDMI 2.0 sinks, support video modes range as per CEA-861-F spec, which is extended to (VIC 1-107). This patch adds a bool input variable, which indicates if

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Ilia Mirkin
On Thu, Mar 23, 2017 at 11:14 AM, Shashank Sharma wrote: > HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). > For any other mode, the VIC filed in AVI infoframes should be 0. > HDMI 2.0 sinks, support video modes range as per CEA-861-F spec, which is > extended to (VIC 1

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Sharma, Shashank
Regards Shashank On 3/23/2017 5:17 PM, Ilia Mirkin wrote: On Thu, Mar 23, 2017 at 11:14 AM, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI infoframes should be 0. HDMI 2.0 sinks, support video modes

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Ilia Mirkin
On Thu, Mar 23, 2017 at 11:22 AM, Sharma, Shashank wrote: > On 3/23/2017 5:17 PM, Ilia Mirkin wrote: >> >> On Thu, Mar 23, 2017 at 11:14 AM, Shashank Sharma >> wrote: >>> >>> HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC >>> 1-64). >>> For any other mode, the VIC filed in A

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Jose Abreu
Hi Shashank, On 23-03-2017 15:14, Shashank Sharma wrote: > HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). > For any other mode, the VIC filed in AVI infoframes should be 0. > HDMI 2.0 sinks, support video modes range as per CEA-861-F spec, which is > extended to (VIC

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Ville Syrjälä
On Thu, Mar 23, 2017 at 05:14:19PM +0200, Shashank Sharma wrote: > HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). > For any other mode, the VIC filed in AVI infoframes should be 0. > HDMI 2.0 sinks, support video modes range as per CEA-861-F spec, which is > extended to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Check we have an wake device before flushing GTT writes (rev2)

2017-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Check we have an wake device before flushing GTT writes (rev2) URL : https://patchwork.freedesktop.org/series/20899/ State : success == Summary == Series 20899v2 drm/i915: Check we have an wake device before flushing GTT writes https://patchwork.freedeskt

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Ville Syrjälä
On Thu, Mar 23, 2017 at 03:28:29PM +, Jose Abreu wrote: > Hi Shashank, > > > On 23-03-2017 15:14, Shashank Sharma wrote: > > HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). > > For any other mode, the VIC filed in AVI infoframes should be 0. > > HDMI 2.0 sinks, sup

[Intel-gfx] [PULL] drm-misc-fixes

2017-03-23 Thread Daniel Vetter
Hi Dave, drm-misc-fixes-2017-03-23: One fbdev regression fix from Michel Cheers, Daniel The following changes since commit 97da3854c526d3a6ee05c849c96e48d21527606c: Linux 4.11-rc3 (2017-03-19 19:09:39 -0700) are available in the git repository at: git://anongit.freedesktop.org/git/drm-mi

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Jose Abreu
Hi Ville, On 23-03-2017 15:36, Ville Syrjälä wrote: > On Thu, Mar 23, 2017 at 05:14:19PM +0200, Shashank Sharma wrote: >> HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). >> For any other mode, the VIC filed in AVI infoframes should be 0. >> HDMI 2.0 sinks, support vide

  1   2   >