Re: [Intel-gfx] [Nouveau] [PATCH 3/3] gpu: drm: drivers: Convert printk(KERN_ to pr_

2017-03-01 Thread Daniel Vetter
On Tue, Feb 28, 2017 at 04:55:54AM -0800, Joe Perches wrote: > Use a more common logging style. > > Miscellanea: > > o Coalesce formats and realign arguments > o Neaten a few macros now using pr_ > > Signed-off-by: Joe Perches Plenty acks, also merged for 4.12. Thanks, Daniel > --- > driver

Re: [Intel-gfx] [PATCH v4 1/5] drm/atomic: Fix atomic helpers to use the new iterator macros, v2.

2017-03-01 Thread Maarten Lankhorst
Op 01-03-17 om 01:49 schreef Laurent Pinchart: > Hi Maarten, > > Thank you for the patch. > > On Thursday 16 Feb 2017 15:47:06 Maarten Lankhorst wrote: >> There are new iterator macros that annotate whether the new or old >> state should be used. This is better than using a state that depends on >>

[Intel-gfx] [PATCH v4.1 1/5] drm/atomic: Fix atomic helpers to use the new iterator macros, v3.

2017-03-01 Thread Maarten Lankhorst
There are new iterator macros that annotate whether the new or old state should be used. This is better than using a state that depends on whether it's called before or after swap. For clarity, also rename the variables from $obj_state to (old,new)_$obj_state as well. Changes since v1: - Use old/n

[Intel-gfx] [PATCH v4.1 4/5] drm/atomic: Convert get_existing_state callers to get_old/new_state, v4.

2017-03-01 Thread Maarten Lankhorst
This is a straightforward conversion that converts all the users of get_existing_state in atomic core to use get_old_state or get_new_state Changes since v1: - Fix using the wrong state in drm_atomic_helper_update_legacy_modeset_state. Changes since v2: - Use the correct state in disable_outputs()

[Intel-gfx] [PATCH i-g-t v3] Add the new tool for create GVT-g Linux guest based on KVMGT

2017-03-01 Thread Terrence Xu
GVT-g (Intel® Graphics Virtualization Technology) is a full GPU virtualization solution with mediated pass-through support. This tool is for create basic Linux guest based on KVMGT with VFIO framework, it including create vgpu, create guest, check IP address, destroy guest, remove vgpu,check dmesg

Re: [Intel-gfx] [PATCH] drm/i915: Tighten mmio arrays for MIPI_PORT

2017-03-01 Thread Chris Wilson
On Tue, Feb 28, 2017 at 05:00:28PM +0200, Jani Nikula wrote: > On Tue, 28 Feb 2017, Chris Wilson wrote: > > drivers/gpu/drm/i915/intel_dsi.c: In function ‘intel_dsi_prepare’: > > drivers/gpu/drm/i915/intel_dsi.c:1308:1: error: the frame size of 2488 > > bytes is larger than 2048 bytes [-Werror=fr

[Intel-gfx] [PATCH 3/6] drm/i915: use drm_connector_list_iter in intel_opregion.c

2017-03-01 Thread Daniel Vetter
One case where I nuked a now unecessary locking, otherwise all just boring stuff. v2: Rebase onto the iter_get/put->iter_begin/end rename. Cc: Thierry Reding Cc: Maarten Lankhorst Cc: Jani Nikula Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_opregion.c | 15 --- 1 f

[Intel-gfx] [PATCH 5/6] drm/i915: use for_each_intel_connector_iter in intel_display.c

2017-03-01 Thread Daniel Vetter
This gets rid of the last users of for_each_intel_connector(), remove that too. At first I wasn't sure whether the 2 loops in the modeset state checker should instead only loop over the connectors in the atomic commit. But we never add connectors to an atomic update if they don't (or won't have) a

[Intel-gfx] [PATCH 6/6] drm/i915: Fix up verify_encoder_state

2017-03-01 Thread Daniel Vetter
The trouble here is that looking at all connector->state in the verifier isn't good, because that's run from the commit work, which doesn't hold the connection_mutex. Which means we're only allowed to look at states in our atomic update. The simple fix for future proofing would be to switch over t

[Intel-gfx] [PATCH 4/6] drm/i915: Make intel_get_pipe_from_connector atomic

2017-03-01 Thread Daniel Vetter
Drive-by fixup while looking at all the connector_list walkers - holding connection_mutex does actually _not_ give you locking to look at the legacy drm_connector->encoder->crtc pointer chain. That one is solely owned by the atomic commit workers. Instead we must inspect the atomic state. Signed-o

[Intel-gfx] [PATCH 2/6] drm/i915: use drm_connector_list_iter in intel_hotplug.c

2017-03-01 Thread Daniel Vetter
Nothing special, just rote conversion. v2: Rebase onto the iter_get/put->iter_begin/end rename. Cc: Thierry Reding Cc: Maarten Lankhorst Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_hotplug.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-)

[Intel-gfx] [PATCH 1/6] drm/i915: Use drm_connector_list_iter in debugfs

2017-03-01 Thread Daniel Vetter
While at it also try to reduce the locking a bit to what's really just needed instead of everything that we could possibly lock. Added a new for_each_intel_connector_iter which includes the cast to intel_connector. Otherwise just plain transformation with nothing special going on. v2: Review fro

Re: [Intel-gfx] [PATCH] #1: test capitalizing PATCH

2017-03-01 Thread Jani Nikula
On Wed, 01 Mar 2017, Hans de Goede wrote: > Hi, > > On 28-02-17 17:31, Jani Nikula wrote: >> >> Cc: Hans, this probably applies to you as well. > > I'm already always using git-send-email, so whatever the > reason why the CI system is not picking up my patches, this > aint it. It doesn't look lik

Re: [Intel-gfx] [PATCH v4.1 1/5] drm/atomic: Fix atomic helpers to use the new iterator macros, v3.

2017-03-01 Thread Laurent Pinchart
Hi Maarten, Thank you for the resend. For the whole series, Tested-by: Laurent Pinchart On Wednesday 01 Mar 2017 10:21:26 Maarten Lankhorst wrote: > There are new iterator macros that annotate whether the new or old > state should be used. This is better than using a state that depends on > wh

Re: [Intel-gfx] [PATCH] #1: test capitalizing PATCH

2017-03-01 Thread Hans de Goede
Hi, On 01-03-17 10:57, Jani Nikula wrote: On Wed, 01 Mar 2017, Hans de Goede wrote: Hi, On 28-02-17 17:31, Jani Nikula wrote: Cc: Hans, this probably applies to you as well. I'm already always using git-send-email, so whatever the reason why the CI system is not picking up my patches, thi

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector atomic property for link status

2017-03-01 Thread Daniel Vetter
On Fri, Dec 16, 2016 at 12:29:06PM +0200, Jani Nikula wrote: > /** > + * enum drm_link_status - connector's link_status property value > + * > + * This enum is used as the connector's link status property value. > + * It is set to the values defined in uapi. > + */ > +enum drm_link_status { > +

[Intel-gfx] [PULL] topic/designware-baytrail for 4.12

2017-03-01 Thread Daniel Vetter
Hi all, topic/designware-baytrail-2017-03-01: Baytrail PMIC vs. PMU race fixes from Hans de Goede I opted to put all the patches for all subsystems into the topic branches, so that if needed, each subsystem can apply refactorings to the entire thing. Which might be needed since we're very early i

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Add render decompression support

2017-03-01 Thread Ville Syrjälä
On Tue, Feb 28, 2017 at 03:20:38PM -0800, Ben Widawsky wrote: > On 17-02-28 12:18:39, Jason Ekstrand wrote: > >I've said it before but reading through Ben's patches again make me want to > >be peskier about it. I would really like the UABI to treat the CCS as if > >it's Y-tiled with a tile size o

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Use drm_connector_list_iter in debugfs

2017-03-01 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Use drm_connector_list_iter in debugfs URL : https://patchwork.freedesktop.org/series/20441/ State : failure == Summary == Series 20441v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/20441/revisi

[Intel-gfx] [i-g-t PATCH] intel-ci: Add initial generic testlist

2017-03-01 Thread Abdiel Janulgue
Similar to fast-feedback test list. The point of the generic test list is to gather pass-rate when running generic tests - i.e., tests that don't rely on specific GPUs. Again, this test list is dynamic and will either shrink or grow over time. Signed-off-by: Abdiel Janulgue Cc: Petri Latvala C

Re: [Intel-gfx] [GLK MIPI DSI V7] drm/i915/glk: Add MIPIIO Enable/disable sequence

2017-03-01 Thread Jani Nikula
On Wed, 01 Mar 2017, Madhav Chauhan wrote: > From: Deepak M > > v2: Addressed Jani's Review comments(renamed bit field macros) > v3: Jani's Review comment for aligning code to platforms and added > wrapper functions. > v4: Corrected enable/disable seuqence as per BSPEC > v5: Corrected waiting twi

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gen9: Increase PCODE request timeout to 100ms (rev2)

2017-03-01 Thread Imre Deak
On Fri, Feb 24, 2017 at 03:52:15PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gen9: Increase PCODE request timeout to 100ms (rev2) > URL : https://patchwork.freedesktop.org/series/19961/ > State : success > > == Summary == > > Series 19961v2 drm/i915/gen9: Increase PCO

[Intel-gfx] [igt PATCH] configure.ac: require libdrm >= 2.4.75 for I915_EXEC_FENCE_OUT

2017-03-01 Thread Jani Nikula
I915_EXEC_FENCE_OUT was added in libdrm commit a3d715ee14b2 ("Import uapi/i915_drm.h from v4.10-rc5-950-g152d5750dda9") and released in libdrm-2.4.75. Signed-off-by: Jani Nikula --- I'm probably doing something wrong. This passes configure for me, but build still fails with: gem_latency.c: In

Re: [Intel-gfx] [igt PATCH] configure.ac: require libdrm >= 2.4.75 for I915_EXEC_FENCE_OUT

2017-03-01 Thread Petri Latvala
On 03/01/2017 01:34 PM, Jani Nikula wrote: I915_EXEC_FENCE_OUT was added in libdrm commit a3d715ee14b2 ("Import uapi/i915_drm.h from v4.10-rc5-950-g152d5750dda9") and released in libdrm-2.4.75. Signed-off-by: Jani Nikula Reviewed-by: Petri Latvala --- I'm probably doing something wrong.

[Intel-gfx] [PATCH] drm/i915: Move w/a LRI debug message from context-init to driver load

2017-03-01 Thread Chris Wilson
The spam of every context initialisation saying the same thing is annoying me! Move the information to the setup of the engine. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_engine_cs.c | 38 +- 1 file changed, 19 insertions(+), 19

Re: [Intel-gfx] [PATCH v5] drm/i915/guc: Extract param logic form guc_init_fw()

2017-03-01 Thread Joonas Lahtinen
On ma, 2017-02-27 at 13:50 +0100, Arkadiusz Hiler wrote: > Let intel_guc_init_fw() focus on determining and fetching the correct > firmware. > > This patch introduces intel_uc_sanitize_options() that is called from > intel_sanitize_options(). > > Then, if we have GuC, we can call intel_guc_init_f

Re: [Intel-gfx] [PATCH 2/4 v2] drm/i915/guc: Add onion teardown to the GuC setup

2017-03-01 Thread Joonas Lahtinen
On pe, 2017-02-24 at 06:01 -0800, Oscar Mateo wrote: > Starting with intel_guc_loader, down to intel_guc_submission > and finally to intel_guc_log. > > v2: >   - Null execbuf client outside guc_client_free (Daniele) >   - Assert if things try to get allocated twice (Daniele/Joonas) >   - Null guc-

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Break out the GuC log "extras"

2017-03-01 Thread Joonas Lahtinen
On pe, 2017-02-24 at 06:01 -0800, Oscar Mateo wrote: > When initializing the GuC log struct, there is an object we need to > allocate always, since the GuC needs its address at fw load time. > The rest are "extras", in the sense that we only need them if we > actually enable GuC logging. Make that

Re: [Intel-gfx] [RFC 10/11] drm/i915/preempt: Emit MI_ARB_CHECK before the start of user batch

2017-03-01 Thread Chris Wilson
On Thu, Feb 23, 2017 at 08:14:20PM +0100, Michał Winiarski wrote: > We should probably do this conditionally, based on whether preemption is > actually enabled. > > Signed-off-by: Michał Winiarski > --- > drivers/gpu/drm/i915/intel_lrc.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-

Re: [Intel-gfx] [RFC 05/11] drm/i915/preempt: Handle preemption event in guc tasklet

2017-03-01 Thread Chris Wilson
On Thu, Feb 23, 2017 at 08:14:15PM +0100, Michał Winiarski wrote: > +static void unsubmit_inflight_requests(struct intel_engine_cs *engine, > + struct list_head *resubmit) > +{ > + struct drm_i915_gem_request *rq, *prev; > + > + assert_spin_locked(&engin

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add more OA configs for BDW, CHV, SKL + BXT

2017-03-01 Thread Matthew Auld
On 02/22, Robert Bragg wrote: > These are auto generated from an XML description of metric sets, > currently maintained in gputop, ref: > > https://github.com/rib/gputop > > gputop-data/oa-*.xml > > scripts/i915-perf-kernelgen.py > > $ make -C gputop-data -f Makefile.xml > > Signed-off-by: R

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix all intel_framebuffer_init failures to take the error path

2017-03-01 Thread Ville Syrjälä
On Tue, Feb 28, 2017 at 04:22:32PM +, Chris Wilson wrote: > No more direct return -EINVAL as we have to unwind the > obj->framebuffer_references. > > Fixes: 24dbf51a5517 ("drm/i915: struct_mutex is not required for allocating > the framebuffer") > Signed-off-by: Chris Wilson > Cc: Ville Syrj

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Prevent concurrent tiling/framebuffer modifications

2017-03-01 Thread Ville Syrjälä
On Tue, Feb 28, 2017 at 04:22:33PM +, Chris Wilson wrote: > Reintroduce a lock around tiling vs framebuffer creation to prevent > modification of the obj->tiling_and_stride whilst the framebuffer is > being created. Rather than use struct_mutex once again, use the > per-object lock - this will

[Intel-gfx] [PATCH RESEND FOR CI 01/10] drm/i915/dsi: Document the panel enable / disable sequences from the spec

2017-03-01 Thread Jani Nikula
From: Hans de Goede Document the DSI panel enable / disable sequences from the spec, for easy comparison between the code and the spec. Signed-off-by: Hans de Goede Acked-by: Jani Nikula Reviewed-by: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 37 +++

[Intel-gfx] drm/i915/dsi: the rest of Hans' DSI patches

2017-03-01 Thread Jani Nikula
Resending again to get CI... BR, Jani. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH RESEND FOR CI 05/10] drm/i915/dsi: Execute MIPI_SEQ_DEASSERT_RESET before calling device_ready()

2017-03-01 Thread Jani Nikula
From: Hans de Goede Execute MIPI_SEQ_DEASSERT_RESET before putting the device in ready state (LP-11), this is the sequence in which things should be done according to the spec. Signed-off-by: Hans de Goede Reviewed-by: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.

[Intel-gfx] [PATCH RESEND FOR CI 06/10] drm/i915/dsi: Group MIPI_SEQ_BACKLIGHT_ON/OFF with panel_[en|dis]able_backlight

2017-03-01 Thread Jani Nikula
From: Hans de Goede Execute the MIPI_SEQ_BACKLIGHT_ON/OFF VBT sequences at the same time as we call intel_panel_enable_backlight() / intel_panel_disable_backlight(). Signed-off-by: Hans de Goede Reviewed-by: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 4 ++--

[Intel-gfx] [PATCH RESEND FOR CI 08/10] drm/i915/dsi: Execute MIPI_SEQ_TEAR_OFF from intel_dsi_post_disable

2017-03-01 Thread Jani Nikula
From: Hans de Goede For v3+ VBTs we should call MIPI_SEQ_TEAR_OFF before MIPI_SEQ_DISPLAY_OFF, v2 VBTs do not have MIPI_SEQ_TEAR_OFF so there this is a nop. Signed-off-by: Hans de Goede Reviewed-by: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 2 ++ 1 file cha

[Intel-gfx] [PATCH RESEND FOR CI 03/10] drm/i915/dsi: Move MIPI_SEQ_POWER_ON/OFF calls together with pmic gpio calls

2017-03-01 Thread Jani Nikula
From: Hans de Goede Now that we are no longer bound to the drm_panel_ callbacks, call MIPI_SEQ_POWER_ON/OFF at the proper place. Signed-off-by: Hans de Goede Reviewed-by: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 10 -- 1 file changed, 4 insertions(

[Intel-gfx] [PATCH RESEND FOR CI 02/10] drm/i915/dsi: Drop bogus MIPI_SEQ_ASSERT_RESET before POWER_ON

2017-03-01 Thread Jani Nikula
From: Hans de Goede intel_dsi_post_disable(), which does the MIPI_SEQ_ASSERT_RESET, will always be called at some point before intel_dsi_pre_enable() making the MIPI_SEQ_ASSERT_RESET in intel_dsi_pre_enable() redundant. In addition, calling MIPI_SEQ_ASSERT_RESET in the enable path goes against t

[Intel-gfx] [PATCH RESEND FOR CI 04/10] drm/i915/dsi: Group DPOunit clock gate workaround with PLL enable

2017-03-01 Thread Jani Nikula
From: Hans de Goede Move the DPOunit clock gate workaround to directly after the PLL enable. The exact location of the workaround does not matter and there are 2 reasons to group it with the PLL enable: 1) This moves it out of the middle of the init sequence from the spec, making it easier t

[Intel-gfx] [PATCH RESEND FOR CI 09/10] drm/i915/dsi: Call MIPI_SEQ_TEAR_ON and DISPLAY_ON for cmd-mode (untested)

2017-03-01 Thread Jani Nikula
From: Hans de Goede According to the spec we should call MIPI_SEQ_TEAR_ON and DISPLAY_ON on enable for cmd-mode, just like we already call their counterparts on disable. Note: untested, my panel is a vid-mode panel. Signed-off-by: Hans de Goede Reviewed-by: Bob Paauwe Signed-off-by: Jani Nikul

[Intel-gfx] [PATCH RESEND FOR CI 07/10] drm/i915/dsi: Document always using v3 SHUTDOWN / MIPI_SEQ_DISPLAY_OFF order

2017-03-01 Thread Jani Nikula
From: Hans de Goede According to the spec for v2 VBTs we should call MIPI_SEQ_DISPLAY_OFF before sending SHUTDOWN, where as for v3 VBTs we should send SHUTDOWN first. Since the v2 order has known issues, we use the v3 order everywhere, add a comment documenting this. Signed-off-by: Hans de Goed

[Intel-gfx] [PATCH RESEND FOR CI 10/10] drm/i915/dsi: Skip delays for v3 VBTs in vid-mode

2017-03-01 Thread Jani Nikula
From: Hans de Goede For v3 VBTs in vid-mode the delays are part of the VBT sequences, so we should not also delay ourselves otherwise we get double delays. Signed-off-by: Hans de Goede Reviewed-by: Bob Paauwe Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 19 ++

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Move w/a LRI debug message from context-init to driver load

2017-03-01 Thread Patchwork
== Series Details == Series: drm/i915: Move w/a LRI debug message from context-init to driver load URL : https://patchwork.freedesktop.org/series/20452/ State : warning == Summary == Series 20452v1 drm/i915: Move w/a LRI debug message from context-init to driver load https://patchwork.freedes

Re: [Intel-gfx] kbl_guc and bxt_guc firmware missing from linux-firmware

2017-03-01 Thread Jani Nikula
On Wed, 15 Feb 2017, Seth Forshee wrote: > Maybe it would be good to have something like MODULE_OPTIONAL_FIRMWARE > to identify firmware that isn't required but will be used by the driver > if available. Then mkinitramfs can try to copy those files along with > the module but know that there's no

Re: [Intel-gfx] [PATCH] drm/i915: use BUILD_BUG_ON to ensure platform name has been set up

2017-03-01 Thread Jani Nikula
On Tue, 28 Feb 2017, Chris Wilson wrote: > On Tue, Feb 28, 2017 at 01:11:43PM +0200, Jani Nikula wrote: >> Leave the runtime check in place in case the platform variable itself >> comes from bogus sources. >> >> Signed-off-by: Jani Nikula > > Neat. > Reviewed-by: Chris Wilson Pushed, thanks fo

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [RESEND,FOR,CI,01/10] drm/i915/dsi: Document the panel enable / disable sequences from the spec

2017-03-01 Thread Patchwork
== Series Details == Series: series starting with [RESEND,FOR,CI,01/10] drm/i915/dsi: Document the panel enable / disable sequences from the spec URL : https://patchwork.freedesktop.org/series/20456/ State : failure == Summary == Series 20456v1 Series without cover letter https://patchwork.fr

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [RESEND,FOR,CI,01/10] drm/i915/dsi: Document the panel enable / disable sequences from the spec

2017-03-01 Thread Jani Nikula
On Wed, 01 Mar 2017, Patchwork wrote: > == Series Details == > > Series: series starting with [RESEND,FOR,CI,01/10] drm/i915/dsi: Document the > panel enable / disable sequences from the spec > URL : https://patchwork.freedesktop.org/series/20456/ > State : failure > > == Summary == > > Series

Re: [Intel-gfx] [PATCH] drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

2017-03-01 Thread Ville Syrjälä
On Mon, Feb 20, 2017 at 04:25:45PM +0100, Tomeu Vizoso wrote: > Rotel RSX-1058 is a receiver with 4 HDMI inputs and a HDMI output, all > 1.1. > > When a sink that supports deep color is connected to the output, the > receiver will send EDIDs that advertise this capability, even if it > isn't possi

[Intel-gfx] [PATCH v2 4/8] drm/i915: Pass pipe_config to pch_enable() functions

2017-03-01 Thread Ander Conselvan de Oliveira
Using crtc->config directly is being removed in favor of passing a pipe_config. Follow the trend and pass pipe_config to pch_enable() functions. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 18 ++ 1 file changed, 10 insertions(+), 8 delet

[Intel-gfx] [PATCH v2 3/8] drm/i915: Pass intel_crtc to intel_lpt_pch_enable()

2017-03-01 Thread Ander Conselvan de Oliveira
The function intel_lpt_pch_enable() needs an intel_crtc so pass that instead of the generic crtc type. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 2/8] drm/i915: Pass intel_crtc to fdi_link_train() hooks

2017-03-01 Thread Ander Conselvan de Oliveira
The implementation of the fdi_link_train() hooks need an intel_crtc so just pass that instead of the generic crtc type. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_ddi.c | 13 drivers/gpu/drm/i915/intel_dis

[Intel-gfx] [PATCH v2 0/8] Try to fix MST regression with DDI IO power domains

2017-03-01 Thread Ander Conselvan de Oliveira
Hi, Here's a v2 of the fix for the regression caused by the recent DDI IO power domain changes. This time with moar patches and actual testing. The new patches remove the usage of crtc->config from intel_ddi.c and that also removes the oops with encoder->crtc being NULL. Ander Conselvan de Olivei

[Intel-gfx] [PATCH v2 6/8] drm/i915: Pass intel_crtc to DDI functions called from crtc en/disable

2017-03-01 Thread Ander Conselvan de Oliveira
Pass intel_crtc to functions intel_ddi_enable_transcoder_func(), intel_ddi_set_pipe_settings() and intel_ddi_set_vc_payload_alloc(), instead of the generic crtc type. By changing the functions intel_ddi_get_crtc_encoder() so that it receives an intel_crtc parameter, there is no need for the drm_crt

[Intel-gfx] [PATCH v2 7/8] drm/i915: Remove direct usages of intel_crtc->config from DDI code

2017-03-01 Thread Ander Conselvan de Oliveira
Remove direct usages of intel_crtc->config from the DDI code. Functions that didn't yet take a pipe_config as an argument were coverted to do so. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_ddi.c | 61 +++- drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v2 5/8] drm/i915: Pass pipe_config to fdi_link_train() functions

2017-03-01 Thread Ander Conselvan de Oliveira
It is preferred to pass pipe_config to functions instead of accessing crtc->config directly. Follow suit and pass pipe_config to the fdi link train functions. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/intel_ddi.c | 9

Re: [Intel-gfx] [PATCH i-g-t 3/8] lib: Define a common bit operations library

2017-03-01 Thread Michel Thierry
On 2/27/2017 1:35 AM, Daniel Vetter wrote: On Thu, Feb 09, 2017 at 09:34:49AM +0200, Joonas Lahtinen wrote: On ke, 2017-02-08 at 18:18 -0800, Michel Thierry wrote: Bring the test/set/clear bit functions we have into a single place. Signed-off-by: Michel Thierry Reviewed-by: Joonas Lahtine

Re: [Intel-gfx] kbl_guc and bxt_guc firmware missing from linux-firmware

2017-03-01 Thread Seth Forshee
On Wed, Mar 01, 2017 at 03:23:06PM +0200, Jani Nikula wrote: > On Wed, 15 Feb 2017, Seth Forshee wrote: > > Maybe it would be good to have something like MODULE_OPTIONAL_FIRMWARE > > to identify firmware that isn't required but will be used by the driver > > if available. Then mkinitramfs can try

[Intel-gfx] [PATCH v2 8/8] drm/i915: Remove duplicate DDI enabling logic from MST path

2017-03-01 Thread Ander Conselvan de Oliveira
The logic to enable a DDI in intel_mst_pre_enable_dp() is essentially the same as in intel_ddi_pre_enable_dp(). So reuse the latter function by calling the post_disable hook on the intel_dig_port instead of duplicating that code. v2: Don't oops because of a NULL encoder->crtc. (Ville) Cc: Imre Dea

Re: [Intel-gfx] [GLK MIPI DSI V7] drm/i915/glk: Add MIPIIO Enable/disable sequence

2017-03-01 Thread Jani Nikula
On Wed, 01 Mar 2017, Madhav Chauhan wrote: > From: Deepak M > > v2: Addressed Jani's Review comments(renamed bit field macros) > v3: Jani's Review comment for aligning code to platforms and added > wrapper functions. > v4: Corrected enable/disable seuqence as per BSPEC > v5: Corrected waiting twi

[Intel-gfx] [PATCH v2 1/8] drm/i915: Enable DDI IO power domains in the DP MST path

2017-03-01 Thread Ander Conselvan de Oliveira
Commit 62b695662a24 ("drm/i915: Only enable DDI IO power domains after enabling DPLL") changed how the DDI IO power domains get enabled, but neglected the need to enable those domains when enabling a DP connector with MST enabled, leading to Kernel panic - not syncing: Timeout: Not all CPUs en

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915: Pass pipe_config to pch_enable() functions

2017-03-01 Thread Ville Syrjälä
On Wed, Mar 01, 2017 at 04:13:14PM +0200, Ander Conselvan de Oliveira wrote: > Using crtc->config directly is being removed in favor of passing a > pipe_config. Follow the trend and pass pipe_config to pch_enable() > functions. > > Signed-off-by: Ander Conselvan de Oliveira > > --- > drivers/gp

[Intel-gfx] [PATCH] drm: Fix the kernel doc warning for drm_link_status

2017-03-01 Thread Manasi Navare
This fixes the kernel doc warning that was introduced in the 'commit 40ee6fbef75fe6 ("drm: Add a new connector atomic property for link status")'. Description has been added for the enum values. Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org -

Re: [Intel-gfx] [PATCH v5 4/6] drm/edid: detect SCDC support in HF-VSDB

2017-03-01 Thread Ville Syrjälä
On Tue, Feb 28, 2017 at 02:09:08PM +0530, Shashank Sharma wrote: > This patch does following: > - Adds a new structure (drm_hdmi_info) in drm_display_info. > This structure will be used to save and indicate if sink > supports advanced HDMI 2.0 features > - Adds another structure drm_scdc within

Re: [Intel-gfx] [PATCH] drm: Fix the kernel doc warning for drm_link_status

2017-03-01 Thread Daniel Vetter
On Wed, Mar 01, 2017 at 06:45:10AM -0800, Manasi Navare wrote: > This fixes the kernel doc warning that was introduced in > the 'commit 40ee6fbef75fe6 ("drm: Add a new connector > atomic property for link status")'. Description has > been added for the enum values. > > Signed-off-by: Manasi Navare

Re: [Intel-gfx] [PATCH v5 5/6] drm/i915: enable scrambling

2017-03-01 Thread Ville Syrjälä
On Tue, Feb 28, 2017 at 02:09:09PM +0530, Shashank Sharma wrote: > Geminilake platform sports a native HDMI 2.0 controller, and is > capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec > mendates scrambling for these higher clocks, for reduced RF footprint. > > This patch checks if the moni

Re: [Intel-gfx] [PATCH 18/18] drm/i915: Add FIFO underrun tracepoints

2017-03-01 Thread Maarten Lankhorst
Op 16-02-17 om 19:07 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > Add tracepoints for display FIFO underruns. Makes it more convenient to > correlate the underruns with other display tracepoints. I'm still not sold on how crtc_state->visible_planes deviates from crtc_state->pl

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move updating color management to before vblank evasion

2017-03-01 Thread Ville Syrjälä
On Tue, Feb 28, 2017 at 05:01:25PM +0200, Ville Syrjälä wrote: > On Tue, Feb 28, 2017 at 03:28:47PM +0100, Maarten Lankhorst wrote: > > This cannot be done reliably during vblank evasasion > > since the color management registers are not double buffered. > > > > The original commit that moved it a

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Complain if we take too long under vblank evasion.

2017-03-01 Thread Ville Syrjälä
On Tue, Feb 28, 2017 at 03:28:48PM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_sprite.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_sprite.c > b/drivers/gpu/drm/i915/i

[Intel-gfx] [CI 2/2] drm/i915: Prevent concurrent tiling/framebuffer modifications

2017-03-01 Thread Chris Wilson
Reintroduce a lock around tiling vs framebuffer creation to prevent modification of the obj->tiling_and_stride whilst the framebuffer is being created. Rather than use struct_mutex once again, use the per-object lock - this will also be required in future to prevent changing the tiling whilst submi

[Intel-gfx] [CI 1/2] drm/i915: Fix all intel_framebuffer_init failures to take the error path

2017-03-01 Thread Chris Wilson
No more direct return -EINVAL as we have to unwind the obj->framebuffer_references. Fixes: 24dbf51a5517 ("drm/i915: struct_mutex is not required for allocating the framebuffer") Signed-off-by: Chris Wilson Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c |

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Implement Link Rate fallback on Link training failure

2017-03-01 Thread Daniel Vetter
On Fri, Dec 16, 2016 at 12:29:07PM +0200, Jani Nikula wrote: > From: Manasi Navare > > If link training at a link rate optimal for a particular > mode fails during modeset's atomic commit phase, then we > let the modeset complete and then retry. We save the link rate > value at which link trainin

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Prevent concurrent tiling/framebuffer modifications

2017-03-01 Thread Chris Wilson
On Wed, Mar 01, 2017 at 03:09:36PM +0200, Ville Syrjälä wrote: > On Tue, Feb 28, 2017 at 04:22:33PM +, Chris Wilson wrote: > > Reintroduce a lock around tiling vs framebuffer creation to prevent > > modification of the obj->tiling_and_stride whilst the framebuffer is > > being created. Rather t

[Intel-gfx] ✓ Fi.CI.BAT: success for Try to fix MST regression with DDI IO power domains (rev2)

2017-03-01 Thread Patchwork
== Series Details == Series: Try to fix MST regression with DDI IO power domains (rev2) URL : https://patchwork.freedesktop.org/series/20345/ State : success == Summary == Series 20345v2 Try to fix MST regression with DDI IO power domains https://patchwork.freedesktop.org/api/1.0/series/20345/

[Intel-gfx] [PATCH i-g-t v2] lib: Define a common bit operations library

2017-03-01 Thread Michel Thierry
Bring the test/set/clear bit functions we have into a single place. v2: Add gtk-doc comment blocks (Daniel) Cc: Daniel Vetter Reviewed-by: Joonas Lahtinen (v1) Signed-off-by: Michel Thierry --- .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib/Makefile.sources

Re: [Intel-gfx] [PATCH] drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

2017-03-01 Thread Ville Syrjälä
On Wed, Mar 01, 2017 at 04:07:02PM +0200, Ville Syrjälä wrote: > On Mon, Feb 20, 2017 at 04:25:45PM +0100, Tomeu Vizoso wrote: > > Rotel RSX-1058 is a receiver with 4 HDMI inputs and a HDMI output, all > > 1.1. > > > > When a sink that supports deep color is connected to the output, the > > receiv

Re: [Intel-gfx] [PATCH i-g-t v2] lib: Define a common bit operations library

2017-03-01 Thread Chris Wilson
On Wed, Mar 01, 2017 at 07:52:26AM -0800, Michel Thierry wrote: > Bring the test/set/clear bit functions we have into a single place. > > v2: Add gtk-doc comment blocks (Daniel) Hiss, boo! Will someone take gtk-doc and bury it? -flto to save the day? -Chris -- Chris Wilson, Intel Open Source Te

[Intel-gfx] [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"

2017-03-01 Thread Daniel Vetter
This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c. I assumed it's ok, but really should have double-checked - CI caught tons of fail :( Cc: Jani Nikula Cc: Manasi Navare Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_dp.c | 27 ---

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"

2017-03-01 Thread Chris Wilson
On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote: > This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c. > > I assumed it's ok, but really should have double-checked - CI caught > tons of fail :( For the record, the failure comes from the error message in intel_dp_get_link_t

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"

2017-03-01 Thread Jani Nikula
On Wed, 01 Mar 2017, Chris Wilson wrote: > On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote: >> This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c. >> >> I assumed it's ok, but really should have double-checked - CI caught >> tons of fail :( Considering the velocity of drm

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"

2017-03-01 Thread Jani Nikula
On Wed, 01 Mar 2017, Jani Nikula wrote: > On Wed, 01 Mar 2017, Chris Wilson wrote: >> On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote: >>> This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c. >>> >>> I assumed it's ok, but really should have double-checked - CI caught >>>

[Intel-gfx] [PATCH v2] drm/i915: Use BUILD_BUG_ON to detected missing engine definitions

2017-03-01 Thread Michal Wajdeczko
Engine related definitions are located in different files and it is easy to break their cross dependency. Additionally use GEM_WARN_ON to catch invalid engine index. v2: compare against array size Signed-off-by: Michal Wajdeczko Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Tvrtko

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Fix all intel_framebuffer_init failures to take the error path

2017-03-01 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Fix all intel_framebuffer_init failures to take the error path URL : https://patchwork.freedesktop.org/series/20464/ State : success == Summary == Series 20464v1 Series without cover letter https://patchwork.freedesktop.org/

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Add render decompression support

2017-03-01 Thread Ben Widawsky
On 17-03-01 12:51:17, Ville Syrjälä wrote: On Tue, Feb 28, 2017 at 03:20:38PM -0800, Ben Widawsky wrote: On 17-02-28 12:18:39, Jason Ekstrand wrote: >I've said it before but reading through Ben's patches again make me want to >be peskier about it. I would really like the UABI to treat the CC

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"

2017-03-01 Thread Ville Syrjälä
On Wed, Mar 01, 2017 at 07:35:15PM +0200, Jani Nikula wrote: > On Wed, 01 Mar 2017, Chris Wilson wrote: > > On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote: > >> This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c. > >> > >> I assumed it's ok, but really should have double-

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Add render decompression support

2017-03-01 Thread Ville Syrjälä
On Wed, Mar 01, 2017 at 09:50:56AM -0800, Ben Widawsky wrote: > On 17-03-01 12:51:17, Ville Syrjälä wrote: > >On Tue, Feb 28, 2017 at 03:20:38PM -0800, Ben Widawsky wrote: > >> On 17-02-28 12:18:39, Jason Ekstrand wrote: > > > >> >I've said it before but reading through Ben's patches again make me

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"

2017-03-01 Thread Jani Nikula
On Wed, 01 Mar 2017, Ville Syrjälä wrote: > On Wed, Mar 01, 2017 at 07:35:15PM +0200, Jani Nikula wrote: >> On Wed, 01 Mar 2017, Chris Wilson wrote: >> > On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote: >> >> This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c. >> >> >> >>

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"

2017-03-01 Thread Ville Syrjälä
On Wed, Mar 01, 2017 at 08:18:18PM +0200, Jani Nikula wrote: > On Wed, 01 Mar 2017, Ville Syrjälä wrote: > > On Wed, Mar 01, 2017 at 07:35:15PM +0200, Jani Nikula wrote: > >> On Wed, 01 Mar 2017, Chris Wilson wrote: > >> > On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote: > >> >> Thi

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Make intel_guc_send a function pointer

2017-03-01 Thread Michal Wajdeczko
On Tue, Feb 07, 2017 at 01:20:35AM -0800, Oscar Mateo wrote: > From: Michal Wajdeczko > > Prepare for an alternate GuC communication interface. > > v2: Make a few functions static and name them correctly while we are at it > (Oscar) > v3: Leave an intel_guc_send_mmio interface for users that re

[Intel-gfx] [PATCH] drm/i915/glk: Fix DSI enable I/O sequence

2017-03-01 Thread Madhav Chauhan
One of the if statement covers the next line in enable I/O sequence. This patch correct the same by adding error message. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/intel_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [GLK MIPI DSI V7] drm/i915/glk: Add MIPIIO Enable/disable sequence

2017-03-01 Thread Chauhan, Madhav
> -Original Message- > From: Nikula, Jani > Sent: Wednesday, March 1, 2017 7:44 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Conselvan De Oliveira, Ander ; > Shankar, Uma ; Mukherjee, Indranil > ; Saarinen, Jani ; > Kamath, Sunil ; Deepak M > ; Chauhan, Madhav > Sub

[Intel-gfx] [PATCH] drm/i915: Fix use after free in lpe_audio_platdev_destroy()

2017-03-01 Thread Chris Wilson
[31908.547136] BUG: KASAN: use-after-free in intel_lpe_audio_teardown+0x78/0xb0 [i915] at addr 8801f7788358 [31908.547297] Read of size 8 by task drv_selftest/3781 [31908.547405] CPU: 0 PID: 3781 Comm: drv_selftest Tainted: GBU W 4.10.0+ #451 [31908.547553] Hardware name:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use BUILD_BUG_ON to detected missing engine definitions (rev2)

2017-03-01 Thread Patchwork
== Series Details == Series: drm/i915: Use BUILD_BUG_ON to detected missing engine definitions (rev2) URL : https://patchwork.freedesktop.org/series/20394/ State : success == Summary == Series 20394v2 drm/i915: Use BUILD_BUG_ON to detected missing engine definitions https://patchwork.freedeskt

Re: [Intel-gfx] [PATCH] drm/i915: Move w/a LRI debug message from context-init to driver load

2017-03-01 Thread Tvrtko Ursulin
On 01/03/2017 12:11, Chris Wilson wrote: The spam of every context initialisation saying the same thing is annoying me! Move the information to the setup of the engine. Yes I've noticed this ugly side effect of code consolidation. :) Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- driv

Re: [Intel-gfx] [PATCH v2] drm/i915: Use BUILD_BUG_ON to detected missing engine definitions

2017-03-01 Thread Tvrtko Ursulin
On 01/03/2017 17:39, Michal Wajdeczko wrote: Engine related definitions are located in different files and it is easy to break their cross dependency. Additionally use GEM_WARN_ON to catch invalid engine index. v2: compare against array size Signed-off-by: Michal Wajdeczko Cc: Jani Nikula C

Re: [Intel-gfx] [PATCH] drm/i915: Don't use enums for hardware engine id

2017-03-01 Thread Michal Wajdeczko
On Tue, Feb 28, 2017 at 09:53:37PM +, Chris Wilson wrote: > On Tue, Feb 28, 2017 at 07:07:38PM +0100, Michal Wajdeczko wrote: > > On Tue, Feb 28, 2017 at 04:52:34PM +, Chris Wilson wrote: > > > On Tue, Feb 28, 2017 at 04:43:02PM +, Chris Wilson wrote: > > > > On Tue, Feb 28, 2017 at 02:

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/glk: Fix DSI enable I/O sequence

2017-03-01 Thread Patchwork
== Series Details == Series: drm/i915/glk: Fix DSI enable I/O sequence URL : https://patchwork.freedesktop.org/series/20474/ State : warning == Summary == Series 20474v1 drm/i915/glk: Fix DSI enable I/O sequence https://patchwork.freedesktop.org/api/1.0/series/20474/revisions/1/mbox/ Test gem

[Intel-gfx] [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC

2017-03-01 Thread Anusha Srivatsa
Return silently without producing much noise on platforms that have a HuC but the firmware is absent. Cc: Ander Conselvan De Oliveira Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_huc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/d

Re: [Intel-gfx] [PATCH v2] drm/i915: Use BUILD_BUG_ON to detected missing engine definitions

2017-03-01 Thread Michal Wajdeczko
On Wed, Mar 01, 2017 at 07:29:15PM +, Tvrtko Ursulin wrote: > > On 01/03/2017 17:39, Michal Wajdeczko wrote: > > Engine related definitions are located in different files > > and it is easy to break their cross dependency. > > > > Additionally use GEM_WARN_ON to catch invalid engine index. >

  1   2   >