Re: [Intel-gfx] [PATCH RFC] drm/i915: reduce cursor size for GEN5 hardware

2017-02-07 Thread Ville Syrjälä
On Tue, Feb 07, 2017 at 06:51:25PM +0100, Maarten Lankhorst wrote: > Op 07-02-17 om 16:35 schreef Ville Syrjälä: > > On Tue, Feb 07, 2017 at 05:03:09PM +0200, Martin Peres wrote: > >> On 07/02/17 15:22, Uwe Kleine-König wrote: > >>> Hello, > >>> > >>> On 02/01/2017 03:37 PM, Ville Syrjälä wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Get correct display clock on 945gm

2017-02-07 Thread Ville Syrjälä
On Wed, Feb 01, 2017 at 12:50:26AM +0100, Arthur Heymans wrote: > This is according to Mobile Intel® 945 Express Chipset > Family datasheet. > > Signed-off-by: Arthur Heymans Reviewed-by: Ville Syrjälä and pushed to dinq. Thanks for the patch. > --- > drivers/gpu/drm/i915/i915_reg.h |

[Intel-gfx] [PATCH i-g-t] igt/core: Return condition result from igt_warn_on*()

2017-02-07 Thread Lyude
This allows us to be a little more flexible with how we use igt_warn_on() and igt_warn_on_f() by allowing us to write statements like this: if (igt_warn_on(scary_condition)) { /* some error handling... */ } Signed-off-by: Lyude --- lib/igt_core.h | 25 +++

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Make intel_guc_send a function pointer (rev2)

2017-02-07 Thread Patchwork
== Series Details == Series: drm/i915/guc: Make intel_guc_send a function pointer (rev2) URL : https://patchwork.freedesktop.org/series/19024/ State : failure == Summary == Series 19024v2 drm/i915/guc: Make intel_guc_send a function pointer https://patchwork.freedesktop.org/api/1.0/series/1902

[Intel-gfx] [PATCH v3 03/14] drm/i915: s/get_display_clock_speed/get_cdclk/

2017-02-07 Thread ville . syrjala
From: Ville Syrjälä Rename the .get_display_clock_speed() hook to .get_cdclk(). .get_cdclk() is more specific (which clock) and it's much shorter. v2: Deal with IS_GEN9_BC() v3: Deal with i945gm_get_display_clock_speed() Signed-off-by: Ville Syrjälä Reviewed-by: Ander Conselvan de Oliveira Li

[Intel-gfx] [PATCH v2 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder

2017-02-07 Thread ville . syrjala
From: Ville Syrjälä Let's clean up the mess we have in the if ladder that assigns the .get_cdclk() hooks. The grouping of the platforms by the function results in a thing that's not really legible, so let's do it the other way around and order the if ladder by platform and duplicate whatever assi

[Intel-gfx] [PATCH v4 05/14] drm/i915: Move most cdclk/rawclk related code to intel_cdclk.c

2017-02-07 Thread ville . syrjala
From: Ville Syrjälä Let's try to shrink intel_display.c a bit by moving the cdclk/rawclk stuff to a new file. It's all reasonably self contained so we don't even have to add that many non-static symbols. We'll also take the opportunity to shuffle around the functions a bit to get things in a mor

[Intel-gfx] [PATCH v4 07/14] drm/i915: Start moving the cdclk stuff into a distinct state structure

2017-02-07 Thread ville . syrjala
From: Ville Syrjälä Introduce intel_cdclk state which for now will track the cdclk frequency, the vco frequency and the reference frequency (not sure we want the last one, but I put it there anyway). We'll also make the .get_cdclk() function fill out this state structure rather than just returnin

Re: [Intel-gfx] [PATCH v1½ 03/13] drm/i915/dp: rename rate_to_index() to intel_dp_find_rate() and reuse

2017-02-07 Thread Pandiyan, Dhinakaran
On Thu, 2017-02-02 at 10:44 +0200, Jani Nikula wrote: > On Wed, 01 Feb 2017, "Pandiyan, Dhinakaran" > wrote: > > On Thu, 2017-01-26 at 21:44 +0200, Jani Nikula wrote: > >> Rename the function, move it at the top, and reuse in > >> intel_dp_link_rate_index(). If there was a reason in the past to u

[Intel-gfx] [PATCH] drm/i915: Always convert incoming exec offsets to non-canonical

2017-02-07 Thread Michał Winiarski
We're using non-canonical addresses in drm_mm, and we're making sure that userspace is using canonical addressing - both in case of softpin (verifying incoming offset) and when relocating (converting to canonical when updating offset returned to userspace). Unfortunately when considering the need f

Re: [Intel-gfx] [PATCH v2 00/13] drm/i915/dp: link rate and lane count refactoring

2017-02-07 Thread Manasi Navare
Hi Jani, Thanks for this patch series. This definitely makes use of lane count and link rate cleaner while handling the link failures. I have tested these patches with compliance device along with my pending DRM link-status patches and it does the fallback as expected. It does not solve the proble

Re: [Intel-gfx] [PATCH v2 12/13] drm/i915/dp: localize link rate index variable more

2017-02-07 Thread Manasi Navare
This has been tested to correctly execute the compliance request. Reviewed-by: Manasi Navare Manasi On Fri, Feb 03, 2017 at 04:19:35PM +0200, Jani Nikula wrote: > Localize link_rate_index to the if block, and rename to just index to > reduce indent. > > Cc: Manasi Navare > Cc: Ville Syrjälä

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Introduce intel_cdclk_state (rev12)

2017-02-07 Thread Patchwork
== Series Details == Series: drm/i915: Introduce intel_cdclk_state (rev12) URL : https://patchwork.freedesktop.org/series/16994/ State : warning == Summary == Series 16994v12 drm/i915: Introduce intel_cdclk_state https://patchwork.freedesktop.org/api/1.0/series/16994/revisions/12/mbox/ Test k

Re: [Intel-gfx] [PATCH] drm/i915: Always convert incoming exec offsets to non-canonical

2017-02-07 Thread Chris Wilson
On Tue, Feb 07, 2017 at 08:55:59PM +0100, Michał Winiarski wrote: > We're using non-canonical addresses in drm_mm, and we're making sure that > userspace is using canonical addressing - both in case of softpin > (verifying incoming offset) and when relocating (converting to canonical > when updatin

Re: [Intel-gfx] [PATCH] drm/i915/guc: Dynamically alloc GuC descriptor

2017-02-07 Thread Chris Wilson
On Tue, Feb 07, 2017 at 01:37:52AM -0800, Oscar Mateo wrote: > > > On 02/07/2017 09:25 AM, Chris Wilson wrote: > >On Tue, Feb 07, 2017 at 12:55:21AM -0800, Oscar Mateo wrote: > >> > >>On 02/02/2017 11:33 PM, Chris Wilson wrote: > >>>On Thu, Feb 02, 2017 at 07:27:45AM -0800, Oscar Mateo wrote: > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Always convert incoming exec offsets to non-canonical

2017-02-07 Thread Patchwork
== Series Details == Series: drm/i915: Always convert incoming exec offsets to non-canonical URL : https://patchwork.freedesktop.org/series/19259/ State : failure == Summary == Series 19259v1 drm/i915: Always convert incoming exec offsets to non-canonical https://patchwork.freedesktop.org/api/

[Intel-gfx] [PATCH 2/3] drm/i915: Split GEM resetting into 3 phases

2017-02-07 Thread Chris Wilson
Currently we do a reset prepare/finish around the call to reset the GPU, but it looks like we need a later stage after the hw has been reinitialised to allow GEM to restart itself. Start by splitting the 2 GEM phases into 3: prepare - before the reset, check if GEM recovered, then stop GEM re

[Intel-gfx] [PATCH 1/3] drm/i915: Move calling engine->init_hw() to its own function

2017-02-07 Thread Chris Wilson
Just a simple refactor to move a loop and some support code out of i915_gem_init_hw(). This is in preparation for avoiding a race between the tasklet writing to ELSP whilst simultaneously being written by engine->init_hw() following a GPU reset. Signed-off-by: Chris Wilson Cc: Mika Kuoppala ---

[Intel-gfx] [PATCH 3/3] drm/i915: Disable engine->irq_tasklet around resets

2017-02-07 Thread Chris Wilson
When we restart the engines, and we have active requests, a request on the first engine may complete and queue a request to the second engine before we try to restart the second engine. That queueing of the request may race with the engine to restart, and so may corrupt the current state. Disabling

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Split GEM resetting into 3 phases

2017-02-07 Thread Chris Wilson
On Tue, Feb 07, 2017 at 09:12:25PM +, Chris Wilson wrote: > Currently we do a reset prepare/finish around the call to reset the GPU, > but it looks like we need a later stage after the hw has been > reinitialised to allow GEM to restart itself. Start by splitting the 2 > GEM phases into 3: > >

Re: [Intel-gfx] [PATCH v4] drm/i915: Restore context and pd for ringbuffer submission after reset

2017-02-07 Thread Chris Wilson
On Tue, Feb 07, 2017 at 05:54:10PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > Following a reset, the context and page directory registers are lost. > > However, the queue of requests that we resubmit after the reset may > > depend upon them - the registers are restored from a contex

[Intel-gfx] linux-firmware pull request (bxt guc,huc; kbl guc,huc; skl huc)

2017-02-07 Thread Srivatsa, Anusha
Hi, Please consider pulling i915 updates to linux-firmware.git. The following changes since commit 6d3bc8886517d171068fd1263176b8b5c51df204: Fix permissions on ti-connectivity firmware from 05e9fe59 (2017-01-13 10:14:07 -0500) are available in the git repository at: https://github.com/anu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Move calling engine->init_hw() to its own function

2017-02-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Move calling engine->init_hw() to its own function URL : https://patchwork.freedesktop.org/series/19263/ State : success == Summary == Series 19263v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/

[Intel-gfx] [PATCH] drm/i915/dp: Clean up/Get rid of detect_done flag

2017-02-07 Thread Manasi Navare
Detect_done flag was added previously when intel_dp_long_pulse was called from multiple places. However now it is called only from intel_dp_detect(). So this flag becomes redundant. Anyway now, we set this to false right away after intel_dp_long_pulse so it calls long pulse handler always for all c

Re: [Intel-gfx] [PATCH] drm/fb-helper: Automatically clean up fb_info

2017-02-07 Thread Emil Velikov
On 7 February 2017 at 14:49, Chris Wilson wrote: > On Tue, Feb 07, 2017 at 02:38:16PM +, Emil Velikov wrote: >> On 7 February 2017 at 14:29, Daniel Vetter wrote: >> > Noticed that everyone duplicates the same logic here and we could safe >> > a few lines per driver. Yay for lots of drivers to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Clean up/Get rid of detect_done flag

2017-02-07 Thread Patchwork
== Series Details == Series: drm/i915/dp: Clean up/Get rid of detect_done flag URL : https://patchwork.freedesktop.org/series/19276/ State : success == Summary == Series 19276v1 drm/i915/dp: Clean up/Get rid of detect_done flag https://patchwork.freedesktop.org/api/1.0/series/19276/revisions/1

[Intel-gfx] [PATCH] drm/i915/dp: Reset the link params on HPD/connected boot/resume

2017-02-07 Thread Manasi Navare
The max link parameters should be set/reset only on HPD or connected boot case or on system resume. Add a flag reset_link_params to intel_dp to decide when to reset the max link parameters. This prevents the parameters from getting reset/overwritten through all other connector->funcs->detect() cal

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Reset the link params on HPD/connected boot/resume

2017-02-07 Thread Patchwork
== Series Details == Series: drm/i915/dp: Reset the link params on HPD/connected boot/resume URL : https://patchwork.freedesktop.org/series/19277/ State : success == Summary == Series 19277v1 drm/i915/dp: Reset the link params on HPD/connected boot/resume https://patchwork.freedesktop.org/api/

[Intel-gfx] [PATCH i-g-t] lib/igt_gt: Define HANG_ALLOW_* as bit flags

2017-02-07 Thread Michel Thierry
As that is what they are meant to be. It will prevent any confusion if we have to add other flags in the future. Signed-off-by: Michel Thierry --- lib/igt_gt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt_gt.h b/lib/igt_gt.h index e44b6db1..d83e23a1 100644 ---

<    1   2