Re: [Intel-gfx] [PATCH v2 15/38] drm/i915: Test simultaneously submitting requests to all engines

2017-02-01 Thread Joonas Lahtinen
On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > Use a recursive-batch to busy spin on each to ensure that each is being > run simultaneously. > > Signed-off-by: Chris Wilson > --- >  drivers/gpu/drm/i915/selftests/i915_gem_request.c | 178 > ++ >  1 file changed, 17

Re: [Intel-gfx] [PATCH v2 14/38] drm/i915: Simple selftest to exercise live requests

2017-02-01 Thread Joonas Lahtinen
On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > Just create several batches of requests and expect it to not fall over! > > Signed-off-by: Chris Wilson > +static int live_nop_request(void *arg) > +{ > + for_each_prime_number_from(prime, 1, 8192) { #define MAGIC_PRIME_2

Re: [Intel-gfx] [PATCH] drm: Don't race connector registration

2017-02-01 Thread Daniel Vetter
On Tue, Jan 31, 2017 at 04:27:14PM -0800, Dave Hansen wrote: > I added some printk()s all over and gathered a bit more information > about what's going on. It looks like the display doesn't work until the > drm connector code cleans up the *old* connector. For some reason, it > isn't motivated to

[Intel-gfx] [PATCH 3/3] drm/i915/gen9: WM memory bandwidth related workaround

2017-02-01 Thread Mahesh Kumar
This patch enables workarounds related to display arbitrated memory bandwidth only if it's necessary. WA's are applicable for all GEN9 based platforms. Changes since v1: - Rebase on top of Paulo's patch series Changes since v2: - Address review comments - Rebase/rework as per other patch change

Re: [Intel-gfx] [PATCH igt] intel-ci: Move start of gvt tests last

2017-02-01 Thread Petri Latvala
On Tue, Jan 31, 2017 at 03:54:46PM +, Chris Wilson wrote: > The purpose of the current placeholder gvt is to reload the module with > gvt enabled. As a reload, it should be last after the basic reload > checks. > > Signed-off-by: Chris Wilson Indeed. Acked-by: Petri Latvala > --- >

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable IPC & WM related WA's (rev2)

2017-02-01 Thread Patchwork
== Series Details == Series: Enable IPC & WM related WA's (rev2) URL : https://patchwork.freedesktop.org/series/18842/ State : failure == Summary == Series 18842v2 Enable IPC & WM related WA's https://patchwork.freedesktop.org/api/1.0/series/18842/revisions/2/mbox/ Test core_prop_blob:

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gen9: WM memory bandwidth related workaround

2017-02-01 Thread Maarten Lankhorst
Hey, Op 31-01-17 om 15:57 schreef Mahesh Kumar: > This patch enables workarounds related to display arbitrated memory > bandwidth only if it's necessary. WA's are applicable for all GEN9 > based platforms. > > Changes since v1: > - Rebase on top of Paulo's patch series > Changes since v2: > - Ad

Re: [Intel-gfx] [PATCH v2 15/38] drm/i915: Test simultaneously submitting requests to all engines

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 10:03:07AM +0200, Joonas Lahtinen wrote: > On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > > + if (gen >= 8) { > > + *cmd++ = MI_BATCH_BUFFER_START | 1 << 8 | 1; > > + *cmd++ = lower_32_bits(vma->node.start); > > + *cmd++ = upper_32_bi

[Intel-gfx] [PATCH v5] drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Chris Wilson
This emulates execlists on top of the GuC in order to defer submission of requests to the hardware. This deferral allows time for high priority requests to gazump their way to the head of the queue, however it nerfs the GuC by converting it back into a simple execlist (where the CPU has to wake up

Re: [Intel-gfx] [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc

2017-02-01 Thread Daniel Vetter
On Mon, Jan 09, 2017 at 11:19:32AM +, Chris Wilson wrote: > On a non-llc system, the objects are created with .cache_level = > CACHE_NONE and so the transition to uncached for scanout is a no-op. > However, if the object was never written to, it will still be in the CPU > domain (having been ze

Re: [Intel-gfx] [PATCH v2 14/38] drm/i915: Simple selftest to exercise live requests

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 10:14:28AM +0200, Joonas Lahtinen wrote: > On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > > Just create several batches of requests and expect it to not fall over! > > > > Signed-off-by: Chris Wilson > > > > > +static int live_nop_request(void *arg) > > +{ > >

Re: [Intel-gfx] [PATCH i-g-t v4 05/11] lib/igt_kms: Add support for the IN_FENCE_FD property

2017-02-01 Thread Brian Starkey
On Tue, Jan 31, 2017 at 08:25:14PM -0500, Robert Foss wrote: Add support dor the IN_FENCE_FD property to enable setting in fences for atomic commits. trivial... s/dor/for/ Signed-off-by: Robert Foss --- lib/igt_kms.c | 25 + lib/igt_kms.h | 5 + 2 files changed, 3

Re: [Intel-gfx] [PATCH i-g-t v4 06/11] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2017-02-01 Thread Brian Starkey
On Tue, Jan 31, 2017 at 08:25:15PM -0500, Robert Foss wrote: From: Gustavo Padovan Add support for the OUT_FENCE_PTR property to enable setting out fences for atomic commits. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 23 ++- lib/igt_kms.

Re: [Intel-gfx] [PATCH i-g-t v4 09/11] tests/kms_atomic_transition: add out_fences tests

2017-02-01 Thread Brian Starkey
On Tue, Jan 31, 2017 at 08:25:18PM -0500, Robert Foss wrote: Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 16 + tests/kms_atomic_transition.c | 153 -- 2 files changed, 164 insertions(+), 5 deletions(-)

Re: [Intel-gfx] [PATCH i-g-t v4 11/11] lib/igt_kms: Added igt_pipe_get_last_out_fence()

2017-02-01 Thread Brian Starkey
On Tue, Jan 31, 2017 at 08:25:20PM -0500, Robert Foss wrote: Added the igt_pipe_get_last_out_fence() helper function that wraps accesses to pipe->fence_out. Signed-off-by: Robert Foss --- lib/igt_kms.c | 8 lib/igt_kms.h | 1 + 2 files changed, 9 insertions(+) diff --git a/lib/igt_kms.c

Re: [Intel-gfx] [PATCH i-g-t v4 00/11] tests/kms_atomic_transition add fence testing

2017-02-01 Thread Brian Starkey
Hi Robert, Some minor comments on 5, 6, 9, 10 and 11. With those addressed, the whole series is: Reviewed-by: Brian Starkey Thanks! -Brian P.S. Immediately after hitting send I realised I should have trimmed that blob from my reply. Sorry for bouncing that back to everyone! On Tue, Jan 31, 2

Re: [Intel-gfx] [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 11:24:32AM +0100, Daniel Vetter wrote: > On Mon, Jan 09, 2017 at 11:19:32AM +, Chris Wilson wrote: > > On a non-llc system, the objects are created with .cache_level = > > CACHE_NONE and so the transition to uncached for scanout is a no-op. > > However, if the object was

[Intel-gfx] [PATCH i-g-t] tests/chamelium: Adapt to dynamic number of planes changes

2017-02-01 Thread Petri Latvala
CC: Robert Foss CC: Lyude Signed-off-by: Petri Latvala --- tests/chamelium.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/chamelium.c b/tests/chamelium.c index d914d5b..e03acc4 100644 --- a/tests/chamelium.c +++ b/tests/chamelium.c @@ -310,7 +310,7 @@ ena

Re: [Intel-gfx] [PATCH v2 03/38] drm/i915: Add some selftests for sg_table manipulation

2017-02-01 Thread Tvrtko Ursulin
On 19/01/2017 11:41, Chris Wilson wrote: Start exercising the scattergather lists, especially looking at iteration after coalescing. v2: Comment on the peculiarity of table construction (i.e. why this sg_table might be interesting). Just a comment added as request, cool, I can r-b then! Erm n

Re: [Intel-gfx] [PATCH v2 06/38] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

2017-02-01 Thread Tvrtko Ursulin
On 19/01/2017 11:41, Chris Wilson wrote: Third retroactive test, make sure that the seqno waiters are woken. No changelog and you haven't added any of the comments I've asked for. I really think it is time to add more documentation in the tests. I don't feel like reverse engineering what thi

Re: [Intel-gfx] [PATCH v2 03/38] drm/i915: Add some selftests for sg_table manipulation

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 11:17:39AM +, Tvrtko Ursulin wrote: > >+static noinline int expect_pfn_sg(struct pfn_table *pt, > > Why noinline? So they show up in perf individually. > >+ > >+for (npages = npages_funcs; *npages; npages++) { > >+prando

Re: [Intel-gfx] [PATCH v2 06/38] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 11:27:00AM +, Tvrtko Ursulin wrote: > > On 19/01/2017 11:41, Chris Wilson wrote: > >Third retroactive test, make sure that the seqno waiters are woken. > > No changelog and you haven't added any of the comments I've asked > for. I really think it is time to add more do

Re: [Intel-gfx] [PATCH v2 38/38] drm/i915: Add initial selftests for hang detection and resets

2017-02-01 Thread Mika Kuoppala
Chris Wilson writes: > Check that we can reset the GPU and continue executing from the next > request. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_hangcheck.c | 4 + > .../gpu/drm/i915/selftests/i915_live_selftests.h | 1 + > drivers/gpu/drm/i915/selftes

Re: [Intel-gfx] [PATCH v5] drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Tvrtko Ursulin
On 01/02/2017 10:24, Chris Wilson wrote: This emulates execlists on top of the GuC in order to defer submission of requests to the hardware. This deferral allows time for high priority requests to gazump their way to the head of the queue, however it nerfs the GuC by converting it back into a si

[Intel-gfx] [PATCH 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-01 Thread Shashank Sharma
This patch does following: - Adds a new structure (drm_hdmi_info) in drm_display_info. This structure will be used to save and indicate if sink supports advance HDMI 2.0 features - Checks the HF-VSDB block for presence of SCDC, and marks it in hdmi_info structure. - If SCDC is present, checks

[Intel-gfx] [PATCH 2/6] drm/edid: check for HF-VSDB block

2017-02-01 Thread Shashank Sharma
From: Thierry Reding This patch implements a small function that finds if a given CEA db is hdmi-forum vendor specific data block or not. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_edid.c | 15 +++ include/linux/hdmi.h | 1 + 2 files changed, 16 insertions(+) dif

[Intel-gfx] [PATCH 5/6] drm/i915: enable scrambling

2017-02-01 Thread Shashank Sharma
Geminilake platform has a native HDMI 2.0 controller, and is capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec mendates scrambling for these higher clocks, for reduced RF footprint. This patch checks if the monitor supports scrambling, and if required, enables it during the modeset. Sign

[Intel-gfx] [PATCH 6/6] drm/i915: allow HDMI 2.0 clock rates

2017-02-01 Thread Shashank Sharma
Geminilake has a native HDMI 2.0 controller, which is capable of driving clocks upto 594Mhz. This patch updates the max tmds clock limit for the same. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH 0/6] HDMI 2.0: Scrambling support in DRM layer

2017-02-01 Thread Shashank Sharma
HDMI 2.0 spec defines a method to reduce the RF footprint while operating at higher pixel clocks, which is called Scrambling. Scrambling can be controlled over a new set of I2C registers which are accessible over existing DDC I2C lines, called SCDC register set. This patch series contains 6 patche

[Intel-gfx] [PATCH 1/6] drm: Add SCDC helpers

2017-02-01 Thread Shashank Sharma
From: Thierry Reding SCDC is a mechanism defined in the HDMI 2.0 specification that allows the source and sink devices to communicate. This commit introduces helpers to access the SCDC and provides the symbolic names for the various registers defined in the specification. Signed-off-by: Thierry

[Intel-gfx] [PATCH 4/6] drm: scrambling support in drm layer

2017-02-01 Thread Shashank Sharma
HDMI 2.0 spec mandates scrambling for modes with pixel clock higher than 340Mhz. This patch adds few new functions in drm layer for core drivers to enable/disable scrambling. This patch adds: - A function to detect scrambling support parsing HF-VSDB - A function to check scrambling status runtime

Re: [Intel-gfx] [PATCH RFC] drm/i915: reduce cursor size for GEN5 hardware

2017-02-01 Thread Maarten Lankhorst
Op 31-01-17 om 20:13 schreef Uwe Kleine-König: > Hello, > > On Tue, Jan 31, 2017 at 10:03:26AM +0100, Maarten Lankhorst wrote: >> Op 31-01-17 om 09:09 schreef Uwe Kleine-König: >>> From: Chris Wilson >>> >>> As the introduced comment admits this is clearly a workaround, but for >>> me this is the

[Intel-gfx] Problem with i915 driver when mixing Skylake CPU with Kabylake chipset

2017-02-01 Thread Rainer Koenig
Hello, I'm investigating a problem on a machine that has a Kabylake PCH but a Skylake CPU i5-6500. Problem is that I can install and use distributions that are based on an older kernel, but newer Linux dristributions fail to boot even the installer. So far I managed to get Fedora 25 with a 4.9 k

Re: [Intel-gfx] [PATCH v5] drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 12:09:40PM +, Tvrtko Ursulin wrote: > > On 01/02/2017 10:24, Chris Wilson wrote: > >This emulates execlists on top of the GuC in order to defer submission of > >requests to the hardware. This deferral allows time for high priority > >requests to gazump their way to the

[Intel-gfx] [PATCH] drm/i915/execlists: Skip resetting RING_CONTEXT_STATUS_PTR

2017-02-01 Thread Chris Wilson
As we now flag when the GPU signals a context-switch and do not read the status register before we see that signal, we do not have to ensure that it is cleared upon reset (and can leave it to the GPU to reset it from the power context). Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ur

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Patchwork
== Series Details == Series: drm/i915/scheduler: emulate a scheduler for guc URL : https://patchwork.freedesktop.org/series/18909/ State : success == Summary == Series 18909v1 drm/i915/scheduler: emulate a scheduler for guc https://patchwork.freedesktop.org/api/1.0/series/18909/revisions/1/mbo

[Intel-gfx] ✗ Fi.CI.BAT: failure for HDMI 2.0: Scrambling support in DRM layer

2017-02-01 Thread Patchwork
== Series Details == Series: HDMI 2.0: Scrambling support in DRM layer URL : https://patchwork.freedesktop.org/series/18915/ State : failure == Summary == CHECK usr/include/linux/byteorder/ (2 files) CHECK usr/include/linux/android/ (1 files) CHECK usr/include/linux/caif/ (2 files)

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Skip resetting RING_CONTEXT_STATUS_PTR

2017-02-01 Thread Mika Kuoppala
Chris Wilson writes: > As we now flag when the GPU signals a context-switch and do not read the > status register before we see that signal, we do not have to ensure that > it is cleared upon reset (and can leave it to the GPU to reset it from > the power context). > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for HDMI 2.0: Scrambling support in DRM layer

2017-02-01 Thread Sharma, Shashank
I build bzImage, keeping I915 as part of kernel (not as a module) Looks like I need to add EXPORT_SYMBOL(drm_enable_scrambling) Will cover this in V2. Regards Shashank -Original Message- From: Patchwork [mailto:patchw...@emeril.freedesktop.org] Sent: Wednesday, February 1, 2017 6:33 PM

[Intel-gfx] [PATCH] drm/i915/execlists: Add interrupt-pending check to intel_execlists_idle()

2017-02-01 Thread Chris Wilson
Primarily this serves as a sanity check that the bit has been cleared before we suspend (and hasn't reappeared after resume). Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

Re: [Intel-gfx] [PATCH v5] drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Tvrtko Ursulin
On 01/02/2017 12:46, Chris Wilson wrote: On Wed, Feb 01, 2017 at 12:09:40PM +, Tvrtko Ursulin wrote: On 01/02/2017 10:24, Chris Wilson wrote: This emulates execlists on top of the GuC in order to defer submission of requests to the hardware. This deferral allows time for high priority req

[Intel-gfx] [PATCH i-g-t v3 1/7] lib/igt_kms: Add forcing TEST_ONLY for atomic commits

2017-02-01 Thread Mika Kahola
Add an option to force atomic commits to do commits with TEST_ONLY flag first before doing the actual commit. Signed-off-by: Mika Kahola --- lib/igt_kms.c | 18 +- lib/igt_kms.h | 1 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c i

[Intel-gfx] [PATCH i-g-t v3 2/7] tests/kms_plane_multiple: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 35 +++ 1 file changed, 35 insertions(+)

[Intel-gfx] [PATCH i-g-t v3 7/7] tests/kms_cursor_legacy: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_cursor_legacy.c | 230 -- 1 file changed, 204 insertions(+), 26 deletions(-) diff --git a/tests/kms_cursor_legacy.c b/tests

[Intel-gfx] [PATCH i-g-t v3 4/7] tests/kms_plane_scaling: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic scaling without actually committing the changes. v2: Create subtests with TEST_ONLY flag and one without Signed-off-by: Mika Kahola --- tests/kms_plane_scaling.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/

[Intel-gfx] [PATCH i-g-t v3 0/7] Validate TEST_ONLY correctness against full atomic commit

2017-02-01 Thread Mika Kahola
This test case adds TEST_ONLY flag to the following test cases to test atomic commit correctness. - kms_plane_multiple - kms_atomic_transitions - kms_plane_scaling - kms_rotation_crc - kms_plane_lowres The test randomly selects one of the above test cases and tests atomic commit. If the tes

[Intel-gfx] [PATCH i-g-t v3 6/7] tests/kms_plane_lowres: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_plane_lowres.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_

[Intel-gfx] [PATCH i-g-t v3 3/7] tests/kms_atomic_transition: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic transition display commits without actual real-life commit. v2: use flag to force atomic commit with TEST_ONLY flag Signed-off-by: Mika Kahola --- tests/kms_atomic_transition.c | 66 --- 1 file changed, 56 insertions(+),

[Intel-gfx] [PATCH i-g-t v3 5/7] tests/kms_rotation_crc: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola --- tests/kms_rotation_crc.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.

[Intel-gfx] [PATCH v3] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

2017-02-01 Thread Chris Wilson
Third retroactive test, make sure that the seqno waiters are woken. v2: Smattering of comments, rearrange code Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 202 + 1 file changed, 202 insertions(+) diff --git a/drivers/gpu/drm/i915/sel

Re: [Intel-gfx] [REGRESSION] Black screen after switching desktop session (was: Re: Linux 4.10-rc5)

2017-02-01 Thread David Weinehall
On Wed, Jan 25, 2017 at 01:10:26PM +0100, Martin Steigerwald wrote: > Am Sonntag, 22. Januar 2017, 13:32:08 CET schrieb Linus Torvalds: > > Things seem to be calming down a bit, and everything looks nominal. > > > > There's only been about 250 changes (not counting merges) in the last > > week, an

Re: [Intel-gfx] [PATCH i-g-t] tests/chamelium: Adapt to dynamic number of planes changes

2017-02-01 Thread Robert Foss
This looks good to me, feel free to add my r-b. Rob. On 2017-02-01 05:56 AM, Petri Latvala wrote: CC: Robert Foss CC: Lyude Signed-off-by: Petri Latvala --- tests/chamelium.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/chamelium.c b/tests/chamelium.c

Re: [Intel-gfx] [PATCH v2 32/38] drm/i915: Verify page layout for rotated VMA

2017-02-01 Thread Matthew Auld
On 19 January 2017 at 11:41, Chris Wilson wrote: > Exercise creating rotated VMA and checking the page order within. > > v2: Be more creative in rotated params > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/selftests/i915_vma.c | 177 > ++ > 1 file chan

Re: [Intel-gfx] [PATCH v2 38/38] drm/i915: Add initial selftests for hang detection and resets

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 01:43:41PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > +static u64 hws_address(const struct i915_vma *hws, > > + const struct drm_i915_gem_request *rq) > > +{ > > + return hws->node.start + offset_in_page(sizeof(u32)*rq->fence.context); > > fe

Re: [Intel-gfx] [PATCH v5] drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 01:15:49PM +, Tvrtko Ursulin wrote: > > On 01/02/2017 12:46, Chris Wilson wrote: > >If we set the context-switch bit too early (and process the > >user-interrupt and the context-switch as two separate passes through the > >tasklet), we encounter the error from before th

[Intel-gfx] [PATCH] drm/i915: don't warn about Skylake CPU - KabyPoint PCH combo

2017-02-01 Thread Jani Nikula
Apparently there are machines out there with Skylake CPU and KabyPoint PCH. Judging from our driver code, there doesn't seem to be any code paths that would do anything different between SunrisePoint and KabyPoint PCHs, so it would seem okay to accept the combo without warnings. Fixes: 22dea0be50b

Re: [Intel-gfx] Problem with i915 driver when mixing Skylake CPU with Kabylake chipset

2017-02-01 Thread Jani Nikula
On Wed, 01 Feb 2017, Rainer Koenig wrote: > Hello, > > I'm investigating a problem on a machine that has a Kabylake PCH but a > Skylake CPU i5-6500. > > Problem is that I can install and use distributions that are based on an > older kernel, but newer Linux dristributions fail to boot even the > i

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/execlists: Skip resetting RING_CONTEXT_STATUS_PTR

2017-02-01 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Skip resetting RING_CONTEXT_STATUS_PTR URL : https://patchwork.freedesktop.org/series/18918/ State : warning == Summary == Series 18918v1 drm/i915/execlists: Skip resetting RING_CONTEXT_STATUS_PTR https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH v2 02/38] drm/i915: Provide a hook for selftests

2017-02-01 Thread Chris Wilson
On Wed, Jan 25, 2017 at 01:50:01PM +0200, Joonas Lahtinen wrote: > On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > > @@ -499,7 +501,17 @@ static int i915_pci_probe(struct pci_dev *pdev, const > > struct pci_device_id *ent) > >   if (vga_switcheroo_client_probe_defer(pdev)) > >  

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Add interrupt-pending check to intel_execlists_idle()

2017-02-01 Thread kbuild test robot
Hi Chris, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.10-rc6 next-20170201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-execlists

Re: [Intel-gfx] [PATCH v2 30/38] drm/i915: Test creation of VMA

2017-02-01 Thread Chris Wilson
On Tue, Jan 31, 2017 at 12:50:20PM +0200, Joonas Lahtinen wrote: > On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > > + for_each_prime_number(num_obj, ULONG_MAX - 1) { > > + for (; no < num_obj; no++) { > > + obj = i915_gem_object_create_internal(i915, PAGE_SIZE

[Intel-gfx] [PATCH] tests/kms_plane_multiple: Test only with maximum number of planes

2017-02-01 Thread Mika Kahola
To be more suitable for BAT testing, let's modify the test such a way that it only uses the maximum number of available planes. This reduces the total number of subtests. Cc: Robert Foss Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 91 +++--

Re: [Intel-gfx] Problem with i915 driver when mixing Skylake CPU with Kabylake chipset

2017-02-01 Thread Rainer Koenig
Am 01.02.2017 um 14:50 schrieb Jani Nikula: >> I read from that, that the driver issues the warning when PCH is a >> Kabypoint PCH, but the CPU based graphics is not from a Kabylake CPU. > > It's just a warning. But if there really are such combos out there, we > should get rid of the warning. Pa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Add interrupt-pending check to intel_execlists_idle()

2017-02-01 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Add interrupt-pending check to intel_execlists_idle() URL : https://patchwork.freedesktop.org/series/18921/ State : success == Summary == Series 18921v1 drm/i915/execlists: Add interrupt-pending check to intel_execlists_idle() https://patchwor

Re: [Intel-gfx] [PATCH v2 32/38] drm/i915: Verify page layout for rotated VMA

2017-02-01 Thread Tvrtko Ursulin
On 19/01/2017 11:41, Chris Wilson wrote: Exercise creating rotated VMA and checking the page order within. v2: Be more creative in rotated params Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_vma.c | 177 ++ 1 file changed, 177 insertions(+)

Re: [Intel-gfx] [PATCH RFC] drm/i915: reduce cursor size for GEN5 hardware

2017-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2017 at 01:41:08PM +0100, Maarten Lankhorst wrote: > Op 31-01-17 om 20:13 schreef Uwe Kleine-König: > > Hello, > > > > On Tue, Jan 31, 2017 at 10:03:26AM +0100, Maarten Lankhorst wrote: > >> Op 31-01-17 om 09:09 schreef Uwe Kleine-König: > >>> From: Chris Wilson > >>> > >>> As the

Re: [Intel-gfx] [PATCH] drm/i915: Add MIPI_IO WA and program DSI regulators

2017-02-01 Thread Jani Nikula
On Tue, 31 Jan 2017, Mika Kahola wrote: > Looks ok. > > Acked-by: Mika Kahola Pushed to drm-intel-next-queued, thanks for the patch. BR, Jani. > > On Wed, 2017-01-25 at 19:43 +0530, Vidya Srinivas wrote: >> From: Uma Shankar >> >> Enable MIPI IO WA for BXT DSI as per bspec and >> program the

Re: [Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-02-01 Thread Ville Syrjälä
On Tue, Jan 31, 2017 at 10:36:44PM +0100, Takashi Iwai wrote: > From: Pierre-Louis Bossart > > Enable unmute/mute amp notification. This doesn't seem to affect > HDMI support so this is done unconditionally. > > An earlier version of this patch set a chicken bit at address 0x62F38 > prior to the

Re: [Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-02-01 Thread Takashi Iwai
On Wed, 01 Feb 2017 15:45:24 +0100, Ville Syrjälä wrote: > > On Tue, Jan 31, 2017 at 10:36:44PM +0100, Takashi Iwai wrote: > > From: Pierre-Louis Bossart > > > > Enable unmute/mute amp notification. This doesn't seem to affect > > HDMI support so this is done unconditionally. > > > > An earlier

Re: [Intel-gfx] [PATCH v2 32/38] drm/i915: Verify page layout for rotated VMA

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 02:33:22PM +, Tvrtko Ursulin wrote: > > On 19/01/2017 11:41, Chris Wilson wrote: > >Exercise creating rotated VMA and checking the page order within. > > > >v2: Be more creative in rotated params > > > >Signed-off-by: Chris Wilson > >--- > > drivers/gpu/drm/i915/selfte

Re: [Intel-gfx] [PATCH] tests/kms_plane_multiple: Test only with maximum number of planes

2017-02-01 Thread Robert Foss
I was pondering making this change myself, but didn't dare change the functional aspects of the test. Feel free to add my r-b. Rob. On 2017-02-01 09:12 AM, Mika Kahola wrote: To be more suitable for BAT testing, let's modify the test such a way that it only uses the maximum number of availabl

Re: [Intel-gfx] [PATCH] drm/i915: don't warn about Skylake CPU - KabyPoint PCH combo

2017-02-01 Thread Vivi, Rodrigo
Reviewed-by: Rodrigo Vivi > On Feb 1, 2017, at 5:46 AM, Nikula, Jani wrote: > > Apparently there are machines out there with Skylake CPU and KabyPoint > PCH. Judging from our driver code, there doesn't seem to be any code > paths that would do anything different between SunrisePoint and > Kab

Re: [Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2017 at 03:53:49PM +0100, Takashi Iwai wrote: > On Wed, 01 Feb 2017 15:45:24 +0100, > Ville Syrjälä wrote: > > > > On Tue, Jan 31, 2017 at 10:36:44PM +0100, Takashi Iwai wrote: > > > From: Pierre-Louis Bossart > > > > > > Enable unmute/mute amp notification. This doesn't seem to

Re: [Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-02-01 Thread Takashi Iwai
On Wed, 01 Feb 2017 16:11:37 +0100, Ville Syrjälä wrote: > > > +/* DisplayPort Audio w/ LPE */ > > +#define VLV_AUD_PORT_EN_B_DBG (VLV_DISPLAY_BASE + 0x62F20) > > +#define VLV_AUD_PORT_EN_C_DBG (VLV_DISPLAY_BASE + 0x62F30) > > +#define VLV_AUD_PORT_EN_D_DBG (

[Intel-gfx] [PATCH v6] drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Chris Wilson
This emulates execlists on top of the GuC in order to defer submission of requests to the hardware. This deferral allows time for high priority requests to gazump their way to the head of the queue, however it nerfs the GuC by converting it back into a simple execlist (where the CPU has to wake up

Re: [Intel-gfx] [PATCH v2 32/38] drm/i915: Verify page layout for rotated VMA

2017-02-01 Thread Tvrtko Ursulin
On 01/02/2017 14:55, Chris Wilson wrote: On Wed, Feb 01, 2017 at 02:33:22PM +, Tvrtko Ursulin wrote: [snip] + { } + }, *a, *b; + const unsigned int max_pages = 64; + int err = -ENOMEM; + + /* Create VMA for many different combinations of planes and c

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Drop some unused fields from i915_execbuffer_params

2017-02-01 Thread Tvrtko Ursulin
On 01/02/2017 07:20, Joonas Lahtinen wrote: On ti, 2017-01-31 at 13:15 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin dev, file and ctx are unused. Signed-off-by: Tvrtko Ursulin Could either squash this to the previous commit, or have this before previous commit, to avoid going through

Re: [Intel-gfx] [PATCH 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-01 Thread Thierry Reding
On Wed, Feb 01, 2017 at 06:14:38PM +0530, Shashank Sharma wrote: > This patch does following: > - Adds a new structure (drm_hdmi_info) in drm_display_info. > This structure will be used to save and indicate if sink > supports advance HDMI 2.0 features "advanced" > - Checks the HF-VSDB block f

[Intel-gfx] [PATCH v7] drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Chris Wilson
This emulates execlists on top of the GuC in order to defer submission of requests to the hardware. This deferral allows time for high priority requests to gazump their way to the head of the queue, however it nerfs the GuC by converting it back into a simple execlist (where the CPU has to wake up

Re: [Intel-gfx] [PATCH v7] drm/i915/scheduler: emulate a scheduler for guc

2017-02-01 Thread Tvrtko Ursulin
On 01/02/2017 16:15, Chris Wilson wrote: This emulates execlists on top of the GuC in order to defer submission of requests to the hardware. This deferral allows time for high priority requests to gazump their way to the head of the queue, however it nerfs the GuC by converting it back into a si

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: don't warn about Skylake CPU - KabyPoint PCH combo

2017-02-01 Thread Patchwork
== Series Details == Series: drm/i915: don't warn about Skylake CPU - KabyPoint PCH combo URL : https://patchwork.freedesktop.org/series/18924/ State : success == Summary == Series 18924v1 drm/i915: don't warn about Skylake CPU - KabyPoint PCH combo https://patchwork.freedesktop.org/api/1.0/se

Re: [Intel-gfx] [PATCH 4/6] drm: scrambling support in drm layer

2017-02-01 Thread Thierry Reding
On Wed, Feb 01, 2017 at 06:14:39PM +0530, Shashank Sharma wrote: > HDMI 2.0 spec mandates scrambling for modes with pixel clock higher > than 340Mhz. This patch adds few new functions in drm layer for > core drivers to enable/disable scrambling. > > This patch adds: > - A function to detect scramb

Re: [Intel-gfx] [PATCH 4/6] drm: scrambling support in drm layer

2017-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2017 at 06:14:39PM +0530, Shashank Sharma wrote: > HDMI 2.0 spec mandates scrambling for modes with pixel clock higher > than 340Mhz. This patch adds few new functions in drm layer for > core drivers to enable/disable scrambling. > > This patch adds: > - A function to detect scramb

Re: [Intel-gfx] [PATCH i-g-t v4 05/11] lib/igt_kms: Add support for the IN_FENCE_FD property

2017-02-01 Thread Robert Foss
On 2017-02-01 05:39 AM, Brian Starkey wrote: On Tue, Jan 31, 2017 at 08:25:14PM -0500, Robert Foss wrote: Add support dor the IN_FENCE_FD property to enable setting in fences for atomic commits. trivial... s/dor/for/ Thanks, coming up in v5. Rob. Signed-off-by: Robert Foss --- lib/ig

Re: [Intel-gfx] [PATCH 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2017 at 06:14:38PM +0530, Shashank Sharma wrote: > This patch does following: > - Adds a new structure (drm_hdmi_info) in drm_display_info. > This structure will be used to save and indicate if sink > supports advance HDMI 2.0 features > - Checks the HF-VSDB block for presence o

Re: [Intel-gfx] [PATCH i-g-t v4 06/11] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2017-02-01 Thread Robert Foss
On 2017-02-01 05:40 AM, Brian Starkey wrote: On Tue, Jan 31, 2017 at 08:25:15PM -0500, Robert Foss wrote: From: Gustavo Padovan Add support for the OUT_FENCE_PTR property to enable setting out fences for atomic commits. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt

Re: [Intel-gfx] [PATCH 5/6] drm/i915: enable scrambling

2017-02-01 Thread Ville Syrjälä
On Wed, Feb 01, 2017 at 06:14:40PM +0530, Shashank Sharma wrote: > Geminilake platform has a native HDMI 2.0 controller, and is > capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec > mendates scrambling for these higher clocks, for reduced RF footprint. > > This patch checks if the monitor

Re: [Intel-gfx] [PATCH i-g-t v4 09/11] tests/kms_atomic_transition: add out_fences tests

2017-02-01 Thread Robert Foss
On 2017-02-01 05:40 AM, Brian Starkey wrote: On Tue, Jan 31, 2017 at 08:25:18PM -0500, Robert Foss wrote: Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 16 + tests/kms_atomic_transition.c | 153 -- 2 f

[Intel-gfx] [PATCH 2/2] drm/i915: Capture module parameters for the GPU error state

2017-02-01 Thread Chris Wilson
They include useful material such as what mode the VM address space is running in, what submission mode, extra quirks, etc. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gpu_error.c | 27 --- 2 files changed, 21 in

[Intel-gfx] [PATCH 1/2] drm/i915: Generate i915_params {} using a macro

2017-02-01 Thread Chris Wilson
I want to print the struct from the error state and so would like to use the existing struct definition as the template ala DEV_INFO* Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_params.h | 81 -- 1 file changed, 43 insertions(+), 38 deletions(-)

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Capture module parameters for the GPU error state

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 04:50:06PM +, Chris Wilson wrote: > They include useful material such as what mode the VM address space is s/The module parameters/ > running in, what submission mode, extra quirks, etc. and so are invaluable when analysing errors. -Chris -- Chris Wilson, Intel Open S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/scheduler: emulate a scheduler for guc (rev3)

2017-02-01 Thread Patchwork
== Series Details == Series: drm/i915/scheduler: emulate a scheduler for guc (rev3) URL : https://patchwork.freedesktop.org/series/18909/ State : success == Summary == Series 18909v3 drm/i915/scheduler: emulate a scheduler for guc https://patchwork.freedesktop.org/api/1.0/series/18909/revision

Re: [Intel-gfx] [PATCH v3] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

2017-02-01 Thread Tvrtko Ursulin
On 01/02/2017 13:19, Chris Wilson wrote: Third retroactive test, make sure that the seqno waiters are woken. v2: Smattering of comments, rearrange code Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 202 + 1 file changed, 202 insertio

Re: [Intel-gfx] [PATCH v3] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

2017-02-01 Thread Chris Wilson
On Wed, Feb 01, 2017 at 04:57:53PM +, Tvrtko Ursulin wrote: > >+static bool wait_for_ready(struct igt_wakeup *w) > >+{ > >+DEFINE_WAIT(ready); > >+ > >+if (atomic_dec_and_test(w->done)) > >+wake_up_atomic_t(w->done); > >+ > >+if (test_bit(STOP, &w->flags)) > >+

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Generate i915_params {} using a macro

2017-02-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Generate i915_params {} using a macro URL : https://patchwork.freedesktop.org/series/18937/ State : warning == Summary == Series 18937v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/18937/revisio

Re: [Intel-gfx] [PATCH igt] igt/perf: improve robustness of polling/blocking tests

2017-02-01 Thread Matthew Auld
On 24 January 2017 at 00:53, Robert Bragg wrote: > There were a couple of problems with both of these tests that could lead > to false negatives addressed by this patch. > > 1) The upper limit for the number of iterations missed a +1 to consider >that there might be a sample immediately availa

Re: [Intel-gfx] [PATCH i-g-t v4 00/11] tests/kms_atomic_transition add fence testing

2017-02-01 Thread Robert Foss
On 2017-02-01 05:44 AM, Brian Starkey wrote: Hi Robert, Some minor comments on 5, 6, 9, 10 and 11. With those addressed, the whole series is: Reviewed-by: Brian Starkey Thanks! -Brian Thanks for the review Brian! I'll submit v5 and let it soak for a little while before pushing it upstream

[Intel-gfx] [PATCH i-g-t v5 06/10] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2017-02-01 Thread Robert Foss
From: Gustavo Padovan Add support for the OUT_FENCE_PTR property to enable setting out fences for atomic commits. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Reviewed-by: Brian Starkey --- lib/igt_kms.c | 23 ++- lib/igt_kms.h | 6 +- 2 files changed, 2

[Intel-gfx] [PATCH i-g-t v5 07/10] tests/kms_atomic: stress possible fence settings

2017-02-01 Thread Robert Foss
From: Gustavo Padovan Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Reviewed-by: Brian Starkey --- tests/kms_atomic.c | 187 ++--- 1 file changed, 177 insertions(+), 10 deletions(-) diff --git a/tests/kms_atomic.c b/tests/kms_atomic

[Intel-gfx] [PATCH i-g-t v5 05/10] lib/igt_kms: Add support for the IN_FENCE_FD property

2017-02-01 Thread Robert Foss
Add support for the IN_FENCE_FD property to enable setting in fences for atomic commits. Signed-off-by: Robert Foss Reviewed-by: Brian Starkey --- lib/igt_kms.c | 25 + lib/igt_kms.h | 5 + 2 files changed, 30 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.

  1   2   >