Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

2017-01-31 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 12:18:07PM +, Eric Engestrom wrote: > On Monday, 2017-01-30 11:50:52 +, Daniel Stone wrote: > > Hi, > > > > On 30 January 2017 at 11:46, Petri Latvala wrote: > > > NAK. > > > > > > DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable > > > to modese

Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

2017-01-31 Thread Jeffrey Cheung
Hi Takashi How is the test kernel ? Just wonder when Sridhara team can test again. Regards Jeffrey >>> Takashi Iwai 2017/1/27 下午 18:29 >>>On Thu, 26 Jan 2017 >>> 15:19:44 +0100, Takashi Iwai wrote: > > On Thu, 26 Jan 2017 14:58:55 +0100, > Ville Syrjälä wrote: > > > > Hmm. Have you tried

[Intel-gfx] [PATCH RFC] drm/i915: reduce cursor size for GEN5 hardware

2017-01-31 Thread Uwe Kleine-König
From: Chris Wilson As the introduced comment admits this is clearly a workaround, but for me this is the only known way to make my Lenovo X201 work without flickering and crashing. Signed-off-by: Uwe Kleine-König [uwe: added changelog, comment and restrict to GEN5] --- Hello, as I don't like h

Re: [Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

2017-01-31 Thread Jeffrey Cheung
Hi Takashi Thanks a lot. --- Hi Sridhara Can you please try the test kernel ? Regards Jeffrey >>> Takashi Iwai 2017/1/31 下午 13:49 >>>On Tue, 31 Jan 2017 >>> 03:34:23 +0100, Jeffrey Cheung wrote: > > Hi Takashi > > How is the test kernel ? Just wonder when Sridhara team can test again.

Re: [Intel-gfx] [GLK MIPI DSI V3 0/7] GLK MIPI DSI VIDEO MODE PATCHES

2017-01-31 Thread Chauhan, Madhav
> -Original Message- > From: Chauhan, Madhav > Sent: Monday, January 2, 2017 6:24 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; Shankar, Uma > ; Mukherjee, Indranil > ; Kamath, Sunil ; > Saarinen, Jani ; Conselvan De Oliveira, Ander > ; Konduru, Chandra > ; Kumar, Shobhit >

Re: [Intel-gfx] [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc

2017-01-31 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 10:18:38PM -0800, Dhinakaran Pandiyan wrote: > drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state > but documentation claims otherwise, fix that. > > Signed-off-by: Dhinakaran Pandiyan Indeed, thanks for the fix, applied to drm-misc. -Daniel > --- >

[Intel-gfx] lRE: Broken DPMS with DisplayPort on CHV (also BYT?)

2017-01-31 Thread Jeffrey Cheung
Ok, look like we have improvement of using the drm-intel-nightly tree kernel. Hi takashi and ville, any clue of the single dell e type monitor ? Regards Jeffrey >>> 2017/1/31 下午 15:36 >>>Hi, Installed RPM, Issue still present with Single Dell E- Series monitor (Display doesn't appear ) Iss

Re: [Intel-gfx] [PATCH RFC] drm/i915: reduce cursor size for GEN5 hardware

2017-01-31 Thread Maarten Lankhorst
Op 31-01-17 om 09:09 schreef Uwe Kleine-König: > From: Chris Wilson > > As the introduced comment admits this is clearly a workaround, but for > me this is the only known way to make my Lenovo X201 work without > flickering and crashing. > > Signed-off-by: Uwe Kleine-König > [uwe: added changelog

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

2017-01-31 Thread Maarten Lankhorst
Hey, Op 31-01-17 om 08:46 schreef Daniel Vetter: > On Mon, Jan 30, 2017 at 03:42:17PM +0100, Maarten Lankhorst wrote: >> Op 30-01-17 om 09:17 schreef Daniel Vetter: >>> On Fri, Jan 27, 2017 at 03:08:45PM +, Chris Wilson wrote: On Fri, Jan 27, 2017 at 03:58:08PM +0100, Daniel Vetter wrote:

[Intel-gfx] [PATCH 1/2] drm/atomic: Unconditionally call prepare_fb.

2017-01-31 Thread Maarten Lankhorst
Atomic drivers may set properties like rotation on the same fb, which may require a call to prepare_fb even when framebuffer stays identical. Instead of handling all the special cases in the core, let the driver decide when prepare_fb and cleanup_fb are noops. This is a revert of: commit fcc60b4

[Intel-gfx] [PATCH 2/2] drm/i915: Track pinned vma in intel_plane_state

2017-01-31 Thread Maarten Lankhorst
From: Chris Wilson With atomic plane states we are able to track an allocation right from preparation, during use and through to the final free after being swapped out for a new plane. We can couple the VMA we pin for the framebuffer (and its rotation) to this lifetime and avoid all the clumsy lo

[Intel-gfx] [PATCH 0/2] drm/i915: Backport vma fixes for 4.10-rc6

2017-01-31 Thread Maarten Lankhorst
With atomic plane states we are able to track an allocation right from preparation, during use and through to the final free after being swapped out for a new plane. We can couple the VMA we pin for the framebuffer (and its rotation) to this lifetime and avoid all the clumsy lookups in between. Th

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: reduce cursor size for GEN5 hardware

2017-01-31 Thread Patchwork
== Series Details == Series: drm/i915: reduce cursor size for GEN5 hardware URL : https://patchwork.freedesktop.org/series/18822/ State : warning == Summary == Series 18822v1 drm/i915: reduce cursor size for GEN5 hardware https://patchwork.freedesktop.org/api/1.0/series/18822/revisions/1/mbox/

[Intel-gfx] [PATCH] drm/atomic: Fix double free in drm_atomic_state_default_clear

2017-01-31 Thread Maarten Lankhorst
drm_atomic_helper_page_flip and drm_atomic_ioctl set their own events in crtc_state->event. But when it's set the event is freed in 2 places. Solve this by only freeing the event in the atomic ioctl when it allocated its own event. This has been broken twice. The first time when the code was intr

[Intel-gfx] [dim PATCH 2/2] dim: document how to define subcommand aliases

2017-01-31 Thread Jani Nikula
Cc: Gerd Hoffmann Signed-off-by: Jani Nikula --- dim.rst | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/dim.rst b/dim.rst index 97b375e34e90..911b4666b4aa 100644 --- a/dim.rst +++ b/dim.rst @@ -330,9 +330,10 @@ Run the given command in all active workdirs includi

[Intel-gfx] [dim PATCH 1/2] dim: handle missing declare -n option gracefully

2017-01-31 Thread Jani Nikula
The declare -n option was added in bash 4.3. Handle missing -n gracefully, at the expense of losing dim alias functionality. Cc: Gerd Hoffmann Reported-by: Gerd Hoffmann Signed-off-by: Jani Nikula --- dim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dim b/dim index

Re: [Intel-gfx] [PATCH igt] intel-ci: Minimal exercise of explicit fencing

2017-01-31 Thread Chris Wilson
On Fri, Jan 27, 2017 at 09:36:23PM +, Chris Wilson wrote: > Signed-off-by: Chris Wilson > Cc: Petri Latvala Ping? And any feedback from the earlier ringfill-fds? -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing li

Re: [Intel-gfx] [PATCH] drm/i915: Add MIPI_IO WA and program DSI regulators

2017-01-31 Thread Srinivas, Vidya
Gentle remainder - could you kindly check the patch please? Thank you. > -Original Message- > From: Srinivas, Vidya > Sent: Wednesday, January 25, 2017 7:43 PM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Nikula, Jani > ; Syrjala, Ville ; Kahola, > Mika ; Srinivas, Vidya > S

Re: [Intel-gfx] [PATCH v2] drm/i915: Sanity check the computed size and base of stolen memory

2017-01-31 Thread Joonas Lahtinen
On ma, 2017-01-30 at 13:47 +, Chris Wilson wrote: > Just do a quick check that the stolen memory address range doesn't > overflow our chosen integer type. > > v2: Add add_overflows() to utils with the promise that gcc7 can do this > better than C and then maybe it will have a proper definition

Re: [Intel-gfx] [PATCH i-g-t v3 00/11] tests/kms_atomic_transition add fence testing

2017-01-31 Thread Chris Wilson
On Mon, Jan 30, 2017 at 08:58:36PM -0500, Robert Foss wrote: > This series adds in/out fence testing to kms_atomic_transition test and makes > some minor cleanups. > > This series is rebased ontop of the dyn_n_planes_v3 series. > > This series can be found here: > https://git.collabora.com/cgit/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic: Fix double free in drm_atomic_state_default_clear

2017-01-31 Thread Patchwork
== Series Details == Series: drm/atomic: Fix double free in drm_atomic_state_default_clear URL : https://patchwork.freedesktop.org/series/18826/ State : success == Summary == Series 18826v1 drm/atomic: Fix double free in drm_atomic_state_default_clear https://patchwork.freedesktop.org/api/1.0/

[Intel-gfx] [PATCH] drm/i915: The return of i915_gpu_info to debugfs

2017-01-31 Thread Chris Wilson
Once upon a time before we had automated GPU state capture upon hangs, we had intel_gpu_dump. Now we come almost full circle and reinstate that view of the current GPU queues and registers by using the error capture facility to snapshot the GPU state when debugfs/.../i915_gpu_info is opened - which

[Intel-gfx] [PATCH] drm/i915: Be defensive when cleaning up i915_gem_internal pages

2017-01-31 Thread Chris Wilson
If we abort the i915_gem_internal get_pages, we mark the failing sg as the last. However, that means we iterate upto and including the failing sg element and results us in trying to free the unallocated sg_page(). Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_internal.c | 7 +

Re: [Intel-gfx] [PATCH v2 30/38] drm/i915: Test creation of VMA

2017-01-31 Thread Joonas Lahtinen
On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > Simple test to exercise creation and lookup of VMA within an object. > > Signed-off-by: Chris Wilson > +static bool assert_vma(struct i915_vma *vma, > +    struct drm_i915_gem_object *obj, > +    struct i91

Re: [Intel-gfx] [Linux v4.10.0-rc1+] Still call-traces after suspend-resume (pm? i915? cpu/hotplug?)

2017-01-31 Thread Imre Deak
Hi Rafael, On Mon, Jan 30, 2017 at 11:44:37PM +0100, Rafael J. Wysocki wrote: > On 1/24/2017 2:33 AM, Sedat Dilek wrote: > >On Fri, Dec 30, 2016 at 3:02 PM, Rafael J. Wysocki wrote: > >>On Fri, Dec 30, 2016 at 12:40 PM, Sedat Dilek wrote: > >>>Hi, > >>> > >>>I have already reported this issue in

Re: [Intel-gfx] [PATCH] drm/i915: Add MIPI_IO WA and program DSI regulators

2017-01-31 Thread Mika Kahola
Looks ok. Acked-by: Mika Kahola On Wed, 2017-01-25 at 19:43 +0530, Vidya Srinivas wrote: > From: Uma Shankar > > Enable MIPI IO WA for BXT DSI as per bspec and > program the DSI regulators. > > v2: Moved IO enable to pre-enable as per Mika's > review comments. Also reused the existing registe

Re: [Intel-gfx] [PATCH] drm/i915: Be defensive when cleaning up i915_gem_internal pages

2017-01-31 Thread Matthew Auld
On 31 January 2017 at 10:46, Chris Wilson wrote: > If we abort the i915_gem_internal get_pages, we mark the failing sg as > the last. However, that means we iterate upto and including the failing > sg element and results us in trying to free the unallocated sg_page(). s/us in/in us/ > > Signed-of

Re: [Intel-gfx] [PATCH igt] intel-ci: Add multiple ringfill for execlists

2017-01-31 Thread Petri Latvala
On Tue, Jan 24, 2017 at 01:02:23PM +0200, Petri Latvala wrote: > On Tue, Jan 24, 2017 at 09:31:39AM +, Chris Wilson wrote: > > On Wed, Jan 18, 2017 at 08:54:10PM +, Chris Wilson wrote: > > > Execlists introduces a new wrinkle to filling rings, in that each > > > context has an independent s

Re: [Intel-gfx] [PATCH igt] intel-ci: Minimal exercise of explicit fencing

2017-01-31 Thread Petri Latvala
On Tue, Jan 31, 2017 at 09:54:21AM +, Chris Wilson wrote: > Ping? And any feedback from the earlier ringfill-fds? > -Chris Sent ack on the ringfill test. This one has been queued for a test round at farm2. For those following along and smelling chances of getting their $favoritefeatureofthed

Re: [Intel-gfx] [PATCH] drm/i915: Be defensive when cleaning up i915_gem_internal pages

2017-01-31 Thread Chris Wilson
On Tue, Jan 31, 2017 at 11:04:49AM +, Matthew Auld wrote: > On 31 January 2017 at 10:46, Chris Wilson wrote: > > If we abort the i915_gem_internal get_pages, we mark the failing sg as > > the last. However, that means we iterate upto and including the failing > > sg element and results us in t

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: The return of i915_gpu_info to debugfs

2017-01-31 Thread Patchwork
== Series Details == Series: drm/i915: The return of i915_gpu_info to debugfs URL : https://patchwork.freedesktop.org/series/18833/ State : failure == Summary == Series 18833v1 drm/i915: The return of i915_gpu_info to debugfs https://patchwork.freedesktop.org/api/1.0/series/18833/revisions/1/m

Re: [Intel-gfx] [PATCH igt] intel-ci: Minimal exercise of explicit fencing

2017-01-31 Thread Chris Wilson
On Tue, Jan 31, 2017 at 01:21:15PM +0200, Petri Latvala wrote: > On Tue, Jan 31, 2017 at 09:54:21AM +, Chris Wilson wrote: > > Ping? And any feedback from the earlier ringfill-fds? > > -Chris > > > Sent ack on the ringfill test. This one has been queued for a test > round at farm2. > > For t

Re: [Intel-gfx] [Linux v4.10.0-rc1+] Still call-traces after suspend-resume (pm? i915? cpu/hotplug?)

2017-01-31 Thread Rafael J. Wysocki
On 1/31/2017 11:58 AM, Imre Deak wrote: Hi Rafael, Hi, On Mon, Jan 30, 2017 at 11:44:37PM +0100, Rafael J. Wysocki wrote: On 1/24/2017 2:33 AM, Sedat Dilek wrote: On Fri, Dec 30, 2016 at 3:02 PM, Rafael J. Wysocki wrote: On Fri, Dec 30, 2016 at 12:40 PM, Sedat Dilek wrote: Hi, I have a

Re: [Intel-gfx] [PATCH v2 33/38] drm/i915: Test creation of partial VMA

2017-01-31 Thread Joonas Lahtinen
On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > Mock testing to ensure we can create and lookup partial VMA. > > Signed-off-by: Chris Wilson > +static bool assert_partial(struct drm_i915_gem_object *obj, > +    struct i915_vma *vma, > +    unsign

Re: [Intel-gfx] [Linux v4.10.0-rc1+] Still call-traces after suspend-resume (pm? i915? cpu/hotplug?)

2017-01-31 Thread Imre Deak
On Tue, Jan 31, 2017 at 12:39:35PM +0100, Rafael J. Wysocki wrote: > On 1/31/2017 11:58 AM, Imre Deak wrote: > >Hi Rafael, > > Hi, > > >On Mon, Jan 30, 2017 at 11:44:37PM +0100, Rafael J. Wysocki wrote: > >>On 1/24/2017 2:33 AM, Sedat Dilek wrote: > >>>On Fri, Dec 30, 2016 at 3:02 PM, Rafael J. W

Re: [Intel-gfx] [PATCH] drm/atomic: Fix double free in drm_atomic_state_default_clear

2017-01-31 Thread Gustavo Padovan
Hi Maarten, 2017-01-31 Maarten Lankhorst : > drm_atomic_helper_page_flip and drm_atomic_ioctl set their own events > in crtc_state->event. But when it's set the event is freed in 2 places. > > Solve this by only freeing the event in the atomic ioctl when it > allocated its own event. > > This h

Re: [Intel-gfx] [Linux v4.10.0-rc1+] Still call-traces after suspend-resume (pm? i915? cpu/hotplug?)

2017-01-31 Thread Rafael J. Wysocki
On 1/31/2017 1:02 PM, Imre Deak wrote: On Tue, Jan 31, 2017 at 12:39:35PM +0100, Rafael J. Wysocki wrote: On 1/31/2017 11:58 AM, Imre Deak wrote: Hi Rafael, Hi, On Mon, Jan 30, 2017 at 11:44:37PM +0100, Rafael J. Wysocki wrote: On 1/24/2017 2:33 AM, Sedat Dilek wrote: On Fri, Dec 30, 2016

Re: [Intel-gfx] [PATCH v2 26/38] drm/i915: Exercise filling the top/bottom portions of the ppgtt

2017-01-31 Thread Joonas Lahtinen
On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > Allocate objects with varying number of pages (which should hopefully > consist of a mixture of contiguous page chunks and so coalesced sg > lists) and check that the sg walkers in insert_pages cope. > > Signed-off-by: Chris Wilson > +sta

Re: [Intel-gfx] [PATCH] drm/atomic: Fix double free in drm_atomic_state_default_clear

2017-01-31 Thread Daniel Vetter
On Tue, Jan 31, 2017 at 10:04:09AM -0200, Gustavo Padovan wrote: > Hi Maarten, > > 2017-01-31 Maarten Lankhorst : > > > drm_atomic_helper_page_flip and drm_atomic_ioctl set their own events > > in crtc_state->event. But when it's set the event is freed in 2 places. > > > > Solve this by only fre

Re: [Intel-gfx] [Linux v4.10.0-rc1+] Still call-traces after suspend-resume (pm? i915? cpu/hotplug?)

2017-01-31 Thread Imre Deak
On Tue, Jan 31, 2017 at 01:12:05PM +0100, Rafael J. Wysocki wrote: > On 1/31/2017 1:02 PM, Imre Deak wrote: > >On Tue, Jan 31, 2017 at 12:39:35PM +0100, Rafael J. Wysocki wrote: > >>On 1/31/2017 11:58 AM, Imre Deak wrote: > >>>Hi Rafael, > >>Hi, > >> > >>>On Mon, Jan 30, 2017 at 11:44:37PM +0100, R

[Intel-gfx] [PATCH 09/10] drm/i915: Pass file_priv to eb_select_engine

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin file_priv is what it needs to pass on to gen8_dispatch_bsd_engine so simplify things by passing it straight away. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/d

[Intel-gfx] [PATCH 03/10] drm/i915: Tidy execbuf_submit

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use a local variable for storing the request and engine and at the same time drop the engine field from i915_execbuffer_params since it is available from the request. textdata bss dec hex filename 1085402 263982628 1114428 11013c i915.ko.0 108

[Intel-gfx] [PATCH 00/10] do_execbuffer tidy

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I've noticed a few opportunities to improve the readability of this functions and then kept spotting more and more which can be removed or compacted. Eventually ended up with removing i915_execbuffer_params completely. But I think it's OK since the plan between when it was a

[Intel-gfx] [PATCH 04/10] drm/i915: Remove batch field from i915_execbuffer_params

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Also redundant since it is stored in the request. textdata bss dec hex filename 1085354 263982628 1114380 11010c i915.ko.0 1085338 263982628 1114364 1100fc i915.ko.1 Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_exe

[Intel-gfx] [PATCH 10/10] drm/i915: Remove some unecessary line breaks

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Just spotted a few lines which fit in 80 chars and were split. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drive

[Intel-gfx] [PATCH 05/10] drm/i915: Nuke i915_execbuffer_params

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Now that it only contains three parameters we can pass them directly to execbuf_submit just as well. No effect on generated binary, just a source reduction. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 39 -- 1

[Intel-gfx] [PATCH 08/10] drm/i915: eb_engine_select only needs flags

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Not the whole args struct needs to be passed in. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 01/10] drm/i915: Tidy i915_gem_do_execbuffer

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of sprinkling around usage and initialization of i915_execbuffer_params we can consolidate it just before execbuf_submit for maintability and readability. That way we can also drop the memset since it becomes easy to spot we initialize all the fields. textd

[Intel-gfx] [PATCH 07/10] drm/i915: Drop unused engine parameter from i915_gem_validate_context

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index 57a

[Intel-gfx] [PATCH 06/10] drm/i915: Remove some single use locals i915_gem_do_execbuffer

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Remove ctx_id, ggtt and vm since they are single use. textdata bss dec hex filename 1085338 263982628 1114364 1100fc i915.ko.0 1085290 263982628 1114316 1100cc i915.ko.1 Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem

[Intel-gfx] [PATCH 02/10] drm/i915: Drop some unused fields from i915_execbuffer_params

2017-01-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin dev, file and ctx are unused. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index ee7b7bd17e29..

Re: [Intel-gfx] [PATCH 00/10] do_execbuffer tidy

2017-01-31 Thread Chris Wilson
On Tue, Jan 31, 2017 at 01:15:36PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I've noticed a few opportunities to improve the readability of this functions > and then kept spotting more and more which can be removed or compacted. > > Eventually ended up with removing i915_execbuffer

Re: [Intel-gfx] [PATCH v2] drm/color: un-inline drm_color_lut_extract()

2017-01-31 Thread Jani Nikula
On Fri, 27 Jan 2017, Jani Nikula wrote: > The function is not that big, but it's also not used for anything > performance critical. Make it a normal function. > > As a side effect, this apparently makes sparse smarter about what it's > doing, and gets rid of the warning: > > ./include/drm/drm_colo

Re: [Intel-gfx] [PATCH] tools: rename intel_bios_reader to intel_vbt_decode

2017-01-31 Thread Jani Nikula
On Mon, 30 Jan 2017, Ville Syrjälä wrote: > On Mon, Jan 30, 2017 at 10:00:54AM +0200, Jani Nikula wrote: >> On Tue, 24 Jan 2017, Jani Nikula wrote: >> > After all these years intel_bios_reader and intel_bios_dumper still >> > manage to confuse me. Read or dump, which one decodes. Rename >> > inte

[Intel-gfx] [PATCH 0/3] Enable IPC & WM related WA's

2017-01-31 Thread Mahesh Kumar
This series include remaining patches from following series to enable IPC and Enable/update memory BW related WA's for WM. https://patchwork.freedesktop.org/series/15562/ Mahesh Kumar (3): drm/i915/bxt: Enable IPC support drm/i915: Decode system memory bandwidth drm/i915/gen9: WM memory band

[Intel-gfx] [PATCH 2/3] drm/i915: Decode system memory bandwidth

2017-01-31 Thread Mahesh Kumar
This patch adds support to decode system memory bandwidth which will be used for arbitrated display memory percentage calculation in GEN9 based system. Changes from v1: - Address comments from Paulo - implement decode function for SKL/KBL also Changes from v2: - Rewrite the code as per HW team

[Intel-gfx] [PATCH 3/3] drm/i915/gen9: WM memory bandwidth related workaround

2017-01-31 Thread Mahesh Kumar
This patch enables workarounds related to display arbitrated memory bandwidth only if it's necessary. WA's are applicable for all GEN9 based platforms. Changes since v1: - Rebase on top of Paulo's patch series Changes since v2: - Address review comments - Rebase/rework as per other patch change

[Intel-gfx] [PATCH 1/3] drm/i915/bxt: Enable IPC support

2017-01-31 Thread Mahesh Kumar
This patch adds IPC support for platforms. This patch enables IPC only for BXT/KBL platform as for SKL recommendation is to keep it disabled. IPC (Isochronous Priority Control) is the hardware feature, which dynamically controls the memory read priority of Display. When IPC is enabled, plane read

[Intel-gfx] ✗ Fi.CI.BAT: warning for do_execbuffer tidy

2017-01-31 Thread Patchwork
== Series Details == Series: do_execbuffer tidy URL : https://patchwork.freedesktop.org/series/18838/ State : warning == Summary == Series 18838v1 do_execbuffer tidy https://patchwork.freedesktop.org/api/1.0/series/18838/revisions/1/mbox/ Test kms_force_connector_basic: Subgroup force

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable IPC & WM related WA's

2017-01-31 Thread Patchwork
== Series Details == Series: Enable IPC & WM related WA's URL : https://patchwork.freedesktop.org/series/18842/ State : success == Summary == Series 18842v1 Enable IPC & WM related WA's https://patchwork.freedesktop.org/api/1.0/series/18842/revisions/1/mbox/ fi-bdw-5557u total:247 pass:

[Intel-gfx] [PATCH igt] intel-ci: Move start of gvt tests last

2017-01-31 Thread Chris Wilson
The purpose of the current placeholder gvt is to reload the module with gvt enabled. As a reload, it should be last after the basic reload checks. Signed-off-by: Chris Wilson --- tests/intel-ci/fast-feedback.testlist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/intel

Re: [Intel-gfx] [PATCH i-g-t v3 00/11] tests/kms_atomic_transition add fence testing

2017-01-31 Thread Robert Foss
On 2017-01-31 05:18 AM, Chris Wilson wrote: On Mon, Jan 30, 2017 at 08:58:36PM -0500, Robert Foss wrote: This series adds in/out fence testing to kms_atomic_transition test and makes some minor cleanups. This series is rebased ontop of the dyn_n_planes_v3 series. This series can be found he

Re: [Intel-gfx] [PATCH 1/3] drm/i915/bxt: Enable IPC support

2017-01-31 Thread Ander Conselvan De Oliveira
On Tue, 2017-01-31 at 20:27 +0530, Mahesh Kumar wrote: > This patch adds IPC support for platforms. This patch enables IPC > only for BXT/KBL platform as for SKL recommendation is to keep it disabled. > IPC (Isochronous Priority Control) is the hardware feature, which > dynamically controls the mem

Re: [Intel-gfx] [PATCH v2] drm/i915: Sanity check the computed size and base of stolen memory

2017-01-31 Thread Chris Wilson
On Tue, Jan 31, 2017 at 12:13:47PM +0200, Joonas Lahtinen wrote: > On ma, 2017-01-30 at 13:47 +, Chris Wilson wrote: > > Just do a quick check that the stolen memory address range doesn't > > overflow our chosen integer type. > > > > v2: Add add_overflows() to utils with the promise that gcc7

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

2017-01-31 Thread Chris Wilson
On Mon, Jan 30, 2017 at 05:54:14PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/3] drm/i915: Make > intel_detect_preproduction_hw easier to extend > URL : https://patchwork.freedesktop.org/series/18758/ > State : success > > == Summary == > > Series 18

Re: [Intel-gfx] [PATCH i-g-t v3 06/11] lib/igt_kms: Add support for the IN_FENCE_FD property

2017-01-31 Thread Brian Starkey
On Mon, Jan 30, 2017 at 08:58:42PM -0500, Robert Foss wrote: Add support dor the IN_FENCE_FD property to enable setting in fences for atomic commits. Signed-off-by: Robert Foss --- lib/igt_kms.c | 20 lib/igt_kms.h | 5 + 2 files changed, 25 insertions(+) diff --git a/l

Re: [Intel-gfx] [PATCH i-g-t v3 07/11] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2017-01-31 Thread Brian Starkey
On Mon, Jan 30, 2017 at 08:58:43PM -0500, Robert Foss wrote: From: Gustavo Padovan Add support for the OUT_FENCE_PTR property to enable setting out fences for atomic commits. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 26 +- lib/igt_k

Re: [Intel-gfx] [PATCH i-g-t v3 08/11] tests/kms_atomic: stress possible fence settings

2017-01-31 Thread Brian Starkey
This one lgtm, just need to swap all the uint64_t out_fence_ptrs for int32_t. -Brian On Mon, Jan 30, 2017 at 08:58:44PM -0500, Robert Foss wrote: From: Gustavo Padovan Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- tests/kms_atomic.c | 187

Re: [Intel-gfx] [PATCH i-g-t v3 10/11] tests/kms_atomic_transition: add out_fences tests

2017-01-31 Thread Brian Starkey
On Mon, Jan 30, 2017 at 08:58:46PM -0500, Robert Foss wrote: Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 35 ++ tests/kms_atomic_transition.c | 148 ++ 2 files changed, 169 insertions(+), 14 deletio

Re: [Intel-gfx] [PATCH i-g-t v3 11/11] tests/kms_atomic_transition: add in_fences tests

2017-01-31 Thread Brian Starkey
On Mon, Jan 30, 2017 at 08:58:47PM -0500, Robert Foss wrote: From: Gustavo Padovan Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 3 +++ tests/kms_atomic_transition.c | 48 ++- 2 files changed, 32 insertions

Re: [Intel-gfx] [PATCH i-g-t v3 05/11] lib/igt_kms: Added igt_pipe_get_last_out_fence()

2017-01-31 Thread Brian Starkey
On Mon, Jan 30, 2017 at 08:58:41PM -0500, Robert Foss wrote: Added the igt_pipe_get_last_out_fence() helper function that wraps accesses to pipe->fence_out. Signed-off-by: Robert Foss --- lib/igt_kms.c | 8 lib/igt_kms.h | 1 + 2 files changed, 9 insertions(+) diff --git a/lib/igt_kms.c

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gen9: WM memory bandwidth related workaround

2017-01-31 Thread kbuild test robot
-Kumar/Enable-IPC-WM-related-WA-s/20170131-230708 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-rhel (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All

[Intel-gfx] [PULL] drm-misc-fixes

2017-01-31 Thread Daniel Vetter
Hi Dave, 2 patches to fix the oops Dave Hanse reported, plus a double kfree fix Maarten discovered while backporting the fix for Linus. For Linus' vma tracking oops the plan is to send you a dedicated pull with the 2 patches we need, but since it's tricky we're letting CI beat on it a bit more.

[Intel-gfx] [PATCH] drm-misc: Document small drivers expectations

2017-01-31 Thread Daniel Vetter
For the experiement we have right now Eric (with vc4) and Sean Paul (with rockchip and zte) volunteering, and Gerd (entire pile of qemu drivers) and Boris (atmel) are also considering to participate. I think that's enough to get started and figure things out as we go. I tried to summarize the main

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gen9: WM memory bandwidth related workaround

2017-01-31 Thread kbuild test robot
-Kumar/Enable-IPC-WM-related-WA-s/20170131-230708 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All

Re: [Intel-gfx] [PATCH RFC] drm/i915: reduce cursor size for GEN5 hardware

2017-01-31 Thread Uwe Kleine-König
Hello, On Tue, Jan 31, 2017 at 10:03:26AM +0100, Maarten Lankhorst wrote: > Op 31-01-17 om 09:09 schreef Uwe Kleine-König: > > From: Chris Wilson > > > > As the introduced comment admits this is clearly a workaround, but for > > me this is the only known way to make my Lenovo X201 work without >

Re: [Intel-gfx] [PATCH] drm-misc: Document small drivers expectations

2017-01-31 Thread Sean Paul
On Tue, Jan 31, 2017 at 07:01:44PM +0100, Daniel Vetter wrote: > For the experiement we have right now Eric (with vc4) and Sean Paul > (with rockchip and zte) volunteering, and Gerd (entire pile of qemu > drivers) and Boris (atmel) are also considering to participate. I > think that's enough to get

Re: [Intel-gfx] [PATCH] drm-misc: Document small drivers expectations

2017-01-31 Thread Daniel Vetter
On Tue, Jan 31, 2017 at 02:31:32PM -0500, Sean Paul wrote: > On Tue, Jan 31, 2017 at 07:01:44PM +0100, Daniel Vetter wrote: > > For the experiement we have right now Eric (with vc4) and Sean Paul > > (with rockchip and zte) volunteering, and Gerd (entire pile of qemu > > drivers) and Boris (atmel)

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Backport vma fixes for 4.10-rc6

2017-01-31 Thread Linus Torvalds
On Tue, Jan 31, 2017 at 1:21 AM, Maarten Lankhorst wrote: > > This is marked for rc6 because it seems the issue is triggerable on > mainline and resulting in an oops. So I did apply my obvious "avoid the oops and just warn about it" patch: commit 39cb2c9a316e ("drm/i915: Check for NULL i915_vma i

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Backport vma fixes for 4.10-rc6

2017-01-31 Thread Daniel Vetter
On Tue, Jan 31, 2017 at 12:28:40PM -0800, Linus Torvalds wrote: > On Tue, Jan 31, 2017 at 1:21 AM, Maarten Lankhorst > wrote: > > > > This is marked for rc6 because it seems the issue is triggerable on > > mainline and resulting in an oops. > > So I did apply my obvious "avoid the oops and just w

[Intel-gfx] [PATCH 0/7] DisplayPort audio support on Cherrytrail

2017-01-31 Thread Takashi Iwai
Hi, the following patches enable DisplayPort Audio on Cherrytrail machines when applied on top of my topic/intel-lpe-audio branch. Tests of DP audio were run on Dell Wyse 3040. The regression test were performed on Baytrail (Compute Stick) and Cherrytrail (Zotac PI330) in HDMI mode. On Cherrytr

[Intel-gfx] [PATCH 1/7] drm/i915: add DP support in LPE audio mode

2017-01-31 Thread Takashi Iwai
From: Pierre-Louis Bossart If DisplayPort is detected, pass flag and link rate to audio driver Signed-off-by: Pierre-Louis Bossart Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.h| 3 ++- drivers/gpu/drm/i915/intel_audio.c | 19 +++ drivers/gpu/drm/

[Intel-gfx] [PATCH 3/7] drm/i915: Avoid MST pipe handling for LPE audio

2017-01-31 Thread Takashi Iwai
The pipe gets cleared to -1 for non-MST before the ELD audio notification due to the MST audio support. This makes sense for HD-audio that received the MST handling, but it's useless for LPE audio. Handle the MST pipe hack conditionally only for HD-audio. Reported-by: Pierre-Louis Bossart Signe

[Intel-gfx] [PATCH 5/7] ALSA: x86: intel_hdmi: add definitions and logic for DP audio

2017-01-31 Thread Takashi Iwai
From: Pierre-Louis Bossart Imported from legacy patches Note: the new code doesn't assume a modified ELD but an explicit notification that DP is present. It appears that the i915 code does change the ELD so we could use the ELD-based tests to check for DP audio Signed-off-by: Pierre-Louis Bossa

[Intel-gfx] [PATCH 6/7] ALSA: x86: Use config base depending on the pipe

2017-01-31 Thread Takashi Iwai
From: Pierre-Louis Bossart Now the pipe that is being used is passed over i915 notification, we can re-setup the relevant register offset depending on pipe assignments during hotplug. This allows playback on single port machines such Zotac Pi330 or dual-port machines such as Dell Wyse 3040 box S

[Intel-gfx] [PATCH 7/7] drm/i915: Pass platform device to LPE audio notifier

2017-01-31 Thread Takashi Iwai
This allows the LPE HDMI driver to clean up its global variable reference. Also drop to pass the eld pointer because the connection status and the ELD bytes can be retrieved from the attached pdata. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_lpe_audio.c | 3 +-- include/drm/int

[Intel-gfx] [PATCH 2/7] drm/i915: add DisplayPort amp unmute for LPE audio mode

2017-01-31 Thread Takashi Iwai
From: Pierre-Louis Bossart Enable unmute/mute amp notification. This doesn't seem to affect HDMI support so this is done unconditionally. An earlier version of this patch set a chicken bit at address 0x62F38 prior to the mute/unmute but this register doesn't seem to do anything so this phase was

[Intel-gfx] [PATCH 4/7] drm/i915: Pass pipe to LPE audio notification

2017-01-31 Thread Takashi Iwai
The LPE audio configuration depends on the pipe, thus we need to pass the currently used pipe. It's now embedded in struct intel_hdmi_lpe_audio_eld as well as port id. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/intel_audio.c | 6 +++--

[Intel-gfx] ✓ Fi.CI.BAT: success for DisplayPort audio support on Cherrytrail

2017-01-31 Thread Patchwork
== Series Details == Series: DisplayPort audio support on Cherrytrail URL : https://patchwork.freedesktop.org/series/18864/ State : success == Summary == Series 18864v1 DisplayPort audio support on Cherrytrail https://patchwork.freedesktop.org/api/1.0/series/18864/revisions/1/mbox/ fi-bdw-55

Re: [Intel-gfx] [PATCH i-g-t v3 07/11] lib/igt_kms: Add support for the OUT_FENCE_PTR property

2017-01-31 Thread Robert Foss
On 2017-01-31 11:49 AM, Brian Starkey wrote: On Mon, Jan 30, 2017 at 08:58:43PM -0500, Robert Foss wrote: From: Gustavo Padovan Add support for the OUT_FENCE_PTR property to enable setting out fences for atomic commits. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt

Re: [Intel-gfx] [PATCH i-g-t v3 08/11] tests/kms_atomic: stress possible fence settings

2017-01-31 Thread Robert Foss
On 2017-01-31 11:50 AM, Brian Starkey wrote: This one lgtm, just need to swap all the uint64_t out_fence_ptrs for int32_t. -Brian Fixed in v4. Rob. On Mon, Jan 30, 2017 at 08:58:44PM -0500, Robert Foss wrote: From: Gustavo Padovan Signed-off-by: Gustavo Padovan Signed-off-by: Robert

[Intel-gfx] [PATCH v2] drm/i915: Get correct display clock on 945gm

2017-01-31 Thread Arthur Heymans
This is according to Mobile Intel® 945 Express Chipset Family datasheet. Signed-off-by: Arthur Heymans --- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_display.c | 29 ++--- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/driver

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Get correct display clock on 945gm (rev2)

2017-01-31 Thread Patchwork
== Series Details == Series: drm/i915: Get correct display clock on 945gm (rev2) URL : https://patchwork.freedesktop.org/series/18693/ State : failure == Summary == CC drivers/acpi/acpica/utpredef.o CC [M] drivers/gpu/drm/i915/i915_perf.o CC [M] drivers/gpu/drm/i915/i915_oa_hsw.o

[Intel-gfx] [PATCH] drm/i915: Get correct display clock on 945gm

2017-01-31 Thread Arthur Heymans
This is according to Mobile Intel® 945 Express Chipset Family datasheet. Signed-off-by: Arthur Heymans --- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_display.c | 27 +-- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/

Re: [Intel-gfx] [PATCH v2] drm/i915: Get correct display clock on 945gm

2017-01-31 Thread kbuild test robot
Hi Arthur, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20170131] [cannot apply to v4.10-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arthur-Heymans

Re: [Intel-gfx] [Linux v4.10.0-rc1+] Still call-traces after suspend-resume (pm? i915? cpu/hotplug?)

2017-01-31 Thread Rafael J. Wysocki
On Mon, Jan 30, 2017 at 11:44 PM, Rafael J. Wysocki wrote: > On 1/24/2017 2:33 AM, Sedat Dilek wrote: >> >> On Fri, Dec 30, 2016 at 3:02 PM, Rafael J. Wysocki >> wrote: >>> >>> On Fri, Dec 30, 2016 at 12:40 PM, Sedat Dilek >>> wrote: Hi, I have already reported this issue in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Get correct display clock on 945gm (rev3)

2017-01-31 Thread Patchwork
== Series Details == Series: drm/i915: Get correct display clock on 945gm (rev3) URL : https://patchwork.freedesktop.org/series/18693/ State : success == Summary == Series 18693v3 drm/i915: Get correct display clock on 945gm https://patchwork.freedesktop.org/api/1.0/series/18693/revisions/3/mb

Re: [Intel-gfx] [PATCH] drm: Don't race connector registration

2017-01-31 Thread Dave Hansen
I added some printk()s all over and gathered a bit more information about what's going on. It looks like the display doesn't work until the drm connector code cleans up the *old* connector. For some reason, it isn't motivated to do that until I go to the console and back. In this case, the displ

Re: [Intel-gfx] [PATCH i-g-t v3 10/11] tests/kms_atomic_transition: add out_fences tests

2017-01-31 Thread Robert Foss
On 2017-01-31 11:52 AM, Brian Starkey wrote: On Mon, Jan 30, 2017 at 08:58:46PM -0500, Robert Foss wrote: Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- lib/igt_kms.c | 35 ++ tests/kms_atomic_transition.c | 148 +

[Intel-gfx] ✓ Fi.CI.BAT: success for Still call-traces after suspend-resume (pm? i915? cpu/hotplug?)

2017-01-31 Thread Patchwork
== Series Details == Series: Still call-traces after suspend-resume (pm? i915? cpu/hotplug?) URL : https://patchwork.freedesktop.org/series/18871/ State : success == Summary == Series 18871v1 Still call-traces after suspend-resume (pm? i915? cpu/hotplug?) https://patchwork.freedesktop.org/api/

  1   2   >