Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect

2016-12-20 Thread Jani Nikula
On Tue, 20 Dec 2016, Dhinakaran Pandiyan wrote: > From: "Navare, Manasi D" > > The detect_done flag was introduced in the 'commit 7d23e3c37bb3 > ("drm/i915: Cleaning up intel_dp_hpd_pulse")' in order to avoid multiple > detects on hotplug where intel_dp_long_pulse() was called from HPD handler >

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Add a cursor hack to allow converting legacy page flip to atomic, v3.

2016-12-20 Thread Daniel Vetter
On Mon, Dec 12, 2016 at 11:34:55AM +0100, Maarten Lankhorst wrote: > Do something similar to vc4, only allow updating the cursor state > in-place through a fastpath when the watermarks are unaffected. This > will allow cursor movement to be smooth, but changing cursor size or > showing/hiding curso

Re: [Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

2016-12-20 Thread Daniel Vetter
On Mon, Dec 19, 2016 at 11:15:40PM +, Pandiyan, Dhinakaran wrote: > On Sun, 2016-12-18 at 14:43 +0100, Daniel Vetter wrote: > > On Sat, Dec 17, 2016 at 05:47:56AM +, Pandiyan, Dhinakaran wrote: > > > On Fri, 2016-12-16 at 16:47 +0200, Jani Nikula wrote: > > > > On Fri, 16 Dec 2016, Daniel V

Re: [Intel-gfx] [RFC 0/4] Introduce drmfs pseudo filesystem for drm subsystem

2016-12-20 Thread Jani Nikula
On Tue, 20 Dec 2016, Laurent Pinchart wrote: > Hi Swati, > > On Monday 19 Dec 2016 16:12:22 swati.dhin...@intel.com wrote: >> From: Swati Dhingra >> >> Currently, we don't have a stable ABI which can be used for the purpose of >> providing output debug/loggging/crc and other such data from DRM.

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder

2016-12-20 Thread Ander Conselvan De Oliveira
On Mon, 2016-12-19 at 19:35 +0200, Jani Nikula wrote: > On Mon, 19 Dec 2016, ville.syrj...@linux.intel.com wrote: > > > > From: Ville Syrjälä > > > > Let's clean up the mess we have in the if ladder that assigns the > > .get_cdclk() hooks. The grouping of the platforms by the function > > result

Re: [Intel-gfx] [PATCH] drm/i915: More reasonable memcpy unroll in i915_gem_swizzle_page

2016-12-20 Thread Tvrtko Ursulin
On 19/12/2016 10:32, Jani Nikula wrote: On Mon, 19 Dec 2016, Joonas Lahtinen wrote: On ma, 2016-12-19 at 09:19 +, Tvrtko Ursulin wrote: +++ b/drivers/gpu/drm/i915/i915_gem_fence_reg.c @@ -631,9 +631,9 @@ i915_gem_swizzle_page(struct page *page) vaddr = kmap(page); for (i

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: use rb_entry()

2016-12-20 Thread Daniel Vetter
On Mon, Dec 19, 2016 at 10:43:49PM +0800, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Not sure a direct alias for container_of is all that useful, but we have list_entry too ... Queued up for 4.1

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder

2016-12-20 Thread Jani Nikula
On Tue, 20 Dec 2016, Ander Conselvan De Oliveira wrote: > On Mon, 2016-12-19 at 19:35 +0200, Jani Nikula wrote: >> On Mon, 19 Dec 2016, ville.syrj...@linux.intel.com wrote: >> > >> > From: Ville Syrjälä >> > >> > Let's clean up the mess we have in the if ladder that assigns the >> > .get_cdclk(

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder

2016-12-20 Thread Ander Conselvan De Oliveira
On Tue, 2016-12-20 at 12:08 +0200, Jani Nikula wrote: > On Tue, 20 Dec 2016, Ander Conselvan De Oliveira wrote: > > > > On Mon, 2016-12-19 at 19:35 +0200, Jani Nikula wrote: > > > > > > On Mon, 19 Dec 2016, ville.syrj...@linux.intel.com wrote: > > > > > > > > > > > > From: Ville Syrjälä > > >

Re: [Intel-gfx] [PATCH i-g-t v1] tests/perf: Fix pointer length compilation errors on 32-bit systems

2016-12-20 Thread Chris Wilson
On Tue, Dec 20, 2016 at 12:48:38AM -0500, Robert Foss wrote: > Fix pointer length compilations errors on 32-bit systems. That's fine, but considering to_user_pointer() to wrap it up similarly to the unwrap on the kernel side (and for everyone ofc). static inline uint64_t to_user_pointer(void *ptr

[Intel-gfx] [PATCH] drm/i915/breadcrumbs: s/container_of/rb_entry/

2016-12-20 Thread Chris Wilson
In keeping with commit f802cf7e0986 ("drm/i915/debugfs: use rb_entry()"), convert the primary user of the rbtrees over to using rb_entry rather than the equivalent container_of. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_breadcrumbs.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Intel-gfx] [PATCH] drm/i915/debugfs: use rb_entry()

2016-12-20 Thread Geliang Tang
To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang --- drivers/gpu/drm/i915/i915_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_d

Re: [Intel-gfx] [PATCH] drm/i915: Remove useless VLV_FEATURE Macro.

2016-12-20 Thread Daniel Vetter
On Mon, Dec 19, 2016 at 01:55:08PM -0800, Rodrigo Vivi wrote: > This macro got useless after commit 8d9c20e1d1e38 > "drm/i915: Remove .is_mobile field from platform struct" > > that removed is_mobile split from VLV definition. > Also this was never reused on any following platform. > > So let's c

Re: [Intel-gfx] [PATCH] drm/i915/breadcrumbs: s/container_of/rb_entry/

2016-12-20 Thread Daniel Vetter
On Tue, Dec 20, 2016 at 10:40:03AM +, Chris Wilson wrote: > In keeping with commit f802cf7e0986 ("drm/i915/debugfs: use > rb_entry()"), convert the primary user of the rbtrees over to using > rb_entry rather than the equivalent container_of. > > Signed-off-by: Chris Wilson Reviewed-by: Danie

Re: [Intel-gfx] [PATCH i-g-t v1] tests/perf: Fix pointer length compilation errors on 32-bit systems

2016-12-20 Thread Robert Foss
On 2016-12-20 05:28 AM, Chris Wilson wrote: On Tue, Dec 20, 2016 at 12:48:38AM -0500, Robert Foss wrote: Fix pointer length compilations errors on 32-bit systems. That's fine, but considering to_user_pointer() to wrap it up similarly to the unwrap on the kernel side (and for everyone ofc).

[Intel-gfx] [PATCH i-g-t v2] tests/perf: Fix pointer length compilation errors on 32-bit systems

2016-12-20 Thread Robert Foss
Fix pointer length compilations errors on 32-bit systems. Signed-off-by: Robert Foss --- tests/perf.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 87df9f00..c9c5c57e 100644 --- a/tests/perf.c ++

Re: [Intel-gfx] [PATCH i-g-t v2] tests/perf: Fix pointer length compilation errors on 32-bit systems

2016-12-20 Thread Robert Foss
I didn't test v2 properly and it is lacking an include. I will resubmit a working version in a little bit. Rob. On 2016-12-20 05:56 AM, Robert Foss wrote: Fix pointer length compilations errors on 32-bit systems. Signed-off-by: Robert Foss --- tests/perf.c | 42 +

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fallback to single PAGE_SIZE segments for DMA remapping

2016-12-20 Thread Daniel Vetter
On Mon, Dec 19, 2016 at 12:43:45PM +, Chris Wilson wrote: > If we at first do not succeed with attempting to remap our physical > pages using a coalesced scattergather list, try again with one > scattergather entry per page. This should help with swiotlb as it uses a > limited buffer size and o

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add a test that we terminate the trimmed sgtable as expected

2016-12-20 Thread Daniel Vetter
On Mon, Dec 19, 2016 at 12:43:46PM +, Chris Wilson wrote: > In commit 0c40ce130e38 ("drm/i915: Trim the object sg table"), we expect > to copy exactly orig_st->nents across and allocate the table thusly. > The copy loop should therefore end with the new_sg being NULL. > > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fallback to single PAGE_SIZE segments for DMA remapping

2016-12-20 Thread Tvrtko Ursulin
On 19/12/2016 12:43, Chris Wilson wrote: If we at first do not succeed with attempting to remap our physical pages using a coalesced scattergather list, try again with one scattergather entry per page. This should help with swiotlb as it uses a limited buffer size and only searches for contiguou

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add a test that we terminate the trimmed sgtable as expected

2016-12-20 Thread Tvrtko Ursulin
On 19/12/2016 12:43, Chris Wilson wrote: In commit 0c40ce130e38 ("drm/i915: Trim the object sg table"), we expect to copy exactly orig_st->nents across and allocate the table thusly. The copy loop should therefore end with the new_sg being NULL. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fallback to single PAGE_SIZE segments for DMA remapping

2016-12-20 Thread Chris Wilson
On Tue, Dec 20, 2016 at 11:13:43AM +, Tvrtko Ursulin wrote: > > On 19/12/2016 12:43, Chris Wilson wrote: > >If we at first do not succeed with attempting to remap our physical > >pages using a coalesced scattergather list, try again with one > >scattergather entry per page. This should help wi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/breadcrumbs: s/container_of/rb_entry/

2016-12-20 Thread Patchwork
== Series Details == Series: drm/i915/breadcrumbs: s/container_of/rb_entry/ URL : https://patchwork.freedesktop.org/series/17048/ State : success == Summary == Series 17048v1 drm/i915/breadcrumbs: s/container_of/rb_entry/ https://patchwork.freedesktop.org/api/1.0/series/17048/revisions/1/mbox/

[Intel-gfx] [PATCH] drm/i915/guc: Make intel_guc_recv static.

2016-12-20 Thread Michal Wajdeczko
This function is only used by intel_guc_send() and it doesn't need to be exposed outside of intel_uc.o file. Also when defined as static, compiler will generate smaller code. Additionally let it take guc param instead dev_priv to match function name. Signed-off-by: Michal Wajdeczko Cc: Joonas Lah

[Intel-gfx] [PATCH i-g-t 1/2] lib/i915_pciids.h: Update to latest version wich includes GLK ids

2016-12-20 Thread Ander Conselvan de Oliveira
Copy the include/drm/i915_pciids.h file from following kernel commit, which includes Geminilake PCI IDs. commit 8363e3c3947d0e22955f94a6a87e4f17ce5087b4 Author: Ander Conselvan de Oliveira Date: Thu Nov 10 17:23:08 2016 +0200 drm/i915/glk: Add Geminilake PCI IDs Signed-off-by: Ander Conse

[Intel-gfx] [PATCH i-g-t 2/2] lib/intel_chipset: Add geminilake platform definition

2016-12-20 Thread Ander Conselvan de Oliveira
Signed-off-by: Ander Conselvan de Oliveira --- lib/intel_chipset.h | 2 ++ lib/intel_device_info.c | 8 2 files changed, 10 insertions(+) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 3c1260b..259b45f 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -63,

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fallback to single PAGE_SIZE segments for DMA remapping

2016-12-20 Thread Chris Wilson
On Tue, Dec 20, 2016 at 11:33:27AM +, Chris Wilson wrote: > On Tue, Dec 20, 2016 at 11:13:43AM +, Tvrtko Ursulin wrote: > > How much is the cost of freeing and re-acquiring pages in the fall > > back case? It could be avoidable by using the table and adding > > something like sgt = i915_sg_

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Use drm_connector_list_iter in debugfs

2016-12-20 Thread Maarten Lankhorst
Op 19-12-16 om 09:24 schreef Daniel Vetter: > While at it also try to reduce the locking a bit to what's really just > needed instead of everything that we could possibly lock. > > Added a new for_each_intel_connector_iter which includes the cast to > intel_connector. > > Otherwise just plain trans

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/DMC/GLK: Load DMC on GLK

2016-12-20 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/DMC/GLK: Load DMC on GLK URL : https://patchwork.freedesktop.org/series/16926/ State : failure == Summary == Series 16926v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/16926/revisions/1/mbox/ Tes

Re: [Intel-gfx] [PATCH 1/2] drm/i915: skip the first 4k of stolen memory on everything >= gen8

2016-12-20 Thread Paulo Zanoni
Em Qua, 2016-12-14 às 12:55 -0200, Paulo Zanoni escreveu: > BSpec got updated and this workaround is now listed as standard > required programming for all subsequent projects. This is confirmed > to > fix Skylake screen flickering issues (probably caused by the fact > that > we initialized a ring i

[Intel-gfx] [RFCv2 01/19] drm/i915: Provide a hook for selftests

2016-12-20 Thread Chris Wilson
Some pieces of code are independent of hardware but are very tricky to exercise through the normal userspace ABI or via debugfs hooks. Being able to create mock unit tests and execute them through CI is vital. Start by adding a central point where we can execute unit tests and a parameter to enable

[Intel-gfx] [RFCv2 05/19] drm/i915: Add unit tests for the breadcrumb rbtree, completion

2016-12-20 Thread Chris Wilson
Second retroactive test, make sure that the waiters are removed from the global wait-tree when their seqno completes. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 103 + drivers/gpu/drm/i915/selftests/mock_e

[Intel-gfx] [RFCv2 02/19] kselftests: Exercise hw-independent mock tests for i915.ko

2016-12-20 Thread Chris Wilson
Although being a GPU driver most functionality of i915.ko depends upon real hardware, many of its internal interfaces can be "mocked" and so tested independently of any hardware. Expanding the test coverage is not only useful for i915.ko, but should provide some integration tests for core infrastru

[Intel-gfx] [RFCv2 03/19] drm/i915: Add some selftests for sg_table manipulation

2016-12-20 Thread Chris Wilson
Start exercising the scattergather lists, especially looking at iteration after coalescing. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c| 11 +- .../gpu/drm/i915/selftests/i915_mock_selftests.h | 1 + drivers/gpu/drm/i915/selftests/

[Intel-gfx] [RFCv2 07/19] drm/i915: Mock the GEM device for self-testing

2016-12-20 Thread Chris Wilson
Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 1 + drivers/gpu/drm/i915/selftests/mock_gem_device.c | 109 +++ drivers/gpu/drm/i915/selftests/mock_gem_device.h | 8 ++ drivers/gpu/drm/i915/selftests/mock_gem_object.h | 8 ++ 4 files c

[Intel-gfx] [RFCv2 06/19] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups

2016-12-20 Thread Chris Wilson
Third retroactive test, make sure that the seqno waiters are woken. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 169 - 1 file changed, 168 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c b

[Intel-gfx] [RFCv2 14/19] drm/i915: Move uncore selfchecks to live selftest infrastructure

2016-12-20 Thread Chris Wilson
Now that the kselftest infrastructure exists, put it to use and add to it the existing consistency checks on the fw register lookup tables. v2: s/tabke/table/ Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_uncore.c| 52 +--- .../gpu/drm/i9

[Intel-gfx] [RFCv2 16/19] drm/i915: Sanity check all registers for matching fw domains

2016-12-20 Thread Chris Wilson
Add a late selftest that walks over all forcewake registers (those below 0x4) and checks intel_uncore_forcewake_for_reg() that the look exists and we having the matching powerwells. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_uncore.c | 47 +++

[Intel-gfx] [RFCv2 19/19] drm/i915: Initial selftests for exercising eviction

2016-12-20 Thread Chris Wilson
Very simple tests to just ask eviction to find some free space in a full GTT and one with some available space. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_evict.c | 4 + drivers/gpu/drm/i915/selftests/i915_gem_evict.c| 237 + .../gpu/drm/

[Intel-gfx] [RFCv2 15/19] drm/i915: Test all fw tables during mock selftests

2016-12-20 Thread Chris Wilson
In addition to just testing the fw table we load, during the initial mock testing we can test that all tables are valid (so the testing is not limited to just the platforms that load that particular table). Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- .../gpu/drm/i915/selftests/i915_mock_

[Intel-gfx] [RFCv2 12/19] drm/i915: Add a simple fence selftest to i915_gem_request

2016-12-20 Thread Chris Wilson
Do a quick selftest on in the interoperability of dma_fence_wait on a i915_gem_request. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/selftests/i915_gem_request.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [RFCv2 13/19] drm/i915: Add selftests for object allocation, phys

2016-12-20 Thread Chris Wilson
The phys object is a rarely used device (only very old machines require a chunk of physically contiguous pages for a few hardware interactions). As such, it is not exercised by CI and to combat that we want to add a test that exercises the phys object on all platforms. Signed-off-by: Chris Wilson

[Intel-gfx] [RFCv2 17/19] drm/i915: Add some mock tests for dmabuf interop

2016-12-20 Thread Chris Wilson
Check that we can create both dmabuf and objects from dmabuf. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_dmabuf.c | 5 + drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c | 297 + .../gpu/drm/i915/selftests/i915_mock_selftests.h | 1 + dr

[Intel-gfx] [RFCv2 11/19] drm/i915: Add a simple request selftest for waiting

2016-12-20 Thread Chris Wilson
A trivial kselftest to submit a request and wait upon it. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_request.c | 44 +++ 1 file changed, 44 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_request.c b/drivers/gpu/drm/i915/selft

[Intel-gfx] [RFCv2 10/19] drm/i915: Add selftests for i915_gem_request

2016-12-20 Thread Chris Wilson
Simple starting point for adding seltests for i915_gem_request, first mock a device (with engines and contexts) that allows us to construct and execute a request, along with waiting for the request to complete. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_request.c|

[Intel-gfx] [RFCv2 04/19] drm/i915: Add unit tests for the breadcrumb rbtree, insert/remove

2016-12-20 Thread Chris Wilson
First retroactive test, make sure that the waiters are in global seqno order after random inserts and removals. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/intel_breadcrumbs.c | 21 +++ d

[Intel-gfx] [RFCv2 09/19] drm/i915: Mock infrastructure for request emission

2016-12-20 Thread Chris Wilson
Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_context.c| 4 + drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 11 +- drivers/gpu/drm/i915/selftests/mock_context.c | 95 drivers/gpu/drm/i915/selftests/mock_context.h | 34 + drivers/g

[Intel-gfx] [RFCv2 08/19] drm/i915: Mock a GGTT for self-testing

2016-12-20 Thread Chris Wilson
A very simple mockery, just a random manager and timeline. Useful for inserting objects and ordering retirement; and not much else. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++ drivers/gpu/drm/i915/selftests/mock_gem_device.c | 22 +++ drivers/gpu

Re: [Intel-gfx] [PATCH 01/14] drm/i915: Store the pipe pixel rate in the crtc state

2016-12-20 Thread Ander Conselvan De Oliveira
On Mon, 2016-12-19 at 19:28 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Rather than recomptuing the pipe pixel rate on demand everwhere, let's > just stick the precomputed value into the crtc state. > > Signed-off-by: Ville Syrjälä > --- >  drivers/gpu/drm/i915/intel_d

[Intel-gfx] [RFCv2 18/19] drm/i915: Add initial selftests for i915_gem_gtt

2016-12-20 Thread Chris Wilson
Simple starting point for adding seltests for i915_gem_gtt, first try creating a ppGTT and filling it. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c| 1 + drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 95 ++ .../gpu/drm/i915/selft

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Nuke intel_mode_max_pixclk()

2016-12-20 Thread Ander Conselvan De Oliveira
On Mon, 2016-12-19 at 19:28 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > ilk_max_pixel_rate() will now give the "correct" pixel rate for all > platforms, so let's kill rename it to intel_max_pixel_rate() and kill Typo: "kill rename". With that fixed, Reviewed-by: Ander

Re: [Intel-gfx] [PATCH 03/14] drm/i915: s/get_display_clock_speed/get_cdclk/

2016-12-20 Thread Ander Conselvan De Oliveira
On Mon, 2016-12-19 at 19:28 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Rename the .get_display_clock_speed() hook to .get_cdclk(). > .get_cdclk() is more specific (which clock) and it's much > shorter. Indeed! Reviewed-by: Ander Conselvan de Oliveira > > Signed-off

Re: [Intel-gfx] [PATCH 01/14] drm/i915: Store the pipe pixel rate in the crtc state

2016-12-20 Thread Ville Syrjälä
On Tue, Dec 20, 2016 at 03:10:53PM +0200, Ander Conselvan De Oliveira wrote: > On Mon, 2016-12-19 at 19:28 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Rather than recomptuing the pipe pixel rate on demand everwhere, let's > > just stick the precomputed value into t

Re: [Intel-gfx] [PATCH 2/6] drm/i915: use drm_connector_list_iter in intel_hotplug.c

2016-12-20 Thread Maarten Lankhorst
Op 19-12-16 om 09:24 schreef Daniel Vetter: > Nothing special, just rote conversion. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_hotplug.c | 28 ++-- > 1 file changed, 18 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_hot

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Make intel_get_pipe_from_connector atomic

2016-12-20 Thread Maarten Lankhorst
Op 19-12-16 om 09:24 schreef Daniel Vetter: > Drive-by fixup while looking at all the connector_list walkers - > holding connection_mutex does actually _not_ give you locking to look > at the legacy drm_connector->encoder->crtc pointer chain. That one is > solely owned by the atomic commit workers.

[Intel-gfx] [PATCH v2 1/2] drm: Create new structure for HDMI info

2016-12-20 Thread Shashank Sharma
This patch creates a new structure drm_hdmi_info (inspired from drm_display_info). Driver will parse HDMI sink's advance capabilities from HF-VSDB and populate this structure. This structure will be kept and used as a sub-class within drm_display_info. We are adding parsing of HF-VSDB In the next

[Intel-gfx] [PATCH v2 2/2] drm: parse hf-vsdb

2016-12-20 Thread Shashank Sharma
HDMI 2.0 / CEA-861-F specs define a new CEA extension data block, called hdmi-forum vendor specific data block (HF-VSDB). This block contains information about sink's support for HDMI 2.0 compliant features. These features are: - Deep color YUV 420 support and BPC - 3D flags for - O

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fallback to single PAGE_SIZE segments for DMA remapping

2016-12-20 Thread Tvrtko Ursulin
On 20/12/2016 12:36, Chris Wilson wrote: On Tue, Dec 20, 2016 at 11:33:27AM +, Chris Wilson wrote: On Tue, Dec 20, 2016 at 11:13:43AM +, Tvrtko Ursulin wrote: How much is the cost of freeing and re-acquiring pages in the fall back case? It could be avoidable by using the table and addi

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Update comment that sets I915_MODE_FLAG_INHERITED

2016-12-20 Thread Maarten Lankhorst
Op 19-12-16 om 09:24 schreef Daniel Vetter: > The code was moved, but the comment not updated. It confused me. > > Fixes: 7f4c62840cc4 ("drm/i915: Assign hwmode after encoder state readout") > Cc: Maarten Lankhorst > Cc: Patrik Jakobsson > Cc: Ville Syrjälä > Signed-off-by: Daniel Vetter > ---

[Intel-gfx] [PATCH] drm/i915: Use the existing pages when retrying to DMA map

2016-12-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Rather than freeing and re-allocating the pages when DMA mapping in large chunks fails, we can just rebuild the sg table with no coalescing. Also change back the page counter to unsigned int because that is what the sg API supports. Signed-off-by: Tvrtko Ursulin Cc: Chris

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder

2016-12-20 Thread Ander Conselvan De Oliveira
On Mon, 2016-12-19 at 19:28 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Let's clean up the mess we have in the if ladder that assigns the > .get_cdclk() hooks. The grouping of the platforms by the function > results in a thing that's not really legible, so let's do it th

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Make intel_guc_recv static.

2016-12-20 Thread Patchwork
== Series Details == Series: drm/i915/guc: Make intel_guc_recv static. URL : https://patchwork.freedesktop.org/series/17052/ State : success == Summary == Series 17052v1 drm/i915/guc: Make intel_guc_recv static. https://patchwork.freedesktop.org/api/1.0/series/17052/revisions/1/mbox/ Test gem

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Make intel_get_pipe_from_connector atomic

2016-12-20 Thread Daniel Vetter
On Tue, Dec 20, 2016 at 02:35:40PM +0100, Maarten Lankhorst wrote: > Op 19-12-16 om 09:24 schreef Daniel Vetter: > > Drive-by fixup while looking at all the connector_list walkers - > > holding connection_mutex does actually _not_ give you locking to look > > at the legacy drm_connector->encoder->c

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fallback to single PAGE_SIZE segments for DMA remapping

2016-12-20 Thread Chris Wilson
On Tue, Dec 20, 2016 at 01:38:16PM +, Tvrtko Ursulin wrote: > > On 20/12/2016 12:36, Chris Wilson wrote: > >On Tue, Dec 20, 2016 at 11:33:27AM +, Chris Wilson wrote: > >>On Tue, Dec 20, 2016 at 11:13:43AM +, Tvrtko Ursulin wrote: > >>>How much is the cost of freeing and re-acquiring pa

Re: [Intel-gfx] [PATCH 3/6] drm/i915: use drm_connector_list_iter in intel_opregion.c

2016-12-20 Thread Daniel Vetter
On Mon, Dec 19, 2016 at 09:24:20AM +0100, Daniel Vetter wrote: > One case where I nuked a now unecessary locking, otherwise all just > boring stuff. Forgot to update the commit message: "Note that we can't drop the connection_mutex in asle_set_backlight because the backlight functions need that (

[Intel-gfx] [PATCH] drm/i915: Use drm_connector_list_iter in debugfs

2016-12-20 Thread Daniel Vetter
While at it also try to reduce the locking a bit to what's really just needed instead of everything that we could possibly lock. Added a new for_each_intel_connector_iter which includes the cast to intel_connector. Otherwise just plain transformation with nothing special going on. v2: Review fro

Re: [Intel-gfx] [PATCH] drm/i915: Use the existing pages when retrying to DMA map

2016-12-20 Thread Chris Wilson
On Tue, Dec 20, 2016 at 01:42:47PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Rather than freeing and re-allocating the pages when DMA mapping > in large chunks fails, we can just rebuild the sg table with no > coalescing. You are freeing and reallocating the pages - I thought you m

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fallback to single PAGE_SIZE segments for DMA remapping

2016-12-20 Thread Tvrtko Ursulin
On 20/12/2016 13:56, Chris Wilson wrote: On Tue, Dec 20, 2016 at 01:38:16PM +, Tvrtko Ursulin wrote: On 20/12/2016 12:36, Chris Wilson wrote: On Tue, Dec 20, 2016 at 11:33:27AM +, Chris Wilson wrote: On Tue, Dec 20, 2016 at 11:13:43AM +, Tvrtko Ursulin wrote: How much is the cos

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFCv2,01/19] drm/i915: Provide a hook for selftests

2016-12-20 Thread Patchwork
== Series Details == Series: series starting with [RFCv2,01/19] drm/i915: Provide a hook for selftests URL : https://patchwork.freedesktop.org/series/17057/ State : success == Summary == Series 17057v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/17057/revision

[Intel-gfx] [PATCH v3] drm: Improve drm_mm search (and fix topdown allocation) with rbtrees

2016-12-20 Thread Chris Wilson
The drm_mm range manager claimed to support top-down insertion, but it was neither searching for the top-most hole that could fit the allocation request nor fitting the request to the hole correctly. In order to search the range efficiently, we create a secondary index for the holes using either t

Re: [Intel-gfx] [PATCH] drm/i915: Use the existing pages when retrying to DMA map

2016-12-20 Thread Tvrtko Ursulin
On 20/12/2016 14:14, Chris Wilson wrote: On Tue, Dec 20, 2016 at 01:42:47PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Rather than freeing and re-allocating the pages when DMA mapping in large chunks fails, we can just rebuild the sg table with no coalescing. You are freeing and real

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fallback to single PAGE_SIZE segments for DMA remapping

2016-12-20 Thread Chris Wilson
On Tue, Dec 20, 2016 at 02:14:21PM +, Tvrtko Ursulin wrote: > > On 20/12/2016 13:56, Chris Wilson wrote: > >On Tue, Dec 20, 2016 at 01:38:16PM +, Tvrtko Ursulin wrote: > >> > >>On 20/12/2016 12:36, Chris Wilson wrote: > >>>On Tue, Dec 20, 2016 at 11:33:27AM +, Chris Wilson wrote: > >>>

Re: [Intel-gfx] [PATCH v2 1/2] drm: Create new structure for HDMI info

2016-12-20 Thread Jose Abreu
Hi Shashank, On 20-12-2016 13:47, Shashank Sharma wrote: > This patch creates a new structure drm_hdmi_info (inspired from > drm_display_info). Driver will parse HDMI sink's advance capabilities > from HF-VSDB and populate this structure. This structure will be kept > and used as a sub-class with

Re: [Intel-gfx] [PATCH] drm/i915: Revert ea0000f0 "Roll out the helper nonblock tracking"

2016-12-20 Thread Jani Nikula
On Sun, 27 Nov 2016, Jim Rees wrote: > Commit eaf0 has been causing multiple problems for i915 users. See for > example: > > https://bugs.freedesktop.org/show_bug.cgi?id=96781 > https://bugs.freedesktop.org/show_bug.cgi?id=97529 > https://bugzilla.redhat.com/show_bug.cgi?id=1385228 > https://f

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/DMC/GLK: Load DMC on GLK

2016-12-20 Thread Ander Conselvan De Oliveira
On Tue, 2016-12-20 at 12:53 +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/i915/DMC/GLK: Load DMC on GLK > URL   : https://patchwork.freedesktop.org/series/16926/ > State : failure > > == Summary == > > Series 16926v1 Series without cover letter > https

Re: [Intel-gfx] [PATCH v2 2/2] drm: parse hf-vsdb

2016-12-20 Thread Jose Abreu
Hi Shashank, On 20-12-2016 13:47, Shashank Sharma wrote: > HDMI 2.0 / CEA-861-F specs define a new CEA extension data block, > called hdmi-forum vendor specific data block (HF-VSDB). This block > contains information about sink's support for HDMI 2.0 compliant > features. These features are: >

Re: [Intel-gfx] i915 regression in kernel 4.10

2016-12-20 Thread Konrad Rzeszutek Wilk
On Mon, Dec 19, 2016 at 03:16:44PM +0100, Juergen Gross wrote: > On 19/12/16 13:29, Chris Wilson wrote: > > On Mon, Dec 19, 2016 at 12:39:16PM +0100, Juergen Gross wrote: > >> With recent 4.10 kernel the graphics isn't coming up under Xen. First > >> failure message is: > >> > >> [ 46.656649] i91

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm: Create new structure for HDMI info

2016-12-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm: Create new structure for HDMI info URL : https://patchwork.freedesktop.org/series/17059/ State : success == Summary == Series 17059v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/17059/revisions/1/m

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/DMC/GLK: Load DMC on GLK

2016-12-20 Thread Chris Wilson
On Tue, Dec 20, 2016 at 04:34:20PM +0200, Ander Conselvan De Oliveira wrote: > On Tue, 2016-12-20 at 12:53 +, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [1/3] drm/i915/DMC/GLK: Load DMC on GLK > > URL   : https://patchwork.freedesktop.org/series/16926/ > > S

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/DMC/GLK: Load DMC on GLK

2016-12-20 Thread Ander Conselvan De Oliveira
On Tue, 2016-12-20 at 14:46 +, Chris Wilson wrote: > On Tue, Dec 20, 2016 at 04:34:20PM +0200, Ander Conselvan De Oliveira wrote: > > > > On Tue, 2016-12-20 at 12:53 +, Patchwork wrote: > > > > > > == Series Details == > > > > > > Series: series starting with [1/3] drm/i915/DMC/GLK: Load

[Intel-gfx] [PATCH] drm/i915/gen9+: Rely on VBT DDI port info for eDP detection

2016-12-20 Thread Imre Deak
There is at least one APL based system using port A in DP mode (connecting to an on-board DP->VGA adaptor). Atm we'll configure port A unconditionally as eDP which is incorrect in this case. Fix this by relying on the VBT DDI port 'internal port' flag instead on all ports GEN9 onwards. For now chic

Re: [Intel-gfx] [RFC 0/4] Introduce drmfs pseudo filesystem for drm subsystem

2016-12-20 Thread Sean Paul
On Tue, Dec 20, 2016 at 4:44 AM, Jani Nikula wrote: > On Tue, 20 Dec 2016, Laurent Pinchart > wrote: >> Hi Swati, >> >> On Monday 19 Dec 2016 16:12:22 swati.dhin...@intel.com wrote: >>> From: Swati Dhingra >>> >>> Currently, we don't have a stable ABI which can be used for the purpose of >>> pr

Re: [Intel-gfx] [PATCH] drm/i915/gen9+: Rely on VBT DDI port info for eDP detection

2016-12-20 Thread Ville Syrjälä
On Tue, Dec 20, 2016 at 05:12:49PM +0200, Imre Deak wrote: > There is at least one APL based system using port A in DP mode > (connecting to an on-board DP->VGA adaptor). Atm we'll configure port A > unconditionally as eDP which is incorrect in this case. Fix this by > relying on the VBT DDI port '

[Intel-gfx] [PATCH] drm/i915: Move the min_pixclk[] handling to the end of readout

2016-12-20 Thread ville . syrjala
From: Ville Syrjälä Trying to determine the pixel rate of the pipe can't be done until we know the clock, which means it can't be done until the encoder .get_config() hooks have been called. So let's move the min_pixclk[] stuff to the end of intel_modeset_readout_hw_state() when we actually have

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use the existing pages when retrying to DMA map

2016-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Use the existing pages when retrying to DMA map URL : https://patchwork.freedesktop.org/series/17061/ State : failure == Summary == Series 17061v1 drm/i915: Use the existing pages when retrying to DMA map https://patchwork.freedesktop.org/api/1.0/series/1

Re: [Intel-gfx] [PATCH] drm/i915/gen9+: Rely on VBT DDI port info for eDP detection

2016-12-20 Thread David Weinehall
On Tue, Dec 20, 2016 at 05:12:49PM +0200, Imre Deak wrote: > There is at least one APL based system using port A in DP mode > (connecting to an on-board DP->VGA adaptor). Atm we'll configure port A > unconditionally as eDP which is incorrect in this case. Fix this by > relying on the VBT DDI port '

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with drm/i915: Use drm_connector_list_iter in debugfs (rev3)

2016-12-20 Thread Patchwork
== Series Details == Series: series starting with drm/i915: Use drm_connector_list_iter in debugfs (rev3) URL : https://patchwork.freedesktop.org/series/16979/ State : warning == Summary == Series 16979v3 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/16979/revis

Re: [Intel-gfx] [PATCH] drm/i915/gen9+: Rely on VBT DDI port info for eDP detection

2016-12-20 Thread Imre Deak
On ti, 2016-12-20 at 18:02 +0200, David Weinehall wrote: > On Tue, Dec 20, 2016 at 05:12:49PM +0200, Imre Deak wrote: > > There is at least one APL based system using port A in DP mode > > (connecting to an on-board DP->VGA adaptor). Atm we'll configure port A > > unconditionally as eDP which is in

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,01/38] drm/i915: Use the MRU stack search after evicting (rev6)

2016-12-20 Thread Patchwork
== Series Details == Series: series starting with [v3,01/38] drm/i915: Use the MRU stack search after evicting (rev6) URL : https://patchwork.freedesktop.org/series/16934/ State : success == Summary == Series 16934v6 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series

[Intel-gfx] [PATCH] drm/i915: Force VDD off on the new power seqeuencer before starting to use it

2016-12-20 Thread ville . syrjala
From: Ville Syrjälä Apparently some VLV BIOSen like to leave the VDD force bit enabled even for power seqeuncers that aren't properly hooked up to any port. That will result in a imbalance in the AUX power domain refcount when we stat to use said power sequencer as edp_panel_vdd_on() will not gra

Re: [Intel-gfx] i915 regression in kernel 4.10

2016-12-20 Thread Konrad Rzeszutek Wilk
On Tue, Dec 20, 2016 at 09:42:46AM -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 19, 2016 at 03:16:44PM +0100, Juergen Gross wrote: > > On 19/12/16 13:29, Chris Wilson wrote: > > > On Mon, Dec 19, 2016 at 12:39:16PM +0100, Juergen Gross wrote: > > >> With recent 4.10 kernel the graphics isn't c

Re: [Intel-gfx] [PATCH] drm/i915/guc: Make intel_guc_recv static.

2016-12-20 Thread Tvrtko Ursulin
On 20/12/2016 11:55, Michal Wajdeczko wrote: This function is only used by intel_guc_send() and it doesn't need to be exposed outside of intel_uc.o file. Also when defined as static, compiler will generate smaller code. Additionally let it take guc param instead dev_priv to match function name.

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/gen9+: Rely on VBT DDI port info for eDP detection

2016-12-20 Thread Patchwork
== Series Details == Series: drm/i915/gen9+: Rely on VBT DDI port info for eDP detection URL : https://patchwork.freedesktop.org/series/17063/ State : warning == Summary == Series 17063v1 drm/i915/gen9+: Rely on VBT DDI port info for eDP detection https://patchwork.freedesktop.org/api/1.0/seri

Re: [Intel-gfx] [PATCH v2] drm/i915/bxt: add bxt dsi gpio element support

2016-12-20 Thread Bob Paauwe
On Tue, 13 Dec 2016 16:11:20 +0200 Jani Nikula wrote: > On Mon, 05 Dec 2016, Mika Kahola wrote: > > From: Jani Nikula > > > > Request the GPIO by index through the consumer API. For now, use a quick > > hack to store the already requested ones, simply because I have no idea > > whether this act

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move the min_pixclk[] handling to the end of readout

2016-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Move the min_pixclk[] handling to the end of readout URL : https://patchwork.freedesktop.org/series/17064/ State : success == Summary == Series 17064v1 drm/i915: Move the min_pixclk[] handling to the end of readout https://patchwork.freedesktop.org/api/1.

Re: [Intel-gfx] [PATCH] drm/i915: use for_each_intel_connector_iter in intel_display.c

2016-12-20 Thread Daniel Vetter
On Mon, Dec 19, 2016 at 10:47:25AM +0100, Maarten Lankhorst wrote: > Op 19-12-16 om 10:22 schreef Daniel Vetter: > > On Mon, Dec 19, 2016 at 09:58:28AM +0100, Daniel Vetter wrote: > >> This gets rid of the last users of for_each_intel_connector(), remove > >> that too. > >> > >> The one exception i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Force VDD off on the new power seqeuencer before starting to use it

2016-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Force VDD off on the new power seqeuencer before starting to use it URL : https://patchwork.freedesktop.org/series/17068/ State : success == Summary == Series 17068v1 drm/i915: Force VDD off on the new power seqeuencer before starting to use it https://

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect

2016-12-20 Thread Pandiyan, Dhinakaran
On Tue, 2016-12-20 at 10:08 +0200, Jani Nikula wrote: > On Tue, 20 Dec 2016, Dhinakaran Pandiyan > wrote: > > From: "Navare, Manasi D" > > > > The detect_done flag was introduced in the 'commit 7d23e3c37bb3 > > ("drm/i915: Cleaning up intel_dp_hpd_pulse")' in order to avoid multiple > > detects

Re: [Intel-gfx] [PATCH 2/5] drm/i915/guc: Introduce intel_uc_init()

2016-12-20 Thread Srivatsa, Anusha
>-Original Message- >From: Hiler, Arkadiusz >Sent: Thursday, December 15, 2016 7:47 AM >To: intel-gfx@lists.freedesktop.org >Cc: Srivatsa, Anusha ; Mcgee, Jeff >; Winiarski, Michal >Subject: [PATCH 2/5] drm/i915/guc: Introduce intel_uc_init() > >We will be able to bulk call all firmware

Re: [Intel-gfx] [PATCH v2 1/2] drm: Create new structure for HDMI info

2016-12-20 Thread kbuild test robot
Hi Shashank, [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.9 next-20161220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Shashank-Sharma/drm-Create-new-structure-for

  1   2   >