Re: [Intel-gfx] [PATCH 1/5] drm/i915: Add support for DP link training compliance

2016-11-24 Thread Jani Nikula
On Thu, 24 Nov 2016, Manasi Navare wrote: > On Wed, Nov 23, 2016 at 03:07:30PM +0200, Jani Nikula wrote: >> On Tue, 22 Nov 2016, Manasi Navare wrote: >> > This patch adds support to handle automated DP compliance >> > link training test requests. This patch has been tested with >> > Unigraf DPR-1

Re: [Intel-gfx] [PATCH 2/5] drm: Check against color expansion in drm_mm_reserve_node()

2016-11-24 Thread Daniel Vetter
On Wed, Nov 23, 2016 at 02:11:15PM +, Chris Wilson wrote: > Use the color_adjust callback when reserving a node to check if > inserting a node into this hole requires any additional space, and so if > that space then conflicts with an existing allocation. > > Signed-off-by: Chris Wilson > Cc:

[Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-11-24 Thread Dave Young
I see a lot of below warning: [ 17.128256] WARNING: CPU: 1 PID: 95 at drivers/gpu/drm/i915/intel_dp.c:1062 intel_dp_aux_transfer+0x201/0x240 [i915] [ 17.128264] WARN_ON_ONCE(!msg->buffer != !msg->size) [ 17.128267] Modules linked in: [ 17.128273] kvm_intel kvm irqbypass i915 intel_gtt drm

Re: [Intel-gfx] [PATCH] drm/i915: Always load guc by default.

2016-11-24 Thread Tvrtko Ursulin
On 24/11/2016 07:13, Chris Wilson wrote: On Wed, Nov 23, 2016 at 04:52:38PM -0800, Anusha Srivatsa wrote: Remove the enable_guc_loading parameter. Load the GuC on plaforms that have GuC. All issues we found so far are related to GuC features like the command submission, but no bug is related to

Re: [Intel-gfx] [PATCH] drm/i915: Always load guc by default.

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 08:15:31AM +, Tvrtko Ursulin wrote: > > On 24/11/2016 07:13, Chris Wilson wrote: > >On Wed, Nov 23, 2016 at 04:52:38PM -0800, Anusha Srivatsa wrote: > >>Remove the enable_guc_loading parameter. Load the GuC on > >>plaforms that have GuC. All issues we found so far are r

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general. Always initialize action_lock

2016-11-24 Thread Arkadiusz Hiler
On Wed, Nov 23, 2016 at 02:27:36PM -0800, Anusha Srivatsa wrote: > From: Peter Antoine > > Rename some of the GuC fw loading code to make them more general. We > will utilise them for HuC loading as well. > s/intel_guc_fw/intel_uc_fw/g > s/GUC_FIRMWARE/UC_FIRMWARE/g > > Struct intel_gu

Re: [Intel-gfx] [PATCH] drm/i915: Always load guc by default.

2016-11-24 Thread Tvrtko Ursulin
On 24/11/2016 08:21, Chris Wilson wrote: On Thu, Nov 24, 2016 at 08:15:31AM +, Tvrtko Ursulin wrote: On 24/11/2016 07:13, Chris Wilson wrote: On Wed, Nov 23, 2016 at 04:52:38PM -0800, Anusha Srivatsa wrote: Remove the enable_guc_loading parameter. Load the GuC on plaforms that have GuC.

Re: [Intel-gfx] [PATCH] drm/i915: Always load guc by default.

2016-11-24 Thread Jani Nikula
On Thu, 24 Nov 2016, Chris Wilson wrote: > History says we will regret enabling a new piece of hw/fw without a > feature option. And history says we'll regret adding new module parameters for everything. Lose-lose. :( BR, Jani. -- Jani Nikula, Intel Open Source Technology Center _

Re: [Intel-gfx] [PATCH] drm/i915: Always load guc by default.

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 08:31:22AM +, Tvrtko Ursulin wrote: > > On 24/11/2016 08:21, Chris Wilson wrote: > >On Thu, Nov 24, 2016 at 08:15:31AM +, Tvrtko Ursulin wrote: > >> > >>On 24/11/2016 07:13, Chris Wilson wrote: > >>>On Wed, Nov 23, 2016 at 04:52:38PM -0800, Anusha Srivatsa wrote: >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Add a new connector atomic property for link status (rev4)

2016-11-24 Thread Patchwork
== Series Details == Series: drm: Add a new connector atomic property for link status (rev4) URL : https://patchwork.freedesktop.org/series/15781/ State : success == Summary == Series 15781v4 drm: Add a new connector atomic property for link status https://patchwork.freedesktop.org/api/1.0/ser

Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-11-24 Thread Jani Nikula
On Thu, 24 Nov 2016, Dave Young wrote: > I see a lot of below warning: No, we must not hide this under the carpet. There's a bug at fdo about this, and we need to fix it. BR, Jani. > [ 17.128256] WARNING: CPU: 1 PID: 95 at > drivers/gpu/drm/i915/intel_dp.c:1062 intel_dp_aux_transfer+0x201/0

Re: [Intel-gfx] [PATCH 2/5] drm: Check against color expansion in drm_mm_reserve_node()

2016-11-24 Thread Daniel Vetter
On Wed, Nov 23, 2016 at 02:11:15PM +, Chris Wilson wrote: > Use the color_adjust callback when reserving a node to check if > inserting a node into this hole requires any additional space, and so if > that space then conflicts with an existing allocation. > > Signed-off-by: Chris Wilson > Cc:

Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-11-24 Thread Dave Young
On 11/24/16 at 10:53am, Jani Nikula wrote: > On Thu, 24 Nov 2016, Dave Young wrote: > > I see a lot of below warning: > > No, we must not hide this under the carpet. There's a bug at fdo about > this, and we need to fix it. It is not hiding it, just not repeating the warnings. But anyway I do no

[Intel-gfx] [PATCH] drm/i915/debugfs: Drop i915_hws_info

2016-11-24 Thread Chris Wilson
i915_hws_info() has not been kept upto date (missing new engines) and so I consider it to be unused. HWS is included in the error state, which would be an avenue to retrieving it if required in future (possibly via i915_engine_info). As it is currently oopsing with rpm, just remove it. Fixes: 3b3f

[Intel-gfx] [PATCH] drm/i915/debugfs: Increment return value of gt.next_seqno

2016-11-24 Thread Chris Wilson
The i915_next_seqno read value is to be the next seqno used by the kernel. However, in the conversion to atomics ops for gt.next_seqno, in commit 28176ef4cfa5 ("drm/i915: Reserve space in the global seqno during request allocation"), this was changed from a post-increment to a pre-increment. This i

Re: [Intel-gfx] [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general. Always initialize action_lock

2016-11-24 Thread Arkadiusz Hiler
On Thu, Nov 24, 2016 at 09:28:14AM +0100, Arkadiusz Hiler wrote: > On Wed, Nov 23, 2016 at 02:27:36PM -0800, Anusha Srivatsa wrote: > > From: Peter Antoine > > > > Rename some of the GuC fw loading code to make them more general. We > > will utilise them for HuC loading as well. > > s/intel_

Re: [Intel-gfx] [PATCH v6 7/8] drm/i915: Decode system memory bandwidth

2016-11-24 Thread kbuild test robot
/GEN-9-Arbitrated-Bandwidth-WM-WA-s-IPC/20161124-172826 config: x86_64-randconfig-x012-201647 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: it may well be a FALSE warning. FWIW

[Intel-gfx] [i-g-t PATCH v12 2/5] lib: add igt_dummyload

2016-11-24 Thread Abdiel Janulgue
A lot of igt testcases need some GPU workload to make sure a race window is big enough. Unfortunately having a fixed amount of workload leads to spurious test failures or overly long runtimes on some fast/slow platforms. This library contains functionality to submit GPU workloads that should consum

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: Drop i915_hws_info

2016-11-24 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Drop i915_hws_info URL : https://patchwork.freedesktop.org/series/15885/ State : success == Summary == Series 15885v1 drm/i915/debugfs: Drop i915_hws_info https://patchwork.freedesktop.org/api/1.0/series/15885/revisions/1/mbox/ fi-bdw-5557u

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/debugfs: Increment return value of gt.next_seqno

2016-11-24 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: Increment return value of gt.next_seqno URL : https://patchwork.freedesktop.org/series/15887/ State : warning == Summary == Series 15887v1 drm/i915/debugfs: Increment return value of gt.next_seqno https://patchwork.freedesktop.org/api/1.0/series/1

[Intel-gfx] drm-intel split-up and new dim script

2016-11-24 Thread Daniel Vetter
Hi all, So it's finally done, drm-misc is split out into a separate repo: https://cgit.freedesktop.org/drm-misc The integration tree and rerere-cache was also split out, so that both groups can update it: https://cgit.freedesktop.org/drm-tip To get there you need to update dim and re-run the s

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Drop i915_hws_info

2016-11-24 Thread Tvrtko Ursulin
On 24/11/2016 09:34, Chris Wilson wrote: i915_hws_info() has not been kept upto date (missing new engines) and so I consider it to be unused. HWS is included in the error state, which would be an avenue to retrieving it if required in future (possibly via i915_engine_info). As it is currently oo

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Drop i915_hws_info

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 10:54:48AM +, Tvrtko Ursulin wrote: > Per-engine files is ugly anyway, so: Yup. Pushed to drm-tip. -Chris # playing with a new toy -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lis

[Intel-gfx] [dim PATCH 4/7] dim: return exit status instead of actually exiting from url_to_remote

2016-11-24 Thread Jani Nikula
This lets us handle url_to_remote failures gracefully where they're not fatal. Signed-off-by: Jani Nikula --- dim | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dim b/dim index 98362f7784a7..ac0be0b97ea1 100755 --- a/dim +++ b/dim @@ -205,7 +205,7 @@ function url_to_re

[Intel-gfx] [dim PATCH 1/7] dim: rename rebuild-nightly to rebuild-tip

2016-11-24 Thread Jani Nikula
Keep update-branches as an alias. Signed-off-by: Jani Nikula --- dim | 5 +++-- dim.rst | 7 +++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dim b/dim index a1a821db2644..ffaadbbc5617 100755 --- a/dim +++ b/dim @@ -374,7 +374,8 @@ function dim_revert_rerere rm

[Intel-gfx] [dim PATCH 6/7] dim: silence the fetch in dim fixes

2016-11-24 Thread Jani Nikula
Messes up copy-pasting the output. Signed-off-by: Jani Nikula --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index fded4e669176..fc0bc8e68d2b 100755 --- a/dim +++ b/dim @@ -1443,7 +1443,7 @@ function dim_fixes echo "Cc: # ${tag}+"

[Intel-gfx] [dim PATCH 3/7] dim: do not do local variable assignments in declaration

2016-11-24 Thread Jani Nikula
We rely on 'set -e' to bail out on errors. We also do a lot of local variable assignments with command substitution like this: local foo=$(bar) However, that masks the return value of the command, failing to bail out on errors. Split up local variable declarations from assignments to avoi

[Intel-gfx] [dim PATCH 2/7] dim: fix references to anything "nightly" in dim and documentation

2016-11-24 Thread Jani Nikula
Reference drm-tip, use $integration_config, or just drop old/stale comments. Signed-off-by: Jani Nikula --- dim | 18 -- dim.rst | 13 - drm-intel.rst | 6 +++--- 3 files changed, 15 insertions(+), 22 deletions(-) diff --git a/dim b/dim index ffaadbb

[Intel-gfx] [dim PATCH 5/7] dim: fix list-upstreams when not in a git repo or with a drm upstream in place

2016-11-24 Thread Jani Nikula
'dim list-upstreams' is needed by bash completion and is used outside of git repos, also within git repos without drm upstream, so don't fail if it can be avoided. Signed-off-by: Jani Nikula --- dim | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dim b/dim index ac0be0b9

[Intel-gfx] [dim PATCH 7/7] dim: check positional parameter on dim fixes and cite

2016-11-24 Thread Jani Nikula
Signed-off-by: Jani Nikula --- dim | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/dim b/dim index fc0bc8e68d2b..8388a57a2ff3 100755 --- a/dim +++ b/dim @@ -1413,6 +1413,11 @@ function dim_cite local sha1 sha1=$1 + if [[ -z "$sha1" ]]; then

Re: [Intel-gfx] drm-intel split-up and new dim script

2016-11-24 Thread Jani Nikula
On Thu, 24 Nov 2016, Daniel Vetter wrote: > To get there you need to update dim and re-run the setup steps: Perhaps needless to say, but please report any hickups you see immediately on IRC and/or in reply to this mail! Thanks, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/debugfs: Increment return value of gt.next_seqno

2016-11-24 Thread Saarinen, Jani
> == Series Details == > > Series: drm/i915/debugfs: Increment return value of gt.next_seqno > URL : https://patchwork.freedesktop.org/series/15887/ > State : warning > > == Summary == > > Series 15887v1 drm/i915/debugfs: Increment return value of > gt.next_seqno > https://patchwork.freedeskto

Re: [Intel-gfx] [PATCH] drm/i915: kick out cmd_parser specific structs from i915_drv.h

2016-11-24 Thread Joonas Lahtinen
On ke, 2016-11-23 at 23:02 +, Matthew Auld wrote: > No sense in keeping the cmd_descriptor and cmd_table structs in > i915_drv.h, now that they are no longer referenced externally. > > Cc: Chris Wilson > Signed-off-by: Matthew Auld Looks good, just what i915_drv.h needs. Reviewed-by: Joona

[Intel-gfx] [PATCH 0/4] GuC code reorganization

2016-11-24 Thread Arkadiusz Hiler
With HuC being imminent we could benefit from some code reorganization. There will be more uC than just GuC so we should name files accordingly. There is also need to use host2guc_*() family of functions, which are currently limited to submission only. Arkadiusz Hiler (4): drm/i915: Rename inte

[Intel-gfx] [PATCH 2/4] drm/i915/guc: Move host2guc_*() to intel_uc.c

2016-11-24 Thread Arkadiusz Hiler
host2guc_*() series of functions were introduced in the i915_guc_submission.c and their scope was limited only to that file. Those are not submission specific though. Signed-off-by: Arkadiusz Hiler Cc: Chris Wilson Cc: Michal Winiarski --- drivers/gpu/drm/i915/Makefile | 3 +-

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: kick out cmd_parser specific structs from i915_drv.h

2016-11-24 Thread Joonas Lahtinen
On ke, 2016-11-23 at 23:46 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: kick out cmd_parser specific structs from > i915_drv.h > URL   : https://patchwork.freedesktop.org/series/15854/ > State : success Reviewed and merged, thanks for the patch. Chris acked this in IRC. R

[Intel-gfx] [PATCH 3/4] drm/i915/guc: Init action_lock in the loader

2016-11-24 Thread Arkadiusz Hiler
Action_lock is a mutex used to serialise communication with GuC. Since some functions which utilize the mutex (host2guc_*()) are no longer limited to submission, initialization should be handled as a part of GuC setup. Signed-off-by: Arkadiusz Hiler Cc: Chris Wilson Cc: Michal Winiarski ---

[Intel-gfx] [PATCH] drm/i915: Use the precomputed value for whether to enable command parsing

2016-11-24 Thread Chris Wilson
As i915.enable_cmd_parser is an unsafe option, make it read-only at runtime. Now that it is constant, we can use the value determined during initialisation as to whether we need the cmdparser at execbuffer time. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_cmd_parser.c | 21 ---

[Intel-gfx] [PATCH 4/4] drm/i915/guc: Remove spurious include

2016-11-24 Thread Arkadiusz Hiler
Signed-off-by: Arkadiusz Hiler Cc: Chris Wilson Cc: Michal Winiarski --- drivers/gpu/drm/i915/i915_guc_submission.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c index 7c20721..aefe0dd 100644 --- a/dri

[Intel-gfx] [PATCH 1/4] drm/i915: Rename intel_guc.h to intel_uc.h

2016-11-24 Thread Arkadiusz Hiler
GuC is not the only one micro controller we have. There are also HuC and DMC. Making the file more general will help with code organization. Signed-off-by: Arkadiusz Hiler Cc: Chris Wilson Cc: Michal Winiarski --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Mark all non-vma being inserted into the address spaces

2016-11-24 Thread Joonas Lahtinen
On ke, 2016-11-23 at 14:11 +, Chris Wilson wrote: > We need to distinguish between full i915_vma structs and simple > drm_mm_nodes when considering eviction (i.e. we must be careful not to > treat a mere drm_mm_node as a much larger i915_vma causing memory > corruption, if we are lucky). To do

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-24 Thread Joonas Lahtinen
On ke, 2016-11-23 at 14:11 +, Chris Wilson wrote: > Soft-pinning depends upon being able to check for availabilty of an > interval and evict overlapping object from a drm_mm range manager very > quickly. Currently it uses a linear list, and so performance is dire and > not suitable as a general

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Tidy i915_gem_valid_gtt_space()

2016-11-24 Thread Joonas Lahtinen
On ke, 2016-11-23 at 14:11 +, Chris Wilson wrote: > We can replace a couple of tests with an assertion that the passed in > node is already allocated (as matches the existing call convention) and > by a small bit of refactoring we can bring the line lengths to under > 80cols. > > Signed-off-by

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 01:45:12PM +0200, Joonas Lahtinen wrote: > On ke, 2016-11-23 at 14:11 +, Chris Wilson wrote: > > Soft-pinning depends upon being able to check for availabilty of an > > interval and evict overlapping object from a drm_mm range manager very > > quickly. Currently it uses

Re: [Intel-gfx] [PATCH i-g-t 2/4 v6] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

2016-11-24 Thread Marius Vlad
On Wed, Nov 23, 2016 at 01:31:21PM +, Chris Wilson wrote: > On Wed, Nov 23, 2016 at 02:35:10PM +0200, Marius Vlad wrote: > > v2: > > - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) > > - do not hard-fail when i915 module could not be loaded/unloaded (Chris > > Wilson) > > > > Si

Re: [Intel-gfx] [PATCH i-g-t 2/4 v6] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 02:04:38PM +0200, Marius Vlad wrote: > On Wed, Nov 23, 2016 at 01:31:21PM +, Chris Wilson wrote: > > On Wed, Nov 23, 2016 at 02:35:10PM +0200, Marius Vlad wrote: > > > v2: > > > - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) > > > - do not hard-fail when

Re: [Intel-gfx] [PATCH 0/4] GuC code reorganization

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 12:30:39PM +0100, Arkadiusz Hiler wrote: > With HuC being imminent we could benefit from some code reorganization. > There will be more uC than just GuC so we should name files accordingly. > > There is also need to use host2guc_*() family of functions, which are > current

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Increment return value of gt.next_seqno

2016-11-24 Thread Joonas Lahtinen
On to, 2016-11-24 at 09:47 +, Chris Wilson wrote: > The i915_next_seqno read value is to be the next seqno used by the > kernel. However, in the conversion to atomics ops for gt.next_seqno, in > commit 28176ef4cfa5 ("drm/i915: Reserve space in the global seqno during > request allocation"), thi

Re: [Intel-gfx] [PATCH] drm/i915: Use the precomputed value for whether to enable command parsing

2016-11-24 Thread Joonas Lahtinen
On to, 2016-11-24 at 11:31 +, Chris Wilson wrote: > As i915.enable_cmd_parser is an unsafe option, make it read-only at > runtime. Now that it is constant, we can use the value determined during > initialisation as to whether we need the cmdparser at execbuffer time. > > Signed-off-by: Chris W

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Increment return value of gt.next_seqno

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 02:15:07PM +0200, Joonas Lahtinen wrote: > On to, 2016-11-24 at 09:47 +, Chris Wilson wrote: > > The i915_next_seqno read value is to be the next seqno used by the > > kernel. However, in the conversion to atomics ops for gt.next_seqno, in > > commit 28176ef4cfa5 ("drm/i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the precomputed value for whether to enable command parsing

2016-11-24 Thread Patchwork
== Series Details == Series: drm/i915: Use the precomputed value for whether to enable command parsing URL : https://patchwork.freedesktop.org/series/15897/ State : success == Summary == Series 15897v1 drm/i915: Use the precomputed value for whether to enable command parsing https://patchwor

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Increment return value of gt.next_seqno

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 02:15:07PM +0200, Joonas Lahtinen wrote: > On to, 2016-11-24 at 09:47 +, Chris Wilson wrote: > > The i915_next_seqno read value is to be the next seqno used by the > > kernel. However, in the conversion to atomics ops for gt.next_seqno, in > > commit 28176ef4cfa5 ("drm/i

Re: [Intel-gfx] [PATCH v6 2/8] drm/i915/bxt: IPC WA for Broxton

2016-11-24 Thread Lankhorst, Maarten
Mahesh Kumar schreef op do 24-11-2016 om 09:31 [+0530]: > If IPC is enabled in BXT, display underruns are observed. > WA: The Line Time programmed in the WM_LINETIME register should be > half of the actual calculated Line Time. > > Programmed Line Time = 1/2*Calculated Line Time > > Signed-off-by

Re: [Intel-gfx] [PATCH v6 8/8] drm/i915/gen9: WM memory bandwidth related workaround

2016-11-24 Thread Lankhorst, Maarten
Mahesh Kumar schreef op do 24-11-2016 om 09:31 [+0530]: > This patch implemnets Workariunds related to display arbitrated > memory > bandwidth. These WA are applicabe for all gen-9 based platforms. > > Changes since v1: >  - Rebase on top of Paulo's patch series > Changes since v2: >  - Address re

[Intel-gfx] [PATCH v2] drm/i915: Use the precomputed value for whether to enable command parsing

2016-11-24 Thread Chris Wilson
As i915.enable_cmd_parser is an unsafe option, make it read-only at runtime. Now that it is constant, we can use the value determined during initialisation as to whether we need the cmdparser at execbuffer time. v2: Remove the inline for its single user, it is clear enough (and shorter) without!

[Intel-gfx] [PATCH] drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton

2016-11-24 Thread Ander Conselvan de Oliveira
The check in __intel_uncore_early_sanitize() to disable decoupled mmio would disable it for every platform that is not broxton. While that's not a problem now since only broxton supports that, simply setting .has_decoupled_mmio in a new platform's device info wouldn't suffice. So avoid future confu

[Intel-gfx] [PATCH 1/2] drm/i915: Rename i915_gem_timeline.next_seqno to .seqno

2016-11-24 Thread Joonas Lahtinen
Rename i915_gem_timeline member 'next_seqno' into 'seqno' as the variable is pre-increment. We've already had two bugs due to the confusing name, second is fixed as follow-up patch. Cc: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- drivers/g

[Intel-gfx] [PATCH 2/2] drm/i915: Fix off-by-one error on debug

2016-11-24 Thread Joonas Lahtinen
We now clearly see that in order to get next seqno we need to add one. Cc: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_deb

[Intel-gfx] [PATCH v2] drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton

2016-11-24 Thread Ander Conselvan de Oliveira
The check in __intel_uncore_early_sanitize() to disable decoupled mmio would disable it for every platform that is not broxton. While that's not a problem now since only broxton supports that, simply setting .has_decoupled_mmio in a new platform's device info wouldn't suffice. So avoid future confu

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix off-by-one error on debug

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 03:22:10PM +0200, Joonas Lahtinen wrote: > We now clearly see that in order to get next seqno we need to add one. > > Cc: Chris Wilson > Signed-off-by: Joonas Lahtinen > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rename i915_gem_timeline.next_seqno to .seqno

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 03:22:09PM +0200, Joonas Lahtinen wrote: > Rename i915_gem_timeline member 'next_seqno' into 'seqno' as > the variable is pre-increment. We've already had two bugs due > to the confusing name, second is fixed as follow-up patch. > > Cc: Chris Wilson > Signed-off-by: Joonas

Re: [Intel-gfx] [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver

2016-11-24 Thread Ville Syrjälä
On Fri, Nov 25, 2016 at 05:25:42AM +0530, Jerome Anand wrote: > Enable support for HDMI LPE audio mode on Baytrail and > Cherrytrail when HDaudio controller is not detected > > Setup minimum required resources during i915_driver_load: > 1. Create a platform device to share MMIO/IRQ resources > 2.

Re: [Intel-gfx] [RFC PATCH v3 2/7] drm/i915: Add support for audio driver notifications

2016-11-24 Thread Ville Syrjälä
On Fri, Nov 25, 2016 at 05:25:43AM +0530, Jerome Anand wrote: > Notifiations like mode change, hot plug and edid to > the audio driver are added. This is inturn used by the > audio driver for its functionality. > > A new interface file capturing the notifications needed by the > audio driver is ad

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the precomputed value for whether to enable command parsing (rev2)

2016-11-24 Thread Patchwork
== Series Details == Series: drm/i915: Use the precomputed value for whether to enable command parsing (rev2) URL : https://patchwork.freedesktop.org/series/15897/ State : success == Summary == Series 15897v2 drm/i915: Use the precomputed value for whether to enable command parsing https://p

[Intel-gfx] [PATCH igt] igt/gem_exec_parse: generalise test_lri + debug info

2016-11-24 Thread Robert Bragg
This further generalises the description passed to test_lri so we only need one loop over the entries with test_lri deducing the exected errno and value based on whether the register is marked as whitelisted and depending on the current command parser version. Each tested register LRI now test get

[Intel-gfx] [PATCH] drm/i915/debugfs: Update pageflip information

2016-11-24 Thread Chris Wilson
Show the last submitted seqno to the engine, not the overall next seqno, as this is more pertinent information when inspecting the pageflip and whether the CS or display engine stalled. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the precomputed value for whether to enable command parsing (rev2)

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 01:45:36PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Use the precomputed value for whether to enable command > parsing (rev2) > URL : https://patchwork.freedesktop.org/series/15897/ > State : success > > == Summary == > > Series 15897v2 drm/i

Re: [Intel-gfx] [PATCH 3/5] drm/i915/bxt: Added _DSM call to set HPD_CTL.

2016-11-24 Thread Jani Nikula
On Wed, 23 Nov 2016, Animesh Manna wrote: > _DSM is added to program HPD_CTL(0x1094) register > of PMC from i915 driver which will be called > based on driver feature flag. PMC hpd control register > programming will enable PMC to get hpd interrupt > during dc9. > > Signed-off-by: Animesh Manna >

Re: [Intel-gfx] [PATCH 2/5] drm/i915/bxt: VBT changes for hpd as wakeup feature

2016-11-24 Thread Jani Nikula
On Wed, 23 Nov 2016, Animesh Manna wrote: > To support hpd during sleep a new feature flag is > added in vbt and also in dev_priv for enabling/disabling > inside driver. By default this feature will be > disabled and based on oem request this feature can > be enabled by changing vbt feature flag.

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_parse: generalise test_lri + debug info

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 01:47:46PM +, Robert Bragg wrote: > This further generalises the description passed to test_lri so we only > need one loop over the entries with test_lri deducing the exected errno > and value based on whether the register is marked as whitelisted and > depending on the

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton (rev2)

2016-11-24 Thread Patchwork
== Series Details == Series: drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton (rev2) URL : https://patchwork.freedesktop.org/series/15902/ State : warning == Summary == Series 15902v2 drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton https://patchwo

[Intel-gfx] [CI 2/2] drm/i915/debugfs: Update pageflip information

2016-11-24 Thread Chris Wilson
Show the last submitted seqno to the engine, not the overall next seqno, as this is more pertinent information when inspecting the pageflip and whether the CS or display engine stalled. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+),

[Intel-gfx] [CI 1/2] drm/i915: Rename i915_gem_timeline.next_seqno to .seqno

2016-11-24 Thread Chris Wilson
From: Joonas Lahtinen Rename i915_gem_timeline member 'next_seqno' into 'seqno' as the variable is pre-increment. We've already had two bugs due to the confusing name, second is fixed as follow-up patch. Cc: Chris Wilson Signed-off-by: Joonas Lahtinen Reviewed-by: Chris Wilson Signed-off-by:

Re: [Intel-gfx] drm-intel split-up and new dim script

2016-11-24 Thread Daniel Vetter
On Thu, Nov 24, 2016 at 11:48 AM, Daniel Vetter wrote: > $ cd $DIM_PREFIX $ rm drm-intel-rerere drm-intel-nightly maintainer-tools > -Rf If you are using git worktree already (manually set up, dim only does this since today) then there's a bit more cleanup required: $ cd $DIM_PREFIX/DIM_DRM_INTE

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton (rev2)

2016-11-24 Thread Saarinen, Jani
> == Series Details == > > Series: drm/i915: Don't sanitize has_decoupled_mmio if platform is not > broxton (rev2) > URL : https://patchwork.freedesktop.org/series/15902/ > State : warning > > == Summary == > > Series 15902v2 drm/i915: Don't sanitize has_decoupled_mmio if platform > is not bro

Re: [Intel-gfx] [dim PATCH 6/7] dim: silence the fetch in dim fixes

2016-11-24 Thread Daniel Vetter
On Thu, Nov 24, 2016 at 01:20:39PM +0200, Jani Nikula wrote: > Messes up copy-pasting the output. > > Signed-off-by: Jani Nikula > --- > dim | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dim b/dim > index fded4e669176..fc0bc8e68d2b 100755 > --- a/dim > +++ b/dim > @@

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton (rev2)

2016-11-24 Thread Ville Syrjälä
On Thu, Nov 24, 2016 at 03:09:30PM +, Saarinen, Jani wrote: > > == Series Details == > > > > Series: drm/i915: Don't sanitize has_decoupled_mmio if platform is not > > broxton (rev2) > > URL : https://patchwork.freedesktop.org/series/15902/ > > State : warning > > > > == Summary == > > > >

[Intel-gfx] [dim PATCH v2 1/7] dim: rename rebuild-nightly to rebuild-tip

2016-11-24 Thread Jani Nikula
Keep update-branches as an alias. Signed-off-by: Jani Nikula --- dim | 5 +++-- dim.rst | 7 +++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dim b/dim index 0c48e1e404f7..0acfb59a3fc2 100755 --- a/dim +++ b/dim @@ -376,7 +376,8 @@ function dim_revert_rerere rm

[Intel-gfx] [dim PATCH v2 2/7] dim: fix references to anything "nightly" in dim and documentation

2016-11-24 Thread Jani Nikula
Reference drm-tip, use $integration_config, or just drop old/stale comments. Signed-off-by: Jani Nikula --- dim | 18 -- dim.rst | 13 - drm-intel.rst | 6 +++--- 3 files changed, 15 insertions(+), 22 deletions(-) diff --git a/dim b/dim index 0acfb59

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Increase PCODE CDCLK change notify timeout

2016-11-24 Thread Imre Deak
commit 848496e5902833600f7992f4faa82dc1546051ba Author: Ville Syrjälä Date: Wed Jul 13 16:32:03 2016 +0300 drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on SKL increased the timeout to match the spec, but we still see a timeout on at least one SKL. A CDCLK change req

[Intel-gfx] [PATCH 1/2] drm/i915/gen6+: Clear upper data byte during PCODE write

2016-11-24 Thread Imre Deak
The spec calls for the upper data byte to be cleared before most of the PCODE write commands, for others like IPS control it doesn't say anything about this byte. Let's clear it in case it's clobbered somehow, especially that there are places where we only do a PCODE write without a preceeding PCOD

[Intel-gfx] [dim PATCH v2 3/7] dim: do not do local variable assignments in declaration

2016-11-24 Thread Jani Nikula
We rely on 'set -e' to bail out on errors. We also do a lot of local variable assignments with command substitution like this: local foo=$(bar) However, that masks the return value of the command, failing to bail out on errors. Split up local variable declarations from assignments to avoi

[Intel-gfx] [dim PATCH v2 7/7] dim: unify rebuild fetch/merge messages

2016-11-24 Thread Jani Nikula
Signed-off-by: Jani Nikula --- dim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dim b/dim index 69c22f6206f0..2b58a0cd7ddc 100755 --- a/dim +++ b/dim @@ -420,7 +420,7 @@ function dim_rebuild_tip for repo in "${!drm_tip_repos[@]}"; do url=${drm_tip_re

[Intel-gfx] [dim PATCH v2 6/7] dim: check positional parameter on dim fixes and cite

2016-11-24 Thread Jani Nikula
Signed-off-by: Jani Nikula --- dim | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/dim b/dim index 76e129de873d..69c22f6206f0 100755 --- a/dim +++ b/dim @@ -1419,6 +1419,11 @@ function dim_cite local sha1 sha1=$1 + if [[ -z "$sha1" ]]; then

[Intel-gfx] [dim PATCH v2 5/7] dim: fix list-upstreams when not in a git repo or with a drm upstream in place

2016-11-24 Thread Jani Nikula
'dim list-upstreams' is needed by bash completion and is used outside of git repos, also within git repos without drm upstream, so don't fail if it can be avoided. Signed-off-by: Jani Nikula --- dim | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dim b/dim index 3c7b6fc1

[Intel-gfx] [dim PATCH v2 4/7] dim: return exit status instead of actually exiting from url_to_remote

2016-11-24 Thread Jani Nikula
This lets us handle url_to_remote failures gracefully where they're not fatal. Our use of 'set -e' guarantees this will bail out otherwise. Signed-off-by: Jani Nikula --- dim | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dim b/dim index 1d52d509450d..3c7b6fc1343b 1007

[Intel-gfx] [RFC PATCH] drm/i915: Add a cursor hack to allow converting legacy page flip to atomic.

2016-11-24 Thread Maarten Lankhorst
Do something similar to vc4, only allow updating the cursor state in-place through a fastpath when the watermarks are unaffected. This will allow cursor movement to be smooth, but changing cursor size or showing/hiding cursor will still fall back so watermarks can be updated. Not completely tested

Re: [Intel-gfx] [dim PATCH v2 3/7] dim: do not do local variable assignments in declaration

2016-11-24 Thread Jani Nikula
On Thu, 24 Nov 2016, Jani Nikula wrote: > @@ -852,18 +876,24 @@ function dim_conf > # $1 is the git sha1 to check > function checkpatch_commit > { > - local commit=$1 > - local cmd="git show --pretty=email $commit" > + local commit cmd bug_lines non_i915_files > + > + commit=$1

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen6+: Clear upper data byte during PCODE write

2016-11-24 Thread Chris Wilson
On Thu, Nov 24, 2016 at 05:32:58PM +0200, Imre Deak wrote: > The spec calls for the upper data byte to be cleared before most of the > PCODE write commands, for others like IPS control it doesn't say > anything about this byte. Let's clear it in case it's clobbered somehow, > especially that there

Re: [Intel-gfx] [PATCH v3] drm/i915/audio: fix hdmi audio noise issue

2016-11-24 Thread Jani Nikula
On Fri, 11 Nov 2016, libin.y...@intel.com wrote: > From: Libin Yang > > Some monitors will have noise or even no sound after > applying the patch 6014ac12. > > In patch 6014ac12, it will reset the cts value to 0 for HDMI. > However, we need to disable Enable CTS or M Prog bit. This is > the initia

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton (rev2)

2016-11-24 Thread Saarinen, Jani
> == Series Details == > > Series: drm/i915: Don't sanitize has_decoupled_mmio if platform is not > broxton (rev2) > URL : https://patchwork.freedesktop.org/series/15902/ > State : warning > > == Summary == > > Series 15902v2 drm/i915: Don't sanitize has_decoupled_mmio if platform > is not bro

Re: [Intel-gfx] [PATCH] drm/i915: Don't sanitize has_decoupled_mmio if platform is not broxton

2016-11-24 Thread Imre Deak
On to, 2016-11-24 at 15:17 +0200, Ander Conselvan de Oliveira wrote: > The check in __intel_uncore_early_sanitize() to disable decoupled mmio > would disable it for every platform that is not broxton. While that's > not a problem now since only broxton supports that, simply setting > .has_decoupled

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen6+: Clear upper data byte during PCODE write

2016-11-24 Thread Ville Syrjälä
On Thu, Nov 24, 2016 at 05:32:58PM +0200, Imre Deak wrote: > The spec calls for the upper data byte to be cleared before most of the > PCODE write commands, for others like IPS control it doesn't say > anything about this byte. Let's clear it in case it's clobbered somehow, > especially that there

[Intel-gfx] [PATCH v2 0/5] GuC code reorganization

2016-11-24 Thread Arkadiusz Hiler
With HuC being imminent we could benefit from some code reorganization. There will be more uC than just GuC so we should name files accordingly. There is also need to use host2guc_*() family of functions, which are currently limited to submission only. In effect host2guc and guc2host entities wer

[Intel-gfx] [PATCH 5/5] drm/i915/guc: Remove spurious include

2016-11-24 Thread Arkadiusz Hiler
Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Arkadiusz Hiler Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_guc_submission.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c index 0f09d5

[Intel-gfx] [PATCH 2/5] drm/i915/guc: Drop guc2host/host2guc from names

2016-11-24 Thread Arkadiusz Hiler
To facilitate code reorganization we are renaming everything that contains guc2host or host2guc. host2guc_action() and host2guc_action_response() become guc_send() and guc_recv() respectively. Other host2guc_*() functions become simply guc_*(). Other entities are renamed basing on context they a

[Intel-gfx] [PATCH 3/5] drm/i915/guc: Move guc_{send, recv}() to intel_uc.c

2016-11-24 Thread Arkadiusz Hiler
guc_send(), guc_recv() and related functions were introduced in the i915_guc_submission.c and their scope was limited only to that file. Those are not submission specific though. This patch moves moves them to intel_uc.c with intel_ prefix added. Cc: Chris Wilson Cc: Michal Winiarski Signed-off

[Intel-gfx] [PATCH 1/5] drm/i915: Rename intel_guc.h to intel_uc.h

2016-11-24 Thread Arkadiusz Hiler
GuC is not the only one micro controller we have. There are also HuC and DMC. Making the file more general will help with code organization. Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Arkadiusz Hiler Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h |

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Init send_mutex in intel_uc_init()

2016-11-24 Thread Arkadiusz Hiler
send_mutex is used to serialise communication with GuC via intel_guc_send(). Since functions that utilize it are no longer limited to submission, initialization should be handled as a part of general setup. Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Arkadiusz Hiler --- drivers/gpu/d

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Rename i915_gem_timeline.next_seqno to .seqno

2016-11-24 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Rename i915_gem_timeline.next_seqno to .seqno URL : https://patchwork.freedesktop.org/series/15907/ State : success == Summary == Series 15907v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15

  1   2   >