Re: [Intel-gfx] [PATCH] aubdump: Handle 48-bit relocations properly

2016-11-22 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 18/11/16 19:51, Jason Ekstrand wrote: aubdump was only writing 32-bits regardless of platform. This is fine if the client being dumped leaves the top 32 bits zero since the aubdump GTT is fairly small. However, if the client does store something in the uppe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add a per-pipe plane identifier enum (rev5)

2016-11-22 Thread Patchwork
== Series Details == Series: drm/i915: Add a per-pipe plane identifier enum (rev5) URL : https://patchwork.freedesktop.org/series/14978/ State : success == Summary == Series 14978v5 drm/i915: Add a per-pipe plane identifier enum https://patchwork.freedesktop.org/api/1.0/series/14978/revisions/

[Intel-gfx] [PATCH igt] igt/gem_exec_parse: test_lri check init + add debug msg

2016-11-22 Thread Robert Bragg
Just to note I haven't tested yet as I don't have hsw to hand, but seems simple enough to send out anyway... --- >8 --- To make it clear on failure what register was being tested the test_lri helper now uses igt_debug to log the register address and value being tested. The test_lri helper now als

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_parse: test_lri check init + add debug msg

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 04:50:35PM +, Robert Bragg wrote: > Just to note I haven't tested yet as I don't have hsw to hand, but seems > simple enough to send out anyway... > > --- >8 --- > > To make it clear on failure what register was being tested the test_lri > helper now uses igt_debug to

Re: [Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 05:22:47PM +0100, Arkadiusz Hiler wrote: > Action lock is not being initialized if the GuC submission is disabled > (i.e. i915.guc_submission=0). > > host2guc_action(), which uses the action_lock can be used for > non-submission purposes, e.g. triggering HuC authentication.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Always initialize action_lock

2016-11-22 Thread Patchwork
== Series Details == Series: drm/i915/guc: Always initialize action_lock URL : https://patchwork.freedesktop.org/series/15755/ State : failure == Summary == Series 15755v1 drm/i915/guc: Always initialize action_lock https://patchwork.freedesktop.org/api/1.0/series/15755/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH] dim: Enable --scissors by default

2016-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2016 at 05:51:20PM +0200, Jani Nikula wrote: > On Tue, 22 Nov 2016, Daniel Vetter wrote: > > I never knew this even was a thing, and plain git am cuts everything > > below the scissors line (since it matches the --- of a diffstat > > start). > > > > Cc: Robert Bragg > > Signed-off

[Intel-gfx] [drm-intel:drm-intel-next-queued 6/11] ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!

2016-11-22 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: 7abbd8d670bb928366aa94332a173aa3d394ebfe commit: d79651522e89c4ffa8992b48dfe449f0c583f809 [6/11] drm/i915: Enable i915 perf stream for Haswell OA unit config: i386-randconfig-c0-11222334 (attached as .config) compiler: g

[Intel-gfx] [PATCH] drm/i915: Make skl_write_{plane, cursor}_wm() static

2016-11-22 Thread ville . syrjala
From: Ville Syrjälä Someone forgot to make skl_write_{plane,cursor}_wm() static when removing the prototypes from the header. Sparse isn't pleased. Cc: Maarten Lankhorst Cc: Lyude Cc: Matt Roper Fixes: e62929b3f628 ("drm/i915/gen9+: Program watermarks as a separate step during evasion, v3.")

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use enum plane_id in SKL wm code

2016-11-22 Thread Lyude Paul
Looks good to me Reviewed-by: Lyude On Tue, 2016-11-22 at 18:01 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Nuke skl_wm_plane_id() and just use the new intel_plane->id. > > v2: Convert skl_write_plane_wm() as well > v3: Convert skl_pipe_wm_get_hw_state() correctly >

Re: [Intel-gfx] [PATCH] drm/i915: Make skl_write_{plane, cursor}_wm() static

2016-11-22 Thread Lyude Paul
Reviewed-by: Lyude On Tue, 2016-11-22 at 22:21 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Someone forgot to make skl_write_{plane,cursor}_wm() static when > removing the prototypes from the header. Sparse isn't pleased. > > Cc: Maarten Lankhorst > Cc: Lyude > Cc: M

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make skl_write_{plane, cursor}_wm() static

2016-11-22 Thread Patchwork
== Series Details == Series: drm/i915: Make skl_write_{plane, cursor}_wm() static URL : https://patchwork.freedesktop.org/series/15767/ State : success == Summary == Series 15767v1 drm/i915: Make skl_write_{plane, cursor}_wm() static https://patchwork.freedesktop.org/api/1.0/series/15767/revis

[Intel-gfx] [PATCH] drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Chris Wilson
Just a couple of naked 64bit divides causing link errors on 32bit builds, with: ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined! Reported-by: kbuild test robot Fixes: d79651522e89 ("drm/i915: Enable i915 perf stream for Haswell OA unit") Signed-off-by: Chris Wilson Cc: Rober

Re: [Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock

2016-11-22 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Chris Wilson >Sent: Tuesday, November 22, 2016 9:06 AM >To: Hiler, Arkadiusz >Cc: intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_l

[Intel-gfx] [PATCH 2/5] drm/i915: Fixes to support DP Compliance EDID tests

2016-11-22 Thread Manasi Navare
This patch addresses a few issues from the original patch for DP Compliance EDID test support submitted by Todd Previte Video Mode requested in the EDID test handler for the EDID Read test (CTS 4.2.2.3) should be set to PREFERRED as per the CTS spec. Signed-off-by: Manasi Navare Cc: Jani Nikula

[Intel-gfx] [PATCH 1/5] drm/i915: Add support for DP link training compliance

2016-11-22 Thread Manasi Navare
This patch adds support to handle automated DP compliance link training test requests. This patch has been tested with Unigraf DPR-120 DP Compliance device for testing Link Training Compliance. After we get a short pulse Compliance test request, test request values are read and hotplug uevent is se

[Intel-gfx] [PATCH 4/5] drm: Add definitions for DP compliance Video pattern tests

2016-11-22 Thread Manasi Navare
Cc: dri-de...@lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- include/drm/drm_dp_helper.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h in

[Intel-gfx] [PATCH 0/5] Add Automation support for DP compliance testing

2016-11-22 Thread Manasi Navare
DP 1.2 compliance testing can be acheived using DPR-120's CTS suite. This compliance unit sends a short pulse to initiate link training and video pattern generation compliance tests and sends a long pulse to initate EDID compliance tests. It also sets the AUTOMATED TEST REQUEST bit in Device IRQ to

[Intel-gfx] [PATCH 5/5] drm/i915: Add support for DP Video pattern compliance tests

2016-11-22 Thread Manasi Navare
The intel_dp_autotest_video_pattern() function gets invoked through the compliance test handler on a HPD short pulse if the test type is set to DP_TEST_VIDEO_PATTERN. This performs the DPCD registers reads to read the requested test pattern, video pattern resolution, frame rate and bits per color v

[Intel-gfx] [PATCH 3/5] Add support for forcing 6 bpc on DP pipes.

2016-11-22 Thread Manasi Navare
From: Jim Bride For DP compliance we need to be able to control the output color type for the pipe associated with the DP port. When a specific DP compliance test is requested with specific BPC value, we read the BPC value from the DPCD register and store it in the intel_dp structure. If this BPC

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Patchwork
== Series Details == Series: drm/i915/perf: Wrap 64bit divides in do_div() URL : https://patchwork.freedesktop.org/series/15769/ State : warning == Summary == Series 15769v1 drm/i915/perf: Wrap 64bit divides in do_div() https://patchwork.freedesktop.org/api/1.0/series/15769/revisions/1/mbox/

[Intel-gfx] ✓ Fi.CI.BAT: success for Add Automation support for DP compliance testing

2016-11-22 Thread Patchwork
== Series Details == Series: Add Automation support for DP compliance testing URL : https://patchwork.freedesktop.org/series/15771/ State : success == Summary == Series 15771v1 Add Automation support for DP compliance testing https://patchwork.freedesktop.org/api/1.0/series/15771/revisions/1/m

Re: [Intel-gfx] [PATCH] drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Robert Bragg
Thanks for sending out. It looked good to me, but testing shows a 'divide error'. I haven't double checked, but I think it's because the max OA exponent (31) converted to nanoseconds is > UINT32_MAX with the lower 32bits zero and the do_div denominator argument is only 32bit. It corresponds to a

Re: [Intel-gfx] [PATCH] drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 11:32:38PM +, Robert Bragg wrote: >Thanks for sending out. It looked good to me, but testing shows a 'divide >error'. > >I haven't double checked, but I think it's because the max OA exponent >(31) converted to nanoseconds is > UINT32_MAX with the lower

Re: [Intel-gfx] [PATCH] lib/debugobjects: Export for use in modules

2016-11-22 Thread Andrew Morton
On Tue, 22 Nov 2016 14:30:39 + Chris Wilson wrote: > Drivers, or other modules, that use a mixture of objects (especially > objects embedded within other objects) would like to take advantage of > the debugobjects facilities to help catch misuse. Currently, the > debugobjects interface is on

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-22 Thread Manasi Navare
On Mon, Nov 21, 2016 at 04:48:07PM +0100, Daniel Vetter wrote: > On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > > On Mon, Nov 21, 2016 at 09:42:57AM +, Chris Wilson wrote: > > > On Mon, Nov 21, 2016 at 10:38:20AM +0100, Daniel Vetter wrote: > > > > On Fri, Nov 18, 2016 at 09:4

[Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-22 Thread Manasi Navare
This is RFC patch for adding a connector link-status property and making it atomic by adding it to the drm_connector_state. This is to make sure its wired properly in drm_atomic_connector_set_property and drm_atomic_connector_get_property functions. Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Sy

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm: Add a new connector atomic property for link status

2016-11-22 Thread Patchwork
== Series Details == Series: drm: Add a new connector atomic property for link status URL : https://patchwork.freedesktop.org/series/15781/ State : warning == Summary == Series 15781v1 drm: Add a new connector atomic property for link status https://patchwork.freedesktop.org/api/1.0/series/157

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-22 Thread Sean Paul
On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare wrote: > This is RFC patch for adding a connector link-status property > and making it atomic by adding it to the drm_connector_state. > This is to make sure its wired properly in drm_atomic_connector_set_property > and drm_atomic_connector_get_proper

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Zhenyu Wang
On 2016.11.22 14:38:19 +, Chris Wilson wrote: > On Tue, Nov 22, 2016 at 09:29:40PM +0800, Zhi Wang wrote: > > Hi guys: > > Would you mind to have a quick review on this patch? :P The > > linux guest under GVT-g couldn't boot up without this patch in the > > newer kernel. > > > > Thanks, >

Re: [Intel-gfx] [PATCH 3/4] drm/i915/lspcon: Wait for expected LSPCON mode to settle

2016-11-22 Thread Sharma, Shashank
R-B: Shashank Sharma Regards Shashank -Original Message- From: Deak, Imre Sent: Tuesday, November 22, 2016 9:47 PM To: Sharma, Shashank ; intel-gfx@lists.freedesktop.org Cc: Ville Syrjälä ; Nikula, Jani Subject: Re: [PATCH 3/4] drm/i915/lspcon: Wait for expected LSPCON mode to settle

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make GPU pages movable

2016-11-22 Thread Hugh Dickins
On Tue, 22 Nov 2016, Matthew Auld wrote: > On 9 November 2016 at 18:36, Hugh Dickins wrote: > > On Wed, 9 Nov 2016, Daniel Vetter wrote: > >> > >> Hi all -mm folks! > >> > >> Any feedback on these two? It's kinda an intermediate step towards a > >> full-blown gemfs, and I think useful for that. Or

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Saarinen, Jani
> == Series Details == > > Series: drm/i915/perf: Wrap 64bit divides in do_div() > URL : https://patchwork.freedesktop.org/series/15769/ > State : warning > > == Summary == > > Series 15769v1 drm/i915/perf: Wrap 64bit divides in do_div() > https://patchwork.freedesktop.org/api/1.0/series/15769

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Zhi Wang
Thanks Michał! Have a good day. :P On 11/22/16 22:39, Michał Winiarski wrote: On Mon, Nov 21, 2016 at 07:44:26PM +0800, Zhi Wang wrote: a PT page will be released if it doesn't contain any meaningful mappings during PPGTT page table shrinking. The PT entry in the upper level will be set to a sc

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Wang, Zhi A
Hi Chris, thanks for the reply! Without this patch, we have to do pattern scan to identify if the page is still being used as a PT page. :( It's complicated. Originally, all the guest shadow PPGTT pages will be set to write-protected by HV. When guest makes a change in its page table, it will be

Re: [Intel-gfx] [PATCH] lib/debugobjects: Export for use in modules

2016-11-22 Thread Chris Wilson
On Tue, Nov 22, 2016 at 04:53:09PM -0800, Andrew Morton wrote: > On Tue, 22 Nov 2016 14:30:39 + Chris Wilson > wrote: > > > Drivers, or other modules, that use a mixture of objects (especially > > objects embedded within other objects) would like to take advantage of > > the debugobjects fac

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Tian, Kevin
It's also the style how CPU page table is managed... > From: Wang, Zhi A > Sent: Wednesday, November 23, 2016 3:37 PM > > Hi Chris, thanks for the reply! Without this patch, we have to do pattern > scan to identify > if the page is still being used as a PT page. :( It's complicated. > > Origina

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-22 Thread Daniel Vetter
On Tue, Nov 22, 2016 at 05:15:59PM -0800, Manasi Navare wrote: > On Mon, Nov 21, 2016 at 04:48:07PM +0100, Daniel Vetter wrote: > > On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > > > On Mon, Nov 21, 2016 at 09:42:57AM +, Chris Wilson wrote: > > > > On Mon, Nov 21, 2016 at 10:3

[Intel-gfx] [PATCH v2] drm/i915/perf: Wrap 64bit divides in do_div()

2016-11-22 Thread Chris Wilson
Just a couple of naked 64bit divides causing link errors on 32bit builds, with: ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined! v2: do_div() is only u64/u32, we need a u32/u64! Reported-by: kbuild test robot Fixes: d79651522e89 ("drm/i915: Enable i915 perf stream for Haswel

<    1   2