[Intel-gfx] [PATCH 2/6] drm/i915: Decouple hang detection from hangcheck period

2016-11-16 Thread Mika Kuoppala
Hangcheck state accumulation has gained more steps along the years, like head movement and more recently the subunit inactivity check. As the subunit sampling is only done if the previous state check showed inactivity, we have added more stages (and time) to reach a hang verdict. Asymmetric engine

[Intel-gfx] [PATCH 5/6] drm/i915: Add per client max context ban limit

2016-11-16 Thread Mika Kuoppala
If we have a bad client submitting unfavourably across different contexts, creating new ones, the per context scoring of badness doesn't remove the root cause, the offending client. To counter, keep track of per client context bans. Deny access if client is responsible for more than 3 context bans

[Intel-gfx] [PATCH 4/6] drm/i915: Add bannable context parameter

2016-11-16 Thread Mika Kuoppala
Now when driver has per context scoring of 'hanging badness' and also subsequent hangs during short windows are allowed, if there is progress made in between, it does not make sense to expose a ban timing window as a context parameter anymore. Let the scoring be the sole indicator for ban policy a

[Intel-gfx] [PATCH 6/6] drm/i915: Wipe hang stats as an embedded struct

2016-11-16 Thread Mika Kuoppala
Bannable property, banned status, guilty and active counts are properties of i915_gem_context. Make them so. v2: rebase Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h| 31 ++ drivers/gpu/drm/i915/i915_gem.c|

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Tvrtko Ursulin
On 16/11/2016 15:27, Chris Wilson wrote: Avoid requiring struct_mutex for exclusive access to the temporary dfs_link inside the i915_dependency as not all callers may want to touch struct_mutex. So rather than force them to take a highly contended lock, introduce a local lock for the execlists s

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] HAX drm/i915: Enable guc submission (rev3)

2016-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] HAX drm/i915: Enable guc submission (rev3) URL : https://patchwork.freedesktop.org/series/15407/ State : failure == Summary == Series 15407v3 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15407/revisions/3/m

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > On 16/11/2016 15:27, Chris Wilson wrote: > >Avoid requiring struct_mutex for exclusive access to the temporary > >dfs_link inside the i915_dependency as not all callers may want to touch > >struct_mutex. So rather than force them

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/6] drm/i915: Split up hangcheck phases

2016-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Split up hangcheck phases URL : https://patchwork.freedesktop.org/series/15423/ State : warning == Summary == Series 15423v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15423/revisions/1/mbox/ T

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/execlists: Use a local lock for dfs_link access

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Use a local lock for dfs_link access URL : https://patchwork.freedesktop.org/series/15425/ State : warning == Summary == Series 15425v1 drm/i915/execlists: Use a local lock for dfs_link access https://patchwork.freedesktop.org/api/1.0/series/154

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Decouple hang detection from hangcheck period

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:20:30PM +0200, Mika Kuoppala wrote: > - ring_hung = engine->hangcheck.score >= HANGCHECK_SCORE_RING_HUNG; > - if (engine->hangcheck.seqno != intel_engine_get_seqno(engine)) > + ring_hung = engine->hangcheck.stall; > + if (engine->hangcheck.seqno != intel_e

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Use request retirement as context progress

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:20:31PM +0200, Mika Kuoppala wrote: > As hangcheck score was removed, the active decay of score > was removed also. This removed feature for hangcheck to detect > if the gpu client was accidentally or maliciously causing intermittent > hangs. Reinstate the scoring as a pe

[Intel-gfx] [PULL] drm-misc-next

2016-11-16 Thread Daniel Vetter
Hi Dave, Another pile of misc: - Explicit fencing for atomic! Big thanks to Gustavo, Sean, Rob 3x, Brian and anyone else I've forgotten to make this happen. - roll out fbdev helper ops to drivers (Stefan Christ) - last bits of drm_crtc split-up&kerneldoc - some drm_irq.c crtc functions cleanup -

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add per client max context ban limit

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:20:33PM +0200, Mika Kuoppala wrote: > If we have a bad client submitting unfavourably across different > contexts, creating new ones, the per context scoring of badness > doesn't remove the root cause, the offending client. > To counter, keep track of per client context b

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Wipe hang stats as an embedded struct

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:20:34PM +0200, Mika Kuoppala wrote: > Bannable property, banned status, guilty and active counts are > properties of i915_gem_context. Make them so. > > v2: rebase > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala Been hesistating since the substruct might have hel

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-16 Thread Manasi Navare
Jani/Ville , could you please review this patch? Jani, you had mentioned it looks good and we were only waiting for ACKs from DRM, so now from the DRM point of view all these patches are ACKed and it looks good. But I need r-b for these two i915 specific patches to get them merged. Regards Manasi

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-16 Thread Manasi Navare
Jani/Ville could you please review this patch? This has been ACKed by DRM and is good from DRM point fo view. But I need r-b from either of you for this to get merged. Regards Manasi On Mon, Nov 14, 2016 at 07:13:23PM -0800, Manasi Navare wrote: > If link training at a link rate optimal for a par

[Intel-gfx] [PATCH] drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-16 Thread Chris Wilson
I tried to avoid having to track the write for every VMA by only tracking writes to the ggtt. However, for the purposes of frontbuffer tracking this is insufficient as we need to invalidate around writes not just to the the ggtt but all aliased ppgtt views of the framebuffer. By moving the critical

[Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

2016-11-16 Thread Matthew Auld
We already have an i915_address_space_init, so for symmetry we should also have a _fini, plus we already open code it twice. This then also fixes a bug where we leak the timeline for the ggtt vm. Cc: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 17 +

[Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-16 Thread Matthew Auld
We need to clean up the global_timeline in i915_gem_load_cleanup. Cc: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 3fb5e66..c440e72 10064

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915: Move frontbuffer CS write tracking from ggtt vma to object URL : https://patchwork.freedesktop.org/series/15435/ State : success == Summary == Series 15435v1 drm/i915: Move frontbuffer CS write tracking from ggtt vma to object https://patchwork.freedeskt

Re: [Intel-gfx] [PATCH] drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-16 Thread Paulo Zanoni
Em Qua, 2016-11-16 às 19:07 +, Chris Wilson escreveu: > I tried to avoid having to track the write for every VMA by only > tracking writes to the ggtt. However, for the purposes of frontbuffer > tracking this is insufficient as we need to invalidate around writes > not > just to the the ggtt bu

Re: [Intel-gfx] [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

2016-11-16 Thread Paolo Stivanin
Hello all, @Jani Nikula: I just tried the patches you linked and they work *perfectly* on my notebook (Clevo P640RE). I also tried to suspend and resume the laptop and it works like a charm! I applied the patches against the Linux kernel v4.8.8 taken from upstream. Thanks again :) Cheers, Paolo

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: add i915_address_space_fini

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915: add i915_address_space_fini URL : https://patchwork.freedesktop.org/series/15437/ State : warning == Summary == Series 15437v1 drm/i915: add i915_address_space_fini https://patchwork.freedesktop.org/api/1.0/series/15437/revisions/1/mbox/ Test drv_module_

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: don't leak global_timeline

2016-11-16 Thread Patchwork
== Series Details == Series: drm/i915: don't leak global_timeline URL : https://patchwork.freedesktop.org/series/15439/ State : warning == Summary == Series 15439v1 drm/i915: don't leak global_timeline https://patchwork.freedesktop.org/api/1.0/series/15439/revisions/1/mbox/ Test drv_module_re

Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 07:32:49PM +, Matthew Auld wrote: > We need to clean up the global_timeline in i915_gem_load_cleanup. > > Cc: Chris Wilson > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/i915_gem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 07:25:17PM +, Matthew Auld wrote: > We already have an i915_address_space_init, so for symmetry we should > also have a _fini, plus we already open code it twice. This then also > fixes a bug where we leak the timeline for the ggtt vm. > > Cc: Chris Wilson > Signed-off

Re: [Intel-gfx] [PATCH] drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-16 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:52:43PM -0200, Paulo Zanoni wrote: > Em Qua, 2016-11-16 às 19:07 +, Chris Wilson escreveu: > > I tried to avoid having to track the write for every VMA by only > > tracking writes to the ggtt. However, for the purposes of frontbuffer > > tracking this is insufficient

Re: [Intel-gfx] [PATCH] drm/i915/GuC: Combine the two kernel parameter into one

2016-11-16 Thread Srivatsa, Anusha
>-Original Message- >From: Mcgee, Jeff >Sent: Tuesday, November 15, 2016 2:46 PM >To: Srivatsa, Anusha >Cc: Tvrtko Ursulin ; Ursulin, Tvrtko >; intel-gfx@lists.freedesktop.org; Vivi, Rodrigo > >Subject: Re: [Intel-gfx] [PATCH] drm/i915/GuC: Combine the two kernel >parameter into one > >O

Re: [Intel-gfx] [PATCH] drm/i915/gvt: drop checks for early Skylake revisions

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 12:13:59 +0200, Jani Nikula wrote: > We no longer cater for pre-production revisions of Skylake. > > Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping > info") > Cc: Ping Gao > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc: > Signed-off-by: Jani Nikula > --- appl

Re: [Intel-gfx] [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

2016-11-16 Thread Marcos Paulo de Souza
Hi, On Wed, Nov 16, 2016 at 09:14:28PM +0100, Paolo Stivanin wrote: > Hello all, > @Jani Nikula: I just tried the patches you linked and they work > *perfectly* on my notebook (Clevo P640RE). I also tried to suspend and > resume the laptop and it works like a charm! > I applied the patches against

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Update connector status for DP MST hotplugs

2016-11-16 Thread Pandiyan, Dhinakaran
On Fri, 2016-11-11 at 23:05 +0200, Ville Syrjälä wrote: > On Fri, Nov 11, 2016 at 08:43:53PM +, Pandiyan, Dhinakaran wrote: > > On Tue, 2016-11-08 at 13:04 +0200, Ville Syrjälä wrote: > > > On Mon, Nov 07, 2016 at 04:27:30PM -0800, Dhinakaran Pandiyan wrote: > > > > Hotplugging a monitor in DP

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Update connector status for DP MST hotplugs

2016-11-16 Thread Pandiyan, Dhinakaran
On Sun, 2016-11-13 at 11:39 +0100, Daniel Vetter wrote: > On Fri, Nov 11, 2016 at 10:21:39PM +0100, Daniel Vetter wrote: > > On Mon, Nov 07, 2016 at 04:27:30PM -0800, Dhinakaran Pandiyan wrote: > > > Hotplugging a monitor in DP MST configuration triggers short pulses. > > > Although the short pulse

Re: [Intel-gfx] [PATCH v3] drm/i915: start adding dp mst audio

2016-11-16 Thread Yang, Libin
Hi all, Could anyone help review the patches? Thanks. Regards, Libin > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Yang, Libin > Sent: Monday, November 14, 2016 1:41 PM > To: intel-gfx@lists.freedesktop.org; jani.nik...@linux.inte

Re: [Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 22:05:04 +0800, Min He wrote: > For a singl_port_submission context, it can only be submitted to port 0, > and there shouldn't be any other context in port 1 at the same time. This > is required by GVT-g context to have an opportunity to save/restore some > non-hw context render regis

Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 15:50:27 +0800, Zhenyu Wang wrote: > > Hi, > > Please pull current GVT-g device model fixes. > Sorry, pls hold on this as found a possible conflict, as this is supposed to be last pull before 4.10 merge window, like to include the fix for that, will send update later. > Thanks. >

Re: [Intel-gfx] [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

2016-11-16 Thread Daniel Vetter
On Fri, Oct 28, 2016 at 10:10:50AM +0200, Daniel Vetter wrote: > Looking at the ioctl permission checks I noticed that it's impossible > to import gem buffers into a control nodes, and fd2handle/handle2fd > also don't work, so no joy with dma-bufs. > > The only way to do anything with a control no

[Intel-gfx] [PATCH] drm/i915: Complete requests in nop_submit_request

2016-11-16 Thread Chris Wilson
Since the submit/execute split in commit d55ac5bf97c6 ("drm/i915: Defer transfer onto execution timeline to actual hw submission") the global seqno advance was deferred until the submit_request callback. After wedging the GPU, we were installing a nop_submit_request handler (to avoid waking up the

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Update connector status for DP MST hotplugs

2016-11-16 Thread Daniel Vetter
On Thu, Nov 17, 2016 at 01:53:31AM +, Pandiyan, Dhinakaran wrote: > On Sun, 2016-11-13 at 11:39 +0100, Daniel Vetter wrote: > > On Fri, Nov 11, 2016 at 10:21:39PM +0100, Daniel Vetter wrote: > > > On Mon, Nov 07, 2016 at 04:27:30PM -0800, Dhinakaran Pandiyan wrote: > > > > Hotplugging a monitor

Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-16 Thread Daniel Vetter
On Thu, Nov 17, 2016 at 02:51:28PM +0800, Zhenyu Wang wrote: > > On 2016.11.16 15:50:27 +0800, Zhenyu Wang wrote: > > > > Hi, > > > > Please pull current GVT-g device model fixes. > > > > Sorry, pls hold on this as found a possible conflict, as this is > supposed to be last pull before 4.10 mer

<    1   2