[Intel-gfx] [i-g-t PATCH] tests: debug log lsmod on module unload failure

2016-10-18 Thread Jani Nikula
It's a bit verbose, but should only happen on errors. This should help debug the snd_hda_intel unload issues. Signed-off-by: Jani Nikula --- UNTESTED!!! --- tests/drv_module_reload_basic | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/drv_module_reload_b

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-18 Thread Daniel Vetter
On Mon, Oct 17, 2016 at 05:46:50PM +0300, Imre Deak wrote: > On ma, 2016-10-17 at 16:32 +0200, Daniel Vetter wrote: > > On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote: > > > Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests > > > to > > > BAT. At the same time remove ba

Re: [Intel-gfx] [PATCH 12/15] drm: RIP mode_config->rotation_property

2016-10-18 Thread Daniel Vetter
On Tue, Oct 18, 2016 at 01:38:05AM +0300, Laurent Pinchart wrote: > Hi Ville, > > On Friday 22 Jul 2016 16:43:13 ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Now that all drivers have been converted over to the per-plane rotation > > property, we can just nuke the global

Re: [Intel-gfx] [PATCH] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Tvrtko Ursulin
On 17/10/2016 15:10, Chris Wilson wrote: When handling execbuf relocations, we play a delicate dance with pagefault. We first try to access the user pages underneath our struct_mutex. However, if those pages were inside a GEM object, we may trigger a pagefault and deadlock as i915_gem_fault() tr

Re: [Intel-gfx] [PATCH 12/15] drm: RIP mode_config->rotation_property

2016-10-18 Thread Laurent Pinchart
Hi Daniel, On Tuesday 18 Oct 2016 09:36:23 Daniel Vetter wrote: > On Tue, Oct 18, 2016 at 01:38:05AM +0300, Laurent Pinchart wrote: > > On Friday 22 Jul 2016 16:43:13 ville.syrj...@linux.intel.com wrote: > >> From: Ville Syrjälä > >> > >> Now that all drivers have been converted over to the per-

Re: [Intel-gfx] [PATCH] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 09:01:30AM +0100, Tvrtko Ursulin wrote: > > On 17/10/2016 15:10, Chris Wilson wrote: > >When handling execbuf relocations, we play a delicate dance with > >pagefault. We first try to access the user pages underneath our > >struct_mutex. However, if those pages were inside a

Re: [Intel-gfx] [Regression report] Weekly regression report WW42

2016-10-18 Thread Jani Nikula
Do all the bugs at fdo now have the appropriate regression/bisected keywords? Can we start using a bugzilla query link to get all the information in this report? BR, Jani. On Mon, 17 Oct 2016, Jairo Miramontes wrote: > This weeknew regressions > +---+--

Re: [Intel-gfx] [PATCH] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Tvrtko Ursulin
On 18/10/2016 09:17, Chris Wilson wrote: On Tue, Oct 18, 2016 at 09:01:30AM +0100, Tvrtko Ursulin wrote: On 17/10/2016 15:10, Chris Wilson wrote: When handling execbuf relocations, we play a delicate dance with pagefault. We first try to access the user pages underneath our struct_mutex. Howev

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 05:39:11AM +, Saarinen, Jani wrote: > > == Series Details == > > > > Series: drm/i915/gvt: Fix build failure after intel_engine_cs change > > URL : https://patchwork.freedesktop.org/series/13910/ > > State : failure > > > > == Summary == > > > > Series 13910v1 drm/i

Re: [Intel-gfx] [PATCH] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 09:22:56AM +0100, Tvrtko Ursulin wrote: > > On 18/10/2016 09:17, Chris Wilson wrote: > >On Tue, Oct 18, 2016 at 09:01:30AM +0100, Tvrtko Ursulin wrote: > >>On 17/10/2016 15:10, Chris Wilson wrote: > >>>When handling execbuf relocations, we play a delicate dance with > >>>pa

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 09:40:07AM +0800, Zhenyu Wang wrote: > Change GVT-g code reference for intel_engine_cs from static array to > allocated pointer after commit 3b3f1650b1ca ("drm/i915: Allocate > intel_engine_cs structure only for the enabled engines"). You also need to enable deprecation war

Re: [Intel-gfx] [PATCH xf86-video-intel] sna: Reprobe if kernel updates the connector mode list

2016-10-18 Thread Chris Wilson
On Mon, Oct 17, 2016 at 03:31:24PM -0700, Manasi Navare wrote: > Output_check_status() should return a false if it detects > that the connector mode list has changed so that sna_mode_discover > can reprobe. > > Fixes: eb01cc549d4d (sna: Refresh mode list if the kernel updates) > > Signed-off-by:

Re: [Intel-gfx] [PATCH 24/41] drm/i915: Use lockless object free

2016-10-18 Thread Joonas Lahtinen
On pe, 2016-10-14 at 13:18 +0100, Chris Wilson wrote: > Having moved the locked phase of freeing an object to a separate worker, > we can now declare to the core that we only need the unlocked variant of > driver->gem_free_object, and can use the simple unreference internally. > > Signed-off-by: C

Re: [Intel-gfx] [PATCH] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Tvrtko Ursulin
On 18/10/2016 09:38, Chris Wilson wrote: On Tue, Oct 18, 2016 at 09:22:56AM +0100, Tvrtko Ursulin wrote: On 18/10/2016 09:17, Chris Wilson wrote: On Tue, Oct 18, 2016 at 09:01:30AM +0100, Tvrtko Ursulin wrote: On 17/10/2016 15:10, Chris Wilson wrote: When handling execbuf relocations, we pla

Re: [Intel-gfx] [PATCH] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 09:54:23AM +0100, Tvrtko Ursulin wrote: > On 18/10/2016 09:38, Chris Wilson wrote: > >>>(a) it is safe to do so, and I can legitimately setup userspace to use > >>>this > >>How what where? :) > >igt, whereelse, has a test case to check we can execute from read only > >memory

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-18 Thread Petri Latvala
On Tue, Oct 18, 2016 at 09:34:49AM +0200, Daniel Vetter wrote: > Re S4: If it indeed improves coverage (i.e. calls our shutdown hooks and > all these S4-only callbacks) then adding it to BAT sounds reasonable. > Still there's the issue of where to get the machine time from. I really do > think you

[Intel-gfx] [PATCH v2] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Chris Wilson
When handling execbuf relocations, we play a delicate dance with pagefault. We first try to access the user pages underneath our struct_mutex. However, if those pages were inside a GEM object, we may trigger a pagefault and deadlock as i915_gem_fault() tries to recursively acquire struct_mutex. Ins

Re: [Intel-gfx] [i-g-t PATCH] igt/tools: Update intel_watermark with SKL support

2016-10-18 Thread Ville Syrjälä
On Mon, Oct 17, 2016 at 10:19:35PM -0700, Dhinakaran Pandiyan wrote: > Added support to print SKL watermark and DDB registers. > > Signed-off-by: Dhinakaran Pandiyan > --- > tools/intel_watermark.c | 104 > +++- > 1 file changed, 103 insertions(+), 1

Re: [Intel-gfx] [PATCH v2] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Tvrtko Ursulin
On 18/10/2016 10:07, Chris Wilson wrote: When handling execbuf relocations, we play a delicate dance with pagefault. We first try to access the user pages underneath our struct_mutex. However, if those pages were inside a GEM object, we may trigger a pagefault and deadlock as i915_gem_fault() tr

Re: [Intel-gfx] [PATCH 12/15] drm: RIP mode_config->rotation_property

2016-10-18 Thread Ville Syrjälä
On Tue, Oct 18, 2016 at 11:13:53AM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Tuesday 18 Oct 2016 09:36:23 Daniel Vetter wrote: > > On Tue, Oct 18, 2016 at 01:38:05AM +0300, Laurent Pinchart wrote: > > > On Friday 22 Jul 2016 16:43:13 ville.syrj...@linux.intel.com wrote: > > >> From: Ville

Re: [Intel-gfx] [PATCH 23/41] drm/i915: Move object release to a freelist + worker

2016-10-18 Thread Joonas Lahtinen
On pe, 2016-10-14 at 13:18 +0100, Chris Wilson wrote: > We want to hide the latency of releasing objects and their backing > storage from the submission, so we move the actual free to a worker. > This allows us to switch to struct_mutex freeing of the object in the > next patch. > > Furthermore, i

Re: [Intel-gfx] [PATCH 23/41] drm/i915: Move object release to a freelist + worker

2016-10-18 Thread Joonas Lahtinen
On ti, 2016-10-18 at 12:19 +0300, Joonas Lahtinen wrote: > With the change from John, > "Now that the change from John was done" would have been better wording. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Int

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Bump object bookkeeping to u64 from size_t

2016-10-18 Thread Tvrtko Ursulin
On 17/10/2016 09:00, Chris Wilson wrote: Internally we allow for using more objects than a single process can allocate, i.e. we allow for a 64bit GPU address space even on a 32bit system. Using size_t may oveerflow. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +-

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-18 Thread Ville Syrjälä
On Tue, Oct 18, 2016 at 12:03:12PM +0300, Petri Latvala wrote: > On Tue, Oct 18, 2016 at 09:34:49AM +0200, Daniel Vetter wrote: > > Re S4: If it indeed improves coverage (i.e. calls our shutdown hooks and > > all these S4-only callbacks) then adding it to BAT sounds reasonable. > > Still there's th

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Document our internal limit on object size

2016-10-18 Thread Tvrtko Ursulin
On 17/10/2016 09:00, Chris Wilson wrote: In many places, we try to count pages using a 32 bit integer. That implies if we are asked to create an object larger than 43bits, we will subtly crash much later. Catch this on the boundary, and add a warning to remind ourselves later on our exabyte syst

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Limit the scattergather coalescing to 32bits

2016-10-18 Thread Tvrtko Ursulin
On 17/10/2016 09:00, Chris Wilson wrote: The scattergather list uses a 32bit size counter, we should avoid exceeding it. v2: Also we should use unsigned int to match sg->length. Fixes: 871dfbd67d4e ("drm/i915: Allow compaction upto SWIOTLB max segment size") Signed-off-by: Chris Wilson Review

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Restrict pagefault disabling to just around copy_from_user() (rev2)

2016-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Restrict pagefault disabling to just around copy_from_user() (rev2) URL : https://patchwork.freedesktop.org/series/13880/ State : failure == Summary == Series 13880v2 drm/i915: Restrict pagefault disabling to just around copy_from_user() https://patchwo

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Document our internal limit on object size

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 10:27:58AM +0100, Tvrtko Ursulin wrote: > > On 17/10/2016 09:00, Chris Wilson wrote: > >In many places, we try to count pages using a 32 bit integer. That > >implies if we are asked to create an object larger than 43bits, we will > >subtly crash much later. Catch this on th

Re: [Intel-gfx] [PATCH 23/41] drm/i915: Move object release to a freelist + worker

2016-10-18 Thread John Harrison
On 14/10/2016 13:18, Chris Wilson wrote: We want to hide the latency of releasing objects and their backing storage from the submission, so we move the actual free to a worker. This allows us to switch to struct_mutex freeing of the object in the next patch. Furthermore, if we know that the obje

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Restrict pagefault disabling to just around copy_from_user() (rev2)

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 09:35:12AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Restrict pagefault disabling to just around > copy_from_user() (rev2) > URL : https://patchwork.freedesktop.org/series/13880/ > State : failure > > == Summary == > > Series 13880v2 drm/i915

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Limit the scattergather coalescing to 32bits

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 10:33:11AM +0100, Tvrtko Ursulin wrote: > > On 17/10/2016 09:00, Chris Wilson wrote: > >The scattergather list uses a 32bit size counter, we should avoid > >exceeding it. > > > >v2: Also we should use unsigned int to match sg->length. > > > >Fixes: 871dfbd67d4e ("drm/i915:

[Intel-gfx] [PATCH 1/2] drm: make is_lspcon_adaptor static

2016-10-18 Thread Jani Nikula
Fixes sparse warning: drivers/gpu/drm/drm_dp_dual_mode_helper.c:151:6: warning: symbol 'is_lspcon_adaptor' was not declared. Should it be static? Fixes: 056996b95686 ("drm: Helper for lspcon in drm_dp_dual_mode") Cc: Rodrigo Vivi Cc: Shashank Sharma Cc: Signed-off-by: Jani Nikula --- n.b. 0

[Intel-gfx] [PATCH 2/2] drm/i915: make lspcon_get_current_mode static

2016-10-18 Thread Jani Nikula
Fixes sparse warning: drivers/gpu/drm/i915/intel_lspcon.c:30:22: warning: symbol 'lspcon_get_current_mode' was not declared. Should it be static? Fixes: dbe9e61b8e43 ("drm/i915: Add lspcon support for I915 driver") Cc: Rodrigo Vivi Cc: Shashank Sharma Signed-off-by: Jani Nikula --- drivers/gp

[Intel-gfx] [PATCH i-g-t] tests/vgem_basic: Retry the initial module unload in unload test

2016-10-18 Thread Petri Latvala
If executed too soon after prime_vgem tests, the vgem unload test fails due to its execbuffers still being handled in the kernel. Retry the unload three times with sleeps before reporting a skip. When tested on HSW, one 1s sleep wasn't enough, 3s was. Signed-off-by: Petri Latvala CC: Chris Wilso

[Intel-gfx] [PATCH] drm: fix sparse warnings on undeclared symbols in crc debugfs

2016-10-18 Thread Jani Nikula
Fixes sparse warnings: drivers/gpu/drm/drm_debugfs_crc.c:118:30: warning: symbol 'drm_crtc_crc_control_fops' was not declared. Should it be static? drivers/gpu/drm/drm_debugfs_crc.c:264:30: warning: symbol 'drm_crtc_crc_data_fops' was not declared. Should it be static? drivers/gpu/drm/drm_debugf

Re: [Intel-gfx] [PATCH] drm: fix sparse warnings on undeclared symbols in crc debugfs

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 02:28:35PM +0300, Jani Nikula wrote: > Fixes sparse warnings: > > drivers/gpu/drm/drm_debugfs_crc.c:118:30: warning: symbol > 'drm_crtc_crc_control_fops' was not declared. Should it be static? > > drivers/gpu/drm/drm_debugfs_crc.c:264:30: warning: symbol > 'drm_crtc_crc_da

[Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

2016-10-18 Thread Arkadiusz Hiler
Dropping WA because it was for early steppings. It is fixed in newer preproduction and all production revisions. Cc: Michal Winiarski Signed-off-by: Arkadiusz Hiler --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringb

Re: [Intel-gfx] [PATCH i-g-t] tests/vgem_basic: Retry the initial module unload in unload test

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 02:25:21PM +0300, Petri Latvala wrote: > If executed too soon after prime_vgem tests, the vgem unload test > fails due to its execbuffers still being handled in the kernel. Retry > the unload three times with sleeps before reporting a skip. What happened to igt ensuring tha

Re: [Intel-gfx] [PATCH 2/2] drm/i915: make lspcon_get_current_mode static

2016-10-18 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank -Original Message- From: Nikula, Jani Sent: Tuesday, October 18, 2016 4:52 PM To: intel-gfx@lists.freedesktop.org Cc: Nikula, Jani ; Vivi, Rodrigo ; Sharma, Shashank Subject: [PATCH 2/2] drm/i915: make lspcon_get_current_mode static Fixes s

Re: [Intel-gfx] [PATCH 1/2] drm: make is_lspcon_adaptor static

2016-10-18 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank -Original Message- From: Nikula, Jani Sent: Tuesday, October 18, 2016 4:52 PM To: intel-gfx@lists.freedesktop.org Cc: Nikula, Jani ; Vivi, Rodrigo ; Sharma, Shashank ; dri-de...@lists.freedesktop.org Subject: [PATCH 1/2] drm: make is_lspcon_

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-18 Thread Jani Nikula
On Mon, 17 Oct 2016, Jani Nikula wrote: > On Mon, 17 Oct 2016, Daniel Vetter wrote: >> Ok applied, but a few things to keep in mind before your next pull >> request: >> >> - Dont rebase everything 5 seconds before sending out the pull request. >> That just invalidates all the testing you've don

[Intel-gfx] [CI 1/4] drm/i915: Bump object bookkeeping to u64 from size_t

2016-10-18 Thread Chris Wilson
Internally we allow for using more objects than a single process can allocate, i.e. we allow for a 64bit GPU address space even on a 32bit system. Using size_t may oveerflow. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/

[Intel-gfx] [CI 2/4] drm/i915: Document our internal limit on object size

2016-10-18 Thread Chris Wilson
In many places, we try to count pages using a 32 bit integer. That implies if we are asked to create an object larger than 43bits, we will subtly crash much later. Catch this on the boundary, and add a warning to remind ourselves later on our exabyte systems. Signed-off-by: Chris Wilson Reviewed-

[Intel-gfx] [CI 4/4] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-18 Thread Chris Wilson
When handling execbuf relocations, we play a delicate dance with pagefault. We first try to access the user pages underneath our struct_mutex. However, if those pages were inside a GEM object, we may trigger a pagefault and deadlock as i915_gem_fault() tries to recursively acquire struct_mutex. Ins

[Intel-gfx] [CI 3/4] drm/i915: Limit the scattergather coalescing to 32bits

2016-10-18 Thread Chris Wilson
The scattergather list uses a 32bit size counter, we should avoid exceeding it. v2: Also we should use unsigned int to match sg->length. Fixes: 871dfbd67d4e ("drm/i915: Allow compaction upto SWIOTLB max segment size") Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Make GPU pages movable

2016-10-18 Thread Joonas Lahtinen
On ma, 2016-04-04 at 14:18 +0100, Chris Wilson wrote: > From: Akash Goel > > On a long run of more than 2-3 days, physical memory tends to get > fragmented severely, which considerably slows down the system. In such a > scenario, the shrinker is also unable to help as lack of memory is not > the

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

2016-10-18 Thread Mika Kuoppala
Arkadiusz Hiler writes: > Dropping WA because it was for early steppings. > > It is fixed in newer preproduction and all production revisions. > We have used References tag to point to a relevant document that has more information. Like for this, it should be: References: HSD#2126385 From ther

[Intel-gfx] [PATCH 09/10] dim: Split out drm-nightly.git

2016-10-18 Thread Daniel Vetter
This is a prep step to eventually split out the drm-misc branches all into their own repo. To get there we first need to split out the integration tree mangling. Since dim doesn't auto-update and since the transition is a good reason to switch over to worktrees and it's tricky it's not scripted. T

[Intel-gfx] [PATCH 02/10] dim: Autocheck for up-to-dateness

2016-10-18 Thread Daniel Vetter
Exits script to annoy people roughly every 100th time ... Also switch to the magic @{upstream} reference, in case the remote is not called origin (which is pretty normal in case of using git worktree). Signed-off-by: Daniel Vetter --- dim | 6 +- 1 file changed, 5 insertions(+), 1 deletion(

[Intel-gfx] [PATCH 04/10] dim: autodetect remotes, first part for dim_setup

2016-10-18 Thread Daniel Vetter
The goals here are multiple: - simpler configuration through autodetection - allows seamless upgrading to git worktree for the aux checkouts - eventually I want to split up drm-misc into a separate remote ... And yes this is just a start. v2: Print errors to stderr, otherwise they can't be seen w

[Intel-gfx] [PATCH 08/10] dim: remove integration-tree remotes

2016-10-18 Thread Daniel Vetter
With the remotes stored in nightly.conf and git worktrees we can avoid hard-coding them in even more places. Signed-off-by: Daniel Vetter --- dim | 12 1 file changed, 12 deletions(-) diff --git a/dim b/dim index f9b28d5fd241..20a3143a5c1e 100755 --- a/dim +++ b/dim @@ -80,8 +80,6

[Intel-gfx] [PATCH 06/10] dim: Nuke nightly-forget

2016-10-18 Thread Daniel Vetter
With our proliferation of branches it's become long useless. Nowadays my MO is to revert the offending commit in the rerere-cache branch explicitly, remove drm-intel-nightly/.git/rr-cache and then re-run rebuild-nightly. That works much better, hence nuke this helper. Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH 07/10] dim: autodetect branches in rebuild-nightly

2016-10-18 Thread Daniel Vetter
Needs new url-mapping information in nightly.conf to work properly. Signed-off-by: Daniel Vetter --- dim | 48 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/dim b/dim index 48d5e7b6477a..f9b28d5fd241 100755 --- a/dim +++ b/dim @@

[Intel-gfx] [PATCH 03/10] dim: echoerr helper for printing to stderr

2016-10-18 Thread Daniel Vetter
Signed-off-by: Daniel Vetter --- dim | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/dim b/dim index 192d6ee10838..2601bb7dbbad 100755 --- a/dim +++ b/dim @@ -102,12 +102,17 @@ DRY= FORCE= HELP= +function echoerr +{ + echo "$@" >&2 +} + function

[Intel-gfx] [PATCH 05/10] dim: support git worktree for aux checkouts

2016-10-18 Thread Daniel Vetter
If available by default. This saves quite a pile of disk-space that imo making it the default is justified. Note that this will break the rebuild-nightly script for now, follow-up patches will fix that. Signed-off-by: Daniel Vetter --- dim | 23 --- 1 file changed, 16 insert

[Intel-gfx] [PATCH 01/10] dim: Extract TODO

2016-10-18 Thread Daniel Vetter
Just maybe a bit more visibility, the scripts are growing. Signed-off-by: Daniel Vetter --- TODO | 27 +++ dim | 17 - qf | 11 --- 3 files changed, 27 insertions(+), 28 deletions(-) create mode 100644 TODO diff --git a/TODO b/TODO new file mo

[Intel-gfx] [PATCH 10/10] dim: s/drm-nightly/drm-tip

2016-10-18 Thread Daniel Vetter
tip = testing and integration pile Also rename drm-intel-rerere directory to drm-rerere. Signed-off-by: Daniel Vetter --- dim| 48 dim.rst| 16 +++- dimrc.sample | 2 +- drm-intel-flow.dot | 18 +

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: make is_lspcon_adaptor static

2016-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: make is_lspcon_adaptor static URL : https://patchwork.freedesktop.org/series/13944/ State : failure == Summary == Series 13944v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/13944/revisions/1/mbox/ Te

Re: [Intel-gfx] [PATCH i-g-t] tests/vgem_basic: Retry the initial module unload in unload test

2016-10-18 Thread Petri Latvala
On 10/18/2016 02:36 PM, Chris Wilson wrote: On Tue, Oct 18, 2016 at 02:25:21PM +0300, Petri Latvala wrote: If executed too soon after prime_vgem tests, the vgem unload test fails due to its execbuffers still being handled in the kernel. Retry the unload three times with sleeps before reporting

Re: [Intel-gfx] [PATCH 01/10] mm: remove write/force parameters from __get_user_pages_locked()

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:11, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > __get_user_pages_locked() > to make the use of FOLL_FORCE explicit in callers as use of this flag can > result > in surprising behaviour (and hence bugs) within the mm subsystem. > > Signe

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: fix sparse warnings on undeclared symbols in crc debugfs

2016-10-18 Thread Patchwork
== Series Details == Series: drm: fix sparse warnings on undeclared symbols in crc debugfs URL : https://patchwork.freedesktop.org/series/13948/ State : failure == Summary == Series 13948v1 drm: fix sparse warnings on undeclared symbols in crc debugfs https://patchwork.freedesktop.org/api/1.0/

Re: [Intel-gfx] [PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked()

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:12, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > __get_user_pages_unlocked() to make the use of FOLL_FORCE explicit in callers > as > use of this flag can result in surprising behaviour (and hence bugs) within > the > mm subsystem. > > S

Re: [Intel-gfx] [PATCH i-g-t] tests/vgem_basic: Retry the initial module unload in unload test

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 03:41:54PM +0300, Petri Latvala wrote: > How should vgem work be flushed properly? With this i915 flushing is > guaranteed even if vgem is opened first, then i915, but such > flushing won't be done if only vgem is opened (I see only vgem_slow > doing that)... vgem doesn't h

Re: [Intel-gfx] [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:13, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > get_user_pages_unlocked() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and >

Re: [Intel-gfx] [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:14, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages_locked() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and > hence

Re: [Intel-gfx] [PATCH i-g-t] tests/vgem_basic: Retry the initial module unload in unload test

2016-10-18 Thread Petri Latvala
On Tue, Oct 18, 2016 at 01:48:52PM +0100, Chris Wilson wrote: > vgem doesn't have the same delayed close as i915. For vgem, closing the > fd (i.e. on process exit) will first signal all fences and drop > references for that fd, so effectively all work will be completed. The > external references to

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/4] drm/i915: Bump object bookkeeping to u64 from size_t

2016-10-18 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Bump object bookkeeping to u64 from size_t URL : https://patchwork.freedesktop.org/series/13950/ State : failure == Summary == Series 13950v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/13950

Re: [Intel-gfx] [PATCH 03/10] dim: echoerr helper for printing to stderr

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Daniel Vetter wrote: > Signed-off-by: Daniel Vetter > --- > dim | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/dim b/dim > index 192d6ee10838..2601bb7dbbad 100755 > --- a/dim > +++ b/dim > @@ -102,12 +102,17 @@ DRY= > FORCE= >

Re: [Intel-gfx] [PATCH 01/10] dim: Extract TODO

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Daniel Vetter wrote: > Just maybe a bit more visibility, the scripts are growing. > > Signed-off-by: Daniel Vetter LGTM > --- > TODO | 27 +++ > dim | 17 - > qf | 11 --- > 3 files changed, 27 insertions(+), 28 deletions(

Re: [Intel-gfx] [PATCH 02/10] dim: Autocheck for up-to-dateness

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Daniel Vetter wrote: > Exits script to annoy people roughly every 100th time ... Annoyingly random, but we can improve this later. LGTM. > Also switch to the magic @{upstream} reference, in case the remote is > not called origin (which is pretty normal in case of using git

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

2016-10-18 Thread Mika Kuoppala
Mika Kuoppala writes: > Arkadiusz Hiler writes: > >> Dropping WA because it was for early steppings. >> >> It is fixed in newer preproduction and all production revisions. >> > > We have used References tag to point to a relevant document > that has more information. Like for this, it should be:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/4] drm/i915: Bump object bookkeeping to u64 from size_t

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 01:05:24PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/4] drm/i915: Bump object bookkeeping to > u64 from size_t > URL : https://patchwork.freedesktop.org/series/13950/ > State : failure > > == Summary == > > Series 13950v1 Ser

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 04:15:22PM +0300, Mika Kuoppala wrote: > Mika Kuoppala writes: > > > Arkadiusz Hiler writes: > > > >> Dropping WA because it was for early steppings. > >> > >> It is fixed in newer preproduction and all production revisions. > >> > > > > We have used References tag to poi

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Make GPU pages movable

2016-10-18 Thread Goel, Akash
On 10/18/2016 5:35 PM, Joonas Lahtinen wrote: On ma, 2016-04-04 at 14:18 +0100, Chris Wilson wrote: From: Akash Goel On a long run of more than 2-3 days, physical memory tends to get fragmented severely, which considerably slows down the system. In such a scenario, the shrinker is also unabl

Re: [Intel-gfx] [PATCH 04/10] dim: autodetect remotes, first part for dim_setup

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Daniel Vetter wrote: > The goals here are multiple: > - simpler configuration through autodetection > - allows seamless upgrading to git worktree for the aux checkouts > - eventually I want to split up drm-misc into a separate remote ... > > And yes this is just a start. > > v

Re: [Intel-gfx] [PATCH 02/10] dim: Autocheck for up-to-dateness

2016-10-18 Thread Daniel Vetter
On Tue, Oct 18, 2016 at 04:15:01PM +0300, Jani Nikula wrote: > On Tue, 18 Oct 2016, Daniel Vetter wrote: > > Exits script to annoy people roughly every 100th time ... > > Annoyingly random, but we can improve this later. I had it non-random, then realized it makes improving dim impossible ;-) -D

Re: [Intel-gfx] [PATCH 04/10] dim: autodetect remotes, first part for dim_setup

2016-10-18 Thread Ville Syrjälä
On Tue, Oct 18, 2016 at 04:27:05PM +0300, Jani Nikula wrote: > On Tue, 18 Oct 2016, Daniel Vetter wrote: > > The goals here are multiple: > > - simpler configuration through autodetection > > - allows seamless upgrading to git worktree for the aux checkouts > > - eventually I want to split up drm-

Re: [Intel-gfx] [Regression report] Weekly regression report WW42

2016-10-18 Thread Vega, Ricardo
Jairo had to manually go into every bug and include the correct "keyword" but this is done. He's script will continue to look for both keywords field and also specific strings in the summary at least until we are consistent using the keyword field. In addition will include the following query

Re: [Intel-gfx] [PATCH 05/10] dim: support git worktree for aux checkouts

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Daniel Vetter wrote: > If available by default. This saves quite a pile of disk-space that > imo making it the default is justified. > > Note that this will break the rebuild-nightly script for now, > follow-up patches will fix that. > > Signed-off-by: Daniel Vetter > --- >

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Make GPU pages movable

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 06:55:12PM +0530, Goel, Akash wrote: > > > On 10/18/2016 5:35 PM, Joonas Lahtinen wrote: > >On ma, 2016-04-04 at 14:18 +0100, Chris Wilson wrote: > >>From: Akash Goel > >> > >>On a long run of more than 2-3 days, physical memory tends to get > >>fragmented severely, which

Re: [Intel-gfx] [PATCH 06/10] dim: Nuke nightly-forget

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Daniel Vetter wrote: > With our proliferation of branches it's become long useless. Nowadays > my MO is to revert the offending commit in the rerere-cache branch > explicitly, remove drm-intel-nightly/.git/rr-cache and then re-run > rebuild-nightly. That works much better, hen

Re: [Intel-gfx] [PATCH 07/10] dim: autodetect branches in rebuild-nightly

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Daniel Vetter wrote: > Needs new url-mapping information in nightly.conf to work properly. I think in the long run the right fix would be to make nightly.conf independent of remote names. Not sure if that's worth the trouble at this point. BR, Jani. > > Signed-off-by: Dan

Re: [Intel-gfx] [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

2016-10-18 Thread Lorenzo Stoakes
On Tue, Oct 18, 2016 at 02:54:25PM +0200, Jan Kara wrote: > > @@ -1282,7 +1282,7 @@ long get_user_pages(unsigned long start, unsigned > > long nr_pages, > > int write, int force, struct page **pages, > > struct vm_area_struct **vmas); > > long get_u

Re: [Intel-gfx] [PATCH 02/10] dim: Autocheck for up-to-dateness

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Daniel Vetter wrote: > On Tue, Oct 18, 2016 at 04:15:01PM +0300, Jani Nikula wrote: >> On Tue, 18 Oct 2016, Daniel Vetter wrote: >> > Exits script to annoy people roughly every 100th time ... >> >> Annoyingly random, but we can improve this later. > > I had it non-random, th

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Sanitory checks for platform that dont have GuC

2016-10-18 Thread Paulo Zanoni
Em Sex, 2016-10-14 às 16:47 -0700, Anusha Srivatsa escreveu: > i915.enable_guc_loading/submission=2 forces the usage of GuC. > For platforms that do not have a GuC, asking the kernel to use a GuC > should not result in an error state. Do extra checks to see if the > platform even has a GuC or not,

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

2016-10-18 Thread Mika Kuoppala
Chris Wilson writes: > On Tue, Oct 18, 2016 at 04:15:22PM +0300, Mika Kuoppala wrote: >> Mika Kuoppala writes: >> >> > Arkadiusz Hiler writes: >> > >> >> Dropping WA because it was for early steppings. >> >> >> >> It is fixed in newer preproduction and all production revisions. >> >> >> > >> >

[Intel-gfx] [PATCH] drm/i915: Mark GVT as BROKEN

2016-10-18 Thread Chris Wilson
It contains oodles of unreviewed code that has numerous bugs in just the few minutes I spent looking at it. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index e1b32da89

Re: [Intel-gfx] [PATCH 04/10] dim: autodetect remotes, first part for dim_setup

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, Ville Syrjälä wrote: > On Tue, Oct 18, 2016 at 04:27:05PM +0300, Jani Nikula wrote: >> On Tue, 18 Oct 2016, Daniel Vetter wrote: >> > The goals here are multiple: >> > - simpler configuration through autodetection >> > - allows seamless upgrading to git worktree for the aux c

Re: [Intel-gfx] 4.8-rc1: it is now common that machine needs re-run of xrandr after resume

2016-10-18 Thread Pavel Machek
Hi! On Wed 2016-09-14 14:14:35, Jani Nikula wrote: > On Wed, 14 Sep 2016, Jani Nikula wrote: > > On Wed, 14 Sep 2016, Pavel Machek wrote: > >> For the "sometimes need xrandr after resume": I don't think I can > >> bisect that. It only happens sometimes :-(. But there's something > >> helpful in

Re: [Intel-gfx] [Regression report] Weekly regression report WW42

2016-10-18 Thread Jani Nikula
On Tue, 18 Oct 2016, "Vega, Ricardo" wrote: > Jairo had to manually go into every bug and include the correct > "keyword" but this is done. I know it had to be done manually. Thank you very much for the effort! > He's script will continue to look for both keywords field and also > specific strin

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-18 Thread Chris Wilson
On Fri, Oct 14, 2016 at 06:30:30PM +0800, Zhenyu Wang wrote: > > Hi, > > This is first pull request to merge GVT-g device model in i915 > which contains core GVT-g device model work to virtualize GPU > resources. This tries to add feature of Intel GVT-g technology > for full GPU virtualization. T

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Mark GVT as BROKEN

2016-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Mark GVT as BROKEN URL : https://patchwork.freedesktop.org/series/13959/ State : warning == Summary == Series 13959v1 drm/i915: Mark GVT as BROKEN https://patchwork.freedesktop.org/api/1.0/series/13959/revisions/1/mbox/ Test kms_pipe_crc_basic: S

[Intel-gfx] [PATCH v2] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

2016-10-18 Thread Arkadiusz Hiler
Dropping WA because it was for early steppings. It is fixed in newer preproduction and all production revisions. v2: add references, updated commit message References: HSD#2126385, HSD#2131381, BSID#0764 Cc: Mika Kuoppala Cc: Chris Wilson Cc: Michal Winiarski Signed-off-by: Arkadiusz Hiler -

[Intel-gfx] IGT contributions and reviews

2016-10-18 Thread Petri Latvala
The current contributing docs for IGT state: << There is no formal review requirement and regular contributors with commit access can push patches right after submitting them to the mailing lists. But invasive changes, new helper libraries and contributions from newcomers should go throug

Re: [Intel-gfx] [PATCH] i915: don't call drm_atomic_state_put on invalid pointer

2016-10-18 Thread Eric Engestrom
On Tuesday, 2016-10-18 17:16:23 +0200, Arnd Bergmann wrote: > The introduction of reference counting on the state structures caused > sanitize_watermarks() in i915 to break in the error handling case, > as pointed out by gcc -Wmaybe-uninitialized > > drivers/gpu/drm/i915/intel_display.c: In functi

Re: [Intel-gfx] [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-18 Thread Michal Hocko
On Thu 13-10-16 01:20:10, Lorenzo Stoakes wrote: > This patch series adjusts functions in the get_user_pages* family such that > desired FOLL_* flags are passed as an argument rather than implied by flags. > > The purpose of this change is to make the use of FOLL_FORCE explicit so it is > easier t

Re: [Intel-gfx] [Regression report] Weekly regression report WW42

2016-10-18 Thread Jairo Miramontes
On 10/18/2016 9:13 AM, Jani Nikula wrote: On Tue, 18 Oct 2016, "Vega, Ricardo" wrote: Jairo had to manually go into every bug and include the correct "keyword" but this is done. I know it had to be done manually. Thank you very much for the effort! He's script will continue to look for bo

Re: [Intel-gfx] [PATCH] i915: don't call drm_atomic_state_put on invalid pointer

2016-10-18 Thread Chris Wilson
On Tue, Oct 18, 2016 at 05:16:23PM +0200, Arnd Bergmann wrote: > The introduction of reference counting on the state structures caused > sanitize_watermarks() in i915 to break in the error handling case, > as pointed out by gcc -Wmaybe-uninitialized > > drivers/gpu/drm/i915/intel_display.c: In fun

[Intel-gfx] [PATCH] drm/i915: KBL - Recommended buffer translation programming for DisplayPort

2016-10-18 Thread Rodrigo Vivi
According to spec: "KBL re-uses SKL values, except where specific KBL values are listed." And recently spec has changed adding different table for Display Port only. But for all SKUs (H,S,U,Y) we have slightly different values. v2: Fix wrong condition spotted by Jani. v3: Fix 7th entry of KBL H a

[Intel-gfx] [PATCH v2] mm/vmalloc: Replace opencoded 4-level page walkers

2016-10-18 Thread Chris Wilson
Rather than open-code the intricacies of walking the 4-level page tables, use the generic page table walker apply_to_page_range() instead. The important change is that it now cleans up after an unsuccessful insertion and propagates the correct error. The current failure may lead to a WARN if we en

  1   2   >