Hangcheck score has been zeroed on engine init, which happens
after reset recovery. This has worked well as we always reset
all engines on hang, and also discarded all work submitted
to engines.
With commit 821ed7df6e2a ("drm/i915: Update reset path to fix
incomplete requests") driver gained capab
On Thu, Oct 06, 2016 at 09:57:29AM +0300, Joonas Lahtinen wrote:
> On ke, 2016-10-05 at 21:05 +0100, Chris Wilson wrote:
> > In order not to trigger hangcheck on a idle-but-waiting engine, we need
> > to distinguish between the pending request queue and the actual
> > execution queue. This is done
On Thu, Oct 06, 2016 at 10:00:09AM +0300, Mika Kuoppala wrote:
> Hangcheck score has been zeroed on engine init, which happens
> after reset recovery. This has worked well as we always reset
> all engines on hang, and also discarded all work submitted
> to engines.
>
> With commit 821ed7df6e2a ("d
On Thu, 06 Oct 2016, "Vivi, Rodrigo" wrote:
> On Tue, 2016-10-04 at 10:05 +0300, Jani Nikula wrote:
>> On Tue, 04 Oct 2016, "Vivi, Rodrigo" wrote:
>> > On Mon, 2016-10-03 at 13:50 +0300, Jani Nikula wrote:
>> >> On Fri, 30 Sep 2016, Rodrigo Vivi wrote:
>> >> > According to spec: "KBL re-uses SKL
On Thu, Oct 06, 2016 at 07:51:46AM +0100, Chris Wilson wrote:
> On Thu, Oct 06, 2016 at 09:31:32AM +0300, Petri Latvala wrote:
> > See tests/intel-ci/README for rationale and explanation.
>
> A lot of those tests are garbage and not future proof making them
> useless for regression testing. Includ
On Thu, Oct 06, 2016 at 09:31:32AM +0300, Petri Latvala wrote:
> See tests/intel-ci/README for rationale and explanation.
>
> Signed-off-by: Petri Latvala
> ---
>
>
> The plans for CI are to use explicit test lists in the future, as laid
> out in this commit. Comments, acks, nacks, flames, etc
On 05/10/2016 18:01, Ville Syrjälä wrote:
On Wed, Oct 05, 2016 at 01:33:28PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
unsigned long is too wide - use smaller types in
struct cxsr_latency to save 800-something bytes of .rodata.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i91
On 06/10/2016 07:58, Joonas Lahtinen wrote:
On ke, 2016-10-05 at 17:53 +0100, Tvrtko Ursulin wrote:
On 05/10/2016 17:50, Tvrtko Ursulin wrote:
On 05/10/2016 16:07, Joonas Lahtinen wrote:
On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Use types of more appropr
On 05/10/2016 18:16, Ville Syrjälä wrote:
On Wed, Oct 05, 2016 at 01:33:31PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
This saves 3248 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 8 +++---
drivers/gpu/drm/i915/intel_crt.c
If we run out of enough aperture space to fit the entire object, we
fallback to trying to insert a single page. However, if that also fails,
we currently fail to userspace with an unexpected ENOSPC. (ENOSPC means
to userspace that their batch could not be fitted within the GTT.) Prior
to commit e8c
== Series Details ==
Series: drm/i915: Save hangcheck score across resets
URL : https://patchwork.freedesktop.org/series/13367/
State : failure
== Summary ==
Series 13367v1 drm/i915: Save hangcheck score across resets
https://patchwork.freedesktop.org/api/1.0/series/13367/revisions/1/mbox/
Te
Chris Wilson writes:
> In order not to trigger hangcheck on a idle-but-waiting engine, we need
> to distinguish between the pending request queue and the actual
> execution queue. This is done later in "drm/i915: Enable multiple
> timelines" but for now we need a temporary fix to prevent blaming
== Series Details ==
Series: drm/i915: Force relocations via cpu if we run out of idle aperture
URL : https://patchwork.freedesktop.org/series/13368/
State : warning
== Summary ==
Series 13368v1 drm/i915: Force relocations via cpu if we run out of idle
aperture
https://patchwork.freedesktop.o
See tests/intel-ci/README for rationale and explanation.
v2: Use the current BAT set for fast-feedback.testlist first
Signed-off-by: Petri Latvala
---
Thanks for the feedback. This commit only contains the current test
set, extended test suites are left for future discussion.
tests/intel-ci/
Hi,
this series basically takes the facility for continuously capturing CRCs
of frames from the i915 driver and into the DRM core.
The idea is that test suites such as IGT use this information to check
that frames that are exected to be identical, also have identical CRC
values.
Other drivers fo
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions(+
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
v6: Rebased.
v7: Fix whitespace issue.
v9: Have intel_display_cr
The core provides now an ABI to userspace for generation of frame CRCs,
so implement the ->set_crc_source() callback and reuse as much code as
possible with the previous ABI implementation.
When handling the pageflip interrupt, we skip 1 or 2 frames depending on
the HW because they contain wrong v
At least when testing the kernel. In normal programs pretty much all
the dmesg noise would simply be replaced by debug asserts, but in the
kernel we try rely hard to not fall over minor inconsistencies.
Still for CI purposes there's not really a difference, hence don't
treat it as such.
Motivated
On Wed, Oct 05, 2016 at 11:48:26PM +0100, Lionel Landwerlin wrote:
> - -o*)
> - file=${1##-o}
> - shift
> - ;;
This breaks using -ofilename without spaces.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists
Along with the interrupt, we want to restore the fake-irq and
wait-timeout detection. If we use the breadcrumbs interface to setup the
interrupt as it wants, the auxiliary timers will also be restored.
Fixes: 821ed7df6e2a ("drm/i915: Update reset path to fix incomplete requests")
Signed-off-by: Ch
On 06/10/16 10:09, Petri Latvala wrote:
On Wed, Oct 05, 2016 at 11:48:26PM +0100, Lionel Landwerlin wrote:
- -o*)
- file=${1##-o}
- shift
- ;;
This breaks using -ofilename without spaces.
Oh right, I didn't realize that was an acceptable input.
L
On Thu, Oct 06, 2016 at 11:07:17AM +0200, Daniel Vetter wrote:
> At least when testing the kernel. In normal programs pretty much all
> the dmesg noise would simply be replaced by debug asserts, but in the
> kernel we try rely hard to not fall over minor inconsistencies.
>
> Still for CI purposes
Regardless of the list of tests we expect to pass, I think it's better
to have an actual list rather than relying on the name of the tests (as
we have been doing or are still doing, correct me if I'm wrong).
Thanks for doing this!
Acked-by: Lionel Landwerlin
On 06/10/16 09:54, Petri Latvala
On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote:
> The port registers related to the phys in broxton map to different
> channels and specific phys. Make that mapping explicit.
>
> Signed-off-by: Ander Conselvan de Oliveira
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 +
On Thu, Oct 06, 2016 at 11:07:17AM +0200, Daniel Vetter wrote:
> At least when testing the kernel. In normal programs pretty much all
> the dmesg noise would simply be replaced by debug asserts, but in the
> kernel we try rely hard to not fall over minor inconsistencies.
>
> Still for CI purposes
On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote:
> Information about which phy is dual channel is hardcoded in the phy init
> sequence. Split that to a separate struct so the init sequence is more
> generic.
>
> Signed-off-by: Ander Conselvan de Oliveira
> ---
> drivers/gpu/d
On 26/09/16 19:30, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> The global mode_config.rotation_property is going away, switch over to
> per-plane rotation_property.
>
> Not sure I got the annoying crtc rotation_property handling right.
> Might work, or migth not.
>
> v2: Dro
On to, 2016-10-06 at 12:56 +0300, Imre Deak wrote:
> On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote:
> > Information about which phy is dual channel is hardcoded in the phy
> > init
> > sequence. Split that to a separate struct so the init sequence is
> > more
> > generic.
> >
On 04/10/2016 14:32, Chris Wilson wrote:
On Tue, Oct 04, 2016 at 03:42:58PM +0300, Joonas Lahtinen wrote:
Sort DEV_INFO_FOR_EACH_FLAG to alphabetical order (except is_*).
Signed-off-by: Joonas Lahtinen
Ok. Looks like it should be easier to read.
Reviewed-by: Chris Wilson
Could you add some
On Wed, 05 Oct 2016, "Argotti, Yann" wrote:
>> > On Mon, 03 Oct 2016, Jairo Miramontes
>> > wrote:
>> > > This week regressions
>> >
>> > In the past we used "regression", "bisect_pending", and "bisected" in
>> > the bugzilla "Keywords" field. Can we start using those again, please?
>>
>> I thin
This comes handy if you want to look at your application output without
having to save it into a file. For example, use this with aubinator from
Mesa :
$ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app
v2: Fix handling empty command line option
v3: Fix command line concatenation (again
On Wed, Oct 05, 2016 at 11:48:27PM +0100, Lionel Landwerlin wrote:
> This comes handy if you want to look at your application output without
> having to save it into a file. For example, use this with aubinator from
> Mesa :
>
> $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app
>
> v2:
On Thu, 2016-10-06 at 13:11 +0300, Jani Nikula wrote:
> On Wed, 05 Oct 2016, "Argotti, Yann" wrote:
> >
> > >
> > > >
> > > > On Mon, 03 Oct 2016, Jairo Miramontes
> > > > wrote:
> > > > >
> > > > > This week regressions
> > > > In the past we used "regression", "bisect_pending", and "bisecte
On Thu, Oct 06, 2016 at 12:59:17PM +0300, Tomi Valkeinen wrote:
>
> On 26/09/16 19:30, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > The global mode_config.rotation_property is going away, switch over to
> > per-plane rotation_property.
> >
> > Not sure I got the annoying
On 06/10/16 13:30, Ville Syrjälä wrote:
> On Thu, Oct 06, 2016 at 12:59:17PM +0300, Tomi Valkeinen wrote:
>>
>> On 26/09/16 19:30, ville.syrj...@linux.intel.com wrote:
>>> From: Ville Syrjälä
>>>
>>> The global mode_config.rotation_property is going away, switch over to
>>> per-plane rotation_pr
Op 05-10-16 om 22:33 schreef Paulo Zanoni:
> Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu:
>> Having skl_wm_level contain all of the watermarks for each plane is
>> annoying since it prevents us from having any sort of object to
>> represent a single watermark level, something we take advantag
On 06/10/16 13:26, Conselvan De Oliveira, Ander wrote:
On Thu, 2016-10-06 at 13:11 +0300, Jani Nikula wrote:
On Wed, 05 Oct 2016, "Argotti, Yann" wrote:
On Mon, 03 Oct 2016, Jairo Miramontes
wrote:
This week regressions
In the past we used "regression", "bisect_pending", and "bisected
Op 05-10-16 om 17:33 schreef Lyude:
> While it (mostly) works, the code for handling watermarks on Skylake has been
> kind of ugly for a while. As well a lot of it isn't that friendly to atomic
> transactions, Lots of copy paste, redundant wm values, etc. While this isn't a
> full cleanup, it's a g
>
> On 06/10/16 13:26, Conselvan De Oliveira, Ander wrote:
> > On Thu, 2016-10-06 at 13:11 +0300, Jani Nikula wrote:
> >> On Wed, 05 Oct 2016, "Argotti, Yann" wrote:
> >>>
>
> >
> > On Mon, 03 Oct 2016, Jairo Miramontes
> > wrote:
> >>
> >> This week regressions
> >
Op 04-10-16 om 19:44 schreef Paulo Zanoni:
> Em Ter, 2016-10-04 às 14:37 -0300, Paulo Zanoni escreveu:
>> With the previous code we were only recomputing the DDB partitioning
>> for the CRTCs included in the atomic commit, so any other active
>> CRTCs
>> would end up having their DDB registers zero
On Wed, 2016-10-05 at 17:51 +0300, Imre Deak wrote:
> On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote:
> >
> > Use struct bxt_ddi_phy_info to hold information of where the Rcomp
> > resistor is located, instead of hard coding it in the init sequence.
> >
> > Note that this mov
From: Ville Syrjälä
Leave the normal "executing" and "exiting" breadcrumbs into dmesg when
running the test.
Signed-off-by: Ville Syrjälä
---
tests/drv_module_reload_basic | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tests/drv_module_reload_basic b/tests/drv
On to, 2016-10-06 at 14:50 +0300, Ander Conselvan De Oliveira wrote:
> On Wed, 2016-10-05 at 17:51 +0300, Imre Deak wrote:
> > On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira
> > wrote:
> > >
> > > Use struct bxt_ddi_phy_info to hold information of where the
> > > Rcomp
> > > resisto
On Thu, 06 Oct 2016, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Leave the normal "executing" and "exiting" breadcrumbs into dmesg when
> running the test.
>
> Signed-off-by: Ville Syrjälä
> ---
> tests/drv_module_reload_basic | 27 +++
> 1 file changed
On Mon, Sep 26, 2016 at 10:23:48AM -, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS
> 8700"
> URL : https://patchwork.freedesktop.org/series/12920/
> State : warning
>
> == Summary ==
>
> Series 12920v1 Series witho
On to, 2016-10-06 at 08:41 +0100, Chris Wilson wrote:
> If we run out of enough aperture space to fit the entire object, we
> fallback to trying to insert a single page. However, if that also fails,
> we currently fail to userspace with an unexpected ENOSPC. (ENOSPC means
> to userspace that their
On Thu, 06 Oct 2016, Ville Syrjälä wrote:
> On Mon, Sep 26, 2016 at 10:23:48AM -, Patchwork wrote:
>> == Series Details ==
>>
>> Series: series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS
>> 8700"
>> URL : https://patchwork.freedesktop.org/series/12920/
>> State : warning
On Thu, 06 Oct 2016, Jani Nikula wrote:
> On Thu, 06 Oct 2016, Ville Syrjälä wrote:
>> On Mon, Sep 26, 2016 at 10:23:48AM -, Patchwork wrote:
>>> == Series Details ==
>>>
>>> Series: series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS
>>> 8700"
>>> URL : https://patchwork.
Em Qua, 2016-10-05 às 23:37 +, Vivi, Rodrigo escreveu:
> Hi Daniel,
>
> So, can we close https://bugs.freedesktop.org/show_bug.cgi?id=97573
> with
> wontfix or notabug?
>
> I don't have a strong side on that actually, but Jani was against it
> it
> seems.
Just my opinion:
Considering that w
On Thu, Oct 06, 2016 at 03:17:45PM +0300, Jani Nikula wrote:
> On Thu, 06 Oct 2016, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > Leave the normal "executing" and "exiting" breadcrumbs into dmesg when
> > running the test.
> >
> > Signed-off-by: Ville Syrjälä
> > ---
> > t
On Thu, Oct 06, 2016 at 11:13:22AM +0100, Lionel Landwerlin wrote:
> This comes handy if you want to look at your application output without
> having to save it into a file. For example, use this with aubinator from
> Mesa :
>
> $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app
Why not
On 06/10/16 13:46, Ville Syrjälä wrote:
On Thu, Oct 06, 2016 at 11:13:22AM +0100, Lionel Landwerlin wrote:
This comes handy if you want to look at your application output without
having to save it into a file. For example, use this with aubinator from
Mesa :
$ intel_aubdump -c '/path/to/aubinat
We're reserving space in the workqueue early during request allocation.
This can be problematic if we get interrupted later in the process,
because we can end up in a state where GuC workqueue is seemingly full,
while the HW is idle and no work has been submitted.
Let's delay the reservation to avo
On Thu, Oct 06, 2016 at 03:14:19PM +0200, Michał Winiarski wrote:
> We're reserving space in the workqueue early during request allocation.
> This can be problematic if we get interrupted later in the process,
> because we can end up in a state where GuC workqueue is seemingly full,
> while the HW
On Thu, 06 Oct 2016, Paulo Zanoni wrote:
> Em Qua, 2016-10-05 às 23:37 +, Vivi, Rodrigo escreveu:
>> Hi Daniel,
>>
>> So, can we close https://bugs.freedesktop.org/show_bug.cgi?id=97573
>> with
>> wontfix or notabug?
>>
>> I don't have a strong side on that actually, but Jani was against it
Chris Wilson writes:
> Along with the interrupt, we want to restore the fake-irq and
> wait-timeout detection. If we use the breadcrumbs interface to setup the
> interrupt as it wants, the auxiliary timers will also be restored.
>
> Fixes: 821ed7df6e2a ("drm/i915: Update reset path to fix incompl
We reserve space in the GuC workqueue for submitting the request in the
future. However, if we fail to construct the request, we need to give
that reserved space back to the system.
Fixes: dadd481bfe55 ("drm/i915/guc: Prepare for nonblocking execbuf submission")
Bugzilla: https://bugs.freedesktop.
From: Ville Syrjälä
Leave the normal "executing" and "exiting" breadcrumbs into dmesg when
running the test.
Signed-off-by: Ville Syrjälä
---
tests/drm_lib.sh | 24
1 file changed, 24 insertions(+)
diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh
index 0eeab1c183c9..4
From: Ville Syrjälä
debugfs_wedged and drm_lib.sh are already using bashism so switch over
to using #!/bin/bash instead of #!/bin/sh.
Signed-off-by: Ville Syrjälä
---
tests/debugfs_wedged | 2 +-
tests/drm_lib.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/
From: Ville Syrjälä
No reason why 'intel_reg dump' can't declare success after a succesful
dumping. Spotted after fixing tools_test to use the right tool :)
Signed-off-by: Ville Syrjälä
---
tools/intel_reg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/intel_reg.c
From: Ville Syrjälä
intel_reg_read and intel_reg_dumper are no more. Switch over to intel_reg.
Signed-off-by: Ville Syrjälä
---
tests/tools_test | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/tools_test b/tests/tools_test
index 04878274e135..a27fb873b029 100755
-
From: Ville Syrjälä
Source drm_lib.sh instead of drm_getopt.sh so that we get the
"executing", and "exiting" breadcrumbs in dmesg.
Signed-off-by: Ville Syrjälä
---
tests/vgem_reload_basic | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vgem_reload_basic b/tests/vgem_r
On Thu, Oct 06, 2016 at 03:37:50PM +0300, Ville Syrjälä wrote:
> On Thu, Oct 06, 2016 at 03:17:45PM +0300, Jani Nikula wrote:
> > On Thu, 06 Oct 2016, ville.syrj...@linux.intel.com wrote:
> > > From: Ville Syrjälä
> > >
> > > Leave the normal "executing" and "exiting" breadcrumbs into dmesg when
>
On Thu, Oct 06, 2016 at 04:32:37PM +0300, Mika Kuoppala wrote:
> Chris Wilson writes:
>
> > Along with the interrupt, we want to restore the fake-irq and
> > wait-timeout detection. If we use the breadcrumbs interface to setup the
> > interrupt as it wants, the auxiliary timers will also be resto
== Series Details ==
Series: drm/i915/guc: Delay GuC workqueue reservation
URL : https://patchwork.freedesktop.org/series/13388/
State : warning
== Summary ==
Series 13388v1 drm/i915/guc: Delay GuC workqueue reservation
https://patchwork.freedesktop.org/api/1.0/series/13388/revisions/1/mbox/
Chris Wilson writes:
> On Thu, Oct 06, 2016 at 04:32:37PM +0300, Mika Kuoppala wrote:
>> Chris Wilson writes:
>>
>> > Along with the interrupt, we want to restore the fake-irq and
>> > wait-timeout detection. If we use the breadcrumbs interface to setup the
>> > interrupt as it wants, the auxil
On Thu, Oct 06, 2016 at 02:34:46PM +0100, Chris Wilson wrote:
> We reserve space in the GuC workqueue for submitting the request in the
> future. However, if we fail to construct the request, we need to give
> that reserved space back to the system.
>
> Fixes: dadd481bfe55 ("drm/i915/guc: Prepare
On Thu, Oct 06, 2016 at 05:02:44PM +0300, Mika Kuoppala wrote:
> Chris Wilson writes:
>
> > On Thu, Oct 06, 2016 at 04:32:37PM +0300, Mika Kuoppala wrote:
> >> Chris Wilson writes:
> >>
> >> > Along with the interrupt, we want to restore the fake-irq and
> >> > wait-timeout detection. If we use
== Series Details ==
Series: drm/i915/guc: Unwind GuC workqueue reservation if request construction
fails
URL : https://patchwork.freedesktop.org/series/13390/
State : success
== Summary ==
Series 13390v1 drm/i915/guc: Unwind GuC workqueue reservation if request
construction fails
https://pa
Hi,
this series basically takes the facility for continuously capturing CRCs
of frames from the i915 driver and into the DRM core.
The idea is that test suites such as IGT use this information to check
that frames that are exected to be identical, also have identical CRC
values.
Other drivers fo
The core provides now an ABI to userspace for generation of frame CRCs,
so implement the ->set_crc_source() callback and reuse as much code as
possible with the previous ABI implementation.
When handling the pageflip interrupt, we skip 1 or 2 frames depending on
the HW because they contain wrong v
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
v6: Rebased.
v7: Fix whitespace issue.
v9: Have intel_display_cr
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions(+
This comes handy if you want to look at your application output without
having to save it into a file. For example, use this with aubinator from
Mesa :
$ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app
v2: Fix handling empty command line option
v3: Fix command line concatenation (again
This makes parsing options less complicated and easier to extend.
Signed-off-by: Lionel Landwerlin
---
tools/aubdump.c| 32 ++--
tools/intel_aubdump.in | 22 +++---
2 files changed, 37 insertions(+), 17 deletions(-)
diff --git a/tools/aubdump.
For some reason init() seems to be called multiple times. Let's move the
initialization to the first ioctl().
Signed-off-by: Lionel Landwerlin
---
tools/aubdump.c | 44
1 file changed, 28 insertions(+), 16 deletions(-)
diff --git a/tools/aubdump.c b/
Hi,
this series basically takes the facility for continuously capturing CRCs
of frames from the i915 driver and into the DRM core.
The idea is that test suites such as IGT use this information to check
that frames that are exected to be identical, also have identical CRC
values.
Other drivers fo
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
v6: Rebased.
v7: Fix whitespace issue.
v9: Have intel_display_cr
The core provides now an ABI to userspace for generation of frame CRCs,
so implement the ->set_crc_source() callback and reuse as much code as
possible with the previous ABI implementation.
When handling the pageflip interrupt, we skip 1 or 2 frames depending on
the HW because they contain wrong v
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions(+
Along with the interrupt, we want to restore the fake-irq and
wait-timeout detection. If we use the breadcrumbs interface to setup the
interrupt as it wants, the auxiliary timers will also be restored.
v2: Cancel both timers as well, sanitize the IMR.
Fixes: 821ed7df6e2a ("drm/i915: Update reset
The phy in broxton is also a dpio phy, similar to cherryview but with
programming through MMIO. So move the code together with the other
similar phys.
Signed-off-by: Ander Conselvan de Oliveira
Reviewed-by: Imre Deak
---
drivers/gpu/drm/i915/i915_drv.h | 12 +-
drivers/gpu/drm/i915/inte
The port registers related to the phys in broxton map to different
channels and specific phys. Make that mapping explicit.
v2: Pass enum dpio_phy to macros instead of mmio base. (Imre)
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/dr
Calling it data seems to imply arbitrary data can be associated with the
power well. However, that field is used for look ups and expected to be
unique, so rename it.
Signed-off-by: Ander Conselvan de Oliveira
Reviewed-by: Imre Deak
---
drivers/gpu/drm/i915/i915_drv.h | 3 +-
drivers
Information about which phy is dual channel is hardcoded in the phy init
sequence. Split that to a separate struct so the init sequence is more
generic.
v2: Restore mangled part that ended up in following patch. (Imre)
Signed-off-by: Ander Conselvan de Oliveira
Reviewed-by: Imre Deak
---
driv
Update series with review addressed. Changes since v1:
- Use lockdep_assert_help() in bxt_ddi_phy_init().
- Fix mangled patch.
- Pass enum dpio_phy instead of mmio base to macroc.
Thanks,
Ander
Ander Conselvan de Oliveira (9):
drm/i915: Rename struct i915_power_well field data to id
dr
The vswing sequence is related to the DPIO phy, so move it closer to the
rest of DPIO phy related code.
Signed-off-by: Ander Conselvan de Oliveira
Reviewed-by: Imre Deak
---
drivers/gpu/drm/i915/i915_drv.h | 3 ++-
drivers/gpu/drm/i915/intel_ddi.c | 38 +++
The mapping from the BXT_DPIO_CMN_* power wells to their respective phys
required a detour implemented in the bxt_power_well_to_phy() function.
Instead, embed that information directly into the power_well struct, by
resurrecting the data field.
Signed-off-by: Ander Conselvan de Oliveira
Reviewed
Pass lane count to bxt_ddi_phy_calc_lane_optmin_mask() instead of having
it extract that number from a pipe_config to decouple the phy code from
intel_crtc_state.
Signed-off-by: Ander Conselvan de Oliveira
Reviewed-by: Imre Deak
---
drivers/gpu/drm/i915/intel_ddi.c | 8
1 file changed
Move the DPIO phy documentation section to intel_dpio_phy.c, since that
is a more suitable place now that there is a source file dedicated for
those phys.
Signed-off-by: Ander Conselvan de Oliveira
Reviewed-by: Imre Deak
---
Documentation/gpu/i915.rst| 2 +-
drivers/gpu/drm/i915/i
Use struct bxt_ddi_phy_info to hold information of where the Rcomp
resistor is located, instead of hard coding it in the init sequence.
Note that this moves the enabling of the phy with the Rcomp resistor out
of the power well enable code. That should be safe since
bxt_ddi_phy_init() is called whi
On 05/10/2016 18:11, Ville Syrjälä wrote:
On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Use types of more appropriate size in struct
intel_watermark_params to save 512 bytes of .rodata.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_drv
== Series Details ==
Series: drm/i915: Reset the breadcrumbs IRQ more carefully (rev2)
URL : https://patchwork.freedesktop.org/series/13375/
State : warning
== Summary ==
Series 13375v2 drm/i915: Reset the breadcrumbs IRQ more carefully
https://patchwork.freedesktop.org/api/1.0/series/13375/re
On Thu, Oct 06, 2016 at 05:38:12PM +0100, Tvrtko Ursulin wrote:
>
> On 05/10/2016 18:11, Ville Syrjälä wrote:
> > On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote:
> >> From: Tvrtko Ursulin
> >>
> >> Use types of more appropriate size in struct
> >> intel_watermark_params to save 51
== Series Details ==
Series: Broxton ddi phy refactoring (rev2)
URL : https://patchwork.freedesktop.org/series/13320/
State : warning
== Summary ==
Series 13320v2 Broxton ddi phy refactoring
https://patchwork.freedesktop.org/api/1.0/series/13320/revisions/2/mbox/
Test kms_pipe_crc_basic:
According to spec: "KBL re-uses SKL values, except where
specific KBL values are listed."
And recently spec has changed adding different table for Display Port only.
But for all SKUs (H,S,U,Y) we have slightly different values.
v2: Fix wrong condition spotted by Jani.
Cc: Jani Nikula
Cc: Manasi
>-Original Message-
>From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
>Sent: Wednesday, October 5, 2016 11:57 PM
>To: Srivatsa, Anusha
>Cc: intel-gfx@lists.freedesktop.org
>Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default
>
>On Wed, Oct 05, 2016 at 04:20:04PM -0700,
I also asked that same question many times. Maybe they can be unified
later when we enable submission by default, but right now I believe
this is the way to go, so
Reviewed-by: Rodrigo Vivi
On Thu, Oct 6, 2016 at 11:03 AM, Srivatsa, Anusha
wrote:
>
>
>>-Original Message-
>>From: Chris
== Series Details ==
Series: series starting with [1/2] drm/i915: Move down skl/kbl ddi iboost and
n_edp_entires fixup (rev2)
URL : https://patchwork.freedesktop.org/series/13171/
State : warning
== Summary ==
Series 13171v2 Series without cover letter
https://patchwork.freedesktop.org/api/1.
1 - 100 of 110 matches
Mail list logo
