Re: [Intel-gfx] [PATCH v2 11/14] drm/i915: Fallback to lower link rate and lane count during link training

2016-09-07 Thread Manasi Navare
On Wed, Sep 07, 2016 at 12:47:49PM +0300, Mika Kahola wrote: > On Tue, 2016-09-06 at 17:13 -0700, Manasi Navare wrote: > > According to the DisplayPort Spec, in case of Clock Recovery failure > > the link training sequence should fall back to the lower link rate > > followed by lower lane count unt

[Intel-gfx] [PATCH] drm: Fix error path in drm_mode_page_flip_ioctl()

2016-09-07 Thread Imre Deak
This fixes the error path for platforms that don't define the new page_flip_target() hook. Fixes: c229bfbbd04 ("drm: Add page_flip_target CRTC hook v2") Testcase: igt/kms_flip/basic-flip-vs-dpms CC: Michel Dänzer Signed-off-by: Imre Deak --- drivers/gpu/drm/drm_crtc.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH v6] drm: two more (drm_)printk() wrapper macros (fixup)

2016-09-07 Thread Dave Gordon
Between v2 and v3 of this patch, c4e68a583202 ("drm: Introduce DRM_DEV_* log messages") was introduced upstream, and this was the reason for the rewrite as v3. Unfortunately a maintainer pushed the earlier version to drm-intel-next 30b0da8d556e ("drm: extra printk() wrapper macros") creating a

Re: [Intel-gfx] [PATCH v2] drm/i915: don't track relative-constants-mode

2016-09-07 Thread Dave Gordon
On 26/08/16 20:55, Chris Wilson wrote: On Fri, Aug 26, 2016 at 08:46:25PM +0100, Dave Gordon wrote: @@ -1520,6 +1528,14 @@ static void eb_export_fence(struct drm_i915_gem_object *obj, if (ret) return ret; + if (instp_mode != I915_EXEC_CONSTANTS_REL_GENERAL) { +

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Fix error path in drm_mode_page_flip_ioctl()

2016-09-07 Thread Patchwork
== Series Details == Series: drm: Fix error path in drm_mode_page_flip_ioctl() URL : https://patchwork.freedesktop.org/series/12129/ State : failure == Summary == Series 12129v1 drm: Fix error path in drm_mode_page_flip_ioctl() http://patchwork.freedesktop.org/api/1.0/series/12129/revisions/1/

[Intel-gfx] [CI_RESEND v4 1/5] drm/i915/guc: symbolic names for GuC submission preferences

2016-09-07 Thread Dave Gordon
The existing code that accesses the "enable_guc_submission" parameter uses explicit numerical values for the various possibilities, including in one case relying on boolean 0/1 mapping to specific values (which could be confusing for maintainers). So this patch just provides and uses names for the

[Intel-gfx] [CI_RESEND v4 3/5] drm/i915/guc: symbolic name for GuC log-level none

2016-09-07 Thread Dave Gordon
The existing code that accesses the "guc_log_level" parameter uses an explicit numerical value for the "no logging" case, whereas there are symbolic names for the other levels. So this patch just provides and uses a name for the default log level (NONE), with the same numeric value that is already

[Intel-gfx] [CI_RESEND v4 0/5] drm/i915/guc: use symbolic names for module parameter values

2016-09-07 Thread Dave Gordon
There are various literal constants used in the GuC module-parameter processing code; this sequence of patches replaces them with symbolic names for greater clarity. And then it re-enables GuC submission by default v3: Original patch broken into two (1/4 + 2/4) Name for GuC log level NONE ad

[Intel-gfx] [CI_RESEND v4 2/5] drm/i915/guc: symbolic names for GuC firmare loading preferences

2016-09-07 Thread Dave Gordon
The existing code that accesses the "enable_guc_loading" parameter uses explicit numerical values for the various possibilities, including in one case relying on boolean 0/1 mapping to specific values (which could be confusing for maintainers). So this patch just provides and uses names for the v

[Intel-gfx] [CI_RESEND v4 5/5] drm/i915/guc: ignore unrecognised loading & submission options

2016-09-07 Thread Dave Gordon
Previously the code allowed *any* values for the enable_guc_loading and enable_guc_submission parameters, and forced them into range by clipping at each extremum. This version instead ignores unknown values, treating them as DEFAULT (which then gets converted to DISABLED or PREFERRED). Of course w

[Intel-gfx] [CI_RESEND v4 4/5] drm/i915/guc: use symbolic names in setting defaults for module parameters

2016-09-07 Thread Dave Gordon
Of course, this also re-enables GuC loading and submission by default on suitable platforms, since it's Intel's Plan of Record that GuC submission shall be used where available. Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_params.c | 10 +- 1 file changed, 5 insertions(+), 5

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: two more (drm_)printk() wrapper macros (fixup)

2016-09-07 Thread Patchwork
== Series Details == Series: drm: two more (drm_)printk() wrapper macros (fixup) URL : https://patchwork.freedesktop.org/series/12130/ State : failure == Summary == Series 12130v1 drm: two more (drm_)printk() wrapper macros (fixup) http://patchwork.freedesktop.org/api/1.0/series/12130/revision

[Intel-gfx] [PATCH v3 11/14] drm/i915: Fallback to lower link rate and lane count during link training

2016-09-07 Thread Manasi Navare
According to the DisplayPort Spec, in case of Clock Recovery failure the link training sequence should fall back to the lower link rate followed by lower lane count until CR succeeds. On CR success, the sequence proceeds with Channel EQ. In case of Channel EQ failures, it should fallback to lower l

[Intel-gfx] [PATCH v13 13/14] drm/i915/dp: Enable Upfront link training for typeC DP support on HSW/BDW/SKL/BXT (DDI platforms)

2016-09-07 Thread Manasi Navare
From: Durgadoss R To support USB type C alternate DP mode, the display driver needs to know the number of lanes required by the DP panel as well as number of lanes that can be supported by the type-C cable. Sometimes, the type-C cable may limit the bandwidth even if Panel can support more lanes.

[Intel-gfx] [PATCH v3 9/14] drm/dp/i915: Make clock recovery in the link training compliant with DP Spec 1.2

2016-09-07 Thread Manasi Navare
From: Dhinakaran Pandiyan This function cleans up clock recovery loop in link training compliant tp Dp Spec 1.2. It tries the clock recovery 5 times for the same voltage or until max voltage swing is reached and removes the additional non compliant retries. This function now returns a boolean val

[Intel-gfx] [PATCH v3 8/14] drm/i915/dp: Move max. vswing check to it's own function

2016-09-07 Thread Manasi Navare
From: Dhinakaran Pandiyan Wrap the max. vswing check in a separate function. This makes the clock recovery phase of DP link training cleaner v3: Fixed the paranthesis warning (Mika Kahola) v2: Fixed the Compiler warning (Mika Kahola) Signed-off-by: Dhinakaran Pandiyan Signed-off-by: Manasi Nav

Re: [Intel-gfx] [PATCH v8 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

2016-09-07 Thread Jim Bride
On Wed, Aug 17, 2016 at 01:49:42PM +0300, Mika Kahola wrote: > Let's remove reference to "struct intel_connector *connector" > in intel_dp_aux_init() function as it is no longer required. > > Signed-off-by: Mika Kahola Reviewed-by: Jim Bride > --- > drivers/gpu/drm/i915/intel_dp.c | 4 ++-- >

Re: [Intel-gfx] [PATCH v8 07/12] drm/i915: Read DP branch device HW revision

2016-09-07 Thread Jim Bride
On Wed, Aug 17, 2016 at 01:49:43PM +0300, Mika Kahola wrote: > HW revision is mandatory field for DisplayPort branch > devices. This is defined in DPCD register field 0x509. > > v2: move drm_dp_ds_revision structure to be part of > drm_dp_link structure (Daniel) > v3: remove dependency to drm_

Re: [Intel-gfx] Linux 4.8-rc?: WARNING: at drivers/gpu/drm/i915/intel_pm.c:7866 sandybridge_pcode_write Missing switch case (16) in gen6_check_mailbox_status

2016-09-07 Thread Sander Eikelenboom
On 2016-09-07 16:49, Jani Nikula wrote: On Tue, 06 Sep 2016, li...@eikelenboom.it wrote: On 2016-09-06 11:25, Jani Nikula wrote: On Tue, 06 Sep 2016, li...@eikelenboom.it wrote: L.S., Since one of the last 4.8 RC's i'm getting the warning below when booting on my sandybridge based thinkpad.

Re: [Intel-gfx] [PATCH v8 08/12] drm/i915: Read DP branch device SW revision

2016-09-07 Thread Jim Bride
On Wed, Aug 17, 2016 at 01:49:44PM +0300, Mika Kahola wrote: > SW revision is mandatory field for DisplayPort branch > devices. This is defined in DPCD register field 0x50A. To be precise, the revision info is in 0x50A and 0x50B. Since both the major and minor versions are called out separately in

Re: [Intel-gfx] [PATCH v8 09/12] Check pixel rate for DP to VGA dongle

2016-09-07 Thread Jim Bride
On Wed, Aug 17, 2016 at 01:49:45PM +0300, Mika Kahola wrote: > Filter out a mode that exceeds the max pixel rate setting > for DP to VGA dongle. This is defined in DPCD register 0x81 > if detailed cap info i.e. info field is 4 bytes long and > it is available for DP downstream port. > > The regist

Re: [Intel-gfx] [PATCH v8 10/12] drm/i915: Update bits per component for display info

2016-09-07 Thread Jim Bride
On Wed, Aug 17, 2016 at 01:49:47PM +0300, Mika Kahola wrote: > DisplayPort branch device may define max supported bits per > component. Update display info based on this value if bpc > is defined. > > v2: cleanup to match the drm_dp_helper.c patches introduced > earlier in this series > v3: Fi

Re: [Intel-gfx] [PATCH v8 11/12] drm: Add DP branch device info on debugfs

2016-09-07 Thread Jim Bride
On Wed, Aug 17, 2016 at 01:49:48PM +0300, Mika Kahola wrote: > Read DisplayPort branch device info from through debugfs > interface. > > v2: use drm_dp_helper routines to collect data > v3: cleanup to match the drm_dp_helper.c patches introduced > earlier in this series > v4: move DP branch de

Re: [Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

2016-09-07 Thread Jim Bride
On Wed, Aug 17, 2016 at 01:49:49PM +0300, Mika Kahola wrote: > Respect max TMDS clock frequency from DPCD for active > DP to HDMI adapters. > > Signed-off-by: Mika Kahola Reviewed-by: Jim Bride > --- > drivers/gpu/drm/i915/intel_drv.h | 3 +++ > drivers/gpu/drm/i915/intel_hdmi.c | 27 ++

Re: [Intel-gfx] [PATCH v3 07/14] drm/i915/dp: Add a standalone function to obtain shared dpll for HSW/BDW/SKL/BXT

2016-09-07 Thread Manasi Navare
On Fri, Sep 02, 2016 at 01:06:32PM -0700, Pandiyan, Dhinakaran wrote: > On Thu, 2016-09-01 at 15:08 -0700, Manasi Navare wrote: > > From: Jim Bride > > > > Add the PLL selection code for HSW/BDW/BXT/SKL into a stand-alone function > > in order to allow for the implementation of a platform neutral

[Intel-gfx] [PATCH v4 7/14] drm/i915/dp: Add a standalone function to obtain shared dpll for HSW/BDW/SKL/BXT

2016-09-07 Thread Manasi Navare
From: Jim Bride Add the PLL selection code for HSW/BDW/BXT/SKL into a stand-alone function in order to allow for the implementation of a platform neutral upfront link training function. v4: * Removed dereferencing NULL pointer in case of failure (Dhinakaran Pandiyan) v3: * Add Hooks for all DDI

Re: [Intel-gfx] [PATCH v4 06/22] drm/i915: Get rid of HAS_CORE_RING_FREQ

2016-09-07 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Wed, Aug 17, 2016 at 12:30:41PM -0700, Carlos Santa wrote: > No need for HAS_CORE_RING_FREQ as that flag is actually the same as > .has_llc. Feedback from V. Syrjala. > > Signed-off-by: Carlos Santa > --- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > drivers/gp

Re: [Intel-gfx] [PATCH v4 10/22] drm/i915: Move HAS_RC6p definition to platform definition

2016-09-07 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Wed, Aug 17, 2016 at 12:30:45PM -0700, Carlos Santa wrote: > Moving all GPU features to the platform struct definition allows for > - standard place when adding new features from new platforms > - possible to see supported features when dumping struct >

Re: [Intel-gfx] [PATCH v4 05/22] drm/i915: Remove runtime PM for SNB

2016-09-07 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Wed, Aug 17, 2016 at 12:30:40PM -0700, Carlos Santa wrote: > Remove runtime PM support for SNB as it breaks hotplug support. > Feedback from V. Syrjala. > > Signed-off-by: Carlos Santa > --- > drivers/gpu/drm/i915/i915_pci.c | 1 - > 1 file changed, 1 deletion(-)

Re: [Intel-gfx] [PATCH v4 04/22] drm/i915: Move HAS_RUNTIME_PM definition to platform

2016-09-07 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Wed, Aug 17, 2016 at 12:30:39PM -0700, Carlos Santa wrote: > Moving all GPU features to the platform struct definition allows for > - standard place when adding new features from new platforms > - possible to see supported features when dumping struct >

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dsi: silence a warning about uninitialized return value

2016-09-07 Thread Nicolas Iooss
On 07/09/16 18:03, Dave Gordon wrote: > On 06/09/16 21:36, Nicolas Iooss wrote: >> On 06/09/16 12:21, Dave Gordon wrote: >>> On 04/09/16 19:58, Nicolas Iooss wrote: When building the kernel with clang and some warning flags, the compiler reports that the return value of dcs_get_backl

Re: [Intel-gfx] [PATCH 5/8] drm/i915/gen9: minimum scanlines for Y tile is not always 4

2016-09-07 Thread Lyude
On Tue, 2016-09-06 at 21:52 -0300, Paulo Zanoni wrote: > During watermarks calculations, this value is used in 3 different > places. Only one of them was not using a hardcoded 4. Move the code > up > so everybody can benefit from the actual value. > > This should only help on situations with Y til

Re: [Intel-gfx] [PATCH 0/8] SKL/KBL watermark fixes

2016-09-07 Thread Lyude
For patches 6-8: Reviewed-by: Lyude On Tue, 2016-09-06 at 21:52 -0300, Paulo Zanoni wrote: > Hi > > This series is the result of me comparing the code against BSpec. It > doesn't solve any particular problem I was seeing, but there's enough > changes that this code could potentially change the

Re: [Intel-gfx] [PATCH 01/10] drm: Move a few macros away from drm_crtc.h

2016-09-07 Thread Carlos Santa
On Wed, 2016-08-31 at 18:09 +0200, Daniel Vetter wrote: > Now that there's less stuff in there I noticed that I overlooked > them. > Sprinkle some docs over them while at it. > > Signed-off-by: Daniel Vetter > --- >  include/drm/drm_connector.h   | 24 ++-- >  include/drm/drm_c

[Intel-gfx] [PATCH v4 11/14] drm/i915: Fallback to lower link rate and lane count during link training

2016-09-07 Thread Manasi Navare
According to the DisplayPort Spec, in case of Clock Recovery failure the link training sequence should fall back to the lower link rate followed by lower lane count until CR succeeds. On CR success, the sequence proceeds with Channel EQ. In case of Channel EQ failures, it should fallback to lower l

Re: [Intel-gfx] Regression in v4.8-rc4: i915 flickering since commit 1c80c25fb6

2016-09-07 Thread Vivi, Rodrigo
On Wed, 2016-09-07 at 15:37 +0300, Jani Nikula wrote: > On Sun, 04 Sep 2016, Dominik Brodowski wrote: > > Hi! > > > > Since commit 1c80c25fb6 (determined by git bisect, and confirmed by > > reverting this patch on top of 9ca581b50d), the sceen on my DELL XPS 13 > > is flickering every once in a wh

[Intel-gfx] [PATCH] Revert "drm/i915/psr: Make idle_frames sensible again"

2016-09-07 Thread Rodrigo Vivi
This reverts commit 1c80c25fb622973dd135878e98d172be20859049. There are panels that needs 4 idle frames before entering PSR, but VBT is unproperly set. Also lately it was identified that idle frame count calculated at HW can be off by 1, what makes the minimum of 2, at least. Without the current

[Intel-gfx] ✗ Fi.CI.BAT: warning for Revert "drm/i915/psr: Make idle_frames sensible again"

2016-09-07 Thread Patchwork
== Series Details == Series: Revert "drm/i915/psr: Make idle_frames sensible again" URL : https://patchwork.freedesktop.org/series/12148/ State : warning == Summary == Series 12148v1 Revert "drm/i915/psr: Make idle_frames sensible again" http://patchwork.freedesktop.org/api/1.0/series/12148/re

[Intel-gfx] linux-next: manual merge of the drm-intel tree with Linus' tree

2016-09-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/intel_pm.c between commit: 9909113cc48a ("drm/i915/gen9: Only copy WM results for changed pipes to skl_hw") from Linus' tree and commits: 2722efb90b34 ("drm/i915/gen9: Only copy WM results fo

Re: [Intel-gfx] [PATCH] drm: Fix error path in drm_mode_page_flip_ioctl()

2016-09-07 Thread Michel Dänzer
On 08/09/16 02:23 AM, Imre Deak wrote: > This fixes the error path for platforms that don't define the new > page_flip_target() hook. > > Fixes: c229bfbbd04 ("drm: Add page_flip_target CRTC hook v2") > Testcase: igt/kms_flip/basic-flip-vs-dpms > CC: Michel Dänzer > Signed-off-by: Imre Deak > ---

Re: [Intel-gfx] [PATCH v2 18/22] drm/i915: Ignore valid but unknown semaphores

2016-09-07 Thread Joonas Lahtinen
On ke, 2016-09-07 at 15:45 +0100, Chris Wilson wrote: > If we find a ring waiting on a semaphore for another assigned but not yet > emitted request, treat it as valid and waiting. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Techn

<    1   2