[Intel-gfx] [PATCH i-g-t v2 5/8] tests/gem_sync: Remove basic tests.

2016-05-27 Thread Marius Vlad
Signed-off-by: Marius Vlad --- tests/gem_sync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem_sync.c b/tests/gem_sync.c index 320bce3..a46f120 100644 --- a/tests/gem_sync.c +++ b/tests/gem_sync.c @@ -221,12 +221,12 @@ igt_main sync_ring(

[Intel-gfx] [PATCH i-g-t v2 6/8] tests/gem_storedw_loop: Remove from BAT.

2016-05-27 Thread Marius Vlad
Signed-off-by: Marius Vlad --- tests/gem_storedw_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c index 317b8c6..a0c5af1 100644 --- a/tests/gem_storedw_loop.c +++ b/tests/gem_storedw_loop.c @@ -185,7 +185,7 @@ igt_main

[Intel-gfx] [PATCH i-g-t v2 2/8] tests/gem_ctx_switch: Remove test from BAT.

2016-05-27 Thread Marius Vlad
Signed-off-by: Marius Vlad --- tests/gem_ctx_switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_ctx_switch.c b/tests/gem_ctx_switch.c index 7b27336..ce52365 100644 --- a/tests/gem_ctx_switch.c +++ b/tests/gem_ctx_switch.c @@ -157,7 +157,7 @@ igt_main ig

[Intel-gfx] [PATCH i-g-t v2 1/8] tests/gem_exec_flush: Remove tests from BAT.

2016-05-27 Thread Marius Vlad
Signed-off-by: Marius Vlad --- tests/gem_exec_flush.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/tests/gem_exec_flush.c b/tests/gem_exec_flush.c index d08b843..2f271bb 100644 --- a/tests/gem_exec_flush.c +++ b/tests/gem_exec_flush.c @@ -532,18 +532,15 @@

[Intel-gfx] [PATCH i-g-t v2 4/8] tests/gem_close_race: Remove basic-threads from BAT.

2016-05-27 Thread Marius Vlad
Signed-off-by: Marius Vlad --- tests/gem_close_race.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_close_race.c b/tests/gem_close_race.c index 94fb905..80da731 100644 --- a/tests/gem_close_race.c +++ b/tests/gem_close_race.c @@ -231,7 +231,7 @@ igt_main

[Intel-gfx] [PATCH i-g-t v2 3/8] tests/gem_exec_nop: Remove test from BAT.

2016-05-27 Thread Marius Vlad
Signed-off-by: Marius Vlad --- tests/gem_exec_nop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/gem_exec_nop.c b/tests/gem_exec_nop.c index e90d5eb..8b31b27 100644 --- a/tests/gem_exec_nop.c +++ b/tests/gem_exec_nop.c @@ -212,9 +212,6 @@ igt_main igt_fork_hang_detector(d

[Intel-gfx] [PATCH i-g-t v2 7/8] tests/gem_tile_pread_basic: Remove gem_tiled_pread_basic from BAT.

2016-05-27 Thread Marius Vlad
Test is renamed to gem_tiled_pread. Signed-off-by: Marius Vlad --- tests/Makefile.sources| 2 +- tests/gem_tiled_pread.c | 228 ++ tests/gem_tiled_pread_basic.c | 215 --- 3 files changed, 229 insertions(

[Intel-gfx] [PATCH i-g-t 8/8] tests/gem_exec_suspend: Remove hibernate from BAT.

2016-05-27 Thread Marius Vlad
We are already skipping this test in CI on more than one platform, so migrate them to nightly. Signed-off-by: Marius Vlad --- tests/gem_exec_suspend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_exec_suspend.c b/tests/gem_exec_suspend.c index cd133cc..3d529bd 10

Re: [Intel-gfx] [PATCH i-g-t v2 1/8] tests/gem_exec_flush: Remove tests from BAT.

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 07:27:46PM +0300, Marius Vlad wrote: You are lacking an explanation. Please tell me what this test is about and why it is not suitable criteria for a basic acceptance test. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___

Re: [Intel-gfx] [PATCH i-g-t 8/8] tests/gem_exec_suspend: Remove hibernate from BAT.

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 07:27:53PM +0300, Marius Vlad wrote: > We are already skipping this test in CI on more than one platform, > so migrate them to nightly. And? So QA is failing, don't bother testing at all? -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH i-g-t v2 2/8] tests/gem_ctx_switch: Remove test from BAT.

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 07:27:47PM +0300, Marius Vlad wrote: Nak. This catches bugs quickly. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/li

Re: [Intel-gfx] [PATCH i-g-t v2 4/8] tests/gem_close_race: Remove basic-threads from BAT.

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 07:27:49PM +0300, Marius Vlad wrote: Please explain why. And why this approach. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org

Re: [Intel-gfx] [PATCH i-g-t v2 3/8] tests/gem_exec_nop: Remove test from BAT.

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 07:27:48PM +0300, Marius Vlad wrote: Why? -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] Gvim causes Xorg to crash in Intel driver

2016-05-27 Thread Edd Barrett
Hello everyone, I raised a bug [1] a few days ago about a crash in the Intel driver's SNA code on OpenBSD. I'm posting here to try to drum up some interest. This bug is affecting a few users (including myself). It prevents us using our text editor of choice, gvim. I've also reported to x...@openb

Re: [Intel-gfx] [PATCH i-g-t v2 5/8] tests/gem_sync: Remove basic tests.

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 07:27:50PM +0300, Marius Vlad wrote: No. Please explain what you replace this basic test with. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.

Re: [Intel-gfx] [PATCH igt v3] lib: Add simple sysfs accessors

2016-05-27 Thread Ville Syrjälä
On Thu, May 26, 2016 at 05:19:35PM +0100, Chris Wilson wrote: > igt_sysfs_set() for setting an attribute via sysfs, igt_sysfs_get() for > reading. > > v2: Lots of little bugs in igt_sysfs_get() > v3: Pass device to open, stop assuming Intel rules. > v4: Test opening and reading! > > Signed-off-by

[Intel-gfx] [PATCH 0/8] drm/i915: Give crtcs and planes actual names (v5)

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä This is the remainder (the i915 specific parts) of my earlier {crtc,plane}->name series [1]. I think at least one i915 specific patch was already merged, and I think I added one or two new ones at some point. I'm not so sure about the last patch. It was somewhat useful in nar

[Intel-gfx] [PATCH 4/8] drm/i915: Don't leak primary/cursor planes on crtc init failure

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä Call intel_plane_destroy() instead of drm_plane_cleanup() so that we also free the plane struct itself when bailing out of the crtc init. And make intel_plane_destroy() NULL tolerant to avoid having to check for it in the caller. Signed-off-by: Ville Syrjälä --- drivers/gp

[Intel-gfx] [PATCH v2 1/8] drm/i915: Use crtc->name in debug messages

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä We have crtc->name, so let's use that in debug messages instead of just printing the more or less useless object ID. v2: Rebased due to intel_dpll_mgr.c, slap on a commit message Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 32 ++

[Intel-gfx] [PATCH v3 5/8] drm/i915: Give meaningful names to all the planes

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä Let's name our planes in a way that makes sense wrt. the spec: - skl+ -> "plane 1A", "plane 2A", "plane 1C", "cursor A" etc. - g4x+ -> "primary A", "primary B", "sprite A", "cursor C" etc. - pre-g4x -> "plane A", "cursor B" etc. v2: Rebase on top of the fixed/cleaned error pa

[Intel-gfx] [PATCH v5 3/8] drm/i915: Set crtc->name to "pipe A", "pipe B", etc.

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä v2: Fix intel_crtc leak on failure to allocate the name Use a local 'name' variable to make things easier v3: Pass the name as a function arguemnt to drm_crtc_init_with_planes() (Jani) v4: Pass the printf style format string to drm_crtc_init_with_planes() v5: Drop spurious

[Intel-gfx] [PATCH v3 6/8] drm/i915: Give encoders useful names

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä Rather than let the core generate usless encoder names, let's pass in something that actually identifies the piece of hardware we're dealing with. v2: Use 'DSI %c' instead of 'MIPI %c' for DSI encoders (Jani) v3: Use port_name() in DSI code since we have it Signed-off-by: Vi

[Intel-gfx] [PATCH 7/8] drm/i915: kill STANDARD/CURSOR plane screams

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä Stop yelling the plane type. "STANDARD" doesn't mean anything anyway. Let's just use the plane name here. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 37 +++- 1 file changed, 15 insertions(+), 22 deletions(-) diff

[Intel-gfx] [PATCH v2 2/8] drm/i915: Use plane->name in debug prints

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä We have plane->name, so let's use that in debug messages instead of just printing the more or less useless object ID. v2: slap on a commit message Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 38 +--- 1 file change

[Intel-gfx] [PATCH v2 8/8] drm/i915: Add debug prints for encoder modeset hooks

2016-05-27 Thread ville . syrjala
From: Ville Syrjälä To get a better idea where exactly some error occurred during modeset, put in some debug prints to tell us when the variuous encoder hooks are getting called. v2: i9xx ->enable hook slipped through, bring it to the fold Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH igt v3] lib: Add simple sysfs accessors

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 08:46:14PM +0300, Ville Syrjälä wrote: > > + for (int n = 0; n < 16; n++) { > > + int len = sprintf(path, "/sys/class/drm/card%d", n); > > + if (device[0]) { > > + char tmp[80]; > > + int ret; > > + > > +

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915: Add debug prints for encoder modeset hooks

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 08:59:26PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > To get a better idea where exactly some error occurred during modeset, > put in some debug prints to tell us when the variuous encoder hooks are > getting called. > > v2: i9xx ->enable hook s

[Intel-gfx] [PATCH v3] drm: Store the plane's index

2016-05-27 Thread Chris Wilson
Currently the plane's index is determined by walking the list of all planes in the mode and finding the position of that plane in the list. A linear walk, especially a linear walk within a linear walk as frequently conceived by i915.ko [O(N^2)] quickly comes to dominate profiles. The plane's index

[Intel-gfx] [RFC 00/12] Support for sustained capturing of GuC firmware logs

2016-05-27 Thread akash . goel
From: Akash Goel GuC firmware log its debug messages into a Host-GuC shared memory buffer and when the buffer is half full it sends a Flush interrupt to Host. GuC firmware expects that while it is writing to 2nd half of the buffer, first half would get consumed by Host and then get a flush comple

[Intel-gfx] [RFC 06/12] drm/i915: Store GuC ukernel logs in the relay buffer

2016-05-27 Thread akash . goel
From: Akash Goel Using the buffer managed by relay to store the snapshots of GuC log buffer. The snapshot will be taken when GuC ukernel sends a log buffer flush interrupt. Suggested-by: Chris Wilson Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/i915_guc_submission.c | 16 +++

[Intel-gfx] [RFC 03/12] drm/i915: Support for GuC interrupts

2016-05-27 Thread akash . goel
From: Sagar Arun Kamble There are certain types of interrupts which Host can recieve from GuC. GuC ukernel sends an interrupt to Host for certain events, like for example retrieve/consume the logs generated by ukernel. This patch adds support to receive interrupts from GuC but currently enables &

[Intel-gfx] [RFC 07/12] drm/i915: Allocate local buffer to store GuC ukernel logs

2016-05-27 Thread akash . goel
From: Akash Goel If relay framework can't be used for all production kernels, due to debugfs limitation, then need to have our own local buffer to store the logs and manage it. This patch allocates a buffer to store the GuC ukernel logs. The contents of the GuC log buffer will be copied into loca

[Intel-gfx] [RFC 01/12] drm/i915: Decouple GuC log setup from verbosity parameter

2016-05-27 Thread akash . goel
From: Sagar Arun Kamble GuC Log buffer allocation was tied up with verbosity level kernel parameter i915.guc_log_level. User could be given a provision to enable logging at runtime and not necessarily during load time only. This patch will perform allocation of shared log buffer always but will i

[Intel-gfx] [RFC 05/12] drm/i915: Add a relay backed debugfs interface for capturing GuC logs

2016-05-27 Thread akash . goel
From: Akash Goel Added a new debugfs interface '/sys/kernel/debug/dri/guc_log' for the User to capture GuC ukernel logs. Availed relay framework to implement the interface, so Driver will just use a relay API to copy the contents of GuC log buffer into relay's buffer. Suggested-by: Chris Wilson

[Intel-gfx] [RFC 10/12] drm/i915: Support to capture GuC logs by multiple clients via device file iface

2016-05-27 Thread akash . goel
From: Akash Goel This patch adds support for multiple clients to capture GuC logs via '/dev/dri/guc_log' interface at the same time. The implementation is done on the lines of '/dev/kmsg', so provides a streaming behavior, on issuing the 'cat' command User will enter into a read loop and will hav

[Intel-gfx] [RFC 12/12] drm/i915: Forcefully flush GuC log buffer on reset

2016-05-27 Thread akash . goel
From: Sagar Arun Kamble If GuC logs are being captured, there should be a force log buffer flush action sent to GuC before proceeding with GPU reset and re-initializing GUC. Those logs would be useful to understand why the GPU reset was initiated. Signed-off-by: Sagar Arun Kamble Signed-off-by:

[Intel-gfx] [RFC 09/12] drm/i915: Add a char device file interface to capture GuC ukernel logs

2016-05-27 Thread akash . goel
From: Akash Goel This patch provides a new character device file interface '/dev/dri/guc_log' for the User to capture the GuC ukernel logs. Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/i915_guc_submission.c | 51 ++ drivers/gpu/drm/i915/intel_guc.h |

[Intel-gfx] [RFC 04/12] drm/i915: Handle log buffer flush interrupt event from GuC

2016-05-27 Thread akash . goel
From: Sagar Arun Kamble GuC ukernel sends an interrupt to Host to flush the log buffer and expects Host to correspondingly update the read pointer information in the state structure, once it has consumed the log buffer contents by copying them to a file or buffer. Even if Host couldn't copy the c

[Intel-gfx] [RFC 08/12] drm/i915: Store GuC ukernel logs in the local buffer

2016-05-27 Thread akash . goel
From: Akash Goel This patch copies the content of GuC log buffer into the local buffer. The data is written into local buffer in a circular manner, so 2 pointers are maintained to track the data inside the buffer. And after copying the logs, readers waiting for the data are woken up. The data fro

[Intel-gfx] [RFC 02/12] drm/i915: Add GuC ukernel logging related fields to fw interface file

2016-05-27 Thread akash . goel
From: Sagar Arun Kamble The first page of the GuC log buffer contains state info or meta data which is required to parse the logs contained in the subsequent pages. The structure representing the state info is added to interface file as Driver would need to handle log buffer flush interrupts from

[Intel-gfx] [RFC 11/12] drm/i915: Add sysfs interface to capture the GuC ukernel logs

2016-05-27 Thread akash . goel
From: Akash Goel This patch adds support to pull GuC logs stored in the local buffer through a sysfs interface '/sys/class/drm/card0/guc_log'. The implementation is on the lines of '/proc/kmsg' and sysfs will be one of the client just like other clients pulling the logs via '/dev/dri/guc_log' int

Re: [Intel-gfx] [RFC 03/12] drm/i915: Support for GuC interrupts

2016-05-27 Thread Chris Wilson
On Sat, May 28, 2016 at 01:12:54AM +0530, akash.g...@intel.com wrote: > From: Sagar Arun Kamble > > There are certain types of interrupts which Host can recieve from GuC. > GuC ukernel sends an interrupt to Host for certain events, like for > example retrieve/consume the logs generated by ukernel

Re: [Intel-gfx] [RFC 09/12] drm/i915: Add a char device file interface to capture GuC ukernel logs

2016-05-27 Thread Chris Wilson
On Sat, May 28, 2016 at 01:13:00AM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > This patch provides a new character device file interface '/dev/dri/guc_log' > for the User to capture the GuC ukernel logs. Do not make the device conditional on !CONFIG_DEBUGFS. With a stable interface

Re: [Intel-gfx] [RFC 03/12] drm/i915: Support for GuC interrupts

2016-05-27 Thread Chris Wilson
On Sat, May 28, 2016 at 01:12:54AM +0530, akash.g...@intel.com wrote: > From: Sagar Arun Kamble > > There are certain types of interrupts which Host can recieve from GuC. > GuC ukernel sends an interrupt to Host for certain events, like for > example retrieve/consume the logs generated by ukernel

Re: [Intel-gfx] [PATCH 0/8] drm/i915: Give crtcs and planes actual names (v5)

2016-05-27 Thread Chris Wilson
On Fri, May 27, 2016 at 08:59:18PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > This is the remainder (the i915 specific parts) of my earlier > {crtc,plane}->name series [1]. I think at least one i915 specific patch > was already merged, and I think I added one or two new

Re: [Intel-gfx] [PATCH v3] drm: Store the plane's index

2016-05-27 Thread Matt Roper
On Fri, May 27, 2016 at 08:05:00PM +0100, Chris Wilson wrote: > Currently the plane's index is determined by walking the list of all > planes in the mode and finding the position of that plane in the list. A > linear walk, especially a linear walk within a linear walk as frequently > conceived by i

Re: [Intel-gfx] [RFC PATCH 4/5] drm/i915: make i915 the source of acpi device ids for _DOD

2016-05-27 Thread Peter Wu
On Wed, Mar 23, 2016 at 01:16:21PM +0200, Jani Nikula wrote: > The graphics driver is supposed to define the DIDL, which are used for > _DOD, not the BIOS. Restore that behaviour. > > This is basically a revert of > > commit 3143751ff51a163b77f7efd389043e038f3e008e > Author: Zhang Rui > Date:

[Intel-gfx] ✓ Ro.CI.BAT: success for drm/i915: Give crtcs and planes actual names (v5)

2016-05-27 Thread Patchwork
== Series Details == Series: drm/i915: Give crtcs and planes actual names (v5) URL : https://patchwork.freedesktop.org/series/7905/ State : success == Summary == Series 7905v1 drm/i915: Give crtcs and planes actual names (v5) http://patchwork.freedesktop.org/api/1.0/series/7905/revisions/1/mbo

[Intel-gfx] ✗ Ro.CI.BAT: failure for Support for sustained capturing of GuC firmware logs

2016-05-27 Thread Patchwork
== Series Details == Series: Support for sustained capturing of GuC firmware logs URL : https://patchwork.freedesktop.org/series/7910/ State : failure == Summary == Series 7910v1 Support for sustained capturing of GuC firmware logs http://patchwork.freedesktop.org/api/1.0/series/7910/revisions

<    1   2