Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Refactor common engine setup

2016-05-09 Thread Daniel Vetter
On Mon, May 02, 2016 at 11:58:38AM +0100, Chris Wilson wrote: > On Mon, May 02, 2016 at 10:51:31AM +0200, Daniel Vetter wrote: > > Imo the low-level irq clearing should all be done in the relevant irq > > setup code in i915_irq.c. Atm we just forgot to do that. I guess you can > > have a bikeshed w

Re: [Intel-gfx] [PATCH] Revert "i965: Always use Y-tiled buffers on SKL+"

2016-05-09 Thread Daniel Vetter
On Mon, May 02, 2016 at 11:38:15AM -0700, Kenneth Graunke wrote: > On Monday, May 2, 2016 3:40:14 PM PDT Daniel Stone wrote: > > This commit broke Weston/KMS, and presumably also xf86-video-modesetting. > > For me, xf86-video-modesetting, and xf86-video-intel/SNA+DRI3 both work > fine with Y-tilin

Re: [Intel-gfx] [PATCH] drm/i915: Dump pipe config when intel_modeset_pipe_config fails.

2016-05-09 Thread Daniel Vetter
On Tue, May 03, 2016 at 10:30:38AM +0200, Maarten Lankhorst wrote: > This makes it easier to debug issues like > https://bugs.freedesktop.org/show_bug.cgi?id=93477 > > Signed-off-by: Maarten Lankhorst > Cc: Chris Wilson <|ch...@chris-wilson.co.uk>| > --- > diff --git a/drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-05-09 Thread Lee Jones
On Mon, 09 May 2016, Daniel Vetter wrote: > On Wed, May 04, 2016 at 08:32:17AM +0100, Lee Jones wrote: > > On Mon, 02 May 2016, Daniel Vetter wrote: > > > > > On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote: > > > > On Fri, Apr 22, 2016 at 9:38 PM, wrote: > > > > > > > > > From:

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-05-09 Thread Lee Jones
On Fri, 22 Apr 2016, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar > Cc: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: T

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Poke at fixing unbalanced referencing in d2307dea14

2016-05-09 Thread Patchwork
== Series Details == Series: drm: Poke at fixing unbalanced referencing in d2307dea14 URL : https://patchwork.freedesktop.org/series/6815/ State : success == Summary == Series 6815v1 drm: Poke at fixing unbalanced referencing in d2307dea14 http://patchwork.freedesktop.org/api/1.0/series/6815/r

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915: start adding dp mst audio"

2016-05-09 Thread Daniel Vetter
On Tue, May 03, 2016 at 03:25:07PM -, Patchwork wrote: > == Series Details == > > Series: Revert "drm/i915: start adding dp mst audio" > URL : https://patchwork.freedesktop.org/series/6685/ > State : failure > > == Summary == > > Series 6685v1 Revert "drm/i915: start adding dp mst audio" >

[Intel-gfx] [PATCH] drm/i915: Simplify control flow in intel_atomic_check a bit.

2016-05-09 Thread Daniel Vetter
- Unconditionally add plane states. Core helpers would have done this in drm_atomic_helper_check_modeset, doing it once more won't cause harm and is less fragile. - Simplify the continue logic when disabling a pipe. Cc: Maarten Lankhorst Reviewed-by: Maarten Lankhorst Signed-off-by: Daniel

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Allow MI_LOAD_REGISTER_REG between whitelisted registers. (rev2)

2016-05-09 Thread Chris Wilson
On Fri, May 06, 2016 at 08:13:22AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Allow MI_LOAD_REGISTER_REG between whitelisted registers. > (rev2) > URL : https://patchwork.freedesktop.org/series/6774/ > State : failure > > == Summary == > > Series 6774v2 drm/i915: All

Re: [Intel-gfx] [PATCH] drm/i915: add missing condition for committing planes on crtc

2016-05-09 Thread Daniel Vetter
On Wed, May 04, 2016 at 12:13:39PM +0100, Lionel Landwerlin wrote: > We are currently missing the color management update condition to > commit planes on crtc. > > v2: add comment about moving the commit of color management registers > to an async worker > > Fixes: 20a34e78f0d7 (drm/i915: Upd

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-09 Thread Daniel Vetter
On Fri, May 06, 2016 at 02:16:29PM +0300, Ville Syrjälä wrote: > On Thu, May 05, 2016 at 07:17:02AM +, Antoine, Peter wrote: > > It's a little overkill? > > > > They just need to know if the cache tables have changed and to be able to > > sync their indexes to the KMD. > > We already shot ou

Re: [Intel-gfx] [PATCH] drm/i915: add missing condition for committing planes on crtc

2016-05-09 Thread Daniel Vetter
On Fri, May 06, 2016 at 01:52:58PM +0300, Ville Syrjälä wrote: > On Thu, May 05, 2016 at 03:04:54PM +0100, Lionel Landwerlin wrote: > > On 04/05/16 15:30, Ville Syrjälä wrote: > > > On Wed, May 04, 2016 at 02:40:34PM +0100, Lionel Landwerlin wrote: > > >> We are currently missing the color manageme

Re: [Intel-gfx] [PATCH igt v3] igt/gem_exec_parse: Simple exercise for MI_LOAD_REGISTER_REG

2016-05-09 Thread Kenneth Graunke
On Friday, May 6, 2016 8:53:56 AM PDT Chris Wilson wrote: > Command parser version 7 introduces the ability to copy between > regsiters from the Haswell RCS with MI_LOAD_REGISTER_REG. This provides > a quick smoketest of that ability. > > v2: Add some negative tests as well > > Signed-off-by: Chr

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Refactor common engine setup

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 09:02:33AM +0200, Daniel Vetter wrote: > On Mon, May 02, 2016 at 11:58:38AM +0100, Chris Wilson wrote: > > On Mon, May 02, 2016 at 10:51:31AM +0200, Daniel Vetter wrote: > > > Imo the low-level irq clearing should all be done in the relevant irq > > > setup code in i915_irq.

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/guc: GuC firmware loading updates

2016-05-09 Thread Patchwork
== Series Details == Series: drm/i915/guc: GuC firmware loading updates URL : https://patchwork.freedesktop.org/series/6818/ State : warning == Summary == Series 6818v1 drm/i915/guc: GuC firmware loading updates http://patchwork.freedesktop.org/api/1.0/series/6818/revisions/1/mbox/ Test core_

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Refactor common engine setup

2016-05-09 Thread Daniel Vetter
On Mon, May 09, 2016 at 08:45:16AM +0100, Chris Wilson wrote: > On Mon, May 09, 2016 at 09:02:33AM +0200, Daniel Vetter wrote: > > On Mon, May 02, 2016 at 11:58:38AM +0100, Chris Wilson wrote: > > > On Mon, May 02, 2016 at 10:51:31AM +0200, Daniel Vetter wrote: > > > > Imo the low-level irq clearin

[Intel-gfx] PATCH i-g-t small patch

2016-05-09 Thread David CARLIER
Hi all, this is a small patch to fix couple of mem leaks, possible double free case. Hope it is useful. Kind regards. From b2c1f0fa1aa8424b7d1200c2cc4171eeda719571 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Thu, 5 May 2016 16:36:58 +0100 Subject: [PATCH i-g-t] couple of memory leak fixe

Re: [Intel-gfx] [PATCH] drm/i915: Small display interrupt handlers tidy

2016-05-09 Thread Daniel Vetter
On Fri, May 06, 2016 at 02:53:54PM +0100, Dave Gordon wrote: > On 06/05/16 14:27, Tvrtko Ursulin wrote: > > > >On 06/05/16 12:27, Chris Wilson wrote: > >>On Fri, May 06, 2016 at 12:07:04PM +0100, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>I have noticed some of our interrupt handle

Re: [Intel-gfx] [PATCH 15/16] drm/i915: Mechanism to forward clock monotonic time in perf samples

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 11:29:50AM +0530, sourab gupta wrote: > On Sat, 2016-04-23 at 01:19 +0530, Chris Wilson wrote: > > Have you looked at cross-timestamps? > > I was looking at the cross-timestamp patch set > (https://lkml.org/lkml/2016/1/4/541), but I'm not entirely sure the > cross timestamp

Re: [Intel-gfx] PATCH i-g-t small patch

2016-05-09 Thread Jani Nikula
On Fri, 06 May 2016, David CARLIER wrote: > Hi all, > > this is a small patch to fix couple of mem leaks, possible double free case. > > Hope it is useful. Please add your Signed-off-by: line to certify http://developercertificate.org/ (see git log if you don't know what this means). Please send

Re: [Intel-gfx] PATCH i-g-t small patch

2016-05-09 Thread Chris Wilson
On Fri, May 06, 2016 at 11:12:50AM +0100, David CARLIER wrote: >Hi all, > >this is a small patch to fix couple of mem leaks, possible double free >case. Please don't bother freeing before process exit. In tests, I would rather those be left around, and open file description, mmaps etc

[Intel-gfx] [CI 1/3] drm: Restore double clflush on the last partial cacheline

2016-05-09 Thread Chris Wilson
This effectively reverts commit afcd950cafea6e27b739fe7772cbbeed37d05b8b Author: Chris Wilson Date: Wed Jun 10 15:58:01 2015 +0100 drm: Avoid the double clflush on the last cache line in drm_clflush_virt_range() as we have observed issues with serialisation of the clflush operations on B

[Intel-gfx] [CI 2/3] drm/i915/execlists: Refactor common engine setup

2016-05-09 Thread Chris Wilson
Move all of the constant assignments up front and into a common function. This is primarily to ensure the backpointers are set as early as possible for later use during initialisation. v2: Use a constant struct so that all the similar values are set together. v3: Sanitize the engine's IMR to disab

Re: [Intel-gfx] i915 with valleyview

2016-05-09 Thread Jani Nikula
On Fri, 06 May 2016, Sudip Mukherjee wrote: > On Fri, May 06, 2016 at 12:21:04PM +0100, Sudip Mukherjee wrote: >> Hi Daniel, >> I am trying to use i915 in one of our board which has Intel ATOM E3840. >> I know Intel has released emgd driver for this cpu to use i915 but emgd >> is not supported on

Re: [Intel-gfx] [PATCH] drm/i915: Small display interrupt handlers tidy

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 10:05:06AM +0200, Daniel Vetter wrote: > Not sure about intel_display because that's an ever-growing dumping ground > and with atomic still in-flight I definitely don't want to upset this. > There's been various plans to split it up a bit (and document while at > it). Maybe

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Make intel_adjust_tile_offset() work for linear buffers

2016-05-09 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On Tuesday 03 May 2016 09:09 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä To make life less surprising we can make intel_adjust_tile_offset() deal with linear buffers as well. Currently it doesn't seem like there's a real need for this since

[Intel-gfx] [PATCH 1/3] Introduce & use new SG page iterators

2016-05-09 Thread Dave Gordon
The existing for_each_sg_page() iterator is somewhat inconvenient; in particular, the 'nents' parameters is not expressed in any useful way, and so there is no way to get a precise (maximum) number of iterations (and therefore pages) without knowing that the SGL has been constructed in a specific w

[Intel-gfx] [PATCH 3/3] drm/i915: optimise i915_gem_object_map() for small objects

2016-05-09 Thread Dave Gordon
We're using this function for ringbuffers and other "small" objects, so it's worth avoiding an extra malloc()/free() cycle if the page array is small enough to put on the stack. Here we've chosen an arbitrary cutoff of 32 (4k) pages, which is big enough for a ringbuffer (4 pages) or a context image

[Intel-gfx] [PATCH 2/3] drm/i915: refactor i915_gem_object_pin_map()

2016-05-09 Thread Dave Gordon
The recently-added i915_gem_object_pin_map() can be further optimised for "small" objects. To facilitate this, and simplify the error paths before adding the new code, this patch pulls out the "mapping" part of the operation (involving local allocations which must be undone before return) into its

Re: [Intel-gfx] [PATCH] Revert "i965: Always use Y-tiled buffers on SKL+"

2016-05-09 Thread Daniel Stone
Hi, On 9 May 2016 at 08:05, Daniel Vetter wrote: > On Mon, May 02, 2016 at 11:38:15AM -0700, Kenneth Graunke wrote: >> On Monday, May 2, 2016 3:40:14 PM PDT Daniel Stone wrote: >> > This commit broke Weston/KMS, and presumably also xf86-video-modesetting. >> >> For me, xf86-video-modesetting, and

Re: [Intel-gfx] [PATCHv4 1/3] drm/i915: Make finding unused crtc as a generic function

2016-05-09 Thread R, Durgadoss
> -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Friday, May 6, 2016 6:38 PM > To: R, Durgadoss ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCHv4 1/3] drm/i915: Make finding unused crtc as > a generic function > > On Mon,

[Intel-gfx] ✗ Fi.CI.BAT: warning for GPU scheduler for i915 driver (rev4)

2016-05-09 Thread Patchwork
== Series Details == Series: GPU scheduler for i915 driver (rev4) URL : https://patchwork.freedesktop.org/series/3585/ State : warning == Summary == Series 3585v4 GPU scheduler for i915 driver http://patchwork.freedesktop.org/api/1.0/series/3585/revisions/4/mbox/ Test kms_pipe_crc_basic:

Re: [Intel-gfx] [PATCH 1/3] Introduce & use new SG page iterators

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 10:33:31AM +0100, Dave Gordon wrote: > The existing for_each_sg_page() iterator is somewhat inconvenient; in > particular, the 'nents' parameters is not expressed in any useful way, > and so there is no way to get a precise (maximum) number of iterations > (and therefore pag

[Intel-gfx] [PATCH] drm: Remove unused drm_device from drm_gem_object_lookup()

2016-05-09 Thread Chris Wilson
drm_gem_object_lookup() has never required the drm_device for its file local translation of the user handle to the GEM object. Let's remove the unused parameter and save some space. Signed-off-by: Chris Wilson Cc: dri-de...@lists.freedesktop.org Cc: Dave Airlie Cc: Daniel Vetter --- drivers/gp

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Compute display surface offset in the plane check hook for SKL+

2016-05-09 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On Tuesday 03 May 2016 09:09 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä SKL has nasty limitations with the display surface offsets: * source x offset + width must be less than the stride for X tiled surfaces or the display engine falls o

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix modeset handling during gpu reset, v2.

2016-05-09 Thread Maarten Lankhorst
Op 06-05-16 om 15:06 schreef Ville Syrjälä: > On Mon, May 02, 2016 at 10:57:01AM +0200, Maarten Lankhorst wrote: >> This function would call drm_modeset_lock_all, while the suspend/resume >> functions already have their own locking. Fix this by factoring out >> __intel_display_resume, and calling t

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Refactor common engine setup

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 09:58:20AM +0200, Daniel Vetter wrote: > On Mon, May 09, 2016 at 08:45:16AM +0100, Chris Wilson wrote: > > This is sanitize. We do enable it in engine->init_hw(), but the point > > raised by Ville earlier in his review of GT irq handling is that nobody > > currently disables

Re: [Intel-gfx] [PATCHv4 3/3] drm/i915/dp: Enable Upfront link training for typeC DP support on BXT

2016-05-09 Thread R, Durgadoss
Hi Ander, Thanks for looking at it. Few queries below.. > -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Friday, May 6, 2016 6:39 PM > To: R, Durgadoss ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCHv4 3/3] drm/i915/dp: Ena

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Small display interrupt handlers tidy (rev2)

2016-05-09 Thread Patchwork
== Series Details == Series: drm/i915: Small display interrupt handlers tidy (rev2) URL : https://patchwork.freedesktop.org/series/6819/ State : failure == Summary == Series 6819v2 drm/i915: Small display interrupt handlers tidy http://patchwork.freedesktop.org/api/1.0/series/6819/revisions/2/

[Intel-gfx] [PATCH v3 1/2] drm/i915: Fix modeset handling during gpu reset, v3.

2016-05-09 Thread Maarten Lankhorst
This function would call drm_modeset_lock_all, while the suspend/resume functions already have their own locking. Fix this by factoring out __intel_display_resume, and calling the atomic helpers for duplicating atomic state and disabling all crtc's during suspend. Changes since v1: - Deal with -ED

Re: [Intel-gfx] i915 with valleyview

2016-05-09 Thread Sudip Mukherjee
On Mon, May 09, 2016 at 11:19:16AM +0300, Jani Nikula wrote: > On Fri, 06 May 2016, Sudip Mukherjee wrote: > > On Fri, May 06, 2016 at 12:21:04PM +0100, Sudip Mukherjee wrote: > >> Hi Daniel, > >> I am trying to use i915 in one of our board which has Intel ATOM E3840. > >> I know Intel has release

Re: [Intel-gfx] [PATCH v4] prime_mmap_kms: show case dma-buf new API and processes restrictions

2016-05-09 Thread Marius Vlad
Pushed. Thanks! On Fri, May 06, 2016 at 04:51:29PM -0300, Tiago Vignatti wrote: > dma-buf new API consists of: > > - mmap(dma_buf_fd, ...): the ability to map a dma-buf file-descriptor of a > graphics buffer to the userspace, and more importantly, to actually write on > the mapped pointer (which w

Re: [Intel-gfx] [PATCH 1/3] drm: Drop crtc argument from __drm_atomic_helper_crtc_destroy_state

2016-05-09 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Friday 06 May 2016 10:32:28 Daniel Vetter wrote: > It's unused, and really this helper should only look at the state > structure and nothing else. > > v2: Rebase on top of rockchip changes > > Cc: Maarten Lankhorst > Cc: Thierry Reding > Cc: Eric Anholt

Re: [Intel-gfx] [PATCH 2/3] drm: Drop crtc argument from __drm_atomic_helper_connector_destroy_state

2016-05-09 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Friday 06 May 2016 10:32:29 Daniel Vetter wrote: > It's unused, and really this helper should only look at the state > structure and nothing else. > > Cc: Maarten Lankhorst > Cc: Thierry Reding > Cc: Eric Anholt > Cc: Laurent Pinchart > Cc: Inki Dae >

Re: [Intel-gfx] [PATCH 3/3] drm: Drop crtc argument from __drm_atomic_helper_connector_destroy_state

2016-05-09 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. s/crtc/connector/ in the subject (I've just realized that the same comment applies to patch 2/3, with s/connector/plane/ as well). Apart from that, Acked-by: Laurent Pinchart On Friday 06 May 2016 10:32:30 Daniel Vetter wrote: > It's unused, and really thi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Pin pages as we flush for CPU access

2016-05-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Pin pages as we flush for CPU access URL : https://patchwork.freedesktop.org/series/6838/ State : success == Summary == Series 6838v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/6838/revisions/1/

[Intel-gfx] [PATCH 1/2] drm/atomic: Add a way to call remove_fb atomically, v2.

2016-05-09 Thread Maarten Lankhorst
Use this in drm_framebuffer_remove, this is to remove the fb in an atomic way. i915 doesn't export DRIVER_ATOMIC yet by default but is atomic, so add a function pointer to allow drivers to use the atomic framebuffer remove. Changes since v1: - Move the atomic framebuffer removal function from hel

[Intel-gfx] [PATCH 1/2] drm/atomic: Add a way to call remove_fb atomically, v2.

2016-05-09 Thread Maarten Lankhorst
Use this in drm_framebuffer_remove, this is to remove the fb in an atomic way. i915 doesn't export DRIVER_ATOMIC yet by default but is atomic, so add a function pointer to allow drivers to use the atomic framebuffer remove. Changes since v1: - Move the atomic framebuffer removal function from hel

[Intel-gfx] [PATCH 2/2] Reapply "drm/atomic: Call ww_acquire_done after check phase is complete"

2016-05-09 Thread Maarten Lankhorst
This reapplies commit 992cbf19b32900efa17850b9fa0031fd623edd4d. With atomic drm_framebuffer_remove and the fbdev emulation layer atomic this should be safe to apply again. Signed-off-by: Maarten Lankhorst Cc: Rob Clark Cc: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 3 +++ 1 file changed,

[Intel-gfx] [PATCH 2/2] Reapply "drm/atomic: Call ww_acquire_done after check phase is complete"

2016-05-09 Thread Maarten Lankhorst
This reapplies commit 992cbf19b32900efa17850b9fa0031fd623edd4d. With atomic drm_framebuffer_remove and the fbdev emulation layer atomic this should be safe to apply again. Signed-off-by: Maarten Lankhorst Cc: Rob Clark Cc: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 3 +++ 1 file changed,

[Intel-gfx] What's using all my DRI memory?

2016-05-09 Thread Adam Nielsen
Hi all, I'm trying to track down an annoying bug which is making my system crash every two weeks, and in between those two weeks I get various programs, typically Firefox, killed every day or two due to out of memory errors. Apparently all this memory is used by the Intel video driver, which does

Re: [Intel-gfx] [PATCH v2 0/4] drm: DP++ adaptor support (v2)

2016-05-09 Thread Ville Syrjälä
On Mon, May 02, 2016 at 10:08:21PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Here's a respin of my DP++ adaptor support series [1]. Pardon for taking > forever with this. Presumably we want to get this into stable to fix the > regression from HDMI 12bpc support. > > I

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [for-CI,1/3] drm: Restore double clflush on the last partial cacheline

2016-05-09 Thread Patchwork
== Series Details == Series: series starting with [for-CI,1/3] drm: Restore double clflush on the last partial cacheline URL : https://patchwork.freedesktop.org/series/6839/ State : warning == Summary == Series 6839v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce INTEL_GEN_RANGE macro

2016-05-09 Thread Jani Nikula
On Fri, 06 May 2016, Dave Gordon wrote: > On 06/05/16 15:33, Chris Wilson wrote: >> On Fri, May 06, 2016 at 03:16:25PM +0100, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> To be used for more efficient Gen range checking. >>> >>> Signed-off-by: Tvrtko Ursulin >>> --- >>> drivers/gpu/d

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Small display interrupt handlers tidy (rev2)

2016-05-09 Thread Tvrtko Ursulin
On 09/05/16 11:53, Patchwork wrote: == Series Details == Series: drm/i915: Small display interrupt handlers tidy (rev2) URL : https://patchwork.freedesktop.org/series/6819/ State : failure == Summary == Series 6819v2 drm/i915: Small display interrupt handlers tidy http://patchwork.freedeskt

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [for-CI,1/3] drm: Restore double clflush on the last partial cacheline

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 12:23:31PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [for-CI,1/3] drm: Restore double clflush on the > last partial cacheline > URL : https://patchwork.freedesktop.org/series/6839/ > State : warning > > == Summary == > > Series 683

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix modeset handling during gpu reset, v3.

2016-05-09 Thread Ville Syrjälä
On Mon, May 09, 2016 at 01:04:21PM +0200, Maarten Lankhorst wrote: > This function would call drm_modeset_lock_all, while the suspend/resume > functions already have their own locking. Fix this by factoring out > __intel_display_resume, and calling the atomic helpers for duplicating > atomic state

Re: [Intel-gfx] What's using all my DRI memory?

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 10:06:49PM +1000, Adam Nielsen wrote: > Hi all, > > I'm trying to track down an annoying bug which is making my system > crash every two weeks, and in between those two weeks I get various > programs, typically Firefox, killed every day or two due to out of > memory errors.

[Intel-gfx] [PATCH 3/5] drm/i915: Replace "INTEL_INFO->gen == x" checks with IS_GENx

2016-05-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This way optimization from a previous patch works even better. v2: Rebase. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- drivers/gpu/drm/i915/i915_dma.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 1/5] drm/i915: Make IS_GENx macros work on a mask

2016-05-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If instead of numerical comparison me make these test a bitmask, we enable the compiler to optimize all instances of IS_GENx || IS_GENy. v2: Make bit zero of gen mask mean gen 1. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_dma.c

[Intel-gfx] [PATCH 4/5] drm/i915: Introduce INTEL_GEN_RANGE macro

2016-05-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To be used for more efficient Gen range checking. v2: Remove spurious chunk. (Chris Wilson) v3: Rebase. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_fbc.c| 2 +- drivers/gpu/

[Intel-gfx] [PATCH 5/5] drm/i915: Do not use a bitfield for INTEL_INFO->num_pipes

2016-05-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It just makes more work for the compiler and generates more code. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/

[Intel-gfx] [PATCH 2/5] drm/i915: Promote IS_BROADWELL to a simple macro

2016-05-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If we allow it a dedicated flag in dev_priv we enable the compiler to nicely optimize conditions like IS_HASSWELL || IS_BROADWELL. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 4 drivers/gpu/drm/i915/i915_drv.h | 3 ++-

Re: [Intel-gfx] [PATCH] x86: Silence 32bit compiler warning in intel_graphics_stolen()

2016-05-09 Thread Joonas Lahtinen
On pe, 2016-05-06 at 13:57 +0300, Ville Syrjälä wrote: > On Thu, May 05, 2016 at 05:15:17PM +0100, Chris Wilson wrote: > > > > arch/x86/kernel/early-quirks.c: In function ‘intel_graphics_stolen’: > > arch/x86/kernel/early-quirks.c:539:9: warning: format ‘%llx’ expects > > argument of type ‘long lo

Re: [Intel-gfx] [PATCH] x86: Silence 32bit compiler warning in intel_graphics_stolen()

2016-05-09 Thread Ville Syrjälä
On Mon, May 09, 2016 at 04:04:31PM +0300, Joonas Lahtinen wrote: > On pe, 2016-05-06 at 13:57 +0300, Ville Syrjälä wrote: > > On Thu, May 05, 2016 at 05:15:17PM +0100, Chris Wilson wrote: > > > > > > arch/x86/kernel/early-quirks.c: In function ‘intel_graphics_stolen’: > > > arch/x86/kernel/early-q

[Intel-gfx] [PATCH i-g-t] tests/{gem_ctx_switch, gem_exec_create}: Fix shadow declaration of child variable.

2016-05-09 Thread Marius Vlad
Signed-off-by: Marius Vlad --- tests/gem_ctx_switch.c | 1 - tests/gem_exec_create.c | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/gem_ctx_switch.c b/tests/gem_ctx_switch.c index 691a4f1..004ba22 100644 --- a/tests/gem_ctx_switch.c +++ b/tests/gem_ctx_switch.c @@ -73,7 +73,6 @@ stat

[Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Marius Vlad
Easier to catch compilation errors. Signed-off-by: Marius Vlad --- benchmarks/Makefile.am | 2 +- demos/Makefile.am | 3 ++- overlay/Makefile.am| 3 ++- tests/Makefile.am | 2 +- tools/Makefile.am | 4 +++- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/benchma

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Re-enable GGTT earlier during resume on pre-gen6 platforms

2016-05-09 Thread Patchwork
== Series Details == Series: drm/i915: Re-enable GGTT earlier during resume on pre-gen6 platforms URL : https://patchwork.freedesktop.org/series/6845/ State : success == Summary == Series 6845v1 drm/i915: Re-enable GGTT earlier during resume on pre-gen6 platforms http://patchwork.freedesktop.

Re: [Intel-gfx] [PATCH i-g-t] tests/{gem_ctx_switch, gem_exec_create}: Fix shadow declaration of child variable.

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 04:23:11PM +0300, Marius Vlad wrote: > Signed-off-by: Marius Vlad Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.fr

[Intel-gfx] [PATCH] drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c

2016-05-09 Thread Chris Wilson
Pass drm_i915_private to the uncore init/fini routines and their subservients as it is their native type. textdata bss dec hex filename 6309978 3578778 696320 10585076 a183f4 vmlinux 6309530 3578778 696320 10584628 a18234 vmlinux a modest 400 bytes of saving,

Re: [Intel-gfx] [PATCH v2] drm/i915: Discard previous atomic state on resume if connectors change

2016-05-09 Thread Lyude Paul
Yep, Dave's patches fix the issue on their own so this is only going to be needed for 4.6. On Mon, 2016-05-09 at 08:42 +0200, Daniel Vetter wrote: > On Fri, May 06, 2016 at 05:39:56PM -0400, Lyude wrote: > > > > If an MST device is disconnected while the machine is suspended, the > > number of co

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Replace "INTEL_INFO->gen == x" checks with IS_GENx

2016-05-09 Thread Dave Gordon
On 06/05/16 14:43, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This way optimization from a previous patch works even better. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- drivers/gpu/drm/i915/i915_dma.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce INTEL_GEN_RANGE macro

2016-05-09 Thread Dave Gordon
On 09/05/16 13:32, Jani Nikula wrote: On Fri, 06 May 2016, Dave Gordon wrote: On 06/05/16 15:33, Chris Wilson wrote: On Fri, May 06, 2016 at 03:16:25PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin To be used for more efficient Gen range checking. Signed-off-by: Tvrtko Ursulin ---

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v3,1/6] drm/i915/guc: distinguish HAS_GUC() from HAS_GUC_UCODE/HAS_GUC_SCHED

2016-05-09 Thread Patchwork
== Series Details == Series: series starting with [v3,1/6] drm/i915/guc: distinguish HAS_GUC() from HAS_GUC_UCODE/HAS_GUC_SCHED URL : https://patchwork.freedesktop.org/series/6846/ State : warning == Summary == Series 6846v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0

Re: [Intel-gfx] [PATCH 1/3] drm: Drop crtc argument from __drm_atomic_helper_crtc_destroy_state

2016-05-09 Thread Daniel Vetter
On Mon, May 09, 2016 at 02:47:58PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Friday 06 May 2016 10:32:28 Daniel Vetter wrote: > > It's unused, and really this helper should only look at the state > > structure and nothing else. > > > > v2: Rebase on top of r

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce INTEL_GEN_RANGE macro

2016-05-09 Thread Jani Nikula
On Mon, 09 May 2016, Dave Gordon wrote: > On 09/05/16 13:32, Jani Nikula wrote: >> On Fri, 06 May 2016, Dave Gordon wrote: >>> On 06/05/16 15:33, Chris Wilson wrote: On Fri, May 06, 2016 at 03:16:25PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > To be used for more ef

[Intel-gfx] [PATCH] drm/i915: add missing condition for committing planes on crtc

2016-05-09 Thread Lionel Landwerlin
We are currently missing the color management update condition to commit planes on crtc. v2: add comment about moving the commit of color management registers to an async worker v3: Commit color management register right after vblank v4: Move back color management commit condition together w

Re: [Intel-gfx] [PATCH v2] drm/i915: Discard previous atomic state on resume if connectors change

2016-05-09 Thread Daniel Vetter
On Mon, May 09, 2016 at 10:07:08AM -0400, Lyude Paul wrote: > Yep, Dave's patches fix the issue on their own so this is only going to be > needed for 4.6. Ok, so not the first one that only needs to be applied to stable kernels. For that to work you need to explain that this is the most minimal fi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Discard previous atomic state on resume if connectors change (rev2)

2016-05-09 Thread Patchwork
== Series Details == Series: drm/i915: Discard previous atomic state on resume if connectors change (rev2) URL : https://patchwork.freedesktop.org/series/6673/ State : failure == Summary == Series 6673v2 drm/i915: Discard previous atomic state on resume if connectors change http://patchwork.

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Simplify control flow in intel_atomic_check a bit.

2016-05-09 Thread Patchwork
== Series Details == Series: drm/i915: Simplify control flow in intel_atomic_check a bit. URL : https://patchwork.freedesktop.org/series/6890/ State : warning == Summary == Series 6890v1 drm/i915: Simplify control flow in intel_atomic_check a bit. http://patchwork.freedesktop.org/api/1.0/serie

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce INTEL_GEN_RANGE macro

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 05:40:39PM +0300, Jani Nikula wrote: > On Mon, 09 May 2016, Dave Gordon wrote: > > On 09/05/16 13:32, Jani Nikula wrote: > >> On Fri, 06 May 2016, Dave Gordon wrote: > >>> On 06/05/16 15:33, Chris Wilson wrote: > On Fri, May 06, 2016 at 03:16:25PM +0100, Tvrtko Ursuli

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Damien Lespiau
On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote: > Easier to catch compilation errors. Having -Werror by default is a no go as you cannot control/predict the set of warnings (and the quality of those) of all previous and future gcc/clang versions. Always using this flag will cause di

Re: [Intel-gfx] [PATCH v2] drm/i915: Discard previous atomic state on resume if connectors change

2016-05-09 Thread Lyude Paul
no problem, I'll let you know when they're ready On Mon, 2016-05-09 at 16:53 +0200, Daniel Vetter wrote: > On Mon, May 09, 2016 at 10:07:08AM -0400, Lyude Paul wrote: > > > > Yep, Dave's patches fix the issue on their own so this is only going to be > > needed for 4.6. > Ok, so not the first one

Re: [Intel-gfx] [PATCH i-g-t v4 4/5] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.

2016-05-09 Thread Marius Vlad
On Tue, Apr 26, 2016 at 11:54:21AM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Previously crtc0 was statically used for VBLANK tests, but > that assumption is not valid for the VC4 platform. > Instead we're now explicitly setting the mode. > > Also add support for testing all

Re: [Intel-gfx] [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

2016-05-09 Thread Eric Engestrom
On Sun, May 01, 2016 at 09:39:58PM -0700, Jason Ekstrand wrote: > On May 1, 2016 6:04 PM, "Kenneth Graunke" wrote: > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > > Adding the anv authors. > > > > > > Jason, Chad, is there a canonical place where changes to > > > vulkan_intel.h s

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Marius Vlad
On Mon, May 09, 2016 at 04:25:40PM +0100, Damien Lespiau wrote: > On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote: > > Easier to catch compilation errors. > > > Having -Werror by default is a no go as you cannot control/predict the > set of warnings (and the quality of those) of all p

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Damien Lespiau
On Mon, May 09, 2016 at 06:55:12PM +0300, Marius Vlad wrote: > > Adding a test (with patchwork integration!) that ensures each commit > > posted on this mailing-list compiles without new warning with a chosen > > toolchain (and even passes distcheck!) would be nice. > We have this for check and dis

Re: [Intel-gfx] [PATCH] drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c

2016-05-09 Thread Joonas Lahtinen
On ma, 2016-05-09 at 14:58 +0100, Chris Wilson wrote: > Pass drm_i915_private to the uncore init/fini routines and their > subservients as it is their native type. > >    textdata bss dec hex filename > 6309978 3578778  696320 10585076 a183f4 vmlinux > 6309530 3578778  6963

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Morton, Derek J
> > >-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On >Behalf Of Marius Vlad >Sent: Monday, May 9, 2016 4:55 PM >To: Lespiau, Damien >Cc: daniel.vet...@ffwll.ch; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, ove

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm: Restore double clflush on the last partial cacheline

2016-05-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm: Restore double clflush on the last partial cacheline URL : https://patchwork.freedesktop.org/series/6892/ State : failure == Summary == CC drivers/usb/host/uhci-hcd.o CC drivers/usb/storage/option_ms.o CC dri

Re: [Intel-gfx] [PATCH] drm/i915: Use drm_i915_private as the native pointer for intel_uncore.c

2016-05-09 Thread Chris Wilson
On Mon, May 09, 2016 at 06:59:58PM +0300, Joonas Lahtinen wrote: > On ma, 2016-05-09 at 14:58 +0100, Chris Wilson wrote: > > Pass drm_i915_private to the uncore init/fini routines and their > > subservients as it is their native type. > > > >    textdata bss dec hex filename > > 63

[Intel-gfx] [PATCH] drm: use seqlocks for vblank time/count

2016-05-09 Thread Matthew Auld
This patch aims to replace the roll-your-own seqlock implementation with full-blown seqlock'. We also remove the timestamp ring-buffer in favour of single timestamp/count pair protected by a seqlock. In turn this means we can now increment the vblank freely without the need for clamping. Cc: Danie

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add a FIXME about crtc !active vs. watermarks

2016-05-09 Thread Ville Syrjälä
On Wed, May 04, 2016 at 02:30:28PM +0200, Maarten Lankhorst wrote: > Op 29-04-16 om 16:31 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > When the crtc is enabled but !active, we should still compute the > > watermarks as if the planes were visible. That would make it more >

[Intel-gfx] [PATCH v2] x86: Silence 32bit compiler warning in intel_graphics_stolen()

2016-05-09 Thread Chris Wilson
arch/x86/kernel/early-quirks.c: In function ‘intel_graphics_stolen’: arch/x86/kernel/early-quirks.c:539:9: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘phys_addr_t’ [-Wformat=] "0x%llx-0x%llx\n", base, base + size - 1); ^ arch

Re: [Intel-gfx] [PATCH] drm: use seqlocks for vblank time/count

2016-05-09 Thread Ville Syrjälä
On Mon, May 09, 2016 at 05:08:43PM +0100, Matthew Auld wrote: > This patch aims to replace the roll-your-own seqlock implementation with > full-blown seqlock'. We also remove the timestamp ring-buffer in favour > of single timestamp/count pair protected by a seqlock. In turn this > means we can now

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] Introduce & use new SG page iterators

2016-05-09 Thread Patchwork
== Series Details == Series: series starting with [1/3] Introduce & use new SG page iterators URL : https://patchwork.freedesktop.org/series/6894/ State : success == Summary == Series 6894v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/6894/revisions/1/mbox/ Tes

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm: Remove unused drm_device from drm_gem_object_lookup()

2016-05-09 Thread Patchwork
== Series Details == Series: drm: Remove unused drm_device from drm_gem_object_lookup() URL : https://patchwork.freedesktop.org/series/6897/ State : warning == Summary == Series 6897v1 drm: Remove unused drm_device from drm_gem_object_lookup() http://patchwork.freedesktop.org/api/1.0/series/68

Re: [Intel-gfx] [PATCH] drm: use seqlocks for vblank time/count

2016-05-09 Thread Daniel Vetter
On Mon, May 09, 2016 at 08:16:07PM +0300, Ville Syrjälä wrote: > On Mon, May 09, 2016 at 05:08:43PM +0100, Matthew Auld wrote: > > This patch aims to replace the roll-your-own seqlock implementation with > > full-blown seqlock'. We also remove the timestamp ring-buffer in favour > > of single times

Re: [Intel-gfx] [PATCH i-g-t v4 4/5] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.

2016-05-09 Thread Robert Foss
On 2016-05-09 11:38 AM, Marius Vlad wrote: > On Tue, Apr 26, 2016 at 11:54:21AM -0400, robert.f...@collabora.com wrote: >> From: Robert Foss >> >> Previously crtc0 was statically used for VBLANK tests, but >> that assumption is not valid for the VC4 platform. >> Instead we're now explicitly s

Re: [Intel-gfx] [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

2016-05-09 Thread Chad Versace
On Mon 09 May 2016, Eric Engestrom wrote: > On Sun, May 01, 2016 at 09:39:58PM -0700, Jason Ekstrand wrote: > > On May 1, 2016 6:04 PM, "Kenneth Graunke" wrote: > > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > > > Adding the anv authors. > > > > > > > > Jason, Chad, is there a c

  1   2   >