Re: [Intel-gfx] [PATCH 01/21] drm/i915/slpc: Expose guc functions for use with SLPC

On Wed, Apr 27, 2016 at 06:10:45PM -0700, tom.orou...@intel.com wrote: > From: Tom O'Rourke > > Expose host2guc_action for use by SLPC in intel_slpc.c. > > Expose functions to allocate and release objects used > by GuC to be used for SLPC shared memory object. > > Signed-off-by: Tom O'Rourke >

Re: [Intel-gfx] [PATCH 04/21] drm/i915/slpc: Add enable_slpc module parameter

On Wed, Apr 27, 2016 at 06:10:48PM -0700, tom.orou...@intel.com wrote: > static void slpc_version_check(struct drm_device *dev, > struct intel_guc_fw *guc_fw) > { > @@ -126,6 +141,8 @@ static void slpc_version_check(struct drm_device *dev, > info = (stru

Re: [Intel-gfx] [PATCH 12/21] drm/i915/slpc: Send shutdown event

On Wed, Apr 27, 2016 at 06:10:56PM -0700, tom.orou...@intel.com wrote: > From: Tom O'Rourke > > Send SLPC shutdown event during disable, suspend, and reset > operations. Sending shutdown event while already shutdown > is OK. > > v2: return void instead of ignored error code (Paulo) > > Signed-

Re: [Intel-gfx] [PATCH 08/21] drm/i915/slpc: Allocate/Release/Initialize SLPC shared data

On Wed, Apr 27, 2016 at 06:10:52PM -0700, tom.orou...@intel.com wrote: > void intel_slpc_init(struct drm_device *dev) > { > - return; > + struct drm_i915_private *dev_priv = dev->dev_private; So what you wanted was dev_priv not dev! > + struct drm_i915_gem_object *obj; > + > + /

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for GuC-based SLPC (rev4)

== Series Details == Series: Add support for GuC-based SLPC (rev4) URL : https://patchwork.freedesktop.org/series/2691/ State : success == Summary == Series 2691v4 Add support for GuC-based SLPC http://patchwork.freedesktop.org/api/1.0/series/2691/revisions/4/mbox/ bdw-nuci7total:201

Re: [Intel-gfx] [PATCH 19/21] drm/i915/slpc: Add enable/disable debugfs for slpc

On Wed, Apr 27, 2016 at 06:11:03PM -0700, tom.orou...@intel.com wrote: > +static ssize_t slpc_balancer_write(struct file *file, const char __user > *ubuf, > + size_t len, loff_t *offp) > +{ > + struct seq_file *m = file->private_data; > + int ret = 0; > + > +

Re: [Intel-gfx] [PATCH] drm/i915: Protect gen7 irq_seqno_barrier with uncore lock

Chris Wilson writes: > [ text/plain ] > Faced with sporadic machine hangs on gen7, that mimic the issue of > concurrent writes to the same cacheline and seem to start with > commit 9b9ed309 (drm/i915: Remove forcewake dance from seqno/irq > barrier on legacy gen6+), let us restore the spinlock ar

Re: [Intel-gfx] [PATCH 21/21] drm/i915/slpc: Fail intel_runtime_suspend if SLPC or RPS not active

On to, 2016-04-28 at 07:56 +0100, Chris Wilson wrote: > On Wed, Apr 27, 2016 at 06:11:05PM -0700, tom.orou...@intel.com wrote: > > From: Sagar Arun Kamble > > > > intel_runtime_suspend failed with warning if RPS was disabled. > > With SLPC enabled, RPS is disabled. With SLPC, warning is now chang

Re: [Intel-gfx] [PATCH 21/21] drm/i915/slpc: Fail intel_runtime_suspend if SLPC or RPS not active

On Thu, Apr 28, 2016 at 10:57:20AM +0300, Imre Deak wrote: > On to, 2016-04-28 at 07:56 +0100, Chris Wilson wrote: > > On Wed, Apr 27, 2016 at 06:11:05PM -0700, tom.orou...@intel.com wrote: > > > From: Sagar Arun Kamble > > > > > > intel_runtime_suspend failed with warning if RPS was disabled. >

Re: [Intel-gfx] [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector.

On Tue, Apr 26, 2016 at 12:50:07PM -0400, Robert Foss wrote: > > > On 04/26/2016 10:10 AM, Daniel Vetter wrote: > >On Fri, Apr 22, 2016 at 05:24:59PM -0400, robert.f...@collabora.com wrote: > >>From: Robert Foss > >> > >>If an incompatible connector is found, don't skip the test, > >>but rather

Re: [Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote: > > > On 04/26/2016 01:00 PM, Ville Syrjälä wrote: > >On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote: > >> > >> > >>On 04/26/2016 10:11 AM, Daniel Vetter wrote: > >>>On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.f...@col

Re: [Intel-gfx] [PATCH 1/4] CI_ONLY: add enable_guc_loading parameter

On Wed, Apr 27, 2016 at 10:43:59AM +0100, Dave Gordon wrote: > On 26/04/16 15:18, Daniel Vetter wrote: > >On Mon, Apr 25, 2016 at 03:37:11PM +0100, Dave Gordon wrote: > >>Split the function of "enable_guc_submission" into two separate > >>options. The new one ("enable_guc_loading") controls only t

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use major_minor version for filename

On Mon, Apr 25, 2016 at 04:22:10PM -0700, tom.orou...@intel.com wrote: > From: Tom O'Rourke > > Load guc firmware from file with major_minor number > in filename instead of using symolic link with only > major number. What's the justification for this change? Either a release breaks ABI (or has

Re: [Intel-gfx] linux-next: build failure after merge of the drm tree

On Thu, 28 Apr 2016, Stephen Rothwell wrote: > Hi Dave, > > After merging the drm tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/gpu/drm/i915/intel_ddi.c: In function 'intel_prepare_ddi_buffer': > drivers/gpu/drm/i915/intel_ddi.c:447:15: error: 'struct drm_i91

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On Tue, Apr 26, 2016 at 08:57:51PM +0300, Ville Syrjälä wrote: > On Tue, Apr 26, 2016 at 04:30:05PM +0200, Daniel Vetter wrote: > > On Tue, Apr 26, 2016 at 05:26:43PM +0300, Eero Tamminen wrote: > > > Hi, > > > > > > On 26.04.2016 16:23, Chris Wilson wrote: > > > >On Tue, Apr 26, 2016 at 04:17:55P

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On Tue, Apr 26, 2016 at 07:01:06PM +0300, Imre Deak wrote: > On ti, 2016-04-26 at 15:42 +0100, Chris Wilson wrote: > > On Tue, Apr 26, 2016 at 05:26:43PM +0300, Eero Tamminen wrote: > > > Hi, > > > > > > On 26.04.2016 16:23, Chris Wilson wrote: > > > > On Tue, Apr 26, 2016 at 04:17:55PM +0300, Imr

Re: [Intel-gfx] [PATCH] drm/i915: Protect gen7 irq_seqno_barrier with uncore lock

On Wed, Apr 27, 2016 at 09:02:01AM +0100, Chris Wilson wrote: > Faced with sporadic machine hangs on gen7, that mimic the issue of > concurrent writes to the same cacheline and seem to start with > commit 9b9ed309 (drm/i915: Remove forcewake dance from seqno/irq > barrier on legacy gen6+), let us r

Re: [Intel-gfx] [PATCH i-g-t 2/3] igt_kms: Allow kmstest_get_connector_config to take provided drmModeGetResources

On Wed, Apr 27, 2016 at 04:12:35PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This will enable the following patch to generate less dmesg spam. > > Signed-off-by: Tvrtko Ursulin > --- > lib/igt_kms.c | 33 +++-- > lib/igt_kms.h | 3 ++- > t

Re: [Intel-gfx] [PATCH] i915 suspend/resume_noirq instead of suspend_late/resume_early

On Thu, Apr 28, 2016 at 12:36:29AM +0300, Imre Deak wrote: > On Wed, 2016-04-27 at 22:33 +0200, Lukas Wunner wrote: > > Hi, > > > > On Wed, Apr 27, 2016 at 11:46:22AM -0700, Todd Brandt wrote: > > >  I'd like to propose that we push the i915 > > > suspend_late/resume_early code > > >  into suspend

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use major_minor version for filename

On Thu, 28 Apr 2016, David Weinehall wrote: > On Mon, Apr 25, 2016 at 04:22:10PM -0700, tom.orou...@intel.com wrote: >> From: Tom O'Rourke >> >> Load guc firmware from file with major_minor number >> in filename instead of using symolic link with only >> major number. > > What's the justificatio

Re: [Intel-gfx] RFC: libdrm: Support Iris Graphics 540 & 550 (Skylake GT3e)

Kenneth Graunke wrote on 28.04.2016 03:05: > On Wednesday, April 27, 2016 9:37:07 AM PDT Thorsten Leemhuis wrote: >> Thorsten Leemhuis wrote on 26.04.2016 13:41: >> > Lo! Below patch adds the PCI-ID for the Intel(R) Iris Graphics 550 > (Skylake >>> GT3e mobile) to libdrm. It afaics is the last pie

Re: [Intel-gfx] [PATCH 15/21] drm/i915/slpc: Notification of Refresh Rate change

On Wed, Apr 27, 2016 at 06:10:59PM -0700, tom.orou...@intel.com wrote: > From: Sagar Arun Kamble > > This patch will inform GuC SLPC about changes in the refresh rate > due to Seamless DRRS. Refresh rate changes due to Static DRRS will > be notified via commit path. > > v2: Rebased on previous c

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On to, 2016-04-28 at 10:17 +0200, Daniel Vetter wrote: > On Tue, Apr 26, 2016 at 07:01:06PM +0300, Imre Deak wrote: > > On ti, 2016-04-26 at 15:42 +0100, Chris Wilson wrote: > > > On Tue, Apr 26, 2016 at 05:26:43PM +0300, Eero Tamminen wrote: > > > > Hi, > > > > > > > > On 26.04.2016 16:23, Chris

Re: [Intel-gfx] [PATCH 15/21] drm/i915/slpc: Notification of Refresh Rate change

On Thu, Apr 28, 2016 at 10:38:27AM +0200, Daniel Vetter wrote: > On Wed, Apr 27, 2016 at 06:10:59PM -0700, tom.orou...@intel.com wrote: > > From: Sagar Arun Kamble > > > > This patch will inform GuC SLPC about changes in the refresh rate > > due to Seamless DRRS. Refresh rate changes due to Stati

Re: [Intel-gfx] [PATCH] drm/i915: Protect gen7 irq_seqno_barrier with uncore lock

On Thu, Apr 28, 2016 at 10:23:00AM +0200, Daniel Vetter wrote: > On Wed, Apr 27, 2016 at 09:02:01AM +0100, Chris Wilson wrote: > > Faced with sporadic machine hangs on gen7, that mimic the issue of > > concurrent writes to the same cacheline and seem to start with > > commit 9b9ed309 (drm/i915: Rem

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2.

Op 27-04-16 om 15:24 schreef Patrik Jakobsson: > On Tue, Apr 19, 2016 at 09:52:22AM +0200, Maarten Lankhorst wrote: >> Both intel_unpin_work.pending and intel_unpin_work.enable_stall_check >> were used to see if work should be enabled. By only using pending >> some special cases are gone, and acces

Re: [Intel-gfx] [PATCH] drm/i915: Validate execbuffer start/length arguments against the target bo

On Fri, 20 Nov 2015, Ville Syrjälä wrote: > On Fri, Nov 20, 2015 at 03:11:04PM +, Chris Wilson wrote: >> The offset within and the length of the command sequence to execute are >> supplied by the user with respect to the batch buffer. We should be >> validating that region is wholly contained

Re: [Intel-gfx] [PATCH] drm/i915: Validate execbuffer start/length arguments against the target bo

On Thu, 28 Apr 2016, Jani Nikula wrote: > On Fri, 20 Nov 2015, Ville Syrjälä wrote: >> On Fri, Nov 20, 2015 at 03:11:04PM +, Chris Wilson wrote: >>> The offset within and the length of the command sequence to execute are >>> supplied by the user with respect to the batch buffer. We should be

Re: [Intel-gfx] [PATCH 9/9] drm: Quiet down drm_mode_getconnector

On Wed, Apr 27, 2016 at 11:07:02AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Debug logging in this function does not provide any information > apart that the userspace is calling an ioctl on the connector. > > There is not any info on the connector provided at all and > since there

Re: [Intel-gfx] [PATCH] drm: Quiet down drm_mode_getresources

On Wed, Apr 27, 2016 at 12:11:47PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > The debug logging here can be very verbose in the kernel logs > and provides no information which userspace doesn't have the > access to already. Turn it off so kernel logs become more > manageable. > > Si

[Intel-gfx] [CI 01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

When releasing the intel_fbdev, we should unpin the framebuffer that we pinned during construction. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_fbdev.c | 7 ++- 3 files changed, 8 insert

[Intel-gfx] [CI 04/25] drm/i915: Introduce i915_vm_to_ggtt()

In a couple of places, we have an i915_address_space that we know is really an i915_ggtt that we want to use. Create an inline helper to convert from the i915_address_space subclass into its container. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Reviewed-by: Joonas Lahtin

[Intel-gfx] [CI 02/25] drm/i915/overlay: Replace i915_gem_obj_ggtt_offset() with the known flip_addr

When setting up the overlay page, we pin it into the GGTT (when using virtual addresses) and store the offset as overlay->flip_addr. Rather than doing a lookup of the GGTT address everytime, we can use the known address instead. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko

[Intel-gfx] [CI 03/25] io-mapping: Specify mapping size for io_mapping_map_wc()

The ioremap() hidden behind the io_mapping_map_wc() convenience helper can be used for remapping multiple pages. Extend the helper so that future callers can use it for larger ranges. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Daniel Vetter Cc: Jani Nikula Cc: David Airlie Cc: Yishai

[Intel-gfx] [CI 05/25] drm/i915: Move ioremap_wc tracking onto VMA

By tracking the iomapping on the VMA itself, we can share that area between multiple users. Also by only revoking the iomapping upon unbinding from the mappable portion of the GGTT, we can keep that iomap across multiple invocations (e.g. execlists context pinning). Note that by moving the iounnma

[Intel-gfx] [CI 21/25] drm/i915: Move releasing of the GEM request from free to retire/cancel

If we move the release of the GEM request (i.e. decoupling it from the various lists used for client and context tracking) after it is complete (either by the GPU retiring the request, or by the caller cancelling the request), we can remove the requirement that the final unreference of the GEM requ

[Intel-gfx] [CI 09/25] drm/i915: Consolidate L3 remapping LRI

We can use a single MI_LOAD_REGISTER_IMM command packet to write all the L3 remapping registers, shrinking the number of bytes required to emit the context switch. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_context.c | 16 ++

[Intel-gfx] [CI 24/25] drm/i915: Stop tracking execlists retired requests

From: Tvrtko Ursulin With the previous patch having extended the pinned lifetime of contexts by referencing the previous context from the current request until the latter is retired (completed by the GPU), we can now remove usage of execlist retired queue entirely. This is because the above now

[Intel-gfx] [CI 06/25] drm/i915: Use i915_vma_pin_iomap on the ringbuffer object

Similarly to i915_gem_object_pin_map on LLC platforms, we can use the new VMA based io mapping on !LLC to amoritize the cost of ringbuffer pinning and unpinning. Signed-off-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/

[Intel-gfx] [CI 07/25] drm/i915: Mark the current context as lost on suspend

In order to force a reload of the context image upon resume, we first need to mark its absence on suspend. Currently we are failing to restore the golden context state and any context w/a to the default context after resume. One oversight corrected, is that we had forgotten to reapply the L3 remap

[Intel-gfx] [CI 22/25] drm/i915: Track the previous pinned context inside the request

As the contexts are accessed by the hardware until the switch is completed to a new context, the hardware may still be writing to the context object after the breadcrumb is visible. We must not unpin/unbind/prune that object whilst still active and so we keep the previous context pinned until the f

[Intel-gfx] [CI 10/25] drm/i915: Remove early l3-remap

Since we do the l3-remap on context switch, we can remove the redundant early call to set the mapping prior to performing the first context switch. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i91

[Intel-gfx] [CI 23/25] drm/i915: Store LRC hardware id in the request

From: Tvrtko Ursulin This way in the following patch we can disconnect requests from contexts. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_lrc.c | 3 ++- 2 files changed, 4 inserti

[Intel-gfx] [CI 15/25] drm/i915: Preallocate enough space for the average request

Rather than being interrupted when we run out of space halfway through the request, and having to restart from the beginning (and returning to userspace), flush a little more free space when we prepare the request. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin ---

[Intel-gfx] [CI 08/25] drm/i915: L3 cache remapping is part of context switching

Move the i915_gem_l3_remap function such that it next to the context switching, which is where we perform the L3 remap. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 31 --- drivers/gpu/drm/i

[Intel-gfx] [CI 14/25] drm/i915: Manually unwind after a failed request allocation

In the next patches, we want to move the work out of freeing the request and into its retirement (so that we can free the request without requiring the struct_mutex). This means that we cannot rely on unreferencing the request to completely teardown the request any more and so we need to manually u

[Intel-gfx] [CI 19/25] drm/i915: Refactor execlists default context pinning

Refactor pinning and unpinning of contexts, such that the default context for an engine is pinned during initialisation and unpinned during teardown (pinning of the context handles the reference counting). Thus we can eliminate the special case handling of the default context that was required to m

[Intel-gfx] [CI 16/25] drm/i915: Update execlists context descriptor format commentary

The comments describing the Context Descriptor Format are off by a bit for the size of the context ID. Signed-off-by: Chris Wilson Cc: Dave Gordon Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions

[Intel-gfx] [CI 20/25] drm/i915: Move the magical deferred context allocation into the request

We can hide more details of execlists from higher level code by removing the explicit call to create an execlist context from execbuffer and into its first use by execlists. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 dri

[Intel-gfx] [CI 25/25] drm/i915: Unify GPU resets upon shutdown

Both execlists and legacy need to reset the context (and mode) of the GPU before we lose control of the system. By resetting the GPU, we revert back to default settings. This simplifies the life of any subsequent driver (in particular for virtualized setups) as it does not then have to try and reco

[Intel-gfx] [CI 17/25] drm/i915: Assign every HW context a unique ID

The hardware tracks contexts and expects all live contexts (those active on the hardware) to have a unique identifier. This is used by the hardware to assign pagefaults and the like to a particular context. v2: Reorder to make sure ctx->link is not left dangling if the assignment of a hw_id fails

[Intel-gfx] [CI 13/25] drm/i915: Remove the identical implementations of request space reservation

Now that we share intel_ring_begin(), reserving space for the tail of the request is identical between legacy/execlists and so the tautology can be removed. In the process, we move the reserved space tracking from the ringbuffer on to the request. This is to enable us to reorder the reserved space

[Intel-gfx] [CI 11/25] drm/i915: Rearrange switch_context to load the aliasing ppgtt on first use

The code to switch_mm() is already handled by i915_switch_context(), the only difference required to setup the aliasing ppgtt is that we need to emit te switch_mm() on the first context, i.e. when transitioning from engine->last_context == NULL. This allows us to defer the initialisation of the GPU

[Intel-gfx] [CI 18/25] drm/i915: Replace the pinned context address with its unique ID

Rather than reuse the current location of the context in the global GTT for its hardware identifier, use the context's unique ID assigned to it for its whole lifetime. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 12 +--- drivers/gpu/

[Intel-gfx] [CI 12/25] drm/i915: Unify intel_ring_begin()

Combine the near identical implementations of intel_logical_ring_begin() and intel_ring_begin() - the only difference is that the logical wait has to check for a matching ring (which is assumed by legacy). In the process some debug messages are culled as there were following a WARN if we hit an ac

Re: [Intel-gfx] Kernel Oops on 3.14.66

Hi Dave, thank you again. I searched, where the memory for the request came from, it is set in line 2158 of i915_gem.c and the kmalloc is in intel_ring_alloc_seq

Re: [Intel-gfx] [PATCH] drm/i915: Validate execbuffer start/length arguments against the target bo

On Thu, Apr 28, 2016 at 11:54:04AM +0300, Jani Nikula wrote: > On Thu, 28 Apr 2016, Jani Nikula wrote: > > On Fri, 20 Nov 2015, Ville Syrjälä wrote: > >> On Fri, Nov 20, 2015 at 03:11:04PM +, Chris Wilson wrote: > >>> The offset within and the length of the command sequence to execute are > >

Re: [Intel-gfx] [PATCH i-g-t 2/3] igt_kms: Allow kmstest_get_connector_config to take provided drmModeGetResources

On 28/04/16 09:28, Daniel Vetter wrote: On Wed, Apr 27, 2016 at 04:12:35PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This will enable the following patch to generate less dmesg spam. Signed-off-by: Tvrtko Ursulin --- lib/igt_kms.c | 33 +++-- lib

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt_kms: Fix use after free in kmstest_get_pipe_from_crtc_id

On 27/04/16 16:12, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- lib/igt_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index ef24a4965567..7557bdc20fa4 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms

Re: [Intel-gfx] [PATCH 03/19] drm/i915: Remove intel_prepare_page_flip, v2.

Op 26-04-16 om 01:14 schreef Patrik Jakobsson: > On Tue, Apr 19, 2016 at 09:52:23AM +0200, Maarten Lankhorst wrote: >> Instead of calling prepare_flip right before calling finish_page_flip >> do everything from prepare_page_flip in finish_page_flip. >> >> Putting prepare and finish page_flip in a s

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Propagate error from drm_gem_object_init() (rev2)

On to, 2016-04-28 at 09:15 +0300, Joonas Lahtinen wrote: > On ke, 2016-04-27 at 14:44 +0100, Chris Wilson wrote: > > > > On Wed, Apr 27, 2016 at 04:35:33PM +0300, Joonas Lahtinen wrote: > > > > > > > > > On ma, 2016-04-25 at 13:24 +, Patchwork wrote: > > > > > > > > > > > > == Series Detai

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Extend GET_APERTURE ioctl to report available map space

On 26/04/16 10:44, Chris Wilson wrote: On Mon, Apr 25, 2016 at 03:51:09PM +0100, Tvrtko Ursulin wrote: On 25/04/16 11:35, Ankitprasad Sharma wrote: On Thu, 2016-04-21 at 15:59 +0100, Tvrtko Ursulin wrote: On 21/04/16 15:46, Chris Wilson wrote: On Thu, Apr 21, 2016 at 03:04:52PM +0100, Tvrtk

[Intel-gfx] [PATCH] drm/i915: Tidy intel_dump_pipe_config a bit

From: Tvrtko Ursulin A few tidies with the goal of making the output more compact and easier to read: 1. Group some data on single lines where it made sense. 2. Do not output scaler data on pre Gen9. 3. Fix plane dump so new log msg is not output in the midddle of the line and compact it a bi

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2.

On Thu, Apr 28, 2016 at 10:48:55AM +0200, Maarten Lankhorst wrote: > Op 27-04-16 om 15:24 schreef Patrik Jakobsson: > > On Tue, Apr 19, 2016 at 09:52:22AM +0200, Maarten Lankhorst wrote: > >> Both intel_unpin_work.pending and intel_unpin_work.enable_stall_check > >> were used to see if work should

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Support for creating/using Stolen memory backed objects (rev13)

Hi Ankit, On 20/04/16 17:28, Patchwork wrote: == Series Details == Series: Support for creating/using Stolen memory backed objects (rev13) URL : https://patchwork.freedesktop.org/series/659/ State : failure == Summary == Series 659v13 Support for creating/using Stolen memory backed objects

Re: [Intel-gfx] [PATCH 02/19] drm/i915: Remove stallcheck special handling, v2.

Op 28-04-16 om 11:54 schreef Patrik Jakobsson: > On Thu, Apr 28, 2016 at 10:48:55AM +0200, Maarten Lankhorst wrote: >> Op 27-04-16 om 15:24 schreef Patrik Jakobsson: >>> On Tue, Apr 19, 2016 at 09:52:22AM +0200, Maarten Lankhorst wrote: Both intel_unpin_work.pending and intel_unpin_work.enable

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Extend GET_APERTURE ioctl to report available map space

On Thu, Apr 28, 2016 at 10:30:32AM +0100, Tvrtko Ursulin wrote: > > On 26/04/16 10:44, Chris Wilson wrote: > >On Mon, Apr 25, 2016 at 03:51:09PM +0100, Tvrtko Ursulin wrote: > >> > >>On 25/04/16 11:35, Ankitprasad Sharma wrote: > >>>On Thu, 2016-04-21 at 15:59 +0100, Tvrtko Ursulin wrote: > On

Re: [Intel-gfx] [PATCH] drm/i915: Fix enc_to_dig_port() for MST encoders

On Thu, Apr 28, 2016 at 09:17:00AM +0300, Jani Nikula wrote: > On Wed, 27 Apr 2016, Lyude wrote: > > For MST encoders, the encoder struct is stored in the intel_dp_mst > > struct, not a intel_digital_port struct. > > > > This fixes issues with hotplugging MST displays that support MST audio, > > w

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: Fix inadvertent CPU snooping due to incorrect MOCS config

On Thu, Apr 28, 2016 at 10:13:37AM +0200, Daniel Vetter wrote: > On Tue, Apr 26, 2016 at 08:57:51PM +0300, Ville Syrjälä wrote: > > On Tue, Apr 26, 2016 at 04:30:05PM +0200, Daniel Vetter wrote: > > > On Tue, Apr 26, 2016 at 05:26:43PM +0300, Eero Tamminen wrote: > > > > Hi, > > > > > > > > On 26.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

== Series Details == Series: series starting with [CI,01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release URL : https://patchwork.freedesktop.org/series/6453/ State : failure == Summary == Series 6453v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/6453/r

Re: [Intel-gfx] [PATCH] drm/i915: Validate execbuffer start/length arguments against the target bo

On 28/04/16 10:02, Chris Wilson wrote: On Thu, Apr 28, 2016 at 11:54:04AM +0300, Jani Nikula wrote: On Thu, 28 Apr 2016, Jani Nikula wrote: On Fri, 20 Nov 2015, Ville Syrjälä wrote: On Fri, Nov 20, 2015 at 03:11:04PM +, Chris Wilson wrote: The offset within and the length of the command

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

On Thu, Apr 28, 2016 at 10:58:29AM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,01/25] drm/i915/fbdev: Call > intel_unpin_fb_obj() on release > URL : https://patchwork.freedesktop.org/series/6453/ > State : failure > > == Summary == > > Series 6453v1 Ser

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Tidy intel_dump_pipe_config a bit

== Series Details == Series: drm/i915: Tidy intel_dump_pipe_config a bit URL : https://patchwork.freedesktop.org/series/6457/ State : failure == Summary == Series 6457v1 drm/i915: Tidy intel_dump_pipe_config a bit http://patchwork.freedesktop.org/api/1.0/series/6457/revisions/1/mbox/ Test drv

[Intel-gfx] [PATCH] drm/i915: remove i915_gem_object_ggtt_unbind

Only has one user and is nothing more than a shim on top of i915_vma_unbind, so let's just get rid of it. Cc: Joonas Lahtinen Suggested-by: Joonas Lahtinen Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_drv.h| 6 -- drivers/gpu/drm/i915/i915_gem_tiling.c | 2 +- 2 files

[Intel-gfx] [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915

Signed-off-by: Joonas Lahtinen --- dim | 5 + 1 file changed, 5 insertions(+) diff --git a/dim b/dim index dbcb7d9..1c258be 100755 --- a/dim +++ b/dim @@ -691,6 +691,11 @@ function checkpatch_commit if test "$bug_lines" -eq 1; then warn_or_fail "New BUG macro added"

[Intel-gfx] [PATCH maintainer-tools 1/2] dim: Use -e on warn_or_fail to allow fo newlines

Signed-off-by: Joonas Lahtinen --- dim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dim b/dim index d9c1be5..dbcb7d9 100755 --- a/dim +++ b/dim @@ -118,9 +118,9 @@ HELP= function warn_or_fail { if [[ $FORCE ]] ; then - echo WARNING: $1, but conti

Re: [Intel-gfx] Kernel Oops on 3.14.66

On 28/04/16 09:58, Andreas Lampersperger wrote: Hi Dave, thank you again. I searched, where the memory for the request came from, it is set in line 2158 of i915_gem.c

[Intel-gfx] [PATCH] drm/i915: Simplify intel_mark_busy/idle

From: Tvrtko Ursulin They use dev_priv exclusively so pass it in instead of dev for smaller source and binary. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 4 ++-- drivers/gpu/drm/i915/intel_display.c | 14 +- drivers/gpu/drm/i915/intel_drv.h | 4 +

Re: [Intel-gfx] [PATCH] drm/i915: Simplify intel_mark_busy/idle

On Thu, Apr 28, 2016 at 12:57:00PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > They use dev_priv exclusively so pass it in instead of dev > for smaller source and binary. True, but we have an outstanding bug report and patch here because we have current breakage with rpm :( > Signed

Re: [Intel-gfx] [PATCH] drm/i915: Fix enc_to_dig_port() for MST encoders

On Thu, 28 Apr 2016, Ville Syrjälä wrote: > On Thu, Apr 28, 2016 at 09:17:00AM +0300, Jani Nikula wrote: >> On Wed, 27 Apr 2016, Lyude wrote: >> > For MST encoders, the encoder struct is stored in the intel_dp_mst >> > struct, not a intel_digital_port struct. >> > >> > This fixes issues with hotp

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove i915_gem_object_ggtt_unbind

== Series Details == Series: drm/i915: remove i915_gem_object_ggtt_unbind URL : https://patchwork.freedesktop.org/series/6461/ State : failure == Summary == Series 6461v1 drm/i915: remove i915_gem_object_ggtt_unbind http://patchwork.freedesktop.org/api/1.0/series/6461/revisions/1/mbox/ Test d

Re: [Intel-gfx] [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915

On Thu, 28 Apr 2016, Joonas Lahtinen wrote: > Signed-off-by: Joonas Lahtinen > --- > dim | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/dim b/dim > index dbcb7d9..1c258be 100755 > --- a/dim > +++ b/dim > @@ -691,6 +691,11 @@ function checkpatch_commit > if test "$bug_lines"

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Simplify intel_mark_busy/idle

== Series Details == Series: drm/i915: Simplify intel_mark_busy/idle URL : https://patchwork.freedesktop.org/series/6465/ State : failure == Summary == Series 6465v1 drm/i915: Simplify intel_mark_busy/idle http://patchwork.freedesktop.org/api/1.0/series/6465/revisions/1/mbox/ Test gem_ringfil

Re: [Intel-gfx] [PATCH 11/35] drm/armada: Use lockless gem BO free callback

On Tue, Apr 26, 2016 at 07:29:44PM +0200, Daniel Vetter wrote: > No dev->struct_mutex anywhere to be seen. > > Cc: Russell King Acked-by: Russell King Thanks Daniel. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps do

Re: [Intel-gfx] [PATCH 16/35] drm/etnaviv: Use lockless gem BO free callback

On Tue, Apr 26, 2016 at 07:29:49PM +0200, Daniel Vetter wrote: > No dev->struct_mutex anywhere to be seen. > > Cc: Christian Gmeiner > Cc: Russell King Acked-by: Russell King Thanks Daniel. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line

[Intel-gfx] [PATCH i-g-t v5 1/6] kms_panel_fitting: Remove un-read variable.

From: Robert Foss Remove devid from data_t since it is never read. Also remove one assignment to devid. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso --- tests/kms_panel_fitting.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c

[Intel-gfx] [PATCH i-g-t v5 3/6] kms_panel_fitting: Remove un-used variable.

From: Robert Foss ref_crc is never assigned or read, and can be safely removed. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso --- tests/kms_panel_fitting.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c index 7bfd980..099816b 10

[Intel-gfx] [PATCH i-g-t v5 2/6] kms_panel_fitting: Remove un-read variable pipe_crc.

From: Robert Foss pipe_crc in data_t is assigned an allocated memory space and then later free'd. But it is never used for any comparisons. It should therefore be safe to remove pipe_crc and the crc requirement. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso --- tests/kms_panel_fitting.

[Intel-gfx] [PATCH i-g-t v5 0/6] Improve kms_panel_fitting.

From: Robert Foss Changes since v4: - Added reviewed-by danvet to patch 6, all patches are now reviewed. Changes since v3: - kms_panel_fitting.c: Pass NULL arguments instead - Added bugzilla link: https://bugs.freedesktop.org/show_bug.cgi?id=93012 Changes since v2: - Added reviewed-by tomeu to

[Intel-gfx] [PATCH i-g-t v5 5/6] kms_panel_fitting: Enabled test on non-Intel hardware.

From: Robert Foss Switched from DRIVER_INTEL to DRIVER_ANY to enable test on all hardware. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso --- tests/kms_panel_fitting.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting

[Intel-gfx] [PATCH i-g-t v5 4/6] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative.

From: Robert Foss Changed the DRM format to LOCAL_DRM_FORMAT_MOD_NONE since it is hardware agnostic. Also fixed formatting/tabs. Signed-off-by: Robert Foss Reviewed-by: Tomeu Vizoso --- tests/kms_panel_fitting.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t

[Intel-gfx] [PATCH i-g-t v5 6/6] kms_panel_fitting: Enable connectors with "scaling mode" property set.

From: Robert Foss Enable testing on all connectors that have the "scaling mode" property set. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93012 Signed-off-by: Robert Foss Reviewed-by: Daniel Vetter --- tests/kms_panel_fitting.c | 15 --- 1 file changed, 12 insertions(+)

[Intel-gfx] [PATCH] drm/i915/execlists: Refactor common engine setup

Move all of the constant assignments up front and into a common function. This is primarily to ensure the backpointers are set as early as possible for later use during initialisation. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- I'm not too happy about using the function parameters with

Re: [Intel-gfx] [PATCH maintainer-tools 2/2] dim: Refuse to commit patches that modify files outside of i915

On Thu, Apr 28, 2016 at 02:32:20PM +0300, Joonas Lahtinen wrote: > Signed-off-by: Joonas Lahtinen > --- > dim | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/dim b/dim > index dbcb7d9..1c258be 100755 > --- a/dim > +++ b/dim > @@ -691,6 +691,11 @@ function checkpatch_commit >

Re: [Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

On 04/28/2016 04:02 AM, Daniel Vetter wrote: On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote: On 04/26/2016 01:00 PM, Ville Syrjälä wrote: On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote: On 04/26/2016 10:11 AM, Daniel Vetter wrote: On Fri, Apr 22, 2016 at 05:25:

Re: [Intel-gfx] [CI 13/25] drm/i915: Remove the identical implementations of request space reservation

On 28/04/16 09:56, Chris Wilson wrote: Now that we share intel_ring_begin(), reserving space for the tail of the request is identical between legacy/execlists and so the tautology can be removed. In the process, we move the reserved space tracking from the ringbuffer on to the request. This is to

Re: [Intel-gfx] [RFC PATCH 2/2] drm/i915/bxt: Adjusting the error in horizontal timings retrieval

On Wed, 27 Apr 2016, Ville Syrjälä wrote: > On Tue, Apr 19, 2016 at 01:48:14PM +0530, Ramalingam C wrote: >> In BXT DSI there is no regs programmed with few horizontal timings >> in Pixels but txbyteclkhs.. So retrieval process adds some >> ROUND_UP ERRORS in the process of PIXELS<==>txbyteclkhs.

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/execlists: Refactor common engine setup

== Series Details == Series: drm/i915/execlists: Refactor common engine setup URL : https://patchwork.freedesktop.org/series/6480/ State : warning == Summary == Series 6480v1 drm/i915/execlists: Refactor common engine setup http://patchwork.freedesktop.org/api/1.0/series/6480/revisions/1/mbox/

Re: [Intel-gfx] [CI 13/25] drm/i915: Remove the identical implementations of request space reservation

On Thu, Apr 28, 2016 at 03:02:18PM +0100, Dave Gordon wrote: > On 28/04/16 09:56, Chris Wilson wrote: > >Now that we share intel_ring_begin(), reserving space for the tail of > >the request is identical between legacy/execlists and so the tautology > >can be removed. In the process, we move the res

Re: [Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

On Thu, Apr 28, 2016 at 10:07:41AM -0400, Robert Foss wrote: > > > On 04/28/2016 04:02 AM, Daniel Vetter wrote: > >On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote: > >> > >> > >>On 04/26/2016 01:00 PM, Ville Syrjälä wrote: > >>>On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wro

  1   2   >