[Intel-gfx] [PATCH v3 08/16] drm/i915/gen9: Compute DDB allocation at atomic check time (v2)

2016-04-21 Thread Matt Roper
Calculate the DDB blocks needed to satisfy the current atomic transaction at atomic check time. This is a prerequisite to calculating SKL watermarks during the 'check' phase and rejecting any configurations that we can't find valid watermarks for. Due to the nature of DDB allocation, it's possibl

[Intel-gfx] [PATCH v3 11/16] drm/i915/gen9: Allow watermark calculation on in-flight atomic state (v3)

2016-04-21 Thread Matt Roper
In an upcoming patch we'll move this calculation to the atomic 'check' phase so that the display update can be rejected early if no valid watermark programming is possible. v2: - Drop intel_pstate_for_cstate_plane() helper and add note about how the code needs to evolve in the future if we sta

[Intel-gfx] [PATCH v3 09/16] drm/i915/gen9: Drop re-allocation of DDB at atomic commit (v2)

2016-04-21 Thread Matt Roper
Now that we're properly pre-allocating the DDB during the atomic check phase and we trust that the allocation is appropriate, let's actually use the allocation computed and not duplicate that work during the commit phase. v2: - Significant rebasing now that we can use cached data rates and min

[Intel-gfx] [PATCH v3 06/16] drm/i915: Track whether an atomic transaction changes the active CRTC's

2016-04-21 Thread Matt Roper
For the purposes of DDB re-allocation we need to know whether a transaction changes the list of CRTC's that are active. While state->modeset could be used for this purpose, that would be slightly too aggressive since it would lead us to re-allocate the DDB when a CRTC's mode changes, but not its f

[Intel-gfx] [PATCH v3 12/16] drm/i915/gen9: Use a bitmask to track dirty pipe watermarks

2016-04-21 Thread Matt Roper
Slightly easier to work with than an array of bools. Signed-off-by: Matt Roper Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_dr

[Intel-gfx] [PATCH v3 14/16] drm/i915/gen9: Calculate watermarks during atomic 'check'

2016-04-21 Thread Matt Roper
Moving watermark calculation into the check phase will allow us to to reject display configurations for which there are no valid watermark values before we start trying to program the hardware (although those tests will come in a subsequent patch). Another advantage of moving this calculation to t

[Intel-gfx] [PATCH v3 13/16] drm/i915/gen9: Propagate watermark calculation failures up the call chain

2016-04-21 Thread Matt Roper
Once we move watermark calculation to the atomic check phase, we'll want to start rejecting display configurations that exceed out watermark limits. At the moment we just assume that there's always a valid set of watermarks, even though this may not actually be true. Let's prepare by passing retu

[Intel-gfx] [PATCH v3 10/16] drm/i915/gen9: Calculate plane WM's from state

2016-04-21 Thread Matt Roper
In a future patch we'll want to calculate plane watermarks for in-flight atomic state rather than the already-committed state. Signed-off-by: Matt Roper Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_pm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) dif

[Intel-gfx] [PATCH v3 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations (v2)

2016-04-21 Thread Matt Roper
If we can't find any valid level 0 watermark values for the requested atomic transaction, reject the configuration before we try to start programming the hardware. v2: - Add extra debugging output when we reject level 0 watermarks so that we can more easily debug how/why they were rejected. C

[Intel-gfx] [PATCH v3 16/16] drm/i915: Remove wm_config from dev_priv/intel_atomic_state

2016-04-21 Thread Matt Roper
We calculate the watermark config into intel_atomic_state and then save it into dev_priv, but never actually use it from there. This is left-over from some early ILK-style watermark programming designs that got changed over time. Signed-off-by: Matt Roper Reviewed-by: Maarten Lankhorst --- dri

Re: [Intel-gfx] [PATCH v2 13/16] drm/i915/gen9: Propagate watermark calculation failures up the call chain

2016-04-21 Thread Matt Roper
On Thu, Apr 21, 2016 at 02:19:33PM +0200, Maarten Lankhorst wrote: > Op 20-04-16 om 04:26 schreef Matt Roper: > > Once we move watermark calculation to the atomic check phase, we'll want > > to start rejecting display configurations that exceed out watermark > > limits. At the moment we just assum

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-04-21 Thread Robert Bragg
On Thu, Apr 21, 2016 at 4:18 PM, Robert Bragg wrote: > > > On Thu, Apr 21, 2016 at 12:09 AM, Chris Wilson > wrote: > >> On Wed, Apr 20, 2016 at 03:23:10PM +0100, Robert Bragg wrote: >> > +static void i915_oa_stream_enable(struct i915_perf_stream *stream) >> > +{ >> > + struct drm_i915_privat

[Intel-gfx] [PATCH] kms_atomic: Fix crtc_id comparison failing.

2016-04-21 Thread robert . foss
From: Robert Foss Fixed ctrc_id comparison failing due to bad initialization of crtc variable. Signed-off-by: Robert Foss --- tests/kms_atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c index 13a5db1..f27ee46 100644 --- a/tests

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for new aspect ratios

2016-04-21 Thread Sharma, Shashank
Thanks for the review Daniel. My comments inline. Regards Shashank On 4/21/2016 8:34 PM, Daniel Vetter wrote: On Fri, Mar 25, 2016 at 01:47:35PM +0530, Shashank Sharma wrote: HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds support for these aspect ratios

Re: [Intel-gfx] [RESEND FOR CI PATCH 2/2] drm/i915: Fixing eDP detection on certain platforms

2016-04-21 Thread Ander Conselvan De Oliveira
On Thu, 2016-04-21 at 16:59 -0400, Lyude wrote: > Ping. Any chance we could get these pushed upstream soon? They were pushed to dinq Tuesday. Ander > > On Wed, 2016-04-13 at 10:47 +0300, Ander Conselvan de Oliveira wrote: > > From: Shubhangi Shrivastava > > > > Since commit 30d9aa4265fe ("drm

Re: [Intel-gfx] [PATCH 02/14] MAINTAINERS: Remove unneded wildcard for the i915 DRM driver

2016-04-21 Thread Jani Nikula
On Fri, 22 Apr 2016, Emil Velikov wrote: > [ text/plain ] > There is no other file but the UAPI header, thus we can drop the > wildcard. > > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: Emil Velikov Acked-by: J

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [01/19] drm/i915/overlay: Replace i915_gem_obj_ggtt_offset() with the known flip_addr

2016-04-21 Thread Patchwork
== Series Details == Series: series starting with [01/19] drm/i915/overlay: Replace i915_gem_obj_ggtt_offset() with the known flip_addr URL : https://patchwork.freedesktop.org/series/6081/ State : warning == Summary == Series 6081v1 Series without cover letter http://patchwork.freedesktop.org

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/vlv: Enable polling when we shut off all power domains

2016-04-21 Thread Patchwork
== Series Details == Series: drm/i915/vlv: Enable polling when we shut off all power domains URL : https://patchwork.freedesktop.org/series/6095/ State : warning == Summary == Series 6095v1 drm/i915/vlv: Enable polling when we shut off all power domains http://patchwork.freedesktop.org/api/1.0

<    1   2   3