[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: clean up aliasing_gtt_bind_vma

2016-03-24 Thread Patchwork
== Series Details == Series: drm/i915: clean up aliasing_gtt_bind_vma URL : https://patchwork.freedesktop.org/series/4815/ State : failure == Summary == Series 4815v1 drm/i915: clean up aliasing_gtt_bind_vma 2016-03-23T15:56:28.165993 http://patchwork.freedesktop.org/api/1.0/series/4815/revis

[Intel-gfx] Enabling 30-bit depth with Intel Graphics

2016-03-24 Thread Marvin Pribadi
[resending because my previous msg didn't get through] Hi devs, I would like to get 10-bit color depth working on my system for proper playback of HEVC Main10 profile. I'm writing some software to do this, but for initial test purposes I'm using readily available applications. So far I'm not able

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Tidy aliasing_gtt_bind_vma()

2016-03-24 Thread Patchwork
== Series Details == Series: drm/i915: Tidy aliasing_gtt_bind_vma() URL : https://patchwork.freedesktop.org/series/990/ State : failure == Summary == Series 990v1 drm/i915: Tidy aliasing_gtt_bind_vma() 2016-03-23T16:40:39.102374 http://patchwork.freedesktop.org/api/1.0/series/990/revisions/1/

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rename GGTT init functions

2016-03-24 Thread Joonas Lahtinen
On ke, 2016-03-23 at 18:02 +0200, Ville Syrjälä wrote: > On Wed, Mar 23, 2016 at 05:54:09PM +0200, Mika Kuoppala wrote: > > > > Ville Syrjälä writes: > > > > > > > > [ text/plain ] > > > On Wed, Mar 23, 2016 at 03:00:22PM +0200, Joonas Lahtinen wrote: > > > > > > > > Rename and document the GG

Re: [Intel-gfx] [PATCH 174/190] drm/i915: Show context objects in debugfs/i915_gem_objects

2016-03-24 Thread David Weinehall
On Mon, Jan 11, 2016 at 11:01:15AM +, Chris Wilson wrote: > Signed-off-by: Chris Wilson With ring --> ringbuf, unless your s/ringbuf/ring/ patch is merged, obviously: Reviewed-by: David Weinehall > --- > drivers/gpu/drm/i915/i915_debugfs.c | 35 +++ > 1 fil

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make pages of GFX allocations movable

2016-03-24 Thread Chris Wilson
On Wed, Mar 23, 2016 at 01:55:14PM +0530, Goel, Akash wrote: > > > On 3/23/2016 1:28 PM, Chris Wilson wrote: > >On Wed, Mar 23, 2016 at 11:39:44AM +0530, akash.g...@intel.com wrote: > >>+#ifdef CONFIG_MIGRATION > >>+static int i915_migratepage(struct address_space *mapping, > >>+

Re: [Intel-gfx] [PATCH 164/190] drm/i915: Move obj->dirty:1 to obj->flags

2016-03-24 Thread David Weinehall
On Mon, Jan 11, 2016 at 11:01:05AM +, Chris Wilson wrote: > The obj->dirty bit is a companion to the obj->active bits that were > moved to the obj->flags bitmask. Since we also update this bit inside > the i915_vma_move_to_active() hotpath, we can aide gcc by also moving > the obj->dirty bit to

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm: Add support for EDID injection.

2016-03-24 Thread Patchwork
== Series Details == Series: drm: Add support for EDID injection. URL : https://patchwork.freedesktop.org/series/4818/ State : warning == Summary == Series 4818v1 drm: Add support for EDID injection. http://patchwork.freedesktop.org/api/1.0/series/4818/revisions/1/mbox/ Test kms_flip:

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Allow mmio updates on all platforms.

2016-03-24 Thread Maarten Lankhorst
Op 23-03-16 om 16:07 schreef Ville Syrjälä: > On Wed, Mar 23, 2016 at 02:24:30PM +0100, Maarten Lankhorst wrote: >> Rename intel_unpin_work to intel_flip_work and use it for mmio flips >> and unpinning. Use flip_queued_req to hold the wait request in the >> mmio case and allow the vblank interrupt

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fixes and worarounds for GuC issues (rev3)

2016-03-24 Thread Patchwork
== Series Details == Series: Fixes and worarounds for GuC issues (rev3) URL : https://patchwork.freedesktop.org/series/4694/ State : failure == Summary == Series 4694v3 Fixes and worarounds for GuC issues 2016-03-23T16:43:55.381802 http://patchwork.freedesktop.org/api/1.0/series/4694/revision

Re: [Intel-gfx] Fixing i915/opregion issues with firmware which lists more then 8 output devices

2016-03-24 Thread Jani Nikula
On Wed, 23 Mar 2016, Nicolas Repentin wrote: > Thanks ;) > > I'm sorry, but do you have a "howto" for doing this? > > Not very familiar with patching things. This should get you started: http://kernelnewbies.org/KernelBuild HTH, Jani. > > Nicolas > > Le 23/03/2016 12:36, Jani Nikula a écrit :

Re: [Intel-gfx] [PATCH v2] drm/i915/bxt: Fix DSI HW state readout

2016-03-24 Thread Jani Nikula
On Wed, 23 Mar 2016, Imre Deak wrote: > Currently the machine hangs during booting while accessing the > BXT_MIPI_PORT_CTRL register during pipe HW state readout. After some > experimentation I found that the hang is caused by the DSI PLL being > disabled, or it being enabled but with an incorrect

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix potential dangling else problems in for_each_ macros (rev3)

2016-03-24 Thread Patchwork
== Series Details == Series: drm/i915: fix potential dangling else problems in for_each_ macros (rev3) URL : https://patchwork.freedesktop.org/series/1142/ State : failure == Summary == Series 1142v3 drm/i915: fix potential dangling else problems in for_each_ macros http://patchwork.freedeskt

[Intel-gfx] [PATCH 2/2] drm/i915: CABC support for backlight control

2016-03-24 Thread Deepak M
In CABC (Content Adaptive Brightness Control) content grey level scale can be increased while simultaneously decreasing brightness of the backlight to achieve same perceived brightness. The CABC is not standardized and panel vendors are free to follow their implementation. The CABC implementaion h

[Intel-gfx] [PATCH 1/2] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fileds in VBT

2016-03-24 Thread Deepak M
For dual link panel scenarios there are new fileds added in the VBT which indicate on which port the PWM cntrl and CABC ON/OFF commands needs to be sent. v2: Moving the comment to intel_dsi.h(Jani) Cc: Jani Nikula Cc: Daniel Vetter Cc: Yetunde Adebisi Signed-off-by: Deepak M --- drivers/gpu/

[Intel-gfx] [intelddx] v2.99.917-580-gf656f6afa288: sh: 1: ACLOCAL_FLAGS: not found

2016-03-24 Thread Sedat Dilek
[ build-script, build and config logs attached ] Hi Chris, I am just seeing this (or noticed for the first time, here on Ubuntu/precise AMD64)... $ zgrep -A1 -B1 ACLOCAL_FLAGS: build-and-install-log_intelddx-2-99-917-580-gf656f6afa288_tearfree-enabled_llvm-3-8-0.txt.gz autoreconf: running: acloc

Re: [Intel-gfx] [RFC] drm/i915: Move execlists irq handler to a bottom half

2016-03-24 Thread Tvrtko Ursulin
On 23/03/16 15:23, Tvrtko Ursulin wrote: On 23/03/16 12:56, Chris Wilson wrote: On Wed, Mar 23, 2016 at 12:46:35PM +, Tvrtko Ursulin wrote: On 23/03/16 11:31, Chris Wilson wrote: On Wed, Mar 23, 2016 at 10:08:46AM +, Tvrtko Ursulin wrote: You think it is OK to continue sharing your

Re: [Intel-gfx] [PATCH v3 1/2 RESEND] drm/dp_helper: add workarounds from intel_dp_dpcd_read_wake()

2016-03-24 Thread Jani Nikula
On Wed, 23 Mar 2016, Lyude wrote: > Some sinks need some time during the process of resuming the system from > sleep before they're ready to handle transactions. While it would be > nice if they responded with NACKs in these scenarios, this isn't always > the case as a few sinks will just timeout

Re: [Intel-gfx] [PATCH 2/2] drm/i915: CABC support for backlight control

2016-03-24 Thread Jani Nikula
On Thu, 24 Mar 2016, Deepak M wrote: > [ text/plain ] > In CABC (Content Adaptive Brightness Control) content grey level > scale can be increased while simultaneously decreasing > brightness of the backlight to achieve same perceived brightness. > > The CABC is not standardized and panel vendors a

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove impossibe checks from i915_gem_request_add_to_client

2016-03-24 Thread Tvrtko Ursulin
On 23/03/16 15:31, Chris Wilson wrote: On Wed, Mar 23, 2016 at 03:15:03PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin There is only one caller of this functions which calls it under strictly defined conditions. Error checking and return value can be removed. Signed-off-by: Tvrtko Ursul

Re: [Intel-gfx] [intelddx] v2.99.917-580-gf656f6afa288: sh: 1: ACLOCAL_FLAGS: not found

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 10:34:58AM +0100, Sedat Dilek wrote: > [ build-script, build and config logs attached ] > > Hi Chris, > > I am just seeing this (or noticed for the first time, here on > Ubuntu/precise AMD64)... > > $ zgrep -A1 -B1 ACLOCAL_FLAGS: > build-and-install-log_intelddx-2-99-917-

Re: [Intel-gfx] [intelddx] v2.99.917-580-gf656f6afa288: sh: 1: ACLOCAL_FLAGS: not found

2016-03-24 Thread Sedat Dilek
On Thu, Mar 24, 2016 at 10:54 AM, Chris Wilson wrote: > On Thu, Mar 24, 2016 at 10:34:58AM +0100, Sedat Dilek wrote: >> [ build-script, build and config logs attached ] >> >> Hi Chris, >> >> I am just seeing this (or noticed for the first time, here on >> Ubuntu/precise AMD64)... >> >> $ zgrep -A1

Re: [Intel-gfx] [PATCH v2] drm/i915/bxt: Fix DSI HW state readout

2016-03-24 Thread Imre Deak
On to, 2016-03-24 at 11:15 +0200, Jani Nikula wrote: > On Wed, 23 Mar 2016, Imre Deak wrote: > > Currently the machine hangs during booting while accessing the > > BXT_MIPI_PORT_CTRL register during pipe HW state readout. After > > some > > experimentation I found that the hang is caused by the DS

[Intel-gfx] [PATCH 2/3] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fileds in VBT

2016-03-24 Thread Deepak M
For dual link panel scenarios there are new fileds added in the VBT which indicate on which port the PWM cntrl and CABC ON/OFF commands needs to be sent. v2: Moving the comment to intel_dsi.h(Jani) Cc: Jani Nikula Cc: Daniel Vetter Cc: Yetunde Adebisi Signed-off-by: Deepak M --- drivers/gpu/

Re: [Intel-gfx] [PATCH 2/2] drm/i915: CABC support for backlight control

2016-03-24 Thread Deepak, M
> -Original Message- > From: Nikula, Jani > Sent: Thursday, March 24, 2016 3:11 PM > To: Deepak, M ; intel-gfx@lists.freedesktop.org > Cc: Deepak, M ; Vetter, Daniel > ; Adebisi, YetundeX > > Subject: Re: [PATCH 2/2] drm/i915: CABC support for backlight control > > On Thu, 24 Mar 2016,

[Intel-gfx] [PATCH 1/3] drm: Add new DCS commands in the enum list

2016-03-24 Thread Deepak M
Adding new DCS commands which are specified in the DCS 1.3 spec related to CABC. Cc: Thierry Reding Cc: David Airlie Cc: Ville Syrjälä Cc: Daniel Vetter Suggested-by: Jani Nikula Signed-off-by: Deepak M --- include/video/mipi_display.h | 8 1 file changed, 8 insertions(+) diff --g

[Intel-gfx] [PATCH 3/3] drm/i915: CABC support for backlight control

2016-03-24 Thread Deepak M
In CABC (Content Adaptive Brightness Control) content grey level scale can be increased while simultaneously decreasing brightness of the backlight to achieve same perceived brightness. The CABC is not standardized and panel vendors are free to follow their implementation. The CABC implementaion h

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fileds in VBT

2016-03-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fileds in VBT URL : https://patchwork.freedesktop.org/series/4847/ State : failure == Summary == CC [M] drivers/net/ethernet/intel/igb/e1000_mac.o CC [M] drivers/net/ethernet/intel/ig

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove impossibe checks from i915_gem_request_add_to_client

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 09:49:25AM +, Tvrtko Ursulin wrote: > > On 23/03/16 15:31, Chris Wilson wrote: > >On Wed, Mar 23, 2016 at 03:15:03PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>There is only one caller of this functions which calls it under > >>strictly defined cond

Re: [Intel-gfx] [intelddx] v2.99.917-580-gf656f6afa288: sh: 1: ACLOCAL_FLAGS: not found

2016-03-24 Thread Sedat Dilek
On Thu, Mar 24, 2016 at 10:54 AM, Chris Wilson wrote: > On Thu, Mar 24, 2016 at 10:34:58AM +0100, Sedat Dilek wrote: >> [ build-script, build and config logs attached ] >> >> Hi Chris, >> >> I am just seeing this (or noticed for the first time, here on >> Ubuntu/precise AMD64)... >> >> $ zgrep -A1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix DSI HW state readout (rev2)

2016-03-24 Thread Patchwork
== Series Details == Series: drm/i915/bxt: Fix DSI HW state readout (rev2) URL : https://patchwork.freedesktop.org/series/4832/ State : failure == Summary == Series 4832v2 drm/i915/bxt: Fix DSI HW state readout http://patchwork.freedesktop.org/api/1.0/series/4832/revisions/2/mbox/ Test gem_ex

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DCS commands in the enum list

2016-03-24 Thread Jani Nikula
On Thu, 24 Mar 2016, Deepak M wrote: > Adding new DCS commands which are specified in the > DCS 1.3 spec related to CABC. > > Cc: Thierry Reding > Cc: David Airlie > Cc: Ville Syrjälä > Cc: Daniel Vetter > Suggested-by: Jani Nikula > Signed-off-by: Deepak M Deepak, for future reference, ple

[Intel-gfx] [PATCH v3] drm/i915/bxt: Fix DSI HW state readout

2016-03-24 Thread Imre Deak
Currently the machine hangs during booting while accessing the BXT_MIPI_PORT_CTRL register during pipe HW state readout. After some experimentation I found that the hang is caused by the DSI PLL being disabled, or it being enabled but with an incorrect divider configuration. Enabling the PLL got ri

[Intel-gfx] [intelddx][strlcpy | strlcat | clock_gettime] clang-3.8: error: linker command failed with exit code 1

2016-03-24 Thread Sedat Dilek
[ Please see attached files (build-script, full logs etc.) ] With my selfmade llvm-toolchain v3.8.0 I see these errors/warnings... $ egrep -B2 -i 'linker command failed|undefined reference to' config.log "/usr/bin/ld" -z relro --hash-style=gnu --build-id --eh-frame-hdr -m elf_x86_64 -dynamic-lin

Re: [Intel-gfx] [PATCH v3] drm/i915/bxt: Fix DSI HW state readout

2016-03-24 Thread Jani Nikula
On Thu, 24 Mar 2016, Imre Deak wrote: > Currently the machine hangs during booting while accessing the > BXT_MIPI_PORT_CTRL register during pipe HW state readout. After some > experimentation I found that the hang is caused by the DSI PLL being > disabled, or it being enabled but with an incorrect

[Intel-gfx] [intelddx] TearFree still status "Experimental support"?

2016-03-24 Thread Sedat Dilek
Hi Chris, is TearFree feature still "experimental" in current xf86-video-intel.git#master? It is enabled by default! [ configure-log ] ... xf86-video-intel 2.99.917 will be compiled with: Xorg Video ABI version: 15.0 (xorg-server-1.15.1) pixman version: pixman-1-0.30.2 Acceleration backends

Re: [Intel-gfx] [RFC v2] drm/i915: Move execlists irq handler to a bottom half

2016-03-24 Thread Chris Wilson
On Wed, Mar 23, 2016 at 02:57:36PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Doing a lot of work in the interrupt handler introduces huge > latencies to the system as a whole. > > Most dramatic effect can be seen by running an all engine > stress test like igt/gem_exec_nop/all wher

Re: [Intel-gfx] [intelddx][strlcpy | strlcat | clock_gettime] clang-3.8: error: linker command failed with exit code 1

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 11:44:45AM +0100, Sedat Dilek wrote: > [ Please see attached files (build-script, full logs etc.) ] > > With my selfmade llvm-toolchain v3.8.0 I see these errors/warnings... > conftest.c:(.text+0x12): undefined reference to `strlcpy' > clang-3.8: error: linker command fail

Re: [Intel-gfx] [intelddx][strlcpy | strlcat | clock_gettime] clang-3.8: error: linker command failed with exit code 1

2016-03-24 Thread Sedat Dilek
On Thu, Mar 24, 2016 at 12:01 PM, Chris Wilson wrote: > On Thu, Mar 24, 2016 at 11:44:45AM +0100, Sedat Dilek wrote: >> [ Please see attached files (build-script, full logs etc.) ] >> >> With my selfmade llvm-toolchain v3.8.0 I see these errors/warnings... > >> conftest.c:(.text+0x12): undefined r

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Cache some registers in execlists hot paths

2016-03-24 Thread Chris Wilson
On Wed, Mar 23, 2016 at 03:15:02PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > GCC cannot optimize well calculations hidden in macros and > assigned to temporary structures. We can cache the register in > ELSP write, and refactor reading of the CSB a bit to enable > it to do a better

Re: [Intel-gfx] [intelddx] TearFree still status "Experimental support"?

2016-03-24 Thread Sedat Dilek
On Thu, Mar 24, 2016 at 11:56 AM, Sedat Dilek wrote: > Hi Chris, > > is TearFree feature still "experimental" in current > xf86-video-intel.git#master? > It is enabled by default! > > [ configure-log ] > ... > xf86-video-intel 2.99.917 will be compiled with: > Xorg Video ABI version: 15.0 (xorg

[Intel-gfx] [PATCH 2/2 v2] drm/i915: replace for_each_engine()

2016-03-24 Thread Dave Gordon
Having provided for_each_engine_id() for cases where the third (id) argument is useful, we can now replace all the remaining instances with a simpler version that takes only two parameters. In many cases, this also allows the elimination of the local variable used in the iterator (usually 'i'). v2

[Intel-gfx] [PATCH v2 0/5] Add aspect ratio parsing

2016-03-24 Thread Shashank Sharma
Currently DRM framework doesn't parse aspect ratio of a videomode while converting it from a umode->kmode or viceversa. This causes modeset of CEA modes with incorrect aspect ratio. While running HDMI complaince, tests (like 7-27) expect the DUT to apply the mode as per the VIC, but as driver does

[Intel-gfx] [PATCH v2 4/5] drm: Add flags for new aspect ratios

2016-03-24 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds DRM flags for the new aspect ratios in the existing aspect ratio flags. Signed-off-by: Shashank Sharma --- include/uapi/drm/drm_mode.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/dr

[Intel-gfx] [PATCH v2 1/5] drm: add picture aspect ratio flags

2016-03-24 Thread Shashank Sharma
This patch adds drm flag bits for aspect ratio information Currently drm flag bits don't have field for mode's picture aspect ratio. This field will help the driver to pick mode with right aspect ratio, and help in setting right VIC field in avi infoframes. Signed-off-by: Shashank Sharma --- in

[Intel-gfx] [PATCH v2 5/5] drm/i915: Add support for new aspect ratios

2016-03-24 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds support for these aspect ratios in I915 driver, at various places. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_modes.c | 12 drivers/gpu/drm/i915/intel_hdmi.c | 6 ++ driver

[Intel-gfx] [PATCH v2 3/5] video: Add new aspect ratios for HDMI 2.0

2016-03-24 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds enumeration for the new aspect ratios in the existing aspect ratio list. Signed-off-by: Shashank Sharma --- drivers/video/hdmi.c | 4 include/linux/hdmi.h | 2 ++ 2 files changed, 6 insertions(+) diff -

[Intel-gfx] [PATCH v2 2/5] drm: Add aspect ratio parsing in DRM layer

2016-03-24 Thread Shashank Sharma
Current DRM layer functions dont parse aspect ratio information while converting a user mode->kernel mode or viceversa. This causes modeset to pick mode with wrong aspect ratio, eventually cauing failures in HDMI compliance test cases, due to wrong VIC. This patch adds aspect ratio information in

Re: [Intel-gfx] [PATCH v3] drm/i915/bxt: Fix DSI HW state readout

2016-03-24 Thread Sharma, Shashank
reviewed-by: Shashank Sharma Regards Shashank -Original Message- From: Deak, Imre Sent: Thursday, March 24, 2016 4:12 PM To: intel-gfx@lists.freedesktop.org Cc: Ville Syrjälä; Sharma, Shashank; Shankar, Uma; Nikula, Jani Subject: [PATCH v3] drm/i915/bxt: Fix DSI HW state readout Current

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm: Add new DCS commands in the enum list

2016-03-24 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm: Add new DCS commands in the enum list URL : https://patchwork.freedesktop.org/series/4849/ State : success == Summary == Series 4849v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/4849/revisions/1/mbox/

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Cache some registers in execlists hot paths

2016-03-24 Thread Tvrtko Ursulin
On 24/03/16 11:16, Chris Wilson wrote: On Wed, Mar 23, 2016 at 03:15:02PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin GCC cannot optimize well calculations hidden in macros and assigned to temporary structures. We can cache the register in ELSP write, and refactor reading of the CSB a b

[Intel-gfx] commit 1b82b7b48d17b4b3401e9d82b0fe86df06c8d451 breaks here

2016-03-24 Thread Sedat Dilek
Caused by "sna/present: Cancel pending unflips when resizing the screen". ... make[3]: Entering directory `/home/wearefam/src/xserver-xorg-video-intel/xf86-video-intel-git/src' CC backlight.lo CC fd.lo CC intel_device.lo CC intel_options.lo CC intel_module.lo CCLD

Re: [Intel-gfx] [PATCH] drm/i915: Replace some more busy waits with normal ones

2016-03-24 Thread Tvrtko Ursulin
On 23/03/16 16:40, Chris Wilson wrote: On Wed, Mar 23, 2016 at 04:24:48PM +, Tvrtko Ursulin wrote: Biggest thing to make sure is that you don't add a lot of cycles to the forcewake loops since for example fw_domains_get can be the hottest i915 function on some benchmarks. (This area slight

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix potential dangling else problems in for_each_ macros (rev3)

2016-03-24 Thread Dave Gordon
On 24/03/16 09:06, Patchwork wrote: == Series Details == Series: drm/i915: fix potential dangling else problems in for_each_ macros (rev3) URL : https://patchwork.freedesktop.org/series/1142/ State : failure == Summary == Series 1142v3 drm/i915: fix potential dangling else problems in for_e

Re: [Intel-gfx] commit 1b82b7b48d17b4b3401e9d82b0fe86df06c8d451 breaks here

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 12:33:24PM +0100, Sedat Dilek wrote: > Caused by "sna/present: Cancel pending unflips when resizing the screen". Sorry, commit c326ed192bcaeea41bb93b7077ec37a1437a4409 Author: Chris Wilson Date: Thu Mar 24 11:38:35 2016 + sna/present: Add missing "static inline

Re: [Intel-gfx] [RFC v2] drm/i915: Move execlists irq handler to a bottom half

2016-03-24 Thread Tvrtko Ursulin
On 24/03/16 10:56, Chris Wilson wrote: On Wed, Mar 23, 2016 at 02:57:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Doing a lot of work in the interrupt handler introduces huge latencies to the system as a whole. Most dramatic effect can be seen by running an all engine stress test l

Re: [Intel-gfx] commit 1b82b7b48d17b4b3401e9d82b0fe86df06c8d451 breaks here

2016-03-24 Thread Sedat Dilek
On Thu, Mar 24, 2016 at 12:40 PM, Chris Wilson wrote: > On Thu, Mar 24, 2016 at 12:33:24PM +0100, Sedat Dilek wrote: >> Caused by "sna/present: Cancel pending unflips when resizing the screen". > > Sorry, > > commit c326ed192bcaeea41bb93b7077ec37a1437a4409 > Author: Chris Wilson > Date: Thu Mar

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Cache some registers in execlists hot paths

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 11:31:34AM +, Tvrtko Ursulin wrote: > > On 24/03/16 11:16, Chris Wilson wrote: > >On Wed, Mar 23, 2016 at 03:15:02PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>GCC cannot optimize well calculations hidden in macros and > >>assigned to temporary stru

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bxt: Fix DSI HW state readout (rev3)

2016-03-24 Thread Patchwork
== Series Details == Series: drm/i915/bxt: Fix DSI HW state readout (rev3) URL : https://patchwork.freedesktop.org/series/4832/ State : success == Summary == Series 4832v3 drm/i915/bxt: Fix DSI HW state readout http://patchwork.freedesktop.org/api/1.0/series/4832/revisions/3/mbox/ Test gem_ex

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915/dsi: refer to gpio index instead of gpio to avoid confusion

2016-03-24 Thread Mika Kahola
Housekeeping stuff. Reviewed-by: Mika Kahola On Fri, 2016-03-18 at 13:11 +0200, Jani Nikula wrote: > The DSI sequence blocks contain gpio index references, not actual gpio > numbers. No functional changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 16

Re: [Intel-gfx] [PATCH 112/190] drm/i915: Move obj->active:5 to obj->flags

2016-03-24 Thread David Weinehall
On Mon, Jan 11, 2016 at 10:44:56AM +, Chris Wilson wrote: > We are motivated to avoid using a bitfield for obj->active for a couple > of reasons. Firstly, we wish to document our lockless read of obj->active > using READ_ONCE inside i915_gem_busy_ioctl() and that requires an > integral type (i.

[Intel-gfx] [PATCH 1/2] drm/i915: Update VBT fields for child devices

2016-03-24 Thread Shubhangi Shrivastava
This patch adds new fields that are not yet added in drm code in child devices struct Signed-off-by: Sivakumar Thulasimani Signed-off-by: Durgadoss R Signed-off-by: Shubhangi Shrivastava Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_bios.c | 15 ++- drivers/gpu/drm

[Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-03-24 Thread Shubhangi Shrivastava
This patch sets the invert bit for hpd detection for each port based on VBT configuration. Since each AOB can be designed to depend on invert bit or not, it is expected if an AOB requires invert bit, the user will set respective bit in VBT. v2: Separated VBT parsing from the rest of the logic. (Ja

Re: [Intel-gfx] [PATCH 1/2] shmem: Support for registration of Driver/file owner specific ops

2016-03-24 Thread Joonas Lahtinen
On ke, 2016-03-23 at 11:39 +0530, akash.g...@intel.com wrote: > From: Chris Wilson > > This provides support for the Drivers or shmem file owners to register > a set of callbacks, which can be invoked from the address space operations > methods implemented by shmem. > This allow the file owners t

[Intel-gfx] [PATCH v3] drm/i915: Move execlists irq handler to a bottom half

2016-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Doing a lot of work in the interrupt handler introduces huge latencies to the system as a whole. Most dramatic effect can be seen by running an all engine stress test like igt/gem_exec_nop/all where, when the kernel config is lean enough, the whole system can be brought into

Re: [Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-03-24 Thread Shrivastava, Shubhangi
Hi Daniel, Is something else required for this patch series (5 patches) to be merged? Thanks and Regards, Shubhangi Shrivastava. -Original Message- From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] Sent: Wednesday, January 20, 2016 8:07 PM To: Shrivastava, Shubhangi ; int

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix potential dangling else problems in for_each_ macros (rev4)

2016-03-24 Thread Patchwork
== Series Details == Series: drm/i915: fix potential dangling else problems in for_each_ macros (rev4) URL : https://patchwork.freedesktop.org/series/1142/ State : success == Summary == Series 1142v4 drm/i915: fix potential dangling else problems in for_each_ macros http://patchwork.freedeskt

Re: [Intel-gfx] [PATCH] drm/i915: Replace some more busy waits with normal ones

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 11:37:07AM +, Tvrtko Ursulin wrote: > > On 23/03/16 16:40, Chris Wilson wrote: > >On Wed, Mar 23, 2016 at 04:24:48PM +, Tvrtko Ursulin wrote: > >>Biggest thing to make sure is that you don't add a lot of cycles to > >>the forcewake loops since for example fw_domains

Re: [Intel-gfx] [intelddx] v2.99.917-580-gf656f6afa288: sh: 1: ACLOCAL_FLAGS: not found

2016-03-24 Thread Dave Gordon
On 24/03/16 09:54, Chris Wilson wrote: On Thu, Mar 24, 2016 at 10:34:58AM +0100, Sedat Dilek wrote: [ build-script, build and config logs attached ] Hi Chris, I am just seeing this (or noticed for the first time, here on Ubuntu/precise AMD64)... $ zgrep -A1 -B1 ACLOCAL_FLAGS: build-and-instal

Re: [Intel-gfx] [intelddx] v2.99.917-580-gf656f6afa288: sh: 1: ACLOCAL_FLAGS: not found

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 12:29:32PM +, Dave Gordon wrote: > On 24/03/16 09:54, Chris Wilson wrote: > >On Thu, Mar 24, 2016 at 10:34:58AM +0100, Sedat Dilek wrote: > >>[ build-script, build and config logs attached ] > >> > >>Hi Chris, > >> > >>I am just seeing this (or noticed for the first time

Re: [Intel-gfx] [intelddx][strlcpy | strlcat | clock_gettime] clang-3.8: error: linker command failed with exit code 1

2016-03-24 Thread Dave Gordon
On 24/03/16 11:11, Sedat Dilek wrote: From b35261adb49107e7dd6e480b1f7c5d4fb7552f9f Mon Sep 17 00:00:00 2001 From: Sedat Dilek Date: Thu, 24 Mar 2016 12:01:37 +0100 Subject: [PATCH 1/3] configure: Remove ACLOCAL_FLAGS to fix libtool vs automake problem --- Makefile.am | 2 +- 1 file change

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bxt: Fix DSI HW state readout (rev3)

2016-03-24 Thread Imre Deak
On to, 2016-03-24 at 11:32 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bxt: Fix DSI HW state readout (rev3) > URL   : https://patchwork.freedesktop.org/series/4832/ > State : success > > == Summary == > > Series 4832v3 drm/i915/bxt: Fix DSI HW state readout > http://patch

Re: [Intel-gfx] [PATCH v2 1/5] drm: add picture aspect ratio flags

2016-03-24 Thread Jani Nikula
On Thu, 24 Mar 2016, Shashank Sharma wrote: > This patch adds drm flag bits for aspect ratio information > > Currently drm flag bits don't have field for mode's picture > aspect ratio. This field will help the driver to pick mode with > right aspect ratio, and help in setting right VIC field in av

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add aspect ratio parsing (rev2)

2016-03-24 Thread Patchwork
== Series Details == Series: Add aspect ratio parsing (rev2) URL : https://patchwork.freedesktop.org/series/1915/ State : failure == Summary == Series 1915v2 Add aspect ratio parsing http://patchwork.freedesktop.org/api/1.0/series/1915/revisions/2/mbox/ Test gem_exec_suspend: Subgroup

Re: [Intel-gfx] [PATCH v2 1/5] drm: add picture aspect ratio flags

2016-03-24 Thread Sharma, Shashank
Ok, will do it for other patches too. Regards Shashank -Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Thursday, March 24, 2016 6:26 PM To: Sharma, Shashank; Vivi, Rodrigo Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2 1/5] drm: add

Re: [Intel-gfx] [RFC v2] drm/i915: Move execlists irq handler to a bottom half

2016-03-24 Thread Tvrtko Ursulin
On 24/03/16 11:50, Tvrtko Ursulin wrote: Also, gem_latency -n 100 shows 25% better throughput and CPU usage, and 14% better latencies. Mention the benefits of parallelising dispatch. Hm, actually this should be the same as before I think. Of course not, silly me. Will add this at the next

Re: [Intel-gfx] [PATCH] drm/i915: Replace some more busy waits with normal ones

2016-03-24 Thread Tvrtko Ursulin
On 24/03/16 12:27, Chris Wilson wrote: On Thu, Mar 24, 2016 at 11:37:07AM +, Tvrtko Ursulin wrote: On 23/03/16 16:40, Chris Wilson wrote: On Wed, Mar 23, 2016 at 04:24:48PM +, Tvrtko Ursulin wrote: Biggest thing to make sure is that you don't add a lot of cycles to the forcewake loop

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-24 Thread Joonas Lahtinen
On ma, 2016-03-21 at 17:12 +0200, Imre Deak wrote: > On ma, 2016-03-21 at 10:28 +0100, Daniel Vetter wrote: > > > > On Fri, Mar 18, 2016 at 11:15:35AM +0200, Imre Deak wrote: > > > > > > On Fri, 2016-03-18 at 10:59 +0200, Joonas Lahtinen wrote: > > > > > > > > On pe, 2016-03-18 at 00:18 +0200, I

Re: [Intel-gfx] [intelddx][strlcpy | strlcat | clock_gettime] clang-3.8: error: linker command failed with exit code 1

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 12:47:51PM +, Dave Gordon wrote: > On 24/03/16 11:11, Sedat Dilek wrote: > > From b35261adb49107e7dd6e480b1f7c5d4fb7552f9f Mon Sep 17 00:00:00 2001 > >From: Sedat Dilek > >Date: Thu, 24 Mar 2016 12:01:37 +0100 > >Subject: [PATCH 1/3] configure: Remove ACLOCAL_FLAGS to fi

Re: [Intel-gfx] [PATCH] drm/i915: Replace some more busy waits with normal ones

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 01:06:41PM +, Tvrtko Ursulin wrote: > > On 24/03/16 12:27, Chris Wilson wrote: > >On Thu, Mar 24, 2016 at 11:37:07AM +, Tvrtko Ursulin wrote: > >> > >>On 23/03/16 16:40, Chris Wilson wrote: > >>>On Wed, Mar 23, 2016 at 04:24:48PM +, Tvrtko Ursulin wrote: > B

Re: [Intel-gfx] [PATCH] drm/i915: Replace some more busy waits with normal ones

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 01:16:40PM +, Chris Wilson wrote: > On Thu, Mar 24, 2016 at 01:06:41PM +, Tvrtko Ursulin wrote: > > > > On 24/03/16 12:27, Chris Wilson wrote: > > >On Thu, Mar 24, 2016 at 11:37:07AM +, Tvrtko Ursulin wrote: > > >> > > >>On 23/03/16 16:40, Chris Wilson wrote: >

[Intel-gfx] [PATCH] drm/i915: Only arm the forcewake release timer on the final put

2016-03-24 Thread Chris Wilson
If we arm the release timer on acquiring the forcewake, we will release the forcewake on the jiffie afterwards. If we only arm the release timer on the final put, we will release the forcewake slightly later instead. Much, much worse, we did not acquire a refcount for the armed timing during the g

Re: [Intel-gfx] [PATCH] drm/i915: Only arm the forcewake release timer on the final put

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 01:32:53PM +, Chris Wilson wrote: > If we arm the release timer on acquiring the forcewake, we will release > the forcewake on the jiffie afterwards. If we only arm the release timer > on the final put, we will release the forcewake slightly later instead. > > Much, muc

Re: [Intel-gfx] [PATCH] drm/i915: Only arm the forcewake release timer on the final put

2016-03-24 Thread Tvrtko Ursulin
On 24/03/16 13:42, Chris Wilson wrote: On Thu, Mar 24, 2016 at 01:32:53PM +, Chris Wilson wrote: If we arm the release timer on acquiring the forcewake, we will release the forcewake on the jiffie afterwards. If we only arm the release timer on the final put, we will release the forcewake s

[Intel-gfx] [PATCH v2] drm/i915: Only arm the forcewake release timer on the final put

2016-03-24 Thread Chris Wilson
If we arm the release timer on acquiring the forcewake, we will release the forcewake on the jiffie afterwards. If we only arm the release timer on the final put, we will release the forcewake slightly later instead. Much, much worse, we did not acquire a refcount for the armed timing during the g

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Update VBT fields for child devices

2016-03-24 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Update VBT fields for child devices URL : https://patchwork.freedesktop.org/series/4858/ State : success == Summary == Series 4858v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/4858/revisions/1/mb

[Intel-gfx] [PATCH] drm/i915: Use atomic state in debugfs.

2016-03-24 Thread Maarten Lankhorst
Use proper locking, connector_state and encoder masks. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_debugfs.c | 72 ++--- 1 file changed, 34 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH] drm/i915: Only arm the forcewake release timer on the final put

2016-03-24 Thread Chris Wilson
On Thu, Mar 24, 2016 at 02:19:38PM +, Chris Wilson wrote: > On Thu, Mar 24, 2016 at 01:54:36PM +, Tvrtko Ursulin wrote: > > > > On 24/03/16 13:42, Chris Wilson wrote: > > >On Thu, Mar 24, 2016 at 01:32:53PM +, Chris Wilson wrote: > > >>If we arm the release timer on acquiring the force

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Allow mmio updates on all platforms.

2016-03-24 Thread Ville Syrjälä
On Thu, Mar 24, 2016 at 09:35:04AM +0100, Maarten Lankhorst wrote: > Op 23-03-16 om 16:07 schreef Ville Syrjälä: > > On Wed, Mar 23, 2016 at 02:24:30PM +0100, Maarten Lankhorst wrote: > >> Rename intel_unpin_work to intel_flip_work and use it for mmio flips > >> and unpinning. Use flip_queued_req t

Re: [Intel-gfx] [PATCH] drm/i915: Only arm the forcewake release timer on the final put

2016-03-24 Thread Dave Gordon
On 24/03/16 13:42, Chris Wilson wrote: On Thu, Mar 24, 2016 at 01:32:53PM +, Chris Wilson wrote: If we arm the release timer on acquiring the forcewake, we will release the forcewake on the jiffie afterwards. If we only arm the release timer on the final put, we will release the forcewake sl

[Intel-gfx] [PATCH] drm/i915: Rename __force_wake_get to __force_wake_auto

2016-03-24 Thread Chris Wilson
__force_wake_get() only acquire a temporary wakeref on forcewake that is automatically releases when a timer expires. When reading the code again, I confused __intel_uncore_forcewake_get for __force_wake_get and to my shame thought I found a bug in an unbalanced wake_count handling. I claim that i

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Refer to GGTT VM consistently

2016-03-24 Thread Joonas Lahtinen
On ke, 2016-03-23 at 13:25 +, Chris Wilson wrote: > On Wed, Mar 23, 2016 at 03:00:23PM +0200, Joonas Lahtinen wrote: > > > > Refer to the GGTT VM consistently as "ggtt_vm" instead of just "ggtt", > > "vm" or indirectly through other variables like "dev_priv->ggtt.base" > > to avoid confusion w

Re: [Intel-gfx] [PATCH] drm/i915: check vma for error in ggtt_unpin_view

2016-03-24 Thread Joonas Lahtinen
On ke, 2016-03-23 at 15:39 +, Matthew Auld wrote: > When unpinning a ggtt_view check vma for error, otherwise we may end up > accessing an invalid pointer. > > Cc: Joonas Lahtinen > Signed-off-by: Matthew Auld > --- >  drivers/gpu/drm/i915/i915_gem.c | 2 +- >  1 file changed, 1 insertion(+),

[Intel-gfx] [PATCH] kernfs: Move faulting copy_user operations outside of the mutex

2016-03-24 Thread Chris Wilson
A fault in a user provided buffer may lead anywhere, and lockdep warns that we have a potential deadlock between the mm->mmap_sem and the kernfs file mutex: [ 82.811702] == [ 82.811705] [ INFO: possible circular locking dependency detected ]

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rename GGTT init functions

2016-03-24 Thread Joonas Lahtinen
On ke, 2016-03-23 at 17:54 +0200, Mika Kuoppala wrote: > Ville Syrjälä writes: > > > > > [ text/plain ] > > On Wed, Mar 23, 2016 at 03:00:22PM +0200, Joonas Lahtinen wrote: > > > > > > Rename and document the GGTT init functions to give a better > > > idea of the context where they are called f

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Move execlists irq handler to a bottom half (rev3)

2016-03-24 Thread Patchwork
== Series Details == Series: drm/i915: Move execlists irq handler to a bottom half (rev3) URL : https://patchwork.freedesktop.org/series/4764/ State : warning == Summary == Series 4764v3 drm/i915: Move execlists irq handler to a bottom half http://patchwork.freedesktop.org/api/1.0/series/4764/

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Allow mmio updates on all platforms.

2016-03-24 Thread Maarten Lankhorst
Op 24-03-16 om 15:26 schreef Ville Syrjälä: > On Thu, Mar 24, 2016 at 09:35:04AM +0100, Maarten Lankhorst wrote: >> Op 23-03-16 om 16:07 schreef Ville Syrjälä: >>> On Wed, Mar 23, 2016 at 02:24:30PM +0100, Maarten Lankhorst wrote: Rename intel_unpin_work to intel_flip_work and use it for mmio

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Set invert bit for hpd based on VBT

2016-03-24 Thread Ville Syrjälä
On Thu, Mar 24, 2016 at 05:40:51PM +0530, Shubhangi Shrivastava wrote: > This patch sets the invert bit for hpd detection for each port > based on VBT configuration. Since each AOB can be designed to > depend on invert bit or not, it is expected if an AOB requires > invert bit, the user will set re

Re: [Intel-gfx] [PATCH] drm/i915: Only arm the forcewake release timer on the final put

2016-03-24 Thread Dave Gordon
On 24/03/16 13:32, Chris Wilson wrote: If we arm the release timer on acquiring the forcewake, we will release the forcewake on the jiffie afterwards. If we only arm the release timer on the final put, we will release the forcewake slightly later instead. Yes, I had wondered why we armed to tim

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Parsing the PWM cntrl and CABC ON/OFF fileds in VBT

2016-03-24 Thread Jani Nikula
On Thu, 24 Mar 2016, Deepak M wrote: > For dual link panel scenarios there are new fileds added in the > VBT which indicate on which port the PWM cntrl and CABC ON/OFF > commands needs to be sent. > > v2: Moving the comment to intel_dsi.h(Jani) > > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Yetun

  1   2   >