Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 05:46:11PM +0200, Imre Deak wrote: > Atm, in case failure injection forces an error the subsequent > "*ERROR* failed to init modeset" error message will make automated > tests (CI) report this event as a breakage even though the event is > expected. To fix this print the err

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/csr: Allow matching unknown HW steppings with generic firmware

2016-03-19 Thread Imre Deak
On Wed, 2016-03-16 at 17:45 +0200, Imre Deak wrote: > On Mon, 2016-03-07 at 16:24 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/csr: Allow matching unknown HW steppings with > > generic firmware > > URL   : https://patchwork.freedesktop.org/series/4173/ > > State : fail

[Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
Atm, in case failure injection forces an error the subsequent "*ERROR* failed to init modeset" error message will make automated tests (CI) report this event as a breakage even though the event is expected. To fix this print the error message with debug log level in this case. While at it print th

Re: [Intel-gfx] [PATCH 2/8] drm/i915/dsi: add support for DSI sequence block v2 gpio element

2016-03-19 Thread Ville Syrjälä
On Thu, Mar 17, 2016 at 05:04:40PM +0200, Jani Nikula wrote: > In sequence block v2, and only in v2, the gpio source (i.e. IOSF port) > is specified separately. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 21 + > 1 file changed, 17 inse

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen9: add WaClearFlowControlGpgpuContextSave (rev3)

2016-03-19 Thread Gore, Tim
Tim Gore  Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ > -Original Message- > From: Patchwork [mailto:patchw...@emeril.freedesktop.org] > Sent: Thursday, March 17, 2016 9:36 AM > To: Gore, Tim > Cc: intel-gfx@lists.freedesktop.org > Subject: ✗ Fi.CI.BAT: f

[Intel-gfx] [PATCH] prime_mmap_coherency: Add return error tests for prime sync ioctl

2016-03-19 Thread Tiago Vignatti
This patch adds ioctl-errors subtest to be used for exercising prime sync ioctl errors. The subtest constantly interrupts via signals a function doing concurrent blit to stress out the right usage of prime_sync_*, making sure these ioctl errors are handled accordingly. Important to note that in ca

Re: [Intel-gfx] [PATCH RESEND 1/7] drm/i915: move VBT based TV presence check to intel_bios.c

2016-03-19 Thread Daniel Vetter
On Wed, Mar 16, 2016 at 12:43:29PM +0200, Jani Nikula wrote: > Hide knowledge about VBT child devices in intel_bios.c. > > v2: also move int_tv_support check to intel_bios.c (Sivakumar) > > Signed-off-by: Jani Nikula Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_drv.h | 1 +

[Intel-gfx] [PATCH i-g-t 1/2] lib: Fix some doc warnings

2016-03-19 Thread Daniel Vetter
Cc: Marius Vlad Signed-off-by: Daniel Vetter --- lib/igt_core.c | 2 ++ lib/igt_kms.c | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 947a9ca37690..1f9be7d0688e 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1435,6 +1435,8 @@

[Intel-gfx] [PATCH i-g-t 2/2] lib/tests: More igt_subtest_group checks

2016-03-19 Thread Daniel Vetter
... for some cases discussed with Chris on irc. We seem to get them all right. Signed-off-by: Daniel Vetter --- lib/tests/igt_subtest_group.c | 20 1 file changed, 20 insertions(+) diff --git a/lib/tests/igt_subtest_group.c b/lib/tests/igt_subtest_group.c index 2b17955c5ac8

[Intel-gfx] [PATCH v3 11/19] drm/i915: Move unload time display power domain uninit later

2016-03-19 Thread Imre Deak
Move the power domain uninitialization later so that it matches its corresponding init order. Since we access the HW during the later unitialization steps keep a wake reference until after the last such step. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_dma.c | 7 ++- 1 file change

[Intel-gfx] [PATCH v2 6/9] drm/i915/dsi: add support for sequence block v3 gpio for VLV

2016-03-19 Thread Jani Nikula
Just put the iosf port in the gpio table. The table might include some duplication, but this approach keeps the code the cleanest. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

Re: [Intel-gfx] [PATCH RESEND 5/7] drm/i915/panel: setup pwm backlight based on connector type

2016-03-19 Thread Daniel Vetter
On Wed, Mar 16, 2016 at 12:43:33PM +0200, Jani Nikula wrote: > Use the connector type instead of VBT directly to decide which backlight > mechanism to use on VLV/CHV. (Indirectly, this is the same thing, but > hides the VBT use.) > > Signed-off-by: Jani Nikula Reviewed-by: Daniel Vetter > ---

[Intel-gfx] [PATCH v2] mm/vmap: Add a notifier for when we run out of vmap address space

2016-03-19 Thread Chris Wilson
vmaps are temporary kernel mappings that may be of long duration. Reusing a vmap on an object is preferrable for a driver as the cost of setting up the vmap can otherwise dominate the operation on the object. However, the vmap address space is rather limited on 32bit systems and so we add a notific

Re: [Intel-gfx] [PATCH] drm/i915: Restrict usage of live status check

2016-03-19 Thread Sharma, Shashank
Regards Shashank On 3/17/2016 2:55 PM, Jani Nikula wrote: On Thu, 17 Mar 2016, Shashank Sharma wrote: [ text/plain ] This patch restricts usage of live status check for HDMI detection. While testing certain (monitor + cable) combinations with various intel platforms, it seems that live status

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
On Thu, 2016-03-17 at 20:44 +, Chris Wilson wrote: > On Thu, Mar 17, 2016 at 09:50:19PM +0200, Imre Deak wrote: > > On Thu, 2016-03-17 at 19:41 +, Chris Wilson wrote: > > > On Thu, Mar 17, 2016 at 06:08:05PM +0200, Imre Deak wrote: > > > > On Thu, 2016-03-17 at 15:55 +, Chris Wilson wro

Re: [Intel-gfx] [PATCH RESEND 7/7] drm/i915: hide away VBT private data in a separate header

2016-03-19 Thread Jani Nikula
On Wed, 16 Mar 2016, Daniel Vetter wrote: > [ text/plain ] > On Wed, Mar 16, 2016 at 12:43:35PM +0200, Jani Nikula wrote: >> We've been accumulating code across the driver that depends on the VBT >> specific structures and defines. The VBT is an uncontrollable >> beast. Encourage encapsulation of

Re: [Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 01:41:32PM +, Matthew Auld wrote: > Hi, > > If we don't do any of the fence business for !i915_is_gtt, then will > this not change the following code: > > if (alignment == 0) > alignment = flags & PIN_MAPPABLE ? fence_alignment : unfenced_alignment; > > Or am I mi

Re: [Intel-gfx] [PATCH 1/3] pinctrl: Intel: add RX invertion config

2016-03-19 Thread Daniel Vetter
On Wed, Mar 16, 2016 at 01:27:49PM +0100, Linus Walleij wrote: > > On Tue, Mar 15, 2016 at 3:17 AM, Zheng, Qi wrote: > >> On Mon, Mar 14, 2016 at 9:56 AM, Zheng, Qi wrote: > > > >> The "pi330532" device on Broxton requires this function to manually > >> trigger an GPIO input interrupt. > > (...)

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Joonas Lahtinen
On pe, 2016-03-18 at 00:18 +0200, Imre Deak wrote: > On Thu, 2016-03-17 at 22:14 +, Chris Wilson wrote: > > > > On Fri, Mar 18, 2016 at 12:09:30AM +0200, Imre Deak wrote: > > > > > > On Thu, 2016-03-17 at 21:48 +, Chris Wilson wrote: > > > > > > > > I would also like this to be the prefe

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Modify reset func to handle per engine resets

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: Modify reset func to handle per engine resets URL : https://patchwork.freedesktop.org/series/4510/ State : failure == Summary == Series 4510v1 drm/i915: Modify reset func to handle per engine resets http://patchwork.freedesktop.org/api/1.0/series/4510/rev

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2)

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2) URL : https://patchwork.freedesktop.org/series/4491/ State : failure == Summary == Series 4491v2 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit http://patchwork.freedesktop.org/api/1.0/series/4

Re: [Intel-gfx] [RFC PATCH 07/10] drm/i915: abstract get config for cpu transcoder

2016-03-19 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 09:51:15PM +0200, Jani Nikula wrote: > Makes it neater to add the same for DSI transcoder. No functional > changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_display.c | 83 > > 1 file changed, 47 insertions(+)

Re: [Intel-gfx] [PATCH] drm/i915: Fix race condition in intel_dp_destroy_mst_connector()

2016-03-19 Thread Daniel Vetter
On Wed, Mar 16, 2016 at 09:39:49PM +0200, Ville Syrjälä wrote: > On Wed, Mar 16, 2016 at 03:18:04PM -0400, Lyude wrote: > > After unplugging a DP MST display from the system, we have to go through > > and destroy all of the DRM connectors associated with it since none of > > them are valid anymore.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Smarten up and use to_i915() everywhere

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: Smarten up and use to_i915() everywhere URL : https://patchwork.freedesktop.org/series/4592/ State : failure == Summary == Series 4592v1 drm/i915: Smarten up and use to_i915() everywhere http://patchwork.freedesktop.org/api/1.0/series/4592/revisions/1/mbo

Re: [Intel-gfx] [PATCH v2] prime_mmap_coherency: Add return error tests for prime sync ioctl

2016-03-19 Thread Chris Wilson
On Fri, Mar 18, 2016 at 09:44:40AM +, Chris Wilson wrote: > On Thu, Mar 17, 2016 at 06:18:06PM -0300, Tiago Vignatti wrote: > > +static void test_ioctl_errors(void) > > +{ > > + int i; > > + int num_children = 8*sysconf(_SC_NPROCESSORS_ONLN); > > + > > + igt_fork_signal_helper(); > > +

[Intel-gfx] [PATCH v3 03/19] drm/i915: Move load time IRQ SW init earlier

2016-03-19 Thread Imre Deak
Most of the IRQ init is setting up hooks so move that part earlier. Leave the pm_qos_add_request() call in place. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_dma.c | 5 - drivers/gpu/drm/i915/i915_irq.c | 2 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [Intel-gfx] [RFC PATCH 06/10] drm/i915: split set pipeconf to pipe and transcoder parts

2016-03-19 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 09:51:14PM +0200, Jani Nikula wrote: > Prep work for DSI transcoders. No functional changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_display.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Chris Wilson
On Fri, Mar 18, 2016 at 12:09:30AM +0200, Imre Deak wrote: > On Thu, 2016-03-17 at 21:48 +, Chris Wilson wrote: > > I would also like this to be the preferred > > DRM_ERROR reporting mechanism i.e. anytime we emit an ERROR we should > > be > > encouraging the user to file a bug, and do so in a

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Rename local struct intel_ringbuffer variables

2016-03-19 Thread Chris Wilson
On Wed, Mar 16, 2016 at 04:06:14PM +, Tvrtko Ursulin wrote: > > On 16/03/16 16:00, Chris Wilson wrote: > >On Wed, Mar 16, 2016 at 03:40:54PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Majority of the code calls these ringbuf so fix up a few > >>places which use something e

[Intel-gfx] [PATCH v2 1/6] drm/i915: split get/set pipe timings to timings and src size

2016-03-19 Thread Jani Nikula
Prep work for DSI transcoders. No functional changes. v2: call split functions at a higher level (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/driv

[Intel-gfx] [PATCH 0/3] Gen8 Engine reset preparatory patches

2016-03-19 Thread Arun Siluvery
First batch of prep patches for Engine reset feature available from Gen8 onwards. The reset code is recently prep'd to support this feature, now others can follow now. Arun Siluvery (2): drm/i915/tdr: Prepare error handler to accept mask of hung engines drm/i915: Update i915.reset to handle en

Re: [Intel-gfx] [PATCH 3/8] drm/i915/dsi: do not define VLV gpio pad registers separately

2016-03-19 Thread Ville Syrjälä
On Thu, Mar 17, 2016 at 05:04:41PM +0200, Jani Nikula wrote: > They seem to be all just function register offset + 8. No functional > changes, apart from saving some space. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 41 > +++--- >

Re: [Intel-gfx] [RFC PATCH 08/10] drm/i915/bxt: add dsi transcoders

2016-03-19 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 09:51:16PM +0200, Jani Nikula wrote: > The BXT display connections have DSI transcoders A and C that can be > muxed to any pipe, not unlike the eDP transcoder. Add the notion of DSI > transcoders. > > The "normal" transcoders A, B and C are not used with BXT DSI, so care >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move CSB MMIO reads out of the execlists lock (rev4)

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: Move CSB MMIO reads out of the execlists lock (rev4) URL : https://patchwork.freedesktop.org/series/3973/ State : failure == Summary == Series 3973v4 drm/i915: Move CSB MMIO reads out of the execlists lock http://patchwork.freedesktop.org/api/1.0/series/3

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Rename local struct intel_ringbuffer variables

2016-03-19 Thread Chris Wilson
On Wed, Mar 16, 2016 at 03:40:54PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Majority of the code calls these ringbuf so fix up a few > places which use something else to be consistent. I absolutely detest ringbuf as a name. The point of calling the engine the engine was that we co

Re: [Intel-gfx] [PATCH 1/3] drm/i915/tdr: Initialize hangcheck struct for each engine

2016-03-19 Thread Arun Siluvery
On 18/03/2016 20:48, Chris Wilson wrote: On Fri, Mar 18, 2016 at 08:07:54PM +, Arun Siluvery wrote: From: Tomas Elf Initialize hangcheck struct during driver load. Since we do the same after recovering from a reset, this is extracted into a helper function. Cc: Mika Kuoppala Signed-off-b

[Intel-gfx] [PATCH v3 17/19] drm/i915: Split out load time interface registration

2016-03-19 Thread Imre Deak
According to the new init phases scheme we should register the device making it available via some kernel internal or user space interface as the last step in the init sequence, so move the corresponding code to a separate function. Also add a TODO comment about code that still needs to be moved a

Re: [Intel-gfx] [PATCH i-g-t v3 5/6] tests/gem_scheduler: Add subtests to test batch priority behaviour

2016-03-19 Thread Daniele Ceraolo Spurio
On 10/03/16 11:03, Derek Morton wrote: Add subtests to test each ring to check batch buffers of a higher priority will be executed before batch buffers of a lower priority. v2: Addressed review comments from Daniele Ceraolo Spurio Signed-off-by: Derek Morton --- tests/gem_scheduler.c | 53

Re: [Intel-gfx] [RFC PATCH 04/10] drm/i915/bxt: fix dsi hw state pipe readout

2016-03-19 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 09:51:12PM +0200, Jani Nikula wrote: > BXT isn't as limited as BYT and CHT regarding DSI pipes and ports. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 1 + > drivers/gpu/drm/i915/intel_dsi.c | 14 +- > 2 files changed, 14 insertio

Re: [Intel-gfx] [PATCH v6] igt/gem_trtt: Exercise the TRTT hardware

2016-03-19 Thread Chris Wilson
On Fri, Mar 18, 2016 at 02:07:40PM +0530, akash.g...@intel.com wrote: > +/* emit_store_qword > + * populate batch buffer with MI_STORE_DWORD_IMM command > + * @fd: drm file descriptor > + * @cmd_buf: batch buffer > + * @dw_offset: write offset in batch buffer > + * @vaddr: destination Virtual addre

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix sparse warning for using false as NULL

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: fix sparse warning for using false as NULL URL : https://patchwork.freedesktop.org/series/4528/ State : failure == Summary == Series 4528v1 drm/i915: fix sparse warning for using false as NULL http://patchwork.freedesktop.org/api/1.0/series/4528/revisions

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Adding missing IS_KABYLAKE checks.

2016-03-19 Thread Michel Thierry
On 2/29/2016 2:35 PM, Jani Nikula wrote: On Fri, 26 Feb 2016, Rodrigo Vivi wrote: Hi Jani and Daniel, I believe I forgot to cc:stable on this one and this is missing on most branches out there including Linus 4.5-r5. Is there any chance to get this patch in for 4.5? without this i915 is not wo

Re: [Intel-gfx] [RFC 04/15] drm/i915: Add headers for non-HDAudio HDMI interface

2016-03-19 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 03:30:55PM +0200, Ville Syrjälä wrote: > On Tue, Mar 15, 2016 at 09:35:26AM +0100, Daniel Vetter wrote: > > On Mon, Mar 14, 2016 at 04:20:19PM +0200, Ville Syrjälä wrote: > > > On Mon, Mar 14, 2016 at 10:04:00AM +0100, Daniel Vetter wrote: > > > > On Fri, Mar 11, 2016 at 09:

Re: [Intel-gfx] [PATCH resend for CI 2/2] drm/i915: Use shorter route to dev_private where possible

2016-03-19 Thread Tvrtko Ursulin
On 17/03/16 13:17, Chris Wilson wrote: On Thu, Mar 17, 2016 at 01:04:10PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Where we have a request we can use req->i915 directly instead of going through the engine and device. Coccinelle script: @@ function f; identifier r; @@ f(..., struct d

[Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Matthew Auld
No functional change, just makes the code easier to follow. v2: - Remove local fence_size variable (Tvrtko Ursulin) - Remove redundant NULL ggtt_view check - Reuse size variable Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.c | 51 +++-

Re: [Intel-gfx] [PATCH i-g-t] intel: Adding missing Broxton PCI IDs.

2016-03-19 Thread Arun Siluvery
On 17/03/2016 21:39, Rodrigo Vivi wrote: These IDs were already part of the kernel since: kernel commit 985dd4360fdf2533fe48a33a4a2094f2e4718dc0 Author: Imre Deak Date: Thu Jan 28 16:04:12 2016 +0200 drm/i915/bxt: update list of PCIIDs Signed-off-by: Rodrigo Vivi --- lib/intel_chip

[Intel-gfx] [PATCH 1/8] drm/i915/dsi: refer to gpio index instead of gpio to avoid confusion

2016-03-19 Thread Jani Nikula
The DSI sequence blocks contain gpio index references, not actual gpio numbers. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dsi_pan

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2)

2016-03-19 Thread dw kim
On Thu, Mar 17, 2016 at 01:03:36PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2) > URL : https://patchwork.freedesktop.org/series/4491/ > State : failure > > == Summary == > > Series 4491v2 drm/i915/bxt: Reversed polar

[Intel-gfx] [PATCH i-g-t 0/6] New pipe level color management tests

2016-03-19 Thread Lionel Landwerlin
Hi, This series enables testing pipe level color management using kernel patches from this serie : https://patchwork.freedesktop.org/series/2720/ Most of the tests use pipe CRCs to check the results by comparing the output with the expected output drawn using cairo. Cheers, Lionel Lionel Lan

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: lose the loose 666 format name in favor of packed

2016-03-19 Thread Ville Syrjälä
On Wed, Mar 16, 2016 at 12:21:39PM +0200, Jani Nikula wrote: > The enum mipi_dsi_pixel_format defines MIPI_DSI_FMT_RGB666 for the > "loose" 24 bpp format and MIPI_DSI_FMT_RGB666_PACKED for the 18 bpp > format. We have this the other way round, defining a loose version for > 24 bpp. > > Follow suit

Re: [Intel-gfx] [RFC PATCH 01/10] drm/i915: add for_each_port_masked macro

2016-03-19 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 09:51:09PM +0200, Jani Nikula wrote: > Same as for_each_dsi_port, but for general use. Leave the > for_each_dsi_port version around as an "alias" for now to not cause too > much churn. No functional changes. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --

[Intel-gfx] [PATCH 4/8] drm/i915/dsi: abstract VLV gpio element execution to a separate function

2016-03-19 Thread Jani Nikula
Prepare for future. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 57 -- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_p

Re: [Intel-gfx] [PATCH v5] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Chris Wilson
On Fri, Mar 18, 2016 at 08:50:37AM +0200, Imre Deak wrote: > Atm, in case failure injection forces an error the subsequent "*ERROR* > failed to init modeset" error message will make automated tests (CI) > report this event as a breakage even though the event is expected. To > fix this print the err

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Name all intel_ringbuffer instances ring

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: Name all intel_ringbuffer instances ring URL : https://patchwork.freedesktop.org/series/4595/ State : failure == Summary == Series 4595v1 drm/i915: Name all intel_ringbuffer instances ring http://patchwork.freedesktop.org/api/1.0/series/4595/revisions/1/m

[Intel-gfx] [PATCH v2] drm/i915: Name all intel_ringbuffer instances ring

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A mix of Coccinelle, sed and manual editing. v2: Rename engine->buffer as well. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson -- Compile tested only! --- drivers/gpu/drm/i915/i915_debugfs.c| 14 +- drivers/gpu/drm/i915/i915_drv.h| 4 +- drivers/gp

Re: [Intel-gfx] [PATCH 1/3] pinctrl: Intel: add RX invertion config

2016-03-19 Thread Jani Nikula
On Thu, 17 Mar 2016, Linus Walleij wrote: > On Wed, Mar 16, 2016 at 2:34 PM, Daniel Vetter wrote: >> On Wed, Mar 16, 2016 at 01:27:49PM +0100, Linus Walleij wrote: > >>> - What is a HPD interrupt? >> >> hotplug interrupt, fires when you plug in a cable. >> >>> - What is a Type-C DP HPD? >> >> usb

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Release power ref after updating wm

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: Release power ref after updating wm URL : https://patchwork.freedesktop.org/series/4525/ State : failure == Summary == Series 4525v1 drm/i915: Release power ref after updating wm http://patchwork.freedesktop.org/api/1.0/series/4525/revisions/1/mbox/ Test

[Intel-gfx] [PATCH 4/4] drm/i915: Rename struct intel_ringbuffer function parameters

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin From ring to ringbuf so it is always consistent. Coccinelle script: @@ identifier func; identifier r; @@ func(..., struct intel_ringbuffer * - r + ringbuf , ...) { <... - r + ringbuf ...> } @@ identifier func, r; type T; @@ T func(..., struct intel_ringbuffer * - r + ringbu

[Intel-gfx] [maintainer-tools PATCH 2/2] dim: add dim sparse subcommand to run sparse on a commit range

2016-03-19 Thread Jani Nikula
Run sparse only on files that have changed in the range. Replace dim checker with the new one. Signed-off-by: Jani Nikula --- dim | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/dim b/dim index 65985bc4909a..61745b556517 100755 --- a/dim +++ b/dim @@ -713,11 +713,

Re: [Intel-gfx] [PATCH] prime_mmap_coherency: Add return error tests for prime sync ioctl

2016-03-19 Thread Tiago Vignatti
On 03/17/2016 06:01 PM, Chris Wilson wrote: On Thu, Mar 17, 2016 at 03:18:03PM -0300, Tiago Vignatti wrote: This patch adds ioctl-errors subtest to be used for exercising prime sync ioctl errors. The subtest constantly interrupts via signals a function doing concurrent blit to stress out the ri

[Intel-gfx] Intel Atom SoC Bay/Cherry Trail - HDMI Audio

2016-03-19 Thread poma
Hi Fi $ wget https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-4.4.6.tar.xz $ tar xf linux-4.4.6.tar.xz $ cd linux-4.4.6/ $ curl -s https://patchwork.freedesktop.org/api/1.0/series/4142/revisions/1/mbox/ | patch -p1 ... patching file drivers/gpu/drm/i915/i915_reg.h Hunk #1 succeeded at 1993 w

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Imre Deak
On Wed, 2016-03-16 at 10:48 +0200, Imre Deak wrote: > Tomi, noticed two things that maybe infrastructure related, see > below: > > On Wed, 2016-03-16 at 07:31 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs > > (rev3) > > URL 

Re: [Intel-gfx] [PATCH 1/2] mm/vmap: Add a notifier for when we run out of vmap address space

2016-03-19 Thread Roman Peniaev
On Thu, Mar 17, 2016 at 1:57 PM, Chris Wilson wrote: > On Thu, Mar 17, 2016 at 01:37:06PM +0100, Roman Peniaev wrote: >> > + freed = 0; >> > + blocking_notifier_call_chain(&vmap_notify_list, 0, &freed); >> >> It seems to me that alloc_vmap_area() was designed not to sleep, >> at least

[Intel-gfx] [PATCH i-g-t 3/6] lib: fb: add igt_paint_color_gradient_range

2016-03-19 Thread Lionel Landwerlin
This is a helper to draw a gradient between 2 colors. Signed-off-by: Lionel Landwerlin --- lib/igt_fb.c | 34 ++ lib/igt_fb.h | 3 +++ 2 files changed, 37 insertions(+) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 7b53556..06f4a62 100644 --- a/lib/igt_fb.c +++

[Intel-gfx] [PATCH] drm/i915: Name all intel_ringbuffer instances ring

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A mix of Coccinelle, sed and manual editing. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson -- Compile tested only! --- drivers/gpu/drm/i915/i915_debugfs.c| 14 +- drivers/gpu/drm/i915/i915_drv.h| 4 +- drivers/gpu/drm/i915/i915_gem.c|

Re: [Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Tvrtko Ursulin
Hi, On 16/03/16 17:07, Matthew Auld wrote: No functional change, just makes the code easier to follow. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.c | 41 +++-- 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 10/10] drm/i915: Disable use of stolen area by User when Intel RST is present

2016-03-19 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma The BIOS RapidStartTechnology may corrupt the stolen memory across S3 suspend due to unalarmed hibernation, in which case we will not be able to preserve the User data stored in the stolen region. Hence this patch tries to identify presence of the RST device on the ACPI b

Re: [Intel-gfx] [RFC] drm/i915: Smarten up and use to_i915() everywhere

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 04:00:58PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > There is a lot of ways to get to our dev_priv depending on which > object is at hand and often what was chosen by the developer. > > We can make to_i915() accept different pointers by using compile > time

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 11:10:42PM +0200, Imre Deak wrote: > Well, I can follow-up on an export patch for that, but getting that > merged may take a while, so could we go with the current version until > that? What's the current version? ;) For my tastes, I really want the "please file a bug" to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move CSB MMIO reads out of the execlists lock (rev4)

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: Move CSB MMIO reads out of the execlists lock (rev4) URL : https://patchwork.freedesktop.org/series/3973/ State : failure == Summary == Series 3973v4 drm/i915: Move CSB MMIO reads out of the execlists lock http://patchwork.freedesktop.org/api/1.0/series/3

[Intel-gfx] [PATCH igt] lib/core: Add option to exit on first failure

2016-03-19 Thread Chris Wilson
When bisecting a test failure (one of many possibile subtests), we want to exit as early as possible after the first subtest fails. Signed-off-by: Chris Wilson --- lib/igt_core.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index a

Re: [Intel-gfx] [RFC] drm/i915: Smarten up and use to_i915() everywhere

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 08:46:05PM +0200, Jani Nikula wrote: > On Thu, 17 Mar 2016, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > There is a lot of ways to get to our dev_priv depending on which > > object is at hand and often what was chosen by the developer. > > > > We can make to_i915

[Intel-gfx] [PATCH 1/2] mm/vmap: Add a notifier for when we run out of vmap address space

2016-03-19 Thread Chris Wilson
vmaps are temporary kernel mappings that may be of long duration. Reusing a vmap on an object is preferrable for a driver as the cost of setting up the vmap can otherwise dominate the operation on the object. However, the vmap address space is rather limited on 32bit systems and so we add a notific

[Intel-gfx] [PATCH v4 07/19] drm/i915: Move load time gem_load_init earlier

2016-03-19 Thread Imre Deak
The only steps requiring device access is the fence and swizzling initialization, so split these out keeping them in their current place and move the rest of init steps earlier. v2-v3: - unchanged v4: - move call to i915_gem_detect_bit_6_swizzle() to i915_gem_load_init_fences() and preserve the

[Intel-gfx] [PATCH v2 1/4] drm/i915/gtt: Reference mappable_end variable from pointer

2016-03-19 Thread Joonas Lahtinen
Reference variable value from pointer, not assumed pointer destination. Since: commit c44ef60e437019b8ca1dab8b4d2e8761fd4ce1e9 Author: Mika Kuoppala Date: Thu Jun 25 18:35:05 2015 +0300 drm/i915/gtt: Allow >= 4GB sizes for vm. Cc: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by:

Re: [Intel-gfx] [PATCH i-g-t v3 3/6] tests/gem_scheduler: Add gem_scheduler test

2016-03-19 Thread Daniele Ceraolo Spurio
On 17/03/16 08:49, Daniele Ceraolo Spurio wrote: On 10/03/16 11:03, Derek Morton wrote: This is intended to test the scheduler behaviour is correct. The subtests are -basic Tests that batch buffers of the same priority submitted to a ring execute in the order they are submitted. -read Submit

[Intel-gfx] [PATCH v2 4/6] drm/i915/bxt: add dsi transcoders

2016-03-19 Thread Jani Nikula
The BXT display connections have DSI transcoders A and C that can be muxed to any pipe, not unlike the eDP transcoder. Add the notion of DSI transcoders. The "normal" transcoders A, B and C are not used with BXT DSI, so care must be taken to avoid accessing those registers with DSI transcoders in

Re: [Intel-gfx] [RFC] drm/i915: Smarten up and use to_i915() everywhere

2016-03-19 Thread Arun Siluvery
On 17/03/2016 16:00, Tvrtko Ursulin wrote: From: Tvrtko Ursulin There is a lot of ways to get to our dev_priv depending on which object is at hand and often what was chosen by the developer. We can make to_i915() accept different pointers by using compile time magic. Like: dev_priv = to_i9

[Intel-gfx] [maintainer-tools PATCH 1/2] dim: abstract git commit range expansion helper

2016-03-19 Thread Jani Nikula
Signed-off-by: Jani Nikula --- dim | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/dim b/dim index 67671de198a0..65985bc4909a 100755 --- a/dim +++ b/dim @@ -690,19 +690,23 @@ function checkpatch_commit fi } -dim_alias_check_patch=checkpatch -di

[Intel-gfx] [PATCH 2/4] drm/i915: Use shorter route to dev_private where possible

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Where we have a request we can use req->i915 directly instead of going through the engine and device. Coccinelle script: @@ function f; identifier r; @@ f(..., struct drm_i915_gem_request *r, ...) { ... - engine->dev->dev_private + r->i915 ... } @@ struct drm_i915_gem_reques

Re: [Intel-gfx] [PATCH v3 19/19] drm/i915: Add fault injection support

2016-03-19 Thread Chris Wilson
On Wed, Mar 16, 2016 at 01:39:08PM +0200, Imre Deak wrote: > Add support for forcing an error at selected places in the driver. As an > example add 4 options to fail during driver loading. > > Requested by Chris. > > v2: > - Add fault point for modeset initialization > - Print debug message when

[Intel-gfx] [PATCH resend for CI 1/2] drm/i915: Remove unused variable in i915_gem_request_add_to_client

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 31652c1da761..9c4d9c186d91 100644 --- a/drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 04:42:12PM +0200, Imre Deak wrote: > Atm, in case failure injection forces an error a subsequent error > messages will make automated tests (CI) report this event as a breakage, > even though the event is expected. To fix this print the error message > with debug log level i

[Intel-gfx] [PATCH] drm/i915: Name the anonymous per-engine context struct

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This anonymous struct was causing a good amount of overly verbose code. Also, if we name it and cache the pointer locally when there are multiple accesses to it, not only the code is more readable, but the compiler manages to generate smaller binary. Along the way I also sho

Re: [Intel-gfx] Information about Intel_GPU_TOP tool

2016-03-19 Thread Marius Vlad
Hi, As Sergio stated, tools/intel_gpu_top is rather old and has some limitations, but you are welcome to improve it :-). 1. None that I know of. 2. Most likely true. 3. The tool suggested by Sergio is an alternative. On Fri, Mar 18, 2016 at 03:57:16PM +, Sanchez, AdolfoX w

Re: [Intel-gfx] [PATCH v2] dim: Avoid false positives with BUG detection

2016-03-19 Thread Tvrtko Ursulin
On 11/03/16 15:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Makes sure that the diff line adding the BUG is not immediately preceded by the diff line removing the BUG. Or in other words, avoids false positives when existing BUG is edited. v2: Sent the incomplete version out... Signed-off-

[Intel-gfx] [PATCH v2] drm/i915: Name the anonymous per-engine context struct

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This anonymous struct was causing a good amount of overly verbose code. Also, if we name it and cache the pointer locally when there are multiple accesses to it, not only the code is more readable, but the compiler manages to generate smaller binary. Along the way I also sho

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Codify our assumption that the Global GTT is <= 4GiB

2016-03-19 Thread Mika Kuoppala
Mika Kuoppala writes: > [ text/plain ] > Joonas Lahtinen writes: > >> [ text/plain ] >> From: Chris Wilson >> >> Throughout the code base, we use u32 for offsets into the global GTT. If >> we ever see any hardware with a larger GGTT, then we run the real risk >> of silent corruption. So test fo

Re: [Intel-gfx] [PATCH resend for CI 2/2] drm/i915: Use shorter route to dev_private where possible

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 01:47:31PM +, Tvrtko Ursulin wrote: > > On 17/03/16 13:17, Chris Wilson wrote: > >On Thu, Mar 17, 2016 at 01:04:10PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Where we have a request we can use req->i915 directly instead > >>of going through the en

[Intel-gfx] [PATCH v6] igt/gem_trtt: Exercise the TRTT hardware

2016-03-19 Thread akash . goel
From: Akash Goel This patch provides the testcase to exercise the TRTT hardware. Some platforms have an additional address translation hardware support in form of Tiled Resource Translation Table (TR-TT) which provides an extra level of abstraction over PPGTT. This is useful for mapping Sparse/T

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/dsi: lose the loose 666 format name in favor of packed

2016-03-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dsi: lose the loose 666 format name in favor of packed URL : https://patchwork.freedesktop.org/series/4505/ State : failure == Summary == Series 4505v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/

Re: [Intel-gfx] [PATCH i-g-t] intel: Adding missing Broxton PCI IDs.

2016-03-19 Thread Vivi, Rodrigo
On Fri, 2016-03-18 at 00:42 +, Arun Siluvery wrote: > On 17/03/2016 21:39, Rodrigo Vivi wrote: > > These IDs were already part of the kernel since: > > > > kernel commit 985dd4360fdf2533fe48a33a4a2094f2e4718dc0 > > Author: Imre Deak > > Date: Thu Jan 28 16:04:12 2016 +0200 > > > > dr

[Intel-gfx] [PATCH 2/2] drm/i915/shrinker: Hook up vmap allocation failure notifier

2016-03-19 Thread Chris Wilson
If the core runs out of vmap address space, it will call a notifier in case any driver can reap some of its vmaps. As i915.ko is possibily holding onto vmap address space that could be recovered, hook into the notifier chain and try and reap objects holding onto vmaps. Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH v3] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
Atm, in case failure injection forces an error the subsequent "*ERROR* failed to init modeset" error message will make automated tests (CI) report this event as a breakage even though the event is expected. To fix this print the error message with debug log level in this case. While at it print th

Re: [Intel-gfx] [PATCH v3 19/19] drm/i915: Add fault injection support

2016-03-19 Thread Chris Wilson
On Wed, Mar 16, 2016 at 02:12:35PM +0200, Imre Deak wrote: > On Wed, 2016-03-16 at 12:00 +, Chris Wilson wrote: > > On Wed, Mar 16, 2016 at 01:39:08PM +0200, Imre Deak wrote: > > > Add support for forcing an error at selected places in the driver. > > > As an > > > example add 4 options to fail

Re: [Intel-gfx] [PATCH v5] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
On Fri, 2016-03-18 at 07:58 +, Chris Wilson wrote: > On Fri, Mar 18, 2016 at 08:50:37AM +0200, Imre Deak wrote: > > Atm, in case failure injection forces an error the subsequent "*ERROR* > > failed to init modeset" error message will make automated tests (CI) > > report this event as a breakage

[Intel-gfx] [PATCH v3 maintainer-tools] dim: Avoid false positives with BUG detection

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Makes sure that the diff line adding the BUG is not immediately preceded by the diff line removing the BUG. Or in other words, avoids false positives when existing BUG is edited. v2: Sent the incomplete version out... v3: Rebase. Signed-off-by: Tvrtko Ursulin Cc: Jani Nik

[Intel-gfx] [PATCH v3 16/19] drm/i915: Split out load time HW initialization

2016-03-19 Thread Imre Deak
According to the new init phases scheme we should have a definite step in the init sequence where we setup things requiring accessing the device, so move the corresponding code to separate function. The steps in this init phase should avoid exposing the driver via some interface, which is done in t

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Rename dev_priv->gtt to dev_priv->ggtt

2016-03-19 Thread Chris Wilson
On Fri, Mar 18, 2016 at 09:53:09AM +0200, Joonas Lahtinen wrote: > Refer to Global GTT consistencly as GGTT, thus rename dev_priv->gtt > to dev_priv->ggtt and struct i915_gtt to struct i915_ggtt. Simple enough mechanical sed, and ggtt is a good name with ggtt vs ppgtt nomenclature. Reviewed-by: Ch

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Tomi Sarvela
On Wednesday 16 March 2016 16:40:24 Takashi Iwai wrote: > On Wed, 16 Mar 2016 16:37:06 +0100, Daniel Vetter wrote: > > On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote: > > > > > > SND is recurring problem. I'd like to see drm-intel-nightly not breaking > > > when pulling sound updates

<    1   2   3   4   >