== Summary ==
Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly:
2016y-01m-27d-16h-33m-06s UTC integration manifest
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (ilk-hp8440p)
bdw-nuci7total:141 pass:132 dwarn:0
== Summary ==
Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly:
2016y-01m-27d-16h-33m-06s UTC integration manifest
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (ilk-hp8440p)
bdw-nuci7total:141 pass:132 dwarn:0
>>> However, as a couple of crashers
>>> slipped through into 2.99.916 (though not actual regressions in
>>> 2.99.916 per se) and 3 months have passed, we should make one more
>>> snapshot before an imminent release.
> Distributions are forced to randomly pick some git snapshot. Often it's
> not
== Summary ==
Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly:
2016y-01m-27d-16h-33m-06s UTC integration manifest
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (ilk-hp8440p)
bdw-nuci7total:141 pass:132 dwarn:0
On 27/01/16 15:36, Ville Syrjälä wrote:
On Wed, Jan 27, 2016 at 03:02:15PM +, Morton, Derek J wrote:
-Original Message-
From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
Sent: Wednesday, January 27, 2016 2:31 PM
To: Morton, Derek J
Cc: intel-gfx@lists.freedesktop.org
Subje
== Summary ==
Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly:
2016y-01m-27d-16h-33m-06s UTC integration manifest
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (ilk-hp8440p)
bdw-nuci7total:141 pass:132 dwarn:0
On ke, 2016-01-27 at 17:32 +, Dave Gordon wrote:
> On 26/01/16 09:44, Joonas Lahtinen wrote:
> > On ma, 2016-01-25 at 18:57 +, Dave Gordon wrote:
> > > On 25/01/16 18:17, Daniel Vetter wrote:
> > >
> > >
> > > I915_DBG(...) ?
> > >
> > > It's conventional that macros should be UPPERCA
== Summary ==
Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly:
2016y-01m-27d-16h-33m-06s UTC integration manifest
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (ilk-hp8440p)
bdw-nuci7total:141 pass:132 dwarn:0
On 27/01/16 13:50, Chris Wilson wrote:
On Wed, Jan 27, 2016 at 01:13:54PM +, Daniele Ceraolo Spurio wrote:
On 27/01/16 09:38, Chris Wilson wrote:
On Wed, Jan 27, 2016 at 08:55:40AM +, daniele.ceraolospu...@intel.com wrote:
From: Daniele Ceraolo Spurio
While running some tests on th
== Summary ==
Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly:
2016y-01m-27d-16h-33m-06s UTC integration manifest
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (ilk-hp8440p)
bdw-ultratotal:144 pass:138 dwarn:0
Thanks for the review Paulo.
Will incorporate the suggestions.
Thanks
Sagar
On 1/21/2016 6:54 PM, Zanoni, Paulo R wrote:
Em Qua, 2016-01-20 às 18:26 -0800, tom.orou...@intel.com escreveu:
From: Sagar Arun Kamble
GuC SLPC need to be sent data related to Active pipes, refresh rates,
widi pipes
== Summary ==
Built on 430706bace599ea1a908b9a7c6b7ea17535fe17f drm-intel-nightly:
2016y-01m-27d-16h-33m-06s UTC integration manifest
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (ilk-hp8440p)
bdw-nuci7total:141 pass:132 dwarn:0
This patchset implements the core part of Intel GVT-g [1] for graphics
virtualization. The patchset consists of two subsets: One is the
device model implementation of vGPUs for virtual machines (patch 09 -
29) Another is the needed i915 native driver changes for that
implementation (patch 01 - 08).
As the GVT context will use the shadow PPGTT page table generated by GVT
itself from guest PPGTT page table, the GVT context doesn't need a host
PPGTT page table, so host i915 doesn't need to populate PPGTT root pointers
for it as well.
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/intel_lrc.
As GVT-g workload scheduler may submit workloads from different VMs to i915,
some VM may use 32bit PPGTT addressing mode, while some VMs may use 48bit
addressing mode, the context addressing mode bit in the context descriptor
has to be aligned with guest workload. If the to-be-submitted context is
From: Bing Niu
This patch introduces host graphics memory ballon when GVT-g is enabled.
As under GVT-g, i915 only owned limited graphics resources, others are
managed by GVT-g resource allocator and kept for other vGPUs.
For graphics memory space partition, a typical layout looks like:
+--
This patch introduces the very basic framework of GVT-g device model,
includes basic prototypes, definitions, initialization.
---
arch/x86/include/asm/xen/interface.h | 3 +
drivers/gpu/drm/i915/Kconfig | 16 ++
drivers/gpu/drm/i915/Makefile | 2 +
drivers/gpu/drm/i915/gvt/M
GVT workload scheduler needs special host LRC contexts, the so called "shadow
LRC context" to submit guest workload to host i915. During the guest
workload submission, GVT fills the shadow LRC context with the content of
guest LRC context: engine context is copied without changes, ring context is
m
As the guest context will be copied into GVT context, during the context
shadow. It's not necessary for host i915 to initialize the engine state of
GVT context.
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/intel_lrc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dri
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/gvt/Makefile | 3 ++-
drivers/gpu/drm/i915/gvt/trace.h| 36 +
drivers/gpu/drm/i915/gvt/trace_points.c | 29 ++
3 files changed, 67 insertions(+), 1 deletion(-)
create mode 1006
This patch introduces the basic prototypes and definitions for GVT guest
MMIO emulation.
- Save an original MMIO snaphot when system boot up, which will
be used as the initial guest MMIO content.
- Introduce a framework to tracked all kinds of GEN MMIO registers,
each tracked MMIO register may ha
From: Zhiyuan Lv
In the compositor mode of display, dom0/host needs to get the guest
framebuffer to do more rendering, so that the guest VM's screen can
show up in more fancy way, e.g., in an X window of dom0/host.
In order to do that, a new gem object type "gvtbuffer" is introduced
to i915. Dif
From: Yulei Zhang
This patch introduces the GVT-g resource allocator. Under virtualization
environment, GGTT and fences are partitioned. GGTT memory space and fences
for i915 are limited. Only a part of GGTT memory space and fences is owned
by host. The left resources are mananged by GVT-g resour
Due to render mmio switch, GVT context cannot be scheduled with the host
i915 context together in a ELSP combo. Currently we will only allow the
a single submission if host i915 will schedule a GVT context.
At the time of schedule-in/out a GVT context, host i915 has to notify
GVT-g the status of G
This patch introduces vGPU life cycle management framework. vGPU instance
is a collection of virtual GEN hardware status, like virtual CFG/MMIO registers,
how much GGTT memory space/Fence this vGPU owns, etc.
A vGPU instance consists following virtualized/limited resources:
- Configuration space(
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/i915_vgpu.h | 85 +---
1 file changed, 70 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vgpu.h b/drivers/gpu/drm/i915/i915_vgpu.h
index b8a49e6..21c77a2 100644
--- a/drivers/gpu/drm/i915/
The vGPU graphics memory emulation framework is responsible for graphics
memory table virtualization/shadow. Under virtualization environment,
the guest will populate the page table with guest page frame number(GFN).
The relationship between GFN and MFN(Machine frame number) is managed by
hyperviso
This patch introduces vGPU interrupt emulation framework.
The vGPU intrerrupt emulation framework is an event-based interrupt emulation
framework. It's responsible for emulating GEN hardware interrupts demanded
by other GVT-g emulation core component.
It consists serveral components:
- Descripti
As different VM may configure different render MMIOs when executing workload,
to schedule workloads between different VM, the render MMIOs have to be
switched.
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/gvt/Makefile| 2 +-
drivers/gpu/drm/i915/gvt/debug.h | 3 +
drivers/gpu/drm
This patch introduces a vGPU schedule policy framework, with a timer based
schedule policy module for now
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/gvt/Makefile | 3 +-
drivers/gpu/drm/i915/gvt/gvt.h | 2 +
drivers/gpu/drm/i915/gvt/handlers.c | 16 ++
drivers/gpu/d
This patch introduces the vGPU OpRegion emulation routines based on the
MPT services and GVT-g CFG/MMIO emulation framework to support guest OpRegion
facilities.
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/gvt/Makefile| 2 +-
drivers/gpu/drm/i915/gvt/cfg_space.c | 13 ++
drivers/gpu/
This patch introduces the vGPU configuration space handlers built on the
generic MPT framework.
In vGPU configuration space emulation, GVT-g will:
- Adjust the trapped GPFN(Guest Page Frame Number) of virtual GEN PCI BAR 0,
when guest BIOS/OS modify the BAR address.
- Emulate OpRegion when guest
From: Niu Bing
GVT-g supports an indirect display mode by mapping guest display framebuffer
into host graphics memory space as a GEM object, so that host windows system
/ GL can easily manipulate it like a common GEM object.
For example, use an EGL extension to wrap a guest framebuffer GEM objec
GVT-g supports both Xen/KVM hypervisors and requires a couple of hypervisor
services to work. The MPT framework is a kinds of abstraction which provides
a unique hypervisor APIs to GVT-g core logics.
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/gvt/gvt.c | 6 ++
drivers/gpu/drm/i915/
From: "Niu,Bing"
This patch introduces vGPU MMIO register emulation core logics.
Under virtualization environment, all GEN MMIO register access will be trapped
by hypervisor and forwarded to GVT-g. GVT-g will handle these MMIO register
emulation request by different policies.
For some kinds of
From: Yulei Zhang
This patch introduces a command scanner to scan guest command buffers.
Signed-off-by: Yulei Zhang
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/gvt/Makefile |2 +-
drivers/gpu/drm/i915/gvt/cmd_parser.c | 2018 +
drivers/gpu/drm/i915
This patch introduces the GVT workload scheduler routines.
GVT workload scheduler is responsible for picking and executing GVT workload
from current scheduled vGPU. Before the workload is submitted to host i915,
the guest execlist context will be shadowed in the host GVT shadow context.
the instru
From: Yi Sun
This patch introduces the control interface for creating/destroying vGPUs.
Signed-off-by: Yi Sun
Signed-off-by: Zhi Wang
---
drivers/gpu/drm/i915/gvt/Makefile | 2 +-
drivers/gpu/drm/i915/gvt/control.c | 181 +
drivers/gpu/drm/i915/gvt/gvt.c
This patch introduces a full execlist status emulation framework.
Under virtulization environment, the execlist status are fully emulated
including virtual CSB emulation, virtual execlist emulation. The framework
will emulate the virtual CSB according to the guest workload running status.
Signed-
This is the xen hypervisor MPT module which let GVT-g be able to run under
Xen hypervisor.
Signed-off-by: Zhi Wang
---
arch/x86/include/asm/xen/hypercall.h |7 +
arch/x86/include/asm/xen/interface.h |1 +
arch/x86/xen/mmu.c | 83 +++
drivers/gpu/drm/i915/gvt/gvt.c
This patch introduces the vGPU execlist workload submission logics.
Under virtualization environment, guest will submit workload through virtual
execlist submit port. The submitted workload load will be wrapped into
an gvt workload which will be picked by GVT workload scheduler and executed
on hos
From: Bing Niu
This patch introduces the GVT-g full display virtualization subsystem.
It consists a collection of display MMIO handlers, like power well register
handler, pipe register handler, plane register handler, which will emulate
all display MMIOs behavior to support virtual mode setting
From: Tvrtko Ursulin
Will enable cleaner implementation of a following fix and
easier code unification in the future.
Idea and code by Chris Wilson.
v2: Do not return before last_contexts on engines are unpinned.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
Cc: Chris Wilson
---
From: Tvrtko Ursulin
Previously intel_lr_context_(un)pin were operating on requests
which is in conflict with their names.
If we make them take a context and an engine, it makes the names
make more sense and it also makes future fixes possible.
v2: Rebase for default_context/kernel_context chan
From: Tvrtko Ursulin
Will simplify the following fix and sounds logical.
v2: Add some whitespace to separate logic better. (Chris Wilson)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Chris Wilson
Cc: Chris Wilson
Cc: Nick Hoath
---
drivers/gpu/drm/i915/intel_lrc.c | 4
1 file changed, 4
From: Tvrtko Ursulin
In GuC mode LRC pinning lifetime depends exclusively on the
request liftime. Since that is terminated by the seqno update
that opens up a race condition between GPU finishing writing
out the context image and the driver unpinning the LRC.
To extend the LRC lifetime we will e
On 28/01/16 10:29, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Previously intel_lr_context_(un)pin were operating on requests
which is in conflict with their names.
If we make them take a context and an engine, it makes the names
make more sense and it also makes future fixes possible.
v2: Re
>
>
>-Original Message-
>From: Gordon, David S
>Sent: Thursday, January 28, 2016 8:35 AM
>To: intel-gfx@lists.freedesktop.org; Morton, Derek J; Ville Syrjälä
>Subject: Re: [Intel-gfx] [PATCH i-g-t] lib/igt_core.c: Expand --run-subtest
>functionality.
>
>On 27/01/16 15:36, Ville Syrjälä wr
On 28/01/16 10:48, Tvrtko Ursulin wrote:
From: Dave Gordon
In the error-handling paths of i915_gem_do_execbuffer() and
intel_crtc_page_flip(), the local pointer-to-request variables
were expected to be either valid pointers or NULL. Since
2682708 drm/i915: simplify allocation of driver-int
From: Dave Gordon
In the error-handling paths of i915_gem_do_execbuffer() and
intel_crtc_page_flip(), the local pointer-to-request variables
were expected to be either valid pointers or NULL. Since
2682708 drm/i915: simplify allocation of driver-internal requests
they could also be ERR_PTR()
On 27/01/16 16:39, Ville Syrjälä wrote:
On Wed, Jan 27, 2016 at 03:43:49PM +,daniele.ceraolospu...@intel.com wrote:
From: Daniele Ceraolo Spurio
While running some tests on the scheduler patches with rpm enabled I
came across a corruption in the ringbuffer, which was root-caused to
the G
Well we can't use that directly since that code must hold
dev->event_lock already. Extract an _unlocked version.
Embarrassingly I've totally forgotten about this patch and any kind of
event-based vblank wait totally blew up, killing the kernel.
v2: Pick the right base struct, someone didn't notic
Added support for specifying arbitary lists of subtests to run, or
to exclude from being run if prefixed by ^ or !.
subtest1,subtest2 Will run subtest1 and subtest2
^subtest1,subtest2 or !subtest1,subtest2 will run all subtests except
subtest1 and subtest2.
Any subtest string not starting ! or ^
On Wed, Jan 27, 2016 at 08:18:57PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 26, 2016 at 05:45:31PM +0200, Mika Kuoppala wrote:
> > There has been cases where we read DC_STATE and get something that we
> > did not write there. As DMC owns power well 1, this could be that DMC
> > snoops DC_STATE acc
Hi,
See the file MAINTAINERS and add Cc: lines according to "XEN HYPERVISOR
INTERFACE". Also I think it'll be useful to split the i915 changes to a
separate patch next int he series (as the reviewer will be different).
We will have to wait for Xen maintainers to take a position on this. Is
there
On Wed, Jan 20, 2016 at 03:31:20PM +0100, Patrik Jakobsson wrote:
> On SKL and KBL we can have pipe A/B/C disabled by fuse settings. The
> pipes must be fused in descending order (e.g. C, B+C, A+B+C). We simply
> decrease info->num_pipes if we find a valid fused out config.
>
> v2: Don't store the
Hi,
On 11/01/16 09:17, Chris Wilson wrote:
With the introduction of requests, we amplified the number of atomic
refcounted objects we use and update every execbuffer; from none to
several references, and a set of references that need to be changed. We
also introduced interesting side-effects in
On 11/01/16 09:17, Chris Wilson wrote:
In order to disambiguate between the pointer to the intel_engine_cs
(called ring) and the intel_ringbuffer (called ringbuf), rename
s/ring/engine/.
How about just extract this and do it straight away?
I sneaked in some engines already so it would be good
== Summary ==
HEAD is now at b3f8ad6 drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC
integration manifest
Applying: drm/i915: Extend LRC pinning to cover GPU context writeback
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001
On Thu, Jan 28, 2016 at 10:55:16AM +, Daniele Ceraolo Spurio wrote:
>
>
> On 27/01/16 16:39, Ville Syrjälä wrote:
> >On Wed, Jan 27, 2016 at 03:43:49PM +,daniele.ceraolospu...@intel.com
> >wrote:
> >>From: Daniele Ceraolo Spurio
> >>
> >>While running some tests on the scheduler patches
On Thu, Jan 28, 2016 at 11:41:37AM +, Tvrtko Ursulin wrote:
>
> Hi,
>
> On 11/01/16 09:17, Chris Wilson wrote:
> >With the introduction of requests, we amplified the number of atomic
> >refcounted objects we use and update every execbuffer; from none to
> >several references, and a set of ref
On 11/01/16 09:17, Chris Wilson wrote:
Now that we have disambuigated ring and engine, we can use the clearer
and more consistent name for the intel_ringbuffer pointer in the
request.
I am unsure about this one. Seems to be more ringbufs in the code base
and structure is called ring buffer so
On 11/01/16 09:17, Chris Wilson wrote:
Having ringbuf->ring point to an engine is confusing, so rename it once
again to ring->engine.
Another one to extract, rebase and merge ahead of the big work.
Regards,
Tvrtko
___
Intel-gfx mailing list
Intel-
Oh right, I suppose patch 59 is OK then if it goes together with this one.
Regards,
Tvrtko
On 11/01/16 09:17, Chris Wilson wrote:
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c| 21 +++---
drivers/gpu/drm/i915/i915_drv.h| 2 +-
drivers/gpu/drm/
On 28/01/16 11:46, Chris Wilson wrote:
On Thu, Jan 28, 2016 at 11:41:37AM +, Tvrtko Ursulin wrote:
Hi,
On 11/01/16 09:17, Chris Wilson wrote:
With the introduction of requests, we amplified the number of atomic
refcounted objects we use and update every execbuffer; from none to
several r
On Thu, Jan 28, 2016 at 11:45:24AM +, Chris Wilson wrote:
> On Thu, Jan 28, 2016 at 10:55:16AM +, Daniele Ceraolo Spurio wrote:
> >
> >
> > On 27/01/16 16:39, Ville Syrjälä wrote:
> > >On Wed, Jan 27, 2016 at 03:43:49PM +,daniele.ceraolospu...@intel.com
> > >wrote:
> > >>From: Danie
== Summary ==
Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly:
2016y-01m-28d-10h-26m-23s UTC integration manifest
bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9
bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6
bsw-nuc-2
ringfill generates a few very common errors when submitting requests,
and historically these have been where we have had many implementation
bugs, repeated over and over again.
Signed-off-by: Chris Wilson
---
tests/gem_ringfill.c | 21 +
1 file changed, 9 insertions(+), 12 de
== Summary ==
Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly:
2016y-01m-28d-10h-26m-23s UTC integration manifest
bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9
bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6
bsw-nuc-2
On Thu, Jan 28, 2016 at 02:09:37PM +0200, Ville Syrjälä wrote:
> On Thu, Jan 28, 2016 at 11:45:24AM +, Chris Wilson wrote:
> > On Thu, Jan 28, 2016 at 10:55:16AM +, Daniele Ceraolo Spurio wrote:
> > >
> > >
> > > On 27/01/16 16:39, Ville Syrjälä wrote:
> > > >On Wed, Jan 27, 2016 at 03:43
== Summary ==
Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly:
2016y-01m-28d-10h-26m-23s UTC integration manifest
Test kms_flip:
Subgroup basic-flip-vs-dpms:
pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE
Test kms_pipe_crc_basic:
Subgroup susp
== Summary ==
Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly:
2016y-01m-28d-10h-26m-23s UTC integration manifest
bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9
bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6
bsw-nuc-2
On 28/01/16 11:05, Derek Morton wrote:
Added support for specifying arbitary lists of subtests to run, or
to exclude from being run if prefixed by ^ or !.
subtest1,subtest2 Will run subtest1 and subtest2
^subtest1,subtest2 or !subtest1,subtest2 will run all subtests except
subtest1 and subtest2.
Hi Joonas,
On Thu, Jan 28, 2016 at 01:33:33PM +0200, Joonas Lahtinen wrote:
> Hi,
>
> See the file MAINTAINERS and add Cc: lines according to "XEN HYPERVISOR
> INTERFACE". Also I think it'll be useful to split the i915 changes to a
> separate patch next int he series (as the reviewer will be diff
== Summary ==
Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly:
2016y-01m-28d-10h-26m-23s UTC integration manifest
Test kms_flip:
Subgroup basic-flip-vs-dpms:
pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE
bdw-nuci7total:156 pass:147 dwarn:0
Rename to match the subcommand name.
Signed-off-by: Jani Nikula
---
dim | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dim b/dim
index faa98114a027..aee6e4b87b14 100755
--- a/dim
+++ b/dim
@@ -369,7 +369,7 @@ function dim_push_branch
# ensure we're on branch $1
Rename to match the (long) subcommand name. Move error checking to the
function too.
Signed-off-by: Jani Nikula
---
dim | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/dim b/dim
index aee6e4b87b14..e2d4869fdab0 100755
--- a/dim
+++ b/dim
@@ -440,8 +4
Rename to match the subcommand name. Move error checking to the function
too.
Signed-off-by: Jani Nikula
---
dim | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/dim b/dim
index e08fdffd3d86..faa98114a027 100755
--- a/dim
+++ b/dim
@@ -349,8 +349,13 @@ fun
Allow specifying dim subcommand aliases using variables of the format
dim_alias_. The value of the variable should be the name of the
actual subcommand. The user can specify aliases in the dimrc.
Signed-off-by: Jani Nikula
---
dim | 56
1
Drop the dim_ prefix as there's no corresponding subcommand.
Signed-off-by: Jani Nikula
---
dim | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dim b/dim
index e2d4869fdab0..d26abceb21a6 100755
--- a/dim
+++ b/dim
@@ -386,7 +386,7 @@ function dim_apply_branch
This is v2 of [1], with Daniel's concern regarding aliases
addressed. It's much better now.
Patches 1-11 and 15-31 are mostly just mechanical renames or code
movement. They explode the series so big, but I think they're easier to
look at this way.
The real changes are in patches 12-14 and 32-33.
Add dim_ prefix to functions corresponding to subcommands.
Signed-off-by: Jani Nikula
---
dim | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dim b/dim
index fa6e896aaf46..a2c0d74c37e8 100755
--- a/dim
+++ b/dim
@@ -406,7 +406,7 @@ function dim_apply_branch
eval $
Rename to match the subcommand. Also add checkpatch subcommand (without
the hyphen) to match the spelling of the tool.
Signed-off-by: Jani Nikula
---
dim | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dim b/dim
index 8865778a34f5..f8da41d71bc1 100755
--- a/dim
+++ b/di
Add dim_ prefix to functions corresponding to subcommands.
Signed-off-by: Jani Nikula
---
dim | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dim b/dim
index 5d06918f207e..6f209e360391 100755
--- a/dim
+++ b/dim
@@ -555,7 +555,7 @@ function prep_pull_mail
prep_pul
If there's a dim_ prefixed function matching the subcommand, call it to
handle the subcommand without going through the big switch case.
Drop the cases which already match the convention. Once all the cases
are converted to functions, the handling of subcommands becomes much
cleaner.
This also al
Signed-off-by: Jani Nikula
---
dim | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/dim b/dim
index 651ee5882ca3..c8daacfdf9f4 100755
--- a/dim
+++ b/dim
@@ -347,6 +347,15 @@ function dim_rebuild_nightly
}
+function dim_nightly_forget
+{
+ cd $DIM_PR
More abstraction is better, also guards against invalid internal use.
Signed-off-by: Jani Nikula
---
dim | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/dim b/dim
index a2c0d74c37e8..5833306e35c5 100755
--- a/dim
+++ b/dim
@@ -591,6 +591,11 @@ function dim_create_wor
Signed-off-by: Jani Nikula
---
dim | 42 ++
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/dim b/dim
index c8daacfdf9f4..fd61ce5a7f49 100755
--- a/dim
+++ b/dim
@@ -645,6 +645,28 @@ function dim_pull_request
"$addr_drm_maint
Helpful convenience.
Signed-off-by: Jani Nikula
---
dim | 7 +++
dim.rst | 5 +
2 files changed, 12 insertions(+)
diff --git a/dim b/dim
index 98b090eadf33..651ee5882ca3 100755
--- a/dim
+++ b/dim
@@ -743,6 +743,13 @@ function assert_branch
fi
}
+function dim_alias
+{
+
Rename as there's no corresponding subcommand (the check-patch
subcommand does a slightly different thing).
Signed-off-by: Jani Nikula
---
dim | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dim b/dim
index d26abceb21a6..8865778a34f5 100755
--- a/dim
+++ b/dim
@@ -478,7
Rename to match the subcommand.
Signed-off-by: Jani Nikula
---
dim | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dim b/dim
index f8da41d71bc1..5d06918f207e 100755
--- a/dim
+++ b/dim
@@ -625,7 +625,7 @@ function dim_pull_request
"$addr_drm_maintainer"
}
Rename to match the subcommand name.
Signed-off-by: Jani Nikula
---
dim | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dim b/dim
index 6f209e360391..fa6e896aaf46 100755
--- a/dim
+++ b/dim
@@ -234,7 +234,7 @@ function update_rerere_cache
cd -
}
-function upd
Signed-off-by: Jani Nikula
---
dim | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/dim b/dim
index f86ba6253e49..808c9c74a8d4 100755
--- a/dim
+++ b/dim
@@ -870,6 +870,12 @@ function dim_alias
sed 's/^dim_alias_/\t/;s/=/\t/'
}
+function dim_cat_to
Signed-off-by: Jani Nikula
---
dim | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/dim b/dim
index d887a9afc426..07ef5d70db1e 100755
--- a/dim
+++ b/dim
@@ -376,6 +376,24 @@ function dim_push_branch
update_linux_next
}
+dim_alias_pq=
Signed-off-by: Jani Nikula
---
dim | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/dim b/dim
index 69c8d6a49495..1ecdfefc4f11 100755
--- a/dim
+++ b/dim
@@ -750,6 +750,24 @@ function dim_pull_request
"$addr_drm_maintainer"
}
Signed-off-by: Jani Nikula
---
dim | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/dim b/dim
index 8c21c4d905b6..4942b1684f74 100755
--- a/dim
+++ b/dim
@@ -892,6 +892,13 @@ function dim_tc
fi
}
+function dim_fixes
+{
+ sha1=$1
+ git log -1
Signed-off-by: Jani Nikula
---
dim | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/dim b/dim
index 898889a28c69..f86ba6253e49 100755
--- a/dim
+++ b/dim
@@ -461,6 +461,16 @@ function dim_apply_resolved
git commit --amend &
}
+dim_alias_mrr=magic
I find displaying the man page on every typo a bit distracting. Now that
we can list all the supported subcommands (by way of listing all the
dim_ prefixed functions), add usage to show quick help. Also make it a
subcommand of its own.
Signed-off-by: Jani Nikula
---
dim | 17 ++---
1
Signed-off-by: Jani Nikula
---
dim | 56 +---
1 file changed, 33 insertions(+), 23 deletions(-)
diff --git a/dim b/dim
index 519d09a1cdc8..898889a28c69 100755
--- a/dim
+++ b/dim
@@ -435,6 +435,39 @@ function dim_apply_branch
eval $DRY
Signed-off-by: Jani Nikula
---
dim | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/dim b/dim
index 07ef5d70db1e..519d09a1cdc8 100755
--- a/dim
+++ b/dim
@@ -486,6 +486,21 @@ function dim_checkout
fi
}
+function dim_conq
+{
+ dim_check
1 - 100 of 162 matches
Mail list logo
