Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-12 Thread Ankitprasad Sharma
On Mon, 2016-01-11 at 21:29 +, Chris Wilson wrote: > On Mon, Jan 11, 2016 at 05:15:54PM +, Tvrtko Ursulin wrote: > > > Is that not what was written? I take it my telepathy isn't working > > > again. > > > > Sorry not a new loop, new case in a old loop. This is the hunk I think > > is not h

[Intel-gfx] ✓ success: Fi.CI.BAT

2016-01-12 Thread Patchwork
== Summary == Built on a90796840c30dac6d9907439bf98d1d08046c49d drm-intel-nightly: 2016y-01m-11d-17h-22m-54s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: pass -> DMESG-WARN (skl-i5k-2) UNSTABLE Test kms_pipe_crc_basic: Subgroup susp

[Intel-gfx] ✗ failure: Fi.CI.BAT

2016-01-12 Thread Patchwork
== Summary == HEAD is now at a907968 drm-intel-nightly: 2016y-01m-11d-17h-22m-54s UTC integration manifest Applying: drm: kerneldoc for drm_fops.c Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 drm: kerneldoc for drm_fops.c

Re: [Intel-gfx] [PATCH 05/13] drm/i915: Cache LRCA in the context

2016-01-12 Thread Tvrtko Ursulin
On 11/01/16 19:41, Dave Gordon wrote: On 11/01/16 08:38, Daniel Vetter wrote: On Fri, Jan 08, 2016 at 11:29:44AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We are not allowed to call i915_gem_obj_ggtt_offset from irq context without the big kernel lock held. LRCA lifetime is well def

Re: [Intel-gfx] [PATCH v4 02/38] drm/i915: Explicit power enable during deferred context initialisation

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 11:11:20AM +, John Harrison wrote: > On 12/01/2016 00:20, Chris Wilson wrote: > >On Mon, Jan 11, 2016 at 06:42:31PM +, john.c.harri...@intel.com wrote: > >>From: John Harrison > >> > >>A later patch in this series re-organises the batch buffer submission > >>code. P

[Intel-gfx] ✗ warning: Fi.CI.BAT

2016-01-12 Thread Patchwork
== Summary == Built on a90796840c30dac6d9907439bf98d1d08046c49d drm-intel-nightly: 2016y-01m-11d-17h-22m-54s UTC integration manifest Test kms_pipe_crc_basic: Subgroup read-crc-pipe-b-frame-sequence: pass -> DMESG-WARN (byt-nuc) Test pm_rpm: Subgroup basic-r

Re: [Intel-gfx] [PATCH 08/22] drm/gma500: Remove empty preclose hook

2016-01-12 Thread Patrik Jakobsson
On Mon, Jan 11, 2016 at 10:41 PM, Daniel Vetter wrote: > I'm auditing them all, empty ones just confuse ... > > Cc: Patrik Jakobsson > Acked-by: Daniel Stone > Reviewed-by: Alex Deucher > Signed-off-by: Daniel Vetter Acked-by: Patrik Jakobsson > --- > drivers/gpu/drm/gma500/psb_drv.c | 9 -

Re: [Intel-gfx] [PATCH 5/5] drm: Enable markdown^Wasciidoc for gpu.tmpl

2016-01-12 Thread Daniel Vetter
On Mon, Jan 11, 2016 at 06:12:12PM -0700, Jonathan Corbet wrote: > On Sat, 12 Dec 2015 12:13:45 +0100 > Daniel Vetter wrote: > > > I just figured there's no way this could get it, and I'd > > much rather improve the docs themselves than trying to convince core > > kernel folks that this might be

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: move VBT based TV presence check to intel_bios.c

2016-01-12 Thread Daniel Vetter
On Mon, Jan 11, 2016 at 09:54:37PM +0200, Jani Nikula wrote: > Hide knowledge about VBT child devices in intel_bios.c. > > Signed-off-by: Jani Nikula Assuming you copypasted correctly ;-) Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/inte

Re: [Intel-gfx] [PATCH 073/190] drm/i915: Introduce i915_gem_active for request tracking

2016-01-12 Thread Tvrtko Ursulin
On 11/01/16 22:49, Chris Wilson wrote: On Mon, Jan 11, 2016 at 05:32:27PM +, Tvrtko Ursulin wrote: +struct i915_gem_active { + struct drm_i915_gem_request *request; +}; + +static inline void +i915_gem_request_mark_active(struct drm_i915_gem_request *request, +

Re: [Intel-gfx] [PATCH 020/190] drm/i915: Remove the lazy_coherency parameter from request-completed?

2016-01-12 Thread Mika Kuoppala
Chris Wilson writes: > Now that we have split out the seqno-barrier from the > engine->get_seqno() callback itself, we can move the users of the > seqno-barrier to the required callsites simplifying the common code and > making the required workaround handling much more explicit. > > Signed-off-b

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Add per context timelines to fence object

2016-01-12 Thread John Harrison
On 11/01/2016 22:58, Chris Wilson wrote: On Mon, Jan 11, 2016 at 02:47:33PM -0800, Jesse Barnes wrote: On 01/11/2016 11:03 AM, John Harrison wrote: On 08/01/2016 22:05, Chris Wilson wrote: On Fri, Jan 08, 2016 at 06:47:24PM +, john.c.harri...@intel.com wrote: From: John Harrison The fen

[Intel-gfx] [PATCH v3 3/7] drm/i915: Cache ringbuffer GTT VMA

2016-01-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Purpose is to avoid calling i915_gem_obj_ggtt_offset from the interrupt context without the big lock held. v2: Renamed gtt_start to gtt_offset. (Daniel Vetter) v3: Cache the VMA instead of address. (Chris Wilson) Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter Cc: Chris W

Re: [Intel-gfx] [PATCH v4 02/38] drm/i915: Explicit power enable during deferred context initialisation

2016-01-12 Thread John Harrison
On 12/01/2016 00:20, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:42:31PM +, john.c.harri...@intel.com wrote: From: John Harrison A later patch in this series re-organises the batch buffer submission code. Part of that is to reduce the scope of a pm_get/put pair. Specifically, they previ

Re: [Intel-gfx] [PATCH 7/7] drm/i915/dp: Enable Upfront link training for typeC DP support on BXT

2016-01-12 Thread Ander Conselvan De Oliveira
On Mon, 2016-01-11 at 17:53 +, R, Durgadoss wrote: > > -Original Message- > > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > > Sent: Monday, January 11, 2016 8:46 PM > > To: R, Durgadoss; intel-gfx@lists.freedesktop.org > > Subject: Re: [PATCH 7/7] drm/i915/dp: Enable

Re: [Intel-gfx] [PATCH 073/190] drm/i915: Introduce i915_gem_active for request tracking

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 10:04:20AM +, Tvrtko Ursulin wrote: > Perhaps then leave the structure name as is and just rename the > function to i915_gem_request_assign_active? I think that describes > better what is actually happening. i915_gem_request_update_active()? request_assign_active() say

[Intel-gfx] ✗ warning: Fi.CI.BAT

2016-01-12 Thread Patchwork
== Summary == Built on a90796840c30dac6d9907439bf98d1d08046c49d drm-intel-nightly: 2016y-01m-11d-17h-22m-54s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: pass -> DMESG-WARN (skl-i7k-2) UNSTABLE Test kms_pipe_crc_basic: Subgroup read

Re: [Intel-gfx] [PATCH v4 21/38] drm/i915: Added a module parameter for allowing scheduler overrides

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 11:34:45AM +, John Harrison wrote: > On 11/01/2016 22:24, Chris Wilson wrote: > >On Mon, Jan 11, 2016 at 06:42:50PM +, john.c.harri...@intel.com wrote: > >>From: John Harrison > >> > >>It can be useful to be able to disable certain features (e.g. the > >>entire sche

Re: [Intel-gfx] [PATCH 021/190] drm/i915: Use HWS for seqno tracking everywhere

2016-01-12 Thread Mika Kuoppala
Chris Wilson writes: > By using the same address for storing the HWS on every platform, we can > remove the platform specific vfuncs and reduce the get-seqno routine to > a single read of a cached memory location. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_debugfs.c

Re: [Intel-gfx] [PATCH v4 21/38] drm/i915: Added a module parameter for allowing scheduler overrides

2016-01-12 Thread John Harrison
On 11/01/2016 22:24, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:42:50PM +, john.c.harri...@intel.com wrote: From: John Harrison It can be useful to be able to disable certain features (e.g. the entire scheduler) via a module parameter for debugging purposes. A parameter has the advanta

Re: [Intel-gfx] [PATCH 020/190] drm/i915: Remove the lazy_coherency parameter from request-completed?

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 12:27:05PM +0200, Mika Kuoppala wrote: > > for_each_ring(ring, dev_priv, i) { > > - seqno[i] = ring->get_seqno(ring); > > acthd[i] = intel_ring_get_active_head(ring); > > + seqno[i] = ring->get_seqno(ring); > > Oh! Perhaps I am overly opt

[Intel-gfx] [PATCH] drm/i915: Assign crtc correctly in load detection.

2016-01-12 Thread Maarten Lankhorst
drm_atomic_set_crtc_for_connector should be used, and crtc->primary->crtc is assigned by atomic_commit. Rely on the helpers for setting this correctly, so connector_mask gets updated too. Signed-off-by: Maarten Lankhorst --- Should this be applied to topic/drm-misc since atomic connector_masks a

Re: [Intel-gfx] [PATCH v4 06/38] drm/i915: Re-instate request->uniq because it is extremely useful

2016-01-12 Thread John Harrison
On 11/01/2016 22:04, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:42:35PM +, john.c.harri...@intel.com wrote: From: John Harrison The seqno value cannot always be used when debugging issues via trace points. This is because it can be reset back to start, especially during TDR type tests.

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Don't need a timer to wake us up

2016-01-12 Thread Tvrtko Ursulin
On 11/01/16 14:33, Chris Wilson wrote: On Mon, Jan 11, 2016 at 02:08:39PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We can avoid open-coding the schedule wake-up since commit 9cff8adeaa34b5d2802f03f89803da57856b3b72 Author: NeilBrown Date: Fri Feb 13 15:49:17 2015 +110

Re: [Intel-gfx] [PATCH v4 12/38] drm/i915: Added scheduler hook into i915_gem_request_notify()

2016-01-12 Thread John Harrison
On 11/01/2016 22:14, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:42:41PM +, john.c.harri...@intel.com wrote: From: John Harrison The scheduler needs to know when requests have completed so that it can keep its own internal state up to date and can submit new requests to the hardware fro

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix a memory leak where guc->execbuf_client is not freed

2016-01-12 Thread Dave Gordon
On 06/01/16 20:53, yu@intel.com wrote: From: Alex Dai During driver unloading, the guc_client created for command submission needs to be released to avoid memory leak. Signed-off-by: Alex Dai --- drivers/gpu/drm/i915/i915_guc_submission.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Intel-gfx] [PATCH v4 10/38] drm/i915: Force MMIO flips when scheduler enabled

2016-01-12 Thread John Harrison
On 11/01/2016 22:16, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:42:39PM +, john.c.harri...@intel.com wrote: From: John Harrison MMIO flips are the preferred mechanism now but more importantly, Says who? I asked this exact question at the linux architecture forum quite some time ago

Re: [Intel-gfx] [PATCH] drm/i915: Assign crtc correctly in load detection.

2016-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2016 at 12:35:59PM +0100, Maarten Lankhorst wrote: > drm_atomic_set_crtc_for_connector should be used, > and crtc->primary->crtc is assigned by atomic_commit. > > Rely on the helpers for setting this correctly, so > connector_mask gets updated too. > > Signed-off-by: Maarten Lankh

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915: Cache LRC state page in the context

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 11:56:11AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > LRC lifetime is well defined so we can cache the page pointing > to the object backing store in the context in order to avoid > walking over the object SG page list from the interrupt context > without the

Re: [Intel-gfx] [PATCH v4 02/38] drm/i915: Explicit power enable during deferred context initialisation

2016-01-12 Thread John Harrison
On 12/01/2016 11:28, Chris Wilson wrote: On Tue, Jan 12, 2016 at 11:11:20AM +, John Harrison wrote: On 12/01/2016 00:20, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:42:31PM +, john.c.harri...@intel.com wrote: From: John Harrison A later patch in this series re-organises the batch

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Support for creating Stolen memory backed objects

2016-01-12 Thread Chris Wilson
On Tue, Dec 22, 2015 at 11:50:47AM +0530, ankitprasad.r.sha...@intel.com wrote: > @@ -456,6 +457,21 @@ struct drm_i915_gem_create { >*/ > __u32 handle; > __u32 pad; > + /** > + * Requested flags (currently used for placement > + * (which memory domain)) > + *

Re: [Intel-gfx] [PATCH 5/5] drm: Enable markdown^Wasciidoc for gpu.tmpl

2016-01-12 Thread Graham Whaley
On Tue, 2016-01-12 at 09:34 +0100, Daniel Vetter wrote: > On Mon, Jan 11, 2016 at 06:12:12PM -0700, Jonathan Corbet wrote: > > On Sat, 12 Dec 2015 12:13:45 +0100 > > Daniel Vetter wrote: > > > > > I just figured there's no way this could get it, and I'd > > > much rather improve the docs themselv

Re: [Intel-gfx] [PATCH 07/22] drm/armada: Remove NULL open/pre/postclose hooks

2016-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2016 at 11:51:58AM +, Russell King - ARM Linux wrote: > On Mon, Jan 11, 2016 at 10:41:01PM +0100, Daniel Vetter wrote: > > The compiler will do this, but the void hits when grepping all the > > hooks for a subsystem wide audit are slightly annoying. So remove them > > for next t

Re: [Intel-gfx] [PATCH] drm/i915/skl: Use proper plane dimensions for DDB and WM calculations

2016-01-12 Thread Ville Syrjälä
On Mon, Jan 11, 2016 at 02:13:06PM -0800, Matt Roper wrote: > On Mon, Jan 11, 2016 at 09:31:03PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 21, 2015 at 07:31:17AM -0800, Matt Roper wrote: > > > In commit > > > > > > commit 024c9045221fe45482863c47c4b4c47d37f97cbf > > > Author: Mat

Re: [Intel-gfx] [PATCH v4 38/38] drm/i915: Allow scheduler to manage inter-ring object synchronisation

2016-01-12 Thread John Harrison
On 11/01/2016 22:07, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:43:07PM +, john.c.harri...@intel.com wrote: From: John Harrison The scheduler has always tracked batch buffer dependencies based on DRM object usage. This means that it will not submit a batch on one ring that has outstand

[Intel-gfx] [PATCH v3 4/7] drm/i915: Cache LRC state page in the context

2016-01-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin LRC lifetime is well defined so we can cache the page pointing to the object backing store in the context in order to avoid walking over the object SG page list from the interrupt context without the big lock held. v2: Also cache the mapping. (Chris Wilson) v3: Unmap on the

[Intel-gfx] [PATCH v2 2/7] drm/i915: Do not call API requiring struct_mutex where it is not available

2016-01-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin LRC code was calling GEM API like i915_gem_obj_ggtt_offset from places where the struct_mutex cannot be grabbed (irq handlers). To avoid that this patch caches some interesting bits and values in the engine and context structures. Some usages are also removed where they are

Re: [Intel-gfx] [PATCH v3 3/7] drm/i915: Cache ringbuffer GTT VMA

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 11:42:39AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Purpose is to avoid calling i915_gem_obj_ggtt_offset from the > interrupt context without the big lock held. > > v2: Renamed gtt_start to gtt_offset. (Daniel Vetter) > v3: Cache the VMA instead of address.

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Add per context timelines to fence object

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 11:03:08AM +, John Harrison wrote: > On 11/01/2016 22:58, Chris Wilson wrote: > >On Mon, Jan 11, 2016 at 02:47:33PM -0800, Jesse Barnes wrote: > >>On 01/11/2016 11:03 AM, John Harrison wrote: > >>>On 08/01/2016 22:05, Chris Wilson wrote: > On Fri, Jan 08, 2016 at 06:

[Intel-gfx] [PATCH v2 4/7] drm/i915: Cache LRC state page in the context

2016-01-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin LRC lifetime is well defined so we can cache the page pointing to the object backing store in the context in order to avoid walking over the object SG page list from the interrupt context without the big lock held. v2: Also cache the mapping. (Chris Wilson) Signed-off-by: T

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915: Cache LRC state page in the context

2016-01-12 Thread Tvrtko Ursulin
On 12/01/16 12:12, Chris Wilson wrote: On Tue, Jan 12, 2016 at 11:56:11AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin LRC lifetime is well defined so we can cache the page pointing to the object backing store in the context in order to avoid walking over the object SG page list from the

Re: [Intel-gfx] [PATCH v4 18/38] drm/i915: Added scheduler support to __wait_request() calls

2016-01-12 Thread John Harrison
On 11/01/2016 23:14, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:42:47PM +, john.c.harri...@intel.com wrote: From: John Harrison The scheduler can cause batch buffers, and hence requests, to be submitted to the ring out of order and asynchronously to their submission to the driver. Thus

Re: [Intel-gfx] [PATCH 1/6] drm: Create Color Management DRM properties

2016-01-12 Thread Ville Syrjälä
On Mon, Jan 11, 2016 at 08:37:09PM +, Daniel Stone wrote: > Hi, > > On 5 January 2016 at 10:23, Daniel Vetter wrote: > > On Wed, Dec 23, 2015 at 09:47:00AM +, Daniel Stone wrote: > >> It's not even a legacy vs. atomic thing, this can happen in > >> pure-atomic as well. Same as the render-

Re: [Intel-gfx] [PATCH v4 00/38] GPU scheduler for i915 driver

2016-01-12 Thread John Harrison
On 12/01/2016 04:37, Tian, Kevin wrote: From: john.c.harri...@intel.com Sent: Tuesday, January 12, 2016 2:42 AM From: John Harrison Implemented a batch buffer submission scheduler for the i915 DRM driver. The general theory of operation is that when batch buffers are submitted to the driver,

Re: [Intel-gfx] [PATCH 021/190] drm/i915: Use HWS for seqno tracking everywhere

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 12:05:06PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > - intel_ring_emit(ring, GFX_OP_PIPE_CONTROL(4) | PIPE_CONTROL_QW_WRITE | > > - PIPE_CONTROL_WRITE_FLUSH | > > - PIPE_CONTROL_TEXTURE_CACHE_INVALIDATE); > > - intel_ring

Re: [Intel-gfx] [PATCH 07/22] drm/armada: Remove NULL open/pre/postclose hooks

2016-01-12 Thread Russell King - ARM Linux
On Mon, Jan 11, 2016 at 10:41:01PM +0100, Daniel Vetter wrote: > The compiler will do this, but the void hits when grepping all the > hooks for a subsystem wide audit are slightly annoying. So remove them > for next time around. I'll try to remember to queue this after -rc1, though a reminder afte

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: simplify allocation of driver-internal requests

2016-01-12 Thread Dave Gordon
On 07/01/16 16:53, Chris Wilson wrote: On Thu, Jan 07, 2016 at 08:49:38AM -0800, Jesse Barnes wrote: On 01/07/2016 03:58 AM, Chris Wilson wrote: On Thu, Jan 07, 2016 at 10:20:50AM +, Dave Gordon wrote: There are a number of places where the driver needs a request, but isn't working on beha

Re: [Intel-gfx] [PATCH v2 02/10] drm/i915: Cleanup phys status page too

2016-01-12 Thread Daniel Vetter
On Mon, Jan 11, 2016 at 08:48:32PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Restore the lost phys status page cleanup. > > Fixes the following splat with DMA_API_DEBUG=y: Oh, we should enable this in our CI. Can you please shoot a mail to Tomi? > > WARNING: CPU: 0

Re: [Intel-gfx] [PATCH v3 4/7] drm/i915: Cache LRC state page in the context

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 12:54:25PM +, Tvrtko Ursulin wrote: > > On 12/01/16 12:12, Chris Wilson wrote: > >On Tue, Jan 12, 2016 at 11:56:11AM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>LRC lifetime is well defined so we can cache the page pointing > >>to the object backing

Re: [Intel-gfx] [PATCH] drm/i915: Assign crtc correctly in load detection.

2016-01-12 Thread Maarten Lankhorst
Op 12-01-16 om 13:34 schreef Daniel Vetter: > On Tue, Jan 12, 2016 at 12:35:59PM +0100, Maarten Lankhorst wrote: >> drm_atomic_set_crtc_for_connector should be used, >> and crtc->primary->crtc is assigned by atomic_commit. >> >> Rely on the helpers for setting this correctly, so >> connector_mask g

Re: [Intel-gfx] [PATCH] drm/i915: reboot notifier delay for eDP panels

2016-01-12 Thread Ville Syrjälä
On Mon, Jan 11, 2016 at 01:52:17PM -0800, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > Add reboot notifier for all platforms. This guarantees T12 delay > compliance during reboot cycles when pre-os enables the panel within > 500ms. > > Signed-off-by: Clint Taylor > --- > drivers/

Re: [Intel-gfx] [PATCH 145/190] drm/i915: Stop discarding GTT cache-domain on unbind vma

2016-01-12 Thread Joonas Lahtinen
On ma, 2016-01-11 at 11:00 +, Chris Wilson wrote: > Since > > commit 43566dedde54f9729113f5f9fde77d53e75e61e9 > Author: Chris Wilson > Date: Fri Jan 2 16:29:29 2015 +0530 > > drm/i915: Broaden application of set-domain(GTT) > > we allowed objects to be in the GTT domain, but unbound.

Re: [Intel-gfx] Intel-gfx Digest, Vol 96, Issue 26

2016-01-12 Thread Shubhangi Shrivastava
Hi, Can someone review the patches in the below mail? PFB the link to the same: https://patchwork.freedesktop.org/series/369/#rev5 Thanks and Regards, Shubhangi Shrivastava. On Tuesday 05 January 2016 06:28 PM, intel-gfx-requ...@lists.freedesktop.org wrote: Send Intel-gfx mail

Re: [Intel-gfx] [PATCH 073/190] drm/i915: Introduce i915_gem_active for request tracking

2016-01-12 Thread Tvrtko Ursulin
On 12/01/16 11:01, Chris Wilson wrote: On Tue, Jan 12, 2016 at 10:04:20AM +, Tvrtko Ursulin wrote: Perhaps then leave the structure name as is and just rename the function to i915_gem_request_assign_active? I think that describes better what is actually happening. i915_gem_request_update

Re: [Intel-gfx] [PATCH 073/190] drm/i915: Introduce i915_gem_active for request tracking

2016-01-12 Thread Tvrtko Ursulin
On 12/01/16 11:01, Chris Wilson wrote: On Tue, Jan 12, 2016 at 10:04:20AM +, Tvrtko Ursulin wrote: Perhaps then leave the structure name as is and just rename the function to i915_gem_request_assign_active? I think that describes better what is actually happening. i915_gem_request_update_

Re: [Intel-gfx] [PATCH 074/190] drm/i915: Rename request->list to link for consistency

2016-01-12 Thread Tvrtko Ursulin
On 11/01/16 09:17, Chris Wilson wrote: We use "list" to denote the list and "link" to denote an element on that list. Rename request->list to match this idiom. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- drivers/gpu/drm/i915/i915_gem.c | 12 +++

Re: [Intel-gfx] [PATCH] drm/i915: edp resume/On time optimization.

2016-01-12 Thread Ville Syrjälä
On Mon, Jan 11, 2016 at 02:55:37PM -0800, abhay.ku...@intel.com wrote: > From: Abhay Kumar > > Make resume/on codepath not to wait for panel_power_cycle_delay(t11_t12) > if this time is already spent in suspend/poweron time. > > v2: Use CLOCK_BOOTTIME and remove jiffies for panel power cycle >

Re: [Intel-gfx] [PATCH v4 00/38] GPU scheduler for i915 driver

2016-01-12 Thread Dave Gordon
On 12/01/2016 11:43, John Harrison wrote: On 12/01/2016 04:37, Tian, Kevin wrote: From: john.c.harri...@intel.com Sent: Tuesday, January 12, 2016 2:42 AM From: John Harrison Implemented a batch buffer submission scheduler for the i915 DRM driver. The general theory of operation is that whe

Re: [Intel-gfx] [PATCH 076/190] drm/i915: Rename vma->*_list to *_link for consistency

2016-01-12 Thread Tvrtko Ursulin
On 11/01/16 09:17, Chris Wilson wrote: Elsewhere we have adopted the convention of using '_link' to denote elements in the list (and '_list' for the actual list_head itself), and that the name should indicate which list the link belongs to (and preferrably not just where the link is being store

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: simplify allocation of driver-internal requests

2016-01-12 Thread Daniel Vetter
On Thu, Jan 07, 2016 at 10:20:50AM +, Dave Gordon wrote: > There are a number of places where the driver needs a request, but isn't > working on behalf of any specific user or in a specific context. At > present, we associate them with the per-engine default context. A future > patch will aboli

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915: abolish separate per-ring default_context pointers

2016-01-12 Thread Daniel Vetter
On Thu, Jan 07, 2016 at 10:20:51AM +, Dave Gordon wrote: > Now that we've eliminated a lot of uses of ring->default_context, > we can eliminate the pointer itself. > > All the engines share the same default intel_context, so we can just > keep a single reference to it in the dev_priv structure

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915: tidy up a few leftovers

2016-01-12 Thread Daniel Vetter
On Thu, Jan 07, 2016 at 10:20:52AM +, Dave Gordon wrote: > There are a few bits of code which the transformations implemented by > the previous patch reveal to be suboptimal, once the notion of a per- > ring default context has gone away. So this tidies up the leftovers. > > It could have been

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: simplify allocation of driver-internal requests

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 02:50:28PM +0100, Daniel Vetter wrote: > On Thu, Jan 07, 2016 at 10:20:50AM +, Dave Gordon wrote: > > There are a number of places where the driver needs a request, but isn't > > working on behalf of any specific user or in a specific context. At > > present, we associat

Re: [Intel-gfx] [PATCH v4 02/38] drm/i915: Explicit power enable during deferred context initialisation

2016-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2016 at 11:50:34AM +, John Harrison wrote: > On 12/01/2016 11:28, Chris Wilson wrote: > >On Tue, Jan 12, 2016 at 11:11:20AM +, John Harrison wrote: > >>On 12/01/2016 00:20, Chris Wilson wrote: > >>>On Mon, Jan 11, 2016 at 06:42:31PM +, john.c.harri...@intel.com wrote: >

Re: [Intel-gfx] [PATCH v4 10/38] drm/i915: Force MMIO flips when scheduler enabled

2016-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2016 at 11:19:26AM +, John Harrison wrote: > On 11/01/2016 22:16, Chris Wilson wrote: > >On Mon, Jan 11, 2016 at 06:42:39PM +, john.c.harri...@intel.com wrote: > >>From: John Harrison > >> > >>MMIO flips are the preferred mechanism now but more importantly, > >Says who? >

Re: [Intel-gfx] [PATCH 073/190] drm/i915: Introduce i915_gem_active for request tracking

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 01:44:13PM +, Tvrtko Ursulin wrote: > > On 12/01/16 11:01, Chris Wilson wrote: > >On Tue, Jan 12, 2016 at 10:04:20AM +, Tvrtko Ursulin wrote: > >>Perhaps then leave the structure name as is and just rename the > >>function to i915_gem_request_assign_active? I think

Re: [Intel-gfx] [PATCH 16/22] drm/omap: Nuke close hooks

2016-01-12 Thread Tomi Valkeinen
On 11/01/16 23:41, Daniel Vetter wrote: > Again since the core takes care of this we can remove them. While at > it also remove the postclose hook, it's empty. > > v2: Laurent pointed me at even more code to delete. > > Cc: Laurent Pinchart > Cc: Tomi Valkeinen > Acked-by: Daniel Stone > Revie

Re: [Intel-gfx] [PATCH 024/190] drm/i915: Replace manual barrier() with READ_ONCE() in HWS accessor

2016-01-12 Thread Mika Kuoppala
Chris Wilson writes: > When reading from the HWS page, we use barrier() to prevent the compiler > optimising away the read from the volatile (may be updated by the GPU) > memory address. This is more suited to READ_ONCE(); make it so. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter After r

Re: [Intel-gfx] [PATCH v4 02/38] drm/i915: Explicit power enable during deferred context initialisation

2016-01-12 Thread John Harrison
On 12/01/2016 14:04, Daniel Vetter wrote: On Tue, Jan 12, 2016 at 11:50:34AM +, John Harrison wrote: On 12/01/2016 11:28, Chris Wilson wrote: On Tue, Jan 12, 2016 at 11:11:20AM +, John Harrison wrote: On 12/01/2016 00:20, Chris Wilson wrote: On Mon, Jan 11, 2016 at 06:42:31PM +, j

Re: [Intel-gfx] [PATCH 20/22] drm/tilcdc: Nuke preclose hook

2016-01-12 Thread Tomi Valkeinen
On 11/01/16 23:41, Daniel Vetter wrote: > Again since the drm core takes care of event unlinking/disarming this > is now just needless code. > > v2: Fixup misplaced hunks. > > Cc: Rob Clark > Acked-by: Daniel Stone > Reviewed-by: Alex Deucher (v1) > Signed-off-by: Daniel Vetter > --- > driv

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: simplify allocation of driver-internal requests

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 01:56:48PM +, Chris Wilson wrote: > But we were removing the engine->default_context as it complicated the > rest of the code. I strongly prefer keeping the contexts explicit as > context separation should be first and foremost in the driver. $ git grep kernel_context -

Re: [Intel-gfx] [PATCH 021/190] drm/i915: Use HWS for seqno tracking everywhere

2016-01-12 Thread Mika Kuoppala
Chris Wilson writes: > On Tue, Jan 12, 2016 at 12:05:06PM +0200, Mika Kuoppala wrote: >> Chris Wilson writes: >> > - intel_ring_emit(ring, GFX_OP_PIPE_CONTROL(4) | PIPE_CONTROL_QW_WRITE | >> > - PIPE_CONTROL_WRITE_FLUSH | >> > - PIPE_CONTROL_TEXTURE_CACHE_INVAL

Re: [Intel-gfx] [PATCH 021/190] drm/i915: Use HWS for seqno tracking everywhere

2016-01-12 Thread Chris Wilson
On Tue, Jan 12, 2016 at 04:30:03PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Tue, Jan 12, 2016 at 12:05:06PM +0200, Mika Kuoppala wrote: > >> Chris Wilson writes: > >> > -intel_ring_emit(ring, GFX_OP_PIPE_CONTROL(4) | > >> > PIPE_CONTROL_QW_WRITE | > >> > -

Re: [Intel-gfx] [PATCH 00/15] drm/i915: Cure DDI from multiple personality disorder

2016-01-12 Thread Ville Syrjälä
On Tue, Dec 08, 2015 at 07:59:35PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > While debugging problems on DDI platforms I got tired of the crap > caused by the the dual personality DDI encoders, so I went ahead > and split them into separate HDMI and DP encoders. > > A

Re: [Intel-gfx] [PATCH] drm/i915: Handle PipeC fused off on HSW

2016-01-12 Thread Gabriel Feceoru
On 11.01.2016 19:56, Ville Syrjälä wrote: On Mon, Dec 21, 2015 at 01:57:22PM +0200, Gabriel Feceoru wrote: On some HSW boards all pipeC tests fail with various dmesg errors. This seems to be caused by Pipe C beeing disabled in FUSE_STRAP and thus reading back the PIPECONF register is always ze

Re: [Intel-gfx] [PATCH 00/10] drm/i915: Fixes from my attempt at running igt on gen2

2016-01-12 Thread Ville Syrjälä
On Mon, Dec 14, 2015 at 06:23:39PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > It's been a while since I last ran igt on gen2, so I figured I'd > give it a shot. 855 had some failures, 830 no longer worked at > all. So I went ahead and fixed them, and here's the result.

[Intel-gfx] [PATCH 1/3] drm/i915: Encapsulate the pwm_device in a pwm_info structure

2016-01-12 Thread Shobhit Kumar
pwm_info helps in encapsulating the PWM period_ns values and will form basis of adding new pwm devices which can then be genrically used by initializing proper pwm_info structure in the backlight setup call. Cc: cbroo...@gmail.com Cc: jani.nik...@linux.intel.com Signed-off-by: Shobhit Kumar ---

[Intel-gfx] [PATCH 0/3] LPSS PWM support for devices that support it

2016-01-12 Thread Shobhit Kumar
Hi, This is an untested attempt to enable LPSS PWM in the driver. As part of this did some restructuring for encapsulating the pwm_info inside the panel->backlight itself. This makes enabling LPSS PWM clean and simple. Not sending yet to pwm mailing list as this is all untested. C.B. please test t

[Intel-gfx] [PATCH 2/3] pwm: lpss: Add intel-gfx as consumer device in lookup table

2016-01-12 Thread Shobhit Kumar
Cc: cbroo...@gmail.com Cc: jani.nik...@linux.intel.com Signed-off-by: Shobhit Kumar --- drivers/pwm/pwm-lpss-platform.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/pwm/pwm-lpss-platform.c b/drivers/pwm/pwm-lpss-platform.c index 54433fc..910bc14 100644 --- a/drivers/pwm/pwm

[Intel-gfx] [PATCH xf86-video-intel] Sync PCI ids with latest kernel, adding SKL GT4

2016-01-12 Thread Damien Lespiau
Syncs with: commit 15620206ae87ba9643ffa6f5ddb5471be7192006 Author: Mika Kuoppala Date: Fri Nov 6 14:11:16 2015 +0200 drm/i915/skl: Add SKL GT4 PCI IDs Signed-off-by: Damien Lespiau --- src/i915_pciids.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH 3/3] drm/i915: Add support for LPSS PWM on devices that support it

2016-01-12 Thread Shobhit Kumar
Cc: cbroo...@gmail.com Cc: jani.nik...@linux.intel.com Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_panel.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index 9e24c59..1

[Intel-gfx] RPM wakelock ref not held during HW access

2016-01-12 Thread Sergey Senozhatsky
Hello, -mmots 4.4.0-mm1-dbg-00602-g776bd09 [ 5331.509087] WARNING: CPU: 0 PID: 359 at drivers/gpu/drm/i915/intel_drv.h:1446 gen6_read32+0x7b/0x253 [i915]() [ 5331.509091] RPM wakelock ref not held during HW access [ 5331.509093] Modules linked in: [ 5331.509182] CPU: 0 PID: 359 Comm: Xorg Not t

Re: [Intel-gfx] [PATCH] drm/i915: Handle PipeC fused off on HSW

2016-01-12 Thread Ville Syrjälä
On Tue, Jan 12, 2016 at 05:00:16PM +0200, Gabriel Feceoru wrote: > > > On 11.01.2016 19:56, Ville Syrjälä wrote: > > On Mon, Dec 21, 2015 at 01:57:22PM +0200, Gabriel Feceoru wrote: > >> On some HSW boards all pipeC tests fail with various dmesg errors. > >> This seems to be caused by Pipe C beei

Re: [Intel-gfx] [PATCH 20/22] drm/tilcdc: Nuke preclose hook

2016-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2016 at 04:19:39PM +0200, Tomi Valkeinen wrote: > > On 11/01/16 23:41, Daniel Vetter wrote: > > Again since the drm core takes care of event unlinking/disarming this > > is now just needless code. > > > > v2: Fixup misplaced hunks. > > > > Cc: Rob Clark > > Acked-by: Daniel Ston

[Intel-gfx] [PATCH] drm/i915: Handle error paths during watermark sanitization properly (v3)

2016-01-12 Thread Matt Roper
sanitize_watermarks() does not properly handle errors returned by drm_atomic_helper_duplicate_state(). Make failures drop locks before returning. We also change the lock of connection_mutex to a drm_modeset_lock_all_ctx() to make sure any EDEADLK's are handled earlier. v2: Change call to lock co

[Intel-gfx] ✓ success: Fi.CI.BAT

2016-01-12 Thread Patchwork
== Summary == Built on 37f6c2ae666fbba9eff4355115252b8b0fd43050 drm-intel-nightly: 2016y-01m-12d-14h-25m-44s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: dmesg-warn -> PASS (bdw-nuci7) Test kms_pipe_crc_basic: Subgroup read-crc-pipe

[Intel-gfx] [PATCH 1/1] drm/i915: Reorder shadow registers on gen8 for faster lookup

2016-01-12 Thread Mika Kuoppala
The most common thing on normal operation is ring tail pointer update. Put it first in the shadow register list for gen8, like we do with gen9. Also order the checks inside reg write paths so that if register is shadowed, no additional checks need to be made. Cc: Chris Wilson Signed-off-by: Mika

Re: [Intel-gfx] RPM wakelock ref not held during HW access

2016-01-12 Thread Daniel Vetter
On Wed, Jan 13, 2016 at 12:06:07AM +0900, Sergey Senozhatsky wrote: > Hello, > > -mmots 4.4.0-mm1-dbg-00602-g776bd09 Patch to shut this up (rpm is disabled by default for a reason still) on it's way into 4.5/-next. Thanks anyway for the report. -Daniel > > > [ 5331.509087] WARNING: CPU: 0 PID:

[Intel-gfx] [PATCH] drm/i915: Only complain about n_edp_entries with eDP ports

2016-01-12 Thread ville . syrjala
From: Ville Syrjälä commit 10afa0b65fe2 ("drm/i915: Reject >9 ddi translation entried if port != A/E on SKL") added sanity checks to make sure we don't end up with too many ddi translation values for eDP ports, but it actually failed to check if the port is eDP. We still look up the edp translat

Re: [Intel-gfx] [PATCH v4 02/38] drm/i915: Explicit power enable during deferred context initialisation

2016-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2016 at 02:21:51PM +, John Harrison wrote: > On 12/01/2016 14:04, Daniel Vetter wrote: > >On Tue, Jan 12, 2016 at 11:50:34AM +, John Harrison wrote: > >>On 12/01/2016 11:28, Chris Wilson wrote: > >>>On Tue, Jan 12, 2016 at 11:11:20AM +, John Harrison wrote: > On 12/0

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: Do not call API requiring struct_mutex where it is not available

2016-01-12 Thread Dave Gordon
On 12/01/16 11:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin LRC code was calling GEM API like i915_gem_obj_ggtt_offset from places where the struct_mutex cannot be grabbed (irq handlers). To avoid that this patch caches some interesting bits and values in the engine and context structures.

[Intel-gfx] ✗ warning: Fi.CI.BAT

2016-01-12 Thread Patchwork
== Summary == Built on 37f6c2ae666fbba9eff4355115252b8b0fd43050 drm-intel-nightly: 2016y-01m-12d-14h-25m-44s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: pass -> DMESG-WARN (skl-i5k-2) UNSTABLE Test kms_flip: Subgroup basic-flip-vs-

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Only grab timestamps when needed

2016-01-12 Thread Dave Gordon
On 11/01/16 15:04, Tvrtko Ursulin wrote: On 11/01/16 14:36, Chris Wilson wrote: On Mon, Jan 11, 2016 at 02:08:40PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin No need to call ktime_get_raw_ns twice per unlimited wait and can also elimate a local variable. But we could eliminate both,

Re: [Intel-gfx] [PATCH] drm/i915: Only complain about n_edp_entries with eDP ports

2016-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2016 at 05:28:16PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > commit 10afa0b65fe2 ("drm/i915: Reject >9 ddi translation entried if port != > A/E on SKL") > added sanity checks to make sure we don't end up with too many ddi translation > values for eDP p

[Intel-gfx] [PATCH 0/2] DPCD Backlight Control

2016-01-12 Thread Yetunde Adebisi
These patches add support for Backlight Control using DPCD registers on eDP displays. - Patch 1 adds macro for DPCD registers capability size to drm_dp_helper.h A copy of this patch has also been sent to dri-devel list. - Patch 2 Implements functionaly for DPCD Backlight Control Yetunde Adebisi

Re: [Intel-gfx] [PATCH 00/10] drm/i915: Fixes from my attempt at running igt on gen2

2016-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2016 at 04:54:27PM +0200, Ville Syrjälä wrote: > On Mon, Dec 14, 2015 at 06:23:39PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > It's been a while since I last ran igt on gen2, so I figured I'd > > give it a shot. 855 had some failures, 830 no longer

[Intel-gfx] [PATCH 1/2] drm/dp: Add definition for Display Control DPCD Registers capability size

2016-01-12 Thread Yetunde Adebisi
This is used when reading Display Control capability Registers on the sink device. cc: Jani Nikula cc: dri-de...@lists.freedesktop.org Signed-off-by: Yetunde Adebisi --- include/drm/drm_dp_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm

[Intel-gfx] [PATCH 1/2] drm/i915/gen8: Tidy display interrupt processing

2016-01-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin One bugfix and a few tidy-ups: * Pipe fault logging was broken on Gen9+. * Removed some unnecessary local variables. * Removed unnecessary initializers. * Decreased pipe iir block indentation level. * Grouped variable initialization close to use sites. Signed-off-by: T

[Intel-gfx] [PATCH 2/2] drm/i915/gen8: Factor out display interrupt handling

2016-01-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tidy quite long interrupt service routine by factoring out the display part. This simplifies the exit path a little bit, makes the code a bit more readable, and potentialy makes code reuse in the future easier. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_i

Re: [Intel-gfx] [PATCH v4 02/38] drm/i915: Explicit power enable during deferred context initialisation

2016-01-12 Thread Imre Deak
On ti, 2016-01-12 at 16:35 +0100, Daniel Vetter wrote: > On Tue, Jan 12, 2016 at 02:21:51PM +, John Harrison wrote: > > On 12/01/2016 14:04, Daniel Vetter wrote: > > > On Tue, Jan 12, 2016 at 11:50:34AM +, John Harrison wrote: > > > > On 12/01/2016 11:28, Chris Wilson wrote: > > > > > On Tu

  1   2   >