On Wed, 06 Jan 2016, Matt Roper wrote:
> Our attempts save/restore panel power state in i915_suspend.c are
> causing unclaimed register warnings on BXT since the registers for this
> platform differ from older platforms.
>
> The big hammer suspend/resume shouldn't be necessary for PP since the
> c
We still keep getting
[4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control
interrupt lied (SDE)!
This reverts
commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
Author: Jani Nikula
Date: Wed Nov 25 16:47:23 2015 +0200
Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
On Wed, 06 Jan 2016, Daniel Vetter wrote:
> On Sat, Jan 02, 2016 at 03:41:29PM +0200, Jani Nikula wrote:
>> On Thu, 31 Dec 2015, Matt Roper wrote:
>> > On Thu, Dec 31, 2015 at 08:31:45AM +0530, Kannan, Vandana wrote:
>> >> When I submitted the PPS patch in April, I got an input from Jani to
>> >>
On ma, 2016-01-04 at 17:05 +0200, Ville Syrjälä wrote:
> On Thu, Dec 31, 2015 at 05:52:07PM +0200, Gabriel Feceoru wrote
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -2014,15 +2014,18 @@ bool intel_ddi_get_hw_state(struct
> > intel_encoder *encoder
Since
commit ac9b8236551d1177fd07b56aef9b565d1864420d
Author: Ville Syrjälä
Date: Fri Nov 27 18:55:26 2015 +0200
drm/i915: Introduce a gmbus power domain
gmbus also needs the power domain infrastructure right from the start,
since as soon as we register the i2c controllers someone can use
On Thu, Jan 07, 2016 at 09:07:03AM +, Chris Wilson wrote:
> Some stress tests create both the signal helper and a lot of competing
> processes. In these tests, the parent is just waiting upon the children,
> and the intention is not to keep waking up the waiting parent, but to
> keep interrupti
On Thu, Jan 07, 2016 at 10:10:56AM +0100, Daniel Vetter wrote:
> Since
>
> commit ac9b8236551d1177fd07b56aef9b565d1864420d
> Author: Ville Syrjälä
> Date: Fri Nov 27 18:55:26 2015 +0200
>
> drm/i915: Introduce a gmbus power domain
>
> gmbus also needs the power domain infrastructure right
On Thu, Jan 07, 2016 at 10:29:10AM +0200, Jani Nikula wrote:
> We still keep getting
>
> [4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control
> interrupt lied (SDE)!
>
> This reverts
>
> commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
> Author: Jani Nikula
> Date: Wed Nov
On Thu, Jan 07, 2016 at 10:15:00AM +0200, Jani Nikula wrote:
> On Wed, 06 Jan 2016, Matt Roper wrote:
> > Our attempts save/restore panel power state in i915_suspend.c are
> > causing unclaimed register warnings on BXT since the registers for this
> > platform differ from older platforms.
> >
> >
On Wed, Jan 06, 2016 at 05:15:30PM -0800, Rodrigo Vivi wrote:
> The only missing gap compared to Skylake is the GuC
> because we don't have yet a GuC firmware image to publish.
>
> However with all other parts in place this is very similar to
> Skylake which is out of this procection.
>
> So I'm
On Thu, Jan 07, 2016 at 10:29:10AM +0200, Jani Nikula wrote:
> We still keep getting
>
> [4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control
> interrupt lied (SDE)!
>
> This reverts
>
> commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
> Author: Jani Nikula
> Date: Wed Nov
On Thu, 07 Jan 2016, Daniel Vetter wrote:
> On Thu, Jan 07, 2016 at 10:15:00AM +0200, Jani Nikula wrote:
>> On Wed, 06 Jan 2016, Matt Roper wrote:
>> > Our attempts save/restore panel power state in i915_suspend.c are
>> > causing unclaimed register warnings on BXT since the registers for this
>>
This is similar to the other drm_for_each_*_mask functions.
Changes since v1:
- Use for_each_if
Signed-off-by: Maarten Lankhorst
---
include/drm/drm_crtc.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index fd2ace4a18de..c0226f
This is useful for adding encoder_mask in crtc_state.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/drm_crtc.c | 23 +++
include/drm/drm_crtc.h | 1 +
2 files changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 62f
Another attempt at adding encoder_mask, with some behavioral fixes.
Maarten Lankhorst (5):
drm/core: Add drm_encoder_index.
drm/core: Add drm_for_each_encoder_mask, v2.
drm/i915: Do not touch best_encoder for load detect.
drm/atomic: Do not unset crtc when an encoder is stolen
drm/atomic
While we steal the encoder away from the connector the connector may
be updated to use a different encoder.
Without this change if 2 connectors swap encoders one of them will
end up without a crtc.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/drm_atomic_helper.c | 4
1 file changed
During startup, the driver creates a unique "intel_context" that will
provide a home for orphan requests (i.e. those generated by the driver
internally, not associated with user batchbuffers).
However, one of the infelicities of the current code is that the driver
keeps a per-engine pointer to the
Now that we've eliminated a lot of uses of ring->default_context,
we can eliminate the pointer itself.
All the engines share the same default intel_context, so we can just
keep a single reference to it in the dev_priv structure rather than one
in each of the engine[] elements. This make refcountin
> commit ac9b8236551d1177fd07b56aef9b565d1864420d
> Author: Ville Syrjälä
> Date: Fri Nov 27 18:55:26 2015 +0200
>
> drm/i915: Introduce a gmbus power domain
>
> gmbus also needs the power domain infrastructure right from the start,
> since as soon as we register the i2c controllers someon
This is duplicated with intel_check_cursor_plane, and with all
non-atomic paths removed this should be dead code.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/d
> > intel_setup_gmbus registers the i2c adapters, which does transfers on
> > the i2c bus on probe, and this happens before intel_power_domains_init
> > which initializes the power domain lock.
> >
> > The bisect and backtrace make sense and are not mysterious at all.
> >
> > Not sure of the fix th
Since
commit ac9b8236551d1177fd07b56aef9b565d1864420d
Author: Ville Syrjälä
Date: Fri Nov 27 18:55:26 2015 +0200
drm/i915: Introduce a gmbus power domain
gmbus also needs the power domain infrastructure right from the start,
since as soon as we register the i2c controllers someone can use
/drm-i915-Init-power-domains-early-in-driver-load/20160107-194542
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x007-01060743 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new
On Thu, Jan 07, 2016 at 10:20:50AM +, Dave Gordon wrote:
> There are a number of places where the driver needs a request, but isn't
> working on behalf of any specific user or in a specific context. At
> present, we associate them with the per-engine default context. A future
> patch will aboli
On Thu, 07 Jan 2016, Daniel Vetter wrote:
> Since
>
> commit ac9b8236551d1177fd07b56aef9b565d1864420d
> Author: Ville Syrjälä
> Date: Fri Nov 27 18:55:26 2015 +0200
>
> drm/i915: Introduce a gmbus power domain
>
> gmbus also needs the power domain infrastructure right from the start,
> sinc
On Thu, Jan 07, 2016 at 11:54:06AM +0100, Maarten Lankhorst wrote:
> Don't use plane->state directly, use the pointer from commit_plane.
>
> Changes since v1:
> - Fix uses of plane->state->rotation and color key to use the passed state
> too.
> - Only pass crtc_state and plane_state to update_pla
On Thu, Jan 07, 2016 at 11:54:08AM +0100, Maarten Lankhorst wrote:
> This is duplicated with intel_check_cursor_plane, and with all
> non-atomic paths removed this should be dead code.
>
> Signed-off-by: Maarten Lankhorst
I have some cursor stuff in a branch somewhere that does some of the
same,
On Thu, Jan 07, 2016 at 11:54:09AM +0100, Maarten Lankhorst wrote:
> Update cursor_bo and cursor_addr after being called.
cursor_bo no longer exists. My cursor stuff sitting in branch also gets
rid of cursor_addr, but until I land that we can go with this.
Reviewed-by: Ville Syrjälä
> This is r
On Thu, Jan 07, 2016 at 11:54:11AM +0100, Maarten Lankhorst wrote:
> Pass in the atomic states to allow for proper updates.
> This removes uses of intel_crtc->config and direct access
> to plane->state.
>
> This breaks the last bit of kgdboc, but that appears to be dead code.
>
> Signed-off-by: M
On Thu, Jan 07, 2016 at 11:54:12AM +0100, Maarten Lankhorst wrote:
> With sprites, cursors and primary planes taking the atomic state
> this is now unused. It's removed in a separate commit to allow
> a revert.
>
> Signed-off-by: Maarten Lankhorst
One less weird difference between the planes. Ya
Since
commit ac9b8236551d1177fd07b56aef9b565d1864420d
Author: Ville Syrjälä
Date: Fri Nov 27 18:55:26 2015 +0200
drm/i915: Introduce a gmbus power domain
gmbus also needs the power domain infrastructure right from the start,
since as soon as we register the i2c controllers someone can use
Since
commit ac9b8236551d1177fd07b56aef9b565d1864420d
Author: Ville Syrjälä
Date: Fri Nov 27 18:55:26 2015 +0200
drm/i915: Introduce a gmbus power domain
gmbus also needs the power domain infrastructure right from the start,
since as soon as we register the i2c controllers someone can use
On Thu, Jan 07, 2016 at 11:31:25AM +0200, Jani Nikula wrote:
> On Tue, 05 Jan 2016, Ville Syrjälä wrote:
> > On Mon, Dec 21, 2015 at 03:11:00PM +0200, Jani Nikula wrote:
> >> Add parsing of the i2c element, defined in MIPI sequence block v2. Drop
> >> the status operation byte while at it, that do
On Thu, Jan 07, 2016 at 03:06:13PM +0200, Jani Nikula wrote:
> On Thu, 07 Jan 2016, Dave Gordon wrote:
> > On 06/01/16 10:20, Patchwork wrote:
> >> == Summary ==
> >>
> >> Built on 24b053acb16b4b3b021575e4ee30ffedd3ab2920 drm-intel-nightly:
> >> 2016y-01m-06d-08h-16m-11s UTC integration manifest
On Mon, Dec 21, 2015 at 03:11:01PM +0200, Jani Nikula wrote:
> Properly parse the new sequences added in MIPI sequence block v2.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_bios.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.h
On Thu, Jan 07, 2016 at 11:40:22AM +0200, Jani Nikula wrote:
> On Thu, 07 Jan 2016, Daniel Vetter wrote:
> > On Thu, Jan 07, 2016 at 10:15:00AM +0200, Jani Nikula wrote:
> >> On Wed, 06 Jan 2016, Matt Roper wrote:
> >> > Our attempts save/restore panel power state in i915_suspend.c are
> >> > cau
On Wed, 16 Dec 2015, Yetunde Adebisi wrote:
> This patch adds support for eDP backlight control using DPCD registers to
> backlight hooks in intel_panel.
>
> It checks for backlight control over AUX channel capability and sets up
> function pointers to get and set the backlight brightness level if
On Thu, 07 Jan 2016, Ville Syrjälä wrote:
> On Mon, Dec 21, 2015 at 03:11:01PM +0200, Jani Nikula wrote:
>> Properly parse the new sequences added in MIPI sequence block v2.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/intel_bios.h | 3 +++
>> 1 file changed, 3 insertions(+)
On Mon, Dec 21, 2015 at 03:11:02PM +0200, Jani Nikula wrote:
> From: vkorjani
>
> New sequence element for i2c is been added in the
> mipi sequence block of the VBT. This patch parses
> and executes the i2c sequence.
>
> v2: Add i2c_put_adapter call(Jani), rebase
>
> v3: corrected the retry loo
On Mon, Dec 21, 2015 at 03:11:03PM +0200, Jani Nikula wrote:
> New sequences, new operations within sequences.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_bios.h | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i91
On 07/01/16 14:36, Daniel Vetter wrote:
On Thu, Jan 07, 2016 at 03:06:13PM +0200, Jani Nikula wrote:
On Thu, 07 Jan 2016, Dave Gordon wrote:
On 06/01/16 10:20, Patchwork wrote:
== Summary ==
Built on 24b053acb16b4b3b021575e4ee30ffedd3ab2920 drm-intel-nightly:
2016y-01m-06d-08h-16m-11s UTC i
This fixes reprobing of display connectors on resume. After some
talking with danvet on IRC, I learned that calling
drm_helper_hpd_irq_event() does actually trigger a full reprobe of each
connector's status. It turns out this is the actual reason reprobing on
resume hasn't been working (this was o
> commit ac9b8236551d1177fd07b56aef9b565d1864420d
> Author: Ville Syrjälä
> Date: Fri Nov 27 18:55:26 2015 +0200
>
> drm/i915: Introduce a gmbus power domain
>
> gmbus also needs the power domain infrastructure right from the start,
> since as soon as we register the i2c controllers someon
Hello,
On 2016-01-07 14:59, Daniel Vetter wrote:
On Tue, Jan 05, 2016 at 01:52:50PM +0100, Marek Szyprowski wrote:
This patch adds support for generic plane's zpos property property with
well-defined semantics:
- added zpos properties to drm core and plane state structures
- added helpers for n
From: Tvrtko Ursulin
No need to call ktime_get_raw_ns twice per unlimited wait and can
also elimate a local variable.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gem.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem
From: Tvrtko Ursulin
Just some random stuff, mostly execlists and tiny bit of wait request.
Spends a little bit fewer cycles in the hot paths, shrinks the source by a bit,
results with a little bit less .text, and polutes with Gen conditionals at
hot code paths a little bit less.
Tvrtko Ursulin
From: Tvrtko Ursulin
Same effect for slightly less source code and resulting binary.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_lrc.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/in
From: Tvrtko Ursulin
LRCA lifetime is well defined so cache it so it can be looked up
cheaply from the interrupt context and at command submission
time.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 15 ++
drivers/gpu/drm/i915/i915_drv.h | 1 +
driver
On Tue, Jan 05, 2016 at 11:18:55AM -0800, Rodrigo Vivi wrote:
> No functional changes.
>
> That state the obvious and just duplicate the place we
> need to change whenever the table is updated. So let's clean it.
>
> Cc: Ville Syrjälä
> Signed-off-by: Rodrigo Vivi
Reviewed-by: Ville Syrjälä
On Thu, Jan 07, 2016 at 04:36:20PM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> LRCA lifetime is well defined so cache it so it can be looked up
> cheaply from the interrupt context and at command submission
> time.
Or track the actual vma.
-Chris
--
Chris Wilson, Intel Open Source
On Thu, Jan 07, 2016 at 04:36:21PM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> No need to call ktime_get_raw_ns twice per unlimited wait and can
> also elimate a local variable.
>
> Signed-off-by: Tvrtko Ursulin
> ---
> drivers/gpu/drm/i915/i915_gem.c | 12 +++-
> 1 file ch
On Wed, Jan 06, 2016 at 10:26:41AM +0800, libin.y...@linux.intel.com wrote:
> From: Libin Yang
>
> For DP MST, use enc_to_mst(encoder)->primary to get intel_digital_port,
> instead of using enc_to_dig_port(encoder).
>
> Signed-off-by: Libin Yang
> ---
> drivers/gpu/drm/i915/intel_audio.c | 21
On Thu, Jan 07, 2016 at 08:49:38AM -0800, Jesse Barnes wrote:
> On 01/07/2016 03:58 AM, Chris Wilson wrote:
> > On Thu, Jan 07, 2016 at 10:20:50AM +, Dave Gordon wrote:
> >> There are a number of places where the driver needs a request, but isn't
> >> working on behalf of any specific user or i
On Thu, Jan 07, 2016 at 12:34:39PM +, Dave Gordon wrote:
> On 07/01/16 11:58, Chris Wilson wrote:
> >On Thu, Jan 07, 2016 at 10:20:50AM +, Dave Gordon wrote:
> >>There are a number of places where the driver needs a request, but isn't
> >>working on behalf of any specific user or in a speci
On 07/01/16 16:42, Chris Wilson wrote:
On Thu, Jan 07, 2016 at 04:36:18PM +, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
There is no need to check on what Gen we are running on every
interrupt and every command submission. We can instead set up
some of that when engines are initialized, st
On 07/01/16 16:45, Chris Wilson wrote:
On Thu, Jan 07, 2016 at 04:36:16PM +, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Same effect for slightly less source code and resulting binary.
How about last year's patch that removed 200 lines from this very code
in lrc?
If it is small enough
On 07/01/16 16:46, Chris Wilson wrote:
On Thu, Jan 07, 2016 at 04:36:20PM +, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
LRCA lifetime is well defined so cache it so it can be looked up
cheaply from the interrupt context and at command submission
time.
Or track the actual vma.
This loo
On Thu, Jan 07, 2016 at 05:58:39PM +0100, Daniel Vetter wrote:
> On Thu, Jan 07, 2016 at 06:56:35PM +0200, Ville Syrjälä wrote:
> > On Wed, Jan 06, 2016 at 08:57:57AM +0100, Daniel Vetter wrote:
> > > On Tue, Jan 05, 2016 at 05:18:40PM +0200, Ville Syrjälä wrote:
> > > > On Tue, Jan 05, 2016 at 03:
On 07/01/16 16:47, Chris Wilson wrote:
On Thu, Jan 07, 2016 at 04:36:21PM +, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
No need to call ktime_get_raw_ns twice per unlimited wait and can
also elimate a local variable.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gem.c |
> commit ac9b8236551d1177fd07b56aef9b565d1864420d
> Author: Ville Syrjälä
> Date: Fri Nov 27 18:55:26 2015 +0200
>
> drm/i915: Introduce a gmbus power domain
>
> gmbus also needs the power domain infrastructure right from the start,
> since as soon as we register the i2c controllers someon
On Wed, Jan 06, 2016 at 03:00:39PM +, Michel Thierry wrote:
> i915 validates that requested offset is in canonical form, so tests need
> to convert the offsets as required.
>
> Also add test to verify non-canonical 48-bit address will be rejected.
>
> v2: Use sign_extend64 for converting to c
Let's start using igt_debugfs_read helper so we
can change the debugfs interface at anytime.
Signed-off-by: Rodrigo Vivi
---
tests/kms_psr_sink_crc.c | 57 +++-
1 file changed, 8 insertions(+), 49 deletions(-)
diff --git a/tests/kms_psr_sink_crc.c b/t
This has been reviewed internally. LGTM.
Reviewed-by: Alex Dai
On 01/05/2016 08:17 AM, Lukasz Fiedorowicz wrote:
Test check GuC debugfs file for successful loading confirmation
Signed-off-by: Lukasz Fiedorowicz
---
tests/Makefile.sources | 1 +
tests/gem_guc_loading.c | 89 +
Hi Michel,
On Thu, 2016-01-07 at 16:14 +, Michel Thierry wrote:
> On 1/7/2016 1:15 AM, Rodrigo Vivi wrote:
> > When adding IS_KABYLAKE definition I didn't included the
> > DC states related because I was planing to include them
> > with the patch that fixes DMC firmware loading, but I
> > forg
When adding IS_KABYLAKE definition I didn't included the
DC states related because I was planing to include them
with the patch that fixes DMC firmware loading, but I
forgot them.
Meanwhile this runtime pm code changed a lot for
Skylake.
Well, I didn't expect that this would crash the machine
and
Daniel, Ack?
So I can merge this and the missing IS_KABYLAKE ones...
The preliminary one I agree with you and will put a request for KBL on CI.
Thanks in advance,
Rodrigo.
On Wed, Jan 6, 2016 at 5:15 PM Rodrigo Vivi wrote:
> From: "Boyer, Wayne"
>
> Extend the same reasoning as in the patch
Hi Ville,
> -Original Message-
> From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
> Sent: Friday, January 08, 2016 12:50 AM
> To: libin.y...@linux.intel.com
> Cc: intel-gfx@lists.freedesktop.org; conselv...@gmail.com;
> jani.nik...@linux.intel.com; Vetter, Daniel; ti...@suse.de;
On 1/7/2016 10:15 AM, Ville Syrjälä wrote:
On Mon, Dec 21, 2015 at 05:18:52PM -0800, abhay.ku...@intel.com wrote:
From: Abhay Kumar
Make resume/on codepath not to wait for panel_power_cycle_delay(t11_t12)
if this time is already spent in suspend/poweron time.
v2: Use CLOCK_BOOTTIME and remo
On Tue, Jan 05, 2016 at 05:17:07PM +0100, Lukasz Fiedorowicz wrote:
> Test check GuC debugfs file for successful loading confirmation
>
> Signed-off-by: Lukasz Fiedorowicz
What's the value of this testcase? What happens on a system without guc?
Seems more like a "is your system configured correc
69 matches
Mail list logo
