[Intel-gfx] [PATCH] drm/i915: restore ggtt double-bind avoidance

2015-10-15 Thread Daniel Vetter
This was accidentally lost in commit 75d04a3773ecee617847de963ae4195d6aa74c28 Author: Mika Kuoppala Date: Tue Apr 28 17:56:17 2015 +0300 drm/i915/gtt: Allocate va range only if vma is not bound While at it implement an improved version suggested by Chris which avoids the double-bind irres

[Intel-gfx] [PATCH i-g-t] tests: Add gem_exec_nop_concurrent test

2015-10-15 Thread Derek Morton
This test is based on gem_exec_nop but submits nop batch buffers concurrently from different threads to check for ring hangs and other issues during concurrent submissions. Signed-off-by: Derek Morton --- tests/.gitignore| 1 + tests/Makefile.sources | 1 + tests/gem

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-15 Thread Ville Syrjälä
On Wed, Oct 14, 2015 at 01:33:57PM -0700, Kevin Strasser wrote: > On Wed, Oct 14, 2015 at 10:48:52PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 14, 2015 at 11:59:59AM -0700, Kevin Strasser wrote: > [...] > > > Just to level set, these cases will produce different CRCs on HSW: > > > 1. Primary pla

Re: [Intel-gfx] [PATCH] drm/i915: restore ggtt double-bind avoidance

2015-10-15 Thread Chris Wilson
On Thu, Oct 15, 2015 at 09:37:31AM +0200, Daniel Vetter wrote: > This was accidentally lost in > > commit 75d04a3773ecee617847de963ae4195d6aa74c28 > Author: Mika Kuoppala > Date: Tue Apr 28 17:56:17 2015 +0300 > > drm/i915/gtt: Allocate va range only if vma is not bound > > While at it im

Re: [Intel-gfx] [RFCv2 DP-typeC 2/6] drm/i915/dp: Reuse shared DPLL if it exists already

2015-10-15 Thread R, Durgadoss
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Wednesday, October 14, 2015 6:53 PM >To: R, Durgadoss; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [RFCv2 DP-typeC 2/6] drm/i915/dp: Reuse shared DPLL >if it exists already > >On Wed, 14 Oct

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Don't pass plane+plane_state to intel_pin_and_fence_fb_obj()

2015-10-15 Thread Chris Wilson
On Wed, Oct 14, 2015 at 07:29:03PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_pin_and_fence_fb_obj() only needs the framebuffer, and the desird > rotation (to find the right GTT view for it), so no need to pass all > kinds of plane stuff. imho this is a mistep, I

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Don't pass plane+plane_state to intel_pin_and_fence_fb_obj()

2015-10-15 Thread Ville Syrjälä
On Thu, Oct 15, 2015 at 10:08:53AM +0100, Chris Wilson wrote: > On Wed, Oct 14, 2015 at 07:29:03PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > intel_pin_and_fence_fb_obj() only needs the framebuffer, and the desird > > rotation (to find the right GTT view for it),

[Intel-gfx] HD 4000 ubuntu 14.04 driver

2015-10-15 Thread Samy CHBINOU
Hello, I am new to this list. I work on an OpenCL project. I try to find support to setup the environment: to install the ubuntu driver for my i5-3230M HD 4000 to run OpenCL kernels on it I've already downloaded the Intel openCL SDK for linux but I dont know how to use it as the HD4000 is not r

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Don't pass plane+plane_state to intel_pin_and_fence_fb_obj()

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 12:36:43PM +0300, Ville Syrjälä wrote: > On Thu, Oct 15, 2015 at 10:08:53AM +0100, Chris Wilson wrote: > > On Wed, Oct 14, 2015 at 07:29:03PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > intel_pin_and_fence_fb_obj() only needs the

Re: [Intel-gfx] [PATCH] drm/i915: restore ggtt double-bind avoidance

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 09:48:26AM +0100, Chris Wilson wrote: > On Thu, Oct 15, 2015 at 09:37:31AM +0200, Daniel Vetter wrote: > > This was accidentally lost in > > > > commit 75d04a3773ecee617847de963ae4195d6aa74c28 > > Author: Mika Kuoppala > > Date: Tue Apr 28 17:56:17 2015 +0300 > > > >

[Intel-gfx] [PATCH] drm/i915: Split out aliasing-ppgtt from ggtt_bind_vma()

2015-10-15 Thread Chris Wilson
The presence of the aliasing-ppgtt (or rather its absence) causes some confusion on old generations where we still pretend that there is a difference between PIN_USER and PIN_GLOBAL even though we only have the global GTT. The confusion has resulted in a bug where we do not mark the vma as suitably

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Don't pass plane+plane_state to intel_pin_and_fence_fb_obj()

2015-10-15 Thread Tvrtko Ursulin
Hi, On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä intel_pin_and_fence_fb_obj() only needs the framebuffer, and the desird rotation (to find the right GTT view for it), so no need to pass all kinds of plane stuff. Signed-off-by: Ville Syrjälä --- drivers/gpu/d

Re: [Intel-gfx] [PATCH 12/22] drm/i915: Set i915_ggtt_view_normal type explicitly

2015-10-15 Thread Tvrtko Ursulin
Hi, On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Just for clarity set the type for i915_ggtt_view_normal explicitly. While at it fix the indentation fail for i915_ggtt_view_rotated. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ++

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Don't pass plane+plane_state to intel_pin_and_fence_fb_obj()

2015-10-15 Thread Ville Syrjälä
On Thu, Oct 15, 2015 at 12:10:32PM +0100, Tvrtko Ursulin wrote: > > Hi, > > On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > intel_pin_and_fence_fb_obj() only needs the framebuffer, and the desird > > rotation (to find the right GTT view for it), so no need

Re: [Intel-gfx] [PATCH 14/22] drm/i915: Don't treat differently sized rotated views as equal

2015-10-15 Thread Tvrtko Ursulin
On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä In case we have multiple different rotated views into the same object, each one may need its own vma due to being of different sizes. So don't treat all rotated views as equal. Signed-off-by: Ville Syrjälä --- driv

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Don't pass plane+plane_state to intel_pin_and_fence_fb_obj()

2015-10-15 Thread Tvrtko Ursulin
On 15/10/15 12:17, Ville Syrjälä wrote: On Thu, Oct 15, 2015 at 12:10:32PM +0100, Tvrtko Ursulin wrote: Hi, On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä intel_pin_and_fence_fb_obj() only needs the framebuffer, and the desird rotation (to find the right GTT vi

Re: [Intel-gfx] [PATCH 12/22] drm/i915: Set i915_ggtt_view_normal type explicitly

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 12:15:21PM +0100, Tvrtko Ursulin wrote: > > Hi, > > On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: > >From: Ville Syrjälä > > > >Just for clarity set the type for i915_ggtt_view_normal explicitly. > > > >While at it fix the indentation fail for i915_ggtt_view_rot

Re: [Intel-gfx] [PATCH 14/22] drm/i915: Don't treat differently sized rotated views as equal

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 12:18:41PM +0100, Tvrtko Ursulin wrote: > > On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: > >From: Ville Syrjälä > > > >In case we have multiple different rotated views into the same object, > >each one may need its own vma due to being of different sizes. So don

Re: [Intel-gfx] [PATCH 14/22] drm/i915: Don't treat differently sized rotated views as equal

2015-10-15 Thread Ville Syrjälä
On Thu, Oct 15, 2015 at 02:02:24PM +0200, Daniel Vetter wrote: > On Thu, Oct 15, 2015 at 12:18:41PM +0100, Tvrtko Ursulin wrote: > > > > On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: > > >From: Ville Syrjälä > > > > > >In case we have multiple different rotated views into the same objec

Re: [Intel-gfx] [PATCH 11/22] drm/i915: Don't pass plane+plane_state to intel_pin_and_fence_fb_obj()

2015-10-15 Thread Ville Syrjälä
On Thu, Oct 15, 2015 at 12:30:44PM +0100, Tvrtko Ursulin wrote: > > On 15/10/15 12:17, Ville Syrjälä wrote: > > On Thu, Oct 15, 2015 at 12:10:32PM +0100, Tvrtko Ursulin wrote: > >> > >> Hi, > >> > >> On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: > >>> From: Ville Syrjälä > >>> > >>> int

[Intel-gfx] [PATCH] drm/i915: restore ggtt double-bind avoidance

2015-10-15 Thread Daniel Vetter
This was accidentally lost in commit 75d04a3773ecee617847de963ae4195d6aa74c28 Author: Mika Kuoppala Date: Tue Apr 28 17:56:17 2015 +0300 drm/i915/gtt: Allocate va range only if vma is not bound While at it implement an improved version suggested by Chris which avoids the double-bind irres

[Intel-gfx] [drm-intel:topic/drm-misc 38/38] drivers/gpu/drm/vgem/vgem_drv.c:249:9: error: implicit declaration of function 'drm_vma_offset_exact_lookup'

2015-10-15 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc head: 0f3609e5b5c53ed52b8e82993cbda72806ef9c69 commit: 0f3609e5b5c53ed52b8e82993cbda72806ef9c69 [38/38] drm/gem: Use kref_get_unless_zero for the weak mmap references config: i386-randconfig-s0-201541 (attached as .config) reproduce:

Re: [Intel-gfx] [PATCH 14/22] drm/i915: Don't treat differently sized rotated views as equal

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 03:06:11PM +0300, Ville Syrjälä wrote: > On Thu, Oct 15, 2015 at 02:02:24PM +0200, Daniel Vetter wrote: > > On Thu, Oct 15, 2015 at 12:18:41PM +0100, Tvrtko Ursulin wrote: > > > > > > On 14/10/15 17:29, ville.syrj...@linux.intel.com wrote: > > > >From: Ville Syrjälä > > >

Re: [Intel-gfx] [PATCH v2] drm/i915/hsw: keep gamma and CSC enabled for primary plane disable

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 12:51 AM, Kevin Strasser wrote: > On HSW the crc differs between black and disabled primary planes, causing an > assert to fail in the kms_universal_plane test. It seems that gamma correction > and color space conversion are causing the black primary plane case to result

Re: [Intel-gfx] [PATCH] drm/i915: restore ggtt double-bind avoidance

2015-10-15 Thread Chris Wilson
On Thu, Oct 15, 2015 at 02:23:01PM +0200, Daniel Vetter wrote: > This was accidentally lost in > > commit 75d04a3773ecee617847de963ae4195d6aa74c28 > Author: Mika Kuoppala > Date: Tue Apr 28 17:56:17 2015 +0300 > > drm/i915/gtt: Allocate va range only if vma is not bound > > While at it im

Re: [Intel-gfx] [PATCH v2] drm/i915/hsw: keep gamma and CSC enabled for primary plane disable

2015-10-15 Thread Ville Syrjälä
On Thu, Oct 15, 2015 at 02:31:09PM +0200, Daniel Vetter wrote: > > On Thu, Oct 15, 2015 at 12:51 AM, Kevin Strasser > wrote: > > On HSW the crc differs between black and disabled primary planes, causing an > > assert to fail in the kms_universal_plane test. It seems that gamma > > correction >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/skl: Enable pipe gamma for sprite planes.

2015-10-15 Thread Ville Syrjälä
On Thu, Aug 27, 2015 at 01:46:30PM -0700, Bob Paauwe wrote: > Since SKL has universal planes, we should configure the sprite planes > and the primary plane the same. For the primary plane we do enable > the pipe gamma on the plane so do the same for the non-primary planes. > > Without this, the p

[Intel-gfx] [drm-intel:topic/drm-misc 35/38] drivers/gpu/drm/drm_gem_cma_helper.c:484:21: warning: unused variable 'dev'

2015-10-15 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc head: 0f3609e5b5c53ed52b8e82993cbda72806ef9c69 commit: 9da239e3b9538cd5dd883d8258a7c3e2e0499e13 [35/38] drm/gem: Drop struct_mutex requirement from drm_gem_mmap_obj config: arm-at91_dt_defconfig (attached as .config) reproduce:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl+: Enable pipe CSC on cursor planes. (v2)

2015-10-15 Thread Ville Syrjälä
On Mon, Aug 31, 2015 at 02:03:30PM -0700, Bob Paauwe wrote: > Extend this to SKL and BXT as it's needed for these platforms as well. > > v2: Change if condition to HAS_DDI() instead of listing each platform > Signed-off-by: Bob Paauwe > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file

[Intel-gfx] [PATCH 0/2] Introducing crtc_clock_get()

2015-10-15 Thread Vandana Kannan
The implementation of crtc_clock_get() will not work for BXT. The 2 patches in this series, cleans up the code related to crtc_clock_get() and includes implementation for BXT (DSI and otherwise). A patch to correct crtc_mode_get() for BXT DSI will follow shortly. Vandana Kannan (2): drm/i915: C

[Intel-gfx] [PATCH 1/2] drm/i915: Create crtc_clock_get function pointers

2015-10-15 Thread Vandana Kannan
There are separate functions i9xx_crtc_clock_get(), vlv_crtc_clock_get(), chv_crtc_clock_get(). instead of calling these using if-else, making func pointers. This will also be useful going forward when the implementation for BXT is done. Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915/i91

[Intel-gfx] [PATCH 2/2] drm/i915: Add crtc_clock_get for hsw, skl, bxt

2015-10-15 Thread Vandana Kannan
Reusing the ddi_clock_get functions for hsw, skl, bxt and creating a common crtc_clock_get function. for BXT, there is a difference in clock between DSI and DDI. Taking care of this as well. Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915/intel_display.c | 43 +

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl+: Enable pipe CSC on cursor planes. (v2)

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 03:49:44PM +0300, Ville Syrjälä wrote: > On Mon, Aug 31, 2015 at 02:03:30PM -0700, Bob Paauwe wrote: > > Extend this to SKL and BXT as it's needed for these platforms as well. > > > > v2: Change if condition to HAS_DDI() instead of listing each platform > > Signed-off-by: B

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Create crtc_clock_get function pointers

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 06:52:48PM +0530, Vandana Kannan wrote: > There are separate functions i9xx_crtc_clock_get(), vlv_crtc_clock_get(), > chv_crtc_clock_get(). instead of calling these using if-else, making > func pointers. This will also be useful going forward when the implementation > for BX

[Intel-gfx] [drm-intel:topic/drm-misc 35/37] drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c:143:21: error: unused variable 'dev'

2015-10-15 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc head: 1032f72564813b1dd00184897d8291ad71676a56 commit: 9da239e3b9538cd5dd883d8258a7c3e2e0499e13 [35/37] drm/gem: Drop struct_mutex requirement from drm_gem_mmap_obj config: arm-allmodconfig (attached as .config) reproduce: wg

[Intel-gfx] [PATCH] drm/i915: skl_update_scaler() wants a rotation bitmask instead of bit number

2015-10-15 Thread ville . syrjala
From: Ville Syrjälä Pass BIT(DRM_ROTATE_0) instead of DRM_ROTATE_0 to skl_update_scaler(). The former is a mask, the latter just the bit number. Fortunately the only thing skl_update_scaler() does with the rotation is check if it's 90/270 degrees or not, and so in this case it would still do the

[Intel-gfx] [PATCH] drm/i915: Kill the leftover RMW from ivb_sprite_disable()

2015-10-15 Thread ville . syrjala
From: Ville Syrjälä We still had one lingering RMW in ivb_sprite_disable(), all the other RMWs were killed off from the sprite code some time ago. Kill the straggler too. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH i-g-t v2] tests/core_prop_blob: Fix core_prop_blob for android

2015-10-15 Thread Thomas Wood
On 14 October 2015 at 17:23, Derek Morton wrote: > core_prop_blob was using ioctls not in the android kernel. Added a > igt_require_propblob() function and local defines/structures so the > test will compile and skip on kernels where the feature is unsupported. > > v2: moved igt_require_propblob()

Re: [Intel-gfx] [PATCH] drm/i915: Kill the leftover RMW from ivb_sprite_disable()

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 05:04:04PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We still had one lingering RMW in ivb_sprite_disable(), all the other > RMWs were killed off from the sprite code some time ago. Kill the > straggler too. > > Signed-off-by: Ville Syrjälä Q

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915: Fix failure paths around initial fbdev allocation

2015-10-15 Thread Lukas Wunner
Hi Ville, On Tue, Oct 13, 2015 at 06:04:40PM +0300, Ville Syrjälä wrote: > On Tue, Jun 30, 2015 at 10:06:27AM +0100, Lukas Wunner wrote: > > From: Tvrtko Ursulin > > > > We had two failure modes here: > > > > 1. > > Deadlock in intelfb_alloc failure path where it calls > > drm_framebuffer_remov

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915: Fix failure paths around initial fbdev allocation

2015-10-15 Thread Daniel Vetter
On Thu, Oct 15, 2015 at 07:14:35PM +0200, Lukas Wunner wrote: > Hi Ville, > > On Tue, Oct 13, 2015 at 06:04:40PM +0300, Ville Syrjälä wrote: > > On Tue, Jun 30, 2015 at 10:06:27AM +0100, Lukas Wunner wrote: > > > From: Tvrtko Ursulin > > > > > > We had two failure modes here: > > > > > > 1. > >

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915: Fix failure paths around initial fbdev allocation

2015-10-15 Thread Ville Syrjälä
On Thu, Oct 15, 2015 at 07:14:35PM +0200, Lukas Wunner wrote: > Hi Ville, > > On Tue, Oct 13, 2015 at 06:04:40PM +0300, Ville Syrjälä wrote: > > On Tue, Jun 30, 2015 at 10:06:27AM +0100, Lukas Wunner wrote: > > > From: Tvrtko Ursulin > > > > > > We had two failure modes here: > > > > > > 1. > >

[Intel-gfx] [PATCH v2 21/22] drm/i915: Rewrite fb rotation GTT handling

2015-10-15 Thread ville . syrjala
From: Ville Syrjälä Redo the fb rotation handling in order to: - eliminate the NV12 special casing - handle fb->offsets[] properly - make the rotation handling reasier for the plane code To achieve these goals we reduce intel_rotation_info to only contain (for each plane) the rotated view width,

[Intel-gfx] [PATCH] drm/i915/skl: Eliminate usage of pipe_wm_parameters from SKL-style WM (v4)

2015-10-15 Thread Matt Roper
Just pull the info out of the state structures rather than staging it in an additional set of structures. To make this more straightforward, we change the signature of several internal WM functions to take the crtc state as a parameter. v2: - Don't forget to skip cursor planes on a loop in the D

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-15 Thread Kevin Strasser
On Thu, Oct 15, 2015 at 11:20:59AM +0300, Ville Syrjälä wrote: > On Wed, Oct 14, 2015 at 01:33:57PM -0700, Kevin Strasser wrote: > > On Wed, Oct 14, 2015 at 10:48:52PM +0300, Ville Syrjälä wrote: > > > Does it? I just tried it on IVB, and behaves just like you said. So not > > > sure how far back t

[Intel-gfx] [PATCH igt] kms_cursor_crc: Add test for unthrottled cursor movement

2015-10-15 Thread Matt Roper
We've had bugs in the past that caused cursor updates to be synced to vblank, resulting in sluggish cursor movement. Add a test to try to make sure we don't regress and reintroduce these bugs. Cc: kalyan.kondapa...@intel.com Signed-off-by: Matt Roper --- tests/kms_cursor_crc.c | 42 +++

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-15 Thread Ville Syrjälä
On Thu, Oct 15, 2015 at 04:00:48PM -0700, Kevin Strasser wrote: > On Thu, Oct 15, 2015 at 11:20:59AM +0300, Ville Syrjälä wrote: > > On Wed, Oct 14, 2015 at 01:33:57PM -0700, Kevin Strasser wrote: > > > On Wed, Oct 14, 2015 at 10:48:52PM +0300, Ville Syrjälä wrote: > > > > Does it? I just tried it

Re: [Intel-gfx] [PATCH] igt/kms_addfb_basic: New subtest to check for fb modifier and tiling mode mismatch

2015-10-15 Thread Vivek Kasireddy
Hi Tvrtko, On Fri, 9 Oct 2015 09:34:25 +0100 Tvrtko Ursulin wrote: > > > On 08/10/15 09:55, Tvrtko Ursulin wrote: > > On 07/10/15 22:07, Vivek Kasireddy wrote: > >> > >> Hi Tvrtko, > >> > >> On Wed, 7 Oct 2015 15:07:30 +0100 > >> Tvrtko Ursulin wrote: > >> > >>> > >>> Hi, > >>> > >>> On 07/10

[Intel-gfx] [PULL] drm-intel-fixes

2015-10-15 Thread Jani Nikula
Hi Dave - i915 fixes for v4.3. The revert dance could use some explanation: we had stuff fixed in -next, and initially backported one commit to v4.3. Now, turns out we need more fixes, and we could cherry-pick them all without conflicts if we reverted the backported one first. So did that to not